working/Evergreen.git
8 years agoStage 2: Staff Client
Thomas Berezansky [Fri, 10 Aug 2012 14:44:47 +0000 (10:44 -0400)]
Stage 2: Staff Client

Robustify the oils protocol:

1 - In the event of a problem URL, abort with about:blank.

This prevents a segfault!

2 - In the event of the TPac, or KPac, wrap the channel we return.

The wrapper helps with redirects, but if applied to XMLHttpRequests will
cause full breakage.

Without the wrapper redirects end up setting URLs to https://host/...

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoStage 1: Perl
Thomas Berezansky [Wed, 8 Aug 2012 00:15:24 +0000 (20:15 -0400)]
Stage 1: Perl

Attempt to ensure that we always write to oils://remote when needed.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTrying to update patron CSS color fails here, so don't try
Lebbeous Fogle-Weekley [Thu, 26 Jul 2012 20:45:24 +0000 (16:45 -0400)]
Trying to update patron CSS color fails here, so don't try

After modifying user standing penalties ("messages" in the staff client
patron interface), you could get this error message in an alert() dialog:
    TypeError: patron.display is undefined.

We were apparently trying to use patron.util.set_patron_css() wrongly,
so the commented out changed verison of the call got farther, but stopped at
    ...penalties[i].standing_penalty().name is not a function.

Which probably has something to do with unfleshed data.  Somebody can
get to the bottom of this if they want, but for now it's easier just not
to try to do this and make the alert() dialog go away.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoCheck for filled hold on transit checkin
Thomas Berezansky [Tue, 31 Jul 2012 19:35:21 +0000 (15:35 -0400)]
Check for filled hold on transit checkin

"Fill related hold" can grab a hold out from under a transit, so check for
filled holds in addition to canceled ones.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoSuperCat fixes - Child Init
Thomas Berezansky [Tue, 10 Apr 2012 13:10:46 +0000 (09:10 -0400)]
SuperCat fixes - Child Init

Sometimes it seems that child_init has not run properly for supercat.

This attempts to fix that by checking for the global appsession objects. If
they are not there we run child_init. The function that does this is being
called from all handler entry functions.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoSilence warnings in search results for holdable copies
Dan Scott [Sat, 4 Aug 2012 15:04:17 +0000 (11:04 -0400)]
Silence warnings in search results for holdable copies

Have not yet determined the exact reason the holdable copies size is not
defined in some instances in the search results only, but this commit
prevents warnings from being spewed by apache about undefined variables.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoTPAC: Silence two uninit variable warnings
Dan Scott [Sat, 4 Aug 2012 14:43:31 +0000 (10:43 -0400)]
TPAC: Silence two uninit variable warnings

These warnings were being thrown on every TPAC page request, slowly
filling the logs:

Use of uninitialized value $set_locale in string eq at
/usr/local/share/perl/5.10.1/OpenILS/WWW/EGWeb.pm line 159.

Use of uninitialized value in pattern match (m//) at
/usr/local/share/perl/5.10.1/OpenILS/WWW/EGCatLoader.pm line 250.

Banish them.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoTPAC: Give login boxes a border
Dan Scott [Mon, 13 Aug 2012 17:53:22 +0000 (13:53 -0400)]
TPAC: Give login boxes a border

For some reason, the boxes for the login form were stripped of
their default border style. Let the natural input box formatting for the
border shine through and give users an easier target when logging in.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoTPAC - Fix footer on hold history page
Ben Shum [Mon, 6 Aug 2012 15:11:54 +0000 (11:11 -0400)]
TPAC - Fix footer on hold history page

The hold history page was missing an ending div tag to complete the
block which leads to the footer being generated incorrectly on that
page.

Adding the ending tag repairs the display of the footer to match all
the other pages.

Credit to Melissa Lefebvre for noticing this discrepancy.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoChange grammar for lost and missing failure messages
Melissa Lefebvre [Tue, 14 Aug 2012 16:58:18 +0000 (12:58 -0400)]
Change grammar for lost and missing failure messages

Update to the lost and missing failure wording to make it
gramatically correct.  Removed the word "has" from both
messages.

Signed-off-by: Melissa Lefebvre <mlefebvre@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoPhysical Location Fixes/Enhancements
Thomas Berezansky [Tue, 14 Aug 2012 14:50:11 +0000 (10:50 -0400)]
Physical Location Fixes/Enhancements

Teach the physical location retrieval function about using an ENV var.

This allows a subdomain to force a specific physical location, say by adding
to their apache config:

SetEnv physical_loc 4

Rewriterules could also be used for more dynamic configuration.

Also, as a fix:

Have preferred library use the stored physical location instead of assuming
that CGI has the setting all the time.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoTPAC - fix pickup locations for edit holds
Ben Shum [Tue, 7 Aug 2012 17:48:31 +0000 (13:48 -0400)]
TPAC - fix pickup locations for edit holds

When a patron goes to edit a hold in TPAC, they have the option to
choose a different pickup location. Unfortunately, it looks like that
dropdown does not prevent them from selecting locations that aren't
normally allowed for pickups, such as system groups or consortium
itself.

This patch adds a check for 'can_have_vols_only' to the edit holds
screen.

Credit to Melissa Lefebvre for finally nailing down the source of
the issue.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoDefault to current fiscal year in ACQ order upload
Bill Erickson [Fri, 10 Aug 2012 18:59:50 +0000 (14:59 -0400)]
Default to current fiscal year in ACQ order upload

* Adds a new API call to determine the current fiscal year for a given
  org unit:  open-ils.acq.org_unit.current_fiscal_year

* Use open-ils.acq.org_unit.current_fiscal_year to populate the correct
  fiscal year in the ACQ order upload selector.

This addresses part 2 of LP 1031927

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoEnable pcrud access to fiscal year / fiscal calendar
Bill Erickson [Fri, 10 Aug 2012 18:59:29 +0000 (14:59 -0400)]
Enable pcrud access to fiscal year / fiscal calendar

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoFiscal year selector in ACQ order record upload
Bill Erickson [Fri, 10 Aug 2012 18:06:36 +0000 (14:06 -0400)]
Fiscal year selector in ACQ order record upload

* Support a 'fiscal_year' parameter to ACQ order record upload API.
* Adds a new "Fiscal Year" selector to the upload form to facilitate
  uploading orders to different fiscal years.

This partially resolves LP 1031927 by allowing manual selection of the
correct fiscal year.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoChange "Reset form" to "Clear Form"
Ben Shum [Mon, 13 Aug 2012 22:08:53 +0000 (18:08 -0400)]
Change "Reset form" to "Clear Form"

As suggested by Thomas Berezansky in the comments on LP 994058, change
the button from "Reset form" to "Clear form" to be absolutely clear
that the button now removes all previous search variables.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPAC: Reset Form and New Search should clear queries
Dan Scott [Wed, 8 Aug 2012 19:08:24 +0000 (15:08 -0400)]
TPAC: Reset Form and New Search should clear queries

Currently, clicking "Another Search" in the search results page, or
"Reset Form" on the advanced search page, keeps the same query terms and
type around. Clear these parameters as expected; essentially, we keep
only the search location (loc or locg) in scope.

Note that we explicitly keep parameters around when someone is going
from a basic search to an advanced search, because the assumption is
that they want to refine their search further.

Also affected are the org_selector, because we want to pull the logic
for loc or locg out into a common area (the get_library block in
misc_util.tt2), and the style (input.opac-button elements now get styled
the same as a.opac-button elements, which makes it easier to intermingle
them on the same form).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoTPAC - add library scoping to shelf browser user/dbs/lp973618_cnbrowse_scope
Ben Shum [Sun, 12 Aug 2012 07:25:49 +0000 (03:25 -0400)]
TPAC - add library scoping to shelf browser

The shelf browser currently uses the 'loc' variable to define scoping and
limit browsing to specific org units. However, since much of the scoping
actually uses 'locg', the scoping was broken for the shelf browser.

Additionally, under Advanced Search's Numeric Search, the option for
'Call Number (Shelf Browse)' only applies the 'cn' variable to searches
and never adds the search scope, despite the search library now being
an available filter choice.

Based on suggestion by Dan Scott in IRC, this patch uses the function for
_get_search_lib() to retrieve the search library and add it to both parts
of the shelf browser.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoMake opac/results.tt2 remember facet when sorting, etc.
Jason Stephenson [Wed, 25 Jul 2012 17:43:38 +0000 (13:43 -0400)]
Make opac/results.tt2 remember facet when sorting, etc.

Add a hidden field in the search form and set its value to the value
of the CGI 'facet' param if the facet parameter is set.  This appears
to work for multiple facets.  Clearing a facet is as simple as clicking
on the gray-backgounded facet name.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPAC - fix alignment of "You are now browsing..." in shelf browser
Ben Shum [Thu, 9 Aug 2012 16:27:57 +0000 (12:27 -0400)]
TPAC - fix alignment of "You are now browsing..." in shelf browser

The "You are now browsing..." message does not align to the center of the
page. Changing the <div> to a <p> seems to properly align the text.

Along the way, we should remove the extra <span> and <strong> (the strong
is redundant with the css being inherited by color_4 class) and make the
new single line message more i18n-friendly for future translations.

Credit to Michael Peters for noticing the problem and thanks to Dan Scott,
Lebbeous Fogle-Weekley, and Thomas Berezansky for help via IRC for the
i18n-bits.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoFix TPAC shelf browser's previous link
Thomas Berezansky [Sun, 12 Aug 2012 19:16:01 +0000 (15:16 -0400)]
Fix TPAC shelf browser's previous link

Line fix suggested by Thomas Berezansky.

The cnoffset was strictly checking for values that start with a digit.
But negative numbers start with a "-" instead. Once this check was
changed, the previous link will continue to move further into negative
offsets.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoDocumentation: Fix some issues which caused a2x epub processing to choke.
Robert Soulliere [Fri, 10 Aug 2012 17:03:58 +0000 (13:03 -0400)]
Documentation: Fix some issues which caused a2x epub processing to choke.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoDocumentation: add a missing image.
Robert Soulliere [Fri, 10 Aug 2012 16:24:13 +0000 (12:24 -0400)]
Documentation: add a missing image.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoDocumentation: remove line break characters from file.
Robert Soulliere [Fri, 10 Aug 2012 14:04:59 +0000 (10:04 -0400)]
Documentation: remove line break characters from file.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoDocumentation: Add kids catalog documentation from ESI site.
Sally Fortin [Fri, 10 Aug 2012 13:59:04 +0000 (09:59 -0400)]
Documentation: Add kids catalog documentation from ESI site.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoAuthorities: Fix broken UI due to new XUL/Dojo/regressions
Dan Scott [Thu, 9 Aug 2012 22:25:00 +0000 (18:25 -0400)]
Authorities: Fix broken UI due to new XUL/Dojo/regressions

New versions of XUL, since Firefox 10, hate dojo.query("foo bar"), so we
have to refactor it to use dojo.query("foo").query("bar") instead. At
least until we upgrade to a new version of Dojo.

In addition, 522d8d82 introduced a regression meaning that the text of
the authorities was no longer wrapped in a SPAN element with a class of
"text". That in turn meant that the Dojo queries weren't picking up the
labels for the merge box, leaving no visual indication to the user as to
what authorities exactly were being merged. So, repair that.

Also, similar to a fix for the MFHD editor, set the initial height of
the spawned MARC Editor for an authority record to something reasonable.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoDocumentation: Update upgrade instruction to 2.3.beta1 and include all docs that...
Robert Soulliere [Thu, 9 Aug 2012 19:17:48 +0000 (15:17 -0400)]
Documentation: Update upgrade instruction to 2.3.beta1 and include all docs that were in 2.2.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoSet a sane initial MFHD Editor size
Dan Scott [Thu, 9 Aug 2012 20:31:44 +0000 (16:31 -0400)]
Set a sane initial MFHD Editor size

For most MFHD records, the size of the MARC Editor window when spawned
fits into the confines of a normal desktop. However, for MFHD records
with dozens or more rows, the window chrome can be inaccessible because
it is bumped off the top of the Windows desktop. This makes it
impossible for users to close the window without a workaround like
hitting ALT+F4

This branch sets the window to an initial height of 40 pixels less than
the height of the entire staff client window. This should be enough to
enable the chrome on top to be visible. In addition, we have to set the
width to something reasonable because XUL seems to otherwise set the
window to be extremely skinny once an explicit height is set, so we set
that to be half the width of the staff client window.

Finally, we allow the new window to be resizable according to the user's
preference.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoSimplified Hold Pull List: Fix several sorting bugs
Lebbeous Fogle-Weekley [Wed, 8 Aug 2012 17:50:33 +0000 (13:50 -0400)]
Simplified Hold Pull List: Fix several sorting bugs

First of all, sorting on most columns was broken due to a bug in the way
that the flattener methods of the open-ils.fielder service were
constructing their SQL JOINs.  We were coming up with way too many
joins, and then losing track of which JOIN's alias to refer to when
building the ORDER BY clause later.  This is fixed.

Secondly, the shelving location column now sorts automatically by the
shelving location *ordering* values, when avaiable.  These are the
values that you set up in the drag-and-drop staff client interface
titled "Copy Location Order."  When these values are not set for the org
unit whose pull list you're viewing, the sorting will fall back to
alphabetical.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoDocumentation: Remove a space causing an error during PDF processing.
Robert Soulliere [Wed, 8 Aug 2012 14:45:33 +0000 (10:45 -0400)]
Documentation: Remove a space causing an error during PDF processing.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoTPAC: Remove explicit width on "View my list" button
Dan Scott [Sat, 4 Aug 2012 15:24:15 +0000 (11:24 -0400)]
TPAC: Remove explicit width on "View my list" button

.cached_list_div, which defines the style for the "View my list" button
on the TPAC button bar once an item has been added to a temporary list,
is given an explicit width of 111px, which is problematic for a number
of reasons:

1. If the font-size of the base style is increased, then the text will
   likely wrap.
2. Translations tend to be longer than English, and indeed in fr-CA
   "Afficher ma liste" ends up wrapping onto a second line, which makes
   the button bar look weird.

Accordingly, remove the explicit "width:111px" from the style definition
for .cached_list_div.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoRemove extra xulG redefines
Thomas Berezansky [Tue, 7 Aug 2012 18:29:37 +0000 (14:29 -0400)]
Remove extra xulG redefines

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoFix timestamp typo
Thomas Berezansky [Tue, 7 Aug 2012 18:19:56 +0000 (14:19 -0400)]
Fix timestamp typo

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoRedirect to OILS in staff client
Thomas Berezansky [Mon, 6 Aug 2012 16:48:19 +0000 (12:48 -0400)]
Redirect to OILS in staff client

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoAdd dependencies for Fedora
Dan Scott [Fri, 3 Aug 2012 14:59:33 +0000 (10:59 -0400)]
Add dependencies for Fedora

Noted by Net Wolf on the mailing list, some core dependencies were
missing from the Fedora Makefile.install installer. As some of them have
recently been packaged for Fedora 17, add them to the package
collection; others are still unpackaged, so leave them there.

Note: the packages are not available on Fedora 16, but that has a
limited remaining shelf life anyway, so consider this a shift to
supporting only the latest stable version of Fedora.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoImport updated translations from Launchpad; stage 2
Bill Erickson [Fri, 3 Aug 2012 14:02:29 +0000 (10:02 -0400)]
Import updated translations from Launchpad; stage 2

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoImport updated translations from Launchpad; stage 1
Bill Erickson [Fri, 3 Aug 2012 14:00:54 +0000 (10:00 -0400)]
Import updated translations from Launchpad; stage 1

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoInitial cut of 2.3 release notes.
Bill Erickson [Thu, 2 Aug 2012 16:12:49 +0000 (12:12 -0400)]
Initial cut of 2.3 release notes.

Basically, the contents of RELEASE_NOTES_NEXT organized into
RELEASE_NOTES_2_3.txt and removed from RELEASE_NOTE_NEXT.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoAdd simple README to RELEASE_NOTE_NEXT
Bill Erickson [Thu, 2 Aug 2012 16:09:42 +0000 (12:09 -0400)]
Add simple README to RELEASE_NOTE_NEXT

Without something in the directory, it will dissappear each time we
create release notes from the contents and delete them, since Git
removes empty directories.  That would likely just lead to confusion.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoDocumentation: adjust documentation for 2_3 release.
Robert Soulliere [Fri, 3 Aug 2012 13:21:18 +0000 (09:21 -0400)]
Documentation: adjust documentation for 2_3 release.

Comment out chapters in root.txt except for basic documentation.
Update upgrade instructions for the 2.3 alpha2 release.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoAdd basic release notes for 2.2.1. Not as thorough as notes at major release.
Lebbeous Fogle-Weekley [Fri, 3 Aug 2012 01:37:10 +0000 (21:37 -0400)]
Add basic release notes for 2.2.1.  Not as thorough as notes at major release.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoRepairing upgrade stamp number
Bill Erickson [Thu, 2 Aug 2012 15:35:05 +0000 (11:35 -0400)]
Repairing upgrade stamp number

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoDocumentation: Add Staff account management chapter.
Robert Soulliere [Thu, 2 Aug 2012 14:34:44 +0000 (10:34 -0400)]
Documentation: Add Staff account management chapter.

Converted from 1.6 documentation. Reviewed by Jennifer Turner.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoFix up whitespace in a couple of SIP modules
Dan Scott [Thu, 2 Aug 2012 03:05:58 +0000 (23:05 -0400)]
Fix up whitespace in a couple of SIP modules

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoAdd SIP support for Fine Items field
Jeff Godin [Tue, 19 Jun 2012 19:31:08 +0000 (15:31 -0400)]
Add SIP support for Fine Items field

Add support for SIP Fine Items, msg 64 field AV.

Display outstanding balance, last_billing_type, and a description.

For circulation xacts, description is title / author from MODS.

For grocery xacts, description is last_billing_note.

Wishlist LP 1012328

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoPass authtoken to OpenILS::SIP::Patron objects
Jeff Godin [Tue, 19 Jun 2012 19:10:07 +0000 (15:10 -0400)]
Pass authtoken to OpenILS::SIP::Patron objects

To support retrieval of billing details, OpenILS::SIP::Patron
objects need an auth token.

Teach OpenILS::SIP->find_patron to pass patron objects an auth
token, and also move existing "find patron by what key: barcode or
database id?" logic into find_patron (and out of
OpenILS::SIP::Patron->new).

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoWrap upgrade script for search filter group admin UI
Dan Scott [Wed, 1 Aug 2012 21:33:48 +0000 (17:33 -0400)]
Wrap upgrade script for search filter group admin UI

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoSearch filter group doc repair
Bill Erickson [Wed, 25 Jul 2012 13:43:43 +0000 (09:43 -0400)]
Search filter group doc repair

Change the example in the docs to have correct syntax:

filter_group=reading_level becomes filter_group='reading_level'

Thanks to kmlussier for pointing this out.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoAdd missing search filter group view/admin perm
Bill Erickson [Thu, 31 May 2012 14:06:17 +0000 (10:06 -0400)]
Add missing search filter group view/admin perm

ADMIN_SEARCH_FILTER_GROUP
VIEW_SEARCH_FILTER_GROUP

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoSearch filter groups release notes
Bill Erickson [Thu, 31 May 2012 13:27:40 +0000 (09:27 -0400)]
Search filter groups release notes

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoSearch filter groups admin UI staff menu entry
Bill Erickson [Thu, 31 May 2012 13:37:58 +0000 (09:37 -0400)]
Search filter groups admin UI staff menu entry

Admin -> Local Administration -> Search Filter Groups

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoSearch filter groups admin UI / API
Bill Erickson [Fri, 25 May 2012 13:22:36 +0000 (09:22 -0400)]
Search filter groups admin UI / API

UI for managing search filter groups and group entries.

This inclues a new API call for performing CRUD actions on filter
group entries:

open-ils.actor.filter_group_entry.crud

This new API call was necessary because entries link to
actor.search_query's, whose write access cannot be controled by pcrud.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoAdd WEBDIR to Open-ILS/xul/staff_client/Makefile.am.
Jason Stephenson [Wed, 25 Apr 2012 19:06:38 +0000 (15:06 -0400)]
Add WEBDIR to Open-ILS/xul/staff_client/Makefile.am.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoFix place hold hiding logic
Thomas Berezansky [Wed, 1 Aug 2012 20:40:51 +0000 (16:40 -0400)]
Fix place hold hiding logic

Always show the place hold link for staff with permission to place holds
that won't fill currently.

Otherwise, only show the link if:
There are holdable copies
AND
We aren't blocking OR there are no available copies

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPAC: Wrap "holdable copies" upgrade script
Dan Scott [Wed, 1 Aug 2012 20:54:32 +0000 (16:54 -0400)]
TPAC: Wrap "holdable copies" upgrade script

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoBlock "Place Hold" link in TPAC if item is available
Art Rhyno [Fri, 27 Jul 2012 15:39:14 +0000 (11:39 -0400)]
Block "Place Hold" link in TPAC if item is available

Suppress the display of the "Place Hold" link based on whether an item
is available. This is set as a preference in config.tt2. Some sites
may want the ability to place holds regardless of availability.

Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Conflicts:
Open-ILS/src/templates/opac/parts/record/summary.tt2
Open-ILS/src/templates/opac/parts/result/table.tt2

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPac: Hide place hold links when not holdable
Thomas Berezansky [Wed, 18 Apr 2012 21:03:05 +0000 (17:03 -0400)]
TPac: Hide place hold links when not holdable

The only check done is on the holdable flags:
Copy
Status
Location

Hold rules themselves are not checked.

Note that place hold links are shown either way when you can have the
PLACE_UNFILLABLE_HOLD permission and are logged into the staff client.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoOperator Change Fun
Thomas Berezansky [Thu, 12 Apr 2012 14:23:12 +0000 (10:23 -0400)]
Operator Change Fun

Allow for temporary, staff, and permanent operator changes.

Temporary uses a temp authtoken for a few minute timeout.

Staff uses a normal staff login authtoken for a multi-hour timeout.

Permanent is a staff change that disregards the previous login instead of
allowing it to be recovered by using the menu item again.

I also fixed things up so later timeouts can re-use the previous duration
and fixed up some title bar issues:

1 - Login screen shows version again (needed a document in the title set)
2 - Menu windows don't forget the server name
3 - Menu windows keep the same number for their lifetime

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoRip modal_xulG_stack out, replace with openDialog
Thomas Berezansky [Wed, 11 Apr 2012 23:53:48 +0000 (19:53 -0400)]
Rip modal_xulG_stack out, replace with openDialog

This converts the util/window.js open function to a wrapper around the
openDialog function and passes xulG in that way, as well as teaches
global_util.js to look for it having been passed in via the arguments
parameter on window.

The non-modal "push it into place" is still done as well, in case some
window isn't using global_util.js and needs xulG.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoStamping upgrade script for JEDI with Copies
Mike Rylander [Wed, 1 Aug 2012 19:17:59 +0000 (15:17 -0400)]
Stamping upgrade script for JEDI with Copies

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoEDI ORDER template, now with copies
Bill Erickson [Fri, 27 Jul 2012 16:11:23 +0000 (12:11 -0400)]
EDI ORDER template, now with copies

Adds a new "copies" structure to the stock JEDI ORDER template.  Copies
are ultimately mapped into one or more GIR segments in the outbound EDI.
This commit only adds the change to the stock template (seed data).  It
also adds entries to the environment for the stock template and existing
template 23 via upgrade script (to expedite local template editing).

With the current template, GIR segments look like so:

GIR+001+8:LCO+TESTFUND2:LFN+SYS1-BR1:LLO+FIC ROW 456:LSM+Stacks:LSQ'
GIR+002+9:LCO+TESTFUND2:LFN+SYS1-BR1:LLO+FIC ROW 456:LSM+Stacks:LSQ'
GIR+003+10:LCO+TESTFUND2:LFN+SYS1-BR1:LLO+FIC ROW 456:LSM+Stacks:LSQ'
GIR+004+11:LCO+TESTFUND2:LFN+SYS1-BR1:LLO+FIC ROW 456:LSM+Stacks:LSQ'
GIR+005+12:LCO+TESTFUND2:LFN+SYS1-BR1:LLO+FIC ROW 456:LSM+Stacks:LSQ'
GIR+006+13:LCO+TESTFUND2:LFN+SYS1-BR2:LLO+FIC ROW 456:LSM+Young Adult:LSQ'
GIR+007+14:LCO+TESTFUND2:LFN+SYS1-BR2:LLO+FIC ROW 456:LSM+Young Adult:LSQ'
GIR+008+15:LCO+TESTFUND2:LFN+SYS1-BR2:LLO+FIC ROW 456:LSM+Young Adult:LSQ'

LQT / quantity is also supported.

The current implementation is meant to cover all possible fields so that
users can remove/alter items on a vendor by vendor basis as needed.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoAdded debug-only option to edi_pusher.pl
Bill Erickson [Fri, 27 Jul 2012 15:11:25 +0000 (11:11 -0400)]
Added debug-only option to edi_pusher.pl

Option causes the final EDI to be printed to STDOUT, but does not
populate any data in the DB nor does it FTP the file to the vendor.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoFeed JEDI to the EDI translator to get EDI, and vice versa.
Lebbeous Fogle-Weekley [Thu, 26 Jul 2012 14:17:06 +0000 (10:17 -0400)]
Feed JEDI to the EDI translator to get EDI, and vice versa.

Run this script as the opensrf user.

INPUT_IS_EDI=1 perl test_edi_translator.pl < blob.edi

-or-

perl test_edi_translator.pl < blob.jedi

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoWhitespace fixes in Collections.pm
Lebbeous Fogle-Weekley [Wed, 1 Aug 2012 18:51:39 +0000 (14:51 -0400)]
Whitespace fixes in Collections.pm

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoCollections user balance API / batch file output
Bill Erickson [Thu, 12 Apr 2012 15:44:44 +0000 (11:44 -0400)]
Collections user balance API / batch file output

New API open-ils.collections.user_balance_summary.generate,
which generates summary information on patron balance owed for all open
transactions that occurred at the requested location.  Optional flag
supports including per-xact summary information as well.  The summary
information is written to an XML file and placed in a protected, shared
web directory for download after the file has been generated.

During creation, the output file will have a .tmp suffix, allowing
clients to poll for file completion.

Includes a new opensrf.xml app_setting for open-ils.collections to
specifiy the batch file directory as well as a sample Apache config in
eg_vhost.conf

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoFieldmapper toXML repairs and additions
Bill Erickson [Thu, 12 Apr 2012 15:07:10 +0000 (11:07 -0400)]
Fieldmapper toXML repairs and additions

1. Be sure the append the current element to the document in progress

2. Use the class hint instead of the fully qualified class_name (e.g.
Fielmapper::actor::user) to avoid XML errors:

namespace error : Failed to parse QName 'Fieldmapper:'

3. Added support for additional options including "no_virt" which tells
the routine to skip all virtual fields and "skip_fields" to support
leaving specific fields out of the output.  The main use case for skip
fields is au => ['passwd'], but other examples might include large
fields like bre => ['marc'].

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoTeach Fieldmapper how to turn FM objects into simple XML
Mike Rylander [Tue, 10 Apr 2012 20:28:40 +0000 (16:28 -0400)]
Teach Fieldmapper how to turn FM objects into simple XML

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoStamping upgrade script 0732
Lebbeous Fogle-Weekley [Wed, 1 Aug 2012 18:30:07 +0000 (14:30 -0400)]
Stamping upgrade script 0732

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoACQ unified search submit on enter (for real)
Bill Erickson [Wed, 1 Aug 2012 17:54:00 +0000 (13:54 -0400)]
ACQ unified search submit on enter (for real)

This replaces the old-style submit on enter handler which was based
attaching key handlers to the dijit domNode, which does not work for
filtering selects (i.e. more complicated dijits) w/ the dijit-sanctioned
dojo.connect(..., 'onkeyup', ...), which works regardless.  This also
covers more form input elements which were overlooked with the original
submit-on-enter code.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoACQ invoice formatting improvements
Bill Erickson [Thu, 12 Jul 2012 19:26:50 +0000 (15:26 -0400)]
ACQ invoice formatting improvements

Prevent # invoiced and # paid inputs from wrapping.  Also, make the text
boxes a little smaller to reduce horizontal space requirements.  It's
still possible to enter any value, but only the 4 least significant
digits are visible.  Since it's not common to invoice 10k+ copies of the
same item, this seems like a fair trade off.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoACQ invoice inline lineitem search and add
Bill Erickson [Tue, 10 Jul 2012 15:07:53 +0000 (11:07 -0400)]
ACQ invoice inline lineitem search and add

The Invoice UI is how composed of two tabs, the main invoice tab and a new
Search tab.  The search tab consists of a subset of the Acquisitions unified
search interface.  The goal is to allow users to search for lineitems to
invoice.  Search results may be added directly to the growing invoice.  A
number of small usability features are included.

Features
~~~~~~~~

    * Option (default) to limit searches to invoiceable items.
        ** These are lineitems that are not cancelled, have at least one
           invoiceable copy, linked to a PO whose provider matches that of the
           current invoice, and are not already linked to the current invoice.

    * Search defaults to last-run search (on workstation).
    * New Lineitem Detail filter options
    * Sort searches by lineitem number (default) and title.
    * There is a new Expected Cost field which includes both the total invoiced
      cost plus the anticipated cost of lineitems as they are added.
    * New Price per Copy field
    * Lineitem count field
    * Show / Hide Invoice details button.  Details are displayed by default, but
      hidden when the user enters the search tab.  From there it remains hidden
      until manually shown (or a new invoice is opened).
    * A new "Save & Clear" button which saves the current invoice then clears
      the invoice display to create a new invoice.
    * Provider, shipper, and receiver fields are auto-populated from the
      first-added invoice data (when not already set).
    * Totals are now read-only, since they are derived from existing data (and
      are informational only).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoEditPane setFieldValue method
Bill Erickson [Fri, 20 Jul 2012 17:53:35 +0000 (13:53 -0400)]
EditPane setFieldValue method

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoEditPane.js API repairs
Bill Erickson [Fri, 20 Jul 2012 15:15:25 +0000 (11:15 -0400)]
EditPane.js API repairs

By default, don't throw an exception from EditPane.getFieldValue when a
field is required and the value is null.  Otherwise, external code is
unable to use this method for inspecting the pane.  Make checkRequired
an additional method flag.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoACQ lineitem summary moved to real DB view
Bill Erickson [Fri, 20 Jul 2012 14:25:39 +0000 (10:25 -0400)]
ACQ lineitem summary moved to real DB view

This is allows us to create new IDL views based on the lineitem summary.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoEDI Invoicing
Lebbeous Fogle-Weekley [Tue, 17 Jul 2012 21:59:23 +0000 (17:59 -0400)]
EDI Invoicing

Includes patch for edi4r to make invoice parsing possible.

Also adds OpenILS::Utils::LooseEDI module.  This doesn't try to do the
validation and other helpful things that Business::EDI aims to do, but it
does let us get up and running relatively quickly at getting data from EDI
invoices if we know what we're looking for.

[Amended to add bits about tax, plus release note blurb.]

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoVandelay Copy Overlay support
Bill Erickson [Fri, 27 Jul 2012 20:11:54 +0000 (16:11 -0400)]
Vandelay Copy Overlay support

Vandelay Item Attributes (Cataloging -> MARC Import /
Export -> Import Item Attribute Definitions) contains
a new field called "Overlay Match ID".  The presence of data
in this field extracted from an import-item copy indicates
to the Vandelay import process that a copy overlay is requested
instead of new copy creation.  The value for the field is the
copy id for bib record queues and the ACQ lineitem_detail ID for
Acquisitions Queues.  For either type of queue, however, overlay
occurs against a real copy (asset.copy).  In the ACQ queue case,
we use the lineitem_detail ID because this is the data ACQ
providers and sub-systems will have access to.

When a match point ID value is a set and a matching copy is found,
the values extracted from the inbound copy data are used to replace
values on the existing found copy, including the call-number label.
Any fields on the inbound copy that are empty are ignored.

One use case for this feature are shelf-ready items produced by a
3rd-party (e.g. ACQ provider) and delivered to the library via MARC
file for upload.  The file might contain improved MARC bibliographic
data as well as real barcodes (i.e. not temporary ACQ generated
barcodes) for the copies already purchased through the vendor.

Permission
~~~~~~~~~

This adds a new permission called IMPORT_OVERLAY_COPY which is
required to perform the copy overlay step.

Regardless of permission, it is not possible to overlay values on
a copy unless the imported bib record links (creates/overlays/merges)
to/with the owning bib record for the copy to be overlaid.  This is
both for security and removal of a potent foot-gun.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoStamping Encumbrance-only rollover DB upgrade
Bill Erickson [Tue, 31 Jul 2012 13:14:40 +0000 (09:14 -0400)]
Stamping Encumbrance-only rollover DB upgrade

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoFinishing off rollover-without-money feature
Lebbeous Fogle-Weekley [Fri, 27 Jul 2012 17:32:12 +0000 (13:32 -0400)]
Finishing off rollover-without-money feature

- Minor correction to make stock schema match upgrade script match.
- OU setting determining whether to offer rollover-without-money in UI
   and allow it in DB.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoAllow propagation of encumbrances without funds
Mike Rylander [Thu, 26 Jul 2012 13:35:01 +0000 (09:35 -0400)]
Allow propagation of encumbrances without funds

Some libraries must return all unspent money to some funding agencies at the
end of the year.  To support this, we give the year-end close-out operation
the ability to dump the money from rollover-enabled funds into the void. Funds
are still created for the next year, and encumbrances are moved to theses
analogous funds.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoSupport SIP payment type 02 - credit card
Jeff Godin [Tue, 19 Jun 2012 16:31:03 +0000 (12:31 -0400)]
Support SIP payment type 02 - credit card

Record SIP payments with payment type 02 as credit_card_payment in
Evergreen.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
8 years agoFix LP 829630, Show in Catalogue not working on Bills screen
Steven Chan [Sun, 8 Jul 2012 18:20:11 +0000 (11:20 -0700)]
Fix LP 829630, Show in Catalogue not working on Bills screen

The page is looking for a messagecatalog XUL element with id
'catStrings', but is not finding it, and so we add it to the relevant
XUL file.

It's odd why it is omitted, because a browse through the repository
doesn't show any changes that would explain the error.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoUse bash and the postgres built-in array_agg
Mike Rylander [Thu, 14 Jun 2012 11:34:12 +0000 (07:34 -0400)]
Use bash and the postgres built-in array_agg

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoWrap upgrade script for TPAC advanced search VR formats
Dan Scott [Mon, 30 Jul 2012 20:24:45 +0000 (16:24 -0400)]
Wrap upgrade script for TPAC advanced search VR formats

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPac: Advanced Search Config
Thomas Berezansky [Fri, 13 Apr 2012 21:24:43 +0000 (17:24 -0400)]
TPac: Advanced Search Config

Move advanced search limiter config to config.tt2.

This should, in theory, make it much easier to customize the fields shown
for searching in TPac.

Also adds the VR Format Coded Value Maps so that we can populate that
limiter with them.

And removes dojo.css from being loaded - That includes reset stuff that
messes with our CSS but doesn't seem to give us any benefit.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPAC: Address remaining colors and background URL image
Dan Scott [Mon, 30 Jul 2012 03:19:21 +0000 (23:19 -0400)]
TPAC: Address remaining colors and background URL image

Thanks to Thomas Berezansky for finding these remaining hard-coded CSS
colors, and raising a question about one of the background images that
turns out to not currently being in use.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoTPAC CSS: catch new colours added to master recently
Dan Scott [Sun, 29 Jul 2012 04:31:14 +0000 (00:31 -0400)]
TPAC CSS: catch new colours added to master recently

A few new colours were added to the CSS with recent features; roll them
into the CSS templates for good measure.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoTPAC CSS: Whitespace consistency
Dan Scott [Sun, 29 Jul 2012 04:19:30 +0000 (00:19 -0400)]
TPAC CSS: Whitespace consistency

Resolve the spaces and tabs quandary.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoTPAC CSS: Remove unused classes and associated images
Dan Scott [Sun, 29 Jul 2012 04:15:07 +0000 (00:15 -0400)]
TPAC CSS: Remove unused classes and associated images

Combing through the remaining url() usages in the TPAC CSS, it seems
that most of the usages are unreferenced in the actual TPAC. Therefore,
delete the cruft.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoTemplatize TPAC styles
Dan Scott [Thu, 26 Jul 2012 21:39:06 +0000 (17:39 -0400)]
Templatize TPAC styles

Begin by gathering the colors together in one consistent file, such that
skinning for the purposes of color only needs to touch one small file.
Also, it should make things easier for designers to reduce drastically
the number of colors that are actually used in the design.

Also, enable TT to handle the CSS files in Apache configuration.

Also, convert the login background image into a simple gradient.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoNew XUL user perm editor
Thomas Berezansky [Sun, 29 Jul 2012 16:49:20 +0000 (12:49 -0400)]
New XUL user perm editor

The xhtml one doesn't work in newer xulrunners.

Also, as the same issue breaks the pre-2.0 user editor I have removed it
outright, including taking a stab at removing old language strings.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen
Mike Rylander [Mon, 30 Jul 2012 19:08:47 +0000 (15:08 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen

Appologies for the merge commit noise...

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoStamping KPAC upgrade script
Mike Rylander [Mon, 30 Jul 2012 19:06:22 +0000 (15:06 -0400)]
Stamping KPAC upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agokpac : repair skin2 logout link
Bill Erickson [Mon, 9 Jul 2012 14:22:51 +0000 (10:22 -0400)]
kpac : repair skin2 logout link

Replace non-existent logout image with logout text, including username,
similar to skin1.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agokpac : repair Top link
Bill Erickson [Tue, 26 Jun 2012 19:36:50 +0000 (15:36 -0400)]
kpac : repair Top link

Template Toolkit string.replace() does an inline replacement instead of
returning a value.  Use .replace() correctly when building the Top URL,
or the result will be an empty href, which direct to "here" in
Firefox/Chrome, but directs to "here, minus the page name in the URL"
(e.g. http://domain/eg/kpac/) in IE, which ultimately directs the user
to /eg/opac/login (since it doesn't match any configured paths).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agokpac : better wording for the Save It dialog
Bill Erickson [Thu, 21 Jun 2012 13:07:18 +0000 (09:07 -0400)]
kpac : better wording for the Save It dialog

This removes any mention of selecting a location, which is not needed
for saving items to lists.  It also adds some language about saving
items to existing lists.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agokpac : typo Successfull => Successful
Bill Erickson [Fri, 15 Jun 2012 16:18:31 +0000 (12:18 -0400)]
kpac : typo Successfull => Successful

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agokpac : hrefs for back/top links in category page, avoid dupe cgi param
Bill Erickson [Wed, 6 Jun 2012 18:12:17 +0000 (14:12 -0400)]
kpac : hrefs for back/top links in category page, avoid dupe cgi param

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agokpac : hrefs for back/top links in category page
Bill Erickson [Wed, 6 Jun 2012 17:55:21 +0000 (13:55 -0400)]
kpac : hrefs for back/top links in category page

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agokpac : honor no-search propagation (nosprop) param on homesearch (alt skin)
Bill Erickson [Wed, 6 Jun 2012 17:28:01 +0000 (13:28 -0400)]
kpac : honor no-search propagation (nosprop) param on homesearch (alt skin)

When performing category-based searches, do not propagate the searches
into the search box on the home page, similar to the results page search
box.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agotpac/kpac : search_filter_group cache repairs
Bill Erickson [Tue, 29 May 2012 16:05:16 +0000 (12:05 -0400)]
tpac/kpac : search_filter_group cache repairs

Repaired bug in search_filter_group which lead to empty results
delivered when data was in the cache.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>