working/Evergreen.git
3 months agoRevert "LP#1332651 do not strip internal spaces in barcode" master user/rogan/lp1861239_anonymize_options_rebased
Galen Charlton [Mon, 24 Aug 2020 14:49:12 +0000 (10:49 -0400)]
Revert "LP#1332651 do not strip internal spaces in barcode"

This reverts commit 10a0680e782a6cb7646d4f7d925c8feba44865c4.

3 months agoLP1891960 Stamping upgrade: patron search sticky org
Bill Erickson [Mon, 24 Aug 2020 14:25:16 +0000 (10:25 -0400)]
LP1891960 Stamping upgrade: patron search sticky org

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 months agoLP1891960: Angular patron search org is sticky
Jane Sandberg [Mon, 24 Aug 2020 11:56:25 +0000 (04:56 -0700)]
LP1891960: Angular patron search org is sticky

Also removes some unused dependencies and adds
a new org setting to the database:
eg.orgselect.patron.search

To test:
1) Find a title in the staff catalog.
2) Click Place Hold.
3) Search for a Patron.
4) Notice that the search org is initially
your root org (Consortium-level).
5) Select a different value.
6) Leave and come back to this screen.  Note
that the value you selected remains.
7) Perform a search to make sure that the
search is limited to the org you selected.
8) Click the Clear button.  Note that the
value you selected still remains.
9) Perform anoter search to make sure that the
search is limited to the org you selected.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 months agoStamping upgrade script for sticky org-select
Jane Sandberg [Sun, 23 Aug 2020 19:50:38 +0000 (12:50 -0700)]
Stamping upgrade script for sticky org-select

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 months agoLP1889113 Staff catalog record holds sticky org select
Bill Erickson [Mon, 27 Jul 2020 18:21:09 +0000 (14:21 -0400)]
LP1889113 Staff catalog record holds sticky org select

Teaches the record holds grid to use a persistkey for making the pickup
lib selector sticky.  Additionaly, teach the holds retrieval code to
wait until the org select has settled on a value before collecting any
data.

Also adds the new workstation setting type
'eg.orgselect.cat.catalog.wide_holds'

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 months agoLP1889113 Angular org select persistKey support
Bill Erickson [Mon, 27 Jul 2020 18:20:52 +0000 (14:20 -0400)]
LP1889113 Angular org select persistKey support

* Support reading and writing org-select values using server settings.
* Adds a new @Input fallbackOrg[Id] which is used in cases where no
  persisted value is found.
* Adds a new @Otput called componentLoaded which fires once when the
  selector has completed all of it's load time work.
* Improvid code documentation.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 months agoLP1892077 Staff catalog Holdings grid more columns
Bill Erickson [Thu, 20 Aug 2020 15:07:13 +0000 (11:07 -0400)]
LP1892077 Staff catalog Holdings grid more columns

Adds columns for Parts and Circulate As MARC Type.

Additionally, adds columns for Notes, Tags, and Alerts which display the
count of each linked to a given item.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 months agolp1362743 holdings view duplicate barcodes
Mike Risher [Tue, 24 Mar 2020 16:40:02 +0000 (16:40 +0000)]
lp1362743 holdings view duplicate barcodes

Modify holdings view's "replace barcodes" UI so that it doesn't allow one
to enter a duplicate barcode.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Changes to be committed:
modified:   Open-ILS/src/templates/staff/cat/share/t_replace_barcode.tt2
modified:   Open-ILS/web/js/ui/default/staff/cat/catalog/app.js

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
3 months agoLP#1332651 do not strip internal spaces in barcode
Rogan Hamby [Wed, 5 Aug 2020 13:40:46 +0000 (09:40 -0400)]
LP#1332651 do not strip internal spaces in barcode

for retrieve patron via checkout

Signed-off-by Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
3 months agoLP1819367 - Allow paste of list of barcodes in csv format
Josh Stompro [Fri, 13 Sep 2019 16:38:33 +0000 (11:38 -0500)]
LP1819367 - Allow paste of list of barcodes in csv format

Allow the item status scan box to accept a string of barcodes
separated with commas.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 months agoLP1865564 Clear holds cache after Request Items
Bill Erickson [Thu, 16 Jul 2020 18:27:34 +0000 (14:27 -0400)]
LP1865564 Clear holds cache after Request Items

When staff place holds on a record within the Holdings View via the
Request Items function, reset the holds grid data so it bypasses the
cache and refetches the holds, including the new holds.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1865564 Holds grid avoid dupes (AngularJS)
Bill Erickson [Thu, 16 Jul 2020 16:22:52 +0000 (12:22 -0400)]
LP1865564 Holds grid avoid dupes (AngularJS)

Address a couple if cases where the record holds grid in the AngularJS
staff catalog would make multiple network calls to fetch holds data.
In some cases, these calls would result displaying duplicate holds.

1. Avoid fetching holds when the pickup lib selector fires its on change
if the value provided matches the pickup lib we are already using.

2. Avoid reseting and reloading the grid during an active grid load.
Instead wait for the current load to complete before launching the next
load action.

Patch also includes a minor sanity check in the holdings code to avoid
console errors caused during pickup lib change.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agolp1771386 stamping DB upgrade for inactivate bib on merge
Jane Sandberg [Thu, 20 Aug 2020 20:06:47 +0000 (13:06 -0700)]
lp1771386 stamping DB upgrade for inactivate bib on merge

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 months agolp1771386 update to record merge assets function to make source bib inactive as well...
Rogan Hamby [Thu, 20 Aug 2020 17:04:10 +0000 (13:04 -0400)]
lp1771386 update to record merge assets function to make source bib inactive as well as flagged deleted

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 months agoLP#1844732 Circulation Modifier Display when Batch Editing Items
Garry Collum [Mon, 13 Jul 2020 15:34:55 +0000 (11:34 -0400)]
LP#1844732 Circulation Modifier Display when Batch Editing Items

Fixes the circulation modifiers multivalue list when editing items with
more than one circulation modifier.

To test in with the concerto data, go to Server Administrator ->
Circulation Modifiers and create a couple of circ modifiers (kittens,
puppies).

Bring up the holdings view of a bib and edit a few items assigning these
items to each of the circ modifiers.

After assigning circ modifiers to several items, bring up some of these
items into the item editor making sure that you have chosen items that
have both circ modifiers.

View the multiple values for the circ modifiers.  It will display
something like 'No (10)'.

Apply the patch. Bring up the items again and view the multiple values.
The circ modifiers will be listed indivitually with a number
representing the number of items with that circ modifier.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agolp1747664 add batch edit of call numbers to item bucket
Mike Risher [Fri, 5 Jun 2020 18:31:22 +0000 (18:31 +0000)]
lp1747664 add batch edit of call numbers to item bucket

Modify the item bucket so that one can batch edit call numbers, like
one can from the item status page.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1845047 Ignore grid page size pref when paging disabled
Bill Erickson [Mon, 23 Sep 2019 21:17:13 +0000 (17:17 -0400)]
LP1845047 Ignore grid page size pref when paging disabled

Ignore any saved value for page size on grids configured with paging
disabled.  Such grids are required to show all rows or any data past the
first page would be innaccessible.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1850825 Vandely export set default record source
Bill Erickson [Mon, 10 Aug 2020 19:19:51 +0000 (15:19 -0400)]
LP1850825 Vandely export set default record source

Provide a default value for the record ID source (csv, id, bucket) in
the Vandelay record export interface.  Without this, a record source was
only specified if the source value was modified.  Defaults to 'csv'.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1890351 Vandelay queue type selector retains data
Bill Erickson [Wed, 5 Aug 2020 15:41:14 +0000 (11:41 -0400)]
LP1890351 Vandelay queue type selector retains data

Avoid clearing the queue list grid when a click on the Queue Type
selector results in selecting the same queue type as the type already
loaded.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1839562 Ang Vandelay Match Set Replace Mode
Bill Erickson [Tue, 11 Aug 2020 15:07:04 +0000 (11:07 -0400)]
LP1839562 Ang Vandelay Match Set Replace Mode

Recover "Replace Mode" functionality in the Vandelay Match Set editor
interface, so existing nodes (e.g. And) may be replaced with other nodes
(e.g. Or) without modifying the rest of the tree structure.

Values (Record Attrs / MARC Fields) can replace other values.  Booleans
can replace any type of tree node.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agolp1801947 (follow-up): specify behavior for eg-help-popover button
Jane Sandberg [Mon, 17 Aug 2020 20:51:59 +0000 (13:51 -0700)]
lp1801947 (follow-up): specify behavior for eg-help-popover button

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 months agolp1801947 eg-help-popover accessibility
Mike Risher [Fri, 19 Jun 2020 20:00:04 +0000 (20:00 +0000)]
lp1801947 eg-help-popover accessibility

Modify the eg-help-popover directive so that it can be invoked via
a keyboard action.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/css/style.css.tt2
modified:   Open-ILS/src/templates/staff/share/t_help_popover.tt2

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 months agoLP#1726918 Alert doesn't display for soon-to-expire patron accounts
Terran McCanna [Mon, 21 Oct 2019 19:12:22 +0000 (15:12 -0400)]
LP#1726918 Alert doesn't display for soon-to-expire patron accounts

This displays an alert on the patron summary bar if a patron account
is set to expire within x number of days as defined by the
'Warn when patron account is about to expire' library setting.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 months agoLP1858833 Stamping DB upgrade for change_password
Bill Erickson [Mon, 17 Aug 2020 20:24:07 +0000 (16:24 -0400)]
LP1858833 Stamping DB upgrade for change_password

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 months agoLP1858833 Convenience function for setting a salted password
Rogan Hamby [Wed, 8 Jan 2020 20:47:07 +0000 (15:47 -0500)]
LP1858833 Convenience function for setting a salted password

Copy and pasted from bug comment by Bill Erickson.

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 months agoLP#1724019 Offline Circulation Orgs Alphabetized
Mike Risher [Fri, 7 Aug 2020 20:14:40 +0000 (20:14 +0000)]
LP#1724019 Offline Circulation Orgs Alphabetized

On the offline circulation interface adjust the orgs so that they're
sorted alphabetically.  Preserve the org hierarchy.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/web/js/ui/default/staff/services/env.js
modified:   Open-ILS/web/js/ui/default/staff/services/lovefield.js

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 months agoLP1890849 Grid context menu override fixed width
Bill Erickson [Mon, 10 Aug 2020 15:09:35 +0000 (11:09 -0400)]
LP1890849 Grid context menu override fixed width

Allow grid context menus to expand horizontally for longer terms to
avoid scroll bars and/or having text get cut off.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 months agoLP#1839365: (follow-up) update AngularJS login page as well
Galen Charlton [Thu, 13 Aug 2020 20:01:08 +0000 (16:01 -0400)]
LP#1839365: (follow-up) update AngularJS login page as well

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP#1839365: add h1 heading to Angular staff login page
Shula Link [Tue, 22 Oct 2019 15:06:44 +0000 (11:06 -0400)]
LP#1839365: add h1 heading to Angular staff login page

Signed-off-by: Shula Link <slink@gchrl.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agotidying of Pg/upgrade scripts
Galen Charlton [Thu, 13 Aug 2020 15:32:57 +0000 (11:32 -0400)]
tidying of Pg/upgrade scripts

- remove executable flag
- add .sql extension to a recent one

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP#1869898: stamp DB update
Galen Charlton [Thu, 13 Aug 2020 15:30:58 +0000 (11:30 -0400)]
LP#1869898: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1889685 Staff catalog record CN browse retains search
Bill Erickson [Thu, 30 Jul 2020 19:29:08 +0000 (15:29 -0400)]
LP1889685 Staff catalog record CN browse retains search

Using the Shelf Browse tab on the record detail page in the Angular
staff catalog no longer clobbers the active search, allowing the search
navigation buttons (Next, Previous, etc.) to continue working.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1889694 Staff catalog record summary API
Bill Erickson [Fri, 31 Jul 2020 14:54:28 +0000 (10:54 -0400)]
LP1889694 Staff catalog record summary API

Replaces a number of result page and record detail page API calls with a
bespoke API specifically created to return the data required for display
bib and metabib record summary information in the catalog.

Specifically, a single streaming API this replaces the following:

* fleshed record retrieval
** including record display fields and attributes processing.
* copy count retrieval
* hold count retrieval

The end result is 22 API calls per results page replaced with 2.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1869898 Remove staffcat AOUS; activate holds template
Bill Erickson [Thu, 6 Aug 2020 17:58:14 +0000 (13:58 -0400)]
LP1869898 Remove staffcat AOUS; activate holds template

Remove the org unit setting for enabling access to the Angular staff
catalog, since it is now the default catalog.

Activate the stock holds-for-bib print template, which is used by the
staff catalog holds-for-record grid.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1869898 Ang cat copy table responds to broadcasts
Bill Erickson [Wed, 5 Aug 2020 14:43:05 +0000 (10:43 -0400)]
LP1869898 Ang cat copy table responds to broadcasts

Angular staff catalog copy table responds to broadcasts of modified
holdings.  When holdings for the current record have changed, the table
data is refreshed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1869898: Banner no longer calls the staff catalog experimental
Jane Sandberg [Tue, 4 Aug 2020 21:50:13 +0000 (14:50 -0700)]
LP1869898: Banner no longer calls the staff catalog experimental

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1869898 Holdings responds to broadcasted changes
Bill Erickson [Fri, 19 Jun 2020 20:50:18 +0000 (16:50 -0400)]
LP1869898 Holdings responds to broadcasted changes

Adds a new service for interracting with BroadcastChannel's.
Teaches the holdings grid to refresh data if a broadcast is received for
related holdings updates.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1869898 Angular staff cat place hold from patron
Bill Erickson [Mon, 8 Jun 2020 18:57:37 +0000 (14:57 -0400)]
LP1869898 Angular staff cat place hold from patron

The place hold button in the patron holds list now takes staff to the
Angular catalog for holds placement.  A banner is displayed along the
top of the catalog to indicate which patron the hold is for and to
provide a link back to the patron's holds list.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1869898 Angular staff cat release notes
Bill Erickson [Tue, 31 Mar 2020 15:01:57 +0000 (11:01 -0400)]
LP1869898 Angular staff cat release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1869898 Make Angular staff catalog default
Bill Erickson [Fri, 27 Mar 2020 17:17:38 +0000 (13:17 -0400)]
LP1869898 Make Angular staff catalog default

Modifies Angular and AngJS templates and AngJS code to use the new
Angular staff catalog as the default catalog for new catalog searches,
record detail links, etc.

The traditional client is left unmodified and remains accessible from
the navigation menus.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agolp1890498: Replace Item Barcode now warns about duplicate barcode
Mike Risher [Wed, 5 Aug 2020 21:34:12 +0000 (21:34 +0000)]
lp1890498: Replace Item Barcode now warns about duplicate barcode

Modify the Replace Item Barcode page so that it displays an error
message when trying to replace a barcode with a barcode already
in use.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP#1207744: fix display of duplicate results when viewing report folders
Mike Risher [Fri, 12 Jun 2020 22:17:44 +0000 (22:17 +0000)]
LP#1207744: fix display of duplicate results when viewing report folders

When you repeatedly click the link to display a template, report, or
output folder on the reports UI, the contents of that folder can
display multiple times. This patch addresses this bug and prevents
duplicate contents from displaying.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoDocs: ldconfig needs to be run when installing on Ubuntu 18.04 too
Jane Sandberg [Thu, 13 Aug 2020 13:51:26 +0000 (06:51 -0700)]
Docs: ldconfig needs to be run when installing on Ubuntu 18.04 too

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 months agoLp 1843079: Add renewals remaining to AutoRenew reactor's user data
Jason Stephenson [Fri, 6 Sep 2019 14:38:25 +0000 (10:38 -0400)]
Lp 1843079: Add renewals remaining to AutoRenew reactor's user data

Add auto_renewal_remaining and total_renewal_remaining fields to the
autorenew event's user data so that we can report the number of
renewals remaining to the patron without doing (possibly erroneous)
math in the template.  When the circulation is renewed, we use the
renewal remaining counts from the new circulation.  When the renewal
fails, we use the counts from the original circulation.

The current template is not modified to add these fields.  That is left
as an exercise for sites that want to add this information for the
convenience of their patrons.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
3 months agoforward-port 3.4.3-3.4.4-upgrade-db.sql
Galen Charlton [Wed, 12 Aug 2020 16:21:31 +0000 (12:21 -0400)]
forward-port 3.4.3-3.4.4-upgrade-db.sql

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoForward-port 3.5.1 upgrade script
Jane Sandberg [Tue, 11 Aug 2020 23:58:47 +0000 (16:58 -0700)]
Forward-port 3.5.1 upgrade script

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 months agoDocs: asciidoc syntax correction for 3.5 release notes
Jane Sandberg [Tue, 11 Aug 2020 23:11:07 +0000 (16:11 -0700)]
Docs: asciidoc syntax correction for 3.5 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 months agoDocs: asciidoc syntax correction for 3.4 release notes
Jane Sandberg [Tue, 11 Aug 2020 23:09:51 +0000 (16:09 -0700)]
Docs: asciidoc syntax correction for 3.4 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 months agoDocs: 3.5.1 release notes
Jane Sandberg [Tue, 11 Aug 2020 20:11:14 +0000 (13:11 -0700)]
Docs: 3.5.1 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 months agoDocs: tweaks to 3.4.4 release notes
Jane Sandberg [Tue, 11 Aug 2020 20:10:44 +0000 (13:10 -0700)]
Docs: tweaks to 3.4.4 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 months agoDocs: 3.4.4 release notes
Jane Sandberg [Tue, 11 Aug 2020 18:24:46 +0000 (11:24 -0700)]
Docs: 3.4.4 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 months agoDocs: Release notes for 3.4.3
Remington Steed [Wed, 10 Jun 2020 16:06:05 +0000 (12:06 -0400)]
Docs: Release notes for 3.4.3

Signed-off-by: Remington Steed <rjs7@calvin.edu>
3 months agoLP1811466 Add fields to holdings editor column pickers
Michele Morgan [Tue, 27 Aug 2019 12:55:06 +0000 (08:55 -0400)]
LP1811466 Add fields to holdings editor column pickers

Adds item fields creator, editor and last edit date to the working and
completed grids in the holdings editor.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 months agoLP#1839369: (follow-up) tweak button and styles
Galen Charlton [Mon, 3 Aug 2020 21:14:12 +0000 (17:14 -0400)]
LP#1839369: (follow-up) tweak button and styles

- Change the button text from "Search" to "Search Catalog"
- adjust the styling on the AngularJS side to cuddle the
  button with the search input
- standardize the placeholder text as "Search for..."

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 months agoLP#1839369 Accessibility for Search Box
Terran McCanna [Tue, 22 Oct 2019 20:16:35 +0000 (16:16 -0400)]
LP#1839369 Accessibility for Search Box

This adds an accessible label to the Search box on the splash
page of the staff client as well as to the Angular version of
the splash page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 months agoLP#1864371: bump up ng-bootstrap to 7.0.0
Galen Charlton [Wed, 5 Aug 2020 18:29:39 +0000 (14:29 -0400)]
LP#1864371: bump up ng-bootstrap to 7.0.0

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 months agoLP#1864371: (follow-up) fix lint
Galen Charlton [Wed, 5 Aug 2020 17:49:31 +0000 (13:49 -0400)]
LP#1864371: (follow-up) fix lint

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 months agoLP1864371 Angular 10 deps
Bill Erickson [Fri, 26 Jun 2020 18:33:29 +0000 (14:33 -0400)]
LP1864371 Angular 10 deps

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1864371 Angular 10 deps
Bill Erickson [Fri, 26 Jun 2020 18:31:13 +0000 (14:31 -0400)]
LP1864371 Angular 10 deps

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1864371 Remove extra match set data source
Bill Erickson [Fri, 26 Jun 2020 18:52:09 +0000 (14:52 -0400)]
LP1864371 Remove extra match set data source

Remove an erroneous [dataSource]="queueSource" attribute from the
Vandelay Match Set grid, which was causing the grid to think it had no
data source.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1864371 Migrate deprecated loadChildren invocations
Bill Erickson [Fri, 26 Jun 2020 18:24:00 +0000 (14:24 -0400)]
LP1864371 Migrate deprecated loadChildren invocations

https://angular.io/guide/deprecations#loadchildren-string-syntax

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1864371 ngbTabset to ngbNav for marc editor
Bill Erickson [Fri, 26 Jun 2020 17:57:50 +0000 (13:57 -0400)]
LP1864371 ngbTabset to ngbNav for marc editor

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1864371 Angular 9 bits an pieces
Bill Erickson [Fri, 26 Jun 2020 16:49:31 +0000 (12:49 -0400)]
LP1864371 Angular 9 bits an pieces

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1864371 Angular packages updated for 9.1.0
Bill Erickson [Fri, 26 Jun 2020 15:24:04 +0000 (11:24 -0400)]
LP1864371 Angular packages updated for 9.1.0

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1864371 Makefile.install install Angular 9.1.0
Bill Erickson [Fri, 26 Jun 2020 15:23:45 +0000 (11:23 -0400)]
LP1864371 Makefile.install install Angular 9.1.0

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1864371 Temp delete package-lock.json
Bill Erickson [Fri, 26 Jun 2020 15:16:43 +0000 (11:16 -0400)]
LP1864371 Temp delete package-lock.json

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1774892 release notes
Jason Etheridge [Mon, 3 Aug 2020 12:37:18 +0000 (08:37 -0400)]
LP1774892 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1774892 stripe elements
Jason Etheridge [Fri, 10 Jul 2020 16:15:22 +0000 (12:15 -0400)]
LP1774892 stripe elements

This fixes some minor errors with the generic payment form.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1774892 stripe elements
Jason Etheridge [Fri, 10 Jul 2020 16:08:30 +0000 (12:08 -0400)]
LP1774892 stripe elements

This commit breaks some code out into separate files for easier understanding.

The Stripe form was then tweaked and repositioned to work with specific selected
transactions, invoke the last chance screen, and show the refund policy.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1774892 stripe elements
Jason Etheridge [Fri, 12 Jun 2020 13:57:03 +0000 (09:57 -0400)]
LP1774892 stripe elements

This commmit changes the OPAC to use https://js.stripe.com/v3/ instead of
https://js.stripe.com/v2/ for processing payments through Stripe.

Additionally, it disables the "internal" credit card form in the staff client
when Stripe is the payment processor (or if the processor is not set at all),
as that does not currently work.

It also does not replace Business::Stripe's use of the "Charges API" with the
newer "Payment Intents" API on the backend, but credit card details are still
not sent to the Evergreen server.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1867834 Staffcat clear basket on logout
Bill Erickson [Wed, 18 Mar 2020 16:41:38 +0000 (12:41 -0400)]
LP1867834 Staffcat clear basket on logout

Tell the browser/local store service to treat the staff catalog basket
cache key as a "login item", meaning it should be cleared upon logout.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP#1889251: make call number affix sort keys read-only
Galen Charlton [Tue, 28 Jul 2020 15:09:45 +0000 (11:09 -0400)]
LP#1889251: make call number affix sort keys read-only

This patch makes the call number prefix and suffix label sort
key fields read-only on their respective Server Administration
pages, as any values that a user would try to set for them
would get overwritten by a database trigger.

To test
-------
[1] Apply the patch.
[2] Go to Server Administration -> Call Number Prefixes (or Suffixes)
    and attempt create and edit new affixes.
[3] Verify that the label sort key is a read-only display field on the
    edit modal.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
3 months agoLP#1674364 - Use database bib id for cover art lookup
Josh Stompro [Mon, 4 Mar 2019 17:16:56 +0000 (11:16 -0600)]
LP#1674364 - Use database bib id for cover art lookup

Export the 901c as the URN:BIBID identifier to allow the
ATOM2XHTML.xsl to construct a cover art img link using it.

Testing Notes:

I used a bookbag to test this out.
1. Create a public bookbag of items and grab the bookbag id.
2. View the source of these links on your system to see the current output.
 /opac/extras/feed/bookbag/atom/<bookbagid>
 /opac/extras/feed/bookbag/html-full/<bookbagid>
   Make note that the jacket img link uses the ISBN to lookup cover art.

Make changes.
1. Restart supercat to re-load xsl transfor files.
  osrf_control -l --service open-ils.supercat --restart
2. View the source and output of these links on your system to see the changes.
 /opac/extras/feed/bookbag/atom/<bookbagid>
 /opac/extras/feed/bookbag/html-full/<bookbagid>
   The cover art images should show up now in the html-full, and the
   URN:BIBID: identifier should be populated in the atom file.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP#1731370: (follow-up) fix a typo that was causing console noise
Galen Charlton [Mon, 3 Aug 2020 21:38:48 +0000 (17:38 -0400)]
LP#1731370: (follow-up) fix a typo that was causing console noise

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP#1761142: (follow-up) tweak field-change style
Galen Charlton [Mon, 3 Aug 2020 21:31:32 +0000 (17:31 -0400)]
LP#1761142: (follow-up) tweak field-change style

[1] Ensure that the border is displayed.
[2] Change the border color to one that has more contrast
    as compared to the bg-success background color.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1761142 Volume Copy Editor Changed Fields Hard to Discern
a. bellenir [Thu, 28 Mar 2019 16:26:37 +0000 (12:26 -0400)]
LP1761142 Volume Copy Editor Changed Fields Hard to Discern

Add a changed_fields object to the scope and update it as copies are
changed. The function field_changed(field) determines if any of the
selected copies have altered the given field.  finally, a CSS class,
field-changed, is applied to add a green border to fields whose values
have been modified.

Signed-off-by: a. bellenir <abelleni@grpl.org>
Signed-off-by: Ruth Frasur <rfrasur@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP#1783793 - Suspend holds when activation date set in web client angularjs
Josh Stompro [Tue, 28 Jan 2020 16:04:02 +0000 (10:04 -0600)]
LP#1783793 - Suspend holds when activation date set in web client angularjs

1. Modify Dates popup changed to not allow picking dates in the past for hold
  activation date both in the date picker, and if typed in manually.  If a
  date in the past is typed in, it is changed to today's date and an alert
  message is displayed.  The date picker just won't allow past days to be
  selected.  The alert message remains until a date in the future is selected.

2. Suspend holds when the activation date is set and saved.

3. Adds a note about the fact that the hold will be suspended when the hold
  activation date is selected for editing.  This makes the behavior clear so
  staff don't have to figure it out by trial and error.

4. Updates several sr-only (Screen Reader Only) labels in the holds date popup
  template that were set to the wrong values.  The file was copied from the hold
  notification popup and the screen reader descriptions were left unchanged from
  those values.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP#1885759: Count months and quarters across year boundaries
Mike Rylander [Tue, 30 Jun 2020 19:33:23 +0000 (15:33 -0400)]
LP#1885759: Count months and quarters across year boundaries

We need to add year-multiples of months or quarters when using the
months_ago or quarters_ago transforms in the reporter.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP#1847343: fix Exclude Electronic Resources checkbox when locale picker is enabled
Jeff Davis [Tue, 8 Oct 2019 23:00:12 +0000 (16:00 -0700)]
LP#1847343: fix Exclude Electronic Resources checkbox when locale picker is enabled

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP #1717996 (follow-up) Change label for shareable user buckets
Jane Sandberg [Sat, 26 Oct 2019 04:11:49 +0000 (21:11 -0700)]
LP #1717996 (follow-up) Change label for shareable user buckets

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
3 months agoLP #1717996 Change label for shareable buckets
Tiffany Little [Mon, 21 Oct 2019 19:00:30 +0000 (15:00 -0400)]
LP #1717996 Change label for shareable buckets

Changes 'publicly visible' label on buckets and also adds a tooltip with an explanation. Also makes sure that clicking the tooltip does not check the checkbox automatically.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
3 months agoLP1842431: Add a release note
Jason Boyer [Fri, 31 Jul 2020 16:39:23 +0000 (12:39 -0400)]
LP1842431: Add a release note

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
3 months agoLP1842431: Remove redundant description field
Jason Boyer [Fri, 31 Jul 2020 15:10:24 +0000 (11:10 -0400)]
LP1842431: Remove redundant description field

This branch brings about a good change, but I think having reason
and description be identical in the case of a failure and blank /
'SUCCESS' in the case of, well, success, is redundant and potentially
confusing. Also, if it's not used in the default template I doubt
anyone ever realizes it's there. :) Template editors can use
is_renewed to decide if they want to display success as a result
and that way the capitalization won't look like THE EIGHTIES have come
back in fashion again. :D

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
3 months agoLP#1842431 Split textcode and desc fields for AutoRenew user data
Jason Stephenson [Fri, 6 Sep 2019 15:09:18 +0000 (11:09 -0400)]
LP#1842431 Split textcode and desc fields for AutoRenew user data

Split the event textcode and desc fields into textcode and description
fields, respectively, in the AutoRenew reactor's user data, but also
leave the reason field alone.  This permits sites to show only the
description of the event if they want.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
3 months agoLP#1842431 Make renewal failure reason more appropriate for patron notifications
Michele Morgan [Thu, 12 Sep 2019 20:30:47 +0000 (16:30 -0400)]
LP#1842431 Make renewal failure reason more appropriate for patron notifications

Changes the failure reason for the autorenewal to include only the desc,
Removes the textcode of the event, which shouldn't be included in a patron notice.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
3 months agoLP#1754110: (follow-up) release notes tweak
Galen Charlton [Thu, 30 Jul 2020 14:26:36 +0000 (10:26 -0400)]
LP#1754110: (follow-up) release notes tweak

Update the release notes to indicate which staff
client template one would typically customize to
make use of this feature.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agolp1754110 Patron Reg Field Label Override Release Notes
Kyle Huckins [Tue, 11 Sep 2018 17:38:01 +0000 (17:38 +0000)]
lp1754110 Patron Reg Field Label Override Release Notes

- Add release notes for improvements to draw_field_label

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP#1754110 Patron Reg. Field Label Override
Kyle Huckins [Wed, 7 Mar 2018 17:47:23 +0000 (17:47 +0000)]
LP#1754110 Patron Reg. Field Label Override

Supply additional parameter to draw_field_label macro to
apply custom labels to patron reg/edit fields.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1731370: Distinguishing new copies and volumes with aditional means (WCAG 1.4.1)
Jane Sandberg [Tue, 9 Oct 2018 00:24:20 +0000 (17:24 -0700)]
LP1731370: Distinguishing new copies and volumes with aditional means (WCAG 1.4.1)

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agolp1731370 CSS styling for new items and volumes
Jason Etheridge [Wed, 12 Sep 2018 12:10:32 +0000 (08:10 -0400)]
lp1731370 CSS styling for new items and volumes

previous commit just handled volumes, this handles copies

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agolp1731370 CSS styling for new items and volumes
Jason Etheridge [Wed, 5 Sep 2018 13:13:49 +0000 (09:13 -0400)]
lp1731370 CSS styling for new items and volumes

in vol/copy editor

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP#1851541 - Add audio alert for item alert popups
Josh Stompro [Wed, 6 Nov 2019 18:24:36 +0000 (12:24 -0600)]
LP#1851541 - Add audio alert for item alert popups

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1735568, LP1830443: MARC Editor Fixes
Christine Morgan [Thu, 21 Nov 2019 17:53:11 +0000 (12:53 -0500)]
LP1735568, LP1830443: MARC Editor Fixes

These style changes to the current MARC Editor fix the indicator box
resize problem and the blank subfield problem while improving usability.
Colors were tested using the Chrome extension Colorblindly, a
colorblindness simulator.

Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 months agoLP1889296 Staffcat holds request time includes time
Bill Erickson [Tue, 28 Jul 2020 21:21:28 +0000 (17:21 -0400)]
LP1889296 Staffcat holds request time includes time

Display the hold request time as date plus time in the general purpose
Angluar holds grid.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 months agoLP#1776757: (follow-up) keep input for amount as type "number"
Galen Charlton [Tue, 28 Jul 2020 14:43:25 +0000 (10:43 -0400)]
LP#1776757: (follow-up) keep input for amount as type "number"

Doing this preserves the form validation that ensures that
the user cannot submit the form with a non-numeric amount.

This does lose forcing the display of default amounts such as
"1.50" to two decimal places, but I'm figuring that form validation
takes priority pending a longer-term solution such as a custom
value validator or using ng-currency.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 months agolp1776757 Default Billing Price Not Updating
Mike Risher [Wed, 29 Jan 2020 20:20:35 +0000 (20:20 +0000)]
lp1776757 Default Billing Price Not Updating

Fix the following bug: When billing a patron and one switches from
one billing type to a different billing type, the price isn't updating
to show the new default price

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 months agoLP1795469: Opac holdings sort now considers CN suffix
Jane Sandberg [Wed, 3 Oct 2018 16:04:54 +0000 (09:04 -0700)]
LP1795469: Opac holdings sort now considers CN suffix

To test:
1) Create a bunch of Call Number suffixes in Administration
-> Server Administration -> Call Number Suffixes.
2) Go to a bib record, and add a bunch of holdings,
all with the same call number label, owning/circ libraries,
item numbers, and parts (if using parts) but with different
barcodes and CN suffixes.
3) Look at the OPAC view of these holdings.  Note that they
are in order by barcode, without any consideration for
the CN suffix.
4) Apply this commit.
5) Look at the OPAC view again.  Note that they are now sorted
by CN suffix, and then by barcode.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 months agoLP1882591 Empty combobox avoids default selection
Bill Erickson [Mon, 8 Jun 2020 20:03:14 +0000 (16:03 -0400)]
LP1882591 Empty combobox avoids default selection

When clearing a combobox value, no combobox options are displayed in the
dropdown.  This allows users to clear the value then tab out of the box
without the typeahead magic forcing selection of the first entry.

The full list can still be displayed by clicking on the combobox.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 months agoLP1878079 Staffcat Add Holdings action support
Bill Erickson [Mon, 27 Jul 2020 14:58:52 +0000 (10:58 -0400)]
LP1878079 Staffcat Add Holdings action support

Teaches the staff catalog Add Holdings button to open the holdings
editor using the appropriate parameters.  If the holdings maintenance
grid is active, arguments to pass are based on the grid selection.
Otherwise it simply open the item editor with a single call number /
copy to be created 'here'.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 months agoLP1878079 Staffcat 'Edit' items / call numbers support
Bill Erickson [Wed, 13 May 2020 16:17:19 +0000 (12:17 -0400)]
LP1878079 Staffcat 'Edit' items / call numbers support

Adds support to the Angular staff catalog to properly handle requests
to Edit Items, Edit Call Numbers, and Edit Call Numbers and Items.
Prior to his change, these operations would behave more like Add
operations than Edit operations.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>