working/Evergreen.git
10 years ago1. Disable fleshing for PCRUD. Otherwise fleshing would provide a
scottmk [Thu, 17 Jun 2010 19:16:45 +0000 (19:16 +0000)]
1. Disable fleshing for PCRUD.  Otherwise fleshing would provide a
back door whereby a user could see stuff he has no permission to see.

2. For the id_list method: strip out the "flesh_fields" entry, not
the "flesh_columns" entry (which doesn't exist).  This actually makes
no difference, but if we're going to do something useless, we might
as well do it right.

M    Open-ILS/src/c-apps/oils_sql.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16747 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAcq: Remove the "Selection Lists" entry from the staff client's menu
senator [Thu, 17 Jun 2010 18:45:16 +0000 (18:45 +0000)]
Acq: Remove the "Selection Lists" entry from the staff client's menu

The unified search interface now does everything that the Selection Lists
interface could.

Also, merging selection lists now updates the edit_time field on the lead
list.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16746 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agorecord evidence of the perl-xpath experiment ... not faster enough to warrant the...
miker [Thu, 17 Jun 2010 18:14:15 +0000 (18:14 +0000)]
record evidence of the perl-xpath experiment ... not faster enough to warrant the danger of XML::LibXML

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16745 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agotypo
phasefx [Thu, 17 Jun 2010 18:08:02 +0000 (18:08 +0000)]
typo

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16744 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoprotecting facet_xpath from returning empty nodesets
miker [Thu, 17 Jun 2010 17:05:44 +0000 (17:05 +0000)]
protecting facet_xpath from returning empty nodesets

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16743 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoKludge to fix ISO timestamp parsing in AutoFieldWidget
phasefx [Thu, 17 Jun 2010 15:31:05 +0000 (15:31 +0000)]
Kludge to fix ISO timestamp parsing in AutoFieldWidget

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16742 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomore column id collisions and code to rename such id's if they slip through in the...
phasefx [Thu, 17 Jun 2010 03:58:39 +0000 (03:58 +0000)]
more column id collisions and code to rename such id's if they slip through in the future

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16741 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agocorrectly sort date/timestamp columns in xul lists now that they're localized
phasefx [Thu, 17 Jun 2010 03:39:22 +0000 (03:39 +0000)]
correctly sort date/timestamp columns in xul lists now that they're localized

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16740 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoid collision preventing proper use of these columns
phasefx [Thu, 17 Jun 2010 03:39:21 +0000 (03:39 +0000)]
id collision preventing proper use of these columns

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16739 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoSupport CAST expressions, taking care to avoid SQL injection.
scottmk [Thu, 17 Jun 2010 03:01:32 +0000 (03:01 +0000)]
Support CAST expressions, taking care to avoid SQL injection.

M    Open-ILS/include/openils/oils_buildq.h
M    Open-ILS/src/c-apps/oils_storedq.c
M    Open-ILS/src/c-apps/buildSQL.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16738 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAcq: remove PO search interface from staff client's acquisitions menu
senator [Wed, 16 Jun 2010 20:53:59 +0000 (20:53 +0000)]
Acq: remove PO search interface from staff client's acquisitions menu

The PO search interface is redundant with the generalized Acquisitions Search
interface

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16737 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAcq: Fix display failure in fund tag interface. Add admin interfaces for
senator [Wed, 16 Jun 2010 20:39:00 +0000 (20:39 +0000)]
Acq: Fix display failure in fund tag interface. Add admin interfaces for
invoice_payment_method and invoice_item_type.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16736 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agosplit registration of authority browse urls out from record; add authority formats...
miker [Wed, 16 Jun 2010 19:41:27 +0000 (19:41 +0000)]
split registration of authority browse urls out from record; add authority formats ML method

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16735 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agotypo in json_query for authority browse
miker [Wed, 16 Jun 2010 19:25:15 +0000 (19:25 +0000)]
typo in json_query for authority browse

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16734 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd authority marcxml retrieve method, switch on record type
miker [Wed, 16 Jun 2010 19:21:48 +0000 (19:21 +0000)]
add authority marcxml retrieve method, switch on record type

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16733 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agouse the authority, instead of bib, general tag browse method
miker [Wed, 16 Jun 2010 19:11:16 +0000 (19:11 +0000)]
use the authority, instead of bib, general tag browse method

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16732 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agosteps toward wiring up authority browse via supercat
miker [Wed, 16 Jun 2010 19:01:36 +0000 (19:01 +0000)]
steps toward wiring up authority browse via supercat

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16731 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoupdate the documentation for browse methods re status/location filters
miker [Wed, 16 Jun 2010 18:48:44 +0000 (18:48 +0000)]
update the documentation for browse methods re status/location filters

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16730 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAcq: bugfixes for "Import Catalog Records by ID"
senator [Wed, 16 Jun 2010 17:41:25 +0000 (17:41 +0000)]
Acq: bugfixes for "Import Catalog Records by ID"

Previously, this interface did not correctly interpret realistic CSV data as
produced by the Reporter module, as it was intended to do.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16729 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomake logout with receipt the default for self-check
erickson [Wed, 16 Jun 2010 17:32:08 +0000 (17:32 +0000)]
make logout with receipt the default for self-check

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16728 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd support for status and copy location filters to supercat browse apis for call...
miker [Wed, 16 Jun 2010 16:55:21 +0000 (16:55 +0000)]
add support for status and copy location filters to supercat browse apis for call number, title/author/etc, item age and general tag browsing

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16727 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agothe layer/bundle version of dojo I was using hid the need for this dojo.require line
phasefx [Wed, 16 Jun 2010 14:54:40 +0000 (14:54 +0000)]
the layer/bundle version of dojo I was using hid the need for this dojo.require line

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16726 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAcq: misc minor bugfixes to various admin interfaces that didn't load
senator [Tue, 15 Jun 2010 21:50:15 +0000 (21:50 +0000)]
Acq: misc minor bugfixes to various admin interfaces that didn't load
consistently.  Also a little more menu re-org.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16725 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agono need to start a xact in lineitem search api call, especially if it's not closed...
erickson [Tue, 15 Jun 2010 21:00:34 +0000 (21:00 +0000)]
no need to start a xact in lineitem search api call, especially if it's not closed out when done

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16724 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agospecify @autoscroll=false for xul browser elements
phasefx [Tue, 15 Jun 2010 19:45:08 +0000 (19:45 +0000)]
specify @autoscroll=false for xul browser elements

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16723 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAcq: minor menu reorganization. Move admin-oriented interfaces to admin menu.
senator [Tue, 15 Jun 2010 19:31:19 +0000 (19:31 +0000)]
Acq: minor menu reorganization. Move admin-oriented interfaces to admin menu.

Also remove "Purchase Order Events" from the acq menu: it's outmoded.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16722 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agosupport pre-indexing normalizers for facet value normalization (negative pos value...
miker [Tue, 15 Jun 2010 18:57:12 +0000 (18:57 +0000)]
support pre-indexing normalizers for facet value normalization (negative pos value in the field-norm map)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16721 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAvoid spurious errors when searching more granular indexes
dbs [Tue, 15 Jun 2010 18:36:37 +0000 (18:36 +0000)]
Avoid spurious errors when searching more granular indexes

The storage service automatically generates methods for each top-level search
class, like open-ils.storage.authority.keyword.see_from.controlled.atomic, but
here we were trying to access more granular methods (which storage does not
know about) when a granular index was used. This generated an ugly error in
the logs.

To avoid these errors, we'll only look for cross references from the broad
index class to which the granular index belonds.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16720 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoin patron editor, prevent Save and Save & Clone from working with an invalid form...
phasefx [Tue, 15 Jun 2010 04:01:23 +0000 (04:01 +0000)]
in patron editor, prevent Save and Save & Clone from working with an invalid form, or duplicate barcode or usrname

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16719 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agothe dojo code now behind the util.date iso8601 formatter neither needs nor likes...
phasefx [Mon, 14 Jun 2010 20:20:31 +0000 (20:20 +0000)]
the dojo code now behind the util.date iso8601 formatter neither needs nor likes us appending timestamps to dates like that

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16718 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoTiny bug in 16714; fixing it prevents a useless logline in some cases
senator [Mon, 14 Jun 2010 17:07:38 +0000 (17:07 +0000)]
Tiny bug in 16714; fixing it prevents a useless logline in some cases

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16717 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoIn the unlikely event of an error in a payment transaction following
senator [Mon, 14 Jun 2010 17:03:54 +0000 (17:03 +0000)]
In the unlikely event of an error in a payment transaction following
sucessful external credit card processing, keep the information from the
payment processor and
    a) attach it to the ilsevent that we return, and
    b) log it at the "error" loglevel

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16714 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoMake the estimated hold queue position method aware of the cut_in_line field
phasefx [Mon, 14 Jun 2010 16:24:55 +0000 (16:24 +0000)]
Make the estimated hold queue position method aware of the cut_in_line field

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16711 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoremoved unused method retrieved from method_lookup. apart from being unused, the...
erickson [Mon, 14 Jun 2010 15:39:43 +0000 (15:39 +0000)]
removed unused method retrieved from method_lookup.  apart from being unused, the call was attempting to fetch a nonexistent method ('auth' vs. 'authority') and hilarity ensued

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16704 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoBetter documentation of payment outcomes, particularly credit card declines
senator [Mon, 14 Jun 2010 14:27:37 +0000 (14:27 +0000)]
Better documentation of payment outcomes, particularly credit card declines

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16699 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agosome minor code cleanup of the retrieve user by barcode method
erickson [Mon, 14 Jun 2010 13:06:51 +0000 (13:06 +0000)]
some minor code cleanup of the retrieve user by barcode method

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16698 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoavoid sending unnecessary disconnects to cstore
erickson [Mon, 14 Jun 2010 13:06:50 +0000 (13:06 +0000)]
avoid sending unnecessary disconnects to cstore

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16697 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoIn qstore: support CASE expressions.
scottmk [Sun, 13 Jun 2010 17:15:28 +0000 (17:15 +0000)]
In qstore: support CASE expressions.

M    Open-ILS/include/openils/oils_buildq.h
M    Open-ILS/src/c-apps/oils_storedq.c
M    Open-ILS/src/c-apps/buildSQL.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16696 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agocorrect nullability test for certain WHERE clauses
miker [Sat, 12 Jun 2010 04:49:58 +0000 (04:49 +0000)]
correct nullability test for certain WHERE clauses

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16694 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomissed a constraint change in the 0307 upgrade script
miker [Fri, 11 Jun 2010 22:28:44 +0000 (22:28 +0000)]
missed a constraint change in the 0307 upgrade script

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16693 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoSerials schema adjustments designed by Dan Wells. Essential features are moving...
miker [Fri, 11 Jun 2010 21:20:39 +0000 (21:20 +0000)]
Serials schema adjustments designed by Dan Wells.  Essential features are moving subscription to attach directly to BRE, as the controlled peer to SRE, and allowing distributions to optionally link to an SRE in order to extend them.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16690 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoa null boolean value should use the label for UNSET instead of False (the default)
erickson [Fri, 11 Jun 2010 21:19:42 +0000 (21:19 +0000)]
a null boolean value should use the label for UNSET instead of False (the default)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16689 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agotroubleshooting DOM issue where too many columns in a treerow
phasefx [Fri, 11 Jun 2010 20:32:43 +0000 (20:32 +0000)]
troubleshooting DOM issue where too many columns in a treerow
some refactoring and comment cleanup.  toward having the need for treecell creation be determined on a column by column basis rather than examining the contents of a treerow in one go

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16687 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years ago$e may false (i.e. 0=SUCCESS). it's undefined we need to avoid
erickson [Fri, 11 Jun 2010 18:39:13 +0000 (18:39 +0000)]
$e may false (i.e. 0=SUCCESS).  it's undefined we need to avoid

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16686 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoforgot to remove old order-by when crafting the trunk version of the fifo-holds patch...
miker [Fri, 11 Jun 2010 17:56:58 +0000 (17:56 +0000)]
forgot to remove old order-by when crafting the trunk version of the fifo-holds patch from James Fournie

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16685 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdd helper handling to specify length of field, like: isbn_10 or isbn_13
atz [Fri, 11 Jun 2010 17:10:35 +0000 (17:10 +0000)]
Add helper handling to specify length of field, like: isbn_10 or isbn_13

"isbn" will still just get the first available value.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16684 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoLogger not used
atz [Fri, 11 Jun 2010 17:10:34 +0000 (17:10 +0000)]
Logger not used

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16683 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoBugfix fatal error: $self->editor is not defined
atz [Fri, 11 Jun 2010 17:10:33 +0000 (17:10 +0000)]
Bugfix fatal error: $self->editor is not defined

Logger wasn't being used either.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16682 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years ago0306: Update JEDI template, edi_pusher logic tweaked
atz [Fri, 11 Jun 2010 17:10:32 +0000 (17:10 +0000)]
0306: Update JEDI template, edi_pusher logic tweaked

Old pusher was excluding valid target with "not in"
subquery.  Broke that out and added debugging so
that situation should be more obvious (if verbose).

Signed-off-by: Joe Atzberger <atz@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16681 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoImprove the way information from payment card processors bubbles up to
senator [Fri, 11 Jun 2010 16:18:35 +0000 (16:18 +0000)]
Improve the way information from payment card processors bubbles up to
callers of open-ils.circ.money.payment

This is done by replacing unneeded, weird data structures with ilsevents and
filling those events' payloads with result data from the processor.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16680 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoOrg unit setting and behavior for blocking hold requests if hold recipient has expire...
phasefx [Fri, 11 Jun 2010 15:16:34 +0000 (15:16 +0000)]
Org unit setting and behavior for blocking hold requests if hold recipient has expired privileges

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16679 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agowhen configuring sort order for copy locations, allow local sorting on locations...
erickson [Fri, 11 Jun 2010 14:07:15 +0000 (14:07 +0000)]
when configuring sort order for copy locations, allow local sorting on locations defined at parent orgs (in the UI, finally)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16678 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded a number of info messages to the action/trigger runner and server code. the...
erickson [Fri, 11 Jun 2010 13:52:20 +0000 (13:52 +0000)]
added a number of info messages to the action/trigger runner and server code.  the messages provide summary
data about what event defs / hooks are being processed and when/if they complete or timeout.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16677 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdd column "left_operand" to query.expr_xcase view.
scottmk [Fri, 11 Jun 2010 13:01:54 +0000 (13:01 +0000)]
Add column "left_operand" to query.expr_xcase view.

M    Open-ILS/src/sql/Pg/002.schema.config.sql
M    Open-ILS/src/sql/Pg/008.schema.query.sql
A    Open-ILS/src/sql/Pg/upgrade/0304.schema.query-expr-xcase-left-operand.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16674 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoForward port r16670 and r16672 to avoid directory creation errors in Dojo resource...
dbs [Fri, 11 Jun 2010 05:00:56 +0000 (05:00 +0000)]
Forward port r16670 and r16672 to avoid directory creation errors in Dojo resource i18n script

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16673 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoRemove extraneous whitespace in ILS events POT file
dbs [Fri, 11 Jun 2010 03:27:47 +0000 (03:27 +0000)]
Remove extraneous whitespace in ILS events POT file

We were grabbing everything - tabs, newlines, extra spaces - from
ils_events.xml, and we don't want to do that.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16667 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoWhen looking up a bind variable by name: escape any special characters
scottmk [Thu, 10 Jun 2010 20:10:42 +0000 (20:10 +0000)]
When looking up a bind variable by name: escape any special characters
in the name before building the query.

M    Open-ILS/src/c-apps/oils_storedq.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16666 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agosyntax
phasefx [Thu, 10 Jun 2010 20:03:25 +0000 (20:03 +0000)]
syntax

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16665 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoseed the UPDATE_PICKUP_LIB_FROM_TRANSIT perm
phasefx [Thu, 10 Jun 2010 19:28:31 +0000 (19:28 +0000)]
seed the UPDATE_PICKUP_LIB_FROM_TRANSIT perm

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16662 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoTrunk port of a patch from James Fournie of SITKA:
miker [Thu, 10 Jun 2010 19:15:13 +0000 (19:15 +0000)]
Trunk port of a patch from James Fournie of SITKA:

There was some discussion about problems with holds fulfillment at the
holds roundtable at EG2010.  I am pleased to share this patch with the
community which has been thoroughly tested by the folks at
Thompson-Nicola Regional District Library.  (thanks guys!)

Background:

Evergreen's default out-of-the-box behaviour for holds fulfillment is
a gas-saving method.  Holds are fulfilled by proximity.  In a
multibranch library, holds are fulfilled at the local branch first.
Many libraries, particularly single branch libraries may be ok with
this, but it may be problematic for other libraries.

Imagine a scenario where you have a large central branch and a small
rural branch of the same library system.  At the large branch, there
are many copies of Popular New DVD with lots of holds.   There are no
copies at the rural branch.  Patrons at the small rural branch who
want to pick up Popular New DVD at their home branch may never get
their hold fulfilled because the copies will stay at the large branch
as long as there are holds for pickup there.

This patch adds an org unit setting that changes the opportunistic
check-in so that items checked in will be assigned to holds by request
date first, rather than proximity.   This setting can be applied to
any level of the org tree, so in some situations you may even want to
activate FIFO for large libraries, but leave the original setting for
smaller libraries with less traffic who want to keep their copies more
local.

Also credit to Jeff Godin who thought of the same patch and
contributed the setting name "holds FIFO" for the setting

[ NOTE:  Implications of mixed FIFO and non-FIFO environments that are
not sufficiently segregated by the use of Hard Boundaries for Holds
present a potenial for user confusion.  Beware that mixing FIFO and
non-FIFO settings within a resource-sharing group will likely result in
severe imbalance of hold fulfillment, though further configuration,
development, tuning and testing may be able to mitigate these issues.
 --miker ]

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16659 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoWhen building string literals in SQL: escape special characters.
scottmk [Thu, 10 Jun 2010 18:57:14 +0000 (18:57 +0000)]
When building string literals in SQL: escape special characters.

M    Open-ILS/src/c-apps/buildSQL.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16658 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoupdated report param editor to handle join types embedded in the field name. this...
erickson [Thu, 10 Jun 2010 18:47:57 +0000 (18:47 +0000)]
updated report param editor to handle join types embedded in the field name.  this bug caused sporadic failed rendering of the report editor params widgets

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16655 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agochange the xulG tests to fix Save & Clone for new patrons
phasefx [Thu, 10 Jun 2010 17:54:40 +0000 (17:54 +0000)]
change the xulG tests to fix Save & Clone for new patrons

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16654 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoChange the return type of the open-ils.qstore.prepare method.
scottmk [Thu, 10 Jun 2010 16:28:50 +0000 (16:28 +0000)]
Change the return type of the open-ils.qstore.prepare method.

Formerly, this method merely returned a string to be used as
token for future references to the query.

Now it returns an object, with the following elements:

"token" -- the query token as returned formerly
"bind_variables" -- a (possibly empty) object containing a
list of bind variables and their various attributes, as
returned by the param_list method.

Rationale: an interactive query-building client will always
want a list of bind variables so that it can prompt the user
for values.  With this change to the return type, the client
can get such a list without having to make a separate call
to the param_list method.

M    Open-ILS/src/c-apps/oils_qstore.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16653 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd important reporting-focused link to asset.copy_location
miker [Thu, 10 Jun 2010 16:12:16 +0000 (16:12 +0000)]
add important reporting-focused link to asset.copy_location

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16652 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoHold requests in the middle layer now bubble up more specific information to
senator [Thu, 10 Jun 2010 15:34:34 +0000 (15:34 +0000)]
Hold requests in the middle layer now bubble up more specific information to
the caller in the event of failure.

The caller can find an ilsevent in the response received from calling
open-ils.circ.title_hold.is_possible, and this event will have a fail_part
attribute in its payload that can be mapped either to a) the new entities
in opac.dtd or b) values of the name column of the database table
config.standing_penalty, depending on why a hold request failed.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16651 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agothinko on how ou settings are returned from open-ils.actor.ou_setting.ancestor_defaul...
miker [Thu, 10 Jun 2010 14:53:38 +0000 (14:53 +0000)]
thinko on how ou settings are returned from open-ils.actor.ou_setting.ancestor_default; also, cache max_loops per pickup lib for the duration of the targetting run

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16650 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoFix a pcrud bug. Create method wasn't working because we were
scottmk [Thu, 10 Jun 2010 14:35:01 +0000 (14:35 +0000)]
Fix a pcrud bug.  Create method wasn't working because we were
foolishly trying to fetch the record that hadn't been created
yet, in order to test its ownership.

M    Open-ILS/src/c-apps/oils_sql.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16649 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomake sure we are not trying to use a "modern" class::dbi
miker [Thu, 10 Jun 2010 14:29:38 +0000 (14:29 +0000)]
make sure we are not trying to use a "modern" class::dbi

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16648 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agologic thinko causing us to never use the restricted set of copies for this hold targe...
miker [Thu, 10 Jun 2010 13:55:47 +0000 (13:55 +0000)]
logic thinko causing us to never use the restricted set of copies for this hold targeting round, and instead use all good copies, when in max_loop mode

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16647 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agodrop copy transparency tables
gmc [Thu, 10 Jun 2010 13:18:23 +0000 (13:18 +0000)]
drop copy transparency tables

These tables were never used.

Signed-of-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16646 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agothinko
phasefx [Thu, 10 Jun 2010 00:58:06 +0000 (00:58 +0000)]
thinko

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16645 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoSome python code is non-executable (script_x_check updated)
atz [Wed, 9 Jun 2010 21:44:00 +0000 (21:44 +0000)]
Some python code is non-executable (script_x_check updated)

This corrects an overreach on the earlier patch.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16644 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years ago</link> is not valid HTML
atz [Wed, 9 Jun 2010 21:43:59 +0000 (21:43 +0000)]
</link> is not valid HTML

Although the DTD *may* specify xhtml, since in practice we are serving
with Content-Type: text/html and
  <meta http-equiv="Content-Type" content="text/html;charset=utf-8" />
we should avoid tags that are illegal in html.

These errors are reported in chrome as:
    "Unmatched </link> encountered.  Ignoring tag."

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16643 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoEDI Translator (relocated and combined)
atz [Wed, 9 Jun 2010 21:43:58 +0000 (21:43 +0000)]
EDI Translator (relocated and combined)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16642 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoRewrote the implementation of the open-ils.qstore.columns method.
scottmk [Wed, 9 Jun 2010 21:39:12 +0000 (21:39 +0000)]
Rewrote the implementation of the open-ils.qstore.columns method.

The old implementation examined the SELECT clause(s) as encoded
in the query.select_item and query.expression tables.  The new
implementation performs a dummy query, and then returns the
field names from the database result.

Advantages of the new implementation:

1. It doesn't get confused by wild cards in the SELECT clause.

2. It provides a field name for every column, including those
which are function calls, subqueries, or other expressions.
(Of course these names may not be very revealing, such as
"?column?".)

Disadvantages:

1. The resulting field names are not qualified by table name.

2. Additional overhead due to the additional database call.

M    Open-ILS/src/c-apps/oils_storedq.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16641 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agotypo
phasefx [Wed, 9 Jun 2010 20:15:18 +0000 (20:15 +0000)]
typo

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16640 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoIn the patron editor, ensure that the Verify Password field matches the Password...
phasefx [Wed, 9 Jun 2010 20:06:25 +0000 (20:06 +0000)]
In the patron editor, ensure that the Verify Password field matches the Password field to validate

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16639 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoBugfix cleanup of stray tags
atz [Wed, 9 Jun 2010 19:10:52 +0000 (19:10 +0000)]
Bugfix cleanup of stray tags

<strong> had mismatched nesting and </img> was completely orphaned.

Signed-off-by: Joe Atzberger <atz@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16638 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agotype is a required attributed for script and style tags.
atz [Wed, 9 Jun 2010 19:10:50 +0000 (19:10 +0000)]
type is a required attributed for script and style tags.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16637 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoExecutable scripts
atz [Wed, 9 Jun 2010 19:10:47 +0000 (19:10 +0000)]
Executable scripts

These were all found by ./build/tools/script_x_check.sh

Signed-off-by: Joe Atzberger <atz@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16636 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoupdate GPL 2.0 text in the staff client license statement
gmc [Wed, 9 Jun 2010 18:55:03 +0000 (18:55 +0000)]
update GPL 2.0 text in the staff client license statement

Also fixed last reference to the FSF's old mailing address

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16635 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoupdated license text with current GPL 2.0 text
gmc [Wed, 9 Jun 2010 18:41:05 +0000 (18:41 +0000)]
updated license text with current GPL 2.0 text

NOTE: THIS IS NOT A SEMANTICALLY IMPORTANT CHANGE TO EVERGREEN'S LICENSE.

Updated LICENSE.txt by pulling the current GPL 2.0 text
directly from http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt

The changes are purely textual, and consist solely of:

* updating the FSF's mailing address
* changing references to the "GNU Library General Public License"
  to "GNU Lesser General Public License", per the FSF's current
  (and long-standing) practice
* whitespace changes

REPEAT: THIS IS NOT A RELICENSING

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16634 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agowrong URL
phasefx [Wed, 9 Jun 2010 17:52:58 +0000 (17:52 +0000)]
wrong URL

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16633 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agofix references to ersatz "as_unimarc" method in MARC::Record
gmc [Wed, 9 Jun 2010 15:37:52 +0000 (15:37 +0000)]
fix references to ersatz "as_unimarc" method in MARC::Record

No such method exists in MARC::Record; MARC::Record->as_usmarc()
should be used instead; think of as_usmarc() as if it were
named as_iso2709_blob().

As general note, UNIMARC support in Evergreen is currently
rather theoretical at this point.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16632 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agono includes in fm_IDL.xml
phasefx [Wed, 9 Jun 2010 15:32:02 +0000 (15:32 +0000)]
no includes in fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16631 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoexplicitly allow SSI for these locations. Important for Apache on Redhat, etc.
phasefx [Wed, 9 Jun 2010 15:26:31 +0000 (15:26 +0000)]
explicitly allow SSI for these locations.  Important for Apache on Redhat, etc.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16630 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoRecognize new "required" and "validate" attributes for <field> element.
scottmk [Wed, 9 Jun 2010 04:57:10 +0000 (04:57 +0000)]
Recognize new "required" and "validate" attributes for <field> element.

M    Open-ILS/src/c-apps/idlval.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16629 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years ago1. Support function calls in the FROM clause.
scottmk [Tue, 8 Jun 2010 21:01:27 +0000 (21:01 +0000)]
1. Support function calls in the FROM clause.

2. Support wildcards in the SELECT clause.

WARNING: the presence of a wildcard in the SELECT clause
is likely to disrupt a GROUP BY by renumbering the columns.

Also: the "columns" method currently cannot return the
names of the columns into which a wild card is expanded.

M    Open-ILS/include/openils/oils_buildq.h
M    Open-ILS/src/c-apps/oils_storedq.c
M    Open-ILS/src/c-apps/buildSQL.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16628 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoprotect against empty results from bib searches caused by
erickson [Tue, 8 Jun 2010 16:14:31 +0000 (16:14 +0000)]
protect against empty results from bib searches caused by
search timeouts.  This allows the API call to log the error
and return reasonable results

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16625 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoSplit the ingest trigger logic into bits, simplifying optimization and configuration
miker [Tue, 8 Jun 2010 15:26:24 +0000 (15:26 +0000)]
Split the ingest trigger logic into bits, simplifying optimization and configuration

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16624 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Galen Charlton:
miker [Tue, 8 Jun 2010 13:46:33 +0000 (13:46 +0000)]
Patch from Galen Charlton:

[This] patch adds a new XSL transform for indexing purpose that converts MARC21 880 fields (which are used for alternate graphic representations, i.e., vernacular representations of foreign language strings) to the base tags.

For example, if a MARC record for a Chinese book has

245.00 $6 880-01 $a Ba shi san nian duan pian xiao shuo xuan
880.00 $6 245-01/$1 $a\u516b\u5341\u4e09\u5e74\u77ed\u7bc7\u5c0f\u8aaa\u9078

this stylesheet will transform it to the equivalent of

245.00 $6 880-01 $a Ba shi san nian duan pian xiao shuo xuan
245.00 $6 245-01/$1 $a\u516b\u5341\u4e09\u5e74\u77ed\u7bc7\u5c0f\u8aaa\u9078

This allows an indexing XPath like //marc:datafield[@tag='245']/marc:subfield[@code='a'] to bring in both the vernacular and transliterated versions of the 245$a.

[ED: pretend the \u-encoded unicode are real characters ... curse you, Chrome, for not giving me the raw string!]

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16623 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoconfig.metabib_field_index_norm_map params must be valid json; see also upgrade...
erickson [Mon, 7 Jun 2010 21:28:59 +0000 (21:28 +0000)]
config.metabib_field_index_norm_map params must be valid json;  see also upgrade 0271

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16622 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agodoh, too quick on the commit. :) fix the dupe-barcode test
phasefx [Mon, 7 Jun 2010 20:03:33 +0000 (20:03 +0000)]
doh, too quick on the commit. :)  fix the dupe-barcode test

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16621 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agore-adds the duplicate-barcode check that was lost with the new patron editor. TODO...
phasefx [Mon, 7 Jun 2010 20:00:13 +0000 (20:00 +0000)]
re-adds the duplicate-barcode check that was lost with the new patron editor.  TODO: disable the save buttons when there are form errors

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16620 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdd the left_operand column to the query.expr_xbet view
scottmk [Mon, 7 Jun 2010 19:31:05 +0000 (19:31 +0000)]
Add the left_operand column to the query.expr_xbet view
(correcting an oversight).

M    Open-ILS/src/sql/Pg/002.schema.config.sql
M    Open-ILS/src/sql/Pg/008.schema.query.sql
A    Open-ILS/src/sql/Pg/upgrade/0298.schema.xbet-left-operand.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16619 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years ago1. Add table: serial.caption_and_pattern
scottmk [Mon, 7 Jun 2010 18:41:21 +0000 (18:41 +0000)]
1. Add table: serial.caption_and_pattern

2. In serial.record entry: make "marc" row nullable.

M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0297.schema.serial-caption-and-pattern.sql
M    Open-ILS/src/sql/Pg/210.schema.serials.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16618 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Galen Charlton:
miker [Mon, 7 Jun 2010 18:14:46 +0000 (18:14 +0000)]
Patch from Galen Charlton:

Add foreign key to require that each row in metabib_field has a corresponding XML format.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16617 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoI'm not a fan of I18N-effort on debug output meant for developers. In this case...
phasefx [Mon, 7 Jun 2010 17:55:13 +0000 (17:55 +0000)]
I'm not a fan of I18N-effort on debug output meant for developers.  In this case, the wrong preferences file was being referenced, causing an error

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16616 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoPatch from Galen Charlton:
miker [Mon, 7 Jun 2010 16:53:55 +0000 (16:53 +0000)]
Patch from Galen Charlton:

Fix glitch in definition of the new default identifier indexes that would cause bib ingest to fail.  Note that this affected only newly-created databases; the upgrade script for 0265 is correct.

Thanks to Lee Dickens for running into this bug.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16615 dcc99617-32d9-48b4-a31d-7c20da2025e4