Galen Charlton [Thu, 27 Aug 2015 22:23:23 +0000 (22:23 +0000)]
webstaff: add routine for Dojo JS to detect if running in iframe
Sometimes legacy Dojo interfaces may need to adjust their
behavior if they're embedded in the web staff client. This patch
adds a new utility function, openils.Util.inIFrame(), to detect
if such code is running in an iframe. If so, the presumption
is that iframe belongs to the web staff client.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
This commit removes the references in the docs to the now removed JSPAC,
and replaces all known remaining JSPAC screenshots, and when required
updates the descriptions to match TPAC features. It also fixes AsciiDoc
ordered list syntax in a few cases, which interfered with testing.
Michael Peters [Thu, 4 Dec 2014 20:56:53 +0000 (15:56 -0500)]
LP#1361266 Patron self-registration form accepts date of birth in wrong format
This patch applys some basic javascript to validate that a date entered is
at least in ISO 8601 format. This prevents someone from entering "cupcake"
or 55/66/6666 as a valid date of birth by validating the stgu.dob input
at the time of submission.
Signed-off-by: Michael Peters <mpeters@emeralddata.net> Signed-off-by: Josh Stompro <stomproj@larl.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
If no search parameters or invalid search parameters are sent to the
patron search API, the API call exits early with zero results. This
avoids cases where empty searches can lead to heavy DB calls, querying
and sorting he entire patron data set.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
The fix for LP 1484281 broke the 0847.auth_overlay_generator.pg live
test. Since e was removed from the controlled subfield list for the
100 authority tag, it needs to be removed from the expected live test
results.
This commit does that.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Yamil Suarez [Mon, 17 Aug 2015 20:47:34 +0000 (16:47 -0400)]
LP# 1484281 auth control config update to prevent propagated data deletion
Remove subfield 'e' from authority.control_set_authority_field seed values
Removed from the auth tag 100 and 110, which should apply to bib tags
100,110,600,610,700,710
Added upgrade script, and pgTAP test.
How to test this patch
----------------------
[1] To test this bug you need 1 authority record and at least 1 bib record.
The auth record needs to have an auth 100 or 110 tag that has a subfield $e,
for example 100 $aDavis, Miles $ecomposer. (for the record, it is not good
cataloging practice to have $e in the auth record, but it can happen by mistake.)
The bib record needs to be have a matching bib 100 or 700 tag with the same
subfield $a and $e. In addition the matching bib tag has to be linked to the
authority record, i.e. the bib tag has to have a bib subfield $0 with the DB
id of the authority record.
[2] If you open up the authority record, in the authority MARC editor, and remove
the subfield $e; the subfield $e found in the bib record tag will be removed.
This is a mistake because normally bib record tags 100/110/700/710 do use subfield
$e, though the subfield $e should not be used in the auth record 100/110 tags.
[3] When this patch is applied, if a cataloger removes a subfield $e from an auth
100/110 tag, the deletion will not cascade to its linked bibs.
Signed-off-by: Yamil Suarez <yamil@yamil.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Thu, 20 Aug 2015 17:32:28 +0000 (17:32 +0000)]
LP#1487143: remove legacy_script_support from example SIP config
This patch removes the legacy_script_support option (and the
related references to the scripts themselves) from the example
SIPServer config, as they now have no effect.
Existing Evergreen sites can choose to remove those configuraiton
options or leave them in.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Wells [Fri, 14 Aug 2015 19:11:16 +0000 (15:11 -0400)]
LP#1484989 Don't close xacts with checkin-generated fines
If a transaction has checkin-generated fines, and previously had a
balance of zero, the rearranged billing code was prematurely closing
the transaction. This commit separates the closing step to run after
any possible fine generation.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Ben Shum [Wed, 19 Aug 2015 22:11:18 +0000 (18:11 -0400)]
LP#1484650: Missing webstaff2pot make target for newpot
Seems that something went awry with the commit I submitted for pullrequest
and we missed the actual change to make the webstaff client file for
translation.
Dan Pearl [Wed, 14 Nov 2012 17:14:11 +0000 (12:14 -0500)]
LP# 1086934 - TPAC: Complete column sorting in some screens
(specifically holds, circs, and circs_history)
An earlier LP issue #1010277 concerned the halfway implementation of
the column sort facility, and was addressed at the time by ripping out any hint of
column sort capability, among other cleanup issues.
The sorting capability has now been implemented with the following functionality:
* Clicking on the appropriate column heads now sorts the contents from
"ascending" to "descending" to "no sort". (The "no sort" will restore the
original list as presented to the patron.)
* The sort indicator (an up or down arrow) is placed to the right
of the column head, as appropriate.
* The combined "Title/Author" column in the circ screens is now separated into two
independently sortable columns (Title and Author).
* Title sorting is done with the 'filing' characters (leading "the", "a",
"an", and other langugage equivalents) removed. To clarify the
behavior for the patron, the leading articles are rendered in
a smaller font, so as to keep the main entry prominent. In
addition to the filing characters removed for the sort, leading
non-alphanumeric characters are ignored in the sort.
This commit only affects those screens and columns that suggested column sorting
capability.
Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/templates/opac/parts/topnav.tt2
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Wed, 15 Apr 2015 16:10:27 +0000 (12:10 -0400)]
LP#1438136: Teach QP to be smart about attribute selectivity
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Josh Stompro [Mon, 17 Aug 2015 18:45:16 +0000 (13:45 -0500)]
LP#1124498 - Changed hook name so it includes a prefix to make it clear
it is for actor.usr, and changed the hook description so it matches
the other au hooks. I added "account" because I hate to say "A user has
expired", when there might be a field for deceased status at some point.
Signed-off-by: Josh Stompro <stomproj@larl.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Expand safe token generation to include user ID in the cached data,
which can be retrieved later for activity logging. Add activity logging
directly to the open-ils.actor.safe_token.home_lib.shortname API.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Josh Stompro <stomproj@larl.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
New "Adjust to Zero" option in patron billing UI. Selected
transactions are updated to have a zero balance by rebilling
and/or adding adjustments as required.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
API call for manually adjusting a transaction to zero. It works
by rebilling previously voided billings (if necessary) until a
positive balance is reached, then applying adjustment payments
to zero out the balance.
Dan Wells [Tue, 18 Aug 2015 16:10:28 +0000 (12:10 -0400)]
LP#1479107 Fix IDL classname for account adjustments
This table went through two name changes, and left some debris along
the way. Let's standardize on the default choice of 'maa' for the IDL
classname abbreviation.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Dan Wells [Tue, 18 Aug 2015 14:42:27 +0000 (10:42 -0400)]
LP#1479107 Move VOID_BILLING perm check to top-level API
Pemission checks are needed at entry points, but can lead to
undesirable consequences if checked during automated processing. In
the case of voids, let's move the perm check up to make sure our
automated processing can complete.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
* change binding of marc_xml
* implement edit-then-overlay
* add search-in-progress indicator
* implement display of total hit count
* implement remove fields on import
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
webstaff: web staff: teach MARC editor how to work in-place
This patch adds an "in-place" mode to the MARC editor for
cases where client-side MARC munging is needed without
immediately saving the results to the database.
To use, include in-place-mode="true" in the eg-marc-edit-record
directive.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
* add grid actions
* fix markup
* add view MARC action
* improve name of check for disabling actions that
require at least one result to be selected
* display cover image on view MARC modal
* add Z39.50 raw search capability
* implement selecting local record for overlay
* implement record overlay with confirm
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
webstaff: Fixed-position navigation menu for web client
Changes the class for top-navbar so that it stays fixed at the top of the
screen. This is useful for staff who will need to quickly jump to another
area of the client after they have scrolled down a page.
Initially, changing the class shifted some of the content higher so that the
navbar was covering some elements. I addressed this by adding some padding to
Many thanks to Jason Etheridge for pointing me in the right direction to get
started.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
* add widget to show/hide search form
* add more vertical space between search form and results table
* forgo a label on the results table
* make Z39.50 search results non-multiselect-able
* implement edit-then-import
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Tue, 9 Jun 2015 22:10:18 +0000 (22:10 +0000)]
webstaff: Z39.50 search and import interface
- fetch configured Z39.50 targets
- can now select targets
- search field form now active
- can now retrieve results
- check for empty query correctly
- retain reference to target list
- preserve search query input when toggling Z39.50 target selection
- implement clear form handler
- allow enter key to submit search
- track index of Z39.50 results so that individual ones can be selected
- note results of experiences to make the title be conditionally a hyperlink
- implement show in catalog
- implement direct import Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
LP#1472787: fix expansion of wildcard eg-grid-field paths
This fixes a bug where expansion of wildcard egGridField
paths didn't handle a plain "*" correctly.
To test:
[1] In the web staff client, bring up the list of a patron's
current loans. Add the grace period column to the grid,
but note that the loans' grace period values are not
actually displayed.
[2] Apply the patch.
[3] Refresh the browser and repeat step 1. This time, the
grace period values are displayed.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
projects / working / Evergreen.git / log