The crux of this patch is to rethink how we handle the volume-only
editing interface. Previously, we were attempting to distinguish
between when the volume was the only thing *showing* and when it
was actually the only thing *existing*.
We have now removed that distinction, so the volume-only interface
only cares about the volume regardless of the possible presence of
a copy. This simplifies the interface logic, and reduces or
eliminates the chance of the hidden copy editor interfering with
the volume adding/editing functions.
Other smaller changes here include:
- Teach the edit function to pick up copy-less "empty" call numbers
- Reduce and clarify the arguments to spawnHoldingsAdd
We had three arguments, but two were simply inversions of one another
in every case. Reduce to two arguments and give them more meaningful
labels
- Fix typo ("emtpy") preventing proper button disabling for blank call
numbers
- Move call number emptiness check from updateLabel() function to value
watch instead. This ensure that any updates to that value (even those
not using the update function) will flip the flag appropriately. This
fixes a timing bug which prevented call numbers from being saved
without further edits in some cases.
Ultimately, as J. Boyer suggests, we would be better off not generating
the copy editor at all (rather than just hiding it), but we're a few
steps off from that yet.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Mike Rylander <mrylander@gmail.com>
The new ability to add empty volumes was causing the existing
ability to add new volume/copy combos to not work as expected.
More specifically, added volume/copy combos would not generate
in the selected org_unit, but always in the ws_ou.
- Existing code distinguishs 'adds' from 'edits' via two wrappers,
spawnHoldingsAdd and spawnHoldingsEdit. With this commit, empty volume
adding now extends the 'add' function rather than the 'edit' one, as
this seems more intuitive.
- The previous change had extended both the catalog app and another
similar directive which is only used in a merging context. Since the
merge context had no ability to add anything, and the new code was not
wired up to the interface, this has simply been removed (for now).
- The volcopy app is set up around the concept of passed in
'prototype' vol/copy objects of varying degrees of completeness. It
then loops over these to generate the interface. The previous code
extended this setup with a loop over a potential 'owners' array to
generate empty volumes, but this unrelated loop within a loop seemed
counterintuitive (and was the source of the original bug). This change
has been removed, and empty volume creation now hews more closely to
the original model.
While this commit appears large, when viewed in the context of the
pre-920f58505 code, it is quite limited in scope.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Mike Rylander <mrylander@gmail.com>
When the appropriate checkbox is selected, display subordinate libraries of
the context library that do not have any holdings or empty volumes.
Additionally, the holdings view checkboxes for limiting detail display can
cause console alerts, and should be made visually interdependent. This commit
addresses both of those issues.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Mike Rylander [Thu, 12 Jul 2018 15:03:44 +0000 (11:03 -0400)]
LP#1710401: Z39.50 should notice overlay target change
Currently, we record the overlay target at UI startup and use that going
forward until the interface is reloaded. This commit inspects the local
storage version of the target for changes and offers the user the chance to
proceed with the new target or cancel the action. If the target has been
unset, the user is given the option of proceeding with the load-time target.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Boyer [Thu, 21 Jun 2018 11:17:48 +0000 (07:17 -0400)]
LP1773452: Repeating copy alerts
Without considering the checkin_time on the most
recent circ for an item, checking in a lost, claims
returned, or claims never checked out item would
cause copy alerts on checkin repeatedly until it
was checked out again. Staff may be confused by this
thinking that there is a continuing problem with
the item until the alerts go away.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop> Signed-off-by: Mike Rylander <mrylander@gmail.com>
LP 1478712: Fix acq.fund_rollover_funds_by_org_tree DB function.
When looking for new funds, we need to also use the org unit from the
old fund because different org units may use the same fund code. What
happens without this check is the second library to rollover ends up
assigning their rolled over debits to the first library that rolled
over or propagated funds with the same code.
Unfortunately, I do not know of a good way to test this branch with
the concerto data. I will elaborate how I tested with a copy of our
production data in a test database below.
What I did to test with our production data was first to repair the
debits that had been moved to the wrong library's funds from the
previous year. I then ran the acq.rollover_funds_by_org_tree function
for two libraries that share acq fund codes. I verified that the fund
debits for the second library did indeed get assigned to funds with
the same code that were rolled over for the first library. The debits
ended up on the newly propagated funds of the library that went first.
I reloaded the database, replaced the acq.rollover_funds_by_org_tree
function with the implementation from this branch, and repeated the
above steps. The second library's debits rolled over to new funds
owned by that library as was expected.
This would be a good candidate for a pgtap test with additional data
added to concerto if anyone is feeling ambitious.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
When doing a re-bill, we were aborting too early when it rebilled to
exactly zero. Move the 'zero' check to the top of the loop, and
thereby make sure we check if the xact can be closed if we do any
adjustment, up or down.
To test:
- Run new billing test from previous commit, see it fail
- Apply patch
- Run tests again; all should pass
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Allow deleted copies to be checked in from the patron items out list.
Checkin is based on copy ID instead of barcode. Note that both values
are sent to the server, to reduce the number of changes in the UI code,
but the API inspects the ID first.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
In the work to separate the item service into a reusable component, a
reference to $scope was left hanging around. This causes the service to die
before it can complete its work. The code using $scope does seem to be
necessary, so we'll have the function accept an outer_scope parameter and
adjust the call sites.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
This patch is the belt to the previous patch's suspenders and ensures
that the web staff client does not attempt to authority-validate headings
fields in the MARC editor if they're empty (i.e., no subfield values).
To test
-------
[1] In the web staff client, create a new bib. Ensure that at least one of the
authority-controlled fields has no subfield values.
[2] Hit the Validate button.
[3] Note that the field(s) with empty headings show the tick
mark indicating that they've been "validated".
[4] Apply the patch and repeat steps 1 and 2. This time, empty headings
field should not be checked.
[5] Verify that validating headings that are not empty does continue
to work.
Patch inspired by Mike Rylander.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Galen Charlton [Thu, 25 Jan 2018 19:40:47 +0000 (14:40 -0500)]
LP#1745462: guard against scanning entire authority table
This patch ensures that if, for whatever reason, a MARC editor headings
validation action includes a field whose subfield values are empty, it
ignores any cases where the normalized heading works out to NULL or the
empty string. Otherwise, the database can be asked to fetch the IDs
of most/all records in the database, and open-ils.cstore backend can be
asked to store the entire result set in memory.
To test
-------
[0] Ensure that statement logging is turned on in the PostgreSQL database.
[1] In the web staff client, create a new bib. Ensure that at least one of the
authority-controlled fields has no subfield values.
[2] Hit the Validate button.
[3] Note that the following query is logged by the database:
SELECT "are".id AS "id" FROM authority.record_entry AS "are"
WHERE "are".control_set = '1'
AND "are".deleted = 'f' AND "are".simple_heading IS NOT NULL;
[4] Apply the patch and repeat steps 1 and 2. This time, note that
no such query is recorded.
[5] Verify that validating headings that are not empty does continue
to work.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Display the 'route to cataloging' alert every time a precat copy is
checked in, consistent with the XUL client, instead of displaying
it only with the first checkin.
As with the first checkin, if the alert is configured not to display,
it will not show.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Galen Charlton [Tue, 27 Mar 2018 18:56:23 +0000 (14:56 -0400)]
LP#1746566: Enable 500, 1K, and all rows in more patron grids
This enables the allowAll option in the Patron Items Checked Out
and Other/Special Circulations grids.
To test
-------
[1] Apply the patch.
[2] Verify that the Patron Items Checked Out, Other/Special Circulations,
Non-Catalogued Circulations, and Holds grids now include row
count options 500, 100, and All.
[3] Verify that the Item Status grid now includes the additional
row count options.
[4] Verify that when choosing the "All" row count that you are prompted
to confirm loading all of the rows.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Cesar Velez [Wed, 7 Feb 2018 17:05:10 +0000 (12:05 -0500)]
LP#1746566: Enable 500, 1K, and ALL-the-Rows in patron grids
This adds to the Patron (non-catalogued) Items Out, Patron Holds, and
Item Status grids an 'allowAll' grid feature which will enable the 500,
1K, and ALL (really 10K) rows/pagesize. For the ALL option a modal has
been wired to that the action can be confirmed, since it might be a
very slow operation.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Galen Charlton [Mon, 22 Jan 2018 23:01:00 +0000 (18:01 -0500)]
LP#1745207: tie together copy_tag() and site() search filters
The copy_tag() filter will now restrict itself to records that
have copies that both have matching copy tags and a circ_lib
within the site() scope.
To test
-------
[1] Define two digital bookplate copy tags at two difference org units, e.g.,
"BR1 Smith" at BR1 and "BR4 Smith" at "BR4".
[2] Arrange that a record has items in both BR1 and BR4, and assign the "BR4 Smith"
copy tag to one of the BR4 items.
[3] On a separate record, set up a similar situation, but use BR1 instead.
[4] Enable the digital bookplate search option and do a bookplate search
for "Smith" with the scope limited to BR1.
[5] Note that both of the records set up in #2 and #3 are included in the results
set.
[6] Apply the patch and repeat step 5. This time, only the record set up in #3
should be included.
Michele Morgan [Thu, 14 Sep 2017 15:48:31 +0000 (11:48 -0400)]
LP#1692116 - Action trigger validator fix for paid Long Overdue items
Adds a check for a NULL xact_finish to the CircIsOpen validator. The
result is that overdue notification a/t events for Long Overdue items that
have been paid for, and the transaction closed, will be invalid.
Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Etheridge [Tue, 10 Jul 2018 23:46:04 +0000 (19:46 -0400)]
lp1739286 default search box in Z39.50
This change tweaks the layout of search fields in the web client Z39.50
interface and adds radio buttons for the default search field to auto-focus.
The behavior is "sticky" without the need for an explicit Save action. If the
current default field is not present due to a given combination of selected
services, then no field will be focused by default.
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Boyer [Mon, 9 Jul 2018 16:47:10 +0000 (12:47 -0400)]
LP1736243: SMS Carrier Editing in Patron Editor
The XUL Client treats many user setting entries as
quoted strings. Angular needs some help to recognize
that it needs to convert these incoming "strings"
to ints for use as the data model when editing. The
str-to-int directive gives it this hint.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Boyer [Fri, 29 Jun 2018 18:09:51 +0000 (14:09 -0400)]
LP1779392: Stop sending broken queries
It's possible to send invalid parameters to the
search.highlight_display_fields function which
wastes a db roundtrip and fills the logs with
errors. Checking to be sure there's anything in
the parameter will prevent both.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Kathy Lussier [Fri, 1 Jun 2018 13:51:07 +0000 (09:51 -0400)]
LP#1635386: Restore to xul colors and remove colors from class names
This commit restores the xul display where overdue items were highlighted
in red and long overdue items were highlighted in orange. Also removes
the colors from the class names since people may decide to use totally different
colors or style the rows in different ways.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Wells [Fri, 23 Mar 2018 21:21:36 +0000 (17:21 -0400)]
LP#1635386 Clarify and simplify row highlighting code
The existing code had a few functional problems for me. In the process
of fixing them, I decided it best to also apply a number of small
refactorings. Here is a list of changes in rough order of significance:
-Made the new CSS classes test and apply once per row rather than once
per cell
-Fixed the test case for overdues: we now just look for no checkin-time
+ no lost/long-overdue stop-fines (matches XUL test)
-Made the color and icon tests totally consistent, and also simplified
where possible
-Made the widened configuration header style (to accommodate status
column) functional again (it was using old 'statusicon' class)
-Made row highlight colors '!important' to avoid bad interactions with
alternating row color styles
-Changed status-cell (and statusCell) to status-column (and
statusColumn) for a little extra clarity
-Changed nested function name from 'rowClass()' to 'apply()' for greater
code distinction (i.e. avoid 'rowClass.rowClass()' calls, and instead
have 'rowClass.apply()')
-Removed some unused variable assignments from grid.js
-Cleaned up a few field attributes for necessity and consistency
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Kathy Lussier [Tue, 30 Jan 2018 20:51:13 +0000 (15:51 -0500)]
LP#1635386: Improve contrast for colors used in Bills interface
The contrast between cell contents and background colors did not
meet WCAG standards. This commit provides adequate contrast to
meet AA level of WCAG standards. The red and dark red background
colors are similar to what we saw in the XUL client. The orange
for long overdue is much lighter.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Kyle Huckins [Fri, 17 Nov 2017 23:54:53 +0000 (23:54 +0000)]
lp1635386 Items Column & Styles for Bill Item Status
- CSS classes for red, dark red, and orange eg-grid-cells.
- New parameter for eg-grid 'rowClass' to take an object with a function
to set the class of a cell, allowing such customizations as coloring based
on item fields.
- Implementation of 'rowClass' on the Patron Bills interface to display
colors indicating current Fines Stop reason, based on XUL client.
- New parameter for eg-grid 'statusCell' to take an object with a function
to programattically add status icons to a new "Status Icon" column. Said
column requires a boolean in the object in order to display.
- Implementation of 'statusCell' on the Patron Bills interface to display
glyphicons based on if the bill is for a circ that is lost, overdue, or long
overdue.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/templates/staff/circ/patron/t_bills_list.tt2
modified: Open-ILS/src/templates/staff/css/style.css.tt2
modified: Open-ILS/src/templates/staff/share/t_autogrid.tt2
modified: Open-ILS/web/js/ui/default/staff/circ/patron/bills.js
modified: Open-ILS/web/js/ui/default/staff/services/grid.js
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Mike Rylander [Wed, 20 Jun 2018 13:22:38 +0000 (09:22 -0400)]
LP#1773832: Empty deleted records can be surfaced in search results
There are cases where we avoid checking the deleted flag of bibs as an
optimization that avoids a JOIN in the search query. However, for some
shapes of real-world data, particularly in upgraded instances, deleted
records can slip through. This commit adds an explicit check for the
flag to all search queries.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Daniel Pearl <dpearl@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Added an index to action.usr_circ_history for much needed postgresql justice.
This will increase the speed when deleting patrons with large number of circulations.
Signed-off-by: blake <blake@mobiusconsortium.org> Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Jason Stephenson <jason@sigio.com>
Jason Boyer [Mon, 21 May 2018 16:09:09 +0000 (12:09 -0400)]
LP1772444: Add Patron Names to Bill Receipts
The bills_current and bills_historical receipt templates
were missing patron information. This has been added to
match most other receipt templates (money_summary is not
included since it could potentially be stale).
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Fixes DoB parsing in the browser client patron edit interface by
creating date objects from a whole YMD date string instead of compiling
the date as collection of pieces. Compiling dates from pieces (calling
setFullYear(), setMonth(), etc.) can have unexpected consequences,
because a change of month can result in a change of days as well, if the
number of days in the date object exceeds the capacity of the selected
month.
For example:
---
> d = new Date()
2018-05-31T14:59:26.186Z
> d.setMonth(1) 1520092766186
> d
2018-03-03T15:59:26.186Z
--
Parsing as Date(YYYY,MM,DD) instead avoids this kind of shuffling.
To test
[1] Log in to the staff client on the 31st day of the month :)
[2] Change a patron's DoB to a month that does not contain 31 days.
[3] Save patron and note on reload, the DoB shows the wrong value.
Remington Steed [Thu, 14 Jun 2018 13:31:33 +0000 (09:31 -0400)]
Docs: Minor corrections to "Borrowing items" section
This commit fixes a number of small inconsistencies in wording (between
the docs and the interface) and formatting (e.g. making menu names bold).
Also, one sentence is expanded for clarity.
This patch changes how the web staff client retrieves the list
of billing types available for use by the Bill Patron modal. PCRUD
permissions on config.billing_type don't quite match how the
the set of billing types available to a staff user used to work
in the XUL staff client, so this patch uses the
open-ils.circ.billing_type.ranged.retrieve.all method instead.
To test
-------
[1] Log in as a Circulators staff user (assuming stock data
and permissions).
[2] Try the Bill Patron dialog in the web staff client; note that
no billing types are accessible.
[3] Apply the patch and repeat step #2. This time, it should
include the miscellaneous billing type.
Dan Pearl [Thu, 7 Jun 2018 18:20:49 +0000 (14:20 -0400)]
LP1739271 - Fix Item Edit when Part Present
Cannot edit item or call number after mono part
assigned. This was indeed a timing error where parts were referenced before
they were completely assigned to the structure in which they were to reside.
I have restructured the code to ensure the parts are available.
Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Cesar Velez [Fri, 16 Feb 2018 16:01:23 +0000 (11:01 -0500)]
LP#1745422 - Add Parts column to Patron holds grids and detail view
The webstaff's patron ui did not have a display for the Part,
which will be fetched for any hold type "P" (monographic part).
This adds a Part column to the hold grids and inthe detail view
IF the hold type is P, it'll append the part.label in the same
field/well.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Remington Steed [Thu, 31 May 2018 17:59:30 +0000 (13:59 -0400)]
Docs: Add bullet number images removed in 2.10
These number images are used by the code callout feature of AsciiDoc,
used by the new Receipt Template Editor chapter (and possibly other
docs). I had renamed them in 2015, supposedly to prevent an ePub build
error, but that broke the code callout images. And since I cannot
replicate the ePub error now, I am renaming them back to their original
state, with sincere apologies to code callout readers everywhere.
Mike Rylander [Mon, 29 Jan 2018 21:37:15 +0000 (16:37 -0500)]
LP#1707063: Naive ng-class test for last-column-modified
Instead of comparing a (potentially undefined) property of a column, we'll
just compare the column object directly when checking to see if a column
header should be highlighted for "last touched in editing mode."
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Avoid modifying the copy status in the hold-reset API when it's passing
the copy off to the transit API for canceling the transit. Let the
transit API handle the status instead.
This fixes a bug where resetting a transiting hold, and canceling its
transit, would leave the targeted copy in "in transit" status instead of
"canceled transit".
Patron barcodes in the patron search grid are now click-able, making it
possible to quickly open multiple patrons in new tabs from patron search
by control-clicking (or middle-clicking) the barcode links.
Cesar Velez [Fri, 30 Mar 2018 15:32:45 +0000 (11:32 -0400)]
LP#1759352: improve webstaff fix checkout specific due date UX
The Date Options dropdown UI added as a result of bug 1717025
hides the state of the "checkboxes" for custom due date and
the datepicker wasn't disabled when custom due date was disabled.
This addresses these UX issues, to that the user has visual feedback
as to the state of that option.
Jason Stephenson [Tue, 10 Apr 2018 14:51:24 +0000 (10:51 -0400)]
LP#1751126: Make print holds shelf list aware of clear mode.
We change the Print Full List button on the holds shelf view to be
aware of whether clear mode is active. If clear mode is active, then
the list of holds to clear is printed. If not, then the full holds
shelf list is printed.
This commit does not change the label of the print full list button.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Dawn Dale <ddale@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Mon, 21 May 2018 16:28:39 +0000 (09:28 -0700)]
LP1772417: Adding the bucket ID to the user bucket display
To test:
1) Open a patron bucket. Note that the bucket ID is not listed
in the bucket information section at the top of this screen.
2) Apply this commit.
3) Open the same patron bucket. Note that the bucket ID is
listed in the bucket information section
If the lib.timezone org setting is not a valid timezone, attempting to
use it can result in an internal server error in the OPAC. Let's handle
the error with try/catch instead.
To test
-------
1. In Library Settings Editor, edit the "Library time zone" setting for
Example Branch 1, setting the value to something that's not the name
of a time zone (like "invalid" or "UTC-07:00").
2. In the OPAC, retrieve a record with holdings at Example Branch 1.
You will get an Internal Server Error.
3. Edit the library setting to use a valid timezone name, like
"America/Vancouver".
4. Retrieve the same record again. This time, the record will display
properly.
5. Apply the patch and repeat steps 1 and 2; this time, there should
be no internal server error.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Use the org unit linked to the provided workstation to collect the
login timeout org unit setting value during login. Previously, all
checks defaulted to the global org unit.
This patch solidifies the precedence order for OUS lookups during login
like so:
1. Workstation org unit.
2. API org unit value.
3. Users' home org unit.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Renamed the hold_id url param from "id" to "hid" and prevent it from
sticking in url's where it not needed.
To test
-------
[1] Log in to the public catalog as a patron that has at least
two hold requests.
[2] Go to the My Account holds tab and edit one of the holds.
[3] Rather than submit a change, click on the holds tab again.
[4] Note that /only/ the hold you were edit displays, and that the
'id' URL parameter persists as you navigate through the public
catalog.
[5] Apply the patch and repeat steps 1-3. This time, you should
see all of the holds.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Mike Rylander [Wed, 25 Apr 2018 16:32:15 +0000 (12:32 -0400)]
LP#1753005: Avoid copy alert error for call numbers with no copies
When displaying the Holdings View tab for a bib in the web staff client,
if a volume record has no copies, a Javascript error gets thrown.
Item-less volumes still end up in svc.copies at this point, so at the
moment it is necessary to check whether copy_alerts actually exists.
Some renaming might also be in order to clarify that svc.copies doesn't
necessarily contain /only/ fleshed acp records.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Mike Rylander [Fri, 4 May 2018 13:58:53 +0000 (09:58 -0400)]
LP#1755220: Return value checking in offline session fetch
We need to make sure that we receive the correct shape of data (array) rather
than that we simply got anything when fetching sessions. In the case of an
expired session token, we'll receive an ILS Event object informing us of the
expiration where we'd normally see a list of sessions.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dawn Dale <ddale@georgialibraries.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Garry Collum [Wed, 23 May 2018 23:47:56 +0000 (19:47 -0400)]
LP#1745240: Hold Alias Missing from Hold Shelf Slip
A patron's hold alias can be printed in the hold shelf slip using the variable patron.alias. This patch just adds 'patron.alias' to the list of available options displayed at the top of the template. Also adds a colon before the patron's name fields for consistency.
Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Garry Collum [Thu, 24 May 2018 02:17:38 +0000 (22:17 -0400)]
LP#1745232 - Bill History Receipt doesn't have Finish Date
Adds xact.finish and xact.summary.last_payment to the example data. Also adds xact.summary.last_payment_ts to the template body to indicate when the last payment was made. Also adds a list of variables that can be used in the template in the template's description.
To test -
1. apply the patch
2. find a patron with billings, or add some billings to a patron record.
3. make payments on some of the billings using various methods.
4. go to billing history and print the history list.
Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
projects / working / Evergreen.git / log