working/Evergreen.git
10 years agoFix a bug in pcrud.
scottmk [Thu, 8 Jul 2010 03:32:13 +0000 (03:32 +0000)]
Fix a bug in pcrud.

When checking a row for permissions, we often read a fresh copy of the
row in order to ensure that we have all the foreign keys that we need.
However in some cases (mainly when the class is a view), there is no
primary key, so we can't re-read the row.

Solution: if there is no primary key, don't try to do a fresh read.
Use the row image that we already have.

For these cases, this solution re-creates the possibility that we may
not have all the necessary columns.  There's no good way around that
problem.

M    Open-ILS/src/c-apps/oils_sql.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16873 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoLost my commit msg the first time around, so...
phasefx [Wed, 7 Jul 2010 18:48:38 +0000 (18:48 +0000)]
Lost my commit msg the first time around, so...

This CGI script might be useful for providing an easy way for EZproxy to authenticate users against an Evergreen instance.

For example, if you modify your eg_vhost.conf by adding this:
<Directory "/openils/var/cgi-bin/ezproxy">
    AddHandler cgi-script .pl
    AllowOverride None
    Options +ExecCGI
    allow from all
</Directory>

and make that directory and copy remoteauth.cgi to it:
mkdir /openils/var/cgi-bin/ezproxy/
cp remoteauth.cgi /openils/var/cgi-bin/ezproxy/

Then you could add a line like this to the users.txt of your EZproxy instance:

::external=https://hostname/cgi-bin/ezproxy/remoteauth.cgi,post=user=^u&passwd=^p

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16872 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoMerge branch 'browser'
phasefx [Wed, 7 Jul 2010 18:44:13 +0000 (18:44 +0000)]
Merge branch 'browser'

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16871 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoForward port of r16867: add missing event definition required by vandelay authority...
miker [Wed, 7 Jul 2010 17:13:41 +0000 (17:13 +0000)]
Forward port of r16867: add missing event definition required by vandelay authority import

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16870 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agodefine these variables as parameters
phasefx [Wed, 7 Jul 2010 14:25:05 +0000 (14:25 +0000)]
define these variables as parameters

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16866 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded OPAC support for 1) selecting SSL manually and having it stick and 2) forcing...
erickson [Wed, 7 Jul 2010 13:46:37 +0000 (13:46 +0000)]
added OPAC support for 1) selecting SSL manually and having it stick and 2) forcing SSL when the user is logged in to protect auth tokens and other private data.  The latter option is enabled via new apache env variable

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16865 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoupdated call number browse pass-thru to accommodate new copy location and status...
erickson [Wed, 7 Jul 2010 02:13:19 +0000 (02:13 +0000)]
updated call number browse pass-thru to accommodate new copy location and status filters

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16864 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadding status/copy_location filter support to call number browse
miker [Wed, 7 Jul 2010 00:29:37 +0000 (00:29 +0000)]
adding status/copy_location filter support to call number browse

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16863 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdd new program test_qstore, a command-line utility for testing
scottmk [Tue, 6 Jul 2010 21:08:08 +0000 (21:08 +0000)]
Add new program test_qstore, a command-line utility for testing
and exercising most of the code for the qstore server.

A    Open-ILS/src/c-apps/test_qstore.c
M    Open-ILS/src/c-apps/Makefile.am

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16862 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded opac user setting for default sort order for search results
erickson [Tue, 6 Jul 2010 20:52:39 +0000 (20:52 +0000)]
added opac user setting for default sort order for search results

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16861 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadjust code for an API change. Assume success if no ils_event
phasefx [Tue, 6 Jul 2010 20:28:59 +0000 (20:28 +0000)]
adjust code for an API change.  Assume success if no ils_event

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16860 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoshowing the more descriptive cc payment errors in self-check. printing CC payment...
erickson [Tue, 6 Jul 2010 19:30:04 +0000 (19:30 +0000)]
showing the more descriptive cc payment errors in self-check.  printing CC payment receipts from self-check.  added a commented-out cc type picker for possible future use

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16859 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoreturn IDs of newly created payments on success
erickson [Tue, 6 Jul 2010 19:30:03 +0000 (19:30 +0000)]
return IDs of newly created payments on success

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16858 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoCC payments: address situations where Business::CreditCard::validate() returns
senator [Tue, 6 Jul 2010 19:06:56 +0000 (19:06 +0000)]
CC payments: address situations where Business::CreditCard::validate() returns
true yet Business::CreditCard::cardtype() returns the string "Unknown"

Curse you inconsistent APIs! :-)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16857 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd metarecord support to "already circulated" tagging
miker [Tue, 6 Jul 2010 18:58:54 +0000 (18:58 +0000)]
add metarecord support to "already circulated" tagging

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16856 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoremove all the 901 mangling -- handled by the db now
miker [Tue, 6 Jul 2010 17:12:25 +0000 (17:12 +0000)]
remove all the 901 mangling -- handled by the db now

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16855 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded ability to tag bib record results from staged multiclass search as previously...
erickson [Tue, 6 Jul 2010 16:14:32 +0000 (16:14 +0000)]
added ability to tag bib record results from staged multiclass search as previously checked out by the user.  the code compares search results to the set of circs in the user's visible circulations history.  the ultimate goal is to provide the ability to style rows in search results so the patron can see if he/she already circulated the item (assuming some widget to turn this feature on/off for a search)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16854 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agouse SQL function for speed, instead of PLPGSQL
miker [Tue, 6 Jul 2010 16:14:18 +0000 (16:14 +0000)]
use SQL function for speed, instead of PLPGSQL

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16853 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoaugment these payment receipt templates with more info
phasefx [Tue, 6 Jul 2010 16:00:08 +0000 (16:00 +0000)]
augment these payment receipt templates with more info

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16852 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agointegrate serial.unit by relaxing fkeys against asset.copy and adding hold support
miker [Tue, 6 Jul 2010 15:56:17 +0000 (15:56 +0000)]
integrate serial.unit by relaxing fkeys against asset.copy and adding hold support

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16851 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdd a configuration entry for the qstore server. This entry will look just
scottmk [Tue, 6 Jul 2010 15:51:31 +0000 (15:51 +0000)]
Add a configuration entry for the qstore server.  This entry will look just
like the entry for open-ils.cstore, except:

1. The <implementation> is oils_qstore.so instead of oils_cstore.so, obviously.

2. There is no need (or use) for the max_query_recursion element.

M    Open-ILS/examples/opensrf.xml.example

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16850 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded stored proc to return the distinct set of target copies from a users visible...
erickson [Tue, 6 Jul 2010 15:42:26 +0000 (15:42 +0000)]
added stored proc to return the distinct set of target copies from a users visible circ history

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16849 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoSelfcheck: Show friendly error messages based on circ event fail_part field
senator [Tue, 6 Jul 2010 15:12:04 +0000 (15:12 +0000)]
Selfcheck: Show friendly error messages based on circ event fail_part field

Messages lifted from opac.dtd

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16848 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoBooking: fixed the last db upgrade script. It was trying to insert a row
senator [Tue, 6 Jul 2010 13:44:59 +0000 (13:44 +0000)]
Booking: fixed the last db upgrade script.  It was trying to insert a row
in config.org_unit_setting_type that had already been covered by 0109, but
which had not been in the seed data until recently, so I think one would have
only noticed this if hadn't installed a new schema from scratch in some time.

If you already ran 0323 and it worked for you, you don't have to do anything.

Also, this now avoids clobbering already-set default_elbow_room values.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16847 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agorepaired bug where parsing intervals with months failed becuase dojo.date.add() wants...
erickson [Fri, 2 Jul 2010 19:41:43 +0000 (19:41 +0000)]
repaired bug where parsing intervals with months failed becuase dojo.date.add() wants the full word 'months' whereas postgres stores them abbreviated as 'mons'

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16846 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoremove as many namespace prefixes as I can from the MODS record output
miker [Thu, 1 Jul 2010 19:46:45 +0000 (19:46 +0000)]
remove as many namespace prefixes as I can from the MODS record output

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16845 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoFix missing dojo.require() in a couple of interfaces.
senator [Thu, 1 Jul 2010 17:05:53 +0000 (17:05 +0000)]
Fix missing dojo.require() in a couple of interfaces.

This bug doesn't manifest itself in releases, as the openils_dojo.js layer
seems to take care of overlooked calls to dojo.require() anyway.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16844 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoSupport the following built-in functions with peculiar syntax.
scottmk [Thu, 1 Jul 2010 14:14:42 +0000 (14:14 +0000)]
Support the following built-in functions with peculiar syntax.
They take no parameters and don't even accept empty parentheses:

current_date
current_time
current_timestamp
localtime
localtimestamp

M    Open-ILS/src/c-apps/buildSQL.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16843 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years ago1. Support the peculiar syntax of EXTRACT().
scottmk [Thu, 1 Jul 2010 02:29:38 +0000 (02:29 +0000)]
1. Support the peculiar syntax of EXTRACT().

2. Repair a regression to make SELECT * work again.

M    Open-ILS/src/c-apps/oils_storedq.c
M    Open-ILS/src/c-apps/buildSQL.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16842 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agobug #600021: fix lookup of FIFO holds OU setting
gmc [Thu, 1 Jul 2010 02:06:27 +0000 (02:06 +0000)]
bug #600021: fix lookup of FIFO holds OU setting

Patch from Anoop Atre that fixes enabling FIFO
holds via the circ.holds_fifo org unit setting.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16838 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agobug #600432: fix MARC expert search
gmc [Wed, 30 Jun 2010 23:06:15 +0000 (23:06 +0000)]
bug #600432: fix MARC expert search

Fix gitch introduced via overzealous tidying that broke MARC
expert search; in the expression @array || $scalar, @array
is evaluated in scalar context and thus returns the number
of elements in it.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16837 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoLenny needs DBD::Pg; the unnecessary Class::DBI::Pg had pulled that in as a dependency
dbs [Wed, 30 Jun 2010 19:08:54 +0000 (19:08 +0000)]
Lenny needs DBD::Pg; the unnecessary Class::DBI::Pg had pulled that in as a dependency

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16836 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoexplode_array() is needed by 030.schema.metabib.sql now; create it early so that...
dbs [Wed, 30 Jun 2010 18:14:23 +0000 (18:14 +0000)]
explode_array() is needed by 030.schema.metabib.sql now; create it early so that database schema creation doesn't fail

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16835 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years ago1. Degrade gracefully when the database connection dies.
scottmk [Wed, 30 Jun 2010 13:32:28 +0000 (13:32 +0000)]
1. Degrade gracefully when the database connection dies.

2. Validate the user-specified operator in a series expression.

M    Open-ILS/include/openils/oils_buildq.h
M    Open-ILS/src/c-apps/oils_qstore.c
M    Open-ILS/src/c-apps/oils_buildq.c
M    Open-ILS/src/c-apps/oils_storedq.c
M    Open-ILS/src/c-apps/oils_execsql.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16834 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoBooking: thinko: default value for an org_unit_setting has to come after
senator [Tue, 29 Jun 2010 21:55:51 +0000 (21:55 +0000)]
Booking: thinko: default value for an org_unit_setting has to come after
the org_unit_setting_type is defined

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16833 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoBooking: bit-by-bit forward-port; see commit msg for r16827
senator [Tue, 29 Jun 2010 21:51:34 +0000 (21:51 +0000)]
Booking: bit-by-bit forward-port; see commit msg for r16827

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16832 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoBooking: forward-porting bit-by-bit; see commit msg for r16827
senator [Tue, 29 Jun 2010 20:29:26 +0000 (20:29 +0000)]
Booking: forward-porting bit-by-bit; see commit msg for r16827

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16831 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoFile->Join Tabs experiment. Can disable through prefs.js, and I may make disabled...
phasefx [Tue, 29 Jun 2010 18:20:02 +0000 (18:20 +0000)]
File->Join Tabs experiment.  Can disable through prefs.js, and I may make disabled the default before we branch trunk depending how things play out.  One current limitation is that the interfaces thus joined get reloaded as a consequence of their respective DOM nodes being relocated, so tab joining is most useful to setup prior to retrieving information you'd like to view side by side.  I haven't found an easy way around this, though we could roll our own tab browser (bleh) or come up with a generic way for interfaces to save their state.  Tab labels are also imperfect, given that interfaces are able to dynamically modify the tab label and can clobber each other if sharing a tab

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16830 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoimprove browse support; correct thinkos in new holdings fleshing code; improve genera...
miker [Tue, 29 Jun 2010 18:10:55 +0000 (18:10 +0000)]
improve browse support; correct thinkos in new holdings fleshing code; improve generated MODS XML (remove some namespace prefixes)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16829 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoFix copy-and-paste-o.
senator [Tue, 29 Jun 2010 18:08:14 +0000 (18:08 +0000)]
Fix copy-and-paste-o.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16828 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoBooking: begin forward-porting code from rel_1_6.
senator [Tue, 29 Jun 2010 17:53:39 +0000 (17:53 +0000)]
Booking: begin forward-porting code from rel_1_6.

Booking (regrettably) was largely written directly against a 1.6 environment
instead of written for trunk and backported.  So now we have booking code in
rel_1_6 and rel_1_6_1 that works, but that needs to be cleanly merged with
trunk.  There has been a lot of drift, and this won't be easy.

Here is the first step (some of the easy stuff).  These files have been updated
wholesale with their contents from rel_1_6, since they don't affect anything
other than booking itself.

Just to be clear: this commit does not complete the booking foward-port.  The
booking module did not work in trunk before this commit, and it does not work
after this commit.  For the moment, booking only works in the rel_1_6 branch,
in the rel_1_6_1 branch, and in 1.6.1.* releases.  It still does not work in
trunk, and it will take a few more hairy commits to get things in sync.

Once that's finally done, any future Booking code can be written the Right Way
(in trunk) and *back*ported thence to whatever other branches as needed.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16827 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoRepresent a subfield expression as a variant of a function call
scottmk [Mon, 28 Jun 2010 19:45:43 +0000 (19:45 +0000)]
Represent a subfield expression as a variant of a function call
expression, rather than a function call in its own right.

1. Eliminate 'xfld' as a valid value for query.expression.type.

2. Eliminate the query.expr_xfld view.

3. Expand the query.expr_xfunc view to include the column_name column.

M    Open-ILS/src/sql/Pg/002.schema.config.sql
M    Open-ILS/src/sql/Pg/008.schema.query.sql
A    Open-ILS/src/sql/Pg/upgrade/0322.schema.query.no-xfld-expr.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16824 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd missed stored proc to base schema; adjust said stored proc to use 901 (or provide...
miker [Mon, 28 Jun 2010 17:52:49 +0000 (17:52 +0000)]
add missed stored proc to base schema; adjust said stored proc to use 901 (or provided id) instead of 035 for bib-authority linking

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16823 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoforcibly maintain an appropriate 901 field in all MARC data via triggers
miker [Mon, 28 Jun 2010 16:59:39 +0000 (16:59 +0000)]
forcibly maintain an appropriate 901 field in all MARC data via triggers

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16822 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoSupport function calls with subfields, e.g. (func(args))."id".
scottmk [Mon, 28 Jun 2010 15:43:28 +0000 (15:43 +0000)]
Support function calls with subfields, e.g. (func(args))."id".

Note that this support treats the subfield as an optional
component of the functional call, not as a type of expression
in its own right.  A subsequent commit will eliminate the "xfld"
expression type.

M    Open-ILS/include/openils/oils_buildq.h
M    Open-ILS/src/c-apps/oils_storedq.c
M    Open-ILS/src/c-apps/buildSQL.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16821 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agothinko when trying to preserve any user change to the internal_flag version of the...
miker [Mon, 28 Jun 2010 15:25:07 +0000 (15:25 +0000)]
thinko when trying to preserve any user change to the internal_flag version of the ingest.disable_authority_linking enabled setting

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16820 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoCorrect syntax for dojo.string.substitute() and remove offending unpaired parens
dbs [Sun, 27 Jun 2010 17:37:37 +0000 (17:37 +0000)]
Correct syntax for dojo.string.substitute() and remove offending unpaired parens

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16819 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoproxied added content support for ContentCafe
phasefx [Fri, 25 Jun 2010 22:11:36 +0000 (22:11 +0000)]
proxied added content support for ContentCafe

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16818 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd stored procs to implement authority propagation if links exist; add trigger to...
miker [Fri, 25 Jun 2010 20:32:58 +0000 (20:32 +0000)]
add stored procs to implement authority propagation if links exist; add trigger to optionally fire this propagation (default ON)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16817 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd bib-authority linking table; add stored proc to extract linking; add hook to...
miker [Fri, 25 Jun 2010 17:31:21 +0000 (17:31 +0000)]
add bib-authority linking table; add stored proc to extract linking; add hook to ingest (controlled by internal_flag) to implement authority link extraction

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16816 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAcq: fixing misc UI glitches
senator [Fri, 25 Jun 2010 16:00:36 +0000 (16:00 +0000)]
Acq: fixing misc UI glitches

Creating allocations and credits in the Funding Source Details interface
didn't populate the appropriate grid immediately, but now it does.

New tags didn't seem to persist in the Fund Details interface if you switched
tabs and then came back to the Tags tab.  Fixed.

Changed some tab names of misc Acq interfaces to match their current names in
the staff client menu.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16815 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoMake CentOS/RHEL use Class::DBI::Frozen::301 and remove Class::DBI::Pg (not necessary)
dbs [Fri, 25 Jun 2010 15:16:41 +0000 (15:16 +0000)]
Make CentOS/RHEL use Class::DBI::Frozen::301 and remove Class::DBI::Pg (not necessary)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16814 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agowe will use a real mapping table instead
miker [Fri, 25 Jun 2010 15:16:16 +0000 (15:16 +0000)]
we will use a real mapping table instead

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16813 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agovandelay.add_field bug fix; add stored procs to 1) create an authority-based overlay...
miker [Fri, 25 Jun 2010 14:47:56 +0000 (14:47 +0000)]
vandelay.add_field bug fix; add stored procs to 1) create an authority-based overlay template and 2) allow simple application of said template directly with marcxml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16812 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoProvide support for Class::DBI::Frozen::301 via UNIVERSAL::require
dbs [Fri, 25 Jun 2010 03:54:46 +0000 (03:54 +0000)]
Provide support for Class::DBI::Frozen::301 via UNIVERSAL::require

Class::DBI changed its API interfaces after the 3.0.1 release, causing much
pain (and incompatibility for existing applications like Evergreen). Some
distributions package Class::DBI 0.96 or 3.0.1, but newer distributions
package an incompatible 3.0.17. An alternative is to install the
Class::DBI::Frozen::301 module from source; UNIVERSAL::require enables us
to try loading both and use whichever one we find.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16811 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoReturn NULL if we don't have anything else to return (keeps the compiler happy)
dbs [Thu, 24 Jun 2010 23:52:29 +0000 (23:52 +0000)]
Return NULL if we don't have anything else to return (keeps the compiler happy)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16810 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agodoh, another thinko. spotted by Scott McKellar
miker [Thu, 24 Jun 2010 18:51:57 +0000 (18:51 +0000)]
doh, another thinko. spotted by Scott McKellar

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16809 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years ago1. Degrade (relatively) gracefully when the database connection dies.
scottmk [Thu, 24 Jun 2010 17:15:16 +0000 (17:15 +0000)]
1. Degrade (relatively) gracefully when the database connection dies.

Problem to be solved: a server drone that loses its database connection
immediately becomes unusable.  It might manage to reconnect, but that
wouldn't help if a transaction was in progress at the time of the failure.

If the drone merely reports an error and then makes itself available
for more requests, every request that it services thereafter will fail.
It will continue to fail repeatedly until it reaches the max_requests
limit, or until someone kills it manually.

Solution: terminate immediately, without waiting for max_requests or a
DISCONNECT request.  The listener can replace it with a new drone,
which will try to establish its own database connection.

2. Correct an oversigt in doUpdate() and doDelete().

If the database operation fails, report an error to the client.
The old code would log an error message but otherwise behave as if
the operation had succeeded.

It is conceivable that this change will appear to break something,
because an operation will fail that would otherwise have appeared
to succeed.  However if that happens, whatever breaks was already
broken; the appearance of success was a snare and a delusion.

M    Open-ILS/include/openils/oils_sql.h
M    Open-ILS/src/c-apps/oils_sql.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16808 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoarg ... thinkos. 0315 will work now
miker [Thu, 24 Jun 2010 17:02:03 +0000 (17:02 +0000)]
arg ... thinkos. 0315 will work now

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16807 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd agency-stripping and btrim normalizers; add identifier|arcn index def as facet
miker [Thu, 24 Jun 2010 16:57:30 +0000 (16:57 +0000)]
add agency-stripping and btrim normalizers; add identifier|arcn index def as facet

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16806 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoand imagine that, the ou passed to actor.org_unit_descendants(INT) might also be...
miker [Thu, 24 Jun 2010 15:12:58 +0000 (15:12 +0000)]
and imagine that, the ou passed to actor.org_unit_descendants(INT) might also be null. super.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16805 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years ago0314 Baseline data
atz [Thu, 24 Jun 2010 14:05:04 +0000 (14:05 +0000)]
0314 Baseline data

Signed-off-by: Joe Atzberger <atz@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16804 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoUse a valid validator for 3 Day Pre-Overdue notice event
dbs [Thu, 24 Jun 2010 13:17:26 +0000 (13:17 +0000)]
Use a valid validator for 3 Day Pre-Overdue notice event

Curse traitorous middle-click and my tired eyes.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16803 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoMake '3 Day Pre-Overdue Notice' work in seed data; we were missing a validator
dbs [Thu, 24 Jun 2010 05:18:05 +0000 (05:18 +0000)]
Make '3 Day Pre-Overdue Notice' work in seed data; we were missing a validator

This was inserted properly in upgrade 0054, so we're just playing catch-up here

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16802 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoFix compile error due to undefined LONG_MAX constant, which is defined in limits.h
dbs [Thu, 24 Jun 2010 04:41:29 +0000 (04:41 +0000)]
Fix compile error due to undefined LONG_MAX constant, which is defined in limits.h

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16801 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoFix Fedora 13 compiling for libdbi/libdbd
dbs [Thu, 24 Jun 2010 04:36:20 +0000 (04:36 +0000)]
Fix Fedora 13 compiling for libdbi/libdbd

  * Add libdbi-devel as a prereq
  * Add Fedora's 64-bit location for the dbd driver libraries

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16800 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoWe don't need to install plpython for PostgreSQL;
dbs [Thu, 24 Jun 2010 03:38:40 +0000 (03:38 +0000)]
We don't need to install plpython for PostgreSQL;
also, add a target for the Fedora PostgreSQL server prereqs.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16799 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoFirst stab at Fedora 13 support in prerequisite installer
dbs [Thu, 24 Jun 2010 03:29:02 +0000 (03:29 +0000)]
First stab at Fedora 13 support in prerequisite installer

Of possible concern: the use of -JS_THREADSAFE in JavaScript::SpiderMonkey.
Need to test this change on other distros - but it enabled me to avoid
the libperl.so linking hacks used on RHEL and CentOS.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16798 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoremove duplicate entries for tag 760 from MARC21 tag list
gmc [Thu, 24 Jun 2010 03:18:30 +0000 (03:18 +0000)]
remove duplicate entries for tag 760 from MARC21 tag list

Signed-of-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16797 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoWhenever a database call fails -- i.e. whenever dbi_conn_query() or
scottmk [Thu, 24 Jun 2010 02:57:58 +0000 (02:57 +0000)]
Whenever a database call fails -- i.e. whenever dbi_conn_query() or
dbi_conn_queryf() returns NULL -- call dbi_conn_error() to get a
description of the error, and include that description in the log
message.

M    Open-ILS/src/c-apps/oils_sql.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16796 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoCancel reasons from EDI spec
atz [Wed, 23 Jun 2010 21:27:32 +0000 (21:27 +0000)]
Cancel reasons from EDI spec

Technically, these aren't all cancellation reasons, they are just
"Action request/notification description codes".  A "5" (or 1005, here)
actually means success, for example.

Examine the EDI list here: http://www.stylusstudio.com/edifact/D04B/1229.htm

Include keep_debits field although it does not necessarily apply to each row.

Signed-off-by: Joe Atzberger <atz@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16795 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdd an explicit link to the favicon.ico per http://www.w3.org/2005/10/howto-favicon
dbs [Wed, 23 Jun 2010 20:36:23 +0000 (20:36 +0000)]
Add an explicit link to the favicon.ico per w3.org/2005/10/howto-favicon

Yeah, we're not using the profile attribute on the HEAD element. Do we really need that?

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16794 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoa bit more protection for non-cached values; beware the null depth in the two-param...
miker [Wed, 23 Jun 2010 19:14:39 +0000 (19:14 +0000)]
a bit more protection for non-cached values; beware the null depth in the two-param version of actor.org_unit_descendants!

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16793 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoproper spelling of this trademark
phasefx [Wed, 23 Jun 2010 18:19:00 +0000 (18:19 +0000)]
proper spelling of this trademark

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16792 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agocorrect the logic for detecting whether ChiliFresh has been configured, and add simil...
phasefx [Wed, 23 Jun 2010 18:09:13 +0000 (18:09 +0000)]
correct the logic for detecting whether ChiliFresh has been configured, and add similar support for Novelist

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16791 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoprotect templated slots from errors when there are no template variables
miker [Wed, 23 Jun 2010 18:03:42 +0000 (18:03 +0000)]
protect templated slots from errors when there are no template variables

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16790 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoSIP Callnumber extensions, POD
atz [Wed, 23 Jun 2010 17:56:45 +0000 (17:56 +0000)]
SIP Callnumber extensions, POD

Use org_unit shortname everywhere, no owning_lib.

Checkin response and Item Info response now return callnumber w/ current SIP code.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16789 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoScript for git-svn repos (with possible github remote)
atz [Tue, 22 Jun 2010 22:07:06 +0000 (22:07 +0000)]
Script for git-svn repos (with possible github remote)

Please heed WARNING in the script comments.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16784 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd 954.data.marc21expand880.sql to build-db.sh so that it gets picked up during...
gmc [Tue, 22 Jun 2010 20:32:12 +0000 (20:32 +0000)]
add 954.data.marc21expand880.sql to build-db.sh so that it gets picked up during new installations

Signed-of-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16781 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agocaching extention for org tree traversal
miker [Tue, 22 Jun 2010 20:09:11 +0000 (20:09 +0000)]
caching extention for org tree traversal

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16780 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAcq: make the PO summary pane less monstrously vertical; add PO history link
senator [Tue, 22 Jun 2010 17:58:31 +0000 (17:58 +0000)]
Acq: make the PO summary pane less monstrously vertical; add PO history link

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16779 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAcq: add a Create PO interface for workflows starting with new, blank POs
senator [Tue, 22 Jun 2010 17:07:38 +0000 (17:07 +0000)]
Acq: add a Create PO interface for workflows starting with new, blank POs

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16778 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agothis should place things better across different browsers re: Chilifresh
phasefx [Tue, 22 Jun 2010 16:39:46 +0000 (16:39 +0000)]
this should place things better across different browsers re: Chilifresh

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16777 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agobetter way of setting these environment variables
phasefx [Tue, 22 Jun 2010 15:34:16 +0000 (15:34 +0000)]
better way of setting these environment variables

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16776 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoremoved deprecated MaxPassiveDelayAge validator from default courtesy notice definition
erickson [Tue, 22 Jun 2010 14:51:27 +0000 (14:51 +0000)]
removed deprecated MaxPassiveDelayAge validator from default courtesy notice definition

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16775 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded warnings for missing params to MinPassiveTargetAge validator; missing params...
erickson [Tue, 22 Jun 2010 14:51:26 +0000 (14:51 +0000)]
added warnings for missing params to MinPassiveTargetAge validator; missing params results in invalid for all target objects (noop_false)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16774 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agowhen you execute MARC, it opens a portal to the hellmouth
erickson [Tue, 22 Jun 2010 14:51:25 +0000 (14:51 +0000)]
when you execute MARC, it opens a portal to the hellmouth

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16773 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agobug #597245: remove ersatz $7 "tags" from MARC tag selector
gmc [Tue, 22 Jun 2010 12:45:41 +0000 (12:45 +0000)]
bug #597245: remove ersatz $7 "tags" from MARC tag selector

Signed-of-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16772 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years ago1. In oils_sql.c: make the functions is_identifier() and is_good_operator()
scottmk [Tue, 22 Jun 2010 12:34:43 +0000 (12:34 +0000)]
1. In oils_sql.c: make the functions is_identifier() and is_good_operator()
global instead of static.

2. Use them to protect qstore against various forms of sql injection.

M    Open-ILS/include/openils/oils_sql.h
M    Open-ILS/src/c-apps/oils_storedq.c
M    Open-ILS/src/c-apps/oils_sql.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16771 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agorough cut at integrating ChiliFresh reviews with OPAC search results and record detai...
phasefx [Mon, 21 Jun 2010 20:41:59 +0000 (20:41 +0000)]
rough cut at integrating ChiliFresh reviews with OPAC search results and record details page.  Needs polish

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16770 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAcq: yet another menu-reorganizing commit
senator [Mon, 21 Jun 2010 20:35:57 +0000 (20:35 +0000)]
Acq: yet another menu-reorganizing commit

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16769 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAcq: add default sort order to canned searches, and provide middle layer
senator [Mon, 21 Jun 2010 20:20:57 +0000 (20:20 +0000)]
Acq: add default sort order to canned searches, and provide middle layer
support for sort order for unified search generally.  The UI for that may
come later.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16768 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoApply RHEL5 prerequisite installer patch by Lee Dickens <ldickens@esilibrary.com>
dbs [Sat, 19 Jun 2010 03:01:48 +0000 (03:01 +0000)]
Apply  RHEL5 prerequisite installer patch by Lee Dickens <ldickens@esilibrary.com>

Tweaked slightly to break some long lines over multiple shorter lines

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16767 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd serials holdings to the holdings_xml data for bibs
miker [Fri, 18 Jun 2010 19:40:14 +0000 (19:40 +0000)]
add serials holdings to the holdings_xml data for bibs

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16765 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoexpose the internal record id and create date for a user as a tooltip over the user...
phasefx [Fri, 18 Jun 2010 19:24:26 +0000 (19:24 +0000)]
expose the internal record id and create date for a user as a tooltip over the user's name in the patron display

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16764 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agostop the autoscrolling behavior with AutoFieldWidget
phasefx [Fri, 18 Jun 2010 17:57:21 +0000 (17:57 +0000)]
stop the autoscrolling behavior with AutoFieldWidget

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16763 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAcq: more menu reorganization
senator [Fri, 18 Jun 2010 17:13:30 +0000 (17:13 +0000)]
Acq: more menu reorganization

New entry points to selection list, PO, and invoice interfaces. Also replaced
visible references to "Pick List" with "Selection List" wherever I could think
of, for consistency's sake.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16762 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomake sure $depth is defined, and used
miker [Fri, 18 Jun 2010 16:55:57 +0000 (16:55 +0000)]
make sure $depth is defined, and used

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16761 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd serial.subscription.owning_lib
miker [Fri, 18 Jun 2010 16:10:59 +0000 (16:10 +0000)]
add serial.subscription.owning_lib

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16760 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years ago0312 - JEDI template support for multiple ISBNs
atz [Fri, 18 Jun 2010 15:56:57 +0000 (15:56 +0000)]
0312 - JEDI template support for multiple ISBNs

of same or different types.  The first ISBN-13 is treated as
primary, if there is one.  Otherwise the first ISBN-10 is used.

Signed-off-by: Joe Atzberger <atz@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16759 dcc99617-32d9-48b4-a31d-7c20da2025e4