working/Evergreen.git
6 years agoInitial compilation of release notes for 2.5
Dan Wells [Tue, 15 Oct 2013 21:27:57 +0000 (17:27 -0400)]
Initial compilation of release notes for 2.5

This is a first real attempt at compiled release notes for 2.5.

A few things to note:
1) While content was moved around a little (New Features vs Upgrade
Notes), nothing was outright removed.
2) Some of the sections are indented using ':leveloffset:'.  As a
result, some section headers end up being more than 5 levels deep, and
therefore do not display when generating (for example) HTML.  I think
(in most cases) we want to trim these parts out of this 'release notes'
file and put the offending sections in the actual documentation for
the feature, so I am leaving it as-is for now.

To easily see these too-deep sections, you can run:

asciidoc -a toc -a numbered RELEASE_NOTES_2_5.txt

and look at the warnings.

I have also not yet cleared out the RELEASE_NOTES_NEXT folder, as I
want to ask some of the docs folks first before I do so.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP#1086458: remove unecessary anonymous hashes when calling xulG.set_tab()
Galen Charlton [Mon, 14 Oct 2013 16:21:58 +0000 (09:21 -0700)]
LP#1086458: remove unecessary anonymous hashes when calling xulG.set_tab()

This follows up on observations made by Steven Chan that
suggests that even the act of creating an anonymous hash and
passing it to a global function can cause (I assume) JavaScript
execution contexts to be leaked.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP#1086458: invoke new 'refresh_checkout' event
Galen Charlton [Mon, 14 Oct 2013 15:47:49 +0000 (08:47 -0700)]
LP#1086458: invoke new 'refresh_checkout' event

This implements using the new custom event rather than
xulG.set_tab() to refresh a refresh of the checkout tab. It
also removes use of a callback function to request the tab
refresh in favor of a simple setTimeout().

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP#1086458: define custom event for refreshing the checkout page
Galen Charlton [Thu, 26 Sep 2013 20:05:26 +0000 (13:05 -0700)]
LP#1086458: define custom event for refreshing the checkout page

Using a custom event handled by a chrome event handler rather
than calling xulG.set_tab() directly avoids any possibility of
leaking objects and executation contexts from the code that's
requesting refresh of the checkout page.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP#1086458: convert last-print information hash to JSON string before caching
Galen Charlton [Mon, 14 Oct 2013 15:23:23 +0000 (08:23 -0700)]
LP#1086458: convert last-print information hash to JSON string before caching

By serializing the printing message and context information to a
JSON string before caching it, we avoid inadvertantly dragging in
things like Javascript execution contexts and possibly references
to objects created by the checkout interface.  This was contributing
to the staff client memory leaks observed during receipt printing.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoFix typo in acq code to allow quick PO creation
Dan Wells [Mon, 14 Oct 2013 20:07:17 +0000 (16:07 -0400)]
Fix typo in acq code to allow quick PO creation

When using 'Actions for this Record'->'View/Place Orders', the
'Create Purchase Order' button dies due to an undefined variable,
'filter'.

Looking at the commit which caused the problem, it seems like this
variable should have been 'state'.  Simple testing bears this out.

Original change was part of:
LP1193095 lineitem batch actions sanity filters

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years agoSerial alert notes missing commit
Dan Wells [Tue, 15 Oct 2013 13:33:46 +0000 (09:33 -0400)]
Serial alert notes missing commit

These changes were somehow lost during the hacking on this feature
at the Hack-a-Way.  The translation string is nice, but the changes
to notes.xul are necessary for being able to create notes.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
6 years agoFix TPAC account preferences
Dan Scott [Tue, 15 Oct 2013 03:09:54 +0000 (23:09 -0400)]
Fix TPAC account preferences

Clean up a few problems in the TPAC "My Account" preferences area:

1. Add a missing </form> closing element, which was preventing any
   submitted changes from actually being posted to the correct URL
   (thus preventing most account preference changes such as
   notifications).
2. Remove trailing semicolon from several generated <option> elements
   for cleaner HTML.
3. Make the aria-label for the element translatable.

As we're touching a majority of the lines in the section and the lines
do not follow normal whitespace standards (mixed tabs, inconsistent
indentation, etc), clean up the whitespace.

Also turn one HTML comment into a Template::Toolkit comment.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoFixing typo in the crontab.example file
Chris Sharp [Tue, 15 Oct 2013 13:01:57 +0000 (09:01 -0400)]
Fixing typo in the crontab.example file

I'm assuming here that the intention was to set the purge_pending_users.srfsh
job to run at 2:30 a.m., but it was set to run at 30:02 - obviously an invalid
time.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
6 years agoTranslation updates - newpot
Dan Wells [Mon, 14 Oct 2013 23:28:11 +0000 (19:28 -0400)]
Translation updates - newpot

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoTranslation updates - po files
Dan Wells [Mon, 14 Oct 2013 23:19:31 +0000 (19:19 -0400)]
Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoFinnish translation update.
Pasi Kallinen [Tue, 1 Oct 2013 17:24:25 +0000 (20:24 +0300)]
Finnish translation update.
Add the Finnish translation files for FlattenerGrid and PCrudFilterPane.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoFix integrated subscription editor record field
Dan Wells [Mon, 14 Oct 2013 19:24:39 +0000 (15:24 -0400)]
Fix integrated subscription editor record field

When trying to edit a subscription using the new 'integrated' editor,
it foolishly tries to populate an unfiltered bre dropdown selector.
This works OK in test environments, but (as expected) fails miserably
with production-size data sets.

The end result is that the dropdown either never populates, or takes
a really long time.  If the user saves before the dropdown loads, the
associated record ID is lost, and the subscription is no longer
properly associated with the record.

To fix this, simply turn the dropdown into a disabled text input
instead, as the ability to edit this field would generally be more
harmful than it is necessary.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoTPAC: Remove needless divs from results header bar
Dan Wells [Fri, 4 Oct 2013 15:34:04 +0000 (11:34 -0400)]
TPAC: Remove needless divs from results header bar

In the current state of the TPAC, these "div"ider elements were
completely invisible, yet nobody seemed to miss them.  It wasn't
altogether clear what the divisions meant anyway, so rather than fix
them, let's just trim them out for now.

Also, get rid of a useless clearing div while we are at it.  I could
not detect a valuable display difference in current Chrome, Firefox,
or IE9.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoTPAC: Redo some margins/padding for better collapse behavior
Dan Wells [Fri, 4 Oct 2013 15:23:13 +0000 (11:23 -0400)]
TPAC: Redo some margins/padding for better collapse behavior

In the "results header", we have both buttons and form elements. In
order to have these elements collapse in an orderly fashion, they need
to be exactly the same size. To accomplish this, let's simplify and
redo a few of the element margins and padding.

At the very least, this will make the elements line up better
vertically when viewed at the normal screen width.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoUse libnet-z3950-simpleserver-perl package
Ben Shum [Wed, 9 Oct 2013 18:54:28 +0000 (14:54 -0400)]
Use libnet-z3950-simpleserver-perl package

Instead of building from source, there is a package available now for
Debian Wheezy and Ubuntu Precise.  Let's use that instead!

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
6 years agoVandelay copy overlay call number merge
Bill Erickson [Wed, 4 Sep 2013 18:55:57 +0000 (14:55 -0400)]
Vandelay copy overlay call number merge

When overlaying a copy, if the copy brings with it a new call number
which collides with an existing call number AND said copy is the only
copy linked to its (old) call number, merge the copy's (old) call
number into the (new) existing call number, i.e. the one we collided
with.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoACQ general search sort funds; display year
Bill Erickson [Wed, 18 Sep 2013 19:38:08 +0000 (15:38 -0400)]
ACQ general search sort funds; display year

* Display fiscal year next to fund code in the search fund selector.
* Sort by newest fiscal year first, followed by code

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoStamping 0844: better MODS for browse, etc.
Dan Wells [Thu, 10 Oct 2013 21:15:12 +0000 (17:15 -0400)]
Stamping 0844: better MODS for browse, etc.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoAdd new functions and optional reingest to upgrade
Dan Wells [Wed, 9 Oct 2013 17:53:35 +0000 (13:53 -0400)]
Add new functions and optional reingest to upgrade

Add improved functions and optional browse only reingest to the
upgrade script.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoDon't index browse extracts as search terms unless needed
Dan Wells [Wed, 9 Oct 2013 17:46:55 +0000 (13:46 -0400)]
Don't index browse extracts as search terms unless needed

In previous releases, we didn't have any major config.metabib_field
rows which had 'browse_field = true' but 'search_field = false'.  Now
that we have one (for title browse), make sure we honor the
'search_field = false' by not creating rows in the
metabib.xxxxxx_field_entry tables.

This gets us back to where we started as far as what gets into the
search index tables, but we should consider going a step further and
*not* adding the glommed row to the search tables if we are already
adding separate rows for search+browse.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoUpgrade script for better MODS browse and Name Subject facets
Dan Wells [Mon, 7 Oct 2013 21:55:58 +0000 (17:55 -0400)]
Upgrade script for better MODS browse and Name Subject facets

This upgrade covers the three previous commits:

  * Add new MODS <titleBrowse> to the default config
  * Tweak MODS32 stylesheet for titles
  * Fix LP1118245: Name Subject facet ordering change

Since these all deal with the in-db MODS xsl, it made sense to lump
the upgrades together.

NOTE: We are purposely ignoring similar changes to MODS33, pending
a discussion of how best to handle EG specific MODS changes overall.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoAdd new MODS <titleBrowse> to the default config
Dan Wells [Mon, 7 Oct 2013 21:47:25 +0000 (17:47 -0400)]
Add new MODS <titleBrowse> to the default config

Now that we have a field which will both display and sort how we
want it, use it.

Also, remove the browse info from the 'Title Proper' row (id = 6).

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoTweak MODS32 stylesheet for titles
Dan Wells [Mon, 7 Oct 2013 21:22:42 +0000 (17:22 -0400)]
Tweak MODS32 stylesheet for titles

<titleNonfiling> was added to help certain search cases, but trailing
punctuation makes it unsuitable for display.  <titleInfo>, on the other
hand, chops all trailing punctuation out, which helps the trailing case
but actually makes display of subtitle information worse.  Let's split
the difference and simplify at the same time by building the whole
title, then trimming extra punctuation.

While the above was done to help in browse display, it turns out that
<titleNonfiling> is not able to generate correct browse data.  We want
the display as corrected above, but we also need to preserve the
<nonSort> tag for proper browse sorting.

Rather than complicate the metabib logic, we'll add another special-
purpose field to the MODS called <titleBrowse>. This field is a hybrid
of <titleInfo> and <titleNonfiling>, which will give us a preformatted
string (for preserving needed punctuation) but also keep the <nonSort>
stuff in a separate field (for sorting).

NOTE: We are purposely ignoring similar changes to MODS33, pending
a discussion of how best to handle EG specific MODS changes overall.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoFix LP1118245: Name Subject facet ordering change
Pasi Kallinen [Mon, 24 Jun 2013 16:59:58 +0000 (19:59 +0300)]
Fix LP1118245: Name Subject facet ordering change

Where Name Subject facet shows subfields in order "cad" and Personal
Author shows subfields in order "acd".  This change makes the Name
Subject show the subfields in the same order as in record view and the
Personal Author facet.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
NOTE: We are purposely ignoring similar changes to MODS33, pending
a discussion of how best to handle EG specific MODS changes overall.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoAdding 0842, 0843 to help with 0841 deficiencies
Dan Wells [Thu, 10 Oct 2013 19:54:40 +0000 (15:54 -0400)]
Adding 0842, 0843 to help with 0841 deficiencies

A clean backport of 0841 was not possible due to partial schema
differences in the upgrade.  While we may have planned ahead better,
add 0842 just for 2_3 upgraders which ends up being a no-op for
2_4, and adds ON UPDATE CASCADE for 2_5.

Also, for similar but additional reasons, add 0843, which serves two
purposes:
  1) add ON UPDATE CASCADE to the rest for those upgrading 2_5/master
  2) alter config.z3950_index_field_map for those upgrading from 2_4
     and previous (other lines are no-ops in this case)

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
6 years agoAdd a TestUtils library for live tests
Jason Etheridge [Thu, 22 Aug 2013 16:48:53 +0000 (12:48 -0400)]
Add a TestUtils library for live tests

Package commonly used live test calls in a new Perl module to they can
be shared by different test scripts.

Based it off of Cronscript.  Added a cache method to Cronscript for getting at
memcached.  TestUtils currently has methods for checkin, checkout, and
workstation registration.

Ported existing live tests to use TestUtils.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years agotest bill payment
Jason Etheridge [Fri, 2 Aug 2013 19:25:58 +0000 (15:25 -0400)]
test bill payment

./05-pay_bills.t ..................
1..10
 # Test bill payment against the admin user.
ok 1 - open-ils.storage.direct.actor.user.retrieve returned aou object
ok 2 - User with id = 1 is admin user
 # authtime is 7200, authtoken is b039320a72bbd06c30f0918d1aeeb07a
ok 3 - Have an authtoken
ok 4 - Registered a new workstation
 # authtime is 7200, authtoken is b039320a72bbd06c30f0918d1aeeb07a
ok 5 - Have an authtoken associated with the workstation
ok 6 - Two billable xacts for admin user from previous tests
ok 7 - Both transactions combined have a balance owed of 1.25
ok 8 - Payment attempt returned HASH
ok 9 - Payment response included two payment ids
ok 10 - Zero billable xacts for admin user after payment
ok

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years agotests against stock test data and live Evergreen
Jason Etheridge [Wed, 17 Jul 2013 21:55:07 +0000 (17:55 -0400)]
tests against stock test data and live Evergreen

I'm running these on a machine where Evergreen has been installed with the stock
test data.  Repeat invocations of the tests will cause test failures, as they
don't completely cleanup after themselves (the goal long-term is to rely on
complete database wipes between invocations).

Manual cleanup right now could include doing the following in psql:
DELETE FROM actor.workstation WHERE name ~ '.t$';

and paying the bills on the admin user (otherwise, once a Max Fines penalty is
generated, checkout tests will fail).

opensrf@dev141:~/git/Evergreen/Open-ILS/src/perlmods (livetests)$ make livecheck 2> /dev/null
perl Build.PL --destdir  || make -s build-perl-fail
Creating new 'MYMETA.yml' with configuration results
Creating new 'Build' script for 'OpenILS' version '2.4'
./Build test --test_files live_t || make -s build-perl-fail
live_t/00-simple.t ..................... ok
live_t/01-auth.t ....................... ok
live_t/02-simple_circ.t ................ ok
live_t/03-overdue_circ.t ............... ok
live_t/04-overdue_with_closed_dates.t .. ok
All tests successful.
Files=5, Tests=62, 11 wallclock secs ( 0.25 usr  0.16 sys +  3.52 cusr  0.63 csys =  4.56 CPU)
Result: PASS

and

opensrf@dev141:~/git/Evergreen/Open-ILS/src/perlmods (livetests)$ prove -v live_t/
live_t/00-simple.t .....................
1..2
 # Simple tests against the open-ils.storage service and the stock test data.
ok 1 - open-ils.storage.direct.actor.user.retrieve returned aou object
ok 2 - User with id = 1 is admin user
ok
live_t/01-auth.t .......................
1..4
 # Simple tests against the open-ils.auth service, memcached, and the stock test data.
 # authtime is 7200, authtoken is a3f2d06775fb670284450ad1f1d6ea00
ok 1 - Have an authtoken
ok 2 - Default authtime for staff login is 7200 seconds
ok 3 - Can retrieve authtoken from memcached
ok 4 - Authtoken is removed from memcached after logout
ok
live_t/02-simple_circ.t ................
1..14
 # Test circulation of item CONC70000345 against the admin user.
ok 1 - open-ils.storage.direct.actor.user.retrieve returned aou object
ok 2 - User with id = 1 is admin user
ok 3 - open-ils.storage.direct.asset.copy.retrieve returned acp object
ok 4 - Item with id = 310 has barcode CONC70000345
ok 5 - Item with id = 310 has status of Reshelving or Available
 # authtime is 7200, authtoken is f7c9ae35165ec74ab5e8ce5b84673da8
ok 6 - Have an authtoken
ok 7 - Registered a new workstation
 # authtime is 7200, authtoken is f7c9ae35165ec74ab5e8ce5b84673da8
ok 8 - Have an authtoken associated with the workstation
ok 9 - Checkout request returned a HASH
ok 10 - Checkout returned a SUCCESS event
ok 11 - Item with id = 310 has status of Checked Out after fresh Storage request
ok 12 - Checkin request returned a HASH
ok 13 - Checkin returned a SUCCESS event
ok 14 - Item with id = 310 has status of Reshelving or Available after fresh Storage request
ok
live_t/03-overdue_circ.t ...............
1..20
 # Test fine generation on checkin against the admin user.
ok 1 - open-ils.storage.direct.actor.user.retrieve returned aou object
ok 2 - User with id = 1 is admin user
ok 3 - open-ils.storage.direct.asset.copy.retrieve returned acp object
ok 4 - Item with id = 810 has barcode CONC71000345
ok 5 - Item with id = 810 has status of Reshelving or Available
 # authtime is 7200, authtoken is 5ab4ae5b9a09c7fd04b4eb0dabf19da5
ok 6 - Have an authtoken
ok 7 - Registered a new workstation
 # authtime is 7200, authtoken is 5ab4ae5b9a09c7fd04b4eb0dabf19da5
ok 8 - Have an authtoken associated with the workstation
ok 9 - Checkout request returned a HASH
ok 10 - Checkout returned a SUCCESS event
ok 11 - Checkout response object has payload object
ok 12 - Payload object has circ object
ok 13 - Circ objection has loan duration of "7 days"
ok 14 - Item with id = 810 has status of Checked Out after fresh Storage request
ok 15 - Zero bills associated with circulation
ok 16 - rewrote circ to have happened 20 days ago
ok 17 - Checkin request returned a HASH
ok 18 - Checkin returned a SUCCESS event
ok 19 - Item with id = 810 has status of Reshelving or Available after fresh Storage request
ok 20 - Thirteen bills associated with circulation
ok
live_t/04-overdue_with_closed_dates.t ..
1..22
 # Test fine generation with closed date on checkin against the admin user.
ok 1 - open-ils.storage.direct.actor.user.retrieve returned aou object
ok 2 - User with id = 1 is admin user
ok 3 - open-ils.storage.direct.asset.copy.retrieve returned acp object
ok 4 - Item with id = 1310 has barcode CONC72000345
ok 5 - Item with id = 1310 has status of Reshelving or Available
 # authtime is 7200, authtoken is dd4b533f677dd5ec6d177312eca2e86b
ok 6 - Have an authtoken
ok 7 - Registered a new workstation
 # authtime is 7200, authtoken is dd4b533f677dd5ec6d177312eca2e86b
ok 8 - Have an authtoken associated with the workstation
ok 9 - Created a closed date for 10 days ago
ok 10 - Checkout request returned a HASH
ok 11 - Checkout returned a SUCCESS event
ok 12 - Checkout response object has payload object
ok 13 - Payload object has circ object
ok 14 - Circ objection has loan duration of "7 days"
ok 15 - Item with id = 1310 has status of Checked Out after fresh Storage request
ok 16 - Zero bills associated with circulation
ok 17 - rewrote circ to have happened 20 days ago
ok 18 - Checkin request returned a HASH
ok 19 - Checkin returned a SUCCESS event
ok 20 - Item with id = 1310 has status of Reshelving or Available after fresh Storage request
ok 21 - Twelve bills associated with circulation (instead of 13, thanks to closed date)
ok 22 - Removed closed date
ok
All tests successful.
Files=5, Tests=62, 10 wallclock secs ( 0.06 usr  0.04 sys +  3.29 cusr  0.50 csys =  3.89 CPU)
Result: PASS

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years agoStamping 0841: make space in config.metabib_field sequence
Dan Wells [Thu, 10 Oct 2013 17:32:41 +0000 (13:32 -0400)]
Stamping 0841: make space in config.metabib_field sequence

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoUpgrade script for config.metabib_field sequence redo
Dan Wells [Wed, 9 Oct 2013 13:38:21 +0000 (09:38 -0400)]
Upgrade script for config.metabib_field sequence redo

[LFW: s/DROP FUNCTION/DROP FUNCTION IF EXISTS/]

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoMake some FK constraints on config.metabib_field.id deferrable
Dan Wells [Wed, 9 Oct 2013 13:29:01 +0000 (09:29 -0400)]
Make some FK constraints on config.metabib_field.id deferrable

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoDocumentation: Update EG upgrade instructions to 2.5 beta1
Robert Soulliere [Thu, 10 Oct 2013 14:44:47 +0000 (10:44 -0400)]
Documentation: Update EG upgrade instructions to 2.5 beta1

Also added Debian Wheezy references and updated links.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
6 years agoDocumentation: Update links in installation instructions.
Elliot V [Thu, 10 Oct 2013 14:03:13 +0000 (10:03 -0400)]
Documentation: Update links in installation instructions.

Addresses these bugs reported in launchpad:
https://bugs.launchpad.net/evergreen/+bug/1237781
https://bugs.launchpad.net/evergreen/+bug/1237785

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
6 years agoSet config.metabib_field_id_seq to 1000 in 950.data.seed-values.sql.
Jason Stephenson [Thu, 9 May 2013 19:33:04 +0000 (15:33 -0400)]
Set config.metabib_field_id_seq to 1000 in 950.data.seed-values.sql.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Boosted to 1000 as suggested by Dan Scott and seconded by Bill
Erickson.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoWrap upgrade script for 0840 circulation column picker.
Jason Stephenson [Tue, 8 Oct 2013 18:58:37 +0000 (14:58 -0400)]
Wrap upgrade script for 0840 circulation column picker.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agolp1193487 Circulation Policy Column Picker not saving configuration.
Garry Collum [Sun, 4 Aug 2013 20:10:26 +0000 (16:10 -0400)]
lp1193487 Circulation Policy Column Picker not saving configuration.

The circulation policy column picker is not saving its configuration
because ui.grid_columns.conify.config.circ_matrix_matchpoint is not
defined in the config.usr_setting_type table.  This updates the sql
to populate the table.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoStamping upgrade 0839: alternative title index fix
Dan Wells [Tue, 8 Oct 2013 16:45:12 +0000 (12:45 -0400)]
Stamping upgrade 0839: alternative title index fix

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoReplace inappropriate browse reingest with ...
Lebbeous Fogle-Weekley [Wed, 2 Oct 2013 15:52:25 +0000 (11:52 -0400)]
Replace inappropriate browse reingest with ...

... attempt at reingest across browse/facets/search but limited to
the alternative title index.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoCapture all alternative titles
Mike Rylander [Mon, 30 Sep 2013 13:22:26 +0000 (09:22 -0400)]
Capture all alternative titles

With the addition of bib browse, the alternative title index definition
was made to point at the 740 (ind2 != 2), which contains non-analytic
alternative titles /and/ non-filing indicator info.  It used to capture
both the 246 and (appropriate) 740's.  Allow either to match the XPath.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoStamping 0838 - remove bibcn normalizers
Dan Wells [Mon, 7 Oct 2013 20:10:04 +0000 (16:10 -0400)]
Stamping 0838 - remove bibcn normalizers

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoThe identifier|bibcn field is best served by having no normalizers applied
Lebbeous Fogle-Weekley [Wed, 2 Oct 2013 19:28:35 +0000 (15:28 -0400)]
The identifier|bibcn field is best served by having no normalizers applied

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoOPAC: Make advanced search -> numeric search -> bib cn hone in on right target
Lebbeous Fogle-Weekley [Wed, 2 Oct 2013 19:18:17 +0000 (15:18 -0400)]
OPAC: Make advanced search -> numeric search -> bib cn hone in on right target

The bib call number search under the advanced search page's numeric
search pane was doing the wrong thing.  By thinking the search field
desired was called 'bib_cn' where it's actually called 'bibcn', it
generated searches that just fell back to the broader search class
'identifier'.  This would often find your matches, but would also find
too many records that *shouldn't* have been matches.

Discovered with help from Erica Rohlfs and Mike Rylander.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoRemove unnecessary Title Proper (Browse) index from config.metabib_field
Lebbeous Fogle-Weekley [Fri, 4 Oct 2013 20:28:40 +0000 (16:28 -0400)]
Remove unnecessary Title Proper (Browse) index from config.metabib_field

As pointed out by Ben Shum and Dan Wells, we don't need this index, and
it made it only into the seed data and not into any upgrade script in
master.  It's a relic of bib-and-auth-browse development that ought to
have been removed before the merge to master.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoMove some release notes to core docs
Kathy Lussier [Fri, 4 Oct 2013 19:32:56 +0000 (15:32 -0400)]
Move some release notes to core docs

The release notes for Phonelist.pm and floating groups provided some good
documentation, so let's move them to the core docs and leave just the
intro for the release notes.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
6 years agoRelax MFHD subfield 'a' requirement for caption/patterns
Dan Wells [Thu, 3 Oct 2013 21:54:03 +0000 (17:54 -0400)]
Relax MFHD subfield 'a' requirement for caption/patterns

If going by the book, every caption/pattern field would have a
subfield 'a', since the data from subfield 'i' would be moved to
'a' if 'a' was empty.  Since that is arcane, and our own wizards
used to bend this rule, let's make some minor adjustments to our
expectations:

1) When calculating date progression, don't expect there to be an 'a'
subfield which needs to be "carried" into.
2) When determining whether a field is 'open-ended', check the first
availabile enum/chron subfield rather than hard-coding the check to
'a'.

These changes do not affect the display formatters, so strings
generated from 'a'-less caption/pattern combos are not exactly right,
but they suffice.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoMore release note entries
Kathy Lussier [Fri, 4 Oct 2013 16:56:39 +0000 (12:56 -0400)]
More release note entries

Additional release note entries in the areas of administration,
circulation, staff client, SIP, and serials.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
6 years agoRelease note additions for new acquisitions features
Kathy Lussier [Thu, 3 Oct 2013 16:54:46 +0000 (12:54 -0400)]
Release note additions for new acquisitions features

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
6 years agoAdding new OPAC features to Release Notes.
Kathy Lussier [Tue, 1 Oct 2013 17:03:07 +0000 (13:03 -0400)]
Adding new OPAC features to Release Notes.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
6 years agoMove various release notes into correct directory
Kathy Lussier [Tue, 1 Oct 2013 15:29:41 +0000 (11:29 -0400)]
Move various release notes into correct directory

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
6 years agoDocumentation: Add migrating patron data from 2.1 docs.
Robert Soulliere [Thu, 3 Oct 2013 19:48:19 +0000 (15:48 -0400)]
Documentation: Add migrating patron data from 2.1 docs.

Converted and added documentation from http://docs.evergreen-ils.org/2.1/html/migratingpatrons.html.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
6 years agoLP#1207281: require SSL when downloading offline patron list
Galen Charlton [Thu, 26 Sep 2013 21:24:42 +0000 (14:24 -0700)]
LP#1207281: require SSL when downloading offline patron list

This patch builds on the previous one by forcing use of
SSL for downloading the offline patron list.  It also
updates the Apache 2.4 example configuration.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years agoLP#1207281 Prevent download of offline patron list without authentication
Michael Peters [Tue, 24 Sep 2013 20:57:37 +0000 (16:57 -0400)]
LP#1207281 Prevent download of offline patron list without authentication

This patch addresses the vulnerability which allowed a user with the proper
knowledge of the location of offline patron lists to download the file over
regular HTTP without any staff credentials.

This small addition to eg_vhost.conf.in will present users with a login prompt
when trying to access the /standalone/ subdirectory on an Evergreen server.

Users are able to download the patron list in the staff client as normal
because they already have obtained credentials during the normal staff client
authentication process.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years agoLP#1066141: add authtoken check and related permission for age to lost function
Ben Shum [Fri, 12 Oct 2012 02:04:30 +0000 (22:04 -0400)]
LP#1066141: add authtoken check and related permission for age to lost function

The SET_CIRC_LOST permission is now required in order to invoke
the open-ils.circ.circulation.age_to_lost method.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years agoFix an omission in the log redaction configuration.
Jason Stephenson [Wed, 30 Jan 2013 21:56:12 +0000 (16:56 -0500)]
Fix an omission in the log redaction configuration.

open-ils.actor.patron.password_reset.commit was omitted in the
<log_protect> block of opensrf_core.xml.example.  This commit adds
it and updates the release notes for 2.3 to include it.

There is also a release notes file informing users that they need to
edit opensrf_core.xml to address this issue.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years agoResponsive tpac release notes
Kathy Lussier [Mon, 30 Sep 2013 19:50:59 +0000 (15:50 -0400)]
Responsive tpac release notes

Add release notes entry for the recent responsive tpac work.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
6 years agoCorrect small errors in new AC cover code
Dan Wells [Fri, 27 Sep 2013 18:07:54 +0000 (14:07 -0400)]
Correct small errors in new AC cover code

In shelf browser, two problems:
 - missing '%]' after 'args=rec_attrs;'
 - cn.record_id should be cn.record.id

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoMove 'floating groups' release note docs
Dan Wells [Thu, 26 Sep 2013 23:30:17 +0000 (19:30 -0400)]
Move 'floating groups' release note docs

Not sure if this is the best place, but it seems like a better
place.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoTranslation updates - fix Finnish translator email
Dan Wells [Thu, 26 Sep 2013 22:59:00 +0000 (18:59 -0400)]
Translation updates - fix Finnish translator email

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoTranslation updates - newpot
Dan Wells [Thu, 26 Sep 2013 22:57:18 +0000 (18:57 -0400)]
Translation updates - newpot

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoTranslation updates - po files
Dan Wells [Thu, 26 Sep 2013 22:09:56 +0000 (18:09 -0400)]
Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoAdd apache config examples for AC by record id
Jeff Godin [Thu, 26 Sep 2013 15:42:23 +0000 (11:42 -0400)]
Add apache config examples for AC by record id

Add apache (and apache 2.4) config examples for added content by
record id, update release notes to call out changes.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoAdd release notes for AC by record id
Jeff Godin [Thu, 26 Sep 2013 15:16:43 +0000 (11:16 -0400)]
Add release notes for AC by record id

Add release notes for Added Content by record ID.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoShow jacket on record page even when no isbn/upc
Jeff Godin [Thu, 19 Sep 2013 20:33:01 +0000 (16:33 -0400)]
Show jacket on record page even when no isbn/upc

Show jacket image on record details page even when there is no isbn
or upc found -- because we may have an ISSN or local override image.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoAdd ISSN support to Syndetic AC handler
Jeff Godin [Thu, 19 Sep 2013 18:17:33 +0000 (14:17 -0400)]
Add ISSN support to Syndetic AC handler

Add ISSN support to OpenILS::WWW::AddedContent::Syndetic added
content handler to take advantage of new support from upstream
provider.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoAdd method to permit AC handler to expect keyhash
Jeff Godin [Thu, 19 Sep 2013 18:12:43 +0000 (14:12 -0400)]
Add method to permit AC handler to expect keyhash

Add an expects_keyhash method to
OpenILS::WWW::AddedContent::Syndetic and look for it from
OpenILS::WWW::AddedContent. This allows us to pass a keyhash
(containing isbn/upc/whatever) to this handler while still passing a
simple scalar containing an ISBN to other AddedContent handlers.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoTeach TPAC and selfcheck jackets by record ID
Jeff Godin [Thu, 19 Sep 2013 15:17:27 +0000 (11:17 -0400)]
Teach TPAC and selfcheck jackets by record ID

Teach TPAC and web-based selfcheck to display jackets by record ID.

Not covered yet: KPAC (uses a non-1x1 placeholder at this time) and
Acq (where we don't always have a bre.id).

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoTeach OPAC (jspac) jacket images by record id
Jeff Godin [Sat, 28 Apr 2012 22:18:34 +0000 (18:18 -0400)]
Teach OPAC (jspac) jacket images by record id

Teach the Javascript OPAC how to retrieve jacket images by
record id.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoRemoved unused, commented-out function
Jeff Godin [Sat, 28 Apr 2012 22:16:30 +0000 (18:16 -0400)]
Removed unused, commented-out function

Removed unused, commented-out function: an earlier iteration of
buildISBNSrc

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoTeach Syndetic.pm to pass UPC in requests
Jeff Godin [Sat, 28 Apr 2012 21:24:06 +0000 (17:24 -0400)]
Teach Syndetic.pm to pass UPC in requests

Teach OpenILS::WWW::AddedContent::Syndetic to pass UPC when
requesting added content from the source.

Protect against warnings when no isbn/upc provided

Protect against Perl giving us uninitialized value warnings when
isbn or upc has not been provided.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoFinish Added Content by record ID
Jeff Godin [Wed, 25 Apr 2012 08:23:28 +0000 (04:23 -0400)]
Finish Added Content by record ID

OpenILS::WWW::AddedContent now supports fetching content by record ID.

To start, this lets us request content in a way that uses both ISBN
and UPC as keys, assuming the AC handler and provider support it.

The previous method of requesting AC data continues to be
supported, and should be unaffected.

Business::ISBN is used to clean ISBN values when fetching by record ID

If we find no valid ISBN and no UPC values in the record,
do not attempt to call an AC handler. This will need
to change when we have AC handlers that rely on other
possible keys.

Attempt to serve from cache before fetching keys from the bib
record in the database.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoStart of AC by record ID from 2011 hackfest
Bill Erickson [Wed, 27 Apr 2011 15:42:58 +0000 (11:42 -0400)]
Start of AC by record ID from 2011 hackfest

Rough, untested cut. use rec id as they added content key;
fetch isbn/upc from full_rec; push full set of isbns and upcs
down to handler code

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoFix doc typo in public interface setup section
Dan Scott [Thu, 26 Sep 2013 17:53:25 +0000 (13:53 -0400)]
Fix doc typo in public interface setup section

Signed-off-by: Dan Scott <dscott@laurentian.ca>
6 years agoClean up minor doc problems
Dan Scott [Thu, 26 Sep 2013 17:45:08 +0000 (13:45 -0400)]
Clean up minor doc problems

"Content Café" would generate a section ID containing "é" which is not
well-formed XML; that was breaking PDF generation. Provide an explicit
ID for the section in question.

The OPAC advanced features section skipped a level of headings, which
generated a warning during PDF processing.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
6 years agoInclude auth browse docs in OPAC section
Dan Scott [Thu, 26 Sep 2013 17:19:10 +0000 (13:19 -0400)]
Include auth browse docs in OPAC section

Also fix a typo in the section title.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
6 years agoNumbering upgrade script for auth-only-bib-auth-browse-signoff
Lebbeous Fogle-Weekley [Thu, 26 Sep 2013 17:07:25 +0000 (13:07 -0400)]
Numbering upgrade script for auth-only-bib-auth-browse-signoff

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoSome release notes for browse enhancements
Mike Rylander [Tue, 20 Aug 2013 15:15:34 +0000 (11:15 -0400)]
Some release notes for browse enhancements

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoBi-directional authority enhanced bib browse
Mike Rylander [Thu, 23 May 2013 18:51:27 +0000 (14:51 -0400)]
Bi-directional authority enhanced bib browse

This functionality extends the work committed as the following set:

e071eb91a40d3871bc0e0a078b88cfdde7ba3b5e Finish stamping for bib record browser
c7bad82a66554251b8a0f636e629fe98680b7765 Stamping upgrade scripts for bib record browser
32ec20b71540b1230ecc15f1aec95059e044499e Fix problem where basic search bar was flush with left edge of page
256b4d24240332ae3fd2a5cc14b1709c90f18d05 Fix issues with multiple divs having the search-wrapper id.
cfc828d832ecee92478466cd2f4e174c2f4b5c3c OPAC Browse: bugfixes squashed together from LP #1177810
6990fd819c0dae385c3cc7a40d39a0ebed91086c Break up expensive queries, match index to quals
c0dea517395c733b77e8eb219d2c3f43f6098d42 OPAC Browse: some squashed commits from LP #1177810
9d37f6890ce6b591d62972ce3e341cecf7c45535 Fix problem with YYYY.schema.bib-auth-browse.sql.
e710ecbee519d374bcf69b0c535c3f83814c782b Bib record browser with 'see also', etc from linked authority headings
d2f4cac923668ff05854ffc9720cafe514b9b71c Link browse entries to authority record when possible
3eb616e56c82a5106e14f5a446f1d875015db7f0 Inter-authority linking

With this, we enhance the browse method to allow the return of authority-only
terms (that is, main entries not used by a bib record) if the authority record
from which the term comes is linked to another authority record via the
mechanism created by 3eb616e5, and that linked authority record is itself in
use by visible bibliographic records.

In order to accomplish this we:
 * extend normalization of both bib and auth records to allow a custom string
   to be used when joining parts of a term (for instance, joining subject
   components with " -- ")
 * cause authority headings to be including in the unique set of values
   captured by metabib.browse_entry during authority ingest
 * link authority-heading derived browse entries to their authority-indexed
   counterparts
 * extend the metabib.browse() stored procedure (and related) to inspect
   authority-linked browse entries
 * extend bibliographic-visiblity testing to cover those bibliographic records
   in use by remote-linked authority records.
 * generate browse links between headings found to be appropriately linked
   and bibliographically in-use and visible

The addition of this functionality will require, in the least, reingest of
all authority records, and would benefit from reingest of bibliographic
records as well, as ingest has been improved and extended.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoStamping upgrade for floating groups
Dan Wells [Thu, 26 Sep 2013 16:53:01 +0000 (12:53 -0400)]
Stamping upgrade for floating groups

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoFloating Groups
Thomas Berezansky [Thu, 19 Apr 2012 02:03:16 +0000 (22:03 -0400)]
Floating Groups

Convert the floating bool to a link to floating groups.

Each group contains zero or more members that define how copies can float.

See the included documentation file for an overview.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoOPAC: on the login page, Make "Questions?"/"FAQs" areas not float weird
Lebbeous Fogle-Weekley [Thu, 26 Sep 2013 15:30:36 +0000 (11:30 -0400)]
OPAC: on the login page, Make "Questions?"/"FAQs" areas not float weird

One little change from the original patch to make it 2em; instead of just 1em;

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoPush the 2.4.2 inter-version upgrade script forward
Mike Rylander [Thu, 26 Sep 2013 15:42:00 +0000 (11:42 -0400)]
Push the 2.4.2 inter-version upgrade script forward

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoSerials: Support reader address information in routing slip template
Lebbeous Fogle-Weekley [Mon, 23 Sep 2013 16:14:18 +0000 (12:14 -0400)]
Serials: Support reader address information in routing slip template

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoStamping 'patron credit disable' setting
Dan Wells [Thu, 26 Sep 2013 13:52:04 +0000 (09:52 -0400)]
Stamping 'patron credit disable' setting

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP1211473 YAOUS : disable patron credit payments
Bill Erickson [Mon, 12 Aug 2013 19:02:57 +0000 (15:02 -0400)]
LP1211473 YAOUS : disable patron credit payments

New org unit setting circ.disable_patron_credit.

This prevents "patron_credit" payments in the payment creation API and
hides all patron credit related actions in the patron payment interface.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoTPAC: Add format icon back to record details
Ben Shum [Thu, 26 Sep 2013 02:36:29 +0000 (22:36 -0400)]
TPAC: Add format icon back to record details

Similar to 502f93acff9a5713668931c980d6ce25962a1f8c finding compromise by
putting the format icon back right next to the format label.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoIn reports, show old label name as the default in the Alter Display Header -prompt
Pasi Kallinen [Mon, 15 Jul 2013 08:01:28 +0000 (11:01 +0300)]
In reports, show old label name as the default in the Alter Display Header -prompt

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoAdd PhoneList.pm stuff to Apache 2.4 config
Lebbeous Fogle-Weekley [Wed, 18 Sep 2013 18:14:16 +0000 (14:14 -0400)]
Add PhoneList.pm stuff to Apache 2.4 config

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoAdd phonelist.txt release notes.
Jason Stephenson [Wed, 18 Sep 2013 17:41:31 +0000 (13:41 -0400)]
Add phonelist.txt release notes.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoFix PhoneList.pm child_init method.
Jason Stephenson [Mon, 23 Jul 2012 14:19:13 +0000 (10:19 -0400)]
Fix PhoneList.pm child_init method.

child_init in an Apache module should return something, so it now
returns the OK constant.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoStrip out spaces as well as - from phone numbers in PhoneList::Holds.
Jason Stephenson [Tue, 6 Mar 2012 18:21:14 +0000 (13:21 -0500)]
Strip out spaces as well as - from phone numbers in PhoneList::Holds.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoAdd PhoneList.pm.
Jason Stephenson [Thu, 26 May 2011 14:30:10 +0000 (10:30 -0400)]
Add PhoneList.pm.

A simple WWW module to list patrons who have holds with their phone
numbers and barcodes. The format is as requested by a specific library
for their automated calling program.

Future modifications may include the ability to rearrange the output
columns and provide formats for some data.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoFix delete items confirmation typo.
Pasi Kallinen [Wed, 11 Sep 2013 05:54:55 +0000 (08:54 +0300)]
Fix delete items confirmation typo.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoBetter handling of purchase_order being non-numeric
Lebbeous Fogle-Weekley [Thu, 5 Sep 2013 17:24:54 +0000 (13:24 -0400)]
Better handling of purchase_order being non-numeric

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoFiction records / copies test data
Bill Erickson [Wed, 4 Sep 2013 13:26:23 +0000 (09:26 -0400)]
Fiction records / copies test data

Adds 17 (mostly) fiction bib records w/ copies to
OpenILS/tests/datasets/sql/.  New items are loaded via load_all.sql.

Special thanks to Rogan Hamby for donating (and I believe creating)
these records many moons ago.  For reference:

The father hunt;
Southern Gods /
The winter of our discontent /
CliffsNotes Steinbeck's Of mice and men /
The rum diary
Blueberry girl /
Stardust
Coraline
Objective-C programming :
The swordsman of Mars /
Ghost story
The Avengers
Throne of the Crescent Moon /
The walking dead.
Kraken :
The crow
The running man /

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoAdded in warning message when placing hold with no email address.
Steven Callender [Thu, 12 Sep 2013 17:30:16 +0000 (13:30 -0400)]
Added in warning message when placing hold with no email address.

Previously when an account didn't have an email address associated with it
when placing a hold, the input box would be greyed out and the display
would show the Email Address text with no address to go with it.

This change will instead show text warning the user that they have
no email address configured and they need to go to My Account in order
to add one to their account.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoTPAC: Consolidate and simplify button styles
Dan Wells [Wed, 25 Sep 2013 20:46:31 +0000 (16:46 -0400)]
TPAC: Consolidate and simplify button styles

TPAC has at least two distinct types of buttons, those created by
input tags, and those created by anchor (that is, <a>) tags.  This
commit simplifies and consolidates the styles used for both types
of buttons.

At least in Firefox, inline blocks display in a closer size rendering
to <input> tags than plain 'display:inline'.  The switch doesn't seem
to hurt in most cases in IE, FF, or Chrome, so let's do it.

Two cases where inline works better are the floating 'My Account' and
'dash' buttons'.  They already have special classes, so let's revert
those back to inline.  In fact, let's make the logged-in 'dash'
buttons share the style of the 'My Account' button which got us there,
and make all three buttons more visible when hovering.

Inputs do not inherit the body font by default, so let's apply it for
better display consistency.

Finally, Firefox inputs have some extra space around them; let's make
a modest attempt to remove that.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoTPAC: href not valid on 'button' tags
Dan Wells [Wed, 25 Sep 2013 21:00:29 +0000 (17:00 -0400)]
TPAC: href not valid on 'button' tags

The 'Clear Form' button was moved to a button tag, which solved a
display issue but didn't actually clear the form.  Let's make it
an <a> again.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoTPAC: Add format icon back to search results
Ben Shum [Wed, 25 Sep 2013 21:40:57 +0000 (17:40 -0400)]
TPAC: Add format icon back to search results

As a compromise, add the format icon back to the search results to sit alongside
the fully spelled out format label for the record. Having the label next to the
icon helps to inform on the icon without the need to hover.

Local sites may consider customizing this to their personal desires.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoTPAC: Make corner image link to server root
Dan Wells [Wed, 25 Sep 2013 16:53:51 +0000 (12:53 -0400)]
TPAC: Make corner image link to server root

Most people will do this anyway, and in the MOPAC view, you currently
get trapped in 'My Account' with no obvious way out unless we have
a link like this.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>