working/Evergreen.git
5 years agoLP#1402797 patron search form focus repairs cont.
Bill Erickson [Fri, 2 Jan 2015 16:21:43 +0000 (11:21 -0500)]
LP#1402797 patron search form focus repairs cont.

Building on Mike's original work, use Angular ng-mouseover and the
Angular $document built-in.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 use null as default payment amount
Galen Charlton [Fri, 26 Dec 2014 22:46:31 +0000 (22:46 +0000)]
LP#1402797 use null as default payment amount

This means that operator does not have to select the
previous default of "0" in the control to clear it out.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 webby: catalog record -> view holds org filter repair
Bill Erickson [Mon, 15 Dec 2014 18:47:51 +0000 (13:47 -0500)]
LP#1402797 webby: catalog record -> view holds org filter repair

Selecting a pickup library from the filter in the Catalog -> View Holds
UI shows holds for the selected org unit and descendant org units.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Repair browser client dropdown buttons - #2
Bill Erickson [Mon, 15 Dec 2014 18:46:14 +0000 (13:46 -0500)]
LP#1402797 Repair browser client dropdown buttons - #2

Repairs egOrgSelector.

Angular-ui-bootstrap as of version ~0.11.2 does not want bare
"dropdown-toggle" attributes within action link tags.  When present,
they prevent the dropdown button from opening.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Allow, and use, disabling of button-ish anchors
Mike Rylander [Wed, 17 Dec 2014 16:31:24 +0000 (11:31 -0500)]
LP#1402797 Allow, and use, disabling of button-ish anchors

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Only enable the Apply Payment button when a bill is selected
Mike Rylander [Wed, 17 Dec 2014 15:57:28 +0000 (10:57 -0500)]
LP#1402797 Only enable the Apply Payment button when a bill is selected

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 webby: checkin fine tally patron bills link
Bill Erickson [Fri, 12 Dec 2014 22:27:06 +0000 (17:27 -0500)]
LP#1402797 webby: checkin fine tally patron bills link

Checkin fine tally display now acts as a link which opens a new tab to
the patron bills page for the current checkin patron when fines exist.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Actually do search button, too
Mike Rylander [Fri, 12 Dec 2014 21:43:53 +0000 (16:43 -0500)]
LP#1402797 Actually do search button, too

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Focus patron search field on search, expand, clear
Mike Rylander [Fri, 12 Dec 2014 21:41:24 +0000 (16:41 -0500)]
LP#1402797 Focus patron search field on search, expand, clear

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Use .finally() instead of hash-y syntax~
Mike Rylander [Fri, 12 Dec 2014 19:02:29 +0000 (14:02 -0500)]
LP#1402797 Use .finally() instead of hash-y syntax~

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Apply focus in the .finally() in case there was a popup
Mike Rylander [Fri, 12 Dec 2014 19:01:59 +0000 (14:01 -0500)]
LP#1402797 Apply focus in the .finally() in case there was a popup

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 fix checkout focus after patron load
Jason Etheridge [Fri, 5 Dec 2014 21:59:30 +0000 (16:59 -0500)]
LP#1402797 fix checkout focus after patron load

Thanks to berick and jcamins, and to eeevil for actually nailing the solution

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Repair browser client dropdown buttons
Bill Erickson [Thu, 4 Dec 2014 22:22:46 +0000 (17:22 -0500)]
LP#1402797 Repair browser client dropdown buttons

Angular-ui-bootstrap as of version ~0.11.2 does not want bare
"dropdown-toggle" attributes within action link tags.  When present,
they prevent the dropdown button from opening.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 webby: repair Hatch type=text printing
Bill Erickson [Wed, 3 Dec 2014 19:57:54 +0000 (14:57 -0500)]
LP#1402797 webby: repair Hatch type=text printing

When printing text, Hatch was receiving no print content due to some
code refactoring.  Repaired.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Avoid org tree retrieval race condition on patron app
Bill Erickson [Wed, 3 Dec 2014 17:48:12 +0000 (12:48 -0500)]
LP#1402797 Avoid org tree retrieval race condition on patron app

Avoid calling egOrg.ancestors() during startup, because the org unit
tree is not guarantee to be available until startup has completed.  This
was causing an occasional JS excpetion in the patron app pages, which
prevented the pages from loading.

The error in question:

 TypeError: Cannot read property 'map' of undefined
    at Object.service.get (https://host/js/ui/default/staff/services/org.js:21:25)
    at Object.service.ancestors (https://host/js/ui/default/staff/services/org.js:34:28)
    at Object.egCore.env.classLoaders.actsc (https://host/js/ui/default/staff/circ/patron/app.js:41:37)
    at https://host/js/ui/default/staff/services/env.js:77:55
    at Object.r [as forEach] (https://host/js/ui/default/staff/build/js/angular.min.js:7:290)
    at Object.service.load (https://host/js/ui/default/staff/services/env.js:76:17)
    at https://host/js/ui/default/staff/services/startup.js:64:23
    at J (https://host/js/ui/default/staff/build/js/angular.min.js:101:96)
    at https://host/js/ui/default/staff/build/js/angular.min.js:102:259
    at h.$eval (https://host/js/ui/default/staff/build/js/angular.min.js:113:32)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Adjust timestamp with local timezone before truncating to the date
Mike Rylander [Wed, 3 Dec 2014 21:40:50 +0000 (16:40 -0500)]
LP#1402797 Adjust timestamp with local timezone before truncating to the date

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Add usr and requestor columns to the hold pull list
Mike Rylander [Wed, 3 Dec 2014 15:54:34 +0000 (10:54 -0500)]
LP#1402797 Add usr and requestor columns to the hold pull list

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Begin teaching grid about class hierarchies for labels
Mike Rylander [Wed, 3 Dec 2014 15:54:13 +0000 (10:54 -0500)]
LP#1402797 Begin teaching grid about class hierarchies for labels

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Fetch old circ when the user is not the same (API misuse)
Mike Rylander [Wed, 3 Dec 2014 15:53:35 +0000 (10:53 -0500)]
LP#1402797 Fetch old circ when the user is not the same (API misuse)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Browser client checkout 'Done' clears current user
Bill Erickson [Tue, 2 Dec 2014 22:28:01 +0000 (17:28 -0500)]
LP#1402797 Browser client checkout 'Done' clears current user

Clicking the 'Done' button after checkout resets the patron side bar and
action tabs to completely hide the previous patron's data.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Remove useless options in record bucket export
Mike Rylander [Wed, 26 Nov 2014 15:48:07 +0000 (10:48 -0500)]
LP#1402797 Remove useless options in record bucket export

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Allow the status bar to be hidden
Mike Rylander [Wed, 12 Nov 2014 20:00:07 +0000 (15:00 -0500)]
LP#1402797 Allow the status bar to be hidden

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Separate stock and custom penalty type models
Mike Rylander [Wed, 12 Nov 2014 15:46:43 +0000 (10:46 -0500)]
LP#1402797 Separate stock and custom penalty type models

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Supply top-level method for uncanceling holds
Mike Rylander [Tue, 11 Nov 2014 18:26:21 +0000 (13:26 -0500)]
LP#1402797 Supply top-level method for uncanceling holds

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Fix boolean assumption
Mike Rylander [Tue, 11 Nov 2014 18:25:55 +0000 (13:25 -0500)]
LP#1402797 Fix boolean assumption

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Sort by class, and keep columns from one class together
Mike Rylander [Tue, 11 Nov 2014 18:25:25 +0000 (13:25 -0500)]
LP#1402797 Sort by class, and keep columns from one class together

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Adjust the default for penalty type so it is selected
Mike Rylander [Tue, 11 Nov 2014 18:24:39 +0000 (13:24 -0500)]
LP#1402797 Adjust the default for penalty type so it is selected

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Add invalid-address alert
Mike Rylander [Thu, 30 Oct 2014 15:06:14 +0000 (11:06 -0400)]
LP#1402797 Add invalid-address alert

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Add Check Number input
Mike Rylander [Thu, 30 Oct 2014 14:50:03 +0000 (10:50 -0400)]
LP#1402797 Add Check Number input

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Add the ability (and action) to uncancel holds
Mike Rylander [Thu, 30 Oct 2014 14:38:15 +0000 (10:38 -0400)]
LP#1402797 Add the ability (and action) to uncancel holds

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Ignore the "current_copy" field, we already get that separately
Mike Rylander [Thu, 30 Oct 2014 14:18:07 +0000 (10:18 -0400)]
LP#1402797 Ignore the "current_copy" field, we already get that separately

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Teach autogrid how to ignore fields explicitly
Mike Rylander [Thu, 30 Oct 2014 14:17:49 +0000 (10:17 -0400)]
LP#1402797 Teach autogrid how to ignore fields explicitly

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Add patron barcode and alias to hold lists where appropriate
Mike Rylander [Thu, 30 Oct 2014 13:57:11 +0000 (09:57 -0400)]
LP#1402797 Add patron barcode and alias to hold lists where appropriate

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Fix "scan item for missing pieces" label to say Item instead of Patron
Mike Rylander [Thu, 30 Oct 2014 13:06:53 +0000 (09:06 -0400)]
LP#1402797 Fix "scan item for missing pieces" label to say Item instead of Patron

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Make "Checkout" the consistent spelling in the IDL
Mike Rylander [Thu, 30 Oct 2014 13:01:21 +0000 (09:01 -0400)]
LP#1402797 Make "Checkout" the consistent spelling in the IDL

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Comment out Hide/Show All in autogrid
Mike Rylander [Thu, 30 Oct 2014 12:59:02 +0000 (08:59 -0400)]
LP#1402797 Comment out Hide/Show All in autogrid

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Add label to custom penalty dropdown
Mike Rylander [Thu, 30 Oct 2014 12:57:45 +0000 (08:57 -0400)]
LP#1402797 Add label to custom penalty dropdown

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Push explicitly added columns to the top and keep the explicit order,...
Mike Rylander [Mon, 22 Sep 2014 16:03:48 +0000 (12:03 -0400)]
LP#1402797 Push explicitly added columns to the top and keep the explicit order, then sort the rest by their labels

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Add catalog search to the search menu in the nav bar
Mike Rylander [Mon, 22 Sep 2014 16:02:55 +0000 (12:02 -0400)]
LP#1402797 Add catalog search to the search menu in the nav bar

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1402797 Add checkout/in workstation colums to the available set
Mike Rylander [Mon, 22 Sep 2014 16:02:33 +0000 (12:02 -0400)]
LP#1402797 Add checkout/in workstation colums to the available set

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoForward-port 2.7.2-2.7.3 upgrade script
Ben Shum [Wed, 4 Feb 2015 21:08:41 +0000 (16:08 -0500)]
Forward-port 2.7.2-2.7.3 upgrade script

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1418164: Fix 0905.schema.user_currnet_normalize_heading.sql.
Jason Stephenson [Wed, 4 Feb 2015 18:38:45 +0000 (13:38 -0500)]
LP#1418164: Fix 0905.schema.user_currnet_normalize_heading.sql.

We can't alter a table, enabling triggers in this case, while a
table has trigger events pending.  We move the trigger enabling
to outside the transaction to resolve this.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1261777 repair cloned addr owner link
Bill Erickson [Tue, 17 Dec 2013 14:57:08 +0000 (09:57 -0500)]
LP#1261777 repair cloned addr owner link

Repair reference to undefined variable (offline) in spawn_editor()
function, which is responsible for opening the tab for the linked
patron.  Variable should be "offlineStrings".

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1390138: Clarify 2.6-2.7 upgrade path
Ben Shum [Wed, 4 Feb 2015 18:10:50 +0000 (13:10 -0500)]
LP#1390138: Clarify 2.6-2.7 upgrade path

The file for upgrading from 2.6 to 2.7 series changed to be specifically
2.6.3-2.7.0 (not just 2.6 to 2.7.0 but 2.6.3 to 2.7.0).

Additionally, alter note on reingesting to include that it might be required
post upgrade script running.

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1390138: Remove references to Ubuntu Lucid Lynx 10.04 as this is not supported
Ben Shum [Wed, 4 Feb 2015 17:59:23 +0000 (12:59 -0500)]
LP#1390138: Remove references to Ubuntu Lucid Lynx 10.04 as this is not supported

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1390138: Updating Upgrade and Install docs for 2.7
Josh Stompro [Tue, 27 Jan 2015 17:01:12 +0000 (11:01 -0600)]
LP#1390138: Updating Upgrade and Install docs for 2.7

 - Updated docs to use 2.7.3 as the base in case this gets included in 2.7.3

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1390138: Updating Upgrade and Install docs for 2.7
Josh Stompro [Wed, 12 Nov 2014 15:19:11 +0000 (09:19 -0600)]
LP#1390138: Updating Upgrade and Install docs for 2.7

Upgrade Docs
- Bolded all linux user names so the format matches the install docs.
- Added note about postgres 9.3 being recommended version and 9.1 being the minium version.
- Added Fedora to list of supported linux distros so it matches install docs.
- Added a note about the different apache config files for apache 2.4+ vs Apache 2.2.
- Added a link to troubleshooting section of install docs.

Install Docs
- Added notes about 9.3 being recommened version of postgres and 9.1 being the minimum.
- Changed opensrf version from 2.3.0 to 2.4.0

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1390138: Another update for install/update docs - added make install
Josh Stompro [Fri, 7 Nov 2014 16:05:45 +0000 (10:05 -0600)]
LP#1390138: Another update for install/update docs - added make install

The docs say that the make command will copy the packages into the /updates folder, but without
"make install" that doesn't happen.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1390138: Updated upgrade docs for 2.7.1
Josh Stompro [Thu, 6 Nov 2014 22:16:26 +0000 (16:16 -0600)]
LP#1390138: Updated upgrade docs for 2.7.1

Missed one instance of 2_6_1 in the /openils/var/web/xul server symlink section.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1390138: Updated upgrade docs for 2.7.1.
Josh Stompro [Thu, 6 Nov 2014 17:24:31 +0000 (11:24 -0600)]
LP#1390138: Updated upgrade docs for 2.7.1.

Added in section about checking the release notes for other upgrade steps to the end.

Added in the step to restart memcached as Galen Charlton mentioned in his 11/5 dev list email
about clearing out old login sessions for security reasons.

Added in Jessie and Trusty with a pointer to the Ruby EDI bug that users of the distributions
will run into.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1413660: Stamping upgrade script to change z3950 function
Ben Shum [Tue, 3 Feb 2015 21:12:14 +0000 (16:12 -0500)]
LP#1413660: Stamping upgrade script to change z3950 function

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1413660 Mark 39.50 config function STABLE
Bill Erickson [Thu, 22 Jan 2015 16:57:43 +0000 (11:57 -0500)]
LP#1413660 Mark 39.50 config function STABLE

Mark SQL function evergreen.z3950_attr_name_is_valid(text) as STABLE
instead of IMMUTABLE, since the output may vary with a single input over
time.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1078593 Regenerate summaries when deleting issuances
Dan Wells [Tue, 8 Apr 2014 20:22:33 +0000 (16:22 -0400)]
LP#1078593 Regenerate summaries when deleting issuances

Both interfaces currently allow you to delete issuances even if they
have items attached and have the delete cascade.  While this might be
a dangerous allowance, we should still make sure to keep our summaries
updated when this happens.

This commit adds automatic summary regeneration when deleting issuances
in either serials interface.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1078593 Add method for regenerating serial summaries
Dan Wells [Wed, 10 Apr 2013 22:42:11 +0000 (18:42 -0400)]
LP#1078593 Add method for regenerating serial summaries

Right now, serial summaries only update when receiving or
resetting items. They need to update more often, so lets start
by adding a method just for doing that.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1078593 Assorted small Serial.pm fixes
Dan Wells [Tue, 8 Apr 2014 20:11:31 +0000 (16:11 -0400)]
LP#1078593 Assorted small Serial.pm fixes

1) fleshed_issuance_alter() changes
  - First, if one of the inner updates returns an event, abort early.
    Otherwise, we might overwrite the event while looping and lose
    the error.
  - Second, add authtoken to the created editor.  This editor gets
    passed around, and other functions might look for it there.

2) pass $type down into _summarize_contents()
  - Right now, we have a bug where supplement/index contents in a
    merged MFHD record will get added to the basic contents (and
    vice-(vice-)versa).  By passing in $type, we can assure that
    we only return the type of contents we are looking for.

3) _prepare_summaries() should acknowledge empty summaries
  - Under normal use, summaries will generally grow, and never shrink
    to nothing.  However, we must still handle cases where we have
    discarded/deleted our last issuance, and in those cases, make sure
    we "empty" the generated_coverage field in our summary.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1415572: Stamping upgrade script for ensuring correct version of authority.normali...
Ben Shum [Tue, 3 Feb 2015 21:01:17 +0000 (16:01 -0500)]
LP#1415572: Stamping upgrade script for ensuring correct version of authority.normalize_heading

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1415572: ensure correct version of authority.normalize_heading() is in place
Galen Charlton [Wed, 28 Jan 2015 17:24:02 +0000 (17:24 +0000)]
LP#1415572: ensure correct version of authority.normalize_heading() is in place

Some upgraded Evergreen databases can have the wrong version
of the authority.normalize_heading() function in place because
of a mixup in the 0848 schema upgrade script.  The problem can
manifest itself by there being rows in authority.record_entry
where the heading and simple_heading columns have "NOHEADING"
values regardless of the control set:

-[ RECORD 1 ]--+---------------------------------------------
heading | NOHEADING_a ff0ed9fcd13e8944d9a718650840787a
simple_heading | NOHEADING_a ff0ed9fcd13e8944d9a718650840787a

This patch ensures that the correct version is in place and
updates authority.record_entry to fix up affected rows without
requiring a full authority ingest.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1414112: Stamping upgrade script for spaces in record attr values
Ben Shum [Tue, 3 Feb 2015 20:54:05 +0000 (15:54 -0500)]
LP#1414112: Stamping upgrade script for spaces in record attr values

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1414112: Correct usage of WITH clause for UPDATE.
Chris Sharp [Tue, 27 Jan 2015 18:33:39 +0000 (13:33 -0500)]
LP#1414112: Correct usage of WITH clause for UPDATE.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1414112: Seed data and avoid reingest
Mike Rylander [Mon, 26 Jan 2015 16:44:45 +0000 (11:44 -0500)]
LP#1414112: Seed data and avoid reingest

Update search metadata without a reingest by identifying records that
use a space in the audience field, and be sure that the coded value map
has a space for "uncoded" audience.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1414112: avoid excluding record attribute values that contain only blanks
Galen Charlton [Mon, 26 Jan 2015 16:05:10 +0000 (16:05 +0000)]
LP#1414112: avoid excluding record attribute values that contain only blanks

Certain record attributes, chiefly the ones whose values comes
from MARC fixed fields and which have a coded value map associated
with them, can have a string consisting of one or more blanks as a
valid value.  Consequently, this patch ensures that
reingest_record_attributes() no longer excludes all attributes that
have blank values from the final attribute list.

This fixes a problem where MARC records with the target audience (008/22)
coded as a blank (unknown or not specified) could no longer be retrieved
using an "audience( )" search filter.

After applying this patch, a reingest of record attributes should be
performed, e.g., by doing

  select metabib.reingest_record_attributes(id)
  from biblio.record_entry
  where not deleted;

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1415898 Fix Potential Cstore Starvation in the OPAC
Jason Stephenson [Thu, 29 Jan 2015 13:02:03 +0000 (08:02 -0500)]
LP#1415898 Fix Potential Cstore Starvation in the OPAC

When a user views their current circulations and/or renews them via
the OPAC, a connection is made to a cstore drone so that the user's
circulations can be retrieved from the database, bypassing the cache.
This connection is not closed, and thus a cstore drone is left unable
to respond to new requests for several seconds.  On a busy server,
this has actually caused the number of cstore drones to hit the limit
configured in opensrf.xml.  If that situation continues for too long,
it leads to the load on the server spiking to the point where services
must be restarted.

This commit changes from xact_rollback to rollback so that the connection
will be closed.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoLP#1415898 Fix Potential Cstore Starvation in KPAC
Jason Stephenson [Thu, 29 Jan 2015 12:59:07 +0000 (07:59 -0500)]
LP#1415898 Fix Potential Cstore Starvation in KPAC

The getit_results function in EGKPacLoader.pm does xact_begin, which
opens a connected session to a cstore drone.  It later does xact_rollback,
which does not disconnect the session.  This leaves a drone hanging for
several seconds unable to responde to new requests.  This commit switches
to a rollback call that does disconnect the session.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoLP#1412893: Only apply lost and paid status with the proper transactions
Ben Shum [Wed, 21 Jan 2015 21:30:53 +0000 (16:30 -0500)]
LP#1412893: Only apply lost and paid status with the proper transactions

As discovered while testing the lost and paid feature, when closing earlier transactions where
the item is currently lost, it could change the item status to lost and paid prematurely.

Change the logic so that it only does this if the current transaction being closed either has
a status of lost or longoverdue.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1409844: Towards more meaningful catalogue <title> elements
Dan Scott [Mon, 12 Jan 2015 18:13:03 +0000 (13:13 -0500)]
LP#1409844: Towards more meaningful catalogue <title> elements

Currently the catalogue <title> elements are formed by concatenating the page
title to "Catalog - ". This means that on browsers with more than a few tabs
open, users will only see "Catalog -", which doesn't help them navigate their
tabs. Also, in search results in general search engines, "Catalog - " is
expected to be a significant word as it appears first in the title of the page.

Instead, let's remove the "Catalog - " prefix entirely and add "- <library
name>" as a suffix to the page title. That way, a user will see the page title
in bookmarks, search results, and other contexts with the most important
information up front (whether that's the title of the work in record details,
or the fact that it's a search for some string), followed by the name of the
library to give it a specific context.

In addition, use the name of the library in the OpenSearch definition to be
more meaningful than the current hardcoded "Evergreen OpenSearch" (many users
will not even know what Evergreen is, if they stumble across the little "Add
search engine" widget at all).

And finally, use the HTML and URI filters appropriately to avoid any possible
damage :)

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1396161: Improve public docs and change osrf-config default from script help
Remington Steed [Wed, 26 Nov 2014 14:21:52 +0000 (09:21 -0500)]
LP#1396161: Improve public docs and change osrf-config default from script help

The public docs have an "Action Triggers" chapter, so this commit
applies the same improvements there to match the help docs in the
script. Also in the public docs, in two places a filename was split
across lines, causing a gap to appear in the HTML version of the docs.
That is corrected here.  This commit also removes the 'osrf-config'
option from the examples in the script help docs, since they are using
the default value.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1396161: action_trigger_runner.pl documentation update
Josh Stompro [Tue, 25 Nov 2014 21:56:50 +0000 (15:56 -0600)]
LP#1396161: action_trigger_runner.pl documentation update

 - Removed --granularity-only help docs.  Ever since the script was changed to
   support parallel execution of different granularity levels the granularity-only
   setting has always been set when using --granularity.

 - Added --verbose help docs.  This option wasn't included in the help docs.

 - Clarification - added some clarification to a few of the help descriptions.

 - Added an additional example for processing hooks and running pending events
   with a granularity set.

 - Removed two references to the --granularity-only flag in the Telephony docs.

I believe this change is valid for 2.7, 2.6 and 2.5 since the change to the script
 was made in 2010.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1413490 Fix <table><table> markup
Dan Scott [Thu, 22 Jan 2015 06:48:19 +0000 (01:48 -0500)]
LP#1413490 Fix <table><table> markup

Doesn't really have an effect on the display, as XULRunner automatically
repairs it dynamically, but might as well be correct.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1373594: Also ignore subfield 7 in get_graphics_880s
Ben Shum [Tue, 16 Dec 2014 19:34:12 +0000 (14:34 -0500)]
LP#1373594: Also ignore subfield 7 in get_graphics_880s

In the Czech Republic the subfield 7 of MARC fields 1XX and 7XX are used for
the National authority control number.

The problem is, that in current Evergreen versions, the subfield 7 is displayed
as a part of the link to author seach in search result or record details, but
when using the linkt to search rcords of the same author, no results are
returned, no matter whether the records exist or not.

That is why we nedd to add the subfield 7 into get_graphic_880s.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1407171 Avoid DEFLATEing fm_IDL.xml
Bill Erickson [Fri, 2 Jan 2015 22:50:26 +0000 (17:50 -0500)]
LP#1407171 Avoid DEFLATEing fm_IDL.xml

Prevent fm_IDL.xml from going through the Apache DEFLATE filter before
it's passed off to IDLCHUNK, which is unable to process deflated files.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1398926: Allow symbol popup to trigger on new marc fields
Thomas Berezansky [Wed, 3 Dec 2014 18:18:27 +0000 (13:18 -0500)]
LP#1398926: Allow symbol popup to trigger on new marc fields

Or rather, new MARC text entry boxes in general.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agoLP 1372197: Fixed another link to evergreen-ils.org that changed.
Josh Stompro [Wed, 24 Sep 2014 20:39:30 +0000 (15:39 -0500)]
LP 1372197: Fixed another link to evergreen-ils.org that changed.

Server upgrade section had a link to http://evergreen-ils.org/downloads.php that is now
http://evergreen-ils.org/egdownloads/

Signed-off-by: Josh Stompro <github@stompro.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP 1373197: fixed default "Get Help With Evergreen" link.
Josh Stompro [Wed, 24 Sep 2014 19:48:16 +0000 (14:48 -0500)]
LP 1373197: fixed default "Get Help With Evergreen" link.

The "Get Help" link was pointing to a 404 page, fixed it so it points at the correct page.

Signed-off-by: Josh Stompro <github@stompro.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1310619: Changing relationship between rcil and legacy stat cats to "might_have".
Chris Sharp [Tue, 6 May 2014 17:20:20 +0000 (13:20 -0400)]
LP#1310619: Changing relationship between rcil and legacy stat cats to "might_have".

After discussion with Mike Rylander, I've changed "has_a" to "might_have"
to make left joining rcil and legacy stat cat sources the default behavior.

For reference, see: http://irc.evergreen-ils.org/evergreen/2014-05-06#i_95055

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1310619: Add links in reporter.classic_item_list to legacy_cat1 and legacy_cat2...
Chris Sharp [Mon, 21 Apr 2014 13:10:28 +0000 (09:10 -0400)]
LP#1310619: Add links in reporter.classic_item_list to legacy_cat1 and legacy_cat2 views.

Currently, the reporter.classic_item_list view has the Legacy Cat 1 and 2
fields defined as "text", not "link", so all it will report out is the ID
number of the stat cat.  We want nullability control over stat cat entries,
so these need to be "link".

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1408803 Add 'persist' login type to auth_proxy sample config
Dan Wells [Thu, 8 Jan 2015 21:30:59 +0000 (16:30 -0500)]
LP#1408803 Add 'persist' login type to auth_proxy sample config

A recent version of EG added the option to "stay logged in", and this
was implemented as a new login type. Since basically everyone will use
this option via the OPAC, it makes sense that this should be part of the
sample config for auth_proxy.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoLP#980296: Stamping upgrade script for void lost on claims returned, etc.
Ben Shum [Tue, 13 Jan 2015 22:00:16 +0000 (17:00 -0500)]
LP#980296: Stamping upgrade script for void lost on claims returned, etc.

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#980296: Release notes entry for voiding lost on Claims Return
Kathy Lussier [Mon, 10 Feb 2014 06:03:12 +0000 (01:03 -0500)]
LP#980296: Release notes entry for voiding lost on Claims Return

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#980296: pgtap tests for the void on claims returned org settings.
Jason Stephenson [Sun, 7 Dec 2014 18:55:53 +0000 (13:55 -0500)]
LP#980296: pgtap tests for the void on claims returned org settings.

A single pgtap file to check if the 4 new settings exist in the database.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#980296: Update void on claims returned for longoverdue status.
Jason Stephenson [Sun, 7 Dec 2014 18:41:42 +0000 (13:41 -0500)]
LP#980296: Update void on claims returned for longoverdue status.

We add settings for voiding longoverdue fees on claims returned.

We modify code in Circ.pm to check those settings and void those
bills when a circulation is claims returned.

We also make some logical repairs to the new void_lost function
in CircCommon.pm and to event handling where that function is
called in set_circ_claims_returned in Circ.pm.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#980296: Add void of lost processing fee on claims returned.
Jason Stephenson [Mon, 1 Oct 2012 21:10:25 +0000 (17:10 -0400)]
LP#980296: Add void of lost processing fee on claims returned.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#980296: Void Lost Fines if copy claims returned.
Jason Stephenson [Mon, 1 Oct 2012 18:30:44 +0000 (14:30 -0400)]
LP#980296: Void Lost Fines if copy claims returned.

Add an ou setting (circ.void_lost_on_claimsreturned) to control whether or
not lost fines are voided when a lost circulation is claims returned.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1392759 Add 'bzr' to 'packager' targets
Bill Erickson [Fri, 9 Jan 2015 15:42:40 +0000 (10:42 -0500)]
LP#1392759 Add 'bzr' to 'packager' targets

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1392759 dev/pack makefile.install repairs
Bill Erickson [Thu, 8 Jan 2015 15:09:08 +0000 (10:09 -0500)]
LP#1392759 dev/pack makefile.install repairs

* remove 'make', since you can't execute a Makefile without it.
* remove duplicate installation of auto* packages for debian-wheezy

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1392759 dev/packager Makefile.install additions
Bill Erickson [Wed, 7 Jan 2015 16:55:47 +0000 (11:55 -0500)]
LP#1392759 dev/packager Makefile.install additions

Add additional packages to the "packager" target to help support
building Evergreen packages on machines where Evergreen and its prereqs
are not installed.

The "packager" target now depends internally on the "developer" target,
since packagers have to build the browser client dependencies.

Since older OSes have to build the nodejs dependencies, the autoconf,
etc. targets have been moved into the developer target, again to support
"headless" packaging.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1392759 developer/packager Makefile.install targets
Bill Erickson [Fri, 14 Nov 2014 15:45:07 +0000 (10:45 -0500)]
LP#1392759 developer/packager Makefile.install targets

* Adds <osname>-developer target for installing packages only needed by
  developers installing from source.  Currently, this is limited to
  packages needed for managing browser client dependencies, but others
  could be added later.

* Adds <osname>-packager target for installing packages needed to build
  Evergreen release bundles.

* Updates README install docs to reference these new targets.

* Updates README install docs to remove requirements for installing
  libtool/automake/autoconf, since those packages will have been
  installed during the OpenSRF install (which is required).

* NOTE: this does not include new Makefile.install targets for fedora

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1407507: Update relator codes
Dan Scott [Sun, 4 Jan 2015 21:26:04 +0000 (16:26 -0500)]
LP#1407507: Update relator codes

Per bug # 1046149, we added a script that will generate the contents of the
opac/parts/relators.tt2 file to provide more granular credits for added entries
that have relator codes. However, we haven't run that script since 2013, and
as there are a number of new relator codes, along with some revisions to the
existing relator terms, we should update relators.tt2 accordingly.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1074096: Remove Bib Call Number Search
Kathy Lussier [Thu, 11 Dec 2014 17:12:51 +0000 (12:12 -0500)]
LP#1074096: Remove Bib Call Number Search

Removes the Bib Call Number search as a default numeric search in the
catalog. Release notes include instructions for restoring it for those
sites that wish to restore it.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1386347 stamping upgrade for hold clear copy maps
Bill Erickson [Mon, 12 Jan 2015 16:58:40 +0000 (11:58 -0500)]
LP#1386347 stamping upgrade for hold clear copy maps

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoLP#1386347 clear maps at fulfillment time
Bill Erickson [Thu, 11 Dec 2014 19:36:11 +0000 (14:36 -0500)]
LP#1386347 clear maps at fulfillment time

For backwards compatibility with queue stats info on captured holds,
clear hold copy maps at fulfillment time instead of capture time, as
before.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1386347 Remove more unneeded map deleters
Bill Erickson [Wed, 29 Oct 2014 17:08:10 +0000 (13:08 -0400)]
LP#1386347 Remove more unneeded map deleters

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1386347: Clear hold-copy-map efficiently
Mike Rylander [Wed, 29 Oct 2014 14:37:29 +0000 (10:37 -0400)]
LP#1386347: Clear hold-copy-map efficiently

When capturing or canceling a hold, we can clear the hold-copy-map
with a trigger, saving the time of the user, and making the business
logic simpler.

LP#1386347 copy map trigger wants a RETURN

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoLP#1395456: (Fixing) Add back missing 0901 upgrade script
Ben Shum [Mon, 12 Jan 2015 16:52:22 +0000 (11:52 -0500)]
LP#1395456: (Fixing) Add back missing 0901 upgrade script

I apparently fumbled the upgrade script and it was lost in the action.
LP#1395456 is now closed with adding back this script to the repositories.

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1396359: Add entries for 345 and 346 tags to en-US/marcedit-tooltips.xml.
Jason Stephenson [Thu, 4 Dec 2014 21:28:32 +0000 (16:28 -0500)]
LP#1396359: Add entries for 345 and 346 tags to en-US/marcedit-tooltips.xml.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1396359: Add tooltips for 264, 344, & 347 tags to en-US/marcedit-tooltips.xml.
Jason Stephenson [Tue, 25 Nov 2014 21:29:26 +0000 (16:29 -0500)]
LP#1396359: Add tooltips for 264, 344, & 347 tags to en-US/marcedit-tooltips.xml.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoChanges to smooth out make_release
Dan Wells [Thu, 16 Jan 2014 20:07:40 +0000 (15:07 -0500)]
Changes to smooth out make_release

1) Make the fake 'HeadURL' into a URL which works with our web repo.
Note that this has 'tags/' hardcoded in, so it only works with true
release branches (e.g. rel_x_y_z) not "working" branches
(e.g. rel_x_y).

2) Change range selector when building log to better exclude commits
from previous releases.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoForward-port 2.6.4 upgrade script
Dan Wells [Tue, 6 Jan 2015 21:59:01 +0000 (16:59 -0500)]
Forward-port 2.6.4 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1406367 Fine generator skips no-fines transactions (parallel)
Bill Erickson [Mon, 29 Dec 2014 22:05:39 +0000 (17:05 -0500)]
LP#1406367 Fine generator skips no-fines transactions (parallel)

Avoid inspecting no-fines transactions when running the fine generator
in parallel mode.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agoLP#1406367 Fine generator skips no-fines transactions
Bill Erickson [Mon, 29 Dec 2014 19:04:45 +0000 (14:04 -0500)]
LP#1406367 Fine generator skips no-fines transactions

Filter out any circs or booking reservations which will never be billed
in the initial overdue transactions query used by the fine generator.
This allows us to avoid loading rows into memory that the fine generator
will ignore anyway.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agoLP#1406367 Reduce Fine gen. API memory use
Bill Erickson [Fri, 19 Dec 2014 17:14:10 +0000 (12:14 -0500)]
LP#1406367 Reduce Fine gen. API memory use

Avoid loading the full set of billable transaction objects into
memory when generating fines to reduce the memory footprint of the
open-ils.storage fine generater API.  Instead, load transaction IDs
on startup, then fetch individual transactions as needed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>