6 years agoLP#1207529: Make sure $PATH includes /openils/bin when configuring
alzr [Mon, 5 Aug 2013 19:33:07 +0000 (14:33 -0500)]
LP#1207529: Make sure $PATH includes /openils/bin when configuring

Signed-off-by: alzr <>
Signed-off-by: Galen Charlton <>

6 years agoLP#1384932: document the zips.txt ZIP code database feature
Josh Stompro [Wed, 29 Oct 2014 21:12:08 +0000 (16:12 -0500)]
LP#1384932: document the zips.txt ZIP code database feature

Patron Address City/State/County Pre-Populate by ZIP Code.

Documented the zips.txt feature that auto fills patron address
(City, State, County) information.

Signed-off-by: Josh Stompro <>
Signed-off-by: Galen Charlton <>
6 years agoLP#1246371: Allow BibCommon::title_is_empty to accept a bre id or bre object.
Jason Stephenson [Wed, 30 Oct 2013 15:05:45 +0000 (11:05 -0400)]
LP#1246371: Allow BibCommon::title_is_empty to accept a bre id or bre object.

I was trying to delete copies with the record fleshed in the call number
object and got the following error:

Can't use an undefined value as an ARRAY reference at
/usr/local/share/perl/5.14.2/OpenILS/Application/Cat/ line 399

Having title_is_empty check for a bre object and use its id solved this
problem for me.

Signed-off-by: Jason Stephenson <>
Signed-off-by: Galen Charlton <>
6 years agoLP#1083639: use "cp -r" instead of "cp -R"
Galen Charlton [Thu, 13 Nov 2014 18:45:14 +0000 (10:45 -0800)]
LP#1083639: use "cp -r" instead of "cp -R"

This change is purely for the sake of consistency; there's
no functional difference.

Signed-off-by: Galen Charlton <>
6 years agoLP#1083639 - Added command to copy fonts into the KPAC2 / Alternate monster skin dir
Josh Stompro [Thu, 23 Oct 2014 19:30:05 +0000 (14:30 -0500)]
LP#1083639 - Added command to copy fonts into the KPAC2 / Alternate monster skin dir

Signed-off-by: Josh Stompro <>
Signed-off-by: Galen Charlton <>
6 years agoLP#1116387 - adding kpac setup notes.
Josh Stompro [Thu, 23 Oct 2014 18:21:16 +0000 (13:21 -0500)]
LP#1116387 - adding kpac setup notes.

Revised instructions based on my testing.  Swapped around the Monster
and Default skin discriptions since the listed Alternate Skin is the default skin.

Signed-off-by: Josh Stompro <>
Signed-off-by: Galen Charlton <>
6 years agoAdd KPAC configuration info to the community docs
Kathy Lussier [Tue, 5 Feb 2013 15:24:17 +0000 (10:24 -0500)]
Add KPAC configuration info to the community docs

Adds the KPAC TechRef docs to root.txt so that this information can be
available via the community docs. Also adds a section to the docs on
configuring the alternate skin and removes a reference to configuration
from the end-user KPAC docs.

Signed-off-by: Kathy Lussier <>
Signed-off-by: Galen Charlton <>
6 years agoLP#1246839: no longer crashes with vs 0.23 of File::Temp
Fredric T Parks [Wed, 6 Nov 2013 23:36:32 +0000 (15:36 -0800)]
LP#1246839: no longer crashes with vs 0.23 of File::Temp

updated to use the 0.23 API

Signed-off-by: Fredric T Parks <>
Signed-off-by: Bill Erickson <>
Signed-off-by: Galen Charlton <>
6 years agoLP#1198465 lost overdues generated in main xact
Bill Erickson [Thu, 25 Sep 2014 16:49:17 +0000 (12:49 -0400)]
LP#1198465 lost overdues generated in main xact

Generate overdue fines for lost checkins (if configured) within the main
body of the checkin transaction to avoid complications with negative
balance reconciliation.

Signed-off-by: Bill Erickson <>
Signed-off-by: Dan Wells <>
6 years agoLP#1198465 Allow fine generator to respect a stop_fines filter
Mike Rylander [Thu, 25 Sep 2014 16:58:45 +0000 (12:58 -0400)]
LP#1198465 Allow fine generator to respect a stop_fines filter

In order to support situations where billings should be generated on
specific circs, even when stop_fines is set, we allow a filter to
be passed.  The default of not passing a filter is the same as requiring
that stop_fines be NULL, which is the pre-commit behavior.

We also remove a never-used parameter.

Signed-off-by: Mike Rylander <>
Signed-off-by: Dan Wells <>
6 years agoLP#1133158 - Fix typos in
Josh Stompro [Mon, 10 Nov 2014 15:29:38 +0000 (09:29 -0600)]
LP#1133158 - Fix typos in

Added equals sign to --hooks and added --process-hooks to command so
--hooks=x is actually used.

Signed-off-by: Josh Stompro <>
Signed-off-by: Ben Shum <>
6 years agoLP#1386260: DST bugs in perl live tests (04-overdue_with_closed_dates.t)
Jason Etheridge [Fri, 7 Nov 2014 18:38:39 +0000 (13:38 -0500)]
LP#1386260: DST bugs in perl live tests (04-overdue_with_closed_dates.t)

more fixes

Signed-off-by: Jason Etheridge <>
Signed-off-by: Ben Shum <>
6 years agoLP#1386260: DST bugs in perl live tests (03-overdue_circ.t)
Jason Etheridge [Fri, 7 Nov 2014 18:00:10 +0000 (13:00 -0500)]
LP#1386260: DST bugs in perl live tests (03-overdue_circ.t)

Use safer date math to handle bug with DST

Signed-off-by: Jason Etheridge <>
Signed-off-by: Ben Shum <>
6 years agoLP#1391290: Stamping upgrade script for authority reingest setting
Ben Shum [Tue, 11 Nov 2014 02:00:42 +0000 (21:00 -0500)]
LP#1391290: Stamping upgrade script for authority reingest setting

Signed-off-by: Ben Shum <>
6 years agoLP#1391290: Respect setting to disable authority propagation on reingest
Chris Sharp [Mon, 10 Nov 2014 19:43:22 +0000 (14:43 -0500)]
LP#1391290: Respect setting to disable authority propagation on reingest

In commit a1612cfd6 we lost the ability to disable authority propagation on
record update.  Here, we put it back.

Signed-off-by: Chris Sharp <>
Signed-off-by: Mike Rylander <>
Signed-off-by: Ben Shum <>
6 years agoLP#1012308: Teach the staff client to use titlesort
Thomas Berezansky [Tue, 12 Jun 2012 18:08:04 +0000 (14:08 -0400)]
LP#1012308: Teach the staff client to use titlesort

At least in some places.

Signed-off-by: Thomas Berezansky <>
Signed-off-by: Michele Morgan <>
Signed-off-by: Ben Shum <>
6 years agoLP1282277_LP1282286_Unitialized_Vars_FIx
Liam Whalen [Sun, 13 Jul 2014 17:49:07 +0000 (10:49 -0700)]

The commit to prompt users if they are going to lose data in MARC edit
added some new variables (tabs, and tab) in various files.  If the MARC
edit window does not appear in a tab, then these variables remain
unitialzed and cause problems for MARC edits that appear in their own
window.  By checking for the existence of the variables before MARC
edito loads in its own windown, the problems are resolved.

Signed-off-by: Liam Whalen <>
Signed-off-by: Jennifer Pringle <>
Signed-off-by: Ben Shum <>
6 years agoLP1282277 & LP1282286 Double call to MARC edit save fixed
Liam Whalen [Mon, 7 Jul 2014 20:55:05 +0000 (13:55 -0700)]
LP1282277 & LP1282286 Double call to MARC edit save fixed

The code currently calls the MARC edit save feature twice due to a copy
and paste error.  This commit removes the duplicate call to save.

Signed-off-by: Liam Whalen <>
Signed-off-by: Jennifer Pringle <>
Signed-off-by: Ben Shum <>
6 years agoLP1282277 & LP1282286 Fixed error with Copy Editor
Liam Whalen [Sat, 28 Jun 2014 20:52:45 +0000 (13:52 -0700)]
LP1282277 & LP1282286 Fixed error with Copy Editor

With the previous fix applied, it is impossible to edit values within the copy
editor. A javascript error occurs.  This commit fixes that problem.

Signed-off-by: Liam Whalen <>
Signed-off-by: Jennifer Pringle <>
Signed-off-by: Ben Shum <>
6 years agoLP1282277 & LP1282286 MARC edit save warning & TCN search warning
Liam Whalen [Mon, 16 Sep 2013 02:26:16 +0000 (19:26 -0700)]
LP1282277 & LP1282286 MARC edit save warning & TCN search warning

LP1282286 TCN search shortcut incorrectly prompts for lost data

When cataloguing in the Marc Edit view, users can hit Shift-F3 to bring
up the TCN search dialog box.  After entering a TCN and confirming their
entry, they will be taken to the record specified by the TCN entered.

However, if the user has edited some data on the current marc record,
then another dialog box should appear before the TCN search box that
gives them a warning that they will lose data if they go to a new

Currently, whenver a user presses the Shift-F3 shortcut, they are given
a warning about losing data regardless of the current state of the marc
record being edited.

When a record is edited, a key press event is captured and the function
oils_lock_page is called to record the page as edited.  In the case of
this bug, the Shift key is not being ignored.  So, when the user
presses Shift-F3, the marc record is locked as if it were edited, then
the TCN search function is called.  After the user enters a TCN and
presses OK, the warning about lost data is displayed because the
pressing of Shift marked the record as edited.

This fix adds a check for the ev.shiftKey event in the
set_lock_on_keypress function call in marcedit.js.

Currently, if the user has edited a marc record and
pressed Shift-F3 to retrieve another record via TCN, then the prompt for
the TCN appears and after the user ok's that prompt they are prompted to
make sure they are ok with losing data.

This modification causes the prompt for lost data to appear before the
prompt for the TCN value.  It requires modifying
chrome/content/main/menu.js, which will require a staff client update.
This fix also ensures that if users confirm that it is ok to lose
data but then cancel their TCN searches that they will be prompted that
they might lose data again if they do more TCN retrieving.

LP1282277 Prompt for lost data in  Marc Edit

When using the MARC editor, if you modify a record and then use another
UI element to leave the MARC editor, you will be prompted that you might
lose data if you leave the MARC editor.  Currently, this prompt does not
happen if the user uses an Action for This Record drop down menu item.
As well, if the user then returns to the MARC editor, the changes are
still present, but leaving the MARC editor no longer prompts with  a
lost data warning.

This fix, adds checks to the Actions for This Record menu items, and it
adds some tab variables to keep track of the state of the MARC editor.
That way, if the user leaves then comes back and changes are still
present, the user will still get a lose data warning if they try to
leave again.

As well, when ever a key is pressed in MARC Edit that would result in
modifying a record, a counter is increased on a semamphor stored on
the XUL tab containing the Marc Edit UI.  Currently, when the record is
saved, this counter is decremented by 1.  However, the code checks to
see that the counter is 0 in order to determine if the tab is still
locked and data might be lost.

So, to fix this, we check in the unlock_tab code to see if we are in the
MARC Editor, and if we are, then we set the counter to 0.  The
unlock_tab code is used when saving via the Marc Editor.  It may be
used elsewhere in other parts of the Staff Client, so I have left the
original decrement by 1 logic in for all cases other than being in the
Marc Editor.



The fix was modified, because the previous fix was storing the flags that
indicated a change to a MARC record at the window level.
This new fix stores them at the tab level.  I am keeping this commit
message to indicate that there were more Conflicts when mergin Sitka's
code into the community code.  In case, I missed something and a record
of what was done needs to be consulted.



LP1282277 & LP1282286 MARC edit TCN search lose data prompts

This commit modifies my previous commits.  The code now uses the
previous versions code to mark a tab as locked and to record that data
is saved or not saved.  However, when a user returns to the MARC edit
screen, if there are changes still present, then the code now locks the
tab again and records that there is unsaved data.  This should allow all
previous functionality to remain while providing the proper warnings
when within the MARC editor.

LP1282277 & LP1282286 MARC Edit and TCN lose data prompt

This commit sets the tab.marc_edit_changed value to false when the tab
is set.  This means if an MARC record is edited in a tab then the tab is
set to another view, if the user then goes back to MARC edit, the tab
will not be locked because the flag will now be set to false.  This
results in no warning being shown when a user tries to leave a MARC edit
page when they have not edited the MARC.

Signed-off-by: Liam Whalen <>
Signed-off-by: Kyle Tomita <>
Signed-off-by: Jennifer Pringle <>
Signed-off-by: Ben Shum <>
6 years agoLP#1203734 copy circ counts include anon. circs
Bill Erickson [Mon, 3 Nov 2014 22:55:00 +0000 (17:55 -0500)]
LP#1203734 copy circ counts include anon. circs

Circ counts displayed on "Show Last Few Circulations" (XUL) includes
active, anonymized, and legacy circulations (via cstore)

Signed-off-by: Bill Erickson <>
Signed-off-by: Chris Sharp <>
6 years agoLP#1095290: Wrap record navigation template next and previous arrows with spans.
Pasi Kallinen [Wed, 2 Jan 2013 13:18:56 +0000 (15:18 +0200)]
LP#1095290: Wrap record navigation template next and previous arrows with spans.

Also affects one translatable string, by moving the arrow outside it;
there's no sense having it in the string.

Signed-off-by: Pasi Kallinen <>
Signed-off-by: Kathy Lussier <>
Signed-off-by: Ben Shum <>
6 years agoLP#778989: Stamping upgrade script for copy location trigger
Ben Shum [Tue, 11 Nov 2014 01:27:11 +0000 (20:27 -0500)]
LP#778989: Stamping upgrade script for copy location trigger

Signed-off-by: Ben Shum <>
6 years agoLP#778989: Adding DROP TRIGGER IF EXISTS to allow for smooth upgrades.
Chris Sharp [Tue, 26 Aug 2014 19:39:00 +0000 (15:39 -0400)]
LP#778989: Adding DROP TRIGGER IF EXISTS to allow for smooth upgrades.

Signed-off-by: Chris Sharp <>
Signed-off-by: Ben Shum <>
6 years agoLP#778989: Add circ lib to location fixer
Thomas Berezansky [Tue, 26 Aug 2014 16:14:11 +0000 (12:14 -0400)]
LP#778989: Add circ lib to location fixer

Because the circ lib is valid for picking locations.

Signed-off-by: Thomas Berezansky <>
Signed-off-by: Chris Sharp <>
Signed-off-by: Ben Shum <>
6 years agoLP#778989: Attempt to find "Correct" copy location
Thomas Berezansky [Wed, 1 Feb 2012 21:07:05 +0000 (16:07 -0500)]
LP#778989: Attempt to find "Correct" copy location

This adds a trigger to asset.copy that on insert or change of the location
and/or call number tries to find an identically named copy location that
is scoped to the owning library of the copy.

If it does not find one it uses the location provided.

Signed-off-by: Thomas Berezansky <>
Signed-off-by: Chris Sharp <>
Signed-off-by: Ben Shum <>
6 years agoDocs: remove extra '\r' in cataloging/MARC_batch_edit.txt
Yamil Suarez [Mon, 10 Nov 2014 21:20:58 +0000 (16:20 -0500)]
Docs: remove extra '\r' in cataloging/MARC_batch_edit.txt

Signed-off-by: Yamil Suarez <>
6 years agoDocs: Documentation for MARC Batch Edit
Timothy Spindler [Mon, 10 Nov 2014 21:00:15 +0000 (16:00 -0500)]
Docs: Documentation for MARC Batch Edit

Signed-off-by: Yamil Suarez <>
6 years agoUse xact_start for due date calc instead of now
Thomas Berezansky [Mon, 9 Sep 2013 19:49:47 +0000 (15:49 -0400)]
Use xact_start for due date calc instead of now

If you don't supply a due date when creating a circulation with the
open-ils.circ.checkout family of calls, the due date is currently
calculated from now().  This code modification changes that so that
if a checkout_date is supplied that is used to calculate the due date
instead of now().

This enables some interesting uses of the open-ils.circ module for
batch circulation in the cases of offline use from a spreadsheet and
not the offline client or in the case of migrating circulations from
another ILS into Evergreen.

Signed-off-by: Thomas Berezansky <>
Signed-off-by: Jason Stephenson <>
Signed-off-by: Dan Wells <>
6 years agoDocumentation: LP#1386854 - Locally Hosted Added Content.
Yamil Suarez [Mon, 10 Nov 2014 18:47:52 +0000 (13:47 -0500)]
Documentation: LP#1386854 - Locally Hosted Added Content.

Adds documentation that describes how to use the local content bypass
feature of the AddedContent modules.  This allows for local added content like
cover art, reviews, TOC, exerpts or annotations to be shown in bib records.

I also changed the headers in the External Added Content section to use title case.

Signed-off-by: Josh Stompro <>
Signed-off-by: Yamil Suarez <>
6 years agoLP#1390225: Fail to care about errors from auth.session.delete
Mike Rylander [Thu, 6 Nov 2014 21:03:36 +0000 (16:03 -0500)]
LP#1390225: Fail to care about errors from auth.session.delete

We're just tossing this call over the wall and moving on.  We don't
care if the session wasn't there to delete or even if we didn't pass
a session to the server.

Signed-off-by: Mike Rylander <>
Signed-off-by: Chris Sharp <>
Signed-off-by: Jason Stephenson <>
6 years agoLP#1390225: redirect to ctx.home_page instead of through ctx.logout_page
Mike Rylander [Thu, 6 Nov 2014 20:36:16 +0000 (15:36 -0500)]
LP#1390225: redirect to ctx.home_page instead of through ctx.logout_page

This way, we skip the auth.session.delete call that will error out because
we no longer have the authtoken cookie.

Signed-off-by: Mike Rylander <>
Signed-off-by: Chris Sharp <>
Signed-off-by: Jason Stephenson <>
6 years agoLP#1248636: Clear session at OPAC logout
Mike Rylander [Thu, 30 Oct 2014 15:52:13 +0000 (11:52 -0400)]
LP#1248636: Clear session at OPAC logout

When the user explicitly logs out, clear the session on the server side.

Signed-off-by: Mike Rylander <>
Signed-off-by: Galen Charlton <>
Signed-off-by: Ben Shum <>
6 years agoForward-port 2.6.3 upgrade script
Dan Wells [Wed, 5 Nov 2014 19:22:26 +0000 (14:22 -0500)]
Forward-port 2.6.3 upgrade script

Signed-off-by: Dan Wells <>
6 years agoForward-port 2.5.7 upgrade script
Dan Wells [Wed, 5 Nov 2014 19:21:44 +0000 (14:21 -0500)]
Forward-port 2.5.7 upgrade script

Signed-off-by: Dan Wells <>
6 years agoForward port 2.6-2.7 upgrade script
Ben Shum [Wed, 5 Nov 2014 19:19:10 +0000 (14:19 -0500)]
Forward port 2.6-2.7 upgrade script

Signed-off-by: Ben Shum <>
6 years agoLP#1366964 Update libdbi connection test error parsing
Bill Erickson [Tue, 21 Oct 2014 02:55:20 +0000 (22:55 -0400)]
LP#1366964 Update libdbi connection test error parsing

Modern version of libdbi return a slightly different error message for
queries which fail mid-transaction, causing an C-based DB backends to
exit abruptly unnecessarily.  Update the error message test to include
the new format.

Includes Perl live test for confirming functionality.

Signed-off-by: Bill Erickson <>
Signed-off-by: Jason Stephenson <>
6 years agoLP1383697: Long Overdue needs to be a "magical status" for the copy editor
Chris Sharp [Tue, 21 Oct 2014 13:33:37 +0000 (09:33 -0400)]
LP1383697: Long Overdue needs to be a "magical status" for the copy editor

Signed-off-by: Chris Sharp <>
Signed-off-by: Ben Shum <>
6 years agolp1383763 - Display OpenURL embargo statement
Dan Scott [Tue, 21 Oct 2014 15:02:12 +0000 (11:02 -0400)]
lp1383763 - Display OpenURL embargo statement

The ResolverResolver service fetches the embargo statement (such as
"Last year not available") from OpenURL resolvers and stores it in a
target_embargo field. In JSPAC we used to display this along with the
coverage statement, because it is very important that people know that a
resource may be available from 1999 but the last year isn't available

Restore the display of this information to the TPAC.

Signed-off-by: Dan Scott <>
Signed-off-by: Galen Charlton <>
6 years agoDocs: Changed 'Importing materials' in the staff client section LP#1371615
Dananji Liyanage [Mon, 27 Oct 2014 21:19:10 +0000 (17:19 -0400)]
Docs: Changed 'Importing materials' in the staff client section LP#1371615

Signed-off-by: Yamil Suarez <>
6 years agoLP#1384868: limit fund drop-downs on the invoice page to only active funds
Galen Charlton [Thu, 23 Oct 2014 19:17:58 +0000 (12:17 -0700)]
LP#1384868: limit fund drop-downs on the invoice page to only active funds

This patch fixes the fund selectors for adding extra copies
and charges to invoices to only active funds (in addition
to the existing restriction to funds visible to the user).

Signed-off-by: Galen Charlton <>
Signed-off-by: Bill Erickson <>
6 years agoDocs: add default icon definitions LP#1371598
Dananji Liyanage [Fri, 24 Oct 2014 19:15:12 +0000 (15:15 -0400)]
Docs: add default icon definitions LP#1371598

Documents the default icon definitions that are included with a stock Evergreen install.

Signed-off-by: Yamil Suarez <>
6 years agoLP#1261486 Action/trigger aggregator script repairs user/csharp/lp1366964-libdbi-error-handling-signoff
Bill Erickson [Wed, 11 Dec 2013 17:58:49 +0000 (12:58 -0500)]
LP#1261486 Action/trigger aggregator script repairs

* If both date filters are selected, apply both instead of replacing the
  first with the second

* Select distinct event output to prevent dupes

Signed-off-by: Bill Erickson <>
Signed-off-by: Galen Charlton <>
6 years agoLP#1379824 Make PermaCrud.js disconnect() actually disconnect
Dan Wells [Thu, 9 Oct 2014 21:32:42 +0000 (17:32 -0400)]
LP#1379824 Make PermaCrud.js disconnect() actually disconnect

The disconnect() method in PermaCrud.js was meant to wrap the
underlying session disconnect, but it never actually disconnected
the session.  This could lead to problems in long-living PermaCrud
objects, as they may think they are still connected when they are not
(the session remote_id is never cleared).

Also, remove a couple (now redundant) manual session.disconnect() calls.

Signed-off-by: Dan Wells <>
Signed-off-by: Yamil Suarez <>
Signed-off-by: Ben Shum <>
6 years agoLP#1305958 Change copy table header atts to scope attributes
Dan Scott [Thu, 10 Apr 2014 14:59:49 +0000 (10:59 -0400)]
LP#1305958 Change copy table header atts to scope attributes

Per, the current best practice for
marking up tables for accessibility is to use the "scope" attribute for
headers, rather than the error-prone and markup-heavy "headers" attribute on
table cells.

Signed-off-by: Dan Scott <>
Signed-off-by: Chris Sharp <>
Signed-off-by: Ben Shum <>
6 years agoLP#1309664: Stamping upgrade script for new seed data for COM and SER
Ben Shum [Fri, 10 Oct 2014 17:18:03 +0000 (13:18 -0400)]
LP#1309664: Stamping upgrade script for new seed data for COM and SER

Signed-off-by: Ben Shum <>
6 years agoLP#1309664: Add some fixed field seed data for COM and SER
Mike Rylander [Fri, 18 Apr 2014 17:45:59 +0000 (13:45 -0400)]
LP#1309664: Add some fixed field seed data for COM and SER

There are a few useful fixed fields we're missing mapping data for,
so this branch adds three: Freq, Regl, and File. There are certainly
more, but here's a bit that's of use to folks in the wild using the
fixed field editor improvements.

Signed-off-by: Mike Rylander <>
Signed-off-by: Chris Sharp <>
Signed-off-by: Ben Shum <>
6 years agoLP#1374551: Stamping upgrade script for new index on money.billing.voider
Ben Shum [Fri, 10 Oct 2014 15:35:25 +0000 (11:35 -0400)]
LP#1374551: Stamping upgrade script for new index on money.billing.voider

Signed-off-by: Ben Shum <>
6 years agoLP#1374551: Create index on money.billing.voider to speed user merge.
Chris Sharp [Fri, 26 Sep 2014 18:19:22 +0000 (14:19 -0400)]
LP#1374551: Create index on money.billing.voider to speed user merge.

Signed-off-by: Chris Sharp <>
Signed-off-by: Ben Shum <>
6 years agoLP#1368314: Stamping upgrade script for RDA support to reporter.simple_record
Ben Shum [Fri, 10 Oct 2014 15:21:34 +0000 (11:21 -0400)]
LP#1368314: Stamping upgrade script for RDA support to reporter.simple_record

Signed-off-by: Ben Shum <>
6 years agoLP#1368314: Add RDA support to reporter.simple_record.
Chris Sharp [Sun, 28 Sep 2014 00:06:22 +0000 (20:06 -0400)]
LP#1368314: Add RDA support to reporter.simple_record.

Signed-off-by: Chris Sharp <>
Signed-off-by: Ben Shum <>
6 years agoLP#1306814: Make use of patron timeout setting for selfcheck
Ben Shum [Fri, 26 Sep 2014 21:05:39 +0000 (17:05 -0400)]
LP#1306814: Make use of patron timeout setting for selfcheck

As described in the bug, the library setting "Self Check: Patron Login Timeout
(in seconds)" does not appear to work with the newer selfcheck interface.

It looks like some of it was already being pulled in, like the variable, but
the interface was not utilizing it.

This commit borrows from the old JS selfcheck and implements a default of
three minutes for selfcheck timeout otherwise handled by the library setting.

Signed-off-by: Ben Shum <>
Signed-off-by: Michele Morgan <>
6 years agoTranslation updates - newpot
Ben Shum [Thu, 25 Sep 2014 06:30:54 +0000 (02:30 -0400)]
Translation updates - newpot

Signed-off-by: Ben Shum <>
6 years agoTranslation updates - po files
Ben Shum [Thu, 25 Sep 2014 06:12:50 +0000 (02:12 -0400)]
Translation updates - po files

Signed-off-by: Ben Shum <>
6 years agoUpdate script for update_pofiles
Ben Shum [Thu, 25 Sep 2014 05:58:56 +0000 (01:58 -0400)]
Update script for update_pofiles

We were missing a few of the folders used for i18n purposes from
the update_pofiles script. Added the following entries:


Also, change from Acq.js to acq.js.

Signed-off-by: Ben Shum <>
6 years agoLP#1252786: Add Workstation link to Aged and Active Circulations reports source.
Chris Sharp [Mon, 29 Sep 2014 00:30:22 +0000 (20:30 -0400)]
LP#1252786: Add Workstation link to Aged and Active Circulations reports source.

Signed-off-by: Chris Sharp <>
Signed-off-by: Ben Shum <>
6 years agoLP#1374091: stamping upgrade script for speedier record_attr views
Ben Shum [Thu, 9 Oct 2014 15:59:17 +0000 (11:59 -0400)]
LP#1374091: stamping upgrade script for speedier record_attr views

Signed-off-by: Ben Shum <>
6 years agoLP#1374091: Speed up metarecord version of unAPI mra call
Mike Rylander [Mon, 29 Sep 2014 16:40:32 +0000 (12:40 -0400)]
LP#1374091: Speed up metarecord version of unAPI mra call

The change to metabib.record_attr_flat in the previous commit caused
a regression in the plan used in unapi.mmr_mra.  This commit addresses
that by unrolling the mra view when used in context with metarecords,
which are shaped differently and require slightly different access

Signed-off-by: Mike Rylander <>
Signed-off-by: Ben Shum <>
6 years agoLP#1374091: Redefine view to help PG make better plans
Mike Rylander [Thu, 25 Sep 2014 18:34:20 +0000 (14:34 -0400)]
LP#1374091: Redefine view to help PG make better plans

The metabib.record_attr_flat view previously pulled its data
through several other intermediate views.  While this improves
maintenance overhead, it ends up being an optimization fence
for certain data sets.  So, we pull the logic from the leaf
views up into the main view.  And, poof, 2 orders of magnitude
speedup on large data sets.

Signed-off-by: Mike Rylander <>
Signed-off-by: Ben Shum <>
6 years agoLP#1378575: teach action::hold_request about behind_desk
Galen Charlton [Tue, 7 Oct 2014 23:42:18 +0000 (16:42 -0700)]
LP#1378575: teach action::hold_request about behind_desk

This patch teaches the CDBI class for the action.hold_request
table about the newish behind_desk column, preventing errors
like this from being thrown if a recent OpenSRF version is in

Processing of hold failed:  Can't locate object method "behind_desk"
via package "action::hold_request" at /usr/local/share/perl/5.14.2/OpenILS/Application/Storage/ line 181.

Signed-off-by: Galen Charlton <>
Signed-off-by: Ben Shum <>
6 years agoLP#1314827: On login, don't allow referer-based redirect to external site
Jeff Davis [Fri, 16 May 2014 22:14:43 +0000 (15:14 -0700)]
LP#1314827: On login, don't allow referer-based redirect to external site

On /eg/opac/login, if no redirect_to param is provided, the TPAC will
attempt to use the referer (if any) as the redirect destination. This
leads to undesirable behavior if the referring URL is from an external

Signed-off-by: Jeff Davis <>
Signed-off-by: Ben Shum <>
6 years agoDocumentation bug: corrected image file
Angela Kilsdonk [Thu, 2 Oct 2014 15:41:35 +0000 (10:41 -0500)]
Documentation bug: corrected image file

Signed-off-by: Angela Kilsdonk <>
6 years agoWhitespace and non-weird emdash in docs
Dan Scott [Wed, 1 Oct 2014 19:37:08 +0000 (15:37 -0400)]
Whitespace and non-weird emdash in docs

Signed-off-by: Dan Scott <>
6 years agoDocs: Change all internal links to correct format
Josh Stompro [Mon, 15 Sep 2014 01:08:40 +0000 (20:08 -0500)]
Docs: Change all internal links to correct format

Resolves LP#1294347

I just deleted one link since I couldn't find any trace of where it was intended to go.

"or use the link:federated.txt[View/Place Orders] menu item in the catalog."

If anyone ever finds where that is supposed to go, let me know and I'll fix it.

Signed-off-by: Josh Stompro <>
Signed-off-by: Remington Steed <>
6 years agoLP#1347774 CStoreEditor anonymous PCRUD additions
Bill Erickson [Fri, 1 Aug 2014 17:29:41 +0000 (13:29 -0400)]
LP#1347774 CStoreEditor anonymous PCRUD additions

* Exporter repairs : use export_to_level
* pcrud personality call argument mod repair
* log pcrud personality json_query attempts loudly to ease transition
* CStoreEditor anon/pcrud personality live test

* CStoreEditor anon pcrud default to undef authtoken:
The presence of an authtoken ("ANONYMOUS") in the editor can be
misleading at higher levels of the code, since it implies a
presumably functional authtoken has been provided somewhow.
Apply ANONYMOUS only as needed to API calls instead.

Signed-off-by: Bill Erickson <>
Signed-off-by: Mike Rylander <>
6 years agoLP#1347774 Anonymous PCRUD mode
Mike Rylander [Thu, 24 Jul 2014 19:03:37 +0000 (15:03 -0400)]
LP#1347774 Anonymous PCRUD mode

Support for anonymous access to public (field_safe=true) IDL data
via PCRUD without requiring an authtoken.  To use, pass an authtoken of

Includes initial CStoreEditor plugin for anon pcrud.

Signed-off-by: Mike Rylander <>
Signed-off-by: Bill Erickson <>
6 years agoLP#1373693: Speed up call number browse search at top level org.
Chris Sharp [Thu, 25 Sep 2014 15:45:44 +0000 (11:45 -0400)]
LP#1373693: Speed up call number browse search at top level org.

Signed-off-by: Chris Sharp <>
Signed-off-by: Ben Shum <>
6 years agoDocs: Removed redundant phrase as mentioned in bug #1294299
Snigdha Dagar [Thu, 25 Sep 2014 03:02:54 +0000 (23:02 -0400)]
Docs: Removed redundant phrase as mentioned in bug #1294299

Signed-off-by: Yamil Suarez <>
6 years agoDocs: Updated 2 links that pointed to the old subversion repository
Snigdha Dagar [Thu, 25 Sep 2014 02:42:35 +0000 (22:42 -0400)]
Docs: Updated 2 links that pointed to the old subversion repository

Signed-off-by: Yamil Suarez <>
6 years agoDocs: Removed a redundant phrase as mentioned in bug #1294299
Snigdha Dagar [Thu, 25 Sep 2014 02:26:55 +0000 (22:26 -0400)]
Docs: Removed a redundant phrase as mentioned in bug #1294299

Signed-off-by: Yamil Suarez <>
6 years agoTidy search section of Using the OPAC
Dan Scott [Wed, 24 Sep 2014 03:29:42 +0000 (23:29 -0400)]
Tidy search section of Using the OPAC

Primarily focused on restructuring the information around Boolean
searching, particularly as I find librarians want to know what the
Boolean operators are that they should use. However, cleaned up some
typos and formatting along the way.

Signed-off-by: Dan Scott <>
6 years agoDocs: for new "Imported As" column in Vandelay queue results view
Yamil Suarez [Fri, 19 Sep 2014 18:56:47 +0000 (14:56 -0400)]
Docs: for new "Imported As" column in Vandelay queue results view

Added explanation of the new "Imported As" menu in "MARC Batch Import/Export"
queue results view, also updated screenshots.

Thanks to Joan Kranich of C/W MARS, for helping research were to make these

Signed-off-by: Yamil Suarez <>
6 years agoSmall typo fix for Blu-Ray spelling
Kathy Lussier [Fri, 19 Sep 2014 16:07:11 +0000 (12:07 -0400)]
Small typo fix for Blu-Ray spelling

Signed-off-by: Kathy Lussier <>
6 years agoUpdated formats
Snigdha Dagar [Thu, 18 Sep 2014 16:27:13 +0000 (21:57 +0530)]
Updated formats

Updated the formats under basic search according to version 2.6

Signed-off-by: Kathy Lussier <>
6 years agoUpdate core committer information on the staff client's About Page
Ben Shum [Thu, 11 Sep 2014 21:42:26 +0000 (17:42 -0400)]
Update core committer information on the staff client's About Page

senator has not contributed anything new for the past six months and is
therefore moved to the "Past Core Committer" listing per policies on:

berick belongs to a new organization and this has been updated accordingly.

Signed-off-by: Ben Shum <>
6 years agoLP#1234927: Pluralizing link names to follow convention.
Chris Sharp [Thu, 18 Sep 2014 16:49:45 +0000 (12:49 -0400)]
LP#1234927: Pluralizing link names to follow convention.

Based on feedback from Mike Rylander on the Launchpad ticket.

Signed-off-by: Chris Sharp <>
Signed-off-by: Ben Shum <>
6 years agoLP#1234927 Reporter needs Item -> Combined Aged and Active Circulations link
Chris Sharp [Thu, 18 Sep 2014 14:16:20 +0000 (10:16 -0400)]
LP#1234927 Reporter needs Item -> Combined Aged and Active Circulations link

There is a need for item usage statistics that include more than just active
circulations.  I have included links to both Aged (patronless) Circulations
and to Combined Aged and Active Circulations sources.

Signed-off-by: Chris Sharp <>
Signed-off-by: Ben Shum <>
6 years agoLP#1371173: Reporter: Classic Item List needs link to Item source
Chris Sharp [Thu, 18 Sep 2014 15:08:18 +0000 (11:08 -0400)]
LP#1371173: Reporter: Classic Item List needs link to Item source

Add a link on the reporter.classic_item_list fieldmapper definition
to asset.copy.

Signed-off-by: Chris Sharp <>
Signed-off-by: Ben Shum <>
6 years agoMore additions to 2.7 Release Notes (part 2)
Ben Shum [Fri, 19 Sep 2014 00:39:05 +0000 (20:39 -0400)]
More additions to 2.7 Release Notes (part 2)

Add Steve Callender and move Yamil Suarez to the correct position alphabetically.

Also, note the location of the web client README.install file, but also
promise to update this by the next minor release of 2.7 series as a new
section of the primary README file.

Signed-off-by: Ben Shum <>
6 years agoMore additions to 2.7 Release Notes
Kathy Lussier [Thu, 11 Sep 2014 17:10:21 +0000 (13:10 -0400)]
More additions to 2.7 Release Notes

Additions include a brief description of the web client preview, the
addition of Sprint 1 funding partners in the acknowledgements section,
the addition of NC Cardinal in the acknolwedgements section for
funding an acq funds transfer fix, and the addition of another code
contributor whose patch was just merged over the past few days.

Signed-off-by: Kathy Lussier <>
Signed-off-by: Ben Shum <>
6 years agolp1271198 Strip browse and facet parameters from links
Kathy Lussier [Tue, 26 Aug 2014 19:49:45 +0000 (15:49 -0400)]
lp1271198 Strip browse and facet parameters from links

Browse and facet parameters were sticking to links to author, subject and
series links on record and result pages, as well as some other links where
the search parameters were no longer necessary. This commit:

1. Adds browse_search_parms and facet_search_parms to header.tt2 as new
classes of search parameters that one may want to remove.

2. Removes these parameters from the author and subject links on the
record page. It also uses the same method for removing search parameters
from the author link on the search results page and on the searchbar
Browse link.

3. Fixes an issue where the advanced search links were inadvertently
stripping general search parameters.

4. Adds more parameters to the general_search_parms group so that we can
have cleaner URLs.

Signed-off-by: Kathy Lussier <>
Signed-off-by: Jason Stephenson <>
6 years agoLP 1319560: Another fix for summary.tt2.
Jason Stephenson [Mon, 19 May 2014 13:19:49 +0000 (09:19 -0400)]
LP 1319560: Another fix for summary.tt2.

Argument "" isn't numeric in numeric gt (>) at
/openils/var/templates/opac/parts/record/summary.tt2 line 56.

It was apparently coming from the .size and not where I thought.

Signed-off-by: Jason Stephenson <>
Signed-off-by: Ben Shum <>
6 years agoLP 1319560: Fix the disappearing hold button.
Jason Stephenson [Thu, 15 May 2014 15:31:56 +0000 (11:31 -0400)]
LP 1319560: Fix the disappearing hold button.

Staff discovered an issue with the tt2 changes that caused the
place hold button to disappear when it shouldn't. Changing an &&
back to || seems to fix this.

Signed-off-by: Jason Stephenson <>
Signed-off-by: Ben Shum <>
6 years agoLP 1319560: Silence template error messages in Apache error log.
Jason Stephenson [Wed, 14 May 2014 19:46:29 +0000 (15:46 -0400)]
LP 1319560: Silence template error messages in Apache error log.

We get a number of messages like the following in our Apache error
logs on a constant basis:

Argument "" isn't numeric in addition (+) at
/openils/var/templates/opac/parts/record/navigation.tt2 line 6.
Argument "" isn't numeric in division (/) at
/openils/var/templates/opac/results.tt2 line 1.
Argument "" isn't numeric in numeric ge (>=) at
/openils/var/templates/opac/parts/record/navigation.tt2 line 38.
Argument "" isn't numeric in numeric gt (>) at
/openils/var/templates/opac/myopac/holds/edit.tt2 line 106.
Argument "" isn't numeric in numeric gt (>) at
/openils/var/templates/opac/myopac/holds.tt2 line 42.
Argument "" isn't numeric in numeric gt (>) at
/openils/var/templates/opac/parts/place_hold.tt2 line 98.
Argument "" isn't numeric in numeric gt (>) at
/openils/var/templates/opac/parts/record/summary.tt2 line 56.
Argument "" isn't numeric in numeric gt (>) at
/openils/var/templates/opac/parts/result/table.tt2 line 87.
Argument "" isn't numeric in numeric lt (<) at
/openils/var/templates/opac/myopac/hold_history.tt2 line 122.
Argument "" isn't numeric in numeric lt (<) at
/openils/var/templates/opac/myopa/result/table.tt2 line 87.
Argument "" isn't numeric in numeric lt (<) at
/openils/var/templates/opac/myopac/hold_history.tt2 line 122.
Argument "" isn't numeric in numeric lt (<) at
/openils/var/templates/opac/myopac/holds.tt2 line 215.

This commit adds some sanity checking to make those messages go

Signed-off-by: Jason Stephenson <>
Signed-off-by: Ben Shum <>
6 years agoLP#1251347: Get the most recent session locale for Event description translation
Mike Rylander [Thu, 14 Nov 2013 18:36:25 +0000 (13:36 -0500)]
LP#1251347: Get the most recent session locale for Event description translation

Signed-off-by: Mike Rylander <>
Signed-off-by: Ben Shum <>
6 years agoFix LP904860, Cannot print a patron address label
Steven Chan [Mon, 29 Jul 2013 23:27:13 +0000 (16:27 -0700)]
Fix LP904860, Cannot print a patron address label

The sequence of events for printing an address label is as follows.
Staff client Code in the util/print.js file builds an HTML page of the
address label.  The page includes two vital components, 1) a source tag
to pull 'print_win.js' file from the server, and 2) an onload event
handler bound to the body tag to execute a 'print_init()' function that
is defined in the source tag.

However, print_init() is undefined because the source tag contains a
badly formed URL. It needs to be prefixed by 'oils://remote' so that the
new 'oils:' protocol can be used to pull the file remotely from the

Signed-off-by: Steven Chan <>
Signed-off-by: Ben Shum <>
6 years agoLP#1231634: Mark Floating Groups Config UI strings translatable.
Pasi Kallinen [Thu, 7 Nov 2013 17:37:42 +0000 (19:37 +0200)]
LP#1231634: Mark Floating Groups Config UI strings translatable.

Signed-off-by: Pasi Kallinen <>
Signed-off-by: Ben Shum <>
6 years agoLP#1331127 Repair sort logic of previous issuances
Bill Erickson [Tue, 17 Jun 2014 19:14:12 +0000 (15:14 -0400)]
LP#1331127 Repair sort logic of previous issuances

Ensure that the list of previous issuances is sorted correctly (on
date_published) when looking for the previous serial.unit to update its
copy location (when serial.prev_issuance_copy_location is enabled).

The data comes sorted from the DB, but the sorting was lost during the
process of unique-ifying the list.  Ultimately, it was relying on the
order of hash keys, which is undefined.

Signed-off-by: Bill Erickson <>
Signed-off-by: Dan Wells <>
6 years agoLP 1369128: Add delete permission to fm_IDL.xml for class bre.
Jason Stephenson [Thu, 18 Sep 2014 20:49:20 +0000 (16:49 -0400)]
LP 1369128: Add delete permission to fm_IDL.xml for class bre.

Signed-off-by: Jason Stephenson <>
Signed-off-by: Ben Shum <>
6 years agoLP#1370630: don't log mod_deflate actions by default
Galen Charlton [Wed, 17 Sep 2014 17:22:15 +0000 (10:22 -0700)]
LP#1370630: don't log mod_deflate actions by default

This patch comments out logging of mod_deflate actions,
as this is needed only for debugging.  Otherwise,
deflate_log will grow without bound, as it isn't dealt
with by typical default logrotate configs.

Signed-off-by: Galen Charlton <>
Signed-off-by: Ben Shum <>
6 years agoLP#1361801: Add required fields to serial issuance form
Remington Steed [Fri, 29 Aug 2014 18:45:50 +0000 (14:45 -0400)]
LP#1361801: Add required fields to serial issuance form

This commit prevents issuances from being created without a date_published
or holding_code. This has two benefits:

  1. Prevents uncaught exceptions related to submitting null values for
     either of those fields.
  2. Requiring date_published prevents an ugly error when trying to
     predict new issuances from an issuance without a date_published.

This commit does NOT provide any feedback to the user about which fields
are required. That would require further investigation into the Dojo/Dijit
objects being used for the edit form fields.

Signed-off-by: Remington Steed <>
Signed-off-by: Jennifer Pringle <>
Signed-off-by: Ben Shum <>
6 years agoLP#1246859: Improve username flow for staged users
Jeff Godin [Wed, 30 Oct 2013 20:41:06 +0000 (16:41 -0400)]
LP#1246859: Improve username flow for staged users

Staged users in most cases have a username that consists of a UUID.

Rather than leave the UUID as their username or require staff to
clear the field and replace it with a barcode or other value, it
would be better to remove this username when loading the staged user
in the user editor.

This commit clears the username when loading a stage user if the
username looks like a UUID.

If a barcode has been staged for the loaded staged user, the
username will be populated with that value.

If there is no staged barcode, the username will remain blank and
will be populated using the standard method after staff enters a
value in the barcode field.

Signed-off-by: Jeff Godin <>
Signed-off-by: Ben Shum <>
6 years agoLP#1356576 repair sip date_format config typo
Bill Erickson [Wed, 13 Aug 2014 20:44:50 +0000 (16:44 -0400)]
LP#1356576 repair sip date_format config typo

Avoids "Use of uninitialized value in bitwise or (|)" error.

Signed-off-by: Bill Erickson <>
Signed-off-by: Ben Shum <>
6 years agoLP1309131 - Fix series link
Kathy Lussier [Tue, 12 Aug 2014 21:33:16 +0000 (17:33 -0400)]
LP1309131 - Fix series link

Clicking on a series link with a hyphen failed because the hyphen was
stripped and the two words are joined together. This branch changes
series.tts to replace special characters with a space, which is similar to
the links we build for authors.

Signed-off-by: Kathy Lussier <>
Signed-off-by: Ben Shum <>
6 years agoLP#1325720 Repair fund rollover year selector query
Bill Erickson [Mon, 2 Jun 2014 20:14:38 +0000 (16:14 -0400)]
LP#1325720 Repair fund rollover year selector query

Dojo dojo stores track values as strings, so values used in data store
queries must be coerced into strings before performing the query.

This fixes the year query in the fund rollover UI so that the page is
able to render the results of a rollover without dying from an JS error
before completing.

Signed-off-by: Bill Erickson <>
Signed-off-by: Ben Shum <>
6 years agoLP#1292129: Removed deleted call numbers from the search results to properly show...
Steven Callender [Thu, 13 Mar 2014 17:34:23 +0000 (13:34 -0400)]
LP#1292129: Removed deleted call numbers from the search results to properly show copy count.

The SQL in fm_IDL.xml for setting up the reporter source "Hold/Copy
Ratio per Bib" includes deleted call numbers which in turn can give
an incorrect copy count. The ratio appears to still be correct because
deleted copies are considered in the ratio calculation, but not the
copy count that is displayed.

Signed-off-by: Steven Callender <>
Signed-off-by: Ben Shum <>
6 years agoLP 1350345: marc_export blows up on bad records.
Jason Stephenson [Wed, 30 Jul 2014 13:26:38 +0000 (09:26 -0400)]
LP 1350345: marc_export blows up on bad records.

Add some eval blocks around calls to MARC::Record->as_usmarc and
MARC::Record->as_xml_record to trap errors in bibliograpic and
authority records.

If MARC::Record reports an error, print the record id and the
error message and continue the export.

Signed-off-by: Jason Stephenson <>
Signed-off-by: Ben Shum <>
6 years agoLP#1358916: refuse to retrieve over-large MARC records via Z39.50
Galen Charlton [Tue, 19 Aug 2014 20:19:20 +0000 (13:19 -0700)]
LP#1358916: refuse to retrieve over-large MARC records via Z39.50

At least one malformed record discovered in the wild can
cause backends to balloon to over 3G of memory
consumption.  This patch works around that by refusing
to process any (MARC) Z39.50 results that are larger than the
MARC record maximum of 99,999 octets.

Signed-off-by: Galen Charlton <>
Signed-off-by: Ben Shum <>
6 years agoLP#1340947: Finish support in for -y and -z options
Jason Boyer [Mon, 14 Jul 2014 12:35:39 +0000 (08:35 -0400)]
LP#1340947: Finish support in for -y and -z options

Signed-off-by: Jason Boyer <>
Signed-off-by: Ben Shum <>
6 years agoLP#1357364: Explictly create the extension in the "public" schema.
Chris Sharp [Fri, 15 Aug 2014 12:58:04 +0000 (08:58 -0400)]
LP#1357364: Explictly create the extension in the "public" schema.

Thanks to Thomas Berezansky for the suggestion!

Signed-off-by: Chris Sharp <>
Signed-off-by: Ben Shum <>