working/Evergreen.git
6 years agowebstaff: add support for editing authority records
Galen Charlton [Fri, 28 Aug 2015 00:45:23 +0000 (00:45 +0000)]
webstaff: add support for editing authority records

This adds basic support for invoking the MARC editor on
authority records, and fixes a couple bugs discovered
along the way. The route currently supported is

/cat/catalog/authority/:authority_id/marc_edit

In the future, some sort of summary view of an authority
record might be added, in which case the route
"/cat/catalog/authority/:authority_id" is available.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: add routine for Dojo JS to detect if running in iframe
Galen Charlton [Thu, 27 Aug 2015 22:23:23 +0000 (22:23 +0000)]
webstaff: add routine for Dojo JS to detect if running in iframe

Sometimes legacy Dojo interfaces may need to adjust their
behavior if they're embedded in the web staff client. This patch
adds a new utility function, openils.Util.inIFrame(), to detect
if such code is running in an iframe. If so, the presumption
is that iframe belongs to the web staff client.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Add actions for editing just copy attributes or vol/copy details
Mike Rylander [Fri, 21 Aug 2015 17:30:06 +0000 (13:30 -0400)]
webstaff: Add actions for editing just copy attributes or vol/copy details

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Disable org selector when defaults say to
Mike Rylander [Fri, 21 Aug 2015 17:23:37 +0000 (13:23 -0400)]
webstaff: Disable org selector when defaults say to

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Teach org selector to be completely disabled via text attr
Mike Rylander [Fri, 21 Aug 2015 17:23:12 +0000 (13:23 -0400)]
webstaff: Teach org selector to be completely disabled via text attr

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Supply a "defaults" interface for disabling element and setting call number...
Mike Rylander [Fri, 21 Aug 2015 17:11:49 +0000 (13:11 -0400)]
webstaff: Supply a "defaults" interface for disabling element and setting call number batch defaults

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Expose columns through grid controls for external column pickers
Mike Rylander [Fri, 21 Aug 2015 17:10:41 +0000 (13:10 -0400)]
webstaff: Expose columns through grid controls for external column pickers

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Layout improvements and templates
Mike Rylander [Fri, 21 Aug 2015 02:18:02 +0000 (22:18 -0400)]
webstaff: Layout improvements and templates

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: improvements to core UI widgets
Mike Rylander [Fri, 21 Aug 2015 02:17:20 +0000 (22:17 -0400)]
webstaff: improvements to core UI widgets

* Add enter-key-handler
* improve basic combo box
* teach org selector how to not have a default value

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Add a "Batch Apply" template row above call numbers
Mike Rylander [Wed, 19 Aug 2015 17:43:23 +0000 (13:43 -0400)]
webstaff: Add a "Batch Apply" template row above call numbers

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Update all instances of the call number, mainly for copy display
Mike Rylander [Tue, 18 Aug 2015 21:53:48 +0000 (17:53 -0400)]
webstaff: Update all instances of the call number, mainly for copy display

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Copy editing!
Mike Rylander [Tue, 18 Aug 2015 21:27:47 +0000 (17:27 -0400)]
webstaff: Copy editing!

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Teach the grid how to flesh the last step in a path if it is unfleshed
Mike Rylander [Tue, 18 Aug 2015 21:26:58 +0000 (17:26 -0400)]
webstaff: Teach the grid how to flesh the last step in a path if it is unfleshed

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoDocs: 2.9 Purchase Order Activation Progress Bar
Angela Kilsdonk [Fri, 11 Sep 2015 21:20:15 +0000 (16:20 -0500)]
Docs: 2.9 Purchase Order Activation Progress Bar

Author: Mary Jinglewski

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
6 years agoDocs: 2.9 Updates to OPAC documentation
Angela Kilsdonk [Fri, 11 Sep 2015 21:14:48 +0000 (16:14 -0500)]
Docs: 2.9 Updates to OPAC documentation

Updates by Mary Jinglewski.

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
6 years agoDocs: New screenshots for Conjoined Items section
Remington Steed [Fri, 11 Sep 2015 19:14:38 +0000 (15:14 -0400)]
Docs: New screenshots for Conjoined Items section

Signed-off-by: Remington Steed <rjs7@calvin.edu>
6 years agoDocs 2.9: Remove JSPAC references and screenshots
Remington Steed [Thu, 10 Sep 2015 20:48:56 +0000 (16:48 -0400)]
Docs 2.9: Remove JSPAC references and screenshots

This commit removes the references in the docs to the now removed JSPAC,
and replaces all known remaining JSPAC screenshots, and when required
updates the descriptions to match TPAC features. It also fixes AsciiDoc
ordered list syntax in a few cases, which interfered with testing.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
6 years agoDocs: New link to My Lists
Christine Burns [Thu, 10 Sep 2015 21:14:50 +0000 (17:14 -0400)]
Docs: New link to My Lists

Signed-off-by: Yamil Suarez <yamil@yamil.com>
6 years agoDocs: Link in catalog to clear Added Content cache
Lynn Floyd [Thu, 10 Sep 2015 18:13:44 +0000 (14:13 -0400)]
Docs: Link in catalog to clear Added Content cache

Signed-off-by: Yamil Suarez <yamil@yamil.com>
6 years agoDocs: add info on disabled Google Analytics in staff client
Yamil Suarez [Thu, 10 Sep 2015 16:12:16 +0000 (12:12 -0400)]
Docs: add info on disabled Google Analytics in staff client

Signed-off-by: Yamil Suarez <yamil@yamil.com>
6 years agoDocs: remove TPAC based Searching of Authorities section
Yamil Suarez [Thu, 10 Sep 2015 15:38:25 +0000 (11:38 -0400)]
Docs: remove TPAC based Searching of Authorities section

This fucntionality does nto exist in TPAC.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
6 years agoDocs: add more details about displaying authority subject heading thesaurus value
Yamil Suarez [Thu, 10 Sep 2015 15:25:21 +0000 (11:25 -0400)]
Docs: add more details about displaying authority subject heading thesaurus value

Signed-off-by: Yamil Suarez <yamil@yamil.com>
6 years agoLP#1361266 Patron self-registration form accepts date of birth in wrong format
Michael Peters [Thu, 4 Dec 2014 20:56:53 +0000 (15:56 -0500)]
LP#1361266 Patron self-registration form accepts date of birth in wrong format

This patch applys some basic javascript to validate that a date entered is
at least in ISO 8601 format.  This prevents someone from entering "cupcake"
or 55/66/6666 as a valid date of birth by validating the stgu.dob input
at the time of submission.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoLP#1472380 Display all Vandelay authority matches
Bill Erickson [Tue, 7 Jul 2015 19:49:59 +0000 (15:49 -0400)]
LP#1472380 Display all Vandelay authority matches

Ensure a row is added for every authority record match in the Vandelay
match grid, even when multiple matches refer to the same authority
record.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoLP#1465847 Empty patron search exits early
Bill Erickson [Mon, 22 Jun 2015 16:01:19 +0000 (12:01 -0400)]
LP#1465847 Empty patron search exits early

If no search parameters or invalid search parameters are sent to the
patron search API, the API call exits early with zero results.  This
avoids cases where empty searches can lead to heavy DB calls, querying
and sorting he entire patron data set.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoLP#1491962 Fix 0847 Live Test
Jason Stephenson [Thu, 3 Sep 2015 17:48:20 +0000 (13:48 -0400)]
LP#1491962 Fix 0847 Live Test

The fix for LP 1484281 broke the 0847.auth_overlay_generator.pg live
test.  Since e was removed from the controlled subfield list for the
100 authority tag, it needs to be removed from the expected live test
results.

This commit does that.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP#1484281: Stamping Upgrade Script.
Jason Stephenson [Wed, 2 Sep 2015 16:00:15 +0000 (12:00 -0400)]
LP#1484281: Stamping Upgrade Script.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoLP# 1484281 auth control config update release notes
Yamil Suarez [Wed, 2 Sep 2015 15:20:23 +0000 (11:20 -0400)]
LP# 1484281 auth control config update release notes

Signed-off-by: Yamil Suarez <yamil@yamil.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoLP# 1484281 auth control config update to prevent propagated data deletion
Yamil Suarez [Mon, 17 Aug 2015 20:47:34 +0000 (16:47 -0400)]
LP# 1484281 auth control config update to prevent propagated data deletion

Remove subfield 'e' from authority.control_set_authority_field seed values

Removed from the auth tag 100 and 110, which should apply to bib tags
100,110,600,610,700,710

Added upgrade script, and pgTAP test.

How to test this patch
----------------------
[1] To test this bug you need 1 authority record and at least 1 bib record.
The auth record needs to have an auth 100 or 110 tag that has a subfield $e,
for example 100 $aDavis, Miles $ecomposer. (for the record, it is not good
cataloging practice to have $e in the auth record, but it can happen by mistake.)
The bib record needs to be have a matching bib 100 or 700 tag with the same
subfield $a and $e. In addition the matching bib tag has to be linked to the
authority record, i.e. the bib tag has to have a bib subfield $0 with the DB
id of the authority record.

[2] If you open up the authority record, in the authority MARC editor, and remove
the subfield $e; the subfield $e found in the bib record tag will be removed.
This is a mistake because normally bib record tags 100/110/700/710 do use subfield
$e, though the subfield $e should not be used in the auth record 100/110 tags.

[3] When this patch is applied, if a cataloger removes a subfield $e from an auth
100/110 tag, the deletion will not cascade to its linked bibs.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoLP#1487143: remove legacy_script_support from example SIP config
Galen Charlton [Thu, 20 Aug 2015 17:32:28 +0000 (17:32 +0000)]
LP#1487143: remove legacy_script_support from example SIP config

This patch removes the legacy_script_support option (and the
related references to the scripts themselves) from the example
SIPServer config, as they now have no effect.

Existing Evergreen sites can choose to remove those configuraiton
options or leave them in.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP#1484989: tweak test case
Galen Charlton [Thu, 27 Aug 2015 16:02:57 +0000 (16:02 +0000)]
LP#1484989: tweak test case

This adjusts the test case so that it will
report on the planned number of tests even if the
test circ cannot be retrieved for some reason.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoLP#1484989 Don't close xacts with checkin-generated fines
Dan Wells [Fri, 14 Aug 2015 19:11:16 +0000 (15:11 -0400)]
LP#1484989 Don't close xacts with checkin-generated fines

If a transaction has checkin-generated fines, and previously had a
balance of zero, the rearranged billing code was prematurely closing
the transaction.  This commit separates the closing step to run after
any possible fine generation.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoUpdate Translations
Jason Stephenson [Wed, 26 Aug 2015 19:24:19 +0000 (15:24 -0400)]
Update Translations

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoLP#1486800: Remove Penalty.pm from MANIFEST
Ben Shum [Thu, 20 Aug 2015 02:34:25 +0000 (22:34 -0400)]
LP#1486800: Remove Penalty.pm from MANIFEST

With the changes from bug 1312308, open-ils.penalty service was removed
(see http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=432a106facf4ee93e544408d70524f06d55ff56e in master).

When performing a make install afterwards, we see this warning in the
console:

WARNING: the following files are missing in your kit:
 lib/OpenILS/Application/Penalty.pm
Please inform the author.

Looking around, I can see that we may need to remove the entry for
lib/OpenILS/Application/Penalty.pm from OpenILS/lib/perlmods/MANIFEST.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoForward porting 2.8.2->2.8.3 SQL upgrade
Bill Erickson [Thu, 20 Aug 2015 14:23:33 +0000 (10:23 -0400)]
Forward porting 2.8.2->2.8.3 SQL upgrade

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP#1484650: Missing webstaff2pot make target for newpot
Ben Shum [Wed, 19 Aug 2015 22:11:18 +0000 (18:11 -0400)]
LP#1484650: Missing webstaff2pot make target for newpot

Seems that something went awry with the commit I submitted for pullrequest
and we missed the actual change to make the webstaff client file for
translation.

Fixed.

Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoRelease notes for 2.8.3 release
Kathy Lussier [Wed, 19 Aug 2015 21:13:22 +0000 (17:13 -0400)]
Release notes for 2.8.3 release

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
6 years agolp1198465 Release notes for Conditional Negative Balance branch
Kathy Lussier [Mon, 10 Feb 2014 05:24:18 +0000 (00:24 -0500)]
lp1198465 Release notes for Conditional Negative Balance branch

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
6 years agoFix mis-stamping of 0940.schema.vlist_freq.sql.
Jason Stephenson [Wed, 19 Aug 2015 19:52:47 +0000 (15:52 -0400)]
Fix mis-stamping of 0940.schema.vlist_freq.sql.

I typed the wrong number in the upgrade script.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoLP#1484650: Add webstaff as an i18n target
Ben Shum [Thu, 13 Aug 2015 16:27:57 +0000 (12:27 -0400)]
LP#1484650: Add webstaff as an i18n target

In order to begin the translation process for the new web client
development, we need to add a new translation target file.

Using tpac tt2 as an example, I have added a new "webstaff" target
that will include all the staff pages that have been created up till
now.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoLP# 1086934 - TPAC: Complete column sorting in some screens
Dan Pearl [Wed, 14 Nov 2012 17:14:11 +0000 (12:14 -0500)]
LP# 1086934 - TPAC: Complete column sorting in some screens

(specifically holds, circs, and circs_history)

An earlier LP issue #1010277 concerned the halfway implementation of
the column sort facility, and was addressed at the time by ripping out any hint of
column sort capability, among other cleanup issues.

The sorting capability has now been implemented with the following functionality:
  * Clicking on the appropriate column heads now sorts the contents from
    "ascending" to "descending" to "no sort".  (The "no sort" will restore the
    original list as presented to the patron.)

  * The sort indicator (an up or down arrow) is placed to the right
    of the column head, as appropriate.

  * The combined "Title/Author" column in the circ screens is now separated into two
    independently sortable columns (Title and Author).

  * Title sorting is done with the 'filing' characters (leading "the", "a",
    "an", and other langugage equivalents) removed. To clarify the
    behavior for the patron, the leading articles are rendered in
    a smaller font, so as to keep the main entry prominent.  In
    addition to the filing characters removed for the sort, leading
    non-alphanumeric characters are ignored in the sort.

This commit only affects those screens and columns that suggested column sorting
capability.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/templates/opac/parts/topnav.tt2

Conflicts:
Open-ILS/src/templates/opac/css/style.css.tt2

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
6 years agoLP#1457111 eg-pbx-allocator uses modern rpc api name
Bill Erickson [Wed, 20 May 2015 16:24:13 +0000 (12:24 -0400)]
LP#1457111 eg-pbx-allocator uses modern rpc api name

Replace "-" with "__" in XML-RPC method name for compatibility with
modern Perl XML-RPC libraries.

See also https://bugs.launchpad.net/bugs/1050596

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP 1438136: Stamping upgrade script.
Jason Stephenson [Wed, 19 Aug 2015 19:01:10 +0000 (15:01 -0400)]
LP 1438136: Stamping upgrade script.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoLP#1438136: Make upgrade script forgiving
Mike Rylander [Sun, 26 Apr 2015 16:29:18 +0000 (12:29 -0400)]
LP#1438136: Make upgrade script forgiving

If the functions already exist, that's OK.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoLP#1438136: Protect PG < 9.2 from our stats probe
Mike Rylander [Fri, 17 Apr 2015 16:37:06 +0000 (12:37 -0400)]
LP#1438136: Protect PG < 9.2 from our stats probe

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoLP#1438136: Update baseline schema files
Mike Rylander [Thu, 16 Apr 2015 21:39:49 +0000 (17:39 -0400)]
LP#1438136: Update baseline schema files

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoLP#1438136: Teach QP to be smart about attribute selectivity
Mike Rylander [Wed, 15 Apr 2015 16:10:27 +0000 (12:10 -0400)]
LP#1438136: Teach QP to be smart about attribute selectivity

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoLP#1124498 - Release notes for expiration notice.
Josh Stompro [Fri, 14 Aug 2015 13:37:29 +0000 (08:37 -0500)]
LP#1124498 - Release notes for expiration notice.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP#1124498: Stamping upgrade script for 30 day pre-expiration notice
Ben Shum [Wed, 19 Aug 2015 18:49:45 +0000 (14:49 -0400)]
LP#1124498: Stamping upgrade script for 30 day pre-expiration notice

Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP#1124498 - Changed hook name so it includes a prefix to make it clear
Josh Stompro [Mon, 17 Aug 2015 18:45:16 +0000 (13:45 -0500)]
LP#1124498 - Changed hook name so it includes a prefix to make it clear
  it is for actor.usr, and changed the hook description so it matches
  the other au hooks.  I added "account" because I hate to say "A user has
  expired", when there might be a field for deceased status at some point.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP#1124498 - Made a few format changes just to better match how other sql is formatted.
Josh Stompro [Thu, 23 Apr 2015 15:32:32 +0000 (10:32 -0500)]
LP#1124498 - Made a few format changes just to better match how other sql is formatted.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP#1124498 - Added 30 Day pre expire notice to 950.data.seed-values.sql
Josh Stompro [Wed, 22 Apr 2015 19:36:18 +0000 (14:36 -0500)]
LP#1124498 - Added 30 Day pre expire notice to 950.data.seed-values.sql

This will install this notice for new installs.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP#1124498 - Patron Notice when account expires - fixes and enhancements
Josh Stompro [Tue, 11 Nov 2014 19:07:36 +0000 (13:07 -0600)]
LP#1124498 - Patron Notice when account expires - fixes and enhancements

Changes from Michael Peters initial commit
 - Added repeat delay

 - Removed group_field since that doesn't make sense in
   this usage scenario.

 - Commented out the user param for email sender, not needed.

 - Removed error-to header, not commonly used anymore.

 - Added Auto-Submitted header since email sent out via
   this action are automatically generated.

 - Changed references to card expiring to account expiring.
   It is the patron's account that is expiring, not their card.

 - Fixed up the address lines so it tries to grab the
   mailing_address first, then the billing address.

 - Set the notices to be disabled by default.  So it takes some
   admin action to enable.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP#1124498 Patron notification via email for card expiration
Michael Peters [Wed, 13 Feb 2013 20:52:54 +0000 (15:52 -0500)]
LP#1124498 Patron notification via email for card expiration

The attached code creates an action/trigger event which notifies a patron, via
email, that their card is about to expire.

There are two portions to this code:

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP#1240119 safe auth activity live test
Bill Erickson [Wed, 19 Aug 2015 15:08:48 +0000 (11:08 -0400)]
LP#1240119 safe auth activity live test

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoLP#1240119 Safe auth token activity logging
Bill Erickson [Mon, 19 Aug 2013 13:24:17 +0000 (09:24 -0400)]
LP#1240119 Safe auth token activity logging

Expand safe token generation to include user ID in the cached data,
which can be retrieved later for activity logging.  Add activity logging
directly to the open-ils.actor.safe_token.home_lib.shortname API.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoLP#1479107 adjust to zero UI
Bill Erickson [Mon, 11 Nov 2013 14:16:03 +0000 (09:16 -0500)]
LP#1479107 adjust to zero UI

New "Adjust to Zero" option in patron billing UI.  Selected
transactions are updated to have a zero balance by rebilling
and/or adding adjustments as required.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoLP#1479107 adjust to zero API
Dan Wells [Fri, 8 Nov 2013 16:43:38 +0000 (11:43 -0500)]
LP#1479107 adjust to zero API

API call for manually adjusting a transaction to zero.  It works
by rebilling previously voided billings (if necessary) until a
positive balance is reached, then applying adjustment payments
to zero out the balance.

open-ils.circ.money.billable_xact.adjust_to_zero(auth, [xact_ids])

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoLP#1479107 Fix IDL classname for account adjustments
Dan Wells [Tue, 18 Aug 2015 16:10:28 +0000 (12:10 -0400)]
LP#1479107 Fix IDL classname for account adjustments

This table went through two name changes, and left some debris along
the way.  Let's standardize on the default choice of 'maa' for the IDL
classname abbreviation.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoLP#1479107 Move VOID_BILLING perm check to top-level API
Dan Wells [Tue, 18 Aug 2015 14:42:27 +0000 (10:42 -0400)]
LP#1479107 Move VOID_BILLING perm check to top-level API

Pemission checks are needed at entry points, but can lead to
undesirable consequences if checked during automated processing.  In
the case of voids, let's move the perm check up to make sure our
automated processing can complete.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoLP#1217052 Include Inactive Users in Dupe Search
Jason Boyer [Mon, 16 Mar 2015 14:28:33 +0000 (10:28 -0400)]
LP#1217052 Include Inactive Users in Dupe Search

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP 1485794: Stamping web staff client sprint2 upgrade scripts.
Jason Stephenson [Wed, 19 Aug 2015 17:52:07 +0000 (13:52 -0400)]
LP 1485794: Stamping web staff client sprint2 upgrade scripts.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: add brief release notes for the 2.9 web staff cataloging integration
Galen Charlton [Mon, 17 Aug 2015 23:01:35 +0000 (23:01 +0000)]
webstaff: add brief release notes for the 2.9 web staff cataloging integration

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: more volume/copy editor work
Mike Rylander [Mon, 17 Aug 2015 21:23:35 +0000 (17:23 -0400)]
webstaff: more volume/copy editor work

* Connect the panes for adding/removing copies and volumes
* Teach the UI to load raw data when IDs are not provided

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Add the beginnings of copy attribute editing
Mike Rylander [Mon, 17 Aug 2015 20:14:58 +0000 (16:14 -0400)]
webstaff: Add the beginnings of copy attribute editing

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Teach the grid some new tricks
Mike Rylander [Mon, 17 Aug 2015 20:14:10 +0000 (16:14 -0400)]
webstaff: Teach the grid some new tricks

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Teach Holdings View how to open the Vol/Copy editor
Mike Rylander [Fri, 14 Aug 2015 21:14:12 +0000 (17:14 -0400)]
webstaff: Teach Holdings View how to open the Vol/Copy editor

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Vol/Copy edit (volumes ATM)
Mike Rylander [Fri, 14 Aug 2015 21:13:30 +0000 (17:13 -0400)]
webstaff: Vol/Copy edit (volumes ATM)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Teach holdings to re-render when paging through result lists
Mike Rylander [Thu, 30 Jul 2015 13:50:56 +0000 (09:50 -0400)]
webstaff: Teach holdings to re-render when paging through result lists

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Z39.50 - yet more improvements
Galen Charlton [Tue, 28 Jul 2015 15:04:16 +0000 (15:04 +0000)]
webstaff: Z39.50 - yet more improvements

* change binding of marc_xml
* implement edit-then-overlay
* add search-in-progress indicator
* implement display of total hit count
* implement remove fields on import

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: have egRecordHtml watch for changes to the MARC XML
Galen Charlton [Tue, 28 Jul 2015 15:06:36 +0000 (15:06 +0000)]
webstaff: have egRecordHtml watch for changes to the MARC XML

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: web staff: teach MARC editor how to work in-place
Galen Charlton [Tue, 28 Jul 2015 15:00:16 +0000 (15:00 +0000)]
webstaff: web staff: teach MARC editor how to work in-place

This patch adds an "in-place" mode to the MARC editor for
cases where client-side MARC munging is needed without
immediately saving the results to the database.

To use, include in-place-mode="true" in the eg-marc-edit-record
directive.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Z39.50 - more improvements
Galen Charlton [Thu, 23 Jul 2015 17:52:33 +0000 (17:52 +0000)]
webstaff: Z39.50 - more improvements

* add grid actions
* fix markup
* add view MARC action
* improve name of check for disabling actions that
  require at least one result to be selected
* display cover image on view MARC modal
* add Z39.50 raw search capability
* implement selecting local record for overlay
* implement record overlay with confirm

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: teach eg-record-html how to initialize itself from MARCXML
Galen Charlton [Mon, 27 Jul 2015 17:14:06 +0000 (17:14 +0000)]
webstaff: teach eg-record-html how to initialize itself from MARCXML

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: teach egGrid action menus how to conditionally disable items
Galen Charlton [Thu, 23 Jul 2015 17:49:36 +0000 (17:49 +0000)]
webstaff: teach egGrid action menus how to conditionally disable items

It is now possible to pass a function to specify if an action
menu item should be disabled:

  <eg-grid-action handler="do_stuff" disabled="cant_do_stuff"
    label="[% l('Do Stuff') %]"></eg-grid-action>

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Fixed-position navigation menu for web client
Kathy Lussier [Tue, 14 Jul 2015 16:26:24 +0000 (12:26 -0400)]
webstaff: Fixed-position navigation menu for web client

Changes the class for top-navbar so that it stays fixed at the top of the
screen. This is useful for staff who will need to quickly jump to another
area of the client after they have scrolled down a page.

Initially, changing the class shifted some of the content higher so that the
navbar was covering some elements. I addressed this by adding some padding to

Many thanks to Jason Etheridge for pointing me in the right direction to get
started.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Z39.50 - various improvements
Galen Charlton [Fri, 17 Jul 2015 18:56:10 +0000 (18:56 +0000)]
webstaff: Z39.50 - various improvements

* add widget to show/hide search form
* add more vertical space between search form and results table
* forgo a label on the results table
* make Z39.50 search results non-multiselect-able
* implement edit-then-import

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: force MARC editor context menus to have a high z-index
Galen Charlton [Fri, 17 Jul 2015 22:22:47 +0000 (22:22 +0000)]
webstaff: force MARC editor context menus to have a high z-index

Magic value of 2000 chosen to ensure that they appear
even when the MARC editor is embedded in a Bootstrap
modal.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: teach MARC editor how to initialize itself from a MARCXML blob
Galen Charlton [Fri, 17 Jul 2015 22:10:15 +0000 (22:10 +0000)]
webstaff: teach MARC editor how to initialize itself from a MARCXML blob

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: teach egGrid how to disable multiselect
Galen Charlton [Fri, 17 Jul 2015 19:22:36 +0000 (19:22 +0000)]
webstaff: teach egGrid how to disable multiselect

For grids where it makes sense to allow only one row to be
selected at a time, egGrid now supports a "-multiselect"
feature that:

  * disables generation of the checkbox column
  * disables control-/shift/command-click to multiselect

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: make Firefox happy in various ways
Mike Rylander [Fri, 17 Jul 2015 20:13:54 +0000 (16:13 -0400)]
webstaff: make Firefox happy in various ways

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Z39.50 search and import interface
Galen Charlton [Tue, 9 Jun 2015 22:10:18 +0000 (22:10 +0000)]
webstaff: Z39.50 search and import interface

- fetch configured Z39.50 targets
- can now select targets
- search field form now active
- can now retrieve results
- check for empty query correctly
- retain reference to target list
- preserve search query input when toggling Z39.50 target selection
- implement clear form handler
- allow enter key to submit search
- track index of Z39.50 results so that individual ones can be selected
- note results of experiences to make the title be conditionally a hyperlink
- implement show in catalog
- implement direct import
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoLP#1472787: add regression test
Galen Charlton [Wed, 8 Jul 2015 22:24:55 +0000 (22:24 +0000)]
LP#1472787: add regression test

This patch adds some unit tests for egGrid's egGridColumnsProvider,
including regression tests for LP#1472787.

To run these tests (and all others for the web staff client)
from with a Git checkout of Evergreen:

[1] cd Open-ILS/web/js/ui/default/staff
[2] grunt test

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoLP#1472787: fix expansion of wildcard eg-grid-field paths
Galen Charlton [Wed, 8 Jul 2015 21:35:43 +0000 (21:35 +0000)]
LP#1472787: fix expansion of wildcard eg-grid-field paths

This fixes a bug where expansion of wildcard egGridField
paths didn't handle a plain "*" correctly.

To test:

[1] In the web staff client, bring up the list of a patron's
    current loans.  Add the grace period column to the grid,
    but note that the loans' grace period values are not
    actually displayed.
[2] Apply the patch.
[3] Refresh the browser and repeat step 1.  This time, the
    grace period values are displayed.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Simplify logic of grouped items; Add mark missing/damaged; Add show item...
Mike Rylander [Wed, 24 Jun 2015 13:39:46 +0000 (09:39 -0400)]
webstaff: Simplify logic of grouped items; Add mark missing/damaged; Add show item holds

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Add actions for jumping to item status
Mike Rylander [Wed, 24 Jun 2015 13:18:47 +0000 (09:18 -0400)]
webstaff: Add actions for jumping to item status

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Add support for item list population from the URL
Mike Rylander [Wed, 24 Jun 2015 13:18:04 +0000 (09:18 -0400)]
webstaff: Add support for item list population from the URL

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Adjust how padding is applied
Mike Rylander [Mon, 22 Jun 2015 19:35:02 +0000 (15:35 -0400)]
webstaff: Adjust how padding is applied

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Column ordering improvement
Mike Rylander [Mon, 22 Jun 2015 19:21:35 +0000 (15:21 -0400)]
webstaff: Column ordering improvement

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Use function calls instead of watches; Collapse columns
Mike Rylander [Mon, 22 Jun 2015 19:14:29 +0000 (15:14 -0400)]
webstaff: Use function calls instead of watches; Collapse columns

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Attempt to provide defaults
Mike Rylander [Mon, 22 Jun 2015 17:26:55 +0000 (13:26 -0400)]
webstaff: Attempt to provide defaults

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Add checkboxes and logic for collapsing copy and vol detail
Mike Rylander [Mon, 22 Jun 2015 17:17:42 +0000 (13:17 -0400)]
webstaff: Add checkboxes and logic for collapsing copy and vol detail

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Teach grids how to provide checkboxes
Mike Rylander [Mon, 22 Jun 2015 17:16:19 +0000 (13:16 -0400)]
webstaff: Teach grids how to provide checkboxes

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Holdings View!
Mike Rylander [Mon, 22 Jun 2015 12:47:12 +0000 (08:47 -0400)]
webstaff: Holdings View!

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Add "align" support to grid cells
Mike Rylander [Mon, 22 Jun 2015 12:46:18 +0000 (08:46 -0400)]
webstaff: Add "align" support to grid cells

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Only make the iframe bigger, never smaller
Mike Rylander [Mon, 27 Apr 2015 16:18:40 +0000 (12:18 -0400)]
webstaff: Only make the iframe bigger, never smaller

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Move buttons to the top
Mike Rylander [Mon, 27 Apr 2015 14:47:19 +0000 (10:47 -0400)]
webstaff: Move buttons to the top

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Add height adjustment hacks for a couple dojo interfaces
Mike Rylander [Fri, 24 Apr 2015 20:27:31 +0000 (16:27 -0400)]
webstaff: Add height adjustment hacks for a couple dojo interfaces

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Double scrollbars are bad, this stops them where we can.
Mike Rylander [Thu, 23 Apr 2015 21:35:09 +0000 (17:35 -0400)]
webstaff: Double scrollbars are bad, this stops them where we can.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agowebstaff: Just build the path directly, we know our base
Mike Rylander [Thu, 23 Apr 2015 21:09:34 +0000 (17:09 -0400)]
webstaff: Just build the path directly, we know our base

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>