working/Evergreen.git
11 years agomisnamed dojo tab
erickson [Mon, 24 Aug 2009 21:52:06 +0000 (21:52 +0000)]
misnamed dojo tab

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13928 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoChange constraint on acq.provider. Instead of making code unique
scottmk [Mon, 24 Aug 2009 17:49:26 +0000 (17:49 +0000)]
Change constraint on acq.provider.  Instead of making code unique
by itself, make code + owner unique.

To change an existing table:

ALTER TABLE acq.provider
DROP CONSTRAINT provider_code_key;

ALTER TABLE acq.provider
ALTER COLUMN code SET NOT NULL;

ALTER TABLE acq.provider
ADD CONSTRAINT code_once_per_owner
UNIQUE (code, owner);

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13926 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAdd columns to acq.purchase_order: order_date and name.
scottmk [Mon, 24 Aug 2009 16:14:36 +0000 (16:14 +0000)]
Add columns to acq.purchase_order: order_date and name.

Name defaults to the id, as text.

Name should be unique for a given ordering_agency and order
date (truncated to midnight), but only where order_date
is not null.

To change an existing table, run the following
through psql:

-- Add new columns; populate name

ALTER TABLE acq.purchase_order
ADD COLUMN order_date TIMESTAMP WITH TIME ZONE;

ALTER TABLE acq.purchase_order
ADD COLUMN name TEXT;

UPDATE acq.purchase_order
SET name = id::TEXT;

ALTER TABLE acq.purchase_order
ALTER COLUMN name SET NOT NULL;

-- Name should default to the id.  We can't do that with a DEFAULT
-- clause but we can do it with a trigger.

CREATE OR REPLACE FUNCTION acq.purchase_order_name_default () RETURNS TRIGGER
AS $$
BEGIN
IF NEW.name IS NULL THEN
NEW.name := NEW.id::TEXT;
END IF;

RETURN NEW;
END;
$$ LANGUAGE PLPGSQL;

CREATE TRIGGER po_name_default_trg
  BEFORE INSERT OR UPDATE ON acq.purchase_order
  FOR EACH ROW EXECUTE PROCEDURE acq.purchase_order_name_default ();

-- Name should be unique for a given ordering_agency and day, where
-- order_date is not null.  We can't do that with a check constraint
-- because it would require a subquery, so we use a trigger.

CREATE INDEX acq_po_org_name_order_date_idx
ON acq.purchase_order( ordering_agency, name, order_date );

CREATE OR REPLACE FUNCTION acq.po_org_name_date_unique () RETURNS TRIGGER
AS $$
DECLARE
collision INT;
BEGIN
--
-- If order_date is not null, then make sure we don't have a collision
-- on order_date (truncated to day), org, and name
--
IF NEW.order_date IS NULL THEN
RETURN NEW;
END IF;
--
-- In the WHERE clause, we compare the order_dates without regard to time of day.
-- We use a pair of inequalities instead of comparing truncated dates so that the
-- query can do an indexed range scan.
--
SELECT 1 INTO collision
FROM acq.purchase_order
WHERE
ordering_agency = NEW.ordering_agency
AND name = NEW.name
AND order_date >= date_trunc( 'day', NEW.order_date )
AND order_date <  date_trunc( 'day', NEW.order_date ) + '1 day'::INTERVAL
AND id <> NEW.id;
--
IF collision IS NULL THEN
-- okay, no collision
RETURN NEW;
ELSE
-- collision; nip it in the bud
RAISE EXCEPTION 'Colliding purchase orders: ordering_agency %, date %, name ''%''',
NEW.ordering_agency, NEW.order_date, NEW.name;
END IF;
END;
$$ LANGUAGE PLPGSQL;

CREATE TRIGGER po_org_name_date_unique_trg
  BEFORE INSERT OR UPDATE ON acq.purchase_order
  FOR EACH ROW EXECUTE PROCEDURE acq.po_org_name_date_unique ();

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13924 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agofire the fine generator at checkin time to assess required fines without a "missing...
miker [Mon, 24 Aug 2009 15:23:49 +0000 (15:23 +0000)]
fire the fine generator at checkin time to assess required fines without a "missing fine" window

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13923 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadjusting indentation for readability
miker [Mon, 24 Aug 2009 14:38:46 +0000 (14:38 +0000)]
adjusting indentation for readability

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13921 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoin checkin interface, keep a running tally of fines/bills encountered
phasefx [Mon, 24 Aug 2009 03:04:23 +0000 (03:04 +0000)]
in checkin interface, keep a running tally of fines/bills encountered

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13920 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agotypo, reporter.reporter.
erickson [Fri, 21 Aug 2009 18:33:36 +0000 (18:33 +0000)]
typo,  reporter.reporter.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13915 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agomore work on pcrud filter dialog. added filter option to autogrid. repaired faulty...
erickson [Fri, 21 Aug 2009 15:33:02 +0000 (15:33 +0000)]
more work on pcrud filter dialog.  added filter option to autogrid.  repaired faulty linked object caching in autogrid.  with caching repaired, made linked grid cell data fetching synchronous to prevent excessive network requests (1st instance of an object is cached)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13913 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoChange uniqueness constraint on acq.fund.code so as to
scottmk [Fri, 21 Aug 2009 12:38:47 +0000 (12:38 +0000)]
Change uniqueness constraint on acq.fund.code so as to
include org and year

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13912 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agobeginnings of database replication helper scripts
miker [Fri, 21 Aug 2009 05:14:25 +0000 (05:14 +0000)]
beginnings of database replication helper scripts

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13911 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoset hold.shelf_time when item hits the shelf. updated hold notify event def to use...
erickson [Thu, 20 Aug 2009 20:49:11 +0000 (20:49 +0000)]
set hold.shelf_time when item hits the shelf.  updated hold notify event def to use shelf_time as the delay field

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13907 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAnother typo [sigh...]
scottmk [Thu, 20 Aug 2009 20:13:12 +0000 (20:13 +0000)]
Another typo [sigh...]

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13906 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoCorrecting a typo...
scottmk [Thu, 20 Aug 2009 19:08:19 +0000 (19:08 +0000)]
Correcting a typo...

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13905 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoNew column: action.hold_request.shelf_time
scottmk [Thu, 20 Aug 2009 19:04:18 +0000 (19:04 +0000)]
New column: action.hold_request.shelf_time

For altering an existing table:

ALTER TABLE action.hold_request
ADD COLUMN shelf_time TIMESTAMP WITH TIME ZONE;

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13904 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agobeginning of a filter dialog for pcrud requests. users select columns and values...
erickson [Thu, 20 Aug 2009 16:04:35 +0000 (16:04 +0000)]
beginning of a filter dialog for pcrud requests.  users select columns and values from autofieldwidgets.  the eventual goal is to provide filter options for autogrid

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13903 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agothinko in recent ingest fix
miker [Thu, 20 Aug 2009 15:34:25 +0000 (15:34 +0000)]
thinko in recent ingest fix

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13897 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agomoving the simple-rec synchronization out of the DB for insert/update, and as a new...
miker [Thu, 20 Aug 2009 15:00:46 +0000 (15:00 +0000)]
moving the simple-rec synchronization out of the DB for insert/update, and as a new trigger for "delete".  This should finally address the ingest issues seen at some sites through the 1.4 series

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13894 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoFix a horrible regression when renewing multiple items at once in Items Out.
phasefx [Thu, 20 Aug 2009 08:01:42 +0000 (08:01 +0000)]
Fix a horrible regression when renewing multiple items at once in Items Out.

Referencing loop variables in Javascript with closures is dangerous, so one strategy is to do something like this:

funcs = [];
for (var i = 0; i < my_array.length; i++ ) {

/* Bad */
// funcs.push( function(){ do_something( my_array[i] ); } );
/* Better */
funcs.push( function(safe_value){ return function(){ do_something( safe_value ); } }( my_array[i] ) );
}

In our case, our generated function accidentally referenced a value dependent on the loop variable instead of the corresponding argument of the function generator.

So we had multiple async renewal calls that depending on the timing, could try to renew the same item.  To further add insult to injury, this could potentially put the database in an inconsistent
state wtih duplicate circulations.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13889 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoif the requested hook does not exist, gracefully back out
erickson [Wed, 19 Aug 2009 15:58:51 +0000 (15:58 +0000)]
if the requested hook does not exist, gracefully back out

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13883 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadd lib shortname to overdue script xml output
erickson [Wed, 19 Aug 2009 14:10:52 +0000 (14:10 +0000)]
add lib shortname to overdue script xml output

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13879 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agouse the appropriate label for show hold details in the context menu for the patron...
phasefx [Wed, 19 Aug 2009 03:09:17 +0000 (03:09 +0000)]
use the appropriate label for show hold details in the context menu for the patron holds interface

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13874 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoHave the Place Hold function in the Patron Holds interface update said interface...
phasefx [Wed, 19 Aug 2009 03:07:41 +0000 (03:07 +0000)]
Have the Place Hold function in the Patron Holds interface update said interface upon successful hold placement.
Also, rework how the Patron Holds interface encourages the summary sidebar (and the label under the Holds button) to refresh itself with regard to holds.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13873 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agofield_type may be null, check it
erickson [Tue, 18 Aug 2009 18:57:12 +0000 (18:57 +0000)]
field_type may be null, check it

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13872 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoupdated hold queue position code to consider all hold types that share a common poten...
erickson [Tue, 18 Aug 2009 17:45:49 +0000 (17:45 +0000)]
updated hold queue position code to consider all hold types that share a common potential copy

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13871 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agodon't call ->content if there is no response
erickson [Tue, 18 Aug 2009 17:44:22 +0000 (17:44 +0000)]
don't call ->content if there is no response

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13868 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agomiscommunication on logic. if user != requestor, it's a staff hold
erickson [Tue, 18 Aug 2009 15:48:39 +0000 (15:48 +0000)]
miscommunication on logic.  if user != requestor, it's a staff hold

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13867 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAdded strings for staff hold column
lmcfarland [Tue, 18 Aug 2009 15:32:17 +0000 (15:32 +0000)]
Added strings for staff hold column

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13866 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAdded staff hold column to holds table
lmcfarland [Tue, 18 Aug 2009 14:41:05 +0000 (14:41 +0000)]
Added staff hold column to holds table

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13865 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoalternate (and functional) clipboard context menus for fixed fields
phasefx [Tue, 18 Aug 2009 06:08:27 +0000 (06:08 +0000)]
alternate (and functional) clipboard context menus for fixed fields

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13862 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agofixed regression with default search field not being refocused after using the Clear...
phasefx [Tue, 18 Aug 2009 05:32:37 +0000 (05:32 +0000)]
fixed regression with default search field not being refocused after using the Clear Form button.  Also have the default field come into focus when the whole tab leaves focus and is later revisited.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13857 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoturned on paging for po list. set up the state filter differently so that the browse...
erickson [Mon, 17 Aug 2009 20:09:47 +0000 (20:09 +0000)]
turned on paging for po list.  set up the state filter differently so that the browser won't choose a default value.  no longer showing and fleshing the owner column since it was causing the render flickering... will reassess later.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13854 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoset page title
erickson [Mon, 17 Aug 2009 20:08:27 +0000 (20:08 +0000)]
set page title

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13853 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoremoved dupe debs (wrt osrf Makefile.install)
sboyette [Mon, 17 Aug 2009 18:32:58 +0000 (18:32 +0000)]
removed dupe debs (wrt osrf Makefile.install)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13852 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agochanged menu label from Hold Notice to Hold Details--Hold Notices functionality is...
lmcfarland [Mon, 17 Aug 2009 17:14:01 +0000 (17:14 +0000)]
changed menu label from Hold Notice to Hold Details--Hold Notices functionality is now in the Hold Details UI

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13851 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadded hold_details to the URLS, removed hold_notices
lmcfarland [Mon, 17 Aug 2009 17:03:32 +0000 (17:03 +0000)]
added hold_details to the URLS, removed hold_notices

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13850 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agousing new fund year list to populate year selector
erickson [Mon, 17 Aug 2009 16:14:51 +0000 (16:14 +0000)]
using new fund year list to populate year selector

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13848 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadded optional list of fields whose linked display value should not be fetched
erickson [Mon, 17 Aug 2009 16:12:49 +0000 (16:12 +0000)]
added optional list of fields whose linked display value should not be fetched

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13847 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadded companion api call to fund list retrieval which returns unique set of fund...
erickson [Mon, 17 Aug 2009 16:12:06 +0000 (16:12 +0000)]
added companion api call to fund list retrieval which returns unique set of fund years based on the provided query

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13846 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadd "distinct" support to fielder
miker [Mon, 17 Aug 2009 14:30:01 +0000 (14:30 +0000)]
add "distinct" support to fielder

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13845 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadded support to autogrid for loading paged data via callback for UIs that load their...
erickson [Sun, 16 Aug 2009 15:49:12 +0000 (15:49 +0000)]
added support to autogrid for loading paged data via callback for UIs that load their own data.  added paging to fund list page.  added paging options to fund by org fetcher

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13843 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadding proper attributes to uncontrolled subfield value textboxes to allow the defaul...
miker [Fri, 14 Aug 2009 15:39:05 +0000 (15:39 +0000)]
adding proper attributes to uncontrolled subfield value textboxes to allow the default-ish context menus to work properly

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13842 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agocode clean up--removed some leftover testing strings
lmcfarland [Fri, 14 Aug 2009 15:12:44 +0000 (15:12 +0000)]
code clean up--removed some leftover testing strings

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13841 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoshow hold notices menu is now a hold details interface, soon to encompass all hold...
lmcfarland [Fri, 14 Aug 2009 15:06:26 +0000 (15:06 +0000)]
show hold notices menu is now a hold details interface, soon to encompass all hold actions and details--added hold note functionality to this new/refactored UI

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13840 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoswapped commandset from holds.xul to holds_overlay.xul and the commandset call from...
lmcfarland [Fri, 14 Aug 2009 14:49:24 +0000 (14:49 +0000)]
swapped commandset from holds.xul to holds_overlay.xul and the commandset call from holds_overlay.xul to holds.xul

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13839 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agocreated new column in Holds interface for number of hold notes per hold
lmcfarland [Fri, 14 Aug 2009 14:16:30 +0000 (14:16 +0000)]
created new column in Holds interface for number of hold notes per hold

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13838 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoaccess circulation tables directly instead of through the all_circulation view to...
miker [Fri, 14 Aug 2009 03:11:51 +0000 (03:11 +0000)]
access circulation tables directly instead of through the all_circulation view to avoid pathological query plans

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13837 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agofixed some bugs in creating new picklists by name
erickson [Thu, 13 Aug 2009 21:09:25 +0000 (21:09 +0000)]
fixed some bugs in creating new picklists by name

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13834 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoturn on pagination in the provider list page
erickson [Thu, 13 Aug 2009 21:08:55 +0000 (21:08 +0000)]
turn on pagination in the provider list page

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13833 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoinitial pagination support. when enabled, back/prev links appear in a small nav...
erickson [Thu, 13 Aug 2009 21:08:22 +0000 (21:08 +0000)]
initial pagination support.  when enabled, back/prev links appear in a small nav pane just above the grid

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13832 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadded support for limit/offset to pcrud search and retrieveall calls
erickson [Thu, 13 Aug 2009 21:07:02 +0000 (21:07 +0000)]
added support for limit/offset to pcrud search and retrieveall calls

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13831 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoremoving old provider list code
erickson [Thu, 13 Aug 2009 21:06:33 +0000 (21:06 +0000)]
removing old provider list code

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13830 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoaaaaand the osrf perl preqs
sboyette [Thu, 13 Aug 2009 18:30:59 +0000 (18:30 +0000)]
aaaaand the osrf perl preqs

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13829 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agono apxs; no memcache, ncurses, or readline headers either
sboyette [Thu, 13 Aug 2009 18:09:54 +0000 (18:09 +0000)]
no apxs; no memcache, ncurses, or readline headers either

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13828 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoalso won't find apache2.2-common or liblog-log4perl-perl in a base install of debian
sboyette [Thu, 13 Aug 2009 17:39:16 +0000 (17:39 +0000)]
also won't find apache2.2-common or liblog-log4perl-perl in a base install of debian

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13827 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadding XML::Simple and XML::LibXML to debs list
sboyette [Thu, 13 Aug 2009 17:39:16 +0000 (17:39 +0000)]
adding XML::Simple and XML::LibXML to debs list

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13826 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agonevermind that last change
sboyette [Thu, 13 Aug 2009 17:39:15 +0000 (17:39 +0000)]
nevermind that last change

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13825 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadd Module::Install to the Debian/Ubuntu, Centos, and Gentoo installs
sboyette [Thu, 13 Aug 2009 17:39:14 +0000 (17:39 +0000)]
add Module::Install to the Debian/Ubuntu, Centos, and Gentoo installs

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13824 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agowhen a new hold is placed, tell the containing staff client about it
erickson [Thu, 13 Aug 2009 16:42:06 +0000 (16:42 +0000)]
when a new hold is placed, tell the containing staff client about it

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13823 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agocreate-hold call now only accepts a single hold arg. that's how it was being used...
erickson [Thu, 13 Aug 2009 16:37:45 +0000 (16:37 +0000)]
create-hold call now only accepts a single hold arg.  that's how it was being used and it makes the most since considering the return events are not hold-specific.  now, return the new hold ID on successful creation.  also tweaked potential copies count to use json_query count transform

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13822 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAdd support for UNION, INTERSECT, and EXCEPT.
scottmk [Thu, 13 Aug 2009 13:02:54 +0000 (13:02 +0000)]
Add support for UNION, INTERSECT, and EXCEPT.
(ORDER BY is accepted syntactically but not otherwise
supported yet.)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13821 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadded ability to auto-override configured checkout/renewal events at selfcheck. ...
erickson [Wed, 12 Aug 2009 17:18:50 +0000 (17:18 +0000)]
added ability to auto-override configured checkout/renewal events at selfcheck.  also, pull in JS files directly so we're not unnecessarily running opac-only code

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13817 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadded org setting type for setting overridable selfcheck events
erickson [Wed, 12 Aug 2009 17:14:23 +0000 (17:14 +0000)]
added org setting type for setting overridable selfcheck events

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13816 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoFor create and update methods: accept boolean column values
scottmk [Wed, 12 Aug 2009 15:19:49 +0000 (15:19 +0000)]
For create and update methods: accept boolean column values
as JSON_BOOLs instead of requiring them to be encoded as
"t" or "f" strings.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13815 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoUndo previous change. NULL can be a legitimate value for value.
scottmk [Tue, 11 Aug 2009 21:01:41 +0000 (21:01 +0000)]
Undo previous change.  NULL can be a legitimate value for value.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13814 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoIn doCreate(): check for a NULL pointer as a field value, and
scottmk [Tue, 11 Aug 2009 18:49:43 +0000 (18:49 +0000)]
In doCreate(): check for a NULL pointer as a field value, and
report it by class and field name.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13813 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoselected columns in a json_query need to be in an array
erickson [Tue, 11 Aug 2009 16:38:44 +0000 (16:38 +0000)]
selected columns in a json_query need to be in an array

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13812 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoUpdate code to check for all three caption & holdings fields, add
djfiander [Tue, 11 Aug 2009 16:20:38 +0000 (16:20 +0000)]
Update code to check for all three caption & holdings fields, add
basic test for supplementary material and indexes.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13809 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoDeal with a publication that only has a single level of
djfiander [Tue, 11 Aug 2009 16:10:14 +0000 (16:10 +0000)]
Deal with a publication that only has a single level of
enumeration (ie, only volume numbers).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13808 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoSegfaulting for json_queries selecting from functions, due to a
scottmk [Tue, 11 Aug 2009 13:47:32 +0000 (13:47 +0000)]
Segfaulting for json_queries selecting from functions, due to a
failure to handle the SELECT list properly.  Fixed.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13807 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoWhen defining a SELECT list for a given class: an empty
scottmk [Mon, 10 Aug 2009 16:14:58 +0000 (16:14 +0000)]
When defining a SELECT list for a given class: an empty
array no longer results in a default SELECT list.  You get a
warning message (but not an error) and no fields from that
class.  For a default SELECT list, use "*" or null.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13804 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoPatch from Galen Charlton to add Version to application.ini
erickson [Sun, 9 Aug 2009 14:35:19 +0000 (14:35 +0000)]
Patch from Galen Charlton to add Version to application.ini

==
The attached patch restores the Version key to the staff client's application.ini.  This key is now required; without it, xulrunner-bin --install-app on OS X will silently crash, leading to an incomplete and non-functional installation of the client on that platform.

Note that when the client is built, the value of Version is replaced by the build ID.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13803 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoFor building a SELECT list for a class: instead of traversing the
scottmk [Fri, 7 Aug 2009 04:23:00 +0000 (04:23 +0000)]
For building a SELECT list for a class: instead of traversing the
JSON_ARRAY with a jsonIterator, traverse it more efficiently
with a subscript.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13800 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoTightened the rules for defining SELECT clauses for a JSON query.
scottmk [Thu, 6 Aug 2009 22:06:19 +0000 (22:06 +0000)]
Tightened the rules for defining SELECT clauses for a JSON query.

With two exceptions as noted below, the SELECT list for every class
must be encoded as an array.  Anything else is an error.

The exceptions: null and "*".  For the core class only, these
encodings request a default SELECT list.

For the core class: an empty array requests a default SELECT list.

For a non-core class: an empty array results in an error message,
but not an error.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13799 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoIn oils_cstore.c, function searchWHERE(): rewrote a loop to use an
scottmk [Wed, 5 Aug 2009 18:58:20 +0000 (18:58 +0000)]
In oils_cstore.c, function searchWHERE(): rewrote a loop to use an
index instead of a jsonIterator, to traverse a jsonObject that is
known to be a JSON_ARRAY.  This change avoids the malloc and
free required to create and destroy a jsonIterator.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13798 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAdded a const qualifier. This change is in preparation for a
scottmk [Wed, 5 Aug 2009 12:42:12 +0000 (12:42 +0000)]
Added a const qualifier.  This change is in preparation for a
tweak to the JSON machinery.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13797 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoPerformance tweak to oils_cstore.c.
scottmk [Tue, 4 Aug 2009 19:44:02 +0000 (19:44 +0000)]
Performance tweak to oils_cstore.c.

Rewrote two loops in buildSELECT() and doUpdate() so use
osrfHashIterators instead of building and traversing
osrfString Arrays.

In the latter case: plugged a memory leak (we weren't freeing the
osrfStringArray).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13796 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agorestore raw z39.50 PQN search feature
phasefx [Mon, 3 Aug 2009 20:48:33 +0000 (20:48 +0000)]
restore raw z39.50 PQN search feature

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13791 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoPerformance tweak in oils_cstore.c: Recoded two loops to use
scottmk [Mon, 3 Aug 2009 16:47:01 +0000 (16:47 +0000)]
Performance tweak in oils_cstore.c: Recoded two loops to use
osrfHashIterators, instead of creating osrfStringArrays and
traversing them.

This change also plugs a memory leak (we weren't freeing one of
the osrfStringArrays).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13790 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoIn the initialization routines of oils_cstore.c: recoded a couple
scottmk [Mon, 3 Aug 2009 03:02:48 +0000 (03:02 +0000)]
In the initialization routines of oils_cstore.c: recoded a couple
of loops to use an osrfHashIterator, instead of creating an
osrfStringArray of keys and then traversing that.  This change
eliminates over 500 mallocs and frees.  In addition, traversing
the osrfHash with an iterator just hops along a linked list,
which is almost certainly faster than calculating a hash total
for every key.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13789 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoProperly implement generating issue numbers based on an 'e'
djfiander [Sun, 2 Aug 2009 14:14:04 +0000 (14:14 +0000)]
Properly implement generating issue numbers based on an 'e'
publication pattern.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13788 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoIn oils_cstore.c: accept "is distinct from" and "is not distinct from"
scottmk [Fri, 31 Jul 2009 12:21:49 +0000 (12:21 +0000)]
In oils_cstore.c: accept "is distinct from" and "is not distinct from"
as comparison operators.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13787 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoWhen a JSON query refers to a column qualified by a table alias using
scottmk [Fri, 31 Jul 2009 02:58:23 +0000 (02:58 +0000)]
When a JSON query refers to a column qualified by a table alias using
the plus-class trick (e.g. "+aou":"opac_visible"): verify that the
column belongs to the indicated class.  If it doesn't, return an error.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13786 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoTightened validation a bit in oils_cstore.c:
scottmk [Fri, 31 Jul 2009 02:26:33 +0000 (02:26 +0000)]
Tightened validation a bit in oils_cstore.c:

1. Issue a warning if the SELECT list is empty for a given table alias
(other than the core class).  This happens when we try to do the
equivalent of SELECT * for a non-core class.

2. Return an error if the generated SELECT list is empty.  This can happen
in a case like the following:

{
     "select":{ "aout":null },
        "from":{ "aou":"aout" }
}

...because there is nothing from the core class, and we don't build default
SELECT lists for non-core classes.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13785 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAdd test case for funky publication pattern that specifies the
djfiander [Fri, 31 Jul 2009 01:20:34 +0000 (01:20 +0000)]
Add test case for funky publication pattern that specifies the
enumeration used. Right now this new test fails.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13784 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agodon't fulfill hold when patron checks out a like copy if the hold in question has...
erickson [Thu, 30 Jul 2009 21:36:45 +0000 (21:36 +0000)]
don't fulfill hold when patron checks out a like copy if the hold in question has a copy on the holds shelf.  Use the power of cstore to find appropriate holds

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13783 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agodon't consider invalide addrs with negative IDs, since those are replaced addrs
erickson [Thu, 30 Jul 2009 13:11:07 +0000 (13:11 +0000)]
don't consider invalide addrs with negative IDs, since those are replaced addrs

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13782 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoextra verbiage for patron account OBLITERATION
phasefx [Thu, 30 Jul 2009 12:55:29 +0000 (12:55 +0000)]
extra verbiage for patron account OBLITERATION

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13781 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agooverzealous text replacement
phasefx [Wed, 29 Jul 2009 22:23:08 +0000 (22:23 +0000)]
overzealous text replacement

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13780 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoUI for patron deletion
phasefx [Wed, 29 Jul 2009 22:18:31 +0000 (22:18 +0000)]
UI for patron deletion

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13779 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agohave yns_alert_original call itself if need be
phasefx [Wed, 29 Jul 2009 22:18:00 +0000 (22:18 +0000)]
have yns_alert_original call itself if need be

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13778 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoaction to archive selected penalties. Progressmeter isn't working like I'd expect...
phasefx [Wed, 29 Jul 2009 12:23:07 +0000 (12:23 +0000)]
action to archive selected penalties.  Progressmeter isn't working like I'd expect, though

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13777 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoInterface for archived penalties. I frikkin love streaming results. Pulled down...
phasefx [Wed, 29 Jul 2009 11:48:18 +0000 (11:48 +0000)]
Interface for archived penalties.  I frikkin love streaming results.  Pulled down and rendered 80 archived penalties in 3 seconds on a vmware image.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13776 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoThis works either way. list.append( row_params ) will return a modified row_params...
phasefx [Wed, 29 Jul 2009 09:31:15 +0000 (09:31 +0000)]
This works either way.  list.append( row_params ) will return a modified row_params, but row_params is modified by reference in any case

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13775 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agodon't pre-check the Note radiobutton when editing
phasefx [Wed, 29 Jul 2009 09:11:58 +0000 (09:11 +0000)]
don't pre-check the Note radiobutton when editing

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13774 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agofor now, disable refresh of entire patron interface after penalty manipulation. ...
phasefx [Wed, 29 Jul 2009 09:09:19 +0000 (09:09 +0000)]
for now, disable refresh of entire patron interface after penalty manipulation.  What we're really avoiding is the stop-sign page.  Want to revamp how the patron interface works here to make use of observers.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13773 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agocolumn tweaks for standing penalties in lists
phasefx [Wed, 29 Jul 2009 09:05:03 +0000 (09:05 +0000)]
column tweaks for standing penalties in lists

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13772 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agouse the right data on single row refresh
phasefx [Wed, 29 Jul 2009 09:04:45 +0000 (09:04 +0000)]
use the right data on single row refresh

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13771 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agopopulate note textbox with existing note on edit
phasefx [Wed, 29 Jul 2009 08:21:46 +0000 (08:21 +0000)]
populate note textbox with existing note on edit

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13770 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agohide field for initials entry by default
phasefx [Wed, 29 Jul 2009 08:17:18 +0000 (08:17 +0000)]
hide field for initials entry by default

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13769 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoStaff initials for standing penalties. Looks for org setting ui.circ.standing_penalt...
phasefx [Wed, 29 Jul 2009 08:15:50 +0000 (08:15 +0000)]
Staff initials for standing penalties.  Looks for org setting ui.circ.standing_penalty.require_initials to enable this feature.

The Apply/Modify button will jump to the initials textbox if empty.

No dedicated initials field in actor.user_standing_penalty, so appending to the note field.  Not parsing notes for initials when editing, though we may want to (I'd argue for a dedicated field in
this case).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13768 dcc99617-32d9-48b4-a31d-7c20da2025e4