working/Evergreen.git
7 years agoTPAC - gray out hold submit button
Ben Shum [Wed, 13 Feb 2013 15:27:09 +0000 (10:27 -0500)]
TPAC - gray out hold submit button

When disabled, recolor to gray to indicate that it is disabled.

This will turn back to normal once a valid user is found.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
7 years agoTPac: Disable staff hold place submit button by default
Thomas Berezansky [Wed, 13 Feb 2013 14:49:49 +0000 (09:49 -0500)]
TPac: Disable staff hold place submit button by default

Because if we don't have a barcode in the box we shouldn't be submitting.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
7 years agoTPac: Invalidate 'current' barcode on invalid
Thomas Berezansky [Wed, 13 Feb 2013 14:06:07 +0000 (09:06 -0500)]
TPac: Invalidate 'current' barcode on invalid

Hold placement should allow you to go back to the previous valid barcode.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
7 years agoTPac: Load name from patron place hold interface
Thomas Berezansky [Tue, 12 Feb 2013 14:47:30 +0000 (09:47 -0500)]
TPac: Load name from patron place hold interface

only_settings is applied from there, so check if a barcode was entered.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
7 years agoTPac: Load patron name when placing holds
Thomas Berezansky [Tue, 12 Feb 2013 14:10:29 +0000 (09:10 -0500)]
TPac: Load patron name when placing holds

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
7 years agoForceExternal: Compare hostnames case insensitive
Thomas Berezansky [Wed, 6 Feb 2013 21:01:49 +0000 (16:01 -0500)]
ForceExternal: Compare hostnames case insensitive

Lowercase both sides to avoid "right host, wrong case" issues.

Resolves LP1081699 where the external browser would be used due to
hostname case sensitivity.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoAdd release note for clickable patron indicators
Ben Shum [Fri, 8 Feb 2013 22:30:52 +0000 (17:30 -0500)]
Add release note for clickable patron indicators

Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoRemove See Messages from the invalid email and phone labels
Kathy Lussier [Fri, 8 Feb 2013 21:41:43 +0000 (16:41 -0500)]
Remove See Messages from the invalid email and phone labels

The "See Messages" part of the label might be misleading since clicking these
indicators opens the patron edit screen. Since replacing the email or
phone number automatically removes these messages, there is no need to
direct the user to the messages screen.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoStop highlighting indicators
Thomas Berezansky [Thu, 11 Oct 2012 17:34:32 +0000 (13:34 -0400)]
Stop highlighting indicators

The way that commands were highlighted when selected, highlighted
both the indicators and the buttons. Change to only hightlight
the tabbed buttons.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoMake patron indicators clickable
Thomas Berezansky [Wed, 3 Oct 2012 19:27:54 +0000 (15:27 -0400)]
Make patron indicators clickable

For example, make "(See Notes)" bring you to notes, provided the patron is
already loaded (aka, not from search).

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoTPAC: Make locale picker match default locale
Dan Scott [Mon, 21 Jan 2013 22:02:42 +0000 (17:02 -0500)]
TPAC: Make locale picker match default locale

As noted by Pasi Kallinen, the language picker would not reflect the
chosen locale unless your cookie had been set or there was an explicit
CGI parameter with the locale name.

Accordingly, get the default locale from the context vars and use that
to set the selected value for the language picker in the absence of
anything else, to prevent the picker from possibly confusingly showing
the first language alphabetically rather than the currently displayed
language in the rest of the UI.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP #1092921: Display of/sorting by CN affixes in Simplified Hold Pull List
Lebbeous Fogle-Weekley [Wed, 2 Jan 2013 17:33:36 +0000 (12:33 -0500)]
LP #1092921: Display of/sorting by CN affixes in Simplified Hold Pull List

In the Simplified Hold Pull List interface, the "Call Number Label" column
displays the call number of the copy targeted by the hold in each row,
and it does so by combining affixes with the actual label field.
Sorting of this column actually uses the call number sortkey generated
in-database for this purpose.

Sometimes this means that sorting order doesn't match what you'd
expect to see with this column.  Opinions differ on desired behavior, so
now you can explicity add columns to the table for call number prefix
and suffix, and sort on either of those (potentially in combination with
other columns).

Amended from an earlier version of this commit that still didn't sort
CN prefix and suffix columns quite right.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP#1067361: vandelay: batch queue deletion no longer works
Mark Cooper [Tue, 16 Oct 2012 18:02:23 +0000 (11:02 -0700)]
LP#1067361: vandelay: batch queue deletion no longer works

Because window.location.reload can trigger before the deletions
have occurred. Simple fix (band aid?) is to make the delete
calls in sync.

Signed-off-by: Mark Cooper <markchristophercooper@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP1054053 - Remove white padding around login inputs
Ben Shum [Tue, 29 Jan 2013 05:27:55 +0000 (00:27 -0500)]
LP1054053 - Remove white padding around login inputs

Forget efforts to make the boxes bigger and smoother as it was in the past.
Instead, opting for a cleaner look by removing the extra white background
that was part of the padding surrounding the actual login input area. This
removes the feeling that the box area should have been bigger than it really
is.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
7 years agoReplace "Mirror Mirror" default non-AC jacket cover
Michael Peters [Tue, 27 Nov 2012 14:05:35 +0000 (09:05 -0500)]
Replace "Mirror Mirror" default non-AC jacket cover

Every item in KPAC that doesn't have a jacket cover uses
the cover for "Mirror Mirror".  This is inappropriate, so
lets replace it with a small blank image.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP1053526 - Don't inadvertently modify the in-memory org tree when printing
Jason Etheridge [Thu, 20 Sep 2012 17:10:15 +0000 (13:10 -0400)]
LP1053526 - Don't inadvertently modify the in-memory org tree when printing

To see an example of this causing a problem, load Holdings Maintenance for
an arbitrary bib record with items. Make sure the Hide Empty Libs checkbox
is checked. Hit the Print button at the bottom of the UI (it's okay to then
Cancel the print). Then hit Refresh. It should result in an org.children()
is null error.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP1075586 - Remove top bar in staff client
Thomas Berezansky [Mon, 5 Nov 2012 13:48:46 +0000 (08:48 -0500)]
LP1075586 - Remove top bar in staff client

Chances are it is rigged for patron, not staff, use.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP #1100914: Input focus for staff client portal should be the text box.
Dan Pearl [Thu, 17 Jan 2013 19:56:18 +0000 (14:56 -0500)]
LP #1100914: Input focus for staff client portal should be the text box.

Suggested by a librarian:
Save a click by putting the initial focus of the Portal page in the search box.
Previously, entering the text box would eliminate the decorative background image;
now, pressing on any key while focus in the box will eliminate the text.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoCopy_offset and copy_limit shouldn't persist in URL
Kathy Lussier [Thu, 31 Jan 2013 15:51:40 +0000 (10:51 -0500)]
Copy_offset and copy_limit shouldn't persist in URL

Added copy_offset and copy_limit to stop_parms definition so that they
don't persist in URL when returning to search results or launching
subject/series searches.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoTPAC - Add parse_datetime to expire_date
Ben Shum [Fri, 25 Jan 2013 14:37:29 +0000 (09:37 -0500)]
TPAC - Add parse_datetime to expire_date

As reported by paxed in IRC, sometimes the function for expire_date has
troubles and you get an apache internal server error page and log errors
like:

egweb: template error: date error - bad time/date string:
expects 'h:m:s d:m:y'  got: '2015-01-31T00:00:00+0200'

Adding the ctx.parse_datetime() function to wrap the ctx.user.expire_date
resolves this problem.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
7 years agoSerials: Caption/pattern wizard use enum fields for chronology when no enum
Lebbeous Fogle-Weekley [Mon, 21 Jan 2013 19:54:55 +0000 (14:54 -0500)]
Serials: Caption/pattern wizard use enum fields for chronology when no enum

MFHD spec says that when there are no ‡a - ‡f enumeration captions, any
chronology captions should move back from their usual ‡i - ‡m places
back into enumeration space.

The predictions engine we already have deals with this better than with
the wrong patterns we were creating before, e.g.:

853 20 ‡81 ‡i(year) ‡j(month) ‡wm

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoDeal with opt-in boundaries defensively
Dan Scott [Fri, 17 Aug 2012 20:07:19 +0000 (16:07 -0400)]
Deal with opt-in boundaries defensively

If a site had not set an 'org.patron_opt_default' OU setting, then it
seemed that a DEFAULT value was getting dumped into the "create opt-in"
INSERT statement for the org_unit argument, and that (as there is a
non-NULL constraint on the column and no default value for the column)
resulted in the patron not getting opted in.

One way for sites to deal with this is to set an opt-in boundary at the
consortial level, along the lines of:

INSERT INTO actor.org_unit_setting (org_unit, name, value)
  VALUES (1, 'org.patron_opt_default', 2);

Alternatively, in the absense of any such setting, opt-in should
continue to work as it had before the new feature was added; this change
keeps the old behaviour active in that case.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP1051112 - Display lineitem commands menu on empty picklists
Bill Erickson [Mon, 5 Nov 2012 14:22:55 +0000 (09:22 -0500)]
LP1051112 - Display lineitem commands menu on empty picklists

Ensure that the lineitem commands drop-down menu appears even when the
picklist is empty.  Previously, the commands were not displayed until
the first lineitem was retrieved.  For empty picklists, of course, there
will be no first lineitem.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP1066158 - Add associated permissions to admin menu commands
Ben Shum [Thu, 11 Oct 2012 04:10:54 +0000 (00:10 -0400)]
LP1066158 - Add associated permissions to admin menu commands

For the admin menu, we had already begun to check for specific permissions
to allow staff to access the menu options.  However, it is not complete.

This is a first attempt to add additional permissions to various local
and server admin options.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Mark Cooper <markchristophercooper@gmail.com>
7 years agoLP#1102472: add about:about to staff client developer menu
Galen Charlton [Mon, 21 Jan 2013 16:38:49 +0000 (11:38 -0500)]
LP#1102472: add about:about to staff client developer menu

The about:about page contains many XULRunner diagnostic tools.

Some useful ones include:

about:buildconfig - Get information about how the staff client is built.
about:config - Tweak XULRunner settings.
about:memory - Get detailed information about staff client memory usage.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoMerge remote-tracking branch 'origin/master' into acq-invoice-doc
Kathy Lussier [Sat, 26 Jan 2013 03:36:53 +0000 (22:36 -0500)]
Merge remote-tracking branch 'origin/master' into acq-invoice-doc

7 years agoDocumentation: acquisitions updates user/kmlussier/acq-invoice-doc
Kathy Lussier [Sat, 26 Jan 2013 02:35:13 +0000 (21:35 -0500)]
Documentation: acquisitions updates

Update Search for Line Items from an Invoice section to reflect minor
changes that came with lp1050008. Also, moved received Items from an
Invoice section to fall within the rest of the Invoices section.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoDocumentation: Update staff client installation for 2.3.3 version.
Robert Soulliere [Tue, 22 Jan 2013 14:36:08 +0000 (09:36 -0500)]
Documentation: Update staff client installation for 2.3.3 version.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
7 years agoDocumentation: Update upgrading the server instructions to point to 2.3.3.
Robert Soulliere [Tue, 22 Jan 2013 14:17:26 +0000 (09:17 -0500)]
Documentation: Update upgrading the server instructions to point to 2.3.3.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
7 years agoTPAC - new CSS for login help elements
Ben Shum [Sun, 20 Jan 2013 06:16:13 +0000 (01:16 -0500)]
TPAC - new CSS for login help elements

Instead of having everything hard coded into the page, move important
pieces into the style.css.tt2.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dan@coffeecode.net>
7 years agoTPAC - Remove images from login help page
Thomas Berezansky [Fri, 21 Dec 2012 21:10:09 +0000 (16:10 -0500)]
TPAC - Remove images from login help page

Because images are hard to translate.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dan@coffeecode.net>
7 years agoLP1054053 - make default input font darker
Ben Shum [Fri, 21 Dec 2012 20:47:40 +0000 (15:47 -0500)]
LP1054053 - make default input font darker

The original light grey made it difficult to see what was being input.
Change to use text font color variable (black by default).

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dan@coffeecode.net>
7 years agoTPAC: Fix series display for multiple series fields
Dan Scott [Sat, 19 Jan 2013 19:28:06 +0000 (14:28 -0500)]
TPAC: Fix series display for multiple series fields

This commit adds one test record, "Harry Potter and the Goblet of Fire",
which contains multiple series fields. TPAC would display the series
fields in a purely additive fashion as the variable was not reset after
each field. Now we initialize the series var for each new series field
we retrieve, fixing the display problem.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoUnbold graphic 880 title display
Ben Shum [Thu, 10 Jan 2013 22:01:05 +0000 (17:01 -0500)]
Unbold graphic 880 title display

To maintain consistency with the main title being unbolded and have
a little less bolding distraction in the record.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoAdded 880 series display to Release Notes.
Kathy Lussier [Thu, 10 Jan 2013 21:55:01 +0000 (16:55 -0500)]
Added 880 series display to Release Notes.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoMake series in record details behave
Dan Scott [Mon, 7 Jan 2013 23:16:57 +0000 (18:16 -0500)]
Make series in record details behave

Add graphic 880 field support, as well as relying on mkurl() macro to
generate the desired URL and show the complete series on a single line
instead of having subfields appear on separate rows.

Add a sample record that contains a 440 series field linked to an 880
field.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoAdd test records for graphic 880 field display
Dan Scott [Sun, 6 Jan 2013 01:49:27 +0000 (20:49 -0500)]
Add test records for graphic 880 field display

"--load-all" in eg_db_config.pl will load these records with call
numbers of "G880 ", so you can shelf-browse, or search by title:

* Tu shuo Zhongguo jie
* Matsumoto Shigeharu
* Schrödinger operators
* Breathing, feeding, and neuroprotection
* Data warehousing and knowledge discovery

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoRelease notes for alternate graphic 880 fields
Dan Scott [Sat, 5 Jan 2013 04:55:13 +0000 (23:55 -0500)]
Release notes for alternate graphic 880 fields

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoTPAC: Alternate graphic fields (880) display
Dan Scott [Fri, 4 Jan 2013 21:26:30 +0000 (16:26 -0500)]
TPAC: Alternate graphic fields (880) display

In the search results and record details displays, display the
corresponding 880 field(s) whenever possible.

The contents of the 880 field are generally displayed directly
underneath the corresponding primary field, with the exception of the
contributor credits on the record details page, in which the 880
contents appear between the name of the contributor and the
contributor's credit.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoUpdate staff client's about page to include newest core committers
Ben Shum [Mon, 3 Dec 2012 15:37:43 +0000 (10:37 -0500)]
Update staff client's about page to include newest core committers

The newest core committers were elected during the Evergreen Hack-A-Way on
October 10, 2012:

Jeff Godin, Traverse Area District Library
Benjamin Shum, Bibliomation, Inc.
Jason Stephenson, Merrimack Valley Library Consortium

Also update language of page to reflect that these contributors are now core
"committers" rather than "developers".  And move past core committers into
their own section.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoAdd 2.2.4 -> 2.2.5 upgrade script
Lebbeous Fogle-Weekley [Wed, 16 Jan 2013 20:18:56 +0000 (15:18 -0500)]
Add 2.2.4 -> 2.2.5 upgrade script

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoForward-porting 2.3.2 -> 2.3.3 DB upgrade
Bill Erickson [Wed, 16 Jan 2013 20:18:57 +0000 (15:18 -0500)]
Forward-porting 2.3.2 -> 2.3.3 DB upgrade

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoLP#1098377: protect against even more cstore segfaults
Galen Charlton [Tue, 15 Jan 2013 16:30:41 +0000 (11:30 -0500)]
LP#1098377: protect against even more cstore segfaults

Following up on the preceding patch, passing null
as the savepoint name to savepoint.release and
savepoint.rollback would also segfault cstore.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoVerify savepoint name is non-null
Bill Erickson [Tue, 15 Jan 2013 15:58:16 +0000 (10:58 -0500)]
Verify savepoint name is non-null

Before we attempt to mangle the name, let's ensure that it's non-null.
Otherwise, segfaults ensue.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
7 years agoProtect against overly long savepoint names
Dan Scott [Fri, 11 Jan 2013 06:32:13 +0000 (01:32 -0500)]
Protect against overly long savepoint names

Per http://postgresql.org/docs/9.1/static/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS,
the maximum identifier length works out to being 63 bytes (+1 for the
null terminator), so to avoid potential memory pressure by a 10GB string
somehow being passed in as the savepoint name, malloc no more than 64
bytes and copy no more than 63 bytes from the incoming name to the
escaped name.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
7 years agoLP#1098377: sanitize savepoint names
Galen Charlton [Fri, 11 Jan 2013 07:30:50 +0000 (02:30 -0500)]
LP#1098377: sanitize savepoint names

When invoking open-ils.{cstore,pcrud,rstore}.savepoint.*, the
caller supplies a name for the savepoint.  However, the savepoint
names could be constructed so that the caller could execute
arbitrary SQL.  This patch sanitizes the name so that it contains
only alphanumeric and underscore characters.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years ago2.3.3 translations : repair Finnish translator email
Bill Erickson [Wed, 16 Jan 2013 16:04:23 +0000 (11:04 -0500)]
2.3.3 translations : repair Finnish translator email

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years ago2.3.3 translations : newpot
Bill Erickson [Wed, 16 Jan 2013 15:39:31 +0000 (10:39 -0500)]
2.3.3 translations : newpot

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years ago2.3.3 translations : update profiles
Bill Erickson [Wed, 16 Jan 2013 15:35:33 +0000 (10:35 -0500)]
2.3.3 translations : update profiles

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoMinor fix in Open-ILS/src/templates/opac/parts/place_hold_result.tt2
Jason Stephenson [Mon, 10 Dec 2012 20:27:40 +0000 (15:27 -0500)]
Minor fix in Open-ILS/src/templates/opac/parts/place_hold_result.tt2

The hidden override field had two type attrs: "hidden" and "name."
I deleted the one with the value of "name."

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoLP1076062: Hold overrides not working properly.
Jason Stephenson [Mon, 10 Dec 2012 15:29:21 +0000 (10:29 -0500)]
LP1076062: Hold overrides not working properly.

Edit the verify_copy_for_hold helper function to actually work.  There
were cases where it would permit a copy when it shouldn't and also
disallow a copy when it should have allowed it.  It now makes better
use of the oargs override argument.

If oargs has an events member, the method now removes the matching from
the list of failure events returned by the permit_copy_hold check.  It
was previously bugged, stopping on the first matching event, clearing
the list of failed and events, and returning a value to indicate that
the copy is permitted for the hold, even when it may not be.

If oargs has the "all" member and there are failure events remaining,
the function loops through those events checking if the requestor has
the override permission for the event.  If the requestor does have the
override permission, then the event is added to oargs->{events} to be
saved for future checks on future copies.  It the requestor does not
have the override permission, then the event is pushed onto a new array
of failed events and also onto oargs->{failed}.  The latter is kept
to avoid looking up events repeatedly on future copy checks.

The oargs->{failed} member is added as a shortcut to avoid repeatedly
looking up override permissions when the requestor does not have them.
It is actually checked, when present, before the user permission is
checked with a costly database lookup.

Since verify_copy_for_hold has no other way to determine that an override
was requested, it checks for the events and/or all members of oargs being
set and having a value that would evaluate to true.  If oargs is undefined,
a hashref with no members, or lacks a "true" events or all member, then
verify_copy_for_hold functions as though no overrides are requested.

Additionally, all functions that call verify_copy_for_hold, either directly
or indirectly, have had their intro logic modified to only set oargs when
an override is requested and oargs is not already set.  We make the assump-
tion that if oargs is set, it contains the events member.  (Perhaps that is
a poor assumption, but all of the code so far looks like it will work.)

Fix test_and_create_hold_batch so that it passes the oargs parameter into
open-ils.circ.title_hold.is_possible in the way that check_title_hold (the
implementation function) actually expects it to be passed.  This also means
that we need to delete oargs from the params hashref before creating the
hold objects, as that would blow up if it were present.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoWhitespace cleanup on aisle 9!
Jason Stephenson [Wed, 5 Dec 2012 15:20:45 +0000 (10:20 -0500)]
Whitespace cleanup on aisle 9!

Fix whitespace (spaces, not tabs) in OpenILS/Application/Circ/Holds.pm.

Also, remove trailing whitespace at the end of lines.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoAvoid CStoreEditor failures on missing log-protect
Bill Erickson [Wed, 16 Jan 2013 14:39:56 +0000 (09:39 -0500)]
Avoid CStoreEditor failures on missing log-protect

When the log_protect configuration chunk is not present in
opensrf_core.xml, gracefully move on without it.  This prevents errors
like:

Can't call method \"shared\" on an undefined value at
/usr/local/share/perl/5.10.1/OpenILS/Utils/CStoreEditor.pm line 646.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoFix backdate near DST changes
Thomas Berezansky [Fri, 2 Nov 2012 13:53:30 +0000 (09:53 -0400)]
Fix backdate near DST changes

When the due date and the backdate date are on opposite sides of a DST
boundary we were getting an hour off on the checkin time (using the
original due date's time).

This commit changes it so that instead we just set the hour and minute
values on the backdate date to the due date's versions, leaving the time
zone alone.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoLP#1098669: improve handling of Content Cafe external content in staff client
Galen Charlton [Fri, 11 Jan 2013 18:11:48 +0000 (13:11 -0500)]
LP#1098669: improve handling of Content Cafe external content in staff client

This patch introduces a new TPac content variable, ctx.ext_proto, to
specify whether external content should be retrieved via HTTP or HTTPS.
ctx.proto can't be used for that purpose since it's set to 'oils' when
TPac is running inside the staff client.

This fixes a bug where Content Cafe reviews wouldn't display in the staff
client bib record page and where clicking on the reviews link from search
results would open an empty window.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years ago2.3 Release notes update
Bill Erickson [Tue, 15 Jan 2013 19:08:03 +0000 (14:08 -0500)]
2.3 Release notes update

Merge the edireader and edi_order_template release notes into the 2.3
release notes files.  Added a blurb to the Upgrade Notes regarding the
lack of an automatic EDI template upgrade.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoACQ invoice search persistence repaired
Bill Erickson [Mon, 1 Oct 2012 15:54:00 +0000 (11:54 -0400)]
ACQ invoice search persistence repaired

Use XUL cookieService / cookieManager for managing cookies in embedded
web pages, since dojo.cookie cannot manage cookies within xulrunner.

Persist cookies for 30 days.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoDocs: minor formatting fixes for "borrowing items" chapter
Dan Scott [Tue, 15 Jan 2013 03:39:51 +0000 (22:39 -0500)]
Docs: minor formatting fixes for "borrowing items" chapter

* Images need to have a trailing [] ; ideally this would contain the
  alt text for the image, but the [] is needed to make the images
  show up at all
* Since we're touching the image:: tags anyway, make the filename
  extensions consistently lower case
* Fix a processing error; a bulleted list item wrapped so that > was the
  first character on a line, which made Asciidoc angry. Easiest thing to
  do to avoid this is just to indent the wrapped lines for each bullet
  item, but we'll do the minimal thing and just indent this one line
  this time.
* Fix one instance of Word "smart quotes" having replaced ye olde single
  quotes.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoBorrowing items: who, what, for how long
Kathy Lussier [Tue, 15 Jan 2013 02:43:57 +0000 (21:43 -0500)]
Borrowing items: who, what, for how long

Adding Borrowing Items chapter from Evergreen in Action to the official
docs.`

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoEDI order template improvements (no SQL upgrade script!)
Bill Erickson [Tue, 11 Sep 2012 16:41:08 +0000 (12:41 -0400)]
EDI order template improvements (no SQL upgrade script!)

Improved template for EDI purchase orders.  This theoretically just
works better where the old template worked.  Corrections made for
interactions with ULS, Midwest Tape, Baker & Taylor, and Recorded Books
especially.  GIR segments in the right place.

And also the template is just more maintainable now.

**THERE IS NO UPGRADE SCRIPT INCLUDED**.  Sites using EDI may not
necessarily want to mess with what they already have working.

If you want the changes, and maybe you do, especially if you're doing
enriched ordering and/or ordering from the vendors listed above, you can
extract the template changes easily enough yourself from the
950.data.seed-values.sql file.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoUpgrade script numbering for edireader branch
Lebbeous Fogle-Weekley [Mon, 14 Jan 2013 21:59:12 +0000 (16:59 -0500)]
Upgrade script numbering for edireader branch

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoEDIReader release notes
Bill Erickson [Wed, 26 Dec 2012 21:27:38 +0000 (16:27 -0500)]
EDIReader release notes

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoHandle cancelled (back-order) lineitems in EDI invoice
Bill Erickson [Thu, 13 Dec 2012 14:44:55 +0000 (09:44 -0500)]
Handle cancelled (back-order) lineitems in EDI invoice

Receiving an invoice for a cancelled lineitem mean the lineitem is no
longer cancelled.  Identify such lineitems and uncancel them along with
the requested number of not-yet-invoiced copies.

This work flow is common for back-order items.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoEDIReader: improve monetary regexes
Bill Erickson [Wed, 12 Dec 2012 17:50:47 +0000 (12:50 -0500)]
EDIReader: improve monetary regexes

Make no attempt to enforce/decipher monetary amounts in the regexes,
simply capture the values.  If they are invalid, Postgres will let us
know.

This change allows us to capture non-numeric (\d) characters (e.g. "."),
which are of course common in monetary amounts.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoEDI invoice date; invoice paid quantity/amount
Bill Erickson [Wed, 5 Dec 2012 14:34:00 +0000 (09:34 -0500)]
EDI invoice date; invoice paid quantity/amount

* capture the invoice date in EDIReader
* apply the invoice date to inbound invoices when available instead of
  defaulting to 'now'
* apply the quantity/amount billed to the quantity/amount paid to reduce
  staff data entry needs

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoEDI: ensure lineitem 'state' matches cancel state
Bill Erickson [Tue, 4 Dec 2012 15:00:26 +0000 (10:00 -0500)]
EDI: ensure lineitem 'state' matches cancel state

When cancelling a lineitem becuase all linked copies are cancelled,
ensure that the lineitem state is set to "cancelled".

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoEDI response honor lineitem-level status; debit cleanup
Bill Erickson [Mon, 3 Dec 2012 19:51:41 +0000 (14:51 -0500)]
EDI response honor lineitem-level status; debit cleanup

* Honor lineitem-level order status info (FTX+LIN) which indicates, in
  some cases, that all ordered copies should be cancelled because the LI
  as a whole is cancelled

* Delete fund debits for cancelled lineitem details when appropriate

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoEDI: protect against invalid order response
Bill Erickson [Mon, 3 Dec 2012 14:20:29 +0000 (09:20 -0500)]
EDI: protect against invalid order response

Do not attempt to createI EDI messages for order responses which
reference nonexistent purchase orders, since it results in
transaction commit errors on invalid foreign keys, preventing
subsequent EDI files from getting processed.  Instead, log it
and skip it.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoEDIReader : detect SAN vs. account number in buyer/seller
Bill Erickson [Mon, 12 Nov 2012 14:35:53 +0000 (09:35 -0500)]
EDIReader : detect SAN vs. account number in buyer/seller

NAD+BY+XXXXXXX::31B' -- SAN
NAD+BY+YYYYYYY::91' -- Account number

For invoices, try the SAN first followed by the account number to
determine the receiving org unit.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoCustom/local EDI reader module for ORDRSP and INVOIC (etc)
Bill Erickson [Fri, 28 Sep 2012 14:34:28 +0000 (10:34 -0400)]
Custom/local EDI reader module for ORDRSP and INVOIC (etc)

Provides a new perl module (OpenILS::Utils::EDIReader) for reading
inbound EDI messages and producing data structures more easily
understood by the ACQ code.  Through this, extraction of EDI data is
focused in one module instead of spread through various layers.

EDIReader is a small, purpose built module focusing solely on extracting
the needed EDI data and is not meant to be a general purpose EDI library.

* Updates edi_fetcher and the ORDRSP and INVOIC handling code to use the
  new libs.

* Removes Business::EDI Evergreen dependency, since it's no longer used (and
  is quite large).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoFix a data destruction bug when authorities are updated.
Jason Stephenson [Fri, 11 Jan 2013 13:49:11 +0000 (08:49 -0500)]
Fix a data destruction bug when authorities are updated.

Modify the two-argument form of vandelay.merge_record_xml to return
the target_marc when the add_rule, preserve_rule, replace_rule and
strip_rule are all empty.

This method is used by authority.propagate_changes and would replace
the bibliographic record's marc with the overlay template when the
above would happen. By returning the biblographic record entry's own
marc in that case, we prevent data destruction.

Additionally, protect bib and authority template overlay functions
in the same manner.

Commit includes an upgrade script for this change as well as
for the previous commit's authority.generate_overlay_template fix.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoOnly consider main entry headings for bib overlay
Mike Rylander [Thu, 10 Jan 2013 21:35:44 +0000 (16:35 -0500)]
Only consider main entry headings for bib overlay

Restrict the authority fields we will pull overlay data from to those
that do not subordinate themselves to other authority fields.  That
is, skip see-from/see-also/etc for bib overlay.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoLP #1075167: Serials: Avoid infinite loop in holdings summarization
Lebbeous Fogle-Weekley [Wed, 9 Jan 2013 21:20:39 +0000 (16:20 -0500)]
LP #1075167: Serials: Avoid infinite loop in holdings summarization

When receiving items with unworkable combinations of holdings and
patterns, the holdings summarization code can get stuck in an infinite
loop.  This solution prevents that, sparing the open-ils.serial
process and server resources, although it doesn't help the user out.

It will take further examination of the problem and reëvalution of how
we deal with problems reported by OpenILS::Utils::MFHD to help the
user avoid or resolve these situations.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoAdding Designing Your Catalog chapter from the Evergreen In Action manual.
Kathy Lussier [Sun, 6 Jan 2013 03:01:54 +0000 (22:01 -0500)]
Adding Designing Your Catalog chapter from the Evergreen In Action manual.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Minor fixes to "Designing your catalog" chapter

Some strange Latin-1 characters were giving Asciidoc fits...

Signed-off-by: Dan Scott <dan@coffeecode.net>
7 years agofix user session management for MARC Batch Edit
Galen Charlton [Fri, 4 Jan 2013 19:33:28 +0000 (14:33 -0500)]
fix user session management for MARC Batch Edit

The Javascript in the hardcoded page templates was
not checking the XUL stash for the session key when
run from the staff client; this is now needed as
a result of the XULRunner updates introdued by
commit adee850f.

As a consequence, the list of the user's record buckets
was not retrieved, and attempts to run a batch edit
would spin without updating any records.

This fixes LP#1048707 and LP#1054277.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoDocumentation: Update upgrade instructions.
Robert Soulliere [Thu, 3 Jan 2013 19:23:54 +0000 (14:23 -0500)]
Documentation: Update upgrade instructions.

Also add a few index terms.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
7 years agoSIP option to use SIP date format for due dates
Bill Erickson [Wed, 26 Dec 2012 16:10:23 +0000 (11:10 -0500)]
SIP option to use SIP date format for due dates

New SIP configuration option "use_sip_date_format" which forces all SIP
dates to be formated using the SIP date format: YYYYMMDDZZZZHHMMSS

Without this setting, most dates already correctly use the SIP date
format.  However, for some historical reason, due dates are formatted as
ISO 8601 dates.  Enable this setting to force due dates to use the SIP
date format.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoLP1092937 - fix title/author in alternate pull list
Ben Shum [Mon, 24 Dec 2012 01:46:02 +0000 (20:46 -0500)]
LP1092937 - fix title/author in alternate pull list

Clicking on Print Full Pull List (Alternate strategy) no longer showed
the title and author columns for hold pull lists.

It seems that adding quotes around the tag lookups was all that was
required to bring these back for now. Long-term, it still seems better
to continue moving towards fewer pull list interfaces.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoTPAC - SMS Number Munging
Thomas Berezansky [Tue, 2 Oct 2012 17:31:13 +0000 (13:31 -0400)]
TPAC - SMS Number Munging

Addresses LP bug 1016654 - Despite the hint telling users not to use
hyphens when entering a text notification number, we have patrons who
are entering the hyphens causing the text notification to fail.

Munge "pretty printed" numbers into raw sets of digits in the A/T helper.

This allows aliases to still work for services that support them.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoStamping upgrade script for index corporate authors
Ben Shum [Sun, 23 Dec 2012 20:38:43 +0000 (15:38 -0500)]
Stamping upgrade script for index corporate authors

Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoIndex corporate authors based on relator codes
Dan Scott [Tue, 30 Oct 2012 16:08:54 +0000 (12:08 -0400)]
Index corporate authors based on relator codes

The existing stock index for corporate authors only kicks in if the
710 subfield 'e' == 'creator', but relator codes (in subfield '4') are
by many accounts a preferred mode of identifying the relationship of an
added entry. Thus, add '4' == ('aut' or 'cre') to the criteria for
indexing a corporate author.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP 1088561 - part 2, fix all update forms to not show saved passwords
Ben Shum [Thu, 20 Dec 2012 19:32:46 +0000 (14:32 -0500)]
LP 1088561 - part 2, fix all update forms to not show saved passwords

Bug re-opened due to locating a few other locations in my account area
where the password was being saved by browsers like Firefox instead of
requiring users to key in current password to make changes.

This patch covers those two additional cases and changes the quoting
around the first case to be more consistent with the rest of the line.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Simon Mai <hieu.mai@mnsu.edu>
7 years agoTPAC: Fallback default value for facet.default_display_count
Dan Scott [Sun, 16 Dec 2012 14:09:03 +0000 (09:09 -0500)]
TPAC: Fallback default value for facet.default_display_count

Open-ILS/templates/opac/parts/result/facets.tt2 assigns the value of
facet.default_display_count to DEFAULT_DISPLAY_COUNT and then uses the
latter in a number of comparisons. facet.default_display_count is
expected to be defined in config.tt2; however, on upgrade, sites with
many override templates may not realize that they need to define that
value in config.tt2. If they do not, then the result is a strange facet
display where only the facet category header shows, with no facets, and
Apache error log messages like:

Argument "" isn't numeric in numeric gt (>) at
/openils/var/templates/opac/parts/result/facets.tt2 line 72.

This simple defensive fix assigns a fallback default value if one was
not provided in config.tt2

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoFacets should not be sticky when users click "Search"
Dan Scott [Sat, 22 Dec 2012 02:15:49 +0000 (21:15 -0500)]
Facets should not be sticky when users click "Search"

We were using a hidden form variable to track which facets were in use,
at the same time as relying on the GET params to actually display the
facets, and munging the links on the remaining facets to properly
add/subtract facets.

The result of the hidden form variable was that:

1) clicking the Search button would unexpectedly result in the facet
applying to the new search (wat)

2) applying two facets at once and then searching again would result
in the facet vars being treated as a raw array.

Thanks to Dan Pearl for inspiring this patch with his fix for the latter
problem, and Kathy Lussier's recognition of the basic problem.

Closes LP# 1092946 and 1091659.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoTest data copies get "checked out" copy status when circ'd
Bill Erickson [Fri, 21 Dec 2012 16:14:10 +0000 (11:14 -0500)]
Test data copies get "checked out" copy status when circ'd

Set the status to 1 (checked out) for items that are circulated as part
of the test data transactions load.  Otherwise, the data is busted and
renewals are not possible.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agolp1090867 Hide Fields undefined var error
Jason Etheridge [Fri, 21 Dec 2012 12:26:36 +0000 (07:26 -0500)]
lp1090867 Hide Fields undefined var error

This fixes the "Error in widget_prompt.js, my_init(): TypeError: offlineStrings
is undefined" error.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoCopy 2.3.1-2.3.2 SQL upgrade script into place
Bill Erickson [Thu, 20 Dec 2012 21:48:56 +0000 (16:48 -0500)]
Copy 2.3.1-2.3.2 SQL upgrade script into place

Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoCopy 2.3.0-2.3.1 SQL upgrade script into place
Bill Erickson [Thu, 20 Dec 2012 21:48:42 +0000 (16:48 -0500)]
Copy 2.3.0-2.3.1 SQL upgrade script into place

Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoMaster didn't get these two rel_2_2 series upgrade scripts
Lebbeous Fogle-Weekley [Thu, 20 Dec 2012 21:50:44 +0000 (16:50 -0500)]
Master didn't get these two rel_2_2 series upgrade scripts

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoUpdate "Adding a data source to the reporter" docs
Dan Scott [Thu, 20 Dec 2012 16:36:42 +0000 (11:36 -0500)]
Update "Adding a data source to the reporter" docs

A little bit of formatting clean-up, a little bit of extra information.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoTranslations update step 2: newpot
Bill Erickson [Thu, 20 Dec 2012 14:47:17 +0000 (09:47 -0500)]
Translations update step 2: newpot

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoTranslations update step 1: update profiles
Bill Erickson [Thu, 20 Dec 2012 14:36:56 +0000 (09:36 -0500)]
Translations update step 1: update profiles

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoConsistent permission filtering in ACQ search results
Bill Erickson [Fri, 14 Sep 2012 19:30:15 +0000 (15:30 -0400)]
Consistent permission filtering in ACQ search results

Add permission checks to search result objects when calling unified
search in 'idlist' mode, consistent with the existing permission checks
for non-id-list mode.  Without this, different forms of the call return
different sets of results.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoLP #1092179 FlattenerGrid Filter dialog lead to clobbering grid's base query
Lebbeous Fogle-Weekley [Wed, 19 Dec 2012 16:41:28 +0000 (11:41 -0500)]
LP #1092179 FlattenerGrid Filter dialog lead to clobbering grid's base query

You could see this in the Simplified Hold Pull List interface.  Using
the filter dialog would refresh the grid and populate it with rows
corresponding to your filters, but it would throw away your setting from
the context org dropdown (labeled "Show the pull list for..." there).

FlattenerGrid had a broken mechanism for trying to nicely mix a user's
input from things like context org dropdowns with whatever they put into
the filter dialog, and now that mechanism has been fixed.

This also means a tiny change to the User Event Log interface to react
to the slight change in FlattenerGrid's API.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP#1088561: remove current password (renew password issue with TPAC)
Simon Hieu Mai [Wed, 19 Dec 2012 20:33:54 +0000 (14:33 -0600)]
LP#1088561: remove current password (renew password issue with TPAC)

If a user chooses to have their browser remember their password for the
catalog, it can fill in the password to the change password form page
as hidden dots. This behavior was observed specifically with Firefox.

Instead, add autocomplete="off" attribute to the form to force users to
enter existing password to change to a new password as intended.

Signed-off-by: Simon Mai <hieu.mai@mnsu.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoAdd fi-FI to update_pofiles script
Pasi Kallinen [Tue, 18 Dec 2012 08:42:59 +0000 (10:42 +0200)]
Add fi-FI to update_pofiles script

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agopo-files for Finnish translation
Pasi Kallinen [Tue, 18 Dec 2012 08:41:28 +0000 (10:41 +0200)]
po-files for Finnish translation

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoMake config.update_coded_value_map() consistent
Dan Wells [Tue, 18 Dec 2012 20:51:12 +0000 (15:51 -0500)]
Make config.update_coded_value_map() consistent

The version of this function in the upgrade file is different than
the one in the 002.schema.config.sql file. This commit fixes the
broken logic in the 002 file and makes it match the logic in the
old upgrade file.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoCheck for a selection_depth returned from title_hold.is_possible.
James Fournie [Tue, 18 Dec 2012 20:45:51 +0000 (12:45 -0800)]
Check for a selection_depth returned from title_hold.is_possible.
See Launchpad 1064651 for details.  This is a quick fix which solves a
fairly serious issue whereby copies outside of a hard boundary could fill
holds when they are placed within the TPAC in the staff client.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoDojo IDL: Set the "Accept-Language" header
Dan Scott [Tue, 18 Dec 2012 13:52:55 +0000 (08:52 -0500)]
Dojo IDL: Set the "Accept-Language" header

The internationalization support for /reports/fm_IDL.xml keys off of the
Accept-Language header - which, if not set to ^[a-z]{2}-[A-Z]{2}$, falls
back to en-US. Setting the header in the dojo.xhrGet() request makes
Apache able to serve up the right flavour of /reports/fm_IDL.xml

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>