7 years agoZ39.50 Batch Search/Overlay : SQL / IDL
Bill Erickson [Wed, 30 Jan 2013 20:08:47 +0000 (15:08 -0500)]
Z39.50 Batch Search/Overlay : SQL / IDL

 * DB table for Z39.50 index field maps, which link Z39 search fields to
   indexed bib data via metabib fields and record attributes (svf)

 * Seed data for Z39.50 batch search org unit settings
  ** cat.z3950.batch.max_parallel
  ** cat.z3950.batch.max_results

 * Stock seed data for config.z3950_index_field_map entries

Signed-off-by: Bill Erickson <>
7 years agoRepair SIP start/end list ranges
Bill Erickson [Fri, 5 Apr 2013 17:28:08 +0000 (13:28 -0400)]
Repair SIP start/end list ranges

SIP supports paging of certain lists (holds, fines, etc.) by allowing
the SIP client to provide start and end points for lists.  This patch
repairs how Evgreen extracts the list ranges from arrays.

When using Perl array ranges, the array variable should be accessed via
'@' and not '$'.  Prior to this change, all ranged lists resulted in
returning the first item in the list instead of the full range.

This change affects lists of holds, overdues, fines, and charges.

Signed-off-by: Bill Erickson <>
Signed-off-by: Jeff Godin <>
7 years agoMake Force/Recall holds always return as nearest
Thomas Berezansky [Thu, 26 Jul 2012 14:25:32 +0000 (10:25 -0400)]
Make Force/Recall holds always return as nearest

Without even running the hold rules.

Signed-off-by: Thomas Berezansky <>
Signed-off-by: Mike Rylander <>

(Just whitespace conflicts on tab vs space -- repaired by hand.)

7 years agoTPAC - set autofocus to user input when placing holds in staff client
Ben Shum [Sat, 2 Mar 2013 07:21:58 +0000 (02:21 -0500)]
TPAC - set autofocus to user input when placing holds in staff client

When placing holds in TPAC via the staff client, the focus had been on the
basic search field above. Change this to have autofocus on the input field
for the hold user by default.

This can potentially save staff from having to perform an extra click to
select the input field. Now they can immediately begin entering the barcode
of the user they plan to create a hold on behalf of.

Signed-off-by: Ben Shum <>
Signed-off-by: Mike Rylander <>
7 years agoSIP renew-all; reset renewal statuses
Bill Erickson [Mon, 7 Jan 2013 14:35:55 +0000 (09:35 -0500)]
SIP renew-all; reset renewal statuses

Reset the list of renewed and unrenewed items for each instance of the
RenewAll transactions.  Otherwise, items from previous transactions will
bleed into the current transaction.

While we're in there, fix a couple of tabs.

Signed-off-by: Bill Erickson <>
Signed-off-by: Mike Rylander <>
7 years agoSIP RenewAll
Bill Erickson [Mon, 26 Nov 2012 19:51:27 +0000 (14:51 -0500)]
SIP RenewAll

Adds SIP plugin support for SIP message types 65/66 (Renew All).  When
requested, the plugin performs a renewal on all items currently checked
out for the user.

Signed-off-by: Bill Erickson <>
Signed-off-by: Mike Rylander <>
7 years agoLP1040147 Return wrong-shelf holds in clearable list
Bill Erickson [Fri, 7 Jun 2013 13:42:57 +0000 (09:42 -0400)]
LP1040147 Return wrong-shelf holds in clearable list

1. Change the staff client "View Shelf-Expired Holds" action label to
"View Clearable Holds".

2.  When "View Clearable Holds" is selected, display both shelf-expired
and wrong-shelf holds.

New API calls:


Signed-off-by: Bill Erickson <>
Signed-off-by: Jason Etheridge <>
7 years agochange checkbox label in Browse Hold Shelf
Jason Etheridge [Thu, 6 Jun 2013 23:00:45 +0000 (19:00 -0400)]
change checkbox label in Browse Hold Shelf

from View Shelf-Expired Holds to View Clearable Holds

Signed-off-by: Jason Etheridge <>
Signed-off-by: Bill Erickson <>
7 years agoadd Current Shelf Library column to xul interfaces
Jason Etheridge [Thu, 6 Jun 2013 21:49:46 +0000 (17:49 -0400)]
add Current Shelf Library column to xul interfaces

Signed-off-by: Jason Etheridge <>
Signed-off-by: Bill Erickson <>
7 years agoInclude Wrong-Shelf holds in clear-shelf results
Bill Erickson [Tue, 21 Aug 2012 21:19:54 +0000 (17:19 -0400)]
Include Wrong-Shelf holds in clear-shelf results

Include non-expired, Wrong-Shelf holds in the results list of the "Clear
Shelf-Expired Holds" process.  ("Wrong-Shelf" holds are those whose
pickup lib was changed while the hold was on the holds shelf).  The idea
behind this option is that branches may use the clear-shelf process as a
general shelf management report beyond just holds that have expired.
I.e. tell me everything I need to remove from the shelf.

This change includes a label change for the clear-shelf menu options:

"Clear Shelf-Expired Holds" -> "Clear Holds Shelf"

Signed-off-by: Bill Erickson <>
Signed-off-by: Jason Etheridge <>
7 years agoAsciidoc edit for My Lists documentation
Angela Kilsdonk [Fri, 7 Jun 2013 14:04:27 +0000 (10:04 -0400)]
Asciidoc edit for My Lists documentation

Change to asciidoc structure in opac/my_lists.txt

Signed-off-by: Angela Kilsdonk <>
7 years agoRemove unnecessary TPAC toggle strings on staff client splash page
Ben Shum [Fri, 7 Jun 2013 00:14:08 +0000 (20:14 -0400)]
Remove unnecessary TPAC toggle strings on staff client splash page

Accidentally reintroduced with commit ad86ef5d3c689c9b514cc09bfc93e7f451461dc7,
we can skip adding back TPAC toggle strings to the index.xhtml file since that
toggle action has been removed from the page.

Signed-off-by: Ben Shum <>
7 years agoAcq: Be fuzzy about case when retrieving EDI documents
Lebbeous Fogle-Weekley [Mon, 15 Apr 2013 18:06:54 +0000 (14:06 -0400)]
Acq: Be fuzzy about case when retrieving EDI documents

The edi_fetcher relies on a routine in OpenILS::Acq::EDI to, among
other things, try to avoid fetching the same EDI document multiple times
when many rows in acq.edi_account refer to the same host and login

Since in practice most vendors seem to run FTP servers for EDI on
Windows, not UNIX, and pathnames are therefore case-insensitive, that
test for other occurrences ought also to be case-insensitive.

If I were to look at this as a purist, I could argue that vendor servers
might sometimes by run on UNIX, and that for some reason it is possible
that different vendor-to-buyer EDI documents (order responses or
invoices) could have pathnames that differ only in the case of some
characters.  But that seems wildly unlikely.  If anyone does take this
possibility seriously, perhaps acq.edi_account needs a Boolean column to
indicate the remote host's case [in]sensitivity.

Signed-off-by: Lebbeous Fogle-Weekley <>
Signed-off-by: Ben Shum <>
7 years agolp1183525 Edit Item Attributes pop-up dimensions
Jason Etheridge [Thu, 6 Jun 2013 21:39:24 +0000 (17:39 -0400)]
lp1183525 Edit Item Attributes pop-up dimensions

Took Steven Chan's patch from the launchpad bug and added "stickiness" to the
window dimensions.  So by default, it'll come up maximized, but once adjusted,
it will stay adjusted.

Signed-off-by: Jason Etheridge <>
7 years ago"Return to record" after submission of phone number on SMS page fixed
Lebbeous Fogle-Weekley [Thu, 2 May 2013 19:00:31 +0000 (15:00 -0400)]
"Return to record" after submission of phone number on SMS page fixed

Before this, it only worked on the page load *before* form submission.
There's probably a more elegant solution that doesn't involve keeping
track of URIs, but this seems to me to work.

Problem relayed to me by Dale Rigney at Equinox, who helped reproduce
the issue and test a fix.

Signed-off-by: Lebbeous Fogle-Weekley <>
Signed-off-by: Jason Etheridge <>
7 years agofix copy/paste error
Jason Etheridge [Thu, 6 Jun 2013 20:47:13 +0000 (16:47 -0400)]
fix copy/paste error

Signed-off-by: Jason Etheridge <>
7 years agoAllow translating more strings in xul-files.
Pasi Kallinen [Tue, 19 Mar 2013 23:21:28 +0000 (01:21 +0200)]
Allow translating more strings in xul-files.

Signed-off-by: Pasi Kallinen <>
Signed-off-by: Jason Etheridge <>
7 years agoAdd the copy number to the list of data being pulled for access by the TPAC.
Steven Callender [Mon, 11 Mar 2013 19:48:57 +0000 (15:48 -0400)]
Add the copy number to the list of data being pulled for access by the TPAC.

Signed-off-by: Steven Callender <>
Signed-off-by: Jason Etheridge <>
7 years agoAllow translating the staff client tab names
Pasi Kallinen [Thu, 7 Mar 2013 10:17:09 +0000 (12:17 +0200)]
Allow translating the staff client tab names

Signed-off-by: Pasi Kallinen <>
Signed-off-by: Jason Etheridge <>
7 years agoFix Latin-1 encoding that broke doc output
Dan Scott [Thu, 6 Jun 2013 18:01:07 +0000 (14:01 -0400)]
Fix Latin-1 encoding that broke doc output

asciidoc only expects and can only handle utf-8 encoding :)

Signed-off-by: Dan Scott <>
7 years agoImprove the -script to actually grab all strings.
Pasi Kallinen [Thu, 21 Mar 2013 10:01:24 +0000 (12:01 +0200)]
Improve the -script to actually grab all strings.

Previously the script could only handle oils_i18n_gettext -markers
if the marker and it's parameters were all on one line.

Now it also correctly parses the postgres E'' escaped strings, and
removes sql string concatenations.

Also adds test cases.

Signed-off-by: Pasi Kallinen <>
Signed-off-by: Dan Scott <>
7 years agoAdd new POT files to git so "make newpo" will work
Dan Scott [Thu, 6 Jun 2013 16:13:36 +0000 (12:13 -0400)]
Add new POT files to git so "make newpo" will work

Running "make newpo" errored out because the po subdirectories didn't
exist for the newly added POT files. This will also enable translators
to access the strings in Launchpad.

Signed-off-by: Dan Scott <>
7 years agoAdd missing dojo nls files to the i18n toolchain, and fix one of the files so they...
Pasi Kallinen [Tue, 4 Jun 2013 09:01:32 +0000 (12:01 +0300)]
Add missing dojo nls files to the i18n toolchain, and fix one of the files so they be built.

Signed-off-by: Pasi Kallinen <>
Signed-off-by: Dan Scott <>
7 years agoFedora RPM for bzip2 headers is bzip2-devel
Dan Scott [Thu, 6 Jun 2013 13:40:59 +0000 (09:40 -0400)]
Fedora RPM for bzip2 headers is bzip2-devel

There was an attempt to add the right RPM for the bzip2 headers in
Makefile.install, but that failed on Fedora 19. Swap in bzip2-devel
instead to correct that.

Signed-off-by: Dan Scott <>
7 years agoTPAC: First part of locg param can be branch shortname
Lebbeous Fogle-Weekley [Mon, 22 Oct 2012 22:02:23 +0000 (18:02 -0400)]
TPAC: First part of locg param can be branch shortname

Addresses LP #1020625.  You can use the locg param, which can set an
an OU for search context (and which has other implications related to
location/scope) by shortname now.

As long as your shortnames are something that work in an HTTP query
string, don't contain colons, and as long as you don't have numeric
shortnames for any orgs that would mask orgs with the sames numbers
as an ID (but that would be a lousy setup anyway), this should work.

Now case insensitive per recommendation by Michael Peters.  In the
event that you have org units with names that are the same except
for case (probably a bad practice), the locg parameter will simply
fail to set your context, rather than try to guess which org unit
you meant.

Signed-off-by: Lebbeous Fogle-Weekley <>
Signed-off-by: Pasi Kallinen <>
Signed-off-by: Dan Scott <>

7 years agoAsciidoc fix for documentation
Angela Kilsdonk [Thu, 6 Jun 2013 14:38:42 +0000 (10:38 -0400)]
Asciidoc fix for documentation

Fixed faulty asciidoc in docs/admin/lsa-library_settings_editor.

Signed-off-by: Angela Kilsdonk <>
7 years agoMove lost items modification release notes
Ben Shum [Wed, 5 Jun 2013 03:17:17 +0000 (23:17 -0400)]
Move lost items modification release notes

Moved to the Circulation category and small changes to the formatting for

Signed-off-by: Ben Shum <>
7 years agoStamping upgrade script for lost items blocking
Ben Shum [Wed, 5 Jun 2013 03:38:25 +0000 (23:38 -0400)]
Stamping upgrade script for lost items blocking

Signed-off-by: Ben Shum <>
7 years agoPatron Blocking by lost items and include lost as items out
Kyle Tomita [Thu, 14 Mar 2013 22:01:14 +0000 (15:01 -0700)]
Patron Blocking by lost items and include lost as items out

This feature has two main parts, patron blocking by number
of lost items and include lost items as items out.  A group penalty
threshold will be added for lost items.  This will restrict patrons
who have lost too many items. The inclusion of lost items as items
out will be an optional setting, like claimed returned items. This
will allow libraries to set what type of item statuses count toward
the total items out.

Signed-off-by: Kyle Tomita <>
Signed-off-by: Justin Douma <>
Signed-off-by: Ben Shum <>
7 years agoAdded release note for standalone mode shortcuts
Ben Shum [Wed, 5 Jun 2013 02:57:00 +0000 (22:57 -0400)]
Added release note for standalone mode shortcuts

Signed-off-by: Ben Shum <>
7 years agoStandalone Mode Staff Client Shortcuts
Pranjal Prabhash [Mon, 9 Apr 2012 14:55:08 +0000 (10:55 -0400)]
Standalone Mode Staff Client Shortcuts

This commit addresses LP#955283, which requested the creation
of a Windows shortcut for Evergreen's standalone staff client

Signed-off-by: Pranjal Prabhash <>
Signed-off-by: Ben Shum <>
7 years agoLP#1053074: Editimg MARC Fixed Fields jumps cursor to marc record
Simon Hieu Mai [Mon, 3 Jun 2013 21:45:08 +0000 (17:45 -0400)]
LP#1053074: Editimg MARC Fixed Fields jumps cursor to marc record

Put the cursor back to the current fixed field after reload
the MARC record table.

Signed-off-by: Simon Hieu Mai <>
Signed-off-by: Dan Wells <>
7 years agoLP1183340 selectivly apply editable funds sorting
Bill Erickson [Thu, 23 May 2013 13:11:25 +0000 (09:11 -0400)]
LP1183340 selectivly apply editable funds sorting

Avoid sorting editable funds to the front of the fund list when there
are no org units at which the user has the ADMIN_ACQ_FUND permission.
Otherwise, we are sorting on an empty 'IN' list in pcrud, which results
in an error.

Signed-off-by: Bill Erickson <>
Signed-off-by: Dan Wells <>
7 years agoDocumentation for preset tabs and auto login
Tracy Swaim [Sat, 1 Jun 2013 05:13:13 +0000 (01:13 -0400)]
Documentation for preset tabs and auto login

Missed the actual documentation in the last commit for preset tabs and
auto login docs. Here it is.

Signed-off-by: Kathy Lussier <>
7 years agoPre-set tabs and auto login
Tracy Swaim [Sat, 1 Jun 2013 05:00:26 +0000 (01:00 -0400)]
Pre-set tabs and auto login

Adding staff client documentation for pre-set tabs and auto login.

Signed-off-by: Kathy Lussier <>
7 years agoDocumentation for Org Unit Hiding in TPAC
Angela Kilsdonk [Fri, 31 May 2013 19:09:11 +0000 (15:09 -0400)]
Documentation for Org Unit Hiding in TPAC

Added Org Unit Hiding in TPAC documentation to admin/lsa-library_settings_editor.txt.

Signed-off-by: Angela Kilsdonk <>
7 years agoMerge branch 'master' of
Angela Kilsdonk [Fri, 31 May 2013 18:46:50 +0000 (14:46 -0400)]
Merge branch 'master' of

7 years agoWhen delivering MARC21 via SuperCat, OpenSearch, offer filename w/ extension
Lebbeous Fogle-Weekley [Fri, 10 May 2013 16:32:51 +0000 (12:32 -0400)]
When delivering MARC21 via SuperCat, OpenSearch, offer filename w/ extension

If you want a record feed in MARC21, without this commit a web browser
just suggests "marc21" as the filename for saving to your local system.

Although many consumers of these feeds will be custom scripts and other
non-interactive software components that won't care about filename, for
the web browser case it's helpful if the server suggests a filename that
ends in .mrc.

So here we go.

Signed-off-by: Lebbeous Fogle-Weekley <>
Signed-off-by: Ben Shum <>
7 years agoLP1081576 - fix utf8 characters in searches using portal page
Ben Shum [Thu, 23 May 2013 20:32:49 +0000 (16:32 -0400)]
LP1081576 - fix utf8 characters in searches using portal page

Replace escape() with encodeURIComponent() on the portal page to allow utf8
characters to be passed more appropriately to the subsequent search in catalog.

Thanks Dan Scott for pointing this out.

Signed-off-by: Ben Shum <>
Signed-off-by: Pasi Kallinen <>
7 years agoFix reference to image that broke epub build
Dan Scott [Fri, 31 May 2013 16:27:13 +0000 (12:27 -0400)]
Fix reference to image that broke epub build

The path pointing to the desired image was incorrect, which resulted in
a broken epub build and probably just a missing image in other formats.

Signed-off-by: Dan Scott <>
7 years agoAcquisitions Admin updates
Kathy Lussier [Sat, 25 May 2013 00:52:01 +0000 (20:52 -0400)]
Acquisitions Admin updates

Updates to the chapter on acquisitions administration, including 1) the
reintroduction of the Providers section, which appears to have dropped out
of the docs after 2.1 2) the new default # copies and improvements to
distributions formulas introduced in 2.4 and 3) minor copy editing.

Signed-off-by: Kathy Lussier <>
Signed-off-by: Dan Scott <>
7 years agodon't let function keys lock the MARC editor
Jason Etheridge [Mon, 2 Apr 2012 21:07:55 +0000 (17:07 -0400)]
don't let function keys lock the MARC editor

lock = put the interface into a state where it prompts with an unsaved data
warning before closing the interface

Signed-off-by: Jason Etheridge <>

Signed-off-by: Pasi Kallinen <>
Signed-off-by: Dan Wells <>
7 years agoDocumentation updates for acquisitions invoices
Kathy Lussier [Thu, 30 May 2013 17:01:38 +0000 (13:01 -0400)]
Documentation updates for acquisitions invoices

Updates to acquisitions invoices documentation, including new 2.4
features. Also moves up some 2.1 documentation that is still relevant.

Signed-off-by: Kathy Lussier <>
7 years agoDocumentation for Call Numbers in My Lists
Angela Kilsdonk [Thu, 30 May 2013 15:12:40 +0000 (11:12 -0400)]
Documentation for Call Numbers in My Lists

Signed-off-by: Angela Kilsdonk <>
7 years agoChange autoconf required version for libmar's
Ben Shum [Wed, 29 May 2013 22:06:09 +0000 (18:06 -0400)]
Change autoconf required version for libmar's

Having it set to 2.68 (current for Ubuntu Precise) broke autoreconf for other
distributions. Notably Debian Squeeze/Wheezy have 2.67 and Ubuntu Lucid has
2.65 for their autoconf version.

Set a minimum requirement of 2.61 that we use in the existing options.

Signed-off-by: Ben Shum <>
7 years agoAdd new dependency on libbz2-dev(el).
Jason Stephenson [Tue, 26 Mar 2013 15:01:50 +0000 (11:01 -0400)]
Add new dependency on libbz2-dev(el).

Our own mar tools add a build dependency on libbz2.  The easiest way to
make sure this is there seems to be to install libbz2-dev(el).

Also, update the release notes to reflect the new dependency.

Signed-off-by: Jason Stephenson <>
Signed-off-by: Ben Shum <>
7 years agoAdd release notes for the new updates tools.
Jason Stephenson [Wed, 20 Mar 2013 14:45:03 +0000 (10:45 -0400)]
Add release notes for the new updates tools.

Signed-off-by: Jason Stephenson <>
Signed-off-by: Ben Shum <>
7 years agoFix segmentation fault in mbsdiff and fix crc by linking with libbz2.
Jason Stephenson [Tue, 19 Mar 2013 12:38:31 +0000 (08:38 -0400)]
Fix segmentation fault in mbsdiff and fix crc by linking with libbz2.

Doh! I typed memcpy when I really wanted memset.

This does not actually introduce any new dependencies.  Evergreen
updates/installation already requires bzip2.  If bzip2 is present,
then libbz2 is present.  We don't need libbz2 headers, just the
library itself for a single data structure used in crc32 calculation.

Signed-off-by: Jason Stephenson <>
Signed-off-by: Ben Shum <>
7 years agoAdd libmar to build update tools to the repo.
Jason Stephenson [Tue, 19 Mar 2013 00:03:42 +0000 (20:03 -0400)]
Add libmar to build update tools to the repo.

This adds code from Mozilla to build a command line mar program and the
libmar library that it uses.  This code is now dual-licensed under the
MPL 2.0 and GPL v2 or later.

We also add our own version of mbsdiff using a modified version of Colin
Percival's FreeBSD-licensed bsdiff program.  We also copy the crc32 code
from Mozilla's updater.

Add libmar as "subpackage" in

Add AC_CONFIG_SUBDIRS macro call for Open-ILS/xul/staff_client/external/
libmar so that our update tools will get configured and built when
Evergreen is built.

Modify for our update tools.

Instead of downloading mar and mbsdiff from's servers,
we check if they exist in Open-ILS/xul/staff_client/external/libmar/tool
and if not we build them.  They should be there already.

Signed-off-by: Jason Stephenson <>
Signed-off-by: Ben Shum <>
7 years agoLP1168186 - Add tag 111 and remove subfield 4 from author pool
Ben Shum [Sun, 14 Apr 2013 02:28:53 +0000 (22:28 -0400)]
LP1168186 - Add tag 111 and remove subfield 4 from author pool

Add meeting/conference main entry (111) to TPAC author pool.

Remove subfield 4 from the author data because the information contained
refers to relator and may not be helpful at this time.

Signed-off-by: Ben Shum <>
Signed-off-by: Mark Cooper <>
7 years agoAdd corporate author (110) to TPAC author pool
Dan Wells [Thu, 11 Apr 2013 23:54:12 +0000 (19:54 -0400)]
Add corporate author (110) to TPAC author pool

As requested in LP#1168186, here is a simple attempt to add corporate
authors to the author 'pool' in TPAC.

We may also want to consider adding 111 (meeting or conference as
main entry), but that isn't totally clear cut.

Signed-off-by: Dan Wells <>
Signed-off-by: Mark Cooper <>
Signed-off-by: Ben Shum <>
7 years agoLP1183357 Pass locale to bib search (tpac)
Bill Erickson [Thu, 23 May 2013 13:43:52 +0000 (09:43 -0400)]
LP1183357 Pass locale to bib search (tpac)

Pass the TPAC locale value, which is collected at each page load, to the
bib search API call.  This allows us to take advantage of language-based
relevance bumps.

Signed-off-by: Bill Erickson <>
Signed-off-by: Pasi Kallinen <>
Signed-off-by: Dan Wells <>
7 years agoDocumentation for Best Hold Selection Sort Order
Angela Kilsdonk [Wed, 29 May 2013 19:44:56 +0000 (15:44 -0400)]
Documentation for Best Hold Selection Sort Order

Signed-off-by: Angela Kilsdonk <>
7 years agoUpdated root
Angela Kilsdonk [Wed, 29 May 2013 19:40:19 +0000 (15:40 -0400)]
Updated root

Signed-off-by: Angela Kilsdonk <>
7 years agoOrg Unit Proximity Adjustment documentation
akilsdonk [Wed, 29 May 2013 18:59:48 +0000 (14:59 -0400)]
Org Unit Proximity Adjustment documentation

Signed-off-by: akilsdonk <>
7 years agoTest dataset: authority records for concerto
Dan Scott [Thu, 11 Apr 2013 13:43:10 +0000 (06:43 -0700)]
Test dataset: authority records for concerto

Add a handful of authority records to match a subset of the Concerto
bib records. When the --load-all or --load-concerto options are passed
to eg_db_config, these authority records will be loaded. Running
"authority_control_fields -s 1 -e 100" will then generate 19 links from
Concerto bibs to corresponding authority records.

Signed-off-by: Dan Scott <>
Signed-off-by: Lebbeous Fogle-Weekley <>
7 years agoTPAC: Death date missing from authors in record details
Dan Scott [Fri, 10 May 2013 17:12:55 +0000 (13:12 -0400)]
TPAC: Death date missing from authors in record details

The trailing period prescribed by ISBD punctuation for x00 $d subfields
in certain circumstances confounds the regex that was expected the $d
subfield to match ^\s*\d{4}-\d{4}\s*$. As a result, death dates were
often being omitted from the record detail display. Relaxing the regex
to match against a trailing .* instead of \s* resolves the issue.

Signed-off-by: Dan Scott <>
Signed-off-by: Pasi Kallinen <>
Signed-off-by: Ben Shum <>
7 years agoFix Launchpad Bug 1183418.
Jason Stephenson [Thu, 23 May 2013 15:44:05 +0000 (11:44 -0400)]
Fix Launchpad Bug 1183418.

Clicking on an author with a dash or dates in the name on the search
results page comes up with 0 results. It looks like the dash is stripped
from the date and/or name.

Clicking on such a link from the record view actually works because
the dash is replaced with a space.

This branch changes table.tt2 to replace special characters in author
output with a space in the same way that authors.tt2 does.

Signed-off-by: Jason Stephenson <>
Signed-off-by: Ben Shum <>
7 years agoAvoid additional whitespace in password messages
Dan Scott [Thu, 23 May 2013 16:09:55 +0000 (12:09 -0400)]
Avoid additional whitespace in password messages

Trivial enhancements to avoid extra linefeeds in generated HTML, as well
as including a linefeed at the end of the new password_reset_msg.tt2
file. Good old DOS vs. UNIX :)

Signed-off-by: Dan Scott <>
7 years agoTPAC - Password Messages
Melissa Lefebvre [Fri, 10 May 2013 19:19:09 +0000 (15:19 -0400)]
TPAC - Password Messages

In jspac a message appeared when the patron went to change their
password stating the requirements. This same message is missing
in TPAC. The wording from jspac has been added to a separate
file, update_password_msg.tt2,  that can later be easily edited
and the original update_password.tt2 has been edited with an
INCLUDE statement pointing to the newly created file.

Also improved is the message when requesting a forgotten password.
Patrons are unaware that a valid email address needs to be in
their record until after they try to send a reset. Text has been
added to a new file, password_reset_msg.tt2,  to explain the need
for an email address.  Password_reset.tt2  has been edited with
an INCLUDE statement pointing to the newly created file.

Style.css.tt2 was also updated to remove extra padding on
#account-update-email table to raise the table on
update_password.tt2.  This value is also used on
update_username.tt2 and update_email.tt2 without considerable
impact to the look of those pages.

Signed-off-by: Melissa Lefebvre <>
Signed-off-by: Dan Scott <>
7 years agoLP#1182360: typo fix
Galen Charlton [Tue, 21 May 2013 19:00:13 +0000 (15:00 -0400)]
LP#1182360: typo fix

Signed-off-by: Galen Charlton <>
7 years agoDatabase upgrade script for 2.2.9
Lebbeous Fogle-Weekley [Thu, 16 May 2013 20:12:14 +0000 (16:12 -0400)]
Database upgrade script for 2.2.9

Signed-off-by: Lebbeous Fogle-Weekley <>
Signed-off-by: Bill Erickson <>
7 years ago2.3.6 -> 2.3.7 DB upgrade script
Bill Erickson [Thu, 16 May 2013 19:52:38 +0000 (15:52 -0400)]
2.3.6 -> 2.3.7 DB upgrade script

Signed-off-by: Bill Erickson <>
Signed-off-by: Lebbeous Fogle-Weekley <>
7 years agoCorrect subfield format for authority lookup
Mike Rylander [Fri, 19 Apr 2013 20:14:13 +0000 (16:14 -0400)]
Correct subfield format for authority lookup

The Authority Control Set code expects the format of subfields
that it will be used to build a MARC.Field object to be of the
form: [[code,value],...]  This commit makes that true.

Additionally, dojo.filter over a list of lists can cause the
nested array set to be flattened.  So, instead, we loop directly.

Signed-off-by: Mike Rylander <>
Signed-off-by: Bill Erickson <>
7 years agoRepair faulty MARC editor authority validation
Bill Erickson [Thu, 16 May 2013 13:11:50 +0000 (09:11 -0400)]
Repair faulty MARC editor authority validation

Repair how the JS inspects the results of, which is
used to look up matches for authority validation.  It returns a more
complex structure in the brave new world of authority control sets.

Signed-off-by: Bill Erickson <>
Signed-off-by: Mike Rylander <>
7 years agoApply all 2.2 upgrades prior to running 2.3.0 upgrade
Dan Scott [Tue, 29 Jan 2013 16:04:33 +0000 (11:04 -0500)]
Apply all 2.2 upgrades prior to running 2.3.0 upgrade

If users are expected to run all of the 2.2 upgrade scripts, then let's
make it easy for them. As PostgreSQL 9.1 does not include the \ir
"include relative path" command, we have to pause at the beginning of
the upgrade process to ensure that the user is running the script from
the right directory.

Signed-off-by: Dan Scott <>
Signed-off-by: Lebbeous Fogle-Weekley <>
8 years agoLP#118066: fix searches that failed because punctuation was a token in query
Galen Charlton [Tue, 14 May 2013 19:33:54 +0000 (15:33 -0400)]
LP#118066: fix searches that failed because punctuation was a token in query

When building the text array literal to pass to evergreen.rel_bump,
make sure that tokens that get {search_}normalize{d} away
don't result in syntax errors.

With this patch, searches like the following will work again:

keyword:Take me to the river / Al Green and Mabon

Signed-off-by: Galen Charlton <>
Signed-off-by: Lebbeous Fogle-Weekley <>
8 years agoLP1179614 - fix Export All Records action
Ben Shum [Mon, 13 May 2013 18:19:06 +0000 (14:19 -0400)]
LP1179614 - fix Export All Records action

In the record buckets, the button for 'Export All Records' would work up
to the point where you chose where to save the file. After clicking where
to save, it would not show any saved files or prompts indicating it completed
the export process.

This fix changes the location of where to find the export tool and properly
exports the bibs as the file format selected.

Signed-off-by: Ben Shum <>
Signed-off-by: Galen Charlton <>
8 years agoSerials: MFHD::get_compressed_holdings() can reach infinite loop
Lebbeous Fogle-Weekley [Mon, 6 May 2013 18:15:18 +0000 (14:15 -0400)]
Serials: MFHD::get_compressed_holdings() can reach infinite loop

Even controlled serials holdings involve the internal creation of MFHD
fields, upon which caculations are performed for such purposes as the
display of holdings summaries in the OPAC.

There are too many ways that incorrect MFHD (or MFHD that our code just
can't yet handle) can lead our MFHD routines to crash. We can't address
all these possibilities in a single bug fix. But we can avoid this
infinite loop.

A subroutine within open-ils.serial (_summarize_contents()) relies on
MFHD::get_compressed_holdings(). When the latter went into an infinite
loop the result would be an open-il.serial drone process consuming CPU
time indefinitely and, depending on the data that provoked the loop,
potentially writing repeating messages to stderr indefinitely.

End users will still see the item receiving fail in these cases, and be
obliged to work around the issue as before until more robust
holdings summarization code can be written, but at least the overall
condition of the running Evergreen system won't be affected, and there
will be better information in the error logs.

Signed-off-by: Lebbeous Fogle-Weekley <>
Signed-off-by: Remington Steed <>
Signed-off-by: Dan Wells <>
8 years agoSerials: Test method to identify holdings that lead to summarization bugs
Lebbeous Fogle-Weekley [Mon, 6 May 2013 18:13:13 +0000 (14:13 -0400)]
Serials: Test method to identify holdings that lead to summarization bugs

This adds a simple test method that allows testing of problem holdings.
See the next commit.

Signed-off-by: Lebbeous Fogle-Weekley <>
Signed-off-by: Remington Steed <>
Signed-off-by: Dan Wells <>
8 years agoLP#1176206: improve deadlock handling in
Galen Charlton [Fri, 3 May 2013 21:20:21 +0000 (17:20 -0400)]
LP#1176206: improve deadlock handling in

- make sure that it doesn't attempt to create more than one
  index at a time for a given table
- if deadlocks occur (because of a PostgreSQL bug whose fix
  isn't slated for release until after April 2013), find
  and recreate the affected indexes.

Signed-off-by: Galen Charlton <>
Signed-off-by: Dan Scott <>
8 years agoExports are broken
Mark Cooper [Mon, 6 May 2013 19:37:32 +0000 (12:37 -0700)]
Exports are broken

Proposed fix for lp1175816, tested with 2.3.2 / 2.4.0.

Signed-off-by: Mark Cooper <>
Signed-off-by: Galen Charlton <>
8 years agoAdd params support to show in opac function
Thomas Berezansky [Sun, 7 Oct 2012 15:58:37 +0000 (11:58 -0400)]
Add params support to show in opac function

Signed-off-by: Thomas Berezansky <>
Signed-off-by: Ben Shum <>
8 years agoLP#1175287: make sure tsearch2 is removed, regardless of its origin
Galen Charlton [Wed, 1 May 2013 20:33:39 +0000 (16:33 -0400)]
LP#1175287: make sure tsearch2 is removed, regardless of its origin

A sufficiently old Evergreen database might still have tsearch2
exist as an unpackaged contrib, so convert it to an extension first.

Signed-off-by: Galen Charlton <>
Signed-off-by: Mike Rylander <>
8 years agoadjust release notes references to refer to 2.4.0
Galen Charlton [Wed, 1 May 2013 21:35:30 +0000 (17:35 -0400)]
adjust release notes references to refer to 2.4.0

Signed-off-by: Galen Charlton <>
Signed-off-by: Mike Rylander <>
8 years agoupdate upgrade instructions for 2.4.0 release
Galen Charlton [Wed, 1 May 2013 21:34:02 +0000 (17:34 -0400)]
update upgrade instructions for 2.4.0 release

- specify minimum supported PostgreSQL version as 9.1
- specify minimum supported OpenSRF version as 2.2.0
- update schema upgrade instructions and miscellaneous
  references to 2.3

Signed-off-by: Galen Charlton <>
Signed-off-by: Mike Rylander <>
8 years agorevisions to installation instructions
Galen Charlton [Wed, 1 May 2013 21:02:57 +0000 (17:02 -0400)]
revisions to installation instructions

- Remove references to PostgreSQL 9.0; 9.1 is recommended
  for Evergreen 2.4.
- Clarify that the latest version of OpenSRF now means 2.2
  or later.
- Increase chances that somebody following the instructions
  precisely doesn't run into a problem during the configure step.

Signed-off-by: Galen Charlton <>
Signed-off-by: Mike Rylander <>
8 years agoMake sure the "running" indicator goes away
Mike Rylander [Tue, 30 Apr 2013 15:26:00 +0000 (11:26 -0400)]
Make sure the "running" indicator goes away

Signed-off-by: Mike Rylander <>
Signed-off-by: Jason Etheridge <>
8 years agoAdd a $cache_timeout-based backstop for infinite loops
Mike Rylander [Fri, 26 Apr 2013 15:28:38 +0000 (11:28 -0400)]
Add a $cache_timeout-based backstop for infinite loops

Signed-off-by: Mike Rylander <>
Signed-off-by: Jason Etheridge <>
8 years ago"Queue Compression" -- let one do the work for all identical, concurrent searches
Mike Rylander [Fri, 26 Apr 2013 14:49:17 +0000 (10:49 -0400)]
"Queue Compression" -- let one do the work for all identical, concurrent searches

Signed-off-by: Mike Rylander <>
Signed-off-by: Jason Etheridge <>
8 years agoLP#1174359: follow-up on dropping the reporter.classic_item_list view
Galen Charlton [Wed, 1 May 2013 19:01:30 +0000 (15:01 -0400)]
LP#1174359: follow-up on dropping the reporter.classic_item_list view

Add note for the benefit of any Evergreen admin who may
need to recreate that view.  Also, update the point schema
update script.

Signed-off-by: Galen Charlton <>
8 years agoLP#1174359 Need to drop reporter.classic_item_list
Michael Peters [Mon, 29 Apr 2013 15:14:39 +0000 (11:14 -0400)]
LP#1174359 Need to drop reporter.classic_item_list

ERROR: cannot drop view metabib.full_rec because other objects depend on it
DETAIL: view reporter.classic_item_list depends on view metabib.full_rec
HINT: Use DROP ... CASCADE to drop the dependent objects too.

Beginning at line 55 of the upgrade script, several views and functions are dropped
so metabib.full_rec can be dropped. One of them is missing.

We need to drop reporter.classic_item_list as well, for the script to work.

Signed-off-by: Michael Peters <>
Signed-off-by: Galen Charlton <>
8 years agoImproved AC socket fix
Jason Stephenson [Wed, 1 May 2013 16:08:29 +0000 (12:08 -0400)]
Improved AC socket fix

This provides better coverage for socket shutdown needs, but intends
to fix the same issue as the previous commit.

Signed-off-by: Jason Stephenson <>
Signed-off-by: Mike Rylander <>
8 years agoShutdown added content sockets to prevent hung connections.
Jason Stephenson [Tue, 30 Apr 2013 17:23:24 +0000 (13:23 -0400)]
Shutdown added content sockets to prevent hung connections.

We were getting several thousand sockets hanging around in a
CLOSE_WAIT state on our server.  The connections were from our
server and to our server.  Further investigation showed it to be
caused by the stage2 added content lookup not closing the request
sockets when it was done reading data.  This branch fixes that.

Signed-off-by: Jason Stephenson <>
Signed-off-by: Mike Rylander <>
8 years agoLP1076411 Return updated circ object from checkin
Bill Erickson [Fri, 29 Mar 2013 13:41:44 +0000 (09:41 -0400)]
LP1076411 Return updated circ object from checkin

Retrieve an updated copy of the circulation object to return to the
caller during checkin.  This ensures the data in the circ object, in
particular date fields, are consistent with the database.

Signed-off-by: Bill Erickson <>
Signed-off-by: Ben Shum <>
8 years agoWhen adding errors from failed processing to acq.edi_message, set error_time
Lebbeous Fogle-Weekley [Wed, 3 Apr 2013 19:31:09 +0000 (15:31 -0400)]
When adding errors from failed processing to acq.edi_message, set error_time

This has obvious benefits in facilitating log analysis after a problem.

Signed-off-by: Lebbeous Fogle-Weekley <>
Signed-off-by: Ben Shum <>
8 years agoAdd accepting_usr to IDL to fix reporter field
Remington Steed [Thu, 14 Mar 2013 18:37:17 +0000 (14:37 -0400)]
Add accepting_usr to IDL to fix reporter field

In the reporter interface, the view 'Payments: Brick-and-mortar' is
missing the 'Accepting User' field, which is present in the similar view
'Payments: Desk'. This field is already present in the database view and
is simply missing from the IDL.  Since it is needed for certain kinds of
reports, this commit adds the missing IDL fields. It also adds the
missing 'reporter:datatype' to an existing instance of the IDL field.

Signed-off-by: Remington Steed <>
Signed-off-by: Ben Shum <>
8 years agoLP1170861 Remove unused lineitem alert field
Bill Erickson [Tue, 23 Apr 2013 15:47:37 +0000 (11:47 -0400)]
LP1170861 Remove unused lineitem alert field

Remove extraneous field from the IDL field list for acq lineitem alerts.
The extra field prevented new alerts from getting saved.

Signed-off-by: Bill Erickson <>
Signed-off-by: Kathy Lussier <>
Signed-off-by: Ben Shum <>
8 years agoLP1104823 - OPAC search results "Limit to available items" toggles
Kyle Tomita [Tue, 9 Apr 2013 20:51:14 +0000 (13:51 -0700)]
LP1104823 - OPAC search results "Limit to available items" toggles
off "Show more details"

Added a hidden input to the form when "Show more details" is selected
so that when the form is reloaded, "Show more details" will be still

Signed-off-by: Kyle Tomita <>
Signed-off-by: Ben Shum <>
8 years agoLP#1172893: fix query for retrieving available holds
Bill Erickson [Thu, 25 Apr 2013 15:54:40 +0000 (11:54 -0400)]
LP#1172893: fix query for retrieving available holds

Signed-off-by: Bill Erickson <>
Signed-off-by: Galen Charlton <>
Signed-off-by: Ben Shum <>
8 years agoAdd 2.4 release notes for Novelist Select changes.
Jason Stephenson [Tue, 23 Apr 2013 14:39:55 +0000 (10:39 -0400)]
Add 2.4 release notes for Novelist Select changes.

Signed-off-by: Jason Stephenson <>
8 years agoAdding 2.3-2.4RC upgrade script
Mike Rylander [Mon, 22 Apr 2013 19:04:07 +0000 (15:04 -0400)]
Adding 2.3-2.4RC upgrade script

Signed-off-by: Mike Rylander <>
8 years agoUnbreak make install for apache config files
Dan Scott [Mon, 22 Apr 2013 17:00:05 +0000 (13:00 -0400)]
Unbreak make install for apache config files

The new install process installs the Apache sample configs into the
DOCDIR for Evergreen, with the expectation that packagers will pick up
the examples from the doc directory and that users will eventually be
expected to copy them from there, rather than from the source tree.

However, currently the Apache 2.2 and 2.4 sample configs have the same
names, and that causes a conflict at "make install" time. Kudos to Jason
Stephenson for catching this. The temporary solution is to rename the
Apache 2.4 files to avoid the conflict; longer term, we need to teach
make install to only make & install the files that are pertinent to the
environment on which it was built (either Apache 2.2, or Apache 2.4).

Signed-off-by: Dan Scott <>
Signed-off-by: Jason Stephenson <>
8 years agoUpdating PO files from LaunchPad
Mike Rylander [Mon, 22 Apr 2013 14:17:46 +0000 (10:17 -0400)]
Updating PO files from LaunchPad

Signed-off-by: Mike Rylander <>
8 years agoFix version number in
Jason Stephenson [Sat, 20 Apr 2013 13:49:27 +0000 (09:49 -0400)]
Fix version number in

Signed-off-by: Jason Stephenson <>
Signed-off-by: Ben Shum <>
8 years agoAdd missing [% in prefs_settings.tt2.
Jason Stephenson [Sat, 20 Apr 2013 13:28:37 +0000 (09:28 -0400)]
Add missing [% in prefs_settings.tt2.

Signed-off-by: Jason Stephenson <>
Signed-off-by: Ben Shum <>
8 years agoLP#1162907: install RPC::XML as Evergreen dependency
Galen Charlton [Fri, 5 Apr 2013 03:45:14 +0000 (23:45 -0400)]
LP#1162907: install RPC::XML as Evergreen dependency

RPC::XML used to be installed as part of installing
the OpenSRF deps, but since OpenSRF itself doesn't
use it, this belongs in Evergreen.

Signed-off-by: Galen Charlton <>
Signed-off-by: Mike Rylander <>
8 years agoRepair too-timid hold targeter (it misses copies at other org units)
Lebbeous Fogle-Weekley [Fri, 19 Apr 2013 19:23:05 +0000 (15:23 -0400)]
Repair too-timid hold targeter (it misses copies at other org units)

The patch to address bug 1162989 overreached.  Whereas before that
patch, the hold targeter was wont to target copies with unholdable
statuses, after the patch the hold targeter got the statuses right but
undesirably filtered out copies whose circ_lib doesn't match the hold
pickup lib.  This again probably stems from the differences between
FulfILLment's hold targeter and Evergreen's in the context of merging
the calculated proximity code.

This patch should resolve the issue.

Signed-off-by: Lebbeous Fogle-Weekley <>
Signed-off-by: Kathy Lussier <>
Signed-off-by: Mike Rylander <>
8 years agoStamping best-hold-order update script
Mike Rylander [Fri, 19 Apr 2013 20:19:11 +0000 (16:19 -0400)]
Stamping best-hold-order update script

Signed-off-by: Mike Rylander <>
8 years agoFix various Traditional and holds-go-home best-hold sort orders
Lebbeous Fogle-Weekley [Wed, 3 Apr 2013 20:35:51 +0000 (16:35 -0400)]
Fix various Traditional and holds-go-home best-hold sort orders

Use copy's call number's owning_lib instead of copy's circ_lib

    Should compare checkin lib to copy's (call number's) owning_lib, not
    hold request lib.

    You might think the comparison should be to acp.circ_lib, but that
    doesn't work with floating copies (for non-floaters, acp.circ_lib
    should be equal to acp.call_number.owning_lib).

approx is a more correct first determinant to give the behavior sites
are used to.

    hprox can cause copies to be too eager to go home when
    there are holds with that copy's circ lib as its request lib (if that's
    what you want, then you do pick or create a sort-order with hprox near
    the top).

Address a problem in the copy_has_not_been_home CTE.
    This expression was always meant to provide a TRUE or FALSE value as its
    lone result, but would return NULL in cases where copies had no transit

Use pickup_lib, not request_lib, as the determinant of
    nearness-to-home.  request_lib was used with the thinking that an item's
    "owning" patrons should have their wishes favored at holds-go-home time,
    even if where they wanted to send the copy was not actually home, but
    that's neither necessarily desired nor very intuitive.

Clear up holds-go-home logic with better code AND add TechRef
documentation with diagram in attempt to be as clear as possible.

Signed-off-by: Lebbeous Fogle-Weekley <>
Signed-off-by: Mike Rylander <>