Bill Erickson [Thu, 21 Jun 2012 13:07:18 +0000 (09:07 -0400)]
kpac : better wording for the Save It dialog
This removes any mention of selecting a location, which is not needed
for saving items to lists. It also adds some language about saving
items to existing lists.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Tue, 29 May 2012 14:01:25 +0000 (10:01 -0400)]
kpac : hide font-size image/link pending design
Will need to get some input on how this action should behave. My
personal pref. is to use the browser's page zoom behavior, since it's
the only way to truly resize everything in the page.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Tue, 29 May 2012 13:48:45 +0000 (09:48 -0400)]
kpac : hide font-size image/link pending design
Will need to get some input on how this action should behave. My
personal pref. is to use the browser's page zoom behavior, since it's
the only way to truly resize everything in the page.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Wed, 23 May 2012 15:44:28 +0000 (11:44 -0400)]
kpac : global filter config option
Allows for configuration of an always-on global search filter. All
searches, regardless of origin, in the kpac will be appended by this
filter when configured.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Tue, 17 Apr 2012 14:35:43 +0000 (10:35 -0400)]
EGWeb trim template paths to unique set
The list of template paths may have the same path added multiple times,
depending on the Apache configuration. Trim them down to a unique set
to avoid excess template lookups.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGWeb.pm
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Mon, 30 Jul 2012 13:44:17 +0000 (09:44 -0400)]
TPAC advanced search org unit selector
Make the advanced search org selector a bit more i18n and accessibility
friendly by giving the fields an explicit label. We shouldn't really build
strings out of individual parts like "in" out of context, because the
translators won't know what "in" refers to; and the label elements help
guide screen readers.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Bill Erickson [Mon, 9 Apr 2012 19:45:49 +0000 (15:45 -0400)]
kpac : search link cgi improvements
1. avoid showing the search terms from canned searches in the simple
search box. Patrons, kids especially, probably don't want to see
potentially complicated canned search queries in the search box when the
whole point is that they are accessible by clicking on images.
2. Avoid propagating the search qtype param to canned searches.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Fri, 6 Apr 2012 20:32:13 +0000 (16:32 -0400)]
kpac : added content work
1. Consolidated added content apache configs under /eg
2. Added (untested) code to support LibraryThing reviews.
-- It looks like we'll need to coordinate w/ LT to get it all hooked
up. More research pending.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Fri, 27 Jul 2012 21:24:07 +0000 (17:24 -0400)]
Fix summary display in TPAC; avoid Content Cafe
While in misc_util.tt2 we're grabbing args.summary as a single string,
and args.summaries as the list of summaries, this gets complicated
elsewhere in the summaries display chain, where we're checking for the
number of list elements in "summary" (which is now a string), as well as
a confusion of logic where ContentCafe was being displayed whether or
not the environment variable existed.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Two new list fields. Adds the publication date and format to the My Lists
display in tpac.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
XULRunner/Firefox 4+ change the rules significantly, and to support them
significant changes have to be made in Evergreen.
This commit covers a number of things:
1 - Remote XUL Issues
Later versions of XULRunner disable support for Remote XUL without using a
whitelist entry, and whitelisting may stop working eventually as well. The
solution here is the addition of a new protocol wrapper that allows Remote
XUL to act like Local XUL.
The wrapper is oils:// and acts like HTTPS for the most part. The "host" the
client connects to is always "remote", however, and use of the wrapper has
multiple effects.
The first of these effects is the enabling of Remote XUL content, with as
close to the Local XUL security level as I could manage. This means that
nearly anything Local XUL can do, Remote XUL should be able to do too.
The second of these effects is the disabling of JavaScript-visible cookies.
XUL doesn't have cookies, and as such a side effect of the wrapper allowing
remote content to appear to be local content is the lack of cookies. This
does *not* affect server side visibility of cookies, however, so things like
TPac can still see cookies. This required fixing a lot of places that were
built to read data like authtokens out of cookies.
The third of these effects is the "hiding" of the hostname for anything
going through the wrapper. This prevents oils_persist from saving things
correctly. I thus made oils_persist check for the wrapper and use the data
stash to get the hostname instead. I suspect that we can get rid of the
location.hostname check entirely at this point, but have not done so.
The wrapper also sets a request header of OILS-Wrapper, value of 'true'.
That allows the server to know that the request came through the wrapper. I
used that ability to have TPac go into "Staff" mode when the wrapper is in
use. This will enhance extension use, where the same authtoken will be seen
by both the staff client and Firefox browsing.
I willi also note that I rigged the wrapper to be easily adjusted for a
second, hard-coded host for selfcheck use, using oils://selfcheck instead of
oils://remote, that could be very easily turned into a minimal Firefox
extension. That would enable the selfcheck code to have permission to work
with printers and such without enablePrivilege (see next section).
2 - enablePrivilege Deprecation
The enablePrivilege security model has been removed and no longer functions,
and the staff client depended heavily upon it.
The Remote XUL fix provided us with a way to fix the enablePrivilege issues,
however. Because the Remote XUL has the Local XUL security context it
doesn't need enablePrivilege anymore. However, because enablePrivilege no
longer functions for those things *not* loaded through the wrapper some
things had to be changed.
For one, because if you are loaded through the wrapper you can't see
cookies, and if you can see cookies you can't do "XUL" things, the "XUL"
cookie has been removed. However, the wrapper can be detected by the
protocol you are using, so I added protocol checking to the isXUL checks I
know of. I am unsure about what, if anything, to do about the IAMXUL flag
that is set by the browser code, though.
For two, the JavaScript OPAC needs to be passed through the wrapper for some
staff functions to work currently. This has the additional side effect of
effectively forcing SSL mode for JSPac regardless of other settings.
For three, I went ahead and removed all enablePrivilege calls I could find
outside of the selfcheck code. As they no longer work they were just extra
cruft.
3 - Component changes
Component loading has changed significantly, and the easiest way to
accommodate the changes was to re-write our components. The command line
handler and force external components (the latter from another branch of
mine) were simple enough, especially as they aren't interacted with by other
code in the system (and as I wrote them I understood them anyway). While I
was at it I made the force external component more extension-friendly.
The data stash, however, was using a hack to accomplish what a singleton
component could do more easily. That and I couldn't get it to function as
it was. My solution was to re-write it as a singleton, removing the
interface definition that was not needed. As I changed how it functioned so
significantly I had to update all calls to it.
In addition, I hid a window loading routine in the data stash component for
easier loading of a *single* main Evergreen window from the Firefox
overlays.
4 - Extension changes
First off, Venkman, the DOM Inspector, and Chrome List are not guaranteed
compatible with XULRunner anymore. As such, I have removed the out of date
versions. Instead, I have added routines for loading Venkman and the DOM
Inspector as Extensions. This keeps them easy to update to later versions,
and makes us play much nicer when we are an extension. Also, now the
buttons/menu items for loading these interfaces disable themselves if the
extensions don't appear to be loaded.
A side effect of that was that Windows installers compressed with zlib were
unhappy. I switched to solid lzma, which in theory will get us smaller file
sizes too.
Secondly, Extensions have changed significantly in Firefox 4+, and Evergreen
had to be adjusted to deal with some of the changes. I adjusted the overlay
to take into account the new application menu, and I re-wrote the hotkey set
loading routines to deal with the fact that extensions don't get extracted
by default.
5 - Staff Client Build Process
XULRunner has some changes that needed accounting for, such as a root level
chrome.manifest being needed. Extension mode, as mentioned above, needed
tweaks as well, and other issues were run into along the way. Both XULRunner
and Firefox version support has been extended to 14.* and the base XULRunner
download has been bumped to 14.0.1.
In addition to the changes needed to support later XULRunner versions, I
also included alternate application name support and support for OS-specific
branding folders. Mainly because I ended up using all of them in testing,
and decided to leave them in afterwards.
6 - Miscellaneous fixes
MARC View was building a data URL and dumping it into an attribute without
escaping it. Apparently this made XULRunner unhappy, so I added in escaping.
7 - Miscellaneous tweaks
In addition to everything else, while I was running through my various tests
I changed a few other things.
I enabled the navigation buttons on the OPAC interface embedded in the
patron overview for hold placement. With Remote XUL having the same security
context as Local XUL they now work.
I removed all non-SSL authtoken cookie assignments I could find, and flagged
all the SSL ones I could find as being "secure" cookies. On the subject of
cookies, I also told the logoff code to not erase every cookie, as those
running in extension mode might dislike all cookies going away. I know that
during my testing I disliked it, anyway.
I removed the code that messes with the user agent. Extensions are basically
not allowed to do that, and I don't think we need, or should rely on, a
modified user agent elsewhere, so adding a check specifically for when we
are not an extension didn't make a lot of sense to me.
I also made it so that the automatic login command line options will work
after a logoff (but they won't trigger a logoff) during a testing run where
I was logging off, clearing cache, and logging in again repeatedly.
To deal with CSS changes I changed most (but not all) popup elements to
menupop elements. Popups in later XULRunners are transparent by default.
Also for CSS changes, a menubar CSS entry in global.css was causing issues
with menu visibility on Linux. Things look fine without it, so I went ahead
and removed it outright.
In the reporter I found that "class" was being used as a variable name, but
that is a reserved keyword. I changed it to aClass.
To make things easier for url_prefix use I made it so that the urls hash is
checked by the url_prefix function. It looks for names up to the first of
several characters: /, ?, |. If urls contains that name it is replaced into
place. For | the | itself is removed in this process.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Sat, 17 Mar 2012 01:49:45 +0000 (21:49 -0400)]
Add an XML pretty printer database function
Andrew Dunstan was kind enough to share an XML pretty printer function
for PostgreSQL, and it sure is handy when you're debugging things like
in-database unapi and MARCXML.
Note that it expects honest-to-goodness XML data type input, so for
biblio.record_entry.marc columns you'll need to cast it from TEXT.
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Dan Wells [Tue, 24 Jul 2012 16:39:49 +0000 (12:39 -0400)]
TPAC: Fix org_unit location detection for login
The TPAC login function currently looks for a 'loc' param to pass
to the login service. This isn't right because:
A. 'loc' is a search-related param, and shouldn't affect logins
B. The login form doesn't actually pass through the 'loc' param
C. The 'loc' param has been more or less replaced by 'locg'
No, this isn't multiple choice, it's all of the above. Our best
option at this point is to use the 'physical_loc' value instead.
This matches what was done in JSPAC (though it was called 'ol' for
"original location" back then).
Finally, this commit is 95% the work of Dan Scott, including the
additions of logging info and a few whitespace fixes.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Dan Scott <dan@coffeecode.net>
Dan Scott [Fri, 27 Jul 2012 20:27:29 +0000 (16:27 -0400)]
Use MARC::Field objects to append new fields
While the deprecated MARC::Record::add_fields() method allows you to add
a list of fields using a list object, append_fields() requires
MARC::Field objects.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Triggered Event Log: Add title and author columns for hold-related events
Correcting an omission spotted by Sally Fortin.
NOTE: This adds pcrud as a controller to ahr. Only the retrieve
operation is allowed at this time, and only with a VIEW_HOLD permission
at the pickup lib (same setup as ahopl, the class powering the new pull
list).
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Tue, 24 Jul 2012 18:14:01 +0000 (14:14 -0400)]
Switch to a PLPERLU maintain_901() trigger function
We've been burned by regexes that fail to grok XML properly numerous
times now. Standardizing on something that actually understands MARC
seems like a good idea.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Mike Rylander <mrylander@gmail.com>
The regex used to insert the 901 field can put the new
field in the wrong location if the MARCXML record being
modified uses namespace prefixes. This patch tightens
the regexp to avoid this problem.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Thu, 26 Jul 2012 14:45:25 +0000 (10:45 -0400)]
Get the TPAC basic link inline for <noscript>
The TPAC basic link appeared outside the <p> tag inside the <noscript>
section of the JSPAC, meaning that it would display on the far left
border of the screen rather than right after the colon. Fix that by
getting it inline.
Also apply a style to the link so it appears as some kind of a link.
What kind of madman overrode the basic <a> element style to make it
appear as plain text by default in the first place? :P
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Scott [Wed, 25 Jul 2012 16:45:27 +0000 (12:45 -0400)]
Add evergreen.get_locale_name() function to base schema
I added the evergreen.get_locale_name() function to the database schema
upgrades in 0723 but failed to add it to the base schema, resulting in
errors like: 'egweb: template error: undef error - Can't call method
"maketext"'. Get rid of that problem!
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
This is the result of a bug in the code that went unnoticed until c108746532548fd8d3fadd15736375a57208d485 (CGI.js additions). This patch
repairs how Vandelay checks the CGI param to determine if it should
load the 'inspectq' page on load.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Scott [Fri, 20 Jul 2012 17:41:50 +0000 (13:41 -0400)]
TPAC: Decode translated strings into UTF8
Without the _decode pragma, Locale::Maketext::Lexixcon did not
understand that it was being handed Unicode and generated some funky
output in the TPAC templates.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Scott [Tue, 17 Jul 2012 21:37:54 +0000 (17:37 -0400)]
TPAC: Implement a locale picker
In situations in which more than a single locale is configured, display
a locale picker in the TPAC header based on the registered locales. We
set the eg_locale cookie if passed a set_eg_locale GET param. Default
the selection to the currently selected locale (if any) and resubmit the
current page request.
Grabs the localized locale names, if available, from the database;
otherwise falls back to the en-US version of the locale names.
The locale picker form resubmits the current page with any variables
that were present in the current page request, so that switching locales
should still maintain state.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Steven Chan [Wed, 18 Jul 2012 18:22:14 +0000 (11:22 -0700)]
Fix LP800480, ACQ - Vendor Invoice Won't Save
1. Upon submitting the form, the client prepares two auxiliary data
objects containing service charges and line items. The two objects are
normally 'fleshed', ie, contain references to other data objects, but in
the versions sent to the server, they must be 'unfleshed', ie, the
referent objects are converted back to ID values. If the user resubmits
the form, the client should not unflesh again. However, the software for
preparing line items contain lines of code that unfleshes without
checking if the objects are already unflesh. When unfleshing a second
time, we get an uncaught reference error. Ironically, the software also
contains lines of code to do it correctly, so the errant lines of code
are also duplicates.
To fix problem 1, we remove the duplicate errant lines of code. We
define a helper unflesh() method and use it to replace the current lines
of code to unflesh.
2. When the user submits the form without filling in required data
fields in the invoice, including Vendor Invoice ID, the client does not
validate before making a service request. The server tries to complete
the database transaction, but gets an error. When the response comes
back, the client shows the same form so that the user can retry.
However, the message alert to the user is not informative; it indicates
an error at the database level, but does not indicate the probable
reason.
To fix problem 2, We move the lines of code preparing the invoice object
earlier in the sequence. We define a helper method mapValues() to
prepare the invoice object from the values in the UI widget object.
mapValues() will return an error object if it detects that required
values are null. We check for the error object, and will show an alert
message to the user and abort the submit operation early, allowing the
user to retry.
3. When an invoice with line items is saved, the invoice is re-rendered
with new buttons to allow receiving. It also contains a new button to
enable the user to view the line items in list format. However, it does
not work in a non-Firefox browser, because a debug statement using the
'dump()' function is left uncommented. (Inspection of all other
appearances of dump() show they are all commented out.) There is an
uncaught reference because dump() is not found.
Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Mon, 9 Jul 2012 18:46:41 +0000 (14:46 -0400)]
Batch lineitem create / link-to invoice action
In the PO lineitem list page and lineitem search restuls page, there
are two new actions in the top-level actions selector: "Create Invoice
from Selected Lineitems" and "Link To Invoice for Selected Lineitems".
Both behave the same as create/link invoice for single lineitems, but
now it's possible to select multiple lineitems for invoicing.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
projects / working / Evergreen.git / log