working/Evergreen.git
7 years agoFix backdate near DST changes
Thomas Berezansky [Fri, 2 Nov 2012 13:53:30 +0000 (09:53 -0400)]
Fix backdate near DST changes

When the due date and the backdate date are on opposite sides of a DST
boundary we were getting an hour off on the checkin time (using the
original due date's time).

This commit changes it so that instead we just set the hour and minute
values on the backdate date to the due date's versions, leaving the time
zone alone.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoLP#1098669: improve handling of Content Cafe external content in staff client
Galen Charlton [Fri, 11 Jan 2013 18:11:48 +0000 (13:11 -0500)]
LP#1098669: improve handling of Content Cafe external content in staff client

This patch introduces a new TPac content variable, ctx.ext_proto, to
specify whether external content should be retrieved via HTTP or HTTPS.
ctx.proto can't be used for that purpose since it's set to 'oils' when
TPac is running inside the staff client.

This fixes a bug where Content Cafe reviews wouldn't display in the staff
client bib record page and where clicking on the reviews link from search
results would open an empty window.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years ago2.3 Release notes update
Bill Erickson [Tue, 15 Jan 2013 19:08:03 +0000 (14:08 -0500)]
2.3 Release notes update

Merge the edireader and edi_order_template release notes into the 2.3
release notes files.  Added a blurb to the Upgrade Notes regarding the
lack of an automatic EDI template upgrade.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoACQ invoice search persistence repaired
Bill Erickson [Mon, 1 Oct 2012 15:54:00 +0000 (11:54 -0400)]
ACQ invoice search persistence repaired

Use XUL cookieService / cookieManager for managing cookies in embedded
web pages, since dojo.cookie cannot manage cookies within xulrunner.

Persist cookies for 30 days.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoDocs: minor formatting fixes for "borrowing items" chapter
Dan Scott [Tue, 15 Jan 2013 03:39:51 +0000 (22:39 -0500)]
Docs: minor formatting fixes for "borrowing items" chapter

* Images need to have a trailing [] ; ideally this would contain the
  alt text for the image, but the [] is needed to make the images
  show up at all
* Since we're touching the image:: tags anyway, make the filename
  extensions consistently lower case
* Fix a processing error; a bulleted list item wrapped so that > was the
  first character on a line, which made Asciidoc angry. Easiest thing to
  do to avoid this is just to indent the wrapped lines for each bullet
  item, but we'll do the minimal thing and just indent this one line
  this time.
* Fix one instance of Word "smart quotes" having replaced ye olde single
  quotes.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoBorrowing items: who, what, for how long
Kathy Lussier [Tue, 15 Jan 2013 02:43:57 +0000 (21:43 -0500)]
Borrowing items: who, what, for how long

Adding Borrowing Items chapter from Evergreen in Action to the official
docs.`

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoEDI order template improvements (no SQL upgrade script!)
Bill Erickson [Tue, 11 Sep 2012 16:41:08 +0000 (12:41 -0400)]
EDI order template improvements (no SQL upgrade script!)

Improved template for EDI purchase orders.  This theoretically just
works better where the old template worked.  Corrections made for
interactions with ULS, Midwest Tape, Baker & Taylor, and Recorded Books
especially.  GIR segments in the right place.

And also the template is just more maintainable now.

**THERE IS NO UPGRADE SCRIPT INCLUDED**.  Sites using EDI may not
necessarily want to mess with what they already have working.

If you want the changes, and maybe you do, especially if you're doing
enriched ordering and/or ordering from the vendors listed above, you can
extract the template changes easily enough yourself from the
950.data.seed-values.sql file.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoUpgrade script numbering for edireader branch
Lebbeous Fogle-Weekley [Mon, 14 Jan 2013 21:59:12 +0000 (16:59 -0500)]
Upgrade script numbering for edireader branch

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoEDIReader release notes
Bill Erickson [Wed, 26 Dec 2012 21:27:38 +0000 (16:27 -0500)]
EDIReader release notes

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoHandle cancelled (back-order) lineitems in EDI invoice
Bill Erickson [Thu, 13 Dec 2012 14:44:55 +0000 (09:44 -0500)]
Handle cancelled (back-order) lineitems in EDI invoice

Receiving an invoice for a cancelled lineitem mean the lineitem is no
longer cancelled.  Identify such lineitems and uncancel them along with
the requested number of not-yet-invoiced copies.

This work flow is common for back-order items.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoEDIReader: improve monetary regexes
Bill Erickson [Wed, 12 Dec 2012 17:50:47 +0000 (12:50 -0500)]
EDIReader: improve monetary regexes

Make no attempt to enforce/decipher monetary amounts in the regexes,
simply capture the values.  If they are invalid, Postgres will let us
know.

This change allows us to capture non-numeric (\d) characters (e.g. "."),
which are of course common in monetary amounts.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoEDI invoice date; invoice paid quantity/amount
Bill Erickson [Wed, 5 Dec 2012 14:34:00 +0000 (09:34 -0500)]
EDI invoice date; invoice paid quantity/amount

* capture the invoice date in EDIReader
* apply the invoice date to inbound invoices when available instead of
  defaulting to 'now'
* apply the quantity/amount billed to the quantity/amount paid to reduce
  staff data entry needs

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoEDI: ensure lineitem 'state' matches cancel state
Bill Erickson [Tue, 4 Dec 2012 15:00:26 +0000 (10:00 -0500)]
EDI: ensure lineitem 'state' matches cancel state

When cancelling a lineitem becuase all linked copies are cancelled,
ensure that the lineitem state is set to "cancelled".

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoEDI response honor lineitem-level status; debit cleanup
Bill Erickson [Mon, 3 Dec 2012 19:51:41 +0000 (14:51 -0500)]
EDI response honor lineitem-level status; debit cleanup

* Honor lineitem-level order status info (FTX+LIN) which indicates, in
  some cases, that all ordered copies should be cancelled because the LI
  as a whole is cancelled

* Delete fund debits for cancelled lineitem details when appropriate

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoEDI: protect against invalid order response
Bill Erickson [Mon, 3 Dec 2012 14:20:29 +0000 (09:20 -0500)]
EDI: protect against invalid order response

Do not attempt to createI EDI messages for order responses which
reference nonexistent purchase orders, since it results in
transaction commit errors on invalid foreign keys, preventing
subsequent EDI files from getting processed.  Instead, log it
and skip it.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoEDIReader : detect SAN vs. account number in buyer/seller
Bill Erickson [Mon, 12 Nov 2012 14:35:53 +0000 (09:35 -0500)]
EDIReader : detect SAN vs. account number in buyer/seller

NAD+BY+XXXXXXX::31B' -- SAN
NAD+BY+YYYYYYY::91' -- Account number

For invoices, try the SAN first followed by the account number to
determine the receiving org unit.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoCustom/local EDI reader module for ORDRSP and INVOIC (etc)
Bill Erickson [Fri, 28 Sep 2012 14:34:28 +0000 (10:34 -0400)]
Custom/local EDI reader module for ORDRSP and INVOIC (etc)

Provides a new perl module (OpenILS::Utils::EDIReader) for reading
inbound EDI messages and producing data structures more easily
understood by the ACQ code.  Through this, extraction of EDI data is
focused in one module instead of spread through various layers.

EDIReader is a small, purpose built module focusing solely on extracting
the needed EDI data and is not meant to be a general purpose EDI library.

* Updates edi_fetcher and the ORDRSP and INVOIC handling code to use the
  new libs.

* Removes Business::EDI Evergreen dependency, since it's no longer used (and
  is quite large).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoFix a data destruction bug when authorities are updated.
Jason Stephenson [Fri, 11 Jan 2013 13:49:11 +0000 (08:49 -0500)]
Fix a data destruction bug when authorities are updated.

Modify the two-argument form of vandelay.merge_record_xml to return
the target_marc when the add_rule, preserve_rule, replace_rule and
strip_rule are all empty.

This method is used by authority.propagate_changes and would replace
the bibliographic record's marc with the overlay template when the
above would happen. By returning the biblographic record entry's own
marc in that case, we prevent data destruction.

Additionally, protect bib and authority template overlay functions
in the same manner.

Commit includes an upgrade script for this change as well as
for the previous commit's authority.generate_overlay_template fix.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoOnly consider main entry headings for bib overlay
Mike Rylander [Thu, 10 Jan 2013 21:35:44 +0000 (16:35 -0500)]
Only consider main entry headings for bib overlay

Restrict the authority fields we will pull overlay data from to those
that do not subordinate themselves to other authority fields.  That
is, skip see-from/see-also/etc for bib overlay.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoLP #1075167: Serials: Avoid infinite loop in holdings summarization
Lebbeous Fogle-Weekley [Wed, 9 Jan 2013 21:20:39 +0000 (16:20 -0500)]
LP #1075167: Serials: Avoid infinite loop in holdings summarization

When receiving items with unworkable combinations of holdings and
patterns, the holdings summarization code can get stuck in an infinite
loop.  This solution prevents that, sparing the open-ils.serial
process and server resources, although it doesn't help the user out.

It will take further examination of the problem and reĆ«valution of how
we deal with problems reported by OpenILS::Utils::MFHD to help the
user avoid or resolve these situations.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoAdding Designing Your Catalog chapter from the Evergreen In Action manual.
Kathy Lussier [Sun, 6 Jan 2013 03:01:54 +0000 (22:01 -0500)]
Adding Designing Your Catalog chapter from the Evergreen In Action manual.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Minor fixes to "Designing your catalog" chapter

Some strange Latin-1 characters were giving Asciidoc fits...

Signed-off-by: Dan Scott <dan@coffeecode.net>
7 years agofix user session management for MARC Batch Edit
Galen Charlton [Fri, 4 Jan 2013 19:33:28 +0000 (14:33 -0500)]
fix user session management for MARC Batch Edit

The Javascript in the hardcoded page templates was
not checking the XUL stash for the session key when
run from the staff client; this is now needed as
a result of the XULRunner updates introdued by
commit adee850f.

As a consequence, the list of the user's record buckets
was not retrieved, and attempts to run a batch edit
would spin without updating any records.

This fixes LP#1048707 and LP#1054277.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoDocumentation: Update upgrade instructions.
Robert Soulliere [Thu, 3 Jan 2013 19:23:54 +0000 (14:23 -0500)]
Documentation: Update upgrade instructions.

Also add a few index terms.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
7 years agoSIP option to use SIP date format for due dates
Bill Erickson [Wed, 26 Dec 2012 16:10:23 +0000 (11:10 -0500)]
SIP option to use SIP date format for due dates

New SIP configuration option "use_sip_date_format" which forces all SIP
dates to be formated using the SIP date format: YYYYMMDDZZZZHHMMSS

Without this setting, most dates already correctly use the SIP date
format.  However, for some historical reason, due dates are formatted as
ISO 8601 dates.  Enable this setting to force due dates to use the SIP
date format.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoLP1092937 - fix title/author in alternate pull list
Ben Shum [Mon, 24 Dec 2012 01:46:02 +0000 (20:46 -0500)]
LP1092937 - fix title/author in alternate pull list

Clicking on Print Full Pull List (Alternate strategy) no longer showed
the title and author columns for hold pull lists.

It seems that adding quotes around the tag lookups was all that was
required to bring these back for now. Long-term, it still seems better
to continue moving towards fewer pull list interfaces.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoTPAC - SMS Number Munging
Thomas Berezansky [Tue, 2 Oct 2012 17:31:13 +0000 (13:31 -0400)]
TPAC - SMS Number Munging

Addresses LP bug 1016654 - Despite the hint telling users not to use
hyphens when entering a text notification number, we have patrons who
are entering the hyphens causing the text notification to fail.

Munge "pretty printed" numbers into raw sets of digits in the A/T helper.

This allows aliases to still work for services that support them.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoStamping upgrade script for index corporate authors
Ben Shum [Sun, 23 Dec 2012 20:38:43 +0000 (15:38 -0500)]
Stamping upgrade script for index corporate authors

Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoIndex corporate authors based on relator codes
Dan Scott [Tue, 30 Oct 2012 16:08:54 +0000 (12:08 -0400)]
Index corporate authors based on relator codes

The existing stock index for corporate authors only kicks in if the
710 subfield 'e' == 'creator', but relator codes (in subfield '4') are
by many accounts a preferred mode of identifying the relationship of an
added entry. Thus, add '4' == ('aut' or 'cre') to the criteria for
indexing a corporate author.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP 1088561 - part 2, fix all update forms to not show saved passwords
Ben Shum [Thu, 20 Dec 2012 19:32:46 +0000 (14:32 -0500)]
LP 1088561 - part 2, fix all update forms to not show saved passwords

Bug re-opened due to locating a few other locations in my account area
where the password was being saved by browsers like Firefox instead of
requiring users to key in current password to make changes.

This patch covers those two additional cases and changes the quoting
around the first case to be more consistent with the rest of the line.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Simon Mai <hieu.mai@mnsu.edu>
7 years agoTPAC: Fallback default value for facet.default_display_count
Dan Scott [Sun, 16 Dec 2012 14:09:03 +0000 (09:09 -0500)]
TPAC: Fallback default value for facet.default_display_count

Open-ILS/templates/opac/parts/result/facets.tt2 assigns the value of
facet.default_display_count to DEFAULT_DISPLAY_COUNT and then uses the
latter in a number of comparisons. facet.default_display_count is
expected to be defined in config.tt2; however, on upgrade, sites with
many override templates may not realize that they need to define that
value in config.tt2. If they do not, then the result is a strange facet
display where only the facet category header shows, with no facets, and
Apache error log messages like:

Argument "" isn't numeric in numeric gt (>) at
/openils/var/templates/opac/parts/result/facets.tt2 line 72.

This simple defensive fix assigns a fallback default value if one was
not provided in config.tt2

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoFacets should not be sticky when users click "Search"
Dan Scott [Sat, 22 Dec 2012 02:15:49 +0000 (21:15 -0500)]
Facets should not be sticky when users click "Search"

We were using a hidden form variable to track which facets were in use,
at the same time as relying on the GET params to actually display the
facets, and munging the links on the remaining facets to properly
add/subtract facets.

The result of the hidden form variable was that:

1) clicking the Search button would unexpectedly result in the facet
applying to the new search (wat)

2) applying two facets at once and then searching again would result
in the facet vars being treated as a raw array.

Thanks to Dan Pearl for inspiring this patch with his fix for the latter
problem, and Kathy Lussier's recognition of the basic problem.

Closes LP# 1092946 and 1091659.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoTest data copies get "checked out" copy status when circ'd
Bill Erickson [Fri, 21 Dec 2012 16:14:10 +0000 (11:14 -0500)]
Test data copies get "checked out" copy status when circ'd

Set the status to 1 (checked out) for items that are circulated as part
of the test data transactions load.  Otherwise, the data is busted and
renewals are not possible.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agolp1090867 Hide Fields undefined var error
Jason Etheridge [Fri, 21 Dec 2012 12:26:36 +0000 (07:26 -0500)]
lp1090867 Hide Fields undefined var error

This fixes the "Error in widget_prompt.js, my_init(): TypeError: offlineStrings
is undefined" error.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoCopy 2.3.1-2.3.2 SQL upgrade script into place
Bill Erickson [Thu, 20 Dec 2012 21:48:56 +0000 (16:48 -0500)]
Copy 2.3.1-2.3.2 SQL upgrade script into place

Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoCopy 2.3.0-2.3.1 SQL upgrade script into place
Bill Erickson [Thu, 20 Dec 2012 21:48:42 +0000 (16:48 -0500)]
Copy 2.3.0-2.3.1 SQL upgrade script into place

Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoMaster didn't get these two rel_2_2 series upgrade scripts
Lebbeous Fogle-Weekley [Thu, 20 Dec 2012 21:50:44 +0000 (16:50 -0500)]
Master didn't get these two rel_2_2 series upgrade scripts

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoUpdate "Adding a data source to the reporter" docs
Dan Scott [Thu, 20 Dec 2012 16:36:42 +0000 (11:36 -0500)]
Update "Adding a data source to the reporter" docs

A little bit of formatting clean-up, a little bit of extra information.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoTranslations update step 2: newpot
Bill Erickson [Thu, 20 Dec 2012 14:47:17 +0000 (09:47 -0500)]
Translations update step 2: newpot

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoTranslations update step 1: update profiles
Bill Erickson [Thu, 20 Dec 2012 14:36:56 +0000 (09:36 -0500)]
Translations update step 1: update profiles

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoConsistent permission filtering in ACQ search results
Bill Erickson [Fri, 14 Sep 2012 19:30:15 +0000 (15:30 -0400)]
Consistent permission filtering in ACQ search results

Add permission checks to search result objects when calling unified
search in 'idlist' mode, consistent with the existing permission checks
for non-id-list mode.  Without this, different forms of the call return
different sets of results.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoLP #1092179 FlattenerGrid Filter dialog lead to clobbering grid's base query
Lebbeous Fogle-Weekley [Wed, 19 Dec 2012 16:41:28 +0000 (11:41 -0500)]
LP #1092179 FlattenerGrid Filter dialog lead to clobbering grid's base query

You could see this in the Simplified Hold Pull List interface.  Using
the filter dialog would refresh the grid and populate it with rows
corresponding to your filters, but it would throw away your setting from
the context org dropdown (labeled "Show the pull list for..." there).

FlattenerGrid had a broken mechanism for trying to nicely mix a user's
input from things like context org dropdowns with whatever they put into
the filter dialog, and now that mechanism has been fixed.

This also means a tiny change to the User Event Log interface to react
to the slight change in FlattenerGrid's API.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP#1088561: remove current password (renew password issue with TPAC)
Simon Hieu Mai [Wed, 19 Dec 2012 20:33:54 +0000 (14:33 -0600)]
LP#1088561: remove current password (renew password issue with TPAC)

If a user chooses to have their browser remember their password for the
catalog, it can fill in the password to the change password form page
as hidden dots. This behavior was observed specifically with Firefox.

Instead, add autocomplete="off" attribute to the form to force users to
enter existing password to change to a new password as intended.

Signed-off-by: Simon Mai <hieu.mai@mnsu.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoAdd fi-FI to update_pofiles script
Pasi Kallinen [Tue, 18 Dec 2012 08:42:59 +0000 (10:42 +0200)]
Add fi-FI to update_pofiles script

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agopo-files for Finnish translation
Pasi Kallinen [Tue, 18 Dec 2012 08:41:28 +0000 (10:41 +0200)]
po-files for Finnish translation

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoMake config.update_coded_value_map() consistent
Dan Wells [Tue, 18 Dec 2012 20:51:12 +0000 (15:51 -0500)]
Make config.update_coded_value_map() consistent

The version of this function in the upgrade file is different than
the one in the 002.schema.config.sql file. This commit fixes the
broken logic in the 002 file and makes it match the logic in the
old upgrade file.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoCheck for a selection_depth returned from title_hold.is_possible.
James Fournie [Tue, 18 Dec 2012 20:45:51 +0000 (12:45 -0800)]
Check for a selection_depth returned from title_hold.is_possible.
See Launchpad 1064651 for details.  This is a quick fix which solves a
fairly serious issue whereby copies outside of a hard boundary could fill
holds when they are placed within the TPAC in the staff client.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoDojo IDL: Set the "Accept-Language" header
Dan Scott [Tue, 18 Dec 2012 13:52:55 +0000 (08:52 -0500)]
Dojo IDL: Set the "Accept-Language" header

The internationalization support for /reports/fm_IDL.xml keys off of the
Accept-Language header - which, if not set to ^[a-z]{2}-[A-Z]{2}$, falls
back to en-US. Setting the header in the dojo.xhrGet() request makes
Apache able to serve up the right flavour of /reports/fm_IDL.xml

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
7 years agoSet locale properly in Apache configuration
Dan Scott [Tue, 18 Dec 2012 12:39:18 +0000 (07:39 -0500)]
Set locale properly in Apache configuration

A RewriteCond only applies to the next RewriteRule, while our config was
attempting to apply multiple rules for a single condition. Fix that up
by using skip (S) rules to apply blocks of rules for the condition in
question.

Also, use the HTTP:Accept-Language value directly, rather than relying
on a backreference (which did not seem to be working as desired).

These fixes enable screens like the Register Patron interface to present
field labels from the IDL in the correct locale, whereas previously they
would always default to en-US.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
7 years agoLP#1078596: Cannot translate strings handled by fieldmapper
Pasi Kallinen [Sun, 2 Dec 2012 20:49:42 +0000 (22:49 +0200)]
LP#1078596: Cannot translate strings handled by fieldmapper

Strings that should be translatable only show up in English,
for example in the Patron Registration screen.

There's a bug in the fieldmapper where it sets a variable to
an empty array, but later in the code only checks whether that
particular variable exists, not if it's an empty array.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoSyndetics - retrieve summary as part of added content
Ben Shum [Wed, 28 Nov 2012 21:05:53 +0000 (16:05 -0500)]
Syndetics - retrieve summary as part of added content

As noted by Steve Callender in LP1027131, Syndetics added content is not
retrieving summary.html to be displayed in the catalog.

This change adds a function similar to toc/anotes to bring in summary data.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
7 years agoACQ: repair lineitem cancel-reason fleshing
Bill Erickson [Tue, 4 Dec 2012 16:04:08 +0000 (11:04 -0500)]
ACQ: repair lineitem cancel-reason fleshing

When fetching lineitems for display in the general lineitem list page,
if the lineitem is cancelled, be sure we correctly retrieve the
cancel-reason object.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoStamping upgrade script for frozen holds clear expire time
Ben Shum [Tue, 18 Dec 2012 06:00:07 +0000 (01:00 -0500)]
Stamping upgrade script for frozen holds clear expire time

Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP1076399: Prevent reactivated holds from expiring immediately.
Jason Stephenson [Wed, 14 Nov 2012 18:41:37 +0000 (13:41 -0500)]
LP1076399: Prevent reactivated holds from expiring immediately.

Clear the expire_time on deactivated holds.

Recalculate the expire_time when a hold is reactivated.

Upgrade script to set expire_time to NULL on frozen action.hold_requests.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoResolve LP893448: Prevent hold expiration in past.
Jason Stephenson [Wed, 14 Nov 2012 16:49:49 +0000 (11:49 -0500)]
Resolve LP893448: Prevent hold expiration in past.

If a hold is placed with an expiration date in the past, the
expire_time of the hold will be reset using the hold expiration
interval settings.

Likewise, if a hold is changed to have an expiration date in the
past, the hold expiration date will be recalculated using the
hold expiration interval settings.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoAdd calculate_expire_time helper function to Holds.pm.
Jason Stephenson [Wed, 14 Nov 2012 16:27:53 +0000 (11:27 -0500)]
Add calculate_expire_time helper function to Holds.pm.

This new function calculates an expire_time for a hold based on the hold
expiration interval setting for a passed in org_unit. If the setting is found
the interval is added to "now" and returned as an ISO8601 string. undef is
returned if the setting is not found for the org_unit or its ancestors.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoAdd datecmp to OpenILS::Application::AppUtils.
Jason Stephenson [Wed, 14 Nov 2012 15:40:35 +0000 (10:40 -0500)]
Add datecmp to OpenILS::Application::AppUtils.

datecmp is a handy subroutine for comparing two DateTime objects or string
represenations. It returns -1, 0, and 1, much like the perl cmp operator.

If only 1 date is specified, then it will be compared to DateTime->now.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoFix foreign character display in receipts
Dan Wells [Tue, 6 Nov 2012 21:32:23 +0000 (16:32 -0500)]
Fix foreign character display in receipts

This commit makes two changes to the staff client print code to
help with the proper display of foreign characters:

1) Specify the utf-8 charset in the receipt Data URIs.
2) Properly encode the entire data string using encodeURIComponent
rather than encode().  Failing to do so was causing XULRunner to
be "creative" with the interpretation of the data.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoStamping upgrade script for hold request email notify default false
Ben Shum [Tue, 18 Dec 2012 05:12:38 +0000 (00:12 -0500)]
Stamping upgrade script for hold request email notify default false

Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP#1047475 Set action.hold_request.email_notify to default to false
Michael Peters [Thu, 13 Sep 2012 20:28:04 +0000 (16:28 -0400)]
LP#1047475 Set action.hold_request.email_notify to default to false

LP#1047475 points out that email notify prefs are ignored in TPAC.
Even if a patron deselects email notify during hold request time, it
will always be set to true due to the column default.

This change defaults the column in the database to false (like most
other similar columns are) and resolves the bug.

Credit to Steve Callender for the idea.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP: #1086064 Ignore spaces in opac username/barcode entry field
Dan Pearl [Tue, 11 Dec 2012 15:13:41 +0000 (10:13 -0500)]
LP: #1086064  Ignore spaces in opac username/barcode entry field

Too often, patrons copy the spacing on the barcode on their keytag,
or enter a spurious space before entering their name/barcode. This
change will remove spaces in their name/barcode.

(For now, keep the login screen's directions to omit spaces when
entering the username/barcode.)

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoHighlight selected facets over multiple lines
Dan Scott [Tue, 4 Dec 2012 15:08:36 +0000 (10:08 -0500)]
Highlight selected facets over multiple lines

As reported by Dan Pearl in LP# 1086150, selected facets that wrap over
multiple lines only have the first line highlighted. Which is odd, and
easily fixed with a small tweak to the CSS.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoUse uri_escape_utf8 in EGCatLoader/Record.pm.
Jason Stephenson [Tue, 30 Oct 2012 17:07:21 +0000 (13:07 -0400)]
Use uri_escape_utf8 in EGCatLoader/Record.pm.

To avoid this:

[Tue Oct 30 12:34:36 2012] [error] [client 134.241.121.11] egweb: Context
Loader error: Can't escape \\x{02B9}, try uri_escape_utf8() instead at
/usr/local/share/perl/5.14.2/OpenILS/WWW/EGCatLoader/Record.pm line 472 \n,
referer: http://catalog.mvlc.org/eg/opa c/results?fi%3Aitem_type=&query=
zhenshchiny&qtype=keyword&locg=1

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP#1088868: Column sort popup menu has no background style
Pasi Kallinen [Thu, 13 Dec 2012 08:00:43 +0000 (10:00 +0200)]
LP#1088868: Column sort popup menu has no background style

Change the menu from "popup" element to "menupopup", as per tsbere's suggestion.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoSupport barcode autocompletion in copy buckets
Thomas Berezansky [Thu, 9 Feb 2012 21:37:48 +0000 (16:37 -0500)]
Support barcode autocompletion in copy buckets

By request of our staff, who are lazy.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP#1084161 KPAC: Added Content Tabs can be too wide
Michael Peters [Wed, 28 Nov 2012 17:45:02 +0000 (12:45 -0500)]
LP#1084161 KPAC: Added Content Tabs can be too wide

In cases where LOTS of added content might be available, the
record summary is not wide enough to fit all of the tabs.

This decreases their padding width to fit them comfortably.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP#1090385 Fix success message for copy template deletion
Michael Peters [Mon, 17 Dec 2012 14:10:19 +0000 (09:10 -0500)]
LP#1090385 Fix success message for copy template deletion

We were displaying the "confirm" message twice, instead of the
existing "success" message.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoI18N: Make everything in tt2 files translatable.
Dan Scott [Sun, 16 Dec 2012 08:20:49 +0000 (03:20 -0500)]
I18N: Make everything in tt2 files translatable.

Simply wrap everything that should be translatable inside l().
Also fixes bug #1088388

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Conflicts:
Open-ILS/src/templates/acq/common/li_table.tt2
Open-ILS/src/templates/acq/invoice/view.tt2
Open-ILS/src/templates/acq/search/unified.tt2
Open-ILS/src/templates/vandelay/inc/item_attrs.tt2

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoJava IDL parser supports isnew/ischanged/isdeleted
Bill Erickson [Thu, 5 Apr 2012 13:36:31 +0000 (09:36 -0400)]
Java IDL parser supports isnew/ischanged/isdeleted

Includes changes to TestIDL.java for verification.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoAdd Java *.class files to gitignore
Bill Erickson [Fri, 24 Feb 2012 21:37:07 +0000 (16:37 -0500)]
Add Java *.class files to gitignore

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoJava IDL parser updated to use derived field array index
Bill Erickson [Fri, 24 Feb 2012 21:33:58 +0000 (16:33 -0500)]
Java IDL parser updated to use derived field array index

The "array_position" IDL attribute is deprecated.  Determine the
index by field position within the XML.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoFix OSRF_HOME and EXT in Open-ILs/src/java/Makefil.am.
Jason Stephenson [Wed, 31 Oct 2012 17:25:04 +0000 (13:25 -0400)]
Fix OSRF_HOME and EXT in Open-ILs/src/java/Makefil.am.

Change the paths so that they work.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoUpdate Java dependencies.
Jason Stephenson [Tue, 30 Oct 2012 21:10:42 +0000 (17:10 -0400)]
Update Java dependencies.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoAcq: When invoice-building with embedded search, allow control of results list
Lebbeous Fogle-Weekley [Fri, 5 Oct 2012 22:42:11 +0000 (18:42 -0400)]
Acq: When invoice-building with embedded search, allow control of results list

Previously, a results list could accumulate under inconsistent
conditions.  You'd get an accumulating results list if you were pressing
enter after successful searches, but your results lists would clear if
you actually clicked the Search button.  Worse, searches yielding empty
result sets would *appear* to clear your result list, but subsequent
sucessful searches would restore what was there before.

This is the "missing commit" that makes the behavior consistent and
togglable.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoLP#1058321: Acq: Possible to receive a pending purchase order
Mark Cooper [Wed, 24 Oct 2012 05:02:38 +0000 (22:02 -0700)]
LP#1058321: Acq: Possible to receive a pending purchase order

Revised to allow a cancelled PO to be received, as this is needed under
certain conditions (note - bib/items are not restored in this case).
Added po_state variable to avoid repeated PO.state() function invocations.

Signed-off-by: Mark Cooper <markchristophercooper@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoLP#1058321: Possible to receive a pending purchase order
Mark Cooper [Tue, 16 Oct 2012 01:03:44 +0000 (18:03 -0700)]
LP#1058321: Possible to receive a pending purchase order

Restrict 'Mark purchase order as received' to on-order state
purchase orders, and 'Un-Receive Purchase Order' to 'received'
POs. Otherwise inconsistencies easily occur ...

Signed-off-by: Mark Cooper <markchristophercooper@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoAutoFieldWidget support external copy loc retrieval
Bill Erickson [Fri, 28 Sep 2012 19:48:22 +0000 (15:48 -0400)]
AutoFieldWidget support external copy loc retrieval

When rendering a collection of copy locations, AFW fetches locations
relevant to the context org unit.  While rendering an AFW for an
existing object, though, whose copy location is outside of that scope,
the code will now append the non-local copy location to the selector and
tag it with the owning lib (to avoid dupes).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoACQ order upload use copy location from owner
Bill Erickson [Fri, 28 Sep 2012 19:00:37 +0000 (15:00 -0400)]
ACQ order upload use copy location from owner

When uploading an ACQ MARC order record, attempt to match copy locations
to copies based on the copy owning location instead of the upload
context org unit.  This allows one branch to order copies for another
and have the copies use the copy location of the other (owning) branch
(when they exist) instead of the ordering branch (or parent org).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoUse consistent language for holdings/items profiles in Vandelay. Now
Mark Cooper [Wed, 5 Dec 2012 21:11:23 +0000 (13:11 -0800)]
Use consistent language for holdings/items profiles in Vandelay. Now
uses "Holdings Import Profiles" as standard.

Signed-off-by: Mark Cooper <markchristophercooper@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agolp1010187 eliminate redundant/unnecessary calls
Jason Etheridge [Wed, 20 Jun 2012 15:47:54 +0000 (11:47 -0400)]
lp1010187 eliminate redundant/unnecessary calls

Particularly invocations of open-ils.circ.stat_cat.asset.retrieve.all in the
Item Attribute Editor

To test:

    login with a BR1 workstation
    load a pristine (non-stat-cat-laden) BR1 item with the editor
    there should be no call to open-ils.circ.stat_cat.asset.retrieve.all
    change the Circ Lib on the item to BR4
    reload the item in the editor
    there should be a call to open-ils.circ.stat_cat.asset.retrieve.all
    reload the item in the editor
    there should be no call to open-ils.circ.stat_cat.asset.retrieve.all
    assign the item a stat cat entry owned by CONS
    reload the item in the editor
    there should be no call to open-ils.circ.stat_cat.asset.retrieve.all

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoPatch to improve the warning on double checkout attempt
edoceo [Wed, 25 Jul 2012 09:00:55 +0000 (02:00 -0700)]
Patch to improve the warning on double checkout attempt

Code modifications by David Busby of Edoceo for KCLS
Released without restriction to Evergreen community
Signed-off-by: edoceo <code@edoceo.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agomod_perl expects child_init return values
Thomas Berezansky [Wed, 11 Apr 2012 17:26:42 +0000 (13:26 -0400)]
mod_perl expects child_init return values

So add in Apache2::Const::OK returns on all of them.

[LFW: Added the same change to AutoSuggest.pm for consistency's sake.]

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoAllow 'Enter' key to run Verify Credentials user check
edoceo [Thu, 8 Nov 2012 04:08:27 +0000 (20:08 -0800)]
Allow 'Enter' key to run Verify Credentials user check

In both the "Verify Credentials" menu and "Test Password" patron account
option, this change checks for the keypress of "Enter" and then executes
the cmd_verify routine.

Additionally, the password field is blanked after each attempt.

Signed-off-by: edoceo <code@edoceo.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoAcq: Yet more efforts to sanitize data for the EDI translator
Lebbeous Fogle-Weekley [Fri, 23 Mar 2012 02:21:36 +0000 (22:21 -0400)]
Acq: Yet more efforts to sanitize data for the EDI translator

I specifically did this to address cases reported to me by Galen
Charlton in which get_li_attr_jedi() would return the string "nul", but
I hope this is a nail in the coffin for problems involving
JEDI-producing Action/Trigger templates feeding the EDI translator
strings that the latter doesn't like.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoMake the acquisitions setup show up in the manual
Dan Scott [Sun, 9 Dec 2012 05:36:08 +0000 (00:36 -0500)]
Make the acquisitions setup show up in the manual

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoAdd acquisitions setup chapter
Dan Scott [Sun, 9 Dec 2012 05:30:29 +0000 (00:30 -0500)]
Add acquisitions setup chapter

Another product of the Evergreen in Action documentation sprint!

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoAdd the "Importing via the staff client" chapter
Dan Scott [Sun, 9 Dec 2012 00:55:24 +0000 (19:55 -0500)]
Add the "Importing via the staff client" chapter

... from the Evergreen In Action doc sprint.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoRoll in some Evergreen in Action chapters
Dan Scott [Sat, 8 Dec 2012 23:36:12 +0000 (18:36 -0500)]
Roll in some Evergreen in Action chapters

For the initial import we're keeping the formatting and words identical,
so that we can manually sycnhronize changes as needed between the FLOSS
Manuals version of this documentation and the AsciiDoc version.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoAdd a target ID to fix the epub transform
Dan Scott [Sat, 8 Dec 2012 23:37:51 +0000 (18:37 -0500)]
Add a target ID to fix the epub transform

Commit a850606073 added a link pointing to this ID, but the target ID
did not exist, breaking the epub transform. Now it works again.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoDocumentation: Add sections to workstation admin chapter.
BC Libraries Cooperative [Fri, 30 Nov 2012 16:10:39 +0000 (11:10 -0500)]
Documentation: Add sections to workstation admin chapter.

Content from:
http://docs.sitka.bclibraries.ca/Sitka/current/html/intro_start_workstation_admi$

Receipt template editor sections moved to this chapter.
Converted to asciidoc by rsoulliere. Index terms added by rsoulliere
Some duplicate images were also removed from media directory.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
7 years agoDocumentation: Add workstation administration chapter.
BC Libraries Cooperative [Thu, 29 Nov 2012 20:39:57 +0000 (15:39 -0500)]
Documentation: Add workstation administration chapter.

Content from: http://docs.sitka.bclibraries.ca/Sitka/current/html/intro_start_workstation_admin.html
Converted to asciidoc by rsoulliere.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
7 years agoFix misspelling of "summary" in KPAC Added Content
Michael Peters [Wed, 28 Nov 2012 17:36:10 +0000 (12:36 -0500)]
Fix misspelling of "summary" in KPAC Added Content

Summary != Smmary

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoDocumentation: Add staff client login chapter.
Robert Soulliere [Thu, 29 Nov 2012 15:43:28 +0000 (10:43 -0500)]
Documentation: Add staff client login chapter.

Included standalone interface and loggin out information as well as
a few index terms.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
7 years agoDocumentation: Add chapter on staff client installation.
Robert Soulliere [Wed, 28 Nov 2012 16:36:54 +0000 (11:36 -0500)]
Documentation: Add chapter on staff client installation.

Also included information on removing staff client preferences
(from EG wiki) and registering workstations.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
7 years agoKPAC - add shelving location to copy table display
Melissa Lefebvre [Tue, 27 Nov 2012 18:35:42 +0000 (13:35 -0500)]
KPAC - add shelving location to copy table display

Addition of shelving location information to the display along with the
removal of broken "view library info" javascript link.

Signed-off-by: Melissa Lefebvre <mlefebvre@biblio.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoKPAC - fix getit_results with short titles
Ben Shum [Wed, 21 Nov 2012 19:17:59 +0000 (14:17 -0500)]
KPAC - fix getit_results with short titles

When using the "Get it" options to either add an item to a list or place an
item on hold, one would get an internal server error whenever attemping this
on a bib record with a short title.

Turns out that the substr function that shortens the length of long titles
breaks when the title is 18 characters or less.

Add an IF check around the substr function to avoid this error.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
7 years agoKPAC - fix Get It and pickup library selector
Ben Shum [Mon, 19 Nov 2012 22:34:33 +0000 (17:34 -0500)]
KPAC - fix Get It and pickup library selector

Change PROCESS to INCLUDE to prevent variable leaks from breaking
the pickup library selector's values.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
7 years agoLP#1082260: Update OPAC low search hits template for i18n
Pasi Kallinen [Tue, 27 Nov 2012 10:39:02 +0000 (12:39 +0200)]
LP#1082260: Update OPAC low search hits template for i18n

The OPAC lowhits.tt2 template is only partially translatable,
and the translatable part is impossible to make sound good
for languages with different word order than English.

This patch changes the already translatable part so there
are 4 different phrases to translate (instead of two phrase
fragments), and makes the search hints translatable.

For English language, the patch does not introduce any visible differences.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoFix typo in docs/opac/search_form.txt
Michael Peters [Tue, 27 Nov 2012 14:31:32 +0000 (09:31 -0500)]
Fix typo in docs/opac/search_form.txt

Creating a simple search for kpac should link to "kpac"
not "tpac" which won't exist.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoFix lp1076379: Can't edit holds beyond first page.
Jason Stephenson [Thu, 8 Nov 2012 20:09:09 +0000 (15:09 -0500)]
Fix lp1076379: Can't edit holds beyond first page.

When a hold was being edited on page 2+ of a patron's list of holds, the
offset was > 0. Since the input hold_ids array ref has only 1 member, using
the offset as a starting point in searching began the search beyond the end
of the array and thus returned nothing.

The code in this commit moves the handling of the offset and limit to cases
where the input hold_ids is undefined, as this is, I think the intended
behavior. Typically when hold_ids is passed to the fetch_user_holds function
in EGCatLoader::Account, you want to retrieve those holds regardless of
the offset and limit values.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoRepair syntax on line 559 of Holds.pm
Jason Stephenson [Thu, 8 Nov 2012 16:32:06 +0000 (11:32 -0500)]
Repair syntax on line 559 of Holds.pm

A change was introduced when listing available holds that has incorrect JSON
syntax. This caused available holds not to be returned by the query.

Changing '+ahr' to '=' in the query resolves this.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>