working/Evergreen.git
8 years agoAdd component to *force* external browser use
Thomas Berezansky [Wed, 25 Jan 2012 17:47:40 +0000 (12:47 -0500)]
Add component to *force* external browser use

For http/https urls that don't go to the host we are logged into.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoAllow opening of links in default browser
Thomas Berezansky [Wed, 25 Jan 2012 16:18:39 +0000 (11:18 -0500)]
Allow opening of links in default browser

And do so for the "Get Help With Evergreen" portal link.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoSigned-off-by: Kathy Lussier <klussier@masslnc.org>
Kathy Lussier [Tue, 10 Jul 2012 02:46:05 +0000 (22:46 -0400)]
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
LP: Allow user to change activation options for suspended holds.

Activation options were hidden from users when holds were in a suspended
state.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoFix LP800480, ACQ - Vendor Invoice Won't Save
Steven Chan [Wed, 18 Jul 2012 18:22:14 +0000 (11:22 -0700)]
Fix LP800480, ACQ - Vendor Invoice Won't Save

1. Upon submitting the form, the client prepares two auxiliary data
objects containing service charges and line items. The two objects are
normally 'fleshed', ie, contain references to other data objects, but in
the versions sent to the server, they must be 'unfleshed', ie, the
referent objects are converted back to ID values. If the user resubmits
the form, the client should not unflesh again. However, the software for
preparing line items contain lines of code that unfleshes without
checking if the objects are already unflesh. When unfleshing a second
time, we get an uncaught reference error. Ironically, the software also
contains lines of code to do it correctly, so the errant lines of code
are also duplicates.

To fix problem 1, we remove the duplicate errant lines of code. We
define a helper unflesh() method and use it to replace the current lines
of code to unflesh.

2. When the user submits the form without filling in required data
fields in the invoice, including Vendor Invoice ID, the client does not
validate before making a service request. The server tries to complete
the database transaction, but gets an error.  When the response comes
back, the client shows the same form so that the user can retry.
However, the message alert to the user is not informative; it indicates
an error at the database level, but does not indicate the probable
reason.

To fix problem 2, We move the lines of code preparing the invoice object
earlier in the sequence.  We define a helper method mapValues() to
prepare the invoice object from the values in the UI widget object.
mapValues() will return an error object if it detects that required
values are null. We check for the error object, and will show an alert
message to the user and abort the submit operation early, allowing the
user to retry.

3. When an invoice with line items is saved, the invoice is re-rendered
with new buttons to allow receiving. It also contains a new button to
enable the user to view the line items in list format. However, it does
not work in a non-Firefox browser, because a debug statement using the
'dump()' function is left uncommented. (Inspection of all other
appearances of dump() show they are all commented out.) There is an
uncaught reference because dump() is not found.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoBatch lineitem create / link-to invoice action
Bill Erickson [Mon, 9 Jul 2012 18:46:41 +0000 (14:46 -0400)]
Batch lineitem create / link-to invoice action

In the PO lineitem list page and lineitem search restuls page,  there
are two new actions in the top-level actions selector: "Create Invoice
from Selected Lineitems" and "Link To Invoice for Selected Lineitems".
Both behave the same as create/link invoice for single lineitems, but
now it's possible to select multiple lineitems for invoicing.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoInvoice link dialog supports multiple lineitems/POs
Bill Erickson [Mon, 9 Jul 2012 18:45:15 +0000 (14:45 -0400)]
Invoice link dialog supports multiple lineitems/POs

Adds support to the invoice linking dialog for linking sets of lineitems
or POs instead of just one.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoAttach multiple lineitems / POs to invoice
Bill Erickson [Mon, 9 Jul 2012 17:34:26 +0000 (13:34 -0400)]
Attach multiple lineitems / POs to invoice

Adds support to the Invoice interface for attaching multiple lineitems
or POs via the existing attach_li and attach_po URL params.  These can
be used by other invoice create/link UIs for batch linking.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoDocumentation: Add line breaks in authorities chapter to fix
Robert Soulliere [Tue, 24 Jul 2012 17:01:48 +0000 (13:01 -0400)]
Documentation: Add line breaks in authorities chapter to fix
asciidoc formatting.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoAcq: PO view interface sometimes fails to load in development enviroments
Lebbeous Fogle-Weekley [Tue, 24 Jul 2012 16:46:08 +0000 (12:46 -0400)]
Acq: PO view interface sometimes fails to load in development enviroments

Should not affect production environments, but requiring
dijit.form.Button quiets an error on my system when I don't have
a openils_dojo.js bundle installed.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoACQ : lineitem recovers focus from various interfaces
Bill Erickson [Fri, 13 Jul 2012 16:07:56 +0000 (12:07 -0400)]
ACQ : lineitem recovers focus from various interfaces

1. When viewing an invoice then clicking on the title link for a lineitem,
the user is taken away to the copy grid within the PO page for the
lineitem.This adds a "Return to Invoice" button in the copy grid which
takes the user back to the invoice, focused on the lineitem in question.

2. Adds a "Return to Search" button for PL/PO pages to return to the
lineitem in question when the PL or PO links are selected for a lineitem
in a set of search results.

3. Adds a "Return to Invoice" button to PO/Picklist pages with lineitem
focus when the page was accessed from the invoice UI.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoACQ : Support lineitem fucus in ACQ unified search
Bill Erickson [Fri, 13 Jul 2012 20:31:41 +0000 (16:31 -0400)]
ACQ : Support lineitem fucus in ACQ unified search

Adds support for a "focus_li" URL parameter to ACQ unified search
results pages.  When present, the page of results containing the
requested lineitem are loaded (instead of the default page 1) and the
lineitem is made visible in the viewable screen using the lineitem table
focusLi mechanism.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoACQ : Support for lineitem focus in invoice UI
Bill Erickson [Thu, 12 Jul 2012 20:23:14 +0000 (16:23 -0400)]
ACQ : Support for lineitem focus in invoice UI

Adds support for a "focus_li" URL parameter.  When set, the UI will
scroll to the lineitem and provide a brief color change on the table row
to help orient.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoACQ : worksheet Return action focuses lineitem
Bill Erickson [Thu, 12 Jul 2012 18:09:32 +0000 (14:09 -0400)]
ACQ : worksheet Return action focuses lineitem

Adds a new Return button to the lineitem worksheet page which returns
the user to the previous interface with the lineitem in question
focused.  Uses a new CGI param "focus_li".

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoACQ : Lineitem recovers focus after actions
Bill Erickson [Thu, 12 Jul 2012 18:01:50 +0000 (14:01 -0400)]
ACQ : Lineitem recovers focus after actions

After useing the Copies, Notes, or title-click actions on a lineitem,
using the "Return" button will now cause the lineitem in question to be
visible on the lineitem list page upon return.  After returning, there
is also a brief border coloration around the lineitem to help the user
re-orient.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoSupport custom URL mangling in openils.CGI JS lib
Bill Erickson [Fri, 13 Jul 2012 15:49:00 +0000 (11:49 -0400)]
Support custom URL mangling in openils.CGI JS lib

Adds a new optoinal parameter to the openils.CGI constructor called
'args', which currently supports 'url' and 'query' fields.  If the URL
is provided, CGI uses the value from args.url instead of location.href
and location.search.  Additionally, if 'query' is provided, it's used
instead of location.search and takes precedence over any query in
args.url;

It's also now possible to set parameter values.  By default, setting a
value overwrites the full array of values from multi-value params.  You
can use the 'push' argument to push the value onto the list instead of
clobbering it.

There are two new methods, queryString() and url().  The first returns
the query string, the second the full URL with uri-escaped query string
included.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoACQ order record fetcher and uploader script
Bill Erickson [Mon, 23 Jul 2012 14:44:41 +0000 (10:44 -0400)]
ACQ order record fetcher and uploader script

Some ACQ vendors support delivering MARC order record files directly
from their order system to an ILS via FTP.  (I've heard this called
"one-click" ordering in the past).  This commit includes a script to
seek out such order record files and pass them on to the Acquisitions
service for PO creation and potential activation.

The script supports a number of options, configured in opensrf.xml,
including which Vandelay (record import) options to use during record
import/merge/overlay.  See opensrf.xml.example for details.

Example:

./acq_order_reader.pl \
    --user admin \
    --password demo123 \
    -poll-interval 3 \
    --debug &

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoSupport Purchase Order name extraction from upload
Bill Erickson [Tue, 17 Jul 2012 15:08:35 +0000 (11:08 -0400)]
Support Purchase Order name extraction from upload

It's now possible to extract a purchase order name from a MARC order
record file received from a vendor.  If the provider has an attribute
definition (Admin -> Server Admin -> Acquisitions -> Providers ->
Attribute Definitions) configured with code "purchase_order" and the
order record contains a PO name at the configured MARC field/subfield,
the PO name will be used for the newly created purchase order.

Example attribute configuration:

code            => purchase_order
xpath           => //*[@tag="980"]/*[@code="p"]
Is Identifier   => false

*note 980p is arbitrary

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoStamping upgrade script for Capture/Fulfill penalty blocks
Mike Rylander [Tue, 24 Jul 2012 15:51:29 +0000 (11:51 -0400)]
Stamping upgrade script for Capture/Fulfill penalty blocks

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoApply HOLD block on new holds, CAPTURE block on existing
Bill Erickson [Tue, 17 Jul 2012 13:19:46 +0000 (09:19 -0400)]
Apply HOLD block on new holds, CAPTURE block on existing

With the addition of the CAPTURE block, the HOLD block should only apply
for newly placed holds in the hold permit test
(action.hold_request_permit_test).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoAvoid CAPTURE-blocked holds in pull list (IDL view)
Bill Erickson [Thu, 21 Jun 2012 18:37:11 +0000 (14:37 -0400)]
Avoid CAPTURE-blocked holds in pull list (IDL view)

Update the new IDL holds pull list view to avoid returning holds for
users that have CAPTURE penalties.

Note that items are blocked from the pull list only if the hold pickup
lib is within the CAPTURE penalty org unit range.  This means that users
could be blocked at one branch, but use a pickup lib at another to avoid
the block.  To prevent this type of abuse, set the org_depth to 0 on any
penalties that apply the CAPTURE block.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agohold CAP/FILL blocks : pair FULFILL with CIRC in stock penalties
Bill Erickson [Thu, 21 Jun 2012 18:26:25 +0000 (14:26 -0400)]
hold CAP/FILL blocks : pair FULFILL with CIRC in stock penalties

FULFILL is really a block on circulation, not holds, so pair the FULFILL
block with CIRC blocks for the stock data.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agohold CAP/FILL blocks : more event test collection repairs
Bill Erickson [Thu, 21 Jun 2012 18:11:47 +0000 (14:11 -0400)]
hold CAP/FILL blocks : more event test collection repairs

Further improving the logic which decides which patron permit events are
valid for a given set of circumstances.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agohold CAP/FILL blocks : repair event test in patron permit
Bill Erickson [Thu, 21 Jun 2012 18:00:51 +0000 (14:00 -0400)]
hold CAP/FILL blocks : repair event test in patron permit

Repairs in oversight in the patron permit event testing code that caused
the test to miss events when the checkout was not there to fulfill a
hold.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoAvoid CAPTURE-blocked holds in pull list
Bill Erickson [Tue, 10 Apr 2012 20:24:59 +0000 (16:24 -0400)]
Avoid CAPTURE-blocked holds in pull list

Otherwise, staff will be pulling items for holds that cannot be
captured.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoAvoid checkin capture for CAPTURE-blocked holds
Mike Rylander [Tue, 10 Apr 2012 14:21:02 +0000 (10:21 -0400)]
Avoid checkin capture for CAPTURE-blocked holds

Teach the nearest_hold sub about CAPTURE-blocking penalties

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agohold CAP/FILL blocks : separate CIRC and FULFILL blocks
Bill Erickson [Tue, 10 Apr 2012 19:42:17 +0000 (15:42 -0400)]
hold CAP/FILL blocks : separate CIRC and FULFILL blocks

This breaks the CIRC standing penalty block out into two separate
blocks.  The existing CIRC block now prevents circulations on checkouts
where the checkout is not fulfilling a hold.  A new FULFILL block type
is added which, when applied to a user, (only) prevents the user from
checking out items that fulfill a hold.

To always prevents checkouts, use both blocks.  Use individual blocks
where one or the other behavior is desired.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoDB seed data for CAPTURE and FULFILL penalty blocks
Bill Erickson [Tue, 10 Apr 2012 19:41:51 +0000 (15:41 -0400)]
DB seed data for CAPTURE and FULFILL penalty blocks

All occurrences of HOLD in the block list for any existing penalties are
updated to HOLD|CAPTURE|FULFILL for backwards compatibility, minus the
handful of STAFF_* penalties whose codes match their respective
block_lists.

To use these new block types, simply update existing penalties as
desired or add new local pentalty types for staff-managed patron
blocking messages.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoACQ "Fund Summary" combined IDL reporter view
Bill Erickson [Mon, 23 Jul 2012 22:51:45 +0000 (18:51 -0400)]
ACQ "Fund Summary" combined IDL reporter view

IDL view which produces summary information for funds for reporting.
The resulting "table" looks like a fund w/ four additional fields:
allocated_total, spent_total, encumbrance_total, and combined_balance.

The view is marked as reporter:core="true" so it will be visible in the
main reporter sources.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoRemove retrieve permissions from org units
Ben Shum [Tue, 24 Jul 2012 14:36:49 +0000 (10:36 -0400)]
Remove retrieve permissions from org units

Noticeably broken for the new simplified pull list when org units were not
visible from the interface to users without the following permissions:

CREATE_ORG_UNIT
UPDATE_ORG_UNIT
DELETE_ORG_UNIT

Since regular staff accounts would never be given any of these permissions
and nothing really secretive is included in org unit lookup, this change
removes those permissionas being required for retrieve.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoFix TPAC recognition of logged-in users via http
Jeff Godin [Tue, 24 Jul 2012 06:23:17 +0000 (02:23 -0400)]
Fix TPAC recognition of logged-in users via http

Fixes bug: LP 957375
tpac: catalog does not immediately recognize "stay logged in" users
https://bugs.launchpad.net/evergreen/+bug/957375

The issue: during the login process, the user is redirected to an
https connection and receives a cookie with the "secure" flag set.

Since this cookie is not sent over normal http connections,
following an external link or manually entering an http catalog url
will result in an unexpected "not logged in" experience.

Selecting the login link or any other action requiring login is
enough to return to the "logged in" experience, without a need to
re-enter credentials. Still, we can do better.

This affects users who have checked the persistent login checkbox
and those who have left it unchecked. Users selecting the persistent
login option are more likely to encounter the issue, especially if
the link they typically follow/enter is to a non-https catalog url.

The solution:

Add a new cookie (constant COOKIE_LOGGEDIN)
 - contains a "hint" that the user may be logged in already
 - set/cleared at login/logout time
 - contains no sensitive auth/session data
 - "secure" flag not set (sent for both http and https requests)

When a user's browser presents the COOKIE_LOGGEDIN cookie in a
request for a non-https URL, the user is automatically redirected to
the https version of that url.

At that time, if the user has a valid COOKIE_SES cookie set, they
will be recognized as a logged in user. If their COOKIE_SES value is
no longer valid, a logout is performed, clearing both cookies.

If for some reason the COOKIE_SES cookie is not present but the
COOKIE_LOGGEDIN is present, there is a harmless redirection to https
and the user is not logged in, but can log in via the usual means.

To test, after applying:
- log in to the TPAC
- navigate to http://example/eg/opac/home
- You should be redirected to https://example/eg/opac/home and you
  should see your name, count of checked out / on hold / etc items

Prior to this, the above steps would result in you remaining on the
http URL and seeing only a "Your Account Log In" button.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoShow zero-copy lineitem's in zero-copy activation warning
Bill Erickson [Tue, 10 Jul 2012 20:29:39 +0000 (16:29 -0400)]
Show zero-copy lineitem's in zero-copy activation warning

When PO activation fails as a result of zero-copy lineitems, show the
IDs of the zero-copy lineitems along with the failure message.

This adds a new API call

open-ils.acq.purchase_order.no_copy_lineitems.id_list(auth, po_id)

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoControl PO activation for zero-copy lineitems
Bill Erickson [Tue, 10 Jul 2012 15:56:05 +0000 (11:56 -0400)]
Control PO activation for zero-copy lineitems

By default, prevent activation of POs when any lineitems are present
that have no copies attached.  This adds a new option in the PO UI
called "Allow activation with zero-copy lineitems", which will allow the
activation to continue even when zero-copy lineitems exist.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoTPAC - repair editions statement display
Ben Shum [Mon, 23 Jul 2012 20:59:33 +0000 (16:59 -0400)]
TPAC - repair editions statement display

Change && back to || and repair editions display in TPAC.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoACQ repair reverse exchange rate in fund transfer
Bill Erickson [Mon, 23 Jul 2012 22:01:50 +0000 (18:01 -0400)]
ACQ repair reverse exchange rate in fund transfer

Updated fund transfer code to use the DB exchange rate stored procedure.
In addition to code consolidation, this allows the fund trasnfer
operation to work if an exchange rate for the two currencies involved is
only defined in one direction.  The existing code required that the rate
be defined in both directions in the database or it would produce an
error in the logs and no visible error in the interface.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agowording improvement for 2.2 release notes
Galen Charlton [Tue, 24 Jul 2012 13:53:01 +0000 (09:53 -0400)]
wording improvement for 2.2 release notes

Patch by Sally Fortin <sfortin@esilibrary.com> to fix
typo noticed by James Keenan.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoAlways display the hold type indicator
Mike Rylander [Tue, 22 May 2012 12:00:12 +0000 (08:00 -0400)]
Always display the hold type indicator

We should be showing the type of hold on any pull-list or hold detail
interface we build.  The primary use case is to alert staff when an
alternate identical copy of the same title will (very likely) be usable
by a hold, and (as in the case of C-like holds) it will not.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoStamping upgrade for Copy Location Circ Limits
Mike Rylander [Tue, 24 Jul 2012 12:11:23 +0000 (08:11 -0400)]
Stamping upgrade for Copy Location Circ Limits

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoAdd Copy Location to circ matrix matchpoint
Bill Erickson [Fri, 22 Jun 2012 16:04:41 +0000 (12:04 -0400)]
Add Copy Location to circ matrix matchpoint

Similar to circulation modifiers, circ policies can now be based on copy
location.

This also adds copy location to the circ matrix weights.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoCopy Location Circ Limit Sets Admin UI
Bill Erickson [Fri, 13 Apr 2012 20:19:03 +0000 (16:19 -0400)]
Copy Location Circ Limit Sets Admin UI

Changes are applied to the existing Admin -> Local Administration ->
Circ Limit Sets interface to support copy location limit groups.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Copy Location Circ Limit Sets : UI 2

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoCopy Location Circ Limit Sets : DB and IDL
Bill Erickson [Fri, 13 Apr 2012 19:39:18 +0000 (15:39 -0400)]
Copy Location Circ Limit Sets : DB and IDL

Support for copy location-based circulation limit sets.  Similar to circ
mod limit sets, this allows staff to configure a maximum number of items
allowed checked out based on copy location(s) and link that rule to
circulation policies to control who the rule affects.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoJSPAC: Point to TPAC from <noscript> section
Dan Scott [Mon, 23 Jul 2012 16:09:03 +0000 (12:09 -0400)]
JSPAC: Point to TPAC from <noscript> section

TPAC was built for browsers with no JavaScript. Ironically, we're still
pointing to the SlimPAC from the <noscript> section of the JSPAC... fix
that.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoStamping upgrade script for Trigger Event Log
Mike Rylander [Mon, 23 Jul 2012 20:13:36 +0000 (16:13 -0400)]
Stamping upgrade script for Trigger Event Log

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoTrigger Event Log
Lebbeous Fogle-Weekley [Fri, 18 May 2012 16:12:55 +0000 (12:12 -0400)]
Trigger Event Log

A better, more browsy/filtery way to browse Action Trigger Events
related to holds and circs, which staff users sometimes want to filter
by patron barcode.

This is accessed from various menus around the staff client, notably the
patron interface and the item status interface.

This has better printing capabilities than previous versions of this
interface, too.

There's also a new org unit setting to go with this,
"circ.staff.max_visible_event_age", which if set, should hide any events
older than the configured age.

One new permission: VIEW_TRIGGER_EVENT.  This does what it sounds like
it does.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts (resolved):
Open-ILS/src/sql/Pg/950.data.seed-values.sql
Open-ILS/web/js/dojo/openils/widget/PCrudFilterDialog.js

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoTPAC: Set autofocus appropriately for different contexts
Dan Scott [Thu, 12 Jul 2012 23:12:06 +0000 (19:12 -0400)]
TPAC: Set autofocus appropriately for different contexts

At login, the basic search bar was fighting (and winning) for the
default focus rather than the username field. Additionally, in the
advanced search pages, no field was getting focus. Therefore, check to
see if we expect to be in a context where it makes sense to set the
default focus to the basic search input field; otherwise, set the focus
to the login username field or the appropriate advanced search field.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoDocumentation: Fix typo in upgrade instructions. Bug #1027752 reported by Jeff...
Robert Soulliere [Mon, 23 Jul 2012 12:12:15 +0000 (08:12 -0400)]
Documentation:  Fix typo in upgrade instructions. Bug #1027752 reported  by Jeff Green.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoFix / improve bookbag list paging user/bshum/lp1003409_paging_fixes
Dan Scott [Sun, 22 Jul 2012 22:58:11 +0000 (18:58 -0400)]
Fix / improve bookbag list paging

The prior code used CSS to hide elements, which is a bit weird given
that we can simply avoid creating the element in the first place and
keep the DOM a lot simpler.

Also, the previous code was subject to some bugs if it wasn't given
an explicit offset GET param or paging at the end of a list
(particularly given that the LIMIT parameter ensured that the number of
bookbags returned would always be equal to or less than the LIMIT
parameter).

Finally, the changes related the permanent bookbags didn't pass through
one of the context parameters we needed (bookbag_count) to enable
paging.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoWrap upgrade script for permanent bookbag lists
Dan Scott [Sun, 22 Jul 2012 20:01:38 +0000 (16:01 -0400)]
Wrap upgrade script for permanent bookbag lists

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPAC: Refactor bookbag list actions into a common template
Dan Scott [Wed, 18 Jul 2012 16:27:08 +0000 (12:27 -0400)]
TPAC: Refactor bookbag list actions into a common template

The "add to bookbag" actions in both the search results and record
details pages contained a large amount of duplicated code; consolidate
those into a single template that can be included into each page.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoAbility to add records to permanent bookbags in TPAC.
Jason Stephenson [Wed, 11 Jul 2012 12:59:48 +0000 (08:59 -0400)]
Ability to add records to permanent bookbags in TPAC.

Add an actor usr setting for holding the name of a default book
list: opac.default_list.

Add a button on the my list interface to choose a list should as
the default list for adding titles.  There is presently no way to
unset a default menu, though the default can be changed to any
other menu at any time by clicking that list's button.

Modify opac/record and opac/results so that if a patron is logged
in their my lists will populate a menu.  This menu will include
options to add to a temporary list, the default list (if any), up
to 10 of the user's other lists, to add to a newly created list,
or to see all of their lists and add to one that does not appear
on the menu.

Adding to a temporary list will function the same as adding to a
list does prior to this enhancement.

Adding to a list chosen from the menu will add the record to that
list, and return the user to the search results or record page
that they were looking at.

Choosing to add to a new list will take the user to their "my
lists" page where they can create a new list.  After the list is
created, the record they wanted to add will be added to the new
list and they will be returned to the search results or record
that they were looking at.

Choosing the "see all" menu option will also take the user to
their "my lists" page.  However, all of their bookbags will be
visible and not just the normal limit of 10.  Their will be a
button next to each list's name with the text "Add to this list."
When the user clicks one of those buttons, the record will be
added to that list and the user's session redirected back to
their search or result page.

The user will have the option to create a new list when viewing
all of their lists.

The user will also be able to use the "Add to this list" feature
when they have chosen the "Add to new list" menu option.  This is
done from simplicity in the design, but also allows the user to
change their mind at the last second.

If a patron is not logged in, the add to my list will appear the
same as it does prior to this development.  It will continue to
function as it does prior to this development.

Add coust for opac.patron_temporary_list_warn to let an ou enable
warning users when adding records to a temporary book bag.

Add cust opac.temporary_list_no_warn to let patrons disable
the warning for themselves.

Add the opac.default_list usr_setting_type. This will be used to track a
user's default bookbag.

Add the upgrade script to create new coust and custs.

Insert coust (opac.patron.temporary_list_warn) and cust
(opac.temporary_list_no_warn, opac.default_list) into the respective
tables.

Add release notes for add to permanent bookbag feature.

Add a warning when the user adds a record to a temporary list.

TPAC has been modified so that a user will see a warning before adding
a record to a temporary bookbag.  This message serves to inform the
user that they are adding to a temporary list that will disappear when
their session ends.

A new org. unit setting has been added,
opac.patron.temporary_list_warn, that will enable this warning when
set.  Sites may choose not to display this warning.

The user may also set a preference in their search preferences to
disable this warning.  The setting only works when a user is logged
in, of course.

Add release notes for the temporary list warning feature.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoDocumentation: remove those darn Windows carriage returns.
Robert Soulliere [Thu, 19 Jul 2012 17:35:49 +0000 (13:35 -0400)]
Documentation: remove those darn Windows carriage returns.

I am using linux based system for editing so I am not sure where they are coming from.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoDocumentation: Migrate reports documentation from 2.1
Robert Soulliere [Thu, 19 Jul 2012 17:23:18 +0000 (13:23 -0400)]
Documentation: Migrate reports documentation from 2.1

Content reviewed by Jenny Turner. I converted to asciidoc and tested
processing. I also added index terms.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoDocumentation: Format text to limit line length to 80 characters.
Robert Soulliere [Thu, 19 Jul 2012 01:49:02 +0000 (21:49 -0400)]
Documentation: Format text to limit line length to 80 characters.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoAdd Journal Title search to stock TPAC filters
Dan Scott [Thu, 12 Jul 2012 03:37:11 +0000 (23:37 -0400)]
Add Journal Title search to stock TPAC filters

Academics need access to a quick and easy Journal Title search, this
gives it to them. Due to the requirement to combine search index + bib
level, we define a special search index that can then be acted upon
accordingly.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
8 years agoDocumentation: Fix various issues causing errors during processing.
Robert Soulliere [Wed, 18 Jul 2012 14:16:09 +0000 (10:16 -0400)]
Documentation: Fix various issues causing errors during processing.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoTPAC: Use % font size + bold to highlight login failure
Dan Scott [Tue, 17 Jul 2012 16:55:39 +0000 (12:55 -0400)]
TPAC: Use % font size + bold to highlight login failure

Loved the idea to call more attention to login failures, but wanted to
try to stick to % for font sizes where possible. Testing suggested that
font-weight:bold and a little padding on top would help the display as
well.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Melissa Lefebvre <mlefebvre@biblio.org>
8 years agoTpac CSS: Login failure message
Melissa Lefebvre [Fri, 11 May 2012 15:07:50 +0000 (11:07 -0400)]
Tpac CSS: Login failure message

To draw attention to failed logins, the font size was increased
to 16px and the font color changed from black to red.

Signed-off-by: Melissa Lefebvre <mlefebvre@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPAC: Slightly more accessible user-visible account notes display
Dan Scott [Tue, 17 Jul 2012 16:39:37 +0000 (12:39 -0400)]
TPAC: Slightly more accessible user-visible account notes display

Rather than a table layout that resembles an unordered list, use a real
table with table header so that screen readers will know what to
associate each column with.

Also, move the table display into its own class so that we don't pick up
the uppercase transform, and move it out of the div box so that we can
use whatever screen real estate is given to us, rather than forcing
notes into the hard-coded 662px box.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoTPAC: show patron-visible notes in my-account
Bill Erickson [Tue, 19 Jun 2012 18:24:33 +0000 (14:24 -0400)]
TPAC: show patron-visible notes in my-account

Notes display in the 'Account Summary' box on the first page of
my-account.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPAC: Physical description, now with spaces
Dan Scott [Sat, 16 Jun 2012 02:59:23 +0000 (22:59 -0400)]
TPAC: Physical description, now with spaces

Record details will regularly include physical descriptions like
"Physical Description: 1 sound disc :33 1/3 rpm, mono." where the colon
is jammed up against the content from the following subfield. Easily
fixed by using a space as the joiner for the subfields.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
8 years agoMove Prefix field ahead of Names in patron editor
Ben Shum [Wed, 27 Jun 2012 18:01:24 +0000 (14:01 -0400)]
Move Prefix field ahead of Names in patron editor

In earlier versions of Evergreen (1.6 and earlier), the Prefix field
was used to enter title information, such as Mr., Mrs., etc. When the
field was eventually added to the newer patron registration screens
(2.0+), it was added before the patron's last name field. Ideally,
the prefix should be listed prior to the patron's first name instead.

In addition, address label issues by changing "Suffix/Title" back to
only "Suffix" and making "Prefix" into "Prefix/Title".

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoSquelch uninitialized var warning from hold_copy_targeter
Bill Erickson [Mon, 16 Jul 2012 20:56:10 +0000 (16:56 -0400)]
Squelch uninitialized var warning from hold_copy_targeter

open-ils.storage_stderr.log was getting filled with entries like:

"Use of uninitialized value in concatenation (.) or string at
/usr/local/share/perl/5.10.1/OpenILS/Application/Storage/Publisher/action.pm"

... consuming disk space endlessly. Stop that!

(Stealing Lebbeous' footwork and providing a slightly different solution.)

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoSearchbar spacing: move inline CSS into a style
Dan Scott [Mon, 16 Jul 2012 21:22:16 +0000 (17:22 -0400)]
Searchbar spacing: move inline CSS into a style

In keeping with our attempt to control styles via the CSS file rather
than inline overrides, define a class for the searchbar and style that.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Melissa Lefebvre <mlefebvre@biblio.org>
8 years agoTPAC: Search wrapper spacing
Melissa Lefebvre [Tue, 3 Jul 2012 16:53:09 +0000 (12:53 -0400)]
TPAC: Search wrapper spacing

Currently the search box options are "smooshed up" against the
links toolbar.  The following changes address this.

Padding was added to style.css search_box_wrapper in order to
bring the "Search the Catalog" down lower from the link toolbar.

Padding was also added to the searchbar.tt2 in order to bring the
search filter options down lower from the "Search the Catalog"
wording.

Signed-off-by: Melissa Lefebvre <mlefebvre@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoincrease the default width for the xul list line number column
Jason Etheridge [Thu, 10 May 2012 18:18:37 +0000 (14:18 -0400)]
increase the default width for the xul list line number column

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoDocumentation: Add Patron Bills section to Patron Management chapter.
Jennifer Turner [Sat, 14 Jul 2012 22:51:25 +0000 (18:51 -0400)]
Documentation: Add Patron Bills section to Patron Management chapter.

Converted to asciidoc by Robert Soulliere

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoWhen a user views holds in their account, clicking "only available"
Kathy Lussier [Fri, 6 Jul 2012 21:01:51 +0000 (17:01 -0400)]
When a user views holds in their account, clicking "only available"
on the holds screen or "Ready for Pickup" in the navbar will add an
"available=1" parameter. However, if the user then attempts to return
to a list of all holds, the "available" parameter is not cleared, and
the user will only see holds available for pickup.

This commit will clear those parameters.

Signed-off-by: Kathy Lussier <kmlussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoDocumentation: Add Circulation, Patron management Chapter
Jennifer Turner [Fri, 13 Jul 2012 18:16:32 +0000 (14:16 -0400)]
Documentation: Add Circulation, Patron management Chapter

Content provided by Jennifer Turner at PALS. Converted to Asciidoc by Robert Soulliere. Robert also added indexing terms. Appendices for documentation cleaned up as well.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoTPAC: Use .staff variant for MARC Expert Search
Dan Scott [Fri, 13 Jul 2012 13:56:54 +0000 (09:56 -0400)]
TPAC: Use .staff variant for MARC Expert Search

Inside the staff client, we want to use the .staff method to retrieve
records that match the MARC Expert Search, so that records with no
attached copies can be found and returned.

Fixes LP # 1024382.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoCache propagated funds in fund rollover action
Bill Erickson [Mon, 11 Jun 2012 19:23:17 +0000 (15:23 -0400)]
Cache propagated funds in fund rollover action

Repair display of propagated funds grid which was likely broken with
b9bb6d47.  Propagated funds must be collected and added to the local
cache for grid getter functions to find them.

https://bugs.launchpad.net/evergreen/+bug/1011789

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoRepair PCrudFilter localeStrings variable collisions
Bill Erickson [Mon, 11 Jun 2012 19:19:48 +0000 (15:19 -0400)]
Repair PCrudFilter localeStrings variable collisions

Rename PCrudFilter's localeStrings global variable to avoid name
collisions with UI scripts that define the same variable.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoSet unix file format to remove trailing "\r"s in file.
Robert Soulliere [Thu, 12 Jul 2012 19:46:29 +0000 (15:46 -0400)]
Set unix file format to remove trailing "\r"s in file.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoAdd Group Serials Issues Chapter from Sally Fortin at Equinox Software. Source: http...
Sally Fortin [Thu, 12 Jul 2012 19:36:03 +0000 (15:36 -0400)]
Add Group Serials Issues Chapter from Sally Fortin at Equinox Software. Source: esilibrary.com/esi/availableDocs.php.

Tested in documentation  processing.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoTPac: Disable caching for auth-required pages
Thomas Berezansky [Thu, 14 Jun 2012 17:41:33 +0000 (13:41 -0400)]
TPac: Disable caching for auth-required pages

To make back buttons less likely to show sensitive info.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoSilence undef string concatenation warning in AutoSuggest
Lebbeous Fogle-Weekley [Thu, 12 Jul 2012 13:16:12 +0000 (09:16 -0400)]
Silence undef string concatenation warning in AutoSuggest

Addressing LP #1023651 reported by Dan Scott.

When building a cache key, use processed input values that are
guaranteed to be defined rather than raw ones.

This will mean brief cache misses for AutoSuggest once applied, but
the default life of AutoSuggest cache entries is only 5 minutes anyway.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoFix titles/tabs in Account Preferences subpages
Jeff Godin [Wed, 11 Jul 2012 15:54:34 +0000 (11:54 -0400)]
Fix titles/tabs in Account Preferences subpages

Adjust the value of myopac_page in the Notification Preferences and
Search Preferences pages so that the page title and tab
color/hilight will be correct.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dan@coffeecode.net>
8 years agoGet Z39.50 source names to be linked as expected
Dan Scott [Wed, 11 Jul 2012 22:41:55 +0000 (18:41 -0400)]
Get Z39.50 source names to be linked as expected

The direct thead/th approach appeared to be interfering with the JS
event that was supposed to link the Z39.50 source names; adding the
expected tr layer resolved that.

Signed-off-by: Dan Scott <dan@coffeecode.net>
8 years agoZ39.50 attributes management interface
Bill Erickson [Tue, 19 Jun 2012 14:23:22 +0000 (10:23 -0400)]
Z39.50 attributes management interface

From the release notes:

There is a new interface for managing Z39.50 attributes on a Z39.50
source.  The interface is linked from each source name in the Z39.50
Source administrative interface.

Cloning
~~~~~~

In addition to attribute creation, deletion, and editing, it's also
possible to clone a set of attributes from one source into another.
When cloning, any attributes present in the cloned source that are
not present in the destination source are copied into the destination
source.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dan@coffeecode.net>
8 years agoFlattener grid defines override args in constructor
Bill Erickson [Tue, 19 Jun 2012 14:18:44 +0000 (10:18 -0400)]
Flattener grid defines override args in constructor

...instead of the seconday load handler.  Otherwise, the
grid.overrideEditWidget, etc. containers may be undefined at page load
time.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dan@coffeecode.net>
8 years agoRepaired typo in example rsyslog config file
Bill Erickson [Tue, 26 Jun 2012 17:54:53 +0000 (13:54 -0400)]
Repaired typo in example rsyslog config file

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dan@coffeecode.net>
8 years agoTPAC: Handle multiple matches for an XPath expression
Dan Scott [Fri, 15 Jun 2012 17:25:29 +0000 (13:25 -0400)]
TPAC: Handle multiple matches for an XPath expression

Per LP 1009980, "If a record has multiple subfield b's in the 260 field,
tpac will not display the publisher or publication date in the record
details page and will not display the publisher on the search results
page".

This is because we're calling textContent on a nodeset, rather than an
individual node, and therefore get null back rather than any content.

To avoid this, always expect a nodeset and iterate over it to populate a
list of the strings.  To maintain the same semantics of expecting a
single text string back for, say, args.pubdate, we define the list as
args.pubdates (plural name), and then grab the first item from the list
and populate that as args.pubdate (singular name).

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoAvoid problem with 2.1 -> 2.2 upgrade script issuing error
Lebbeous Fogle-Weekley [Wed, 11 Jul 2012 14:54:44 +0000 (10:54 -0400)]
Avoid problem with 2.1 -> 2.2 upgrade script issuing error

The error is:
    > ERROR: cannot ALTER TABLE "thesaurus" because it has pending
    > trigger events.

Reported by Justin Hopkins, George Duimovich, and Bill Erickson.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Justin Hopkins <hopkinsju@gmail.com>
8 years agoTPac: Add paging to My Lists
Bob Wicksall [Fri, 29 Jun 2012 18:33:22 +0000 (14:33 -0400)]
TPac: Add paging to My Lists

- Added paging to My Lists based on the code from the Checkout History tab.
- Fixed a bug where adding more than 10 items to the Temporary list failed
- After adding paging renaming a list on page 2+ would fail.  Fixed.
- Redirect after saving a list now leaves you on the same page
- Paging was bleeding between My Lists, Holds History and Circ History.
  Fixed.

List contents were also limited to the first 10.  I have upped the limit to
1000 rather than having nested paging.  This should be revisited.

CSV download of lists is still limited to the first 10.  Not sure where to
fix this.

Signed-off-by: Bob Wicksall <bwicksall@pls-net.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoUpdate Evergreen upgrade instructions to reflect the 2.2.0 release. user/rsoulliere/docs_update_evergreen_upgrading_instructions_2_2_0
Robert Soulliere [Tue, 19 Jun 2012 16:23:55 +0000 (12:23 -0400)]
Update Evergreen upgrade instructions to reflect the 2.2.0 release.

Update download reference to point to 2.2.0. Also moved
database updates to the end of the process. It seemed out of order since
the database update scripts were run before the download of the 2.2 tar file.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoTeach the autosuggest web service to cache suggestions where appropriate
Mike Rylander [Tue, 26 Jun 2012 19:03:37 +0000 (15:03 -0400)]
Teach the autosuggest web service to cache suggestions where appropriate

Should spare some DB load on sites.

LFW: I'm not sure the update to the Apache config made any difference,
but it doesn't hurt.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoOrg unit retrieval cleanup
Bill Erickson [Mon, 12 Mar 2012 19:05:50 +0000 (15:05 -0400)]
Org unit retrieval cleanup

Clean up and consolidate the various org unit retrieval method (in Perl)
to reduce code/confusion and make it easier to integrate changes to the
org unit tree in the future.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
8 years agotpac: repair some straggling bookbag CGI param names
Bill Erickson [Tue, 12 Jun 2012 20:04:09 +0000 (16:04 -0400)]
tpac: repair some straggling bookbag CGI param names

We missed some going from "id" to "bbid"

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
8 years agoAcq: fix widget choice for user-linked fields in Acquisitions Search
Lebbeous Fogle-Weekley [Wed, 20 Jun 2012 15:13:11 +0000 (11:13 -0400)]
Acq: fix widget choice for user-linked fields in Acquisitions Search

The Acquisitions Search interface (which also sits underneath the
Purchase Orders inteface, My Selection Lists, and one or two others)
stopped presenting the correct widget for search terms linked to
actor.usr.  This was brought on when PCRUD control was added to
actor.usr, so that means the bug affects only master, not rel_2_2 or
earlier.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agolp#1014664: add new columns to CDBI table definitions
Galen Charlton [Mon, 18 Jun 2012 14:11:17 +0000 (10:11 -0400)]
lp#1014664: add new columns to CDBI table definitions

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoFix Title Holds
Thomas Berezansky [Wed, 13 Jun 2012 17:16:51 +0000 (13:16 -0400)]
Fix Title Holds

Holdable formats was being filled in with oargs, causing random failures.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoFix version numbers in 2.1 -> 2.2 upgrade script
Lebbeous Fogle-Weekley [Thu, 21 Jun 2012 14:01:56 +0000 (10:01 -0400)]
Fix version numbers in 2.1 -> 2.2 upgrade script

Justin Hopkins spotted the problem, and offered a fix in LP #1015807.
I'm just doing it slightly differently here.  Thanks Justin!

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoStop editing README header
Thomas Berezansky [Tue, 19 Jun 2012 20:43:42 +0000 (16:43 -0400)]
Stop editing README header

We no longer have the version in the README header, so we don't need to
update it with a new value.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dan@coffeecode.net>
8 years agoAvoid file extensions on scripts
Dan Scott [Thu, 14 Jun 2012 19:16:51 +0000 (15:16 -0400)]
Avoid file extensions on scripts

Borrowing from the Debian policy, you might reimplement the same
functionality using a different language such as Perl or Python. So
avoid having a file extension in the first place. What are we, Windows
users?

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoRevert to generic ftp.mozilla.org hostname
Dan Scott [Mon, 4 Jun 2012 16:33:56 +0000 (12:33 -0400)]
Revert to generic ftp.mozilla.org hostname

download02.mozilla.org started returning 403 errors; ftp.mozilla.org
seems to work again, so let's go with that.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agogit2cl mangles the changelog; let's just use git's log
Dan Scott [Sun, 3 Jun 2012 03:25:53 +0000 (23:25 -0400)]
git2cl mangles the changelog; let's just use git's log

git2cl does bizarre things to line wrapping. The log it generates looks
deranged. Let's just use what git gives us; it's clean and easy to
parse, even if it doesn't adhere to the GNU changelog standards
(www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html).

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoRelease Building Script
Thomas Berezansky [Wed, 28 Sep 2011 19:05:22 +0000 (15:05 -0400)]
Release Building Script

make_release.sh [-v VERSION] [-f PREV_BRANCH | -t | -b] [-F PREV_VERSION] [-n] [-p]
   VERSION is auto-detected by default and is based on the currently checked out branch.
   PREV_BRANCH is auto-detected by default but that isn't reliable. Include remote name!
   PREV_VERSION Is auto-detected by default and is based on the PREV_BRANCH's name.
   -n specifies that you don't want an upgrade script to be auto-generated.
   -p specifies that this is a preview build.
   -t turns on tag only mode.
   -b turns on build only mode.
   NOTE: -t and -b override PREV_BRANCH/PREV_VERSION, but -b overrides -t.

When building a release you should have git2cl in your PATH as well as
all packages needed for building i18n and staff clients.

Usage examples:

Tagging a major version root (no need for git2cl/staff client deps):

    git checkout -b rel_X_Y origin/master
    build/tools/make_release.sh -t

Building a release:

    git checkout -b rel_X_Y_Z rel_X_Y
    build/tools/make_release.sh

Building a new major release:

    git checkout -b rel_X_Y_Z rel_X_Y
    build/tools/make_release.sh -f origin/tags/rel_U_V_W

Specifying a version outright:

    build/tools/make_release.sh -v X.Y.Z

Very Specific Example: Building the 2.2 RC1 release:

    git checkout -b rel_2_2_rc2 origin/rel_2_2
    build/tools/make_release -f origin/rel_2_1 -n -p

Release files are placed in a "release" folder one level up from your git
root directory.

Nothing is pushed to remote servers, but dojo and xulrunner files may be
downloaded. Dojo to install in the release tarball properly, xulrunner for
building the staff client and avoiding issues with xulrunner changes if
end-users build a custom staff client (say, for autoupdate purposes).

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dan@coffeecode.net>
8 years agoTPAC: Add record detail navigation to page bottom
Dan Scott [Sat, 16 Jun 2012 02:10:15 +0000 (22:10 -0400)]
TPAC: Add record detail navigation to page bottom

A usability rule of thumb suggests that navigation on long pages should
not require you to scroll back up to the top of the page from the
bottom; that gets old fast. We already do this on search results pages;
bring the same good practice to record details.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
8 years agoRemove antiquated 1.6 directory from docs folder.
Robert Soulliere [Thu, 14 Jun 2012 18:35:24 +0000 (14:35 -0400)]
Remove antiquated 1.6 directory from docs folder.

This was used for early DocBook testing and is no longer needed.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
Signed-off-by: Dan Scott <dan@coffeecode.net>
8 years agoSecurity fix: For auth, give same stacktrace for all cases of LOGIN_FAILED
Lebbeous Fogle-Weekley [Tue, 12 Jun 2012 21:26:39 +0000 (17:26 -0400)]
Security fix: For auth, give same stacktrace for all cases of LOGIN_FAILED

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoSecurity fix: Prevent login by deleted and barred users
Lebbeous Fogle-Weekley [Mon, 11 Jun 2012 18:16:34 +0000 (14:16 -0400)]
Security fix: Prevent login by deleted and barred users

An existing comment in the code suggested that we thought we were already
keeping barred users out.  LP #1010671 brings up that deleted users were
not being kept out.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoSecurity fix for Launchpad Bug 1003052.
Jason Stephenson [Mon, 11 Jun 2012 20:12:54 +0000 (16:12 -0400)]
Security fix for Launchpad Bug 1003052.

Bug reported by James Fournie:

Revoking the UPDATE_MARC permission doesn't actually seem to prevent a
user from editing a record. Our use case is that we would like a user
to create new records but not edit existing MARC records.

Changing CREATE_MARC to UPDATE_MARC in OpenILS::Application::Cat's
biblio_record_replace_marc() method seems to fix the problem.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>