Jason Boyer [Wed, 16 Jan 2019 13:36:40 +0000 (08:36 -0500)]
LP1742521: Receipt Count Repair
The div wrapping the receipt printing controls was
shown or hidden using an ng-if declaration which
created a new $scope as explained in bug 1696238,
which caused the controller to not notice that the
value was changed. Changing that to an ng-show
allows the updated value to get where it needs to
be.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Add a deprecation warning to the Hatch configuration page notifying
users that Hatch for storage is deprecated. Includes suggestions on how
to migrate away from Hatch for storage.
Remove the unusued "Use Hatch for Offline Files" option.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Cesar Velez [Fri, 7 Dec 2018 23:50:43 +0000 (18:50 -0500)]
LP1765179 - fix issue with pending/staged user reg
After completing a staged user registration, the controller
in regctl.js was refreshing to the same route, and
trying to fetch the same staged user, but never finding it
as it was no longer staged/pending. This addresses that bug
and adds a bChannel refresh to the pending grid, so once
the user is registered in the child tab, it closes the tab and
the pending user grid is updated.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
abneiman [Wed, 12 Dec 2018 19:48:35 +0000 (14:48 -0500)]
docs: LP1258628: screenshots & updates to actiontriggers.adoc
Added a handful of screenshots; added language for Message Center definitions, and pulled in language about testing action triggers from this document: http://docs.evergreen-ils.org/dev/_creating_action_triggers.html
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Thu, 27 Sep 2018 14:53:35 +0000 (07:53 -0700)]
LP1782652: Make template dropdown larger in Volume/Copy Editor
To test:
1) Open an item in the volume/copy editor.
2) Go to the Copy Templates tab. Note the spacing of the template bar.
3) Create a few templates. Give them names of 30 characters or more.
4) Go back to the Edit tab and select one of your new templates. Note
that after you have selected it, the name of your template does not fit
in the dropdown box, and is cut off at the end.
5) Apply this commit.
6) Go to the Copy Templates tab again. Note that the spacing of the
template bar has not changed.
7) Go to the Edit tab. Note that the template dropdown has changed
to be much larger.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Janet Schrader <jschrader@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
- Change record_type to TEXT rather than an enum, constrained
with the option of "authority" or "bib"
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/sql/Pg/012.schema.vandelay.sql
new file: Open-ILS/src/sql/Pg/upgrade/XXXX.schema.vandelay-record-type-fix.sql
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Jason Stephenson [Wed, 12 Dec 2018 18:24:01 +0000 (13:24 -0500)]
Lp 1730726: Fix lp1501781-unaccent_and_squash.pg for PostgreSQL 9.6
PostgreSQL 9.6 apparently exhibits the same behavior as Postgresql 10
when it comes the OE ligature in the unaccent function. We modify the
test case to take that into account.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Ben Shum <ben@evergreener.net>
Lp 1730726: Fix lp1501781-unaccent_and_squash.pg for PostgreSQL 10
PostgreSQL 10 has improvements in the unaccent function used by the
evergreen.unaccent_and_squash function. The test needs a small
modification to take this into account. Actual code change from Mike
Rylander with a little typo fix.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Ben Shum <ben@evergreener.net>
Lp 1730726: Fix a number of PgTap tests for PostgreSQL 10.
A number of tests disabled output via "\set ECHO". In PostgreSQL 10,
the lack of a value in \set is an error. We change these lines to
"\set ECHO none".
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Ben Shum <ben@evergreener.net>
Lp 1730726: Basic Patch to build the database with PostgreSQL 10.
* Modify the evergreen.org_top() function, with code from Galen
Charlton, to be non-set returning.
* Modify Open-ILS/src/support-scripts/eg_db_config.in to not strip the
period from PostgreSQL version numbers and to use the first two
components when checking for supported PostgreSQL versions.
* Add link from Open-ILS/src/sql/Pg/000.english.pg94.fts-config.sql
to Open-ILS/src/sql/Pg/000.english.pg10.fts-config.sql.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Ben Shum <ben@evergreener.net>
For standalone DB server install, ensure that we are applying the proper
PostgreSQL community apt repo for packages.
DO NOT backport this branch. There are presently known issues with
Ubuntu 18.04 and email generation from action/trigger and other
interfaces. We plan to address these before the 3.3 release, but do
not necessarily expect to backport those fixes.
Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Jason Stephenson <jason@sigio.com>
Jason Stephenson [Tue, 25 Sep 2018 15:47:05 +0000 (11:47 -0400)]
LP#1793585: Fix Unescaped left brace in regex Perl error.
Running make check results in the following error on Perl 5.26:
Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/\${ <-- HERE EMAIL_SENDER}/ at Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/HoldNotify.pm line 358.
Prior to Ubuntu 18.04 and Perl 5.26, this was a deprecation warning.
This commit fixes the regular expressions in HoldNotify.pm to escape
the left braces to make this error/warning go away.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Ben Shum <ben@evergreener.net>
Changes to Makefile.install to support this version of Ubuntu.
Note: We are using PG9.6 from the PostgreSQL apt source instead of the
standard PG10 version that ships with Ubuntu 18.04. Further testing required
before we switch PG versions so relying on a known working version for now.
Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Jason Stephenson <jason@sigio.com>
Terran McCanna [Wed, 12 Dec 2018 22:57:19 +0000 (17:57 -0500)]
LP#1743783 Web Client Bill Full Detail Display Issues
Fleshes out retrieved data to be able to display the billing
location for both circulation and grocery bills on the full
details page as well as the owning library for circulation bills.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
- Call Number
- Owning Library
- Shelving Location
- Last Billing Note
- Last Billing Timestamp
- Last Payment Timestamp
- Last payment Note
- Last Payment Type
2) Corrected path for Type
3) Changed column name for Location to 'Billing Location'
and the former Billing Location to 'Grocery Billing Location' for clarity
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Remington Steed [Wed, 12 Dec 2018 16:36:17 +0000 (11:36 -0500)]
Docs: Fix screenshot file name
The asciidoc is looking for "My_Lists_dd.png", but the file has a
capitalized extension ".PNG". This commit renames the file to match the
code, since lowercase is our common naming convention.
Remington Steed [Mon, 26 Nov 2018 19:10:36 +0000 (14:10 -0500)]
Docs: LP#1731048: Update json_query documentation for new join syntax
This commit simply adds the text from the related commit message (see
LP#1527731) to the original DocBook file. NOTE: This documentation is
also available on the wiki, and has been updated there as well:
Jason Boyer [Fri, 7 Dec 2018 15:05:43 +0000 (10:05 -0500)]
LP1807398: Add workstation to marc_stream_importer
In order to work properly with vandelay session
tracking in 3.2+ a workstation is required at login.
This branch adds a workstation option to the importer
and alerts the user if it's missing.
Signed-off-by: Jason Boyer <JBoyer@library.in.gov> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Ben Shum [Sun, 9 Dec 2018 08:11:48 +0000 (03:11 -0500)]
Docs: Followup commit to fix screenshot for My_Lists3.jpg
The previous commit added some new screenshots for My_Lists, but this one
was saved with .JPG extension instead of .jpg so the original file was
retained.
katiegmartin [Thu, 2 Aug 2018 19:06:28 +0000 (15:06 -0400)]
Docs: LP1783387: update print templates to reflect new name
launchpad 1783387 - update receipt template editor documentation to reflect language change to "print templates" in web client
put both terms in index
updated title to Print (Receipt) Templates
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Added a section on how to apply a binding template to a distribution as this is necessary to ensure the binding does not fail. Also updated an instance of "Action" to "Actions".
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Remington Steed [Mon, 26 Nov 2018 15:04:28 +0000 (10:04 -0500)]
LP#1739606: Allow saving Billing History xacts grid
For a web staff eg-grid to save and retrieve its settings, it needs a
unique persist-key. This commit adds one for the Transactions tab grid
under Billing History (on patron record Bills tab, click the History
grid button).
Adds a new dedicated patron parent/guardian field. This field is
editable in the patron edit interface, displays in the patron summary
side bar on the browser client, and is search-able from the patron
search interface in the browser client.
Adds patron editor "show" and "suggest" library settings.
Also adds a new library setting
'ui.patron.edit.guardian_required_for_juv' ("GUI: Juvenile account
requires parent/guardian"). When this setting is applied, a value
will be required in the patron editor when the juvenile flag is active.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Way back when, we switched from a misspelled 'clense_ISO8601' to a
corrected 'cleanse_ISO8601' in OpenSRF. This function has again moved,
and is now part of OpenILS::Utils::DateTime, and is named
'clean_ISO8601'. This was done as part of LP bug #1552778.
However, a few stragglers of the misspelling remained, so these were
missed when the big changeover occurred. This hopefully catches them
all!
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Jason Boyer [Tue, 20 Nov 2018 16:54:50 +0000 (11:54 -0500)]
LP1793154: Cancel Holds from OPAC Record
The name of the grid handler was misspelled
in the holds grid for records in the opac.
Swapping the location of the 'wide' part of
the function name will allow it to match up
with the functions available in the holds
grid module.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Garry Collum [Sat, 16 Jun 2018 18:13:22 +0000 (14:13 -0400)]
LP#1761242 Z39.50 Marc View Usability with Mobile Repsonsiveness
This patch changes the size of the image in the Z39.50 Marc View from large to
medium. It also incorporates bootstrap's media classes to present the Marc
record and the cover image side by side. If there is no image the marc record
display floats to the left of the modal. From a suggestion by Jane Sandbert, it
also hides the book cover image on small devices.
To test.
1. Perform a search in z39.50. An LOC title search for "Cat in the Hat"
returms results of titles with and without images.
2. View some of the titles in Marc View, noting the large image.
3. Apply the patch.
4. Perform the same search and view the results in Marc View.
MODS 3.3 support was introduced in March 2009, but this
change was never included in an upgrade script. Older
sites on 3.1+ will need to apply this update to avoid scary
segmentation faults, and it should be harmless for newer
sites and desirable for those on 3.0 or older.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Ben Shum <ben@evergreener.net>
The hold shelf rewrite brought back an old behavioral bug where items deleted
while on the hold shelf continued to show on the hold shelf list. The most
recent behavior was to ignore those items, which this commit does. It also
addresses an adjacent issue where holds may show with "Hold Shelf Delay"
instead of "Ready For Pickup" in some cases.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com> Signed-off-by: Ben Shum <ben@evergreener.net>
Jason Boyer [Thu, 15 Nov 2018 16:43:30 +0000 (11:43 -0500)]
LP1755625: Multiple emails in patron editor
Even though the HTML5 "email" input type allows multiple
addresses to be separated by commas there is nothing that
can be done to signal to Angular.js that this is ok; it
will only ever accept a single address. This patch forces
the type of the input tag to plain text so Angular will
rely on any supplied regex to verify the entry.
The ui.patron.edit.au.email.regex (Regex for email field on patron
registration) library setting can be used to control whether
one or multiple email addresses will be permitted on the
patron registration form.
To test
-------
[1] In the web staff client, try to register a new patron, entering
multiple email addresseses in the email field separated by
commas.
[2] Note that the email field displays as invalid and the
record cannot be saved.
[3] Apply the patch and repeat step #1, This time, the email
field should accept multiple addresses.
[4] Set the Regex for email field on patron registration library
setting to the multiple-email form listed above. Reload
the patron registration form and verify that it will
continue to accept multiple email addresses but will not
accept entry that doesn't look like an email address.
[5] Set the library setting to the single-address value. Reload
the patron registration form; this time it should accept
a valid email address but not multiple ones.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
The pane in the web-based staff client to display penalties and messages
currently has a label of "Staff-Generated Penalties/Messages", which is
misleading as the list includes system-generated penalties and messages.
Modify this to "Penalties and Messages" to avoid the "/" construction
(which is considered harder to translate) and avoid the impression that
it contains only staff-generated penalties and messages.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <ben@evergreener.net>
Actually installing a language also runs updatepo and subsequently attempts
to copy the various dtd and property files to their correct places.
Remove from the Makefile target for install, but retain the dtd web opac
folder which is apparently where we put fieldmapper and some other files
later.
Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Bill Erickson [Tue, 6 Nov 2018 14:42:17 +0000 (09:42 -0500)]
LP#1797007 Grid cell tooltips apply to all cells (Ang)
Avoid excessive browser page re-flows, caused by checking cell
widths for rendering tooltips, by rendering tooltips for all cells
regardless of the size of the content.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Avoid excessive browser page re-flows, caused by checking cell widths
for rendering tooltips, by rendering tooltips for all cells regardless
of the size of the content.
Ben Shum [Mon, 5 Nov 2018 19:03:44 +0000 (14:03 -0500)]
LP#1757455: Deprecate i18n building for XUL client
Remove older dtds and properties files from the Makefile for i18n build
process.
To test
-------
[1] Apply patch.
[2] Make a change to a XUL properties or DTD file
[3] Run 'make newpot' in build/i18n.
[4] Verify that your change is not reflected in the updated POT files.
Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP#1783440: adding UPC to numeric search types in advanced search
To test
-------
[1] Go the Advanced Search page in the public catalog, then to the
Numeric Search tab.
[2] Search on a UPC value (e.g., in Concerto, "883929159529").
[3] Verify that a hit is retrieved.
For some strange reason the volcopy bchannel event data.records
would be an array of string integers or a array of ints depending
on whether you're adding or editing holdings. This addresses that
weirdness.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Mike Rylander [Fri, 14 Sep 2018 15:03:30 +0000 (11:03 -0400)]
LP#1684202: Protect against missing features; Make feature more general
I've wrapped the BroadcastChannel code in a test derived from the auth version
of the same concept. Also broadcasting the full set of record IDs and the
pre-update call number IDs for other interfaces that might be interested. The
channel name is also made more generic and made to follow the precedent from
the auth channel name.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Located URIs depend upon bib-level visibility, as there are no copies
to work with. The browse code, however, was joining in the copy
visibility table as if it would always have at least one row per bib,
but in the case of located URIs, it does not.
Let's change it to a LEFT JOIN to allow the bib row to show up, at
which point the existing bib visibility check can do its job.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Mike Rylander <mrylander@gmail.com>
The default tab selection was not being honored from catalog searches,
as the search had already set $scope.record_tab, and we were honoring
that value in all cases.
Instead, let's honor that value in cases where the OPAC load doesn't
change our current record, which should only happen if we load the
record directly to a non-opac tab, then go to the OPAC view.
To test:
1) Set any tab other than "OPAC View" as your default view in record
details.
2) Do a catalog search.
3) Select a record, and notice your default view is not set.
4) Apply patch, do the same steps, and notice the default view is now
selected.
To test regression of bug #1708951:
1) In Firefox, load a record directly (e.g.
/eg/opac/staff/cat/catalog/record/123).
2) Note the default view loaded.
3) Click "OPAC View".
4) Note the view does not return to your default view, but stays on
the OPAC.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Jason Boyer <JBoyer@library.in.gov>
projects / working / Evergreen.git / log