working/Evergreen.git
5 years agoLP#1339767: follow-up: Thumbs.db, not Thumbs.DB
Galen Charlton [Wed, 9 Jul 2014 16:07:32 +0000 (09:07 -0700)]
LP#1339767: follow-up: Thumbs.db, not Thumbs.DB

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1339767: add Thumbs.DB to .gitignore
Galen Charlton [Wed, 9 Jul 2014 15:47:09 +0000 (08:47 -0700)]
LP#1339767: add Thumbs.DB to .gitignore

Removes a minor annoyance for documenters who use recent
versions of Windows

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoDocumentation: Add the authentication proxy chapter
Robert Soulliere [Thu, 3 Jul 2014 15:18:15 +0000 (11:18 -0400)]
Documentation: Add the authentication proxy chapter

- Some content taken from the 2.2 release notes.
- Added a few steps on how to set up authentication proxy in Evergreen.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
5 years agoDocs: Minor wording change
Erica Rohlfs [Fri, 30 May 2014 19:12:29 +0000 (15:12 -0400)]
Docs: Minor wording change

Signed-off-by: Erica Rohlfs <erohlfs@esilibrary.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 years agoLP#968514: Revive bib/auth importing docs from 2.1, add intro
Remington Steed [Fri, 6 Jun 2014 15:59:58 +0000 (11:59 -0400)]
LP#968514: Revive bib/auth importing docs from 2.1, add intro

This commit revives the following sections from the 2.1 version of the docs
and updates them for 2.6:

  - marc_export: Exporting Bibliographic Records into MARC files
    - includes new options for 2.6
  - Importing Authority Records from Command Line
  - Importing Authority Records from the Staff Client

The first two are included in a new section called "Support Scripts"
within the "Developer Resources" section, with a new intro and summary
of other commonly used scripts provided with Evergreen. The third section
is moved inside the Cataloging chapter "Batch Importing MARC Records",
with slight modifications to the intro to that chapter.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 years agoDocumentation: added "search URL" text inside of "using OPAC" section
Yamil Suarez [Tue, 1 Jul 2014 18:58:33 +0000 (14:58 -0400)]
Documentation: added "search URL" text inside of "using OPAC" section

Replaces temporary text that was accidentally added to the "using OPAC" section.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
5 years agoDocumentation: Added 'Using the OPAC' documentation & OPAC WCAG support mention
Yamil Suarez [Mon, 30 Jun 2014 21:55:46 +0000 (17:55 -0400)]
Documentation: Added 'Using the OPAC' documentation & OPAC WCAG support mention

Older DocBook content that covered how to do searches on the OPAC was updated
to use Asciidoc. Also a simple mention of the 2.6 OPAC WCAG support was added.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
5 years agoDocumentation for Located URI Visibility
Kathy Lussier [Fri, 27 Jun 2014 19:31:56 +0000 (15:31 -0400)]
Documentation for Located URI Visibility

Documentation for the new visibility options available for Located URI's
in 2.6.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoFix syntax in filter_group_selector.tt2
Dan Wells [Thu, 26 Jun 2014 21:46:30 +0000 (17:46 -0400)]
Fix syntax in filter_group_selector.tt2

Attempt to fix build breakage introduced by 7e4e9d669

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1326149 Use a TPAC-settable TIME_FORMAT for local time formats
Dan Scott [Wed, 4 Jun 2014 17:09:48 +0000 (13:09 -0400)]
LP#1326149 Use a TPAC-settable TIME_FORMAT for local time formats

We had tried to use the format.time library setting, but that is meant
for Dojo which uses the Unicode formats, that are incompatible with
the POSIX strftime() formats required by Template::Plugin::Date.

At the same time, we need to expose the raw machine-readable time
for schema.org consumers, so express that in a @content attribute.

And we might as well use a more meaningful <time> element instead of
the meaningless <span>, just for good measure.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1301599 improved TPAC jacket alt text
Bill Erickson [Thu, 10 Apr 2014 21:11:21 +0000 (17:11 -0400)]
LP#1301599 improved TPAC jacket alt text

Change "Image of Item" to "Book Cover" as it's slightly more
descriptive/specific.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1301599 Remove duplicate title attributes
Bill Erickson [Fri, 30 May 2014 16:55:47 +0000 (12:55 -0400)]
LP#1301599 Remove duplicate title attributes

Thanks to Ben Shum for spotting these!

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1301599 Additional TPAC facets structure markup
Bill Erickson [Thu, 10 Apr 2014 20:59:14 +0000 (16:59 -0400)]
LP#1301599 Additional TPAC facets structure markup

Labeling facets with <h4> tags provides additional page structure for
screen readers in the TPAC results pages.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1301599 TPAC replace aria-label with title
Bill Erickson [Thu, 10 Apr 2014 20:49:36 +0000 (16:49 -0400)]
LP#1301599 TPAC replace aria-label with title

As appropriate, replace aria-label attributes with traditional HTML
title attributes.

For ref, from the LP entry:

http://www.w3.org/TR/2013/WD-aria-in-html-20131003/#first-rule-of-aria-use

"If you can use a native HTML element [HTML5] or attribute with the
semantics and behaviour you require already built in, instead of
re-purposing an element and adding an ARIA role, state or property to
make it accessible, then do so."

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1301599 TPAC add missing metabib filter label
Bill Erickson [Thu, 3 Apr 2014 18:53:36 +0000 (14:53 -0400)]
LP#1301599 TPAC add missing metabib filter label

In the quick search bar along the top.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1301599 TPAC advanced search from labels
Bill Erickson [Thu, 3 Apr 2014 17:31:29 +0000 (13:31 -0400)]
LP#1301599 TPAC advanced search from labels

Instead of using titles / aria-labels directly on advanced search
selectors, provide selector IDs so the existing text labels can be
turned into <labels> and linked (by id) to their form control.

This means we only need one label per form control, which improves
usability from an accessibility perspective.

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1301599 TPAC advanced search additional labels
Bill Erickson [Wed, 2 Apr 2014 20:46:25 +0000 (16:46 -0400)]
LP#1301599 TPAC advanced search additional labels

Provides a number of labels, primarily for select widgets, in the TPAC
advanced search form for improved accessibility.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1301599 TPAC result table accessibility improvements
Bill Erickson [Wed, 2 Apr 2014 20:43:49 +0000 (16:43 -0400)]
LP#1301599 TPAC result table accessibility improvements

* Give the main result table a screenreader-only header to describe the
  table columns.
* Set the role=presentation in one of the sub-tables used only for
  layout.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#925776 Add placeholder script for backport to 2.5 for function staff uri visibility
Ben Shum [Thu, 26 Jun 2014 19:33:30 +0000 (15:33 -0400)]
LP#925776 Add placeholder script for backport to 2.5 for function staff uri visibility

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#925776 Stamping upgrade script for staff uri visibility
Ben Shum [Thu, 26 Jun 2014 19:30:26 +0000 (15:30 -0400)]
LP#925776 Stamping upgrade script for staff uri visibility

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#925776 Adding upgrade script
Mike Rylander [Fri, 2 May 2014 13:42:28 +0000 (09:42 -0400)]
LP#925776 Adding upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#925776: Recheck located uri visibility
Mike Rylander [Fri, 2 May 2014 13:10:09 +0000 (09:10 -0400)]
LP#925776: Recheck located uri visibility

Previous to this commit, once we have determined that there are no
local Located URIs or foreign copies, we include the record in the
result set in the staff client.  However, the desire of library staff
is that foreign Located URIs be valid as a visibility limiter.  So
we now recheck at the end for that situation.  This honors the new
"Located URIs act like copies" global flag.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoForward port 2.5.5 and 2.6.1 upgrade scripts
Dan Wells [Fri, 6 Jun 2014 13:19:58 +0000 (09:19 -0400)]
Forward port 2.5.5 and 2.6.1 upgrade scripts

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1303544 Trim junk from the ISBN in record summary
Dan Scott [Fri, 6 Jun 2014 00:27:39 +0000 (20:27 -0400)]
LP#1303544 Trim junk from the ISBN in record summary

When asserting that we are publishing an ISBN, move the "(pbk.)"
and similar such matter outside of the schema.org <span property="isbn">
element.

See "The walking dead" in the sample dataset for an example.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1326983: excluded fulfilled holds when adding hold_request.shelf_expires_soon...
Galen Charlton [Thu, 5 Jun 2014 22:16:23 +0000 (15:16 -0700)]
LP#1326983: excluded fulfilled holds when adding hold_request.shelf_expires_soon events

This patch adjusts the example A/T filter for the
hold_request.shelf_expires_soon hook to exclude hold requests that are
already marked as fulfilled.  This saves time creating events that
would immediately be marked as invalid per the HoldIsAvailable
validator.

It also addresses an issue for large databases that have lots of
fulfilled holds wherein hold_request.shelf_expires_soon events can
fail to be added at all due to a cstore timeout.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1326806 Minor repairs to EDI admin documentation
Bill Erickson [Thu, 5 Jun 2014 13:47:36 +0000 (09:47 -0400)]
LP#1326806 Minor repairs to EDI admin documentation

Updates to EDI account Path/Incoming/Account docs.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1284832: Add missing seed data: enable combined search for only the subject class...
Jeff Davis [Tue, 25 Feb 2014 20:41:56 +0000 (12:41 -0800)]
LP#1284832: Add missing seed data: enable combined search for only the subject class by default

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1321363: Suppress Hold Transit use elicits client error
Dan Pearl [Tue, 20 May 2014 17:12:47 +0000 (13:12 -0400)]
LP#1321363: Suppress Hold Transit use elicits client error

This change restores the behavior as designed.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoForward port 2.5.4 upgrade script
Dan Wells [Thu, 29 May 2014 13:15:01 +0000 (09:15 -0400)]
Forward port 2.5.4 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1296937: move the $force_bc parameter of ->charged_items() to an implementation...
Galen Charlton [Tue, 20 May 2014 17:09:08 +0000 (10:09 -0700)]
LP#1296937: move the $force_bc parameter of ->charged_items() to an implementation method

Argubably, the $force_bc parameter of OpenILS::SIP::Patron->charged_items()
method exists solely as an implementation convenience for the renew-all
code.  Consequently, this patch removes the $force_bc parameter from the
public interface for charged_items() and spins it off into a new
implementation method.

This patch should be applied at the same time that a reversion of
SIPServer commit c97d64412bc is applied.  Note that a user who upgrades
SIPServer without upgrading Evergreen to a version that contains this
patch will end up in a situation where the code that counts active
loans for the patron information response will fetch the loans using
$force_bc set to true; this works only by coincidence.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jeff Godin <jgodin@tadl.org>
5 years agoLP#1321017: Order constituent records by quality
Mike Rylander [Tue, 20 May 2014 14:37:30 +0000 (10:37 -0400)]
LP#1321017: Order constituent records by quality

Previously, in some cases (often needlessly) we ordered constituent
records within a metarecord by a combination of type/form/blvl.  This
is not only of little use, but also expensive.  Instead, order them
by the bib's calculated quality, which takes type/form/blvl into account
already.

Also, use the new metabib.record_sorter to find the title tie-breaker
instead of using the view-of-a-view-of-a-view mrd compatability shim.

The net result is several orders of magnitude speed increase for
constituent record retrieval.  In particular, this resolves a problem
where doing a SIP2 patron information lookup and requesting a list
of holds could cause a timeout if the patron has one or more
metarecord holds.

This patch also causes the format filter parameter of the following
methods to be ignored:

open-ils.search.biblio.metarecord_to_records*
open-ils.search.biblio.metarecord.mods_slim.batch.retrieve*
open-ils.search.biblio.metarecord.mods_slim.retrieve*

Since the only use of the format filter was in JSPac code, and since
the record attributes mechanism has changed considerably, this removal
should be considered intentional.

Note that this patch includes a squash of a minor follow-up by Galen
Charlton to remove variables made unused by the original patch.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(for minor follow-up by Galen)
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1310751: Reorder query-building wrapper for QueryParser
Mike Rylander [Wed, 14 May 2014 15:54:47 +0000 (11:54 -0400)]
LP#1310751: Reorder query-building wrapper for QueryParser

In order to make sure that the transparent boolean pushdown does
not cause filters and modifiers to end up deeply embedded in the
query tree, we put them at the front.

This is a short-term fix.  Long-term, we need to make use of the
floating subquery syntax ( {{ ... }} ) available in QueryParser,
which is designed to address the semantic separation between what
the user types into the search box, and the various UI widgets that
can add query clauses.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1322303 cleanse backdate for checkin overdue voiding
Bill Erickson [Thu, 22 May 2014 18:41:17 +0000 (14:41 -0400)]
LP#1322303 cleanse backdate for checkin overdue voiding

Passing raw backdates, particularly from offline transactions, which
have a space between the date and time, to
DateTime::Format::ISO8601->parse_datetime results in "Invalid date
format:" errors.  Pass the date through the cleanse routine first.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoFix 2.6 Release Notes typos and formatting
Remington Steed [Thu, 24 Apr 2014 14:09:08 +0000 (10:09 -0400)]
Fix 2.6 Release Notes typos and formatting

This commit fixes an AsciiDoc URL processing bug by marking two fake URLs
as lines of code. It also fixes a few small typos and misspellings.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 years agoUpdate docs to point to 2.6 release notes
Remington Steed [Wed, 23 Apr 2014 13:52:25 +0000 (09:52 -0400)]
Update docs to point to 2.6 release notes

Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 years ago(documentation) fixed typo.
Erica Rohlfs [Fri, 23 May 2014 18:00:16 +0000 (14:00 -0400)]
(documentation) fixed typo.

Signed-off-by: Erica Rohlfs <erohlfs@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years ago(doc) 'debian-wheezy' was left out of the OS options
Josh Stompro [Wed, 21 May 2014 13:37:58 +0000 (08:37 -0500)]
(doc) 'debian-wheezy' was left out of the OS options

Just added 'debian-wheezy' to the OS options, it was left out by mistake.

Signed-off-by: Josh Stompro <Stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years ago(doc) add overdues to summary of the phone list feature
Josh Stompro [Mon, 19 May 2014 20:17:15 +0000 (15:17 -0500)]
(doc) add overdues to summary of the phone list feature

Added "or overdues" to the summary so it is clear that phonelist
handles both holds and overdues.

Signed-off-by: Josh Stompro <Stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1314920 Stamping upgrade script
Dan Wells [Thu, 22 May 2014 15:24:41 +0000 (11:24 -0400)]
LP#1314920 Stamping upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1314920 change the desc for the org hiding setting
Jason Etheridge [Thu, 1 May 2014 08:15:55 +0000 (04:15 -0400)]
LP#1314920 change the desc for the org hiding setting

so that it references physical_loc instead of ol

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoRemove buggy, unused function get_leaders_from_usergroup
Remington Steed [Fri, 7 Mar 2014 18:56:25 +0000 (13:56 -0500)]
Remove buggy, unused function get_leaders_from_usergroup

Recent editing and testing of get_leaders_from_usergroup() uncovered an
unrelated bug which renders the function useless (it returns all group
members, not just the leader). It wasn't previously caught because
Evergreen has no apparent references to this function. This commit
removes the unused function.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1321411: restore ability to handle credit payments using a processor other than...
Galen Charlton [Tue, 20 May 2014 18:42:32 +0000 (11:42 -0700)]
LP#1321411: restore ability to handle credit payments using a processor other than Stripe

This patch ensures that the processor name is passed
to OpenILS::Application::Circ::CreditCard::process_payment, avoiding
an exception thrown by Business::OnlinePayment.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1246843: Don't show contact invalidators for new users
Jeff Godin [Wed, 30 Oct 2013 18:37:10 +0000 (14:37 -0400)]
LP#1246843: Don't show contact invalidators for new users

Don't show contact invalidator buttons for new users. This affects
staged users and cloned users, where the contact fields have a value
when the editor initially loads.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1321429: Use server-local time as best-guess
Mike Rylander [Tue, 20 May 2014 18:30:20 +0000 (14:30 -0400)]
LP#1321429: Use server-local time as best-guess

When first calculating the shelf expire time, we assume "now" as
the starting point by calling DateTime->now().  However, that gives
us the time in UTC.  That's not good because closed dates are stored
timezone-aware.  Instead, ask for server-local time.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1314902: Restore header bar styles on results pages
Dan Wells [Thu, 1 May 2014 17:47:46 +0000 (13:47 -0400)]
LP#1314902: Restore header bar styles on results pages

Commit fc99f4f2 made an incomplete style change, changing
'results_header_bar' to be a class, but not changing the CSS.  The
simplest solution is to restore 'results_header_bar' to be an id, as
this fixes the main view, the responsive view, and also any custom CSS
which might affect this id.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1312945: pin schema update
Galen Charlton [Tue, 20 May 2014 23:48:57 +0000 (16:48 -0700)]
LP#1312945: pin schema update

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1312945: add regression test
Galen Charlton [Tue, 20 May 2014 23:46:02 +0000 (16:46 -0700)]
LP#1312945: add regression test

This adds a test for the change to the
authority.calculate_authority_linking stored function.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1312945: baseline schema update
Mike Rylander [Wed, 30 Apr 2014 22:38:29 +0000 (18:38 -0400)]
LP#1312945: baseline schema update

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Srey Seng <sreyseng@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1312945: authority.calculate_authority_linking and multiple linked tags
Srey Seng [Wed, 30 Apr 2014 22:20:17 +0000 (15:20 -0700)]
LP#1312945: authority.calculate_authority_linking and multiple linked tags

The function "authority.calculate_authority_linking" was not able to deal with
situations where there are multiple marc tags that are linkable. The function
only process the first tag that contains a linking_subfield and returns that
to be inserted into the authority_linking table, even when there are more than
one of the same tag with linking_subfield.

Added an additional loop to loop through each tag, for situations where there are
multiples of each tag.

Signed-off-by: Srey Seng <sreyseng@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1312945: auth-auth linking: cache less agressively and look for all links
Mike Rylander [Wed, 30 Apr 2014 16:58:11 +0000 (12:58 -0400)]
LP#1312945: auth-auth linking: cache less agressively and look for all links

There was a logic inversion that was causing miss-use of a per-
record cache mechanism.  I remove that entirely, as it's not helpful
in practice.

Also, after finding one use of a linked field we moved on to the
next, though it is possible for more than one link to exist for
different uses of a name, say.  Now we'll loop through all fields
to find all possible linkages.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Srey Seng <sreyseng@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1296937: (follow-up) make $ids_only be the last parameter for ->charged_items()
Galen Charlton [Tue, 20 May 2014 15:46:47 +0000 (08:46 -0700)]
LP#1296937: (follow-up) make $ids_only be the last parameter for ->charged_items()

This change ensures that if a site fails to upgrade SIPServer at the
same time that they upgrade Evergreen, the renew all message won't
break on them.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1296937: (SIP2) Add ids_only parameter to _items functions
Thomas Berezansky [Thu, 23 Jan 2014 17:07:06 +0000 (12:07 -0500)]
LP#1296937: (SIP2) Add ids_only parameter to _items functions

This allows the caller to skip loading of barcodes and/or titles when
they are not needed, such as when the plan is to return counts, not
details.  Per bug 1321017, this is particular useful for patrons
that have metarecord holds.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1320048: remove the Date.W3CDTF() JavaScript module
Galen Charlton [Fri, 16 May 2014 17:40:49 +0000 (10:40 -0700)]
LP#1320048: remove the Date.W3CDTF() JavaScript module

With the closed dates editor now using util.date, and
no other active use of Date.W3CDTF() going on, it can go.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agoLP#1320048: remove last use of Date.W3CDTF() from closed dates editor
Galen Charlton [Fri, 16 May 2014 17:35:01 +0000 (10:35 -0700)]
LP#1320048: remove last use of Date.W3CDTF() from closed dates editor

To test, verify that the closed dates editor continues to
function normally, i.e.,

* single all-day closures can be added
* a multi-day closing can be added
* one can set a "detailed closing" with a custom start
  time and end time
* existing closures are display properly

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agoLP#1320048: correctly display closures in the closed dates editor
Galen Charlton [Fri, 16 May 2014 17:03:45 +0000 (10:03 -0700)]
LP#1320048: correctly display closures in the closed dates editor

This patch fixes a problem introduced by the patch for bug 1187035
that caused the closed dates editor to display all closures as if
they started and ended at the current time.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agoDocumentation for adding OpenSearch to Firefox
Ben Shum [Fri, 11 Apr 2014 03:16:41 +0000 (23:16 -0400)]
Documentation for adding OpenSearch to Firefox

With some sample screenshots!

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 years agoMove authority.record_entry trigger changes out of transaction
Dan Wells [Wed, 14 May 2014 21:03:38 +0000 (17:03 -0400)]
Move authority.record_entry trigger changes out of transaction

This should prevent 'cannot ALTER TABLE "record_entry" because it has
pending trigger events' errors.

This is the same approach used in the original 0875 script, but we
might also work around the problem with a well-placed
SET CONSTRAINTS ALL IMMEDIATE;

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoPreserve script version from 2.6.0
Dan Wells [Wed, 14 May 2014 21:49:51 +0000 (17:49 -0400)]
Preserve script version from 2.6.0

The forward-port had some fixes, so revert those (to be reapplied
in the next commit) to better show fix history for 2.6.1.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoForward-port 2.6.0 version upgrade script
Dan Wells [Wed, 14 May 2014 21:44:03 +0000 (17:44 -0400)]
Forward-port 2.6.0 version upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoDocumentation: add a 'where' clause to bib record import stored procedure
Yamil Suarez [Thu, 8 May 2014 21:37:07 +0000 (17:37 -0400)]
Documentation: add a 'where' clause to bib record import stored procedure

The stored procedure for doing bib record import was lacking a 'where'
clause in one of the update statements.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
5 years agoFix for docs on library information pages
Kathy Lussier [Thu, 1 May 2014 21:32:36 +0000 (17:32 -0400)]
Fix for docs on library information pages

Fixes an AsciiDoc URL processing error.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoDocs 2.6: Lost Item Billing Min/Max Price Settings
Hekman Library Technology Team [Tue, 22 Apr 2014 19:37:17 +0000 (15:37 -0400)]
Docs 2.6: Lost Item Billing Min/Max Price Settings

Add a short description for the new 2.6 feature "Lost Item Billing: New
Min/Max Price Settings" to the only section where it seems to fit, and it
seems obscure and hard to find. It could be useful to create a new, more
prominent section for common Org Unit Settings, possibly organized by
category. Sending this via GitHub to test the new Docs workflow.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 years agoDocumentation: added missing word to 'library settings editor' docs
Yamil Suarez [Wed, 30 Apr 2014 15:57:16 +0000 (11:57 -0400)]
Documentation: added missing word to 'library settings editor' docs

Added "editor" to label of what menu should be used.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
5 years agoDocumentation: Removed bare setting names from Stripe payment doc
Yamil Suarez [Wed, 30 Apr 2014 14:53:27 +0000 (10:53 -0400)]
Documentation: Removed bare setting names from Stripe payment doc

Per jboyer-isl's suggestions

Signed-off-by: Yamil Suarez <yamil@yamil.com>
5 years agoDocumentation: Copied Stripe payment info into 'Library Settings Editor'
Yamil Suarez [Wed, 30 Apr 2014 14:22:42 +0000 (10:22 -0400)]
Documentation: Copied Stripe payment info into 'Library Settings Editor'

Only modified slightly from the documentation provided in the EG 2.6
release notes.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
5 years agoLibrary information pages
Kathy Lussier [Sun, 27 Apr 2014 06:43:16 +0000 (02:43 -0400)]
Library information pages

Updating the linked libraries documentation to include details on the new
library information pages introduced in 2.6.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLinked libraries docs
Kathy Lussier [Sun, 27 Apr 2014 04:48:36 +0000 (00:48 -0400)]
Linked libraries docs

Documentation to the 2.5 feature that allows sites to add links in the
catalog from copy details area of the catalog.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoOnly create extension intarray if it does not already exist
Ben Shum [Fri, 25 Apr 2014 00:58:17 +0000 (20:58 -0400)]
Only create extension intarray if it does not already exist

Simple change to skip over adding intarray if it already exists in a database
for some reason.

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1310283: Propogate .staff through Z3950 searches
Thomas Berezansky [Tue, 22 Apr 2014 13:20:20 +0000 (09:20 -0400)]
LP#1310283: Propogate .staff through Z3950 searches

So that local catalog Z3950 searches don't only show opac visible bibs.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1311467: fix heading validation in bib editor
Galen Charlton [Wed, 23 Apr 2014 05:45:43 +0000 (01:45 -0400)]
LP#1311467: fix heading validation in bib editor

This patch fixes a regression whereby clicking the validate button
in the bib editor would result in no headings getting checked.

In the process, it enables 'startwith' to be used as a JSON query
operator for all types of predicates, not just the results of
transformed values.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoCompile and Tweak Release Notes for 2.6.0
Dan Wells [Wed, 16 Apr 2014 13:56:53 +0000 (09:56 -0400)]
Compile and Tweak Release Notes for 2.6.0

Also, add '.txt' to template name, since our build process expects
and uses that extension.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoGrab an up-to-date relator code list. Thanks, LoC!
Mike Rylander [Tue, 22 Apr 2014 15:34:07 +0000 (11:34 -0400)]
Grab an up-to-date relator code list. Thanks, LoC!

Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoRejigger 2.4.3-2.5.0 upgrade bits
Dan Wells [Thu, 16 Jan 2014 21:01:09 +0000 (16:01 -0500)]
Rejigger 2.4.3-2.5.0 upgrade bits

As reported in LP#1261355, Postgres fails in some cases when changing
constraints on existing data inside a transaction.  This may or may not
fix the actual problem, but it at least tidies up these changes, and
will make it much cleaner to move outside the transaction if needed.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 years agoLP#1308590: Fix schema.org type mapping
Dan Scott [Wed, 16 Apr 2014 14:42:49 +0000 (10:42 -0400)]
LP#1308590: Fix schema.org type mapping

The switch to config.coded_value_map for format icon types and labels
inadvertently broke schema.org type mapping. Restore it and attempt
to take advantage of the finer-grained types that are now available
to us.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoTranslation updates - po files
Dan Wells [Wed, 16 Apr 2014 02:37:26 +0000 (22:37 -0400)]
Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1306176: force installation of Business::Stripe from CPAN
Galen Charlton [Thu, 10 Apr 2014 17:40:01 +0000 (10:40 -0700)]
LP#1306176: force installation of Business::Stripe from CPAN

Business::Stripe can fail to pass its tests on platforms that
happen to have Pod::Simple 3.24 or later and Test::Pod.  In
particular, Debian Jessie and Ubuntu Trusty meet those conditions
(since the OpenSRF installation process installs libtest-pod-perl)
and Debian Wheezy with backports enabled does as well.

Since the failing test cases are only for POD, this patches moves
Business::Stripe to the CPAN_MODULES_FORCE list across the board.

This can be undone if/when Business::Stripe releases a fix for
the POD validation warnings.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
5 years agoLP#1304559 - stamping upgrade script for vandelay_record_attr_to_flat
Ben Shum [Thu, 10 Apr 2014 21:47:26 +0000 (17:47 -0400)]
LP#1304559 - stamping upgrade script for vandelay_record_attr_to_flat

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1304559 Fix slow Vandelay-based imports
Dan Wells [Thu, 10 Apr 2014 13:15:07 +0000 (09:15 -0400)]
LP#1304559 Fix slow Vandelay-based imports

Whether a planning limitation or otherwise, we have seen a few cases
where queries run very, very slowly (appear to hang) when using the
updated metabib.record_attr view in a WHERE clause.

The simplest code change is to switch Vandelay to use the intermediate
'_flat' view instead, and early reports indicate that this at least
gets us back to a functional state.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1305958 Fix copy table header ID error
Dan Scott [Thu, 10 Apr 2014 14:54:19 +0000 (10:54 -0400)]
LP#1305958 Fix copy table header ID error

Currently there is a <td headers='copy_header_date_format'> entry in
copy_table.tt2 that does not link to an associated table header with an
ID of that value. The desired target ID is "copy_header_create_date".

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1306133: Avoid metabib.rec_descriptor where possible
Mike Rylander [Thu, 10 Apr 2014 17:03:30 +0000 (13:03 -0400)]
LP#1306133: Avoid metabib.rec_descriptor where possible

metabib.rec_descriptor has been a view over other data structures
for some time now, but with the advent of the new attribute infrastructure
it is a view over a view over a view, variously transforming IDs to
a slim table to an HSTORE structure and finally to a wide table. Thus,
it is extremely expensive to query. So we won't unless we're asked to.
Which, in the TPAC world, is never.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Doug Kyle <dkyle@grpl.org>
5 years agoLP#1302113: acknowledgments for 2.6.0
Galen Charlton [Thu, 3 Apr 2014 18:54:11 +0000 (14:54 -0400)]
LP#1302113: acknowledgments for 2.6.0

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1302113: define a file for storing lists of folks to acknowledge in the release...
Galen Charlton [Thu, 3 Apr 2014 18:52:08 +0000 (14:52 -0400)]
LP#1302113: define a file for storing lists of folks to acknowledge in the release notes

If a file called _acknowlegments is present in the docs/RELEASE_NOTES_NEXT
directory, its contents will be appended to the end of the release
notes under an "Acknowledgments" heading when
create_release_notes.sh is run.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1301510 Align element name with Fixed Field type
Mike Rylander [Wed, 2 Apr 2014 17:11:25 +0000 (13:11 -0400)]
LP#1301510 Align element name with Fixed Field type

We depend on the field name in the XUL to line up the fixed field
value maps in the database with the appropriate context menus. ELvl
was not capitalized the same in all required spots, causing the
context menu to render but be ineffective.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1303987: Fully populate Ills from context menu
Mike Rylander [Mon, 7 Apr 2014 19:42:45 +0000 (15:42 -0400)]
LP#1303987: Fully populate Ills from context menu

The Ills fixed field is 4 characters long (allowing for up to four
types of illustrations to be noted, per 008/006), but the fixed field
editor dropdown menus are not (a) multi-select capable nor (b) ready
to support multi-value-per-field, because, well Ills is the only one
like this, and that would be a pretty big complication to the code.
However, even though multi-select is not supported, we should still
apply the value selected and update the fixed field, otherwise the
value is not updated in the record itself.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1281678 Fixed field context menus should trigger close confirmation dialog
Lebbeous Fogle-Weekley [Tue, 18 Feb 2014 17:55:15 +0000 (12:55 -0500)]
LP#1281678 Fixed field context menus should trigger close confirmation dialog

Same for using the Physical Characteristics Wizard.

Thanks Dan Wells for the spot.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoReset the displayed mouse cursor
Mike Rylander [Wed, 2 Apr 2014 20:03:39 +0000 (16:03 -0400)]
Reset the displayed mouse cursor

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoAdd alert in user editor for method errors
Jeff Godin [Wed, 30 Oct 2013 17:17:25 +0000 (13:17 -0400)]
Add alert in user editor for method errors

Add an alert() in the user editor so that method errors are not
silent.

Without this, a method error (such as when saving a patron fails at
the db level) is silent. Better to at least inform the user that
something is amiss.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1301955: disable autosuggest by default
Ben Shum [Mon, 7 Apr 2014 19:59:17 +0000 (15:59 -0400)]
LP#1301955: disable autosuggest by default

Until we solve the accessibility issues caused by autosuggest as noted in
https://bugs.launchpad.net/evergreen/+bug/1187993, we shall disable the
feature by default for new installations.

An entry for the release notes is included.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP1301567: New format icons
Kathy Lussier [Wed, 2 Apr 2014 19:18:24 +0000 (15:18 -0400)]
LP1301567: New format icons

This set adds icons for the new formats that can now be represented due to
the recent MVF work. Many thanks to Jim Keenan at C/W MARS for creating
many of these icons.

The serial.png icon was borrowed from the Koha project and was originally
contributed by VOKAL (Vermont Organization of Koha Automated Libraries).

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1115599: Ignore canceled lineitems during batch cancel
Bill Erickson [Sat, 22 Mar 2014 01:05:14 +0000 (21:05 -0400)]
LP#1115599: Ignore canceled lineitems during batch cancel

Continue ignoring already-canceled lineitems during batch cancel so that
a) no unnecessary calls are made and b) staff can be alerted when no
viable lineitems were selected for the requested action.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1115599: Allow cancelled lineitems to be received and invoiced
Kathy Lussier [Wed, 29 Jan 2014 22:07:29 +0000 (17:07 -0500)]
LP#1115599: Allow cancelled lineitems to be received and invoiced

Acquisitions staff need to be able to receive and invoice cancelled items,
particularly when those items are backordered. This branch restores the
ability to perform these actions on cancelled lineitems from the PO
screen.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1282704: Serials: in routing lists, avoid extra page breaks wasting paper at print...
Lebbeous Fogle-Weekley [Thu, 20 Feb 2014 17:21:57 +0000 (12:21 -0500)]
LP#1282704: Serials: in routing lists, avoid extra page breaks wasting paper at print time

If you're using batch receive, and you have two copies (and therefore
two streams) that you're receiving with the Routing List? checkbox
checked, but only one of those streams actually has a routing list,
you'll note before this patch is applied that you get an extra page of
blank paper if you print the routing list that pops up.

This fixes that.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1303940: pin schema upgrade to 0878
Galen Charlton [Tue, 8 Apr 2014 21:15:11 +0000 (14:15 -0700)]
LP#1303940: pin schema upgrade to 0878

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1303940: don't attempt to store NULL values in keyword, browse, or facet indexes
Galen Charlton [Tue, 8 Apr 2014 21:09:46 +0000 (14:09 -0700)]
LP#1303940: don't attempt to store NULL values in keyword, browse, or facet indexes

This patch implements a suggestion by Dan Wells and builds on Mike
Rylander's patch to skip inserting into field_entry and facet
indexes values that have been normalized to NULL.  As a side effect,
the following warning will no longer be logged when attempting
to store such values in the facet index:

WARNING:  Use of uninitialized value in subroutine entry at /usr/lib/perl/5.18/Unicode/Normalize.pm line 80.
CONTEXT:  PL/Perl function "force_unicode_normal_form"

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1303940: Protect against bogus data that can breaking indexing
Mike Rylander [Mon, 7 Apr 2014 18:03:51 +0000 (14:03 -0400)]
LP#1303940: Protect against bogus data that can breaking indexing

In at least the case of browse indexing, some MARC contents can
cause us problems when normalization (such as stripping all
punctuation) can leave us with a NULL value for index-intended
data. The patch avoids the specific case of browse data being null
and causing an ingest failure.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1303940: improve readability of test case
Galen Charlton [Tue, 8 Apr 2014 20:38:50 +0000 (13:38 -0700)]
LP#1303940: improve readability of test case

This patch adds some whitespace and a comment in the MARCXML
to clarify the sort of data that triggers the bug.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP 1303940: pg_tap regression test.
Jason Stephenson [Mon, 7 Apr 2014 19:41:02 +0000 (15:41 -0400)]
LP 1303940: pg_tap regression test.

Add a pg_tap test to insert a record that should trigger the problem
fixed by LP 1303940. If the test fails, we have a regression.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoSimple typo fix in docs
Dan Wells [Wed, 2 Apr 2014 18:31:24 +0000 (14:31 -0400)]
Simple typo fix in docs

Credit for spotting this to Erica Rohlfs.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1300267 Documentation: Reset Staff Client Password (e.g. Admin)
Benjamin [Mon, 31 Mar 2014 20:37:06 +0000 (16:37 -0400)]
LP#1300267 Documentation: Reset Staff Client Password (e.g. Admin)

Signed-off-by: Benjamin <benjamin.wiens@gmail.com>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
5 years agoLP#1300267 Documentation: Reset Staff Client Password (e.g. Admin)
Benjamin [Mon, 31 Mar 2014 20:29:11 +0000 (16:29 -0400)]
LP#1300267 Documentation: Reset Staff Client Password (e.g. Admin)

Signed-off-by: Benjamin <benjamin.wiens@gmail.com>
Signed-off-by: Yamil Suarez <yamil@yamil.com>