9 years agoMerge branch 'master' of ssh://
senator [Wed, 23 Mar 2011 14:32:49 +0000 (10:32 -0400)]
Merge branch 'master' of ssh:// into opac-tt-poc

9 years agoShow format icons in results and record detail pages
senator [Tue, 22 Mar 2011 22:00:11 +0000 (18:00 -0400)]
Show format icons in results and record detail pages

9 years agohave checkILSEvent handle events that aren't in ils_events.xml
phasefx [Tue, 22 Mar 2011 15:59:44 +0000 (15:59 +0000)]
have checkILSEvent handle events that aren't in ils_events.xml

Signed-off-by: Jason Etheridge <>
git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoHonor the 'active' flag in for search.relevance_adjustment entries.
dbwells [Tue, 22 Mar 2011 14:39:56 +0000 (14:39 +0000)]
Honor the 'active' flag in for search.relevance_adjustment entries.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoBuild libjs from source for now until the Perl threading problem can be reliably...
dbs [Tue, 22 Mar 2011 01:24:43 +0000 (01:24 +0000)]
Build libjs from source for now until the Perl threading problem can be reliably tested

The previous commit changed JavaScript::SpiderMonkey to be built without
thread safety, but on Fedora we had been installing the js-devel package
(which was threaded). As you can't build a non-threaded
JavaScript::SpiderMonkey on top of a threaded libjs, for now we'll make
Fedora build a non-threaded libjs from source just like the other distros.

Note that the problem with threaded JavaScript::SpiderMonkey surfaced
on Debian Lenny when targeting holds. Lenny has libthreads-perl 1.71, but
a number of fixes have been committed to subsequent versions
( - so
threading support might be reliable on more current distros. Once we
have a reliable test, we might be able to go back to the packaged
version of libjs.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoAnother layer of escaping for the escapes in the DB update script
dbs [Tue, 22 Mar 2011 00:40:44 +0000 (00:40 +0000)]
Another layer of escaping for the escapes in the DB update script

Apologies for the previous patch that led to breakage; I "tested" in a
script in which I had already hardcoded the answer I wanted after
running into problems with the previous version of the script. Not
good testing practice.

Thanks to Bill Erickson for suggesting the extra escapes. Tested in
a clean environment this time, and it works.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoRemove thready building -- we do not use threads anyway, and it breaks JS::SM
miker [Mon, 21 Mar 2011 22:34:05 +0000 (22:34 +0000)]
Remove thready building -- we do not use threads anyway, and it breaks JS::SM

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoEnable to handle upgrading databases with release version
dbs [Mon, 21 Mar 2011 20:12:17 +0000 (20:12 +0000)]
Enable to handle upgrading databases with release version

When '0475' is mixed with '', the latter wins as far as a plain MAX()
operator goes. Ensuring that the version is all digits should help avoid the
release version numbers in the config.upgrade_log table.

Thanks to Thomas Berezansky for suggesting a SIMILAR TO operator variation
that led to this approach.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agocorrecting bad timespecs in the example crontab
miker [Mon, 21 Mar 2011 18:08:30 +0000 (18:08 +0000)]
correcting bad timespecs in the example crontab

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agono, this was correct. doh :) the list version uses paging, but we're counting the...
phasefx [Mon, 21 Mar 2011 16:47:26 +0000 (16:47 +0000)]
no, this was correct.  doh :)  the list version uses paging, but we're counting the entire set

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agothis "count" method gets the same parameters as the list version
phasefx [Mon, 21 Mar 2011 16:42:01 +0000 (16:42 +0000)]
this "count" method gets the same parameters as the list version

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoUse the human-friendly interval syntax for Apache caching
dbs [Mon, 21 Mar 2011 14:11:21 +0000 (14:11 +0000)]
Use the human-friendly interval syntax for Apache caching

Apache mod_expires has supported a human-readable syntax for defining cache
expiry directives for a long time. In this commit we simply convert the
existing defaults from the "Anumber_of_seconds" syntax to the equivalent
English syntax documented at

Whether CSS _should_ have a cache lifetime of 50 minutes by
default is left to the subject of future commits :)

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoIn-database Grace intervals
miker [Sat, 19 Mar 2011 14:33:18 +0000 (14:33 +0000)]
In-database Grace intervals

s it stands the grace period for a transaction is only specified on the fine generator script, but fines can be generated on checkin as well without one. As a result any checkin results in grace periods being negated.

The attached patch adds in-db grace periods for all non-booking transactions, removing the grace period from the fine generator cron job script and placing it on the circulation. Grace periods are set on the recurring fine rule with an override available on the circ matchpoint, identical to how renewal count can be overridden from the duration rule already. These grace periods are respected on checkin fine generation as well as on the fine generator cron job script.

The upgrade script will assume, by default, a grace period of 1, but has a \set line to change this. It will also update all circulations without a checkin by default, but another \set will allow disabling of that.

[ NOTE: for the history of the patch, see: ]

Signed-off-by: Thomas Berezansky <>
Signed-off-by: Mike Rylander <>
git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoA docstring and spaces for Evergreen constants in
dbs [Sat, 19 Mar 2011 05:48:01 +0000 (05:48 +0000)]
A docstring and spaces for Evergreen constants in

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoSort out a mix of tabs and spaces in
dbs [Sat, 19 Mar 2011 05:34:22 +0000 (05:34 +0000)]
Sort out a mix of tabs and spaces in

Also restructure the docstrings slightly while we're there.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoImport osrf.log and reference it when we attempt to log
dbs [Sat, 19 Mar 2011 05:33:34 +0000 (05:33 +0000)]
Import osrf.log and reference it when we attempt to log

This bare call to log_info was just hanging out, waiting for
someone to stumble across it.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoProvide a top-level docstring for oils/utils/
dbs [Sat, 19 Mar 2011 05:00:42 +0000 (05:00 +0000)]
Provide a top-level docstring for oils/utils/

Also, standardize on triple-double-quoted docstrings, per PEP257.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoRemove unused imports, correct some references, and clean up
dbs [Sat, 19 Mar 2011 04:56:06 +0000 (04:56 +0000)]
Remove unused imports, correct some references, and clean up

Mostly minor cleanups, some additional docstrings, but a few changes
of concern here (OSRF_APP_CONNECTED_STATUS didn't have the appropriate
osrf.const import, for example).

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoDon't stomp "type" built-in and don't import that which is not used
dbs [Sat, 19 Mar 2011 03:59:00 +0000 (03:59 +0000)]
Don't stomp "type" built-in and don't import that which is not used

Also provide a little more docstring action.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoParse the field_safe parameter in Python's IDL parser
dbs [Sat, 19 Mar 2011 03:06:58 +0000 (03:06 +0000)]
Parse the field_safe parameter in Python's IDL parser

Also set the correct namespace for the tablename attribute.

The rest of the changes are for PEP8 compliance. We retain the
IDLParser set_IDL() and parse_IDL() methods because things like
constrictor call them directly, but note in the docstrings that
they are deprecated names.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoMake sure "ol" propagates through BibTemplate subject search links for OPAC range...
miker [Fri, 18 Mar 2011 19:49:58 +0000 (19:49 +0000)]
Make sure "ol" propagates through BibTemplate subject search links for OPAC range hiding

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoupdated code comments
berick [Fri, 18 Mar 2011 18:38:59 +0000 (14:38 -0400)]
updated code comments

9 years agoin bib attr (mra) fetcher, get the display label from the ccvm where appropriate...
berick [Fri, 18 Mar 2011 18:31:07 +0000 (14:31 -0400)]
in bib attr (mra) fetcher, get the display label from the ccvm where appropriate and add to response object

9 years agoSwitch to AccessControl plugin, more reliable.
phasefx [Fri, 18 Mar 2011 18:08:51 +0000 (18:08 +0000)]
Switch to AccessControl plugin, more reliable.

Only fetches it when needed.

Also make NSIS Less...verbose. Warnings/errors only.

Author: Thomas Berezansky <>
Signed-off-by: Thomas Berezansky <>
Signed-off-by: Jason Etheridge <>
git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoTest for an installed libdbi0 package and bail on Ubuntu and Debian
dbs [Fri, 18 Mar 2011 17:50:19 +0000 (17:50 +0000)]
Test for an installed libdbi0 package and bail on Ubuntu and Debian

This isn't a problem on Fedora, where we use the packaged version of libdbi,
but the older version of libdbi0 and possibly the compile options on Ubuntu
Lucid has been demonstrated to be a barrier to successfully installing

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoadded field_safe attr to ccs, aout, and crahp classes; capture field_safe attr durin...
erickson [Fri, 18 Mar 2011 16:51:20 +0000 (16:51 +0000)]
added field_safe attr to ccs, aout, and crahp classes;  capture field_safe attr during IDL parsing

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoMerge branch 'opac-tt-poc' of git+ssh://
berick [Fri, 18 Mar 2011 16:08:26 +0000 (12:08 -0400)]
Merge branch 'opac-tt-poc' of git+ssh:// into opac-tt-poc

9 years agoremoved debug log message
berick [Fri, 18 Mar 2011 16:08:20 +0000 (12:08 -0400)]
removed debug log message

9 years agomake all field_safe classes accessible via fetch/cache by default. reduce page churn...
berick [Fri, 18 Mar 2011 16:08:06 +0000 (12:08 -0400)]
make all field_safe classes accessible via fetch/cache by default.  reduce page churn by creating then caching the fetch/cache and org-tree generator funcs and simply inserting them into the page context on each page load.  IOW, no need to redefine the funcs on each page load

9 years agoadded field_safe attr to ccs, aout, and crahp classes; capture field_safe attr durin...
berick [Fri, 18 Mar 2011 16:05:34 +0000 (12:05 -0400)]
added field_safe attr to ccs, aout, and crahp classes;  capture field_safe attr during IDL parsing

9 years agoMerge branch 'master' of git+ssh://
Mike Rylander [Fri, 18 Mar 2011 15:55:17 +0000 (11:55 -0400)]
Merge branch 'master' of git+ssh:// into opac-tt-poc

9 years agoIntelligent Metarecord Format Selection for Holds
miker [Fri, 18 Mar 2011 15:53:04 +0000 (15:53 +0000)]
Intelligent Metarecord Format Selection for Holds

Previous to this commit, Evergreen would show all possible record formats
when promoting a T-type hold to an M-type.  This change causes the middle
layer method to respect the Hard Boundary of the pickup library when
considering what constituent records within a metarecord will contribute

Signed-off-by: Mike Rylander <>
git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoMerge branch 'opac-tt-poc' of git+ssh://
Mike Rylander [Fri, 18 Mar 2011 15:20:39 +0000 (11:20 -0400)]
Merge branch 'opac-tt-poc' of git+ssh:// into opac-tt-poc

9 years agoMerge branch 'master' of git+ssh://
Mike Rylander [Fri, 18 Mar 2011 15:20:38 +0000 (11:20 -0400)]
Merge branch 'master' of git+ssh:// into opac-tt-poc

9 years agoadded utility func for fetching extracted bre svf attributes (mra's)
berick [Fri, 18 Mar 2011 15:05:48 +0000 (11:05 -0400)]
added utility func for fetching extracted bre svf attributes (mra's)

9 years agoAllow the "result_field" to be used as the default alias in the output column of...
miker [Fri, 18 Mar 2011 14:40:40 +0000 (14:40 +0000)]
Allow the "result_field" to be used as the default alias in the output column of a row or set returning transform

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoas was recently done w/ existing kcls skin; hide the open transaction summary info...
berick [Thu, 17 Mar 2011 20:32:06 +0000 (16:32 -0400)]
as was recently done w/ existing kcls skin; hide the open transaction summary info in my-account, citing confusion and unnecessary additional information.  note, you can still see total balance owed

9 years agoavoid adding site() to query if loc param is empty string
berick [Thu, 17 Mar 2011 20:22:31 +0000 (16:22 -0400)]
avoid adding site() to query if loc param is empty string

9 years agoPre-modified xulrunner-stub files + icons
phasefx [Thu, 17 Mar 2011 20:16:56 +0000 (20:16 +0000)]
Pre-modified xulrunner-stub files + icons

Icons courtesy of Mike Peters, or so my note alongside them says.

The pre-modified stubs are built on the build of xulrunner. They should continue to work on future 1.9.2 builds.

Author: Thomas Berezansky <>
Signed-off-by: Thomas Berezansky <>
Signed-off-by: Jason Etheridge <>
git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoCopy is not valid. How I missed that before I don't know.
phasefx [Thu, 17 Mar 2011 20:14:41 +0000 (20:14 +0000)]
Copy is not valid. How I missed that before I don't know.

Author: Thomas Berezansky <>
Signed-off-by: Thomas Berezansky <>
Signed-off-by: Jason Etheridge <>
git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoDefault to no license page (for the staff client installer)
phasefx [Thu, 17 Mar 2011 20:14:04 +0000 (20:14 +0000)]
Default to no license page (for the staff client installer)

Author: Thomas Berezansky <>
Signed-off-by: Thomas Berezansky <>
Signed-off-by: Jason Etheridge <>
git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoif there, show shelf expire date for available holds; minor var cleanup
berick [Thu, 17 Mar 2011 20:03:48 +0000 (16:03 -0400)]
if there, show shelf expire date for available holds; minor var cleanup

9 years agopile of updated icons
berick [Thu, 17 Mar 2011 19:55:39 +0000 (15:55 -0400)]
pile of updated icons

9 years agoimplemented bookbag rss link
berick [Thu, 17 Mar 2011 19:53:28 +0000 (15:53 -0400)]
implemented bookbag rss link

9 years agomake presentation better by hiding as-yet-unready features, etc
senator [Thu, 17 Mar 2011 16:23:13 +0000 (12:23 -0400)]
make presentation better by hiding as-yet-unready features, etc

also, made links out of the dashboard counts, but oddly the first one
("checked out") only works in IE, not Chrome or Firefox.  I suspect that
the complications of all the "position: absolute"-this and "position:
relative"-that make for fluky layout.

9 years agoTreat call number fields 090 and 092 as local LC and Dewey (respectively) based on...
dbwells [Thu, 17 Mar 2011 13:22:31 +0000 (13:22 +0000)]
Treat call number fields 090 and 092 as local LC and Dewey (respectively) based on de facto standards.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoMerge branch 'master' of ssh://
senator [Wed, 16 Mar 2011 19:20:19 +0000 (15:20 -0400)]
Merge branch 'master' of ssh:// into opac-tt-poc

9 years agoMake a back-compat version of item_lang for QP
miker [Wed, 16 Mar 2011 19:16:43 +0000 (19:16 +0000)]
Make a back-compat version of item_lang for QP

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoMerge branch 'master' of ssh://
senator [Wed, 16 Mar 2011 18:50:14 +0000 (14:50 -0400)]
Merge branch 'master' of ssh:// into opac-tt-poc

9 years ago"Add to my list" becomes "remove from my list", and
senator [Wed, 16 Mar 2011 18:48:52 +0000 (14:48 -0400)]
"Add to my list" becomes "remove from my list", and

it now works on the record detail page as well as the results page.
Also, I fixed a bug by which an HTML form was rendered wrongly, totally
breaking the display of the results page in IE and preventing the first
result on any page of search results from adding to the anonymous list.

9 years agomake payment receipt print/email run inside a transaction. instead of using authorit...
erickson [Wed, 16 Mar 2011 18:19:20 +0000 (18:19 +0000)]
make payment receipt print/email run inside a transaction.  instead of using authoritative, force the xact for reasons mentioned in the comments

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoAddresses LP bug #736167, correctly populate hold format list for Advanced Options
miker [Wed, 16 Mar 2011 17:45:04 +0000 (17:45 +0000)]
Addresses LP bug #736167, correctly populate hold format list for Advanced Options

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoupgrade script matching r19759-r19761
miker [Wed, 16 Mar 2011 16:06:10 +0000 (16:06 +0000)]
upgrade script matching r19759-r19761

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agodedicated renewal interface should use receipt printer
phasefx [Wed, 16 Mar 2011 14:29:24 +0000 (14:29 +0000)]
dedicated renewal interface should use receipt printer

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoPatch from Steve Callendar addressing CN sort order on page 0 (and before) of CN...
miker [Wed, 16 Mar 2011 14:19:54 +0000 (14:19 +0000)]
Patch from Steve Callendar addressing CN sort order on page 0 (and before) of CN browse

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoPatch from Steve Callendar addressing holdability tests for copies
miker [Wed, 16 Mar 2011 13:37:49 +0000 (13:37 +0000)]
Patch from Steve Callendar addressing holdability tests for copies

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoSet default db schema search path to public,pg_catalog
dbs [Wed, 16 Mar 2011 03:46:43 +0000 (03:46 +0000)]
Set default db schema search path to public,pg_catalog

With the addition of the 'evergreen' schema, we discovered that
all of the unqualified database objects were being created in
the 'evergreen' schema if the database user name was 'evergreen'
(as the default search path is "$user",public we started matching

Thomas Berezansky proposed a variation of the function provided
here for changing database settings. By creating the function in
the first schema file, the subsequent connections pick up the
new default search path and all works blissfully as it once did.

Long term, we should probably move towards explicitly qualified
database objects.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoMake DROP statement match new basetype for agg_tsvector
dbs [Wed, 16 Mar 2011 03:38:26 +0000 (03:38 +0000)]
Make DROP statement match new basetype for agg_tsvector

When the CREATE AGGREGATE function was changed to have a basetype
of pg_catalog.agg_tsvector, the corresponding DROP statement was
not changed in a similar fashion; ergo, on creating the schema
a subsequent time, the CREATE statement would fail because the
aggregate function already existed and the transaction would be
rolled back.

Also - do we need to differentiate between PostgreSQL 8.4 and 9.0

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agosmarter search term propagation, should avoid ARRAY(0xdeadbeef) type ...
senator [Tue, 15 Mar 2011 21:53:58 +0000 (17:53 -0400)]
smarter search term propagation, should avoid ARRAY(0xdeadbeef) type ...

... stuff in search boxes

9 years agoWith some hints from eeevil, tweaked 002.functions.aggregate.sql to work after some...
phasefx [Tue, 15 Mar 2011 21:05:49 +0000 (21:05 +0000)]
With some hints from eeevil, tweaked 002.functions.aggregate.sql to work after some search_path mangling.  Haven't smoketested yet, just got past the eg_db_config --create-schema bit with this.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agobib record subject search terms: painstaking translation of BibTemplate to TT
senator [Tue, 15 Mar 2011 19:16:23 +0000 (15:16 -0400)]
bib record subject search terms: painstaking translation of BibTemplate to TT

the reference implementation I used is in
Open-ILS/web/opac/skin/default/xml/rdetail/rdetail_summary.xml starting
at line 93 as of this commit.

Only now that I've imitated the default skin's behavior exactly, I note
that the subject search links produced don't actually work on my test server.
Seems to be a local configuration issue though; will investigate.

9 years agoImprove search term propagation from page to page
senator [Tue, 15 Mar 2011 17:47:10 +0000 (13:47 -0400)]
Improve search term propagation from page to page

Also, for things like the author link on the record detail page, build a
link with 'qtype=author&query=JK Rowling' instead of 'query=au:JK Rowling'

The latter works, but causes the search form to look stupid.
Query type dropdown will be set to keyword by default, and the term will
be "au:JK Rowling", which will be a head scratcher for 99% of real

9 years agorevert accidental commit of dojo-to-for(;;;) test
miker [Tue, 15 Mar 2011 17:18:43 +0000 (17:18 +0000)]
revert accidental commit of dojo-to-for(;;;) test

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoteach the 1.6-2.0 reingest generator about "tnf"-tag rows for title sorting
miker [Tue, 15 Mar 2011 17:15:01 +0000 (17:15 +0000)]
teach the 1.6-2.0 reingest generator about "tnf"-tag rows for title sorting

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoMisc. changes to installer including:
phasefx [Tue, 15 Mar 2011 15:52:12 +0000 (15:52 +0000)]
Misc. changes to installer including:

1 - Fix profile manager links
2 - Add tag at top (currently "Trunk") for easy changing
3 - Add optional extras.nsi for easy additions of extra install/uninstall lines
4 - Run uninstaller if installing to a directory with one (old style OR new style)
5 - Allow license override and only show license page if one defined
    Ex. With NSIS_EXTRAOPTS set to "-DPRODUCT_LICENSE=some/path"
    Or to disable use "-DPRODUCT_LICENSE"
6 - Similar to devbuild, allow for registration per-machine by default
    This includes needing to not wipe out the folder this is stored in
7 - Make "Everyone" able to write to the install folder when:
    Autoupdate is an option
    Per-machine registration is an option
8 - Make silent uninstall function

Author: Thomas Berezansky <>
Signed-off-by: Thomas Berezansky <>
Signed-off-by: Jason Etheridge <>
git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agomake sure search path is set up properly for FTS in 9.0
miker [Tue, 15 Mar 2011 15:51:21 +0000 (15:51 +0000)]
make sure search path is set up properly for FTS in 9.0

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoDefault workstation name to something sensible.
phasefx [Tue, 15 Mar 2011 11:59:04 +0000 (11:59 +0000)]
Default workstation name to something sensible.

Like the computer's hostname. But not localhost.

Author: Thomas Berezansky <>
Signed-off-by: Thomas Berezansky <>
Signed-off-by: Jason Etheridge <>
git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoPrevent creation of report folders with empty folder names
dbs [Tue, 15 Mar 2011 01:37:28 +0000 (01:37 +0000)]
Prevent creation of report folders with empty folder names

Addresses LP # 720755. Clicking the "Create Folder" button when
no folder name has been supplied is now a no-op.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoMerge branch 'opac-tt-poc' of ssh://
senator [Mon, 14 Mar 2011 21:57:04 +0000 (17:57 -0400)]
Merge branch 'opac-tt-poc' of ssh:// into opac-tt-poc

9 years agoIf the TT stuff loads CGI w/o -utf8, that "instance" (not really instance)...
senator [Mon, 14 Mar 2011 21:48:25 +0000 (17:48 -0400)]
If the TT stuff loads CGI w/o -utf8, that "instance" (not really instance)...

... will compete with use CGI in Really. Normally I enjoy
perl but the awful, horrendous, unspeakable black magic used in
has given me a great deal of trouble today.

Specifically, I could not really succeed in subclassing it. I had a kind
of half success before, but I could only really replace methods in my
subclass, but not call the methods unchanged from the original base
class (CGI).  This manifested in a bug where I had been using
the query_string() method preserve search terms across some pages, but
that method had stopped working since I introduced the CGI subclass.

In an attempt to fix that, I discovered this document
and tried the advice therein, and several variations thereof, but
everything I produced caused mod_perl to consume memory until it keeled
over from OOM.

Finally, I discovered that I never really needed the subclass in the
first place, so long as 'use CGI' with no module parameters doesn't
happen in the same process as 'use CGI qw/-utf8/'.

9 years agointegrated update-email address action into account prefs
berick [Mon, 14 Mar 2011 21:46:13 +0000 (17:46 -0400)]
integrated update-email address action into account prefs

9 years agoCGIUTF8 was a horrible, subtle, dark failure
senator [Mon, 14 Mar 2011 21:31:05 +0000 (17:31 -0400)]
CGIUTF8 was a horrible, subtle, dark failure

and I don't want to talk about it. Also, 'use CGI qw/-utf8/' suddenly
works.  Maybe it always did.

9 years agoi18n and repaired holds estimated wait calculation.
berick [Mon, 14 Mar 2011 20:43:57 +0000 (16:43 -0400)]
i18n and repaired holds estimated wait calculation.

9 years agountil futher investigation, roll back the changes of == to ===, since it was causing...
erickson [Mon, 14 Mar 2011 16:34:27 +0000 (16:34 +0000)]
until futher investigation, roll back the changes of == to ===, since it was causing unexpected changes in behavior.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoclass cxt has no field named 'field_class', removing from IDL
erickson [Mon, 14 Mar 2011 16:34:26 +0000 (16:34 +0000)]
class cxt has no field named 'field_class', removing from IDL

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoMore menu work for record attr/coded map config UIs
erickson [Mon, 14 Mar 2011 16:34:25 +0000 (16:34 +0000)]
More menu work for record attr/coded map config  UIs

menu entry for config.coded_value_maps,
updated menu label and page title for config.record_attr_definition page;
in some cases (that probabl need investigating), widget.validate function is not defined.  in those cases, don't attempt to call the function

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agohide edit link in myopac/holds. show basic user info in myopac/prefs
senator [Mon, 14 Mar 2011 16:02:39 +0000 (12:02 -0400)]
hide edit link in myopac/holds. show basic user info in myopac/prefs

9 years agoMerge branch 'master' of ssh://
senator [Mon, 14 Mar 2011 14:08:03 +0000 (10:08 -0400)]
Merge branch 'master' of ssh:// into opac-tt-poc

9 years agoPure whitespace (tabs to spaces) for dojo.fieldmapper
dbs [Mon, 14 Mar 2011 04:46:28 +0000 (04:46 +0000)]
Pure whitespace (tabs to spaces) for dojo.fieldmapper

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoApply jshint suggestions for cleanup to dojo.fieldmapper
dbs [Mon, 14 Mar 2011 04:21:20 +0000 (04:21 +0000)]
Apply jshint suggestions for cleanup to dojo.fieldmapper

Mostly consisting of missing semicolons and avoiding the redeclaration
of variables (generally for iterators) within the same function scope.
Some tightening of null and '' checks to avoid implicit type-casting.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoNormalize patron profile search function in "Search for Patrons" UI
dbs [Sun, 13 Mar 2011 22:09:06 +0000 (22:09 +0000)]
Normalize patron profile search function in "Search for Patrons" UI

Use util.widgets.make_menulist for a more consistent approach to
generating the menulist and use a row/label/hbox layout to normalize the
appearance of the patron profile filter in the search menu.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoApply patch to add a patron profile filter to the "Search for Patrons" UI
dbs [Sun, 13 Mar 2011 22:02:19 +0000 (22:02 +0000)]
Apply patch to add a patron profile filter to the "Search for Patrons" UI

Thanks to Michael Peters <> and
Thomas Berezansky <> for their work on this additional
functionality to the patron search UI, supplied as a patch in LP# 715837.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoRemove unsupported versions of PostgreSQL FTS configs
dbs [Sun, 13 Mar 2011 04:37:25 +0000 (04:37 +0000)]
Remove unsupported versions of PostgreSQL FTS configs

We don't support anything below PostgreSQL 9.0, so let's get this
deadwood out of the way lest anyone get confused.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoClean up build errors when creating/recreating database schema
dbs [Sat, 12 Mar 2011 23:37:45 +0000 (23:37 +0000)]
Clean up build errors when creating/recreating database schema

Dropping the evergreen schema cascaded and wiped out some previously
defined functions, so move it ahead of the other functions. (And maybe
we can start moving those public functions into the evergreen schema?)

DROP AGGREGATE IF EXISTS exists on any version of PostgreSQL that we
care about for Evergreen 2.0, so we can use it to avoid false errors
during schema creation.

FTS config was complaining about public.english_nostop in the ALTER
statement, so remove the schema qualification. This seems to have
been there for a long time?

Use IF EXISTS when dropping the unapi schema to avoid an error.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoUse valid DDL for forgotten index on actor.card
dbs [Sat, 12 Mar 2011 22:18:59 +0000 (22:18 +0000)]
Use valid DDL for forgotten index on actor.card

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoResolve inconsistent results when invoking LOWER() in C vs. UTF8 locale databases
dbs [Sat, 12 Mar 2011 02:57:32 +0000 (02:57 +0000)]
Resolve inconsistent results when invoking LOWER() in C vs. UTF8 locale databases

As reported by the Fundamental Science Library of Armenia, patron searches
were not retrieving patrons who were known to be part of the patron database.

While the initial approach to solve this problem used an encode_utf8() call
to encode the data before passing it on to the database, this turned out to
break the patron search function in other environments.

Testing by Dan Wells confirmed that the LOWER() function returned different
results when invoked against text in a database created with LC_CTYPE=C vs
a database created with LC_CTYPE=*.UTF-8. As the patron search function
used a Perl lc() function call to convert the incoming data to lowercase,
the success of the call depended on the LC_CTYPE value of the database.

To avoid this problem in the future, we define our own evergreen.lowercase()
function that can reliably produce lowercase text for characters outside
the Latin1 range, and we convert our indexes and function calls to use that
function consistently.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoSupport for most of the actions on lists and bookbags
senator [Fri, 11 Mar 2011 23:07:54 +0000 (18:07 -0500)]
Support for most of the actions on lists and bookbags

Show authors too. And other little stuff.

9 years agoonly append street2 to CC payment address if no address is provided by the caller
erickson [Fri, 11 Mar 2011 21:57:21 +0000 (21:57 +0000)]
only append street2 to CC payment address if no address is provided by the caller

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoAcq: The "Claim-Ready Items" interface did not render correctly for > 1 item
senator [Fri, 11 Mar 2011 20:44:33 +0000 (20:44 +0000)]
Acq: The "Claim-Ready Items" interface did not render correctly for > 1 item

The problem was racy async rendering logic. Now we look at our whole result
set and build our table accordingly at the end.

This interface should probably learn about paging one day in order to
handle large result sets.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoUpdate the README to include explict LC_CTYPE/LC_COLLATE db settings
dbs [Fri, 11 Mar 2011 20:39:48 +0000 (20:39 +0000)]
Update the README to include explict LC_CTYPE/LC_COLLATE db settings

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoLANG=C results in SQL_ASCII encoding by default for PostgreSQL, which isn't cool
dbs [Fri, 11 Mar 2011 20:37:50 +0000 (20:37 +0000)]
LANG=C results in SQL_ASCII encoding by default for PostgreSQL, which isn't cool

The docs have been adjusted as 8.4 and up now offer database-level
--lc-ctype / --lc-collate options for createdb command.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agouse the existing util method for mvr-izing, since it handles some additional importan...
erickson [Fri, 11 Mar 2011 20:20:43 +0000 (20:20 +0000)]
use the existing util method for mvr-izing, since it handles some additional important steps (e.g. capturing doc_id)

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoEnsure incoming query values to patron search are UTF8-encoded
dbs [Fri, 11 Mar 2011 16:42:01 +0000 (16:42 +0000)]
Ensure incoming query values to patron search are UTF8-encoded

Addresses the problem reported with searching for patrons with
Armenian names, where Unicode query params were getting corrupted
on its way to the database.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoFoundational work for temporary/anon lists and per-user lists (bookbags)
senator [Thu, 10 Mar 2011 22:24:08 +0000 (17:24 -0500)]
Foundational work for temporary/anon lists and per-user lists (bookbags)

There were already some features in EGCatLoader for adding and
deleting items from lists, but there's more to do, as that code only
dealt with numeric IDs, and we need records avaiable. Also, to avoid
search bots creating temporary/anon lists all the time, and just because
the following is good practice, our "add to my list" links need to be
forms that POST, not links that GET.

Etc., etc.; more to come.

9 years agoadd patron barcode to CC transaction description for payment record keeping/tracking
erickson [Thu, 10 Mar 2011 21:25:16 +0000 (21:25 +0000)]
add patron barcode to CC transaction description for payment record keeping/tracking

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agobump xulrunner version
phasefx [Thu, 10 Mar 2011 20:53:08 +0000 (20:53 +0000)]
bump xulrunner version

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoComplain when trying to register an empty Workstation ID
phasefx [Thu, 10 Mar 2011 19:33:27 +0000 (19:33 +0000)]
Complain when trying to register an empty Workstation ID

Client-side only, no server side validation.

Signed-off-by: Jason Etheridge <>
git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoBooking: don't bail out completely on COPY_ALERT_MESSAGE when returning items
senator [Thu, 10 Mar 2011 17:08:39 +0000 (17:08 +0000)]
Booking: don't bail out completely on COPY_ALERT_MESSAGE when returning items

Provide overridability.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoas an alternate/addition to applying per-setting permissions, use the existing VIEW_O...
erickson [Thu, 10 Mar 2011 14:24:18 +0000 (14:24 +0000)]
as an alternate/addition to applying per-setting permissions, use the existing VIEW_ORG_SETTINGS permission as a general gateway into the org settings UI

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years ago'newpo' in install_all_locales was wiping out all fr-CA translations
dbs [Wed, 9 Mar 2011 21:59:40 +0000 (21:59 +0000)]
'newpo' in install_all_locales was wiping out all fr-CA translations

Long story short, we would rather have install_all_locales fail loudly
than silently wipe out fr-CA.

git-svn-id: svn:// dcc99617-32d9-48b4-a31d-7c20da2025e4