Jason Etheridge [Thu, 22 Aug 2013 16:48:53 +0000 (12:48 -0400)]
Add a TestUtils library for live tests
Package commonly used live test calls in a new Perl module to they can
be shared by different test scripts.
Based it off of Cronscript. Added a cache method to Cronscript for getting at
memcached. TestUtils currently has methods for checkin, checkout, and
workstation registration.
Ported existing live tests to use TestUtils.
Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Jason Etheridge [Fri, 2 Aug 2013 19:25:58 +0000 (15:25 -0400)]
test bill payment
./05-pay_bills.t ..................
1..10
# Test bill payment against the admin user.
ok 1 - open-ils.storage.direct.actor.user.retrieve returned aou object
ok 2 - User with id = 1 is admin user
# authtime is 7200, authtoken is b039320a72bbd06c30f0918d1aeeb07a
ok 3 - Have an authtoken
ok 4 - Registered a new workstation
# authtime is 7200, authtoken is b039320a72bbd06c30f0918d1aeeb07a
ok 5 - Have an authtoken associated with the workstation
ok 6 - Two billable xacts for admin user from previous tests
ok 7 - Both transactions combined have a balance owed of 1.25
ok 8 - Payment attempt returned HASH
ok 9 - Payment response included two payment ids
ok 10 - Zero billable xacts for admin user after payment
ok
Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Jason Etheridge [Wed, 17 Jul 2013 21:55:07 +0000 (17:55 -0400)]
tests against stock test data and live Evergreen
I'm running these on a machine where Evergreen has been installed with the stock
test data. Repeat invocations of the tests will cause test failures, as they
don't completely cleanup after themselves (the goal long-term is to rely on
complete database wipes between invocations).
Manual cleanup right now could include doing the following in psql:
DELETE FROM actor.workstation WHERE name ~ '.t$';
and paying the bills on the admin user (otherwise, once a Max Fines penalty is
generated, checkout tests will fail).
opensrf@dev141:~/git/Evergreen/Open-ILS/src/perlmods (livetests)$ make livecheck 2> /dev/null
perl Build.PL --destdir || make -s build-perl-fail
Creating new 'MYMETA.yml' with configuration results
Creating new 'Build' script for 'OpenILS' version '2.4'
./Build test --test_files live_t || make -s build-perl-fail
live_t/00-simple.t ..................... ok
live_t/01-auth.t ....................... ok
live_t/02-simple_circ.t ................ ok
live_t/03-overdue_circ.t ............... ok
live_t/04-overdue_with_closed_dates.t .. ok
All tests successful.
Files=5, Tests=62, 11 wallclock secs ( 0.25 usr 0.16 sys + 3.52 cusr 0.63 csys = 4.56 CPU)
Result: PASS
and
opensrf@dev141:~/git/Evergreen/Open-ILS/src/perlmods (livetests)$ prove -v live_t/
live_t/00-simple.t .....................
1..2
# Simple tests against the open-ils.storage service and the stock test data.
ok 1 - open-ils.storage.direct.actor.user.retrieve returned aou object
ok 2 - User with id = 1 is admin user
ok
live_t/01-auth.t .......................
1..4
# Simple tests against the open-ils.auth service, memcached, and the stock test data.
# authtime is 7200, authtoken is a3f2d06775fb670284450ad1f1d6ea00
ok 1 - Have an authtoken
ok 2 - Default authtime for staff login is 7200 seconds
ok 3 - Can retrieve authtoken from memcached
ok 4 - Authtoken is removed from memcached after logout
ok
live_t/02-simple_circ.t ................
1..14
# Test circulation of item CONC70000345 against the admin user.
ok 1 - open-ils.storage.direct.actor.user.retrieve returned aou object
ok 2 - User with id = 1 is admin user
ok 3 - open-ils.storage.direct.asset.copy.retrieve returned acp object
ok 4 - Item with id = 310 has barcode CONC70000345
ok 5 - Item with id = 310 has status of Reshelving or Available
# authtime is 7200, authtoken is f7c9ae35165ec74ab5e8ce5b84673da8
ok 6 - Have an authtoken
ok 7 - Registered a new workstation
# authtime is 7200, authtoken is f7c9ae35165ec74ab5e8ce5b84673da8
ok 8 - Have an authtoken associated with the workstation
ok 9 - Checkout request returned a HASH
ok 10 - Checkout returned a SUCCESS event
ok 11 - Item with id = 310 has status of Checked Out after fresh Storage request
ok 12 - Checkin request returned a HASH
ok 13 - Checkin returned a SUCCESS event
ok 14 - Item with id = 310 has status of Reshelving or Available after fresh Storage request
ok
live_t/03-overdue_circ.t ...............
1..20
# Test fine generation on checkin against the admin user.
ok 1 - open-ils.storage.direct.actor.user.retrieve returned aou object
ok 2 - User with id = 1 is admin user
ok 3 - open-ils.storage.direct.asset.copy.retrieve returned acp object
ok 4 - Item with id = 810 has barcode CONC71000345
ok 5 - Item with id = 810 has status of Reshelving or Available
# authtime is 7200, authtoken is 5ab4ae5b9a09c7fd04b4eb0dabf19da5
ok 6 - Have an authtoken
ok 7 - Registered a new workstation
# authtime is 7200, authtoken is 5ab4ae5b9a09c7fd04b4eb0dabf19da5
ok 8 - Have an authtoken associated with the workstation
ok 9 - Checkout request returned a HASH
ok 10 - Checkout returned a SUCCESS event
ok 11 - Checkout response object has payload object
ok 12 - Payload object has circ object
ok 13 - Circ objection has loan duration of "7 days"
ok 14 - Item with id = 810 has status of Checked Out after fresh Storage request
ok 15 - Zero bills associated with circulation
ok 16 - rewrote circ to have happened 20 days ago
ok 17 - Checkin request returned a HASH
ok 18 - Checkin returned a SUCCESS event
ok 19 - Item with id = 810 has status of Reshelving or Available after fresh Storage request
ok 20 - Thirteen bills associated with circulation
ok
live_t/04-overdue_with_closed_dates.t ..
1..22
# Test fine generation with closed date on checkin against the admin user.
ok 1 - open-ils.storage.direct.actor.user.retrieve returned aou object
ok 2 - User with id = 1 is admin user
ok 3 - open-ils.storage.direct.asset.copy.retrieve returned acp object
ok 4 - Item with id = 1310 has barcode CONC72000345
ok 5 - Item with id = 1310 has status of Reshelving or Available
# authtime is 7200, authtoken is dd4b533f677dd5ec6d177312eca2e86b
ok 6 - Have an authtoken
ok 7 - Registered a new workstation
# authtime is 7200, authtoken is dd4b533f677dd5ec6d177312eca2e86b
ok 8 - Have an authtoken associated with the workstation
ok 9 - Created a closed date for 10 days ago
ok 10 - Checkout request returned a HASH
ok 11 - Checkout returned a SUCCESS event
ok 12 - Checkout response object has payload object
ok 13 - Payload object has circ object
ok 14 - Circ objection has loan duration of "7 days"
ok 15 - Item with id = 1310 has status of Checked Out after fresh Storage request
ok 16 - Zero bills associated with circulation
ok 17 - rewrote circ to have happened 20 days ago
ok 18 - Checkin request returned a HASH
ok 19 - Checkin returned a SUCCESS event
ok 20 - Item with id = 1310 has status of Reshelving or Available after fresh Storage request
ok 21 - Twelve bills associated with circulation (instead of 13, thanks to closed date)
ok 22 - Removed closed date
ok
All tests successful.
Files=5, Tests=62, 10 wallclock secs ( 0.06 usr 0.04 sys + 3.29 cusr 0.50 csys = 3.89 CPU)
Result: PASS
Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Garry Collum [Sun, 4 Aug 2013 20:10:26 +0000 (16:10 -0400)]
lp1193487 Circulation Policy Column Picker not saving configuration.
The circulation policy column picker is not saving its configuration
because ui.grid_columns.conify.config.circ_matrix_matchpoint is not
defined in the config.usr_setting_type table. This updates the sql
to populate the table.
Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Mon, 30 Sep 2013 13:22:26 +0000 (09:22 -0400)]
Capture all alternative titles
With the addition of bib browse, the alternative title index definition
was made to point at the 740 (ind2 != 2), which contains non-analytic
alternative titles /and/ non-filing indicator info. It used to capture
both the 246 and (appropriate) 740's. Allow either to match the XPath.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
OPAC: Make advanced search -> numeric search -> bib cn hone in on right target
The bib call number search under the advanced search page's numeric
search pane was doing the wrong thing. By thinking the search field
desired was called 'bib_cn' where it's actually called 'bibcn', it
generated searches that just fell back to the broader search class
'identifier'. This would often find your matches, but would also find
too many records that *shouldn't* have been matches.
Discovered with help from Erica Rohlfs and Mike Rylander.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Remove unnecessary Title Proper (Browse) index from config.metabib_field
As pointed out by Ben Shum and Dan Wells, we don't need this index, and
it made it only into the seed data and not into any upgrade script in
master. It's a relic of bib-and-auth-browse development that ought to
have been removed before the merge to master.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Kathy Lussier [Fri, 4 Oct 2013 19:32:56 +0000 (15:32 -0400)]
Move some release notes to core docs
The release notes for Phonelist.pm and floating groups provided some good
documentation, so let's move them to the core docs and leave just the
intro for the release notes.
Dan Wells [Thu, 3 Oct 2013 21:54:03 +0000 (17:54 -0400)]
Relax MFHD subfield 'a' requirement for caption/patterns
If going by the book, every caption/pattern field would have a
subfield 'a', since the data from subfield 'i' would be moved to
'a' if 'a' was empty. Since that is arcane, and our own wizards
used to bend this rule, let's make some minor adjustments to our
expectations:
1) When calculating date progression, don't expect there to be an 'a'
subfield which needs to be "carried" into.
2) When determining whether a field is 'open-ended', check the first
availabile enum/chron subfield rather than hard-coding the check to
'a'.
These changes do not affect the display formatters, so strings
generated from 'a'-less caption/pattern combos are not exactly right,
but they suffice.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Ben Shum <bshum@biblio.org>
LP#1207281: require SSL when downloading offline patron list
This patch builds on the previous one by forcing use of
SSL for downloading the offline patron list. It also
updates the Apache 2.4 example configuration.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Michael Peters [Tue, 24 Sep 2013 20:57:37 +0000 (16:57 -0400)]
LP#1207281 Prevent download of offline patron list without authentication
This patch addresses the vulnerability which allowed a user with the proper
knowledge of the location of offline patron lists to download the file over
regular HTTP without any staff credentials.
This small addition to eg_vhost.conf.in will present users with a login prompt
when trying to access the /standalone/ subdirectory on an Evergreen server.
Users are able to download the patron list in the staff client as normal
because they already have obtained credentials during the normal staff client
authentication process.
Signed-off-by: Michael Peters <mpeters@emeralddata.net> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Jason Stephenson [Wed, 30 Jan 2013 21:56:12 +0000 (16:56 -0500)]
Fix an omission in the log redaction configuration.
open-ils.actor.patron.password_reset.commit was omitted in the
<log_protect> block of opensrf_core.xml.example. This commit adds
it and updates the release notes for 2.3 to include it.
There is also a release notes file informing users that they need to
edit opensrf_core.xml to address this issue.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Jeff Godin [Thu, 19 Sep 2013 18:12:43 +0000 (14:12 -0400)]
Add method to permit AC handler to expect keyhash
Add an expects_keyhash method to
OpenILS::WWW::AddedContent::Syndetic and look for it from
OpenILS::WWW::AddedContent. This allows us to pass a keyhash
(containing isbn/upc/whatever) to this handler while still passing a
simple scalar containing an ISBN to other AddedContent handlers.
Signed-off-by: Jeff Godin <jgodin@tadl.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Jeff Godin [Wed, 25 Apr 2012 08:23:28 +0000 (04:23 -0400)]
Finish Added Content by record ID
OpenILS::WWW::AddedContent now supports fetching content by record ID.
To start, this lets us request content in a way that uses both ISBN
and UPC as keys, assuming the AC handler and provider support it.
The previous method of requesting AC data continues to be
supported, and should be unaffected.
Business::ISBN is used to clean ISBN values when fetching by record ID
If we find no valid ISBN and no UPC values in the record,
do not attempt to call an AC handler. This will need
to change when we have AC handlers that rely on other
possible keys.
Attempt to serve from cache before fetching keys from the bib
record in the database.
Signed-off-by: Jeff Godin <jgodin@tadl.org> Signed-off-by: Ben Shum <bshum@biblio.org>
With this, we enhance the browse method to allow the return of authority-only
terms (that is, main entries not used by a bib record) if the authority record
from which the term comes is linked to another authority record via the
mechanism created by 3eb616e5, and that linked authority record is itself in
use by visible bibliographic records.
In order to accomplish this we:
* extend normalization of both bib and auth records to allow a custom string
to be used when joining parts of a term (for instance, joining subject
components with " -- ")
* cause authority headings to be including in the unique set of values
captured by metabib.browse_entry during authority ingest
* link authority-heading derived browse entries to their authority-indexed
counterparts
* extend the metabib.browse() stored procedure (and related) to inspect
authority-linked browse entries
* extend bibliographic-visiblity testing to cover those bibliographic records
in use by remote-linked authority records.
* generate browse links between headings found to be appropriately linked
and bibliographically in-use and visible
The addition of this functionality will require, in the least, reingest of
all authority records, and would benefit from reingest of bibliographic
records as well, as ingest has been improved and extended.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Stephenson [Thu, 26 May 2011 14:30:10 +0000 (10:30 -0400)]
Add PhoneList.pm.
A simple WWW module to list patrons who have holds with their phone
numbers and barcodes. The format is as requested by a specific library
for their automated calling program.
Future modifications may include the ability to rearrange the output
columns and provide formats for some data.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Wed, 4 Sep 2013 13:26:23 +0000 (09:26 -0400)]
Fiction records / copies test data
Adds 17 (mostly) fiction bib records w/ copies to
OpenILS/tests/datasets/sql/. New items are loaded via load_all.sql.
Special thanks to Rogan Hamby for donating (and I believe creating)
these records many moons ago. For reference:
The father hunt;
Southern Gods /
The winter of our discontent /
CliffsNotes Steinbeck's Of mice and men /
The rum diary
Blueberry girl /
Stardust
Coraline
Objective-C programming :
The swordsman of Mars /
Ghost story
The Avengers
Throne of the Crescent Moon /
The walking dead.
Kraken :
The crow
The running man /
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Steven Callender [Thu, 12 Sep 2013 17:30:16 +0000 (13:30 -0400)]
Added in warning message when placing hold with no email address.
Previously when an account didn't have an email address associated with it
when placing a hold, the input box would be greyed out and the display
would show the Email Address text with no address to go with it.
This change will instead show text warning the user that they have
no email address configured and they need to go to My Account in order
to add one to their account.
Signed-off-by: Steven Callender <stevecallender@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Wells [Wed, 25 Sep 2013 20:46:31 +0000 (16:46 -0400)]
TPAC: Consolidate and simplify button styles
TPAC has at least two distinct types of buttons, those created by
input tags, and those created by anchor (that is, <a>) tags. This
commit simplifies and consolidates the styles used for both types
of buttons.
At least in Firefox, inline blocks display in a closer size rendering
to <input> tags than plain 'display:inline'. The switch doesn't seem
to hurt in most cases in IE, FF, or Chrome, so let's do it.
Two cases where inline works better are the floating 'My Account' and
'dash' buttons'. They already have special classes, so let's revert
those back to inline. In fact, let's make the logged-in 'dash'
buttons share the style of the 'My Account' button which got us there,
and make all three buttons more visible when hovering.
Inputs do not inherit the body font by default, so let's apply it for
better display consistency.
Finally, Firefox inputs have some extra space around them; let's make
a modest attempt to remove that.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Ben Shum <bshum@biblio.org>
Ben Shum [Wed, 25 Sep 2013 21:40:57 +0000 (17:40 -0400)]
TPAC: Add format icon back to search results
As a compromise, add the format icon back to the search results to sit alongside
the fully spelled out format label for the record. Having the label next to the
icon helps to inform on the icon without the need to hover.
Local sites may consider customizing this to their personal desires.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Wells [Wed, 25 Sep 2013 16:53:51 +0000 (12:53 -0400)]
TPAC: Make corner image link to server root
Most people will do this anyway, and in the MOPAC view, you currently
get trapped in 'My Account' with no obvious way out unless we have
a link like this.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Scott [Wed, 25 Sep 2013 03:38:23 +0000 (23:38 -0400)]
TPAC: Make low hits help support low-width devices
Inline styles were forcing the width of the low-hits help box to be
353px wide, which is wider than our target 320 width for mobile devices.
Let the help use the full available width under the 600px barrier.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Scott [Wed, 25 Sep 2013 03:07:30 +0000 (23:07 -0400)]
TPAC: Make home search screen work on IE8+
The home logo is now centred on IE, and the white background extends
across the full width of the page. Huzzah!
As a bonus, the markup makes more sense without the <strong><center>.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Ben Shum [Tue, 24 Sep 2013 21:47:16 +0000 (17:47 -0400)]
Add missing ending label tag for format selector
On the basic search, we were missing an ending label tag so it was combining
the one from formats and library pickers into a single element which made
selecting the library misbehave.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Ben Shum [Tue, 24 Sep 2013 20:03:59 +0000 (16:03 -0400)]
Remove extra large facets
While an interesting experiment, as agreed in IRC conversation with kmlussier
and dbs, we will remove the extra wide facets being used in wider screens for
the time being.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
There were a couple of explicit width in the My Account area that were
causing the account expiration alert to run off the screen. I removed them
and a tweak to the CSS to get the page elements to display
properly.
Bill Ott [Tue, 24 Sep 2013 19:20:56 +0000 (15:20 -0400)]
i18n support for field names in myopac css
Signed-off-by: Bill Ott <bott@grpl.org> Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Ben Shum [Tue, 24 Sep 2013 18:16:21 +0000 (14:16 -0400)]
Fix tab button margins
Remove a hanging 10px margin that made the advanced search tabs and my account
tabs appear as though they were floating over the contents they were connected
with.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Scott [Tue, 24 Sep 2013 17:21:35 +0000 (13:21 -0400)]
TPAC: Simplify opac-button styling
Conflicting padding declarations in the stylesheet, in an old attempt to
balance out the sizes of various INPUT types vs A elements in Chrome vs.
Firefox, were resulting in increasingly odd sizes for the buttons
(depending on which browser you used). Switching to a BUTTON instead of
an A tag and dropping all of the padding declarations improves the
situation on Firefox, Chrome, and IE8, while simplifying the CSS.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Scott [Tue, 24 Sep 2013 17:04:56 +0000 (13:04 -0400)]
TPAC: Retain advanced search tabs via overflow:auto
At small widths, the advanced search tabs could be forced to escape the
search tab header in a displeasing fashion. Also, the background bar
that provides context for the selected tab had been lost - and
overflow:auto fixes that. Thanks to Dan Wells for the suggestion.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Scott [Tue, 24 Sep 2013 15:24:39 +0000 (11:24 -0400)]
TPAC: Main content needs a clear:both style
On My Account, the content of tabs was riding up against the tabs. Use
clear:both style for #main-content to force the main content to start on
a new line.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Use a new class "nonbreaking-wrapper" with display:inline-block to keep
label + input fields together, rather than the inline "whitespace:
no-wrap" which did not work on Chrome (and oddly enough forced the value
field to the next line).
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Scott [Tue, 24 Sep 2013 14:51:36 +0000 (10:51 -0400)]
TPAC: Prevent IE compatibility view
Windows XP has IE8, and it can handle the CSS we have in the TPAC.
However, the "compatibility view" button, if clicked, actually results
in horribly broken rendering (contrary to what one would expect).
Adding this <meta> tag prevents the compatibility view button from
displaying and should improve the experience for users.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Scott [Tue, 24 Sep 2013 13:53:34 +0000 (09:53 -0400)]
TPAC: Clear line for initial advanced search tab
The initial advanced search tab was being rendered right beside the tabs
instead of underneath them; fix in the same way we fixed the numeric and
expert tabs previously.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
These display well as tabs since there are only two tabs to display. Probably
inadvisable to replace these tabs with menus as we did in other places because
there are already menus on these screens to perform actions on selected
checkouts/holds.
Dan Scott [Tue, 24 Sep 2013 05:55:37 +0000 (01:55 -0400)]
TPAC: Streamline facet display
Rather than including a DIV containing only a non-breaking space to
clear the lines of the facets, just use CSS to clear each facet and set
a bottom margin appropriately.
Also, take advantage of wide screens by allowing facets to display
more broadly rather than being limited to a 10% width of the screen.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Scott [Tue, 24 Sep 2013 05:29:19 +0000 (01:29 -0400)]
TPAC: Advanced search - add line break
The header and form for numeric search and expert search were being
displayed inline with the tabs on the advanced search page; push those
down where they should be.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Scott [Tue, 24 Sep 2013 05:15:39 +0000 (01:15 -0400)]
TPAC: Draw a border under the result header bar
Particularly needed in mobile mode, where the background has been set to
inherit, draw a bottom border to separate the result header actions from
the pagination controls.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Scott [Tue, 24 Sep 2013 05:11:36 +0000 (01:11 -0400)]
TPAC: Enable search bar elements to wrap gracefully
As the browser window narrows, stack the search bar elements vertically
as needed.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Scott [Tue, 24 Sep 2013 05:07:00 +0000 (01:07 -0400)]
TPAC: Define result header padding by contents
Rather than defining padding for the result header bar and then defining
margins for the contained labels and buttons, rely strictly on the
buttons and labels to position themselves.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Scott [Tue, 24 Sep 2013 04:46:27 +0000 (00:46 -0400)]
TPAC: Make result label text consistent size
The text on the result header buttons was all 100%, while the text
labels for the sort and limit to available widgets for some reason were
set to a smaller font size, despite appearing on the same line.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Scott [Tue, 24 Sep 2013 04:43:50 +0000 (00:43 -0400)]
TPAC: Make result button text consistent
There's no good reason for the result buttons to have underlined text
when most other buttons in the Web UI do not have underlined text.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Scott [Tue, 24 Sep 2013 04:36:59 +0000 (00:36 -0400)]
TPAC: Remove wide bar under results options header
The hard-coded <br class="clear-both"> adds a full em of empty vertical
space to the full TPAC with no usability gain. Remove it.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
projects / working / Evergreen.git / log