We add the lib... prefix to all C library names as expected by most
linkers. This necessitates changes to the opensrf.xml configuration
file.
Debian 9's ld also apparently requires that ldconfig be run again
after the Evergreen C libraries are installed, so we add that step to
the installation instructions as well.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP#1706124: Make include inactive patrons checkbox sticky
The state of the 'include inactive' checkbox on the patron search page will now
be remembered when users return to the page. Many thanks to Cesar Velez,
whose code for bug 1697754 inspired this patch!
Show warning message to user when an unknown barcode is scanned in the
copy bucket pending list UI. Also, after a barcode failure occurs, select
the barcode text (instead of clearing it) so it can be seen and easily
replaced, consistent with the item status UI.
After successful scan, clear and re-focus the barcode input box.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Bill Erickson [Thu, 14 Sep 2017 22:09:08 +0000 (18:09 -0400)]
LP#1712637 Patron edit hold pickup location repairs
1. Allow setting the hold pickup location independant of the home
library.
2. Disable org units in the pickup lib selector that are not viable hold
pickup locations (can_have_vols=f)
3. Consistent w/ the XUL client, allow a patron to be created without
selecting a default pickup location.
To test:
[1] Register a new patron and confirm pickup location is initialy unset.
[2] Confirm pickup lib options are viable pickup locations.
[3] Apply a pickup location different from the home library and confirm
the home library selector remains unchanged.
[4] Confirm saving the patron applies the expected pickup location value.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
The $scope.is_registering is used to enable/disable the Register btn
and was not being set back to false, when the user chose to cancel
using an existing WS name, and exiting the modal.
To test
-------
1. Register a workstation.
2. Switch to a different computer or Chrome profile.
3. Try to register the same workstation name. Warning dialog will pop
up.
4. Click cancel.
5. See that the register button is now disabled and no actions on the
form seem to reactivate it.
6. Apply the patch and repeat steps 2-4. This time, the register button
should be active.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Ben Shum <ben@evergreener.net>
LP#1713151: display owning OU in volcopy editor location selector
This patch causes the short name of the OU that owns a location
to be displayed after the location name in shelving location selectors
in the item attribute and copy template editors.
To test
-------
[1] Edit an item and verify that the shelving location selector
displays the org unit shortname in parentheses after the location
name.
[2] Verify that the location selector in the copy template portion
also displays the OU short names.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org> Signed-off-by: Ben Shum <ben@evergreener.net>
LP#1708951: fix tabbing in webstaff catalog app for Firefox
This patch works around an issue where Firefox appears to require
that the iframe for the embedded OPAC not have a null catalog_url
value. It also fixes an issue where navigating to the OPAC View tab
after retrieving the record with a different default view set would
cause it to jump back to that default view... the first time.
To test:
[1] In the web staff client, retrieve a bib record and set the default
view to a tab other than 'OPAC View'.
[2] Retrieve another bib by TCN or ID. Note that although the default tab
will briefly display, the page will jump over to the OPAC view and
display an empty record.
[3] Apply the patch and repeat step 2. This time, it should display the
record with the current default view.
[4] Select the 'OPAC View' tab and verify that it loads the record details
page.
This fixes a regression on the hotkeys introduced by the offline
circulation module.
To test
-------
[1] Apply the patch and verify that hotkeys in the web staff client
such as F1, F5, alt-s, and so forth work.
[2] Go to offline circulation and verify that select hotkeys such as
F1 and F2 activate corresponding tabs in the offline circulation
page.
[3] Repeat step 2 with the browser itself set to offline mode.
LP#1716475: Add label for mobile carrier select menu
Replace the empty string with a label in the SMS carrier select menu due to
issues that arose when putting an empty string in the translation file. It
also is good usability.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Ben Shum <ben@evergreener.net>
LP#1713160: fix crash viewing circ history in public catalog
This patch fixes a crash when a patron views their circulation
history in the public catalog.
To test
-------
[1] Set up a patron record that retains circ history and make
and returns some loans. Ensure that at least one of the
loans is aged.
[2] Log into the public catalog as the test patron and riew the
Check Out History page (/eg/opac/myopac/circ_history).
[3] Note that an internal server error is reported.
[4] Apply the patch, repeat step 2, and verify that the check out
history is now displayed.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jason Boyer [Fri, 1 Sep 2017 21:09:36 +0000 (17:09 -0400)]
LP1714589: Use Explicit Definition for aacs
Spell out the expected fields in the expected order
for the aacs view because databases that have undergone
upgrades may drift when using * in a UNION.
Signed-off-by: <JBoyer@library.in.gov> Signed-off-by: Mike Rylander <mrylander@gmail.com>
This patch accounts for the fact that the IDs returned in source_list
do not have a set order. It also no longer recreates unapi.mmr_mra()
within the test case, meaning that it can now serve as a true regression
test.
Removing the topic_subject map, since it ends up with single terms rather than
the more useful "--"-separated full subjects. Also added an "all creators"
mapping so that if the default "author" is empty for a record, the display
logic can do its best to find an appropriate value.
Gone, again, is the representative_field structure from the baseline (and from
my upgrade changes).
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
* Fix function names in drop statements for upgrade
* Adjust array concat syntax in plpgsql
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
I've rebased this to master and undertake some work to allow streamlined
reingest of specific index definitions. The API remains essentially backwards
compatable, but is reingest_metabib_field_entries() is extended to accept a
list of index definition IDs to which it should restrict its work. If that
optional parameter is not passed, all index definitions are processed.
This has the benefit of skipping XML transformation for index definitions
which won't produce output useful to the requested reingest process, which
should provide a significant speed boost for some situations.
The upgrade schema has now been realigned with some missing bits from the
baseline, but the baseline may still be lacking some from the upgrade.
The data upgrade script has been made to use the existing index definitions
where they match the needs of the new ones, and to use the new reindexing
options.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Adds functions for translating bib record display field data into a
variety of useful formats and structures. Some are best suited for
grids, others for lists of values, etc.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Thu, 11 May 2017 21:54:58 +0000 (17:54 -0400)]
LP#1251394 Compressed and wide display entry VIEWs
flat_display_entry is one row per entry with all of the relevent info.
compressed_display_entry sits atop flat_display_entry and compresses the
values into JSON scalars and arrays depending on the 'multi' value.
Wide display entry is a tabular view of the well-known fields a la
reporter.simple_record.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
'representative_field' (and its check function) create circular
references between metabib_class and metabib_field. The most
straightforward fix is to deal with those fields separate from the
initial table creation and field insertion.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Thu, 14 Nov 2013 21:43:31 +0000 (16:43 -0500)]
LP#1251394 un-squash repeated fields; some minor schema re-alignment
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Mon, 27 Jun 2011 20:53:55 +0000 (16:53 -0400)]
LP#1251394 Add display_field column to config.metabib_field
The idea is to pull the XPath definitions and i18nized labels for
config.metabib_field entries into other contexts, to avoid duplicate /
conflicting defintions in different layers of the code. If display_field
is TRUE, then it is a signal that it could be usefully exposed to users.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Cesar Velez [Fri, 11 Aug 2017 21:52:13 +0000 (17:52 -0400)]
LP#1599894 - OPAC disable Add to MyList when doing metabib search
Since adding a result to MyList yields to a random title
(due to bad id) being added to temp. lists, disable MyList if
metabib search is on, i.e "Group formats and editions"
checkbox is checked.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
This patch is a bit of hackery to work around an intermittent
(but frequent) situation where the vendor session cookie got
cleared right before invoking the cancel hold method, leading
to its failure.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Bill Erickson <berickxx@gmail.com>
- test for ebook_spinner div before attempting to set a class
- eject a couple Perlisms
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jeff Davis [Wed, 16 Aug 2017 18:30:54 +0000 (11:30 -0700)]
LP#1673870: fix OneClickdigital handler to reflect how their API actually works, documentation notwithstanding
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jeff Davis [Mon, 14 Aug 2017 21:03:59 +0000 (14:03 -0700)]
LP#1673870: display ebook availability when detailed holdings info is unavailable
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jeff Davis [Wed, 12 Jul 2017 19:35:43 +0000 (12:35 -0700)]
LP#1673870: indicate suspended holds for OverDrive
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jeff Davis [Tue, 11 Jul 2017 22:45:48 +0000 (15:45 -0700)]
LP#1673870: move ebook availability JS to standard location
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jeff Davis [Fri, 18 Aug 2017 20:35:09 +0000 (13:35 -0700)]
LP#1673870: show spinner in My Account while loading from ebook API
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jeff Davis [Tue, 4 Jul 2017 23:20:11 +0000 (16:20 -0700)]
LP#1673870: Handle OverDrive ebook checkout and download
The workflow for checking out and downloading a title via the OverDrive
API is relatively complex:
1. Check out a title.
2. Lock in a specific format for the checked-out title. Once you lock
in a format, you can only download the title in that format -- except
that the browser-based OverDrive Read and OverDrive Listen formats are
always available (if supported for that title), even if you've locked in
another format.
3. Request a link for downloading the title in the specified format.
Download links are dynamically generated and only work for 60 seconds
from the time of your request.
To simplify the process, we require the user to lock in a format during
checkout. Then, when the user clicks the Download button, we request a
download link; OverDrive responds with a URL, and we immediately
redirect the current browser tab/window to that URL.
A new API call, open-ils.ebook_api.title.get_download_link, has been
added for requesting the download link. Since API calls are not
vendor-specific, we also add support for the new method in the test
module, complete with unit test.
Supplementary fixes:
- show spinner in My Account while loading from ebook API
- ensure session ID is available to ebook object during transactions
- fix display of ebook formats
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jeff Davis [Wed, 28 Jun 2017 20:49:37 +0000 (13:49 -0700)]
LP#1673870: fix bug that prevented more than one ebook transaction from appearing in list in My Account
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
projects / working / Evergreen.git / log