Jason Etheridge [Wed, 12 Dec 2012 01:02:38 +0000 (20:02 -0500)]
P.V. SUPA GoodStuff integration
This impliments a "Server Add-ons" module for integrating P.V. Supa's RFID
product known as GoodStuff with the Evergreen staff client.
To activate it, you should add the identifier "pv_supa_goodstuff" (without the
quotes) to the list managed by the Admin->Workstation Administration->Server
Add-ons menu action within the staff client. You will need the
ADMIN_SERVER_ADDON_FOR_WORKSTATION permission to do this.
After doing this and clicking the Update Active Add-Ons button, the interface
will refresh and show a GoodStuff tab in the Add-on Preferences section. Within
this tab you will have the option of specifying the hostname and port for the
GoodStuff hardware. There is also an "Enabled" setting that needs to be checked.
Currently three interfaces have been integrated:
* Circulation -> Check In Items
* Circulation -> Check Out Items (where you scan the patron barcode)
* Circulation -> Check Out Items (where you scan the item barcodes)
Each interface gets an RFID checkbox if the "Enabled" preference has been set,
that can activate/deactivate the functionality on a per interface basis. The
checkbox states persist (i.e. are sticky).
Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Etheridge [Fri, 21 Dec 2012 05:19:37 +0000 (00:19 -0500)]
JSAN module autoloader for "add-ons"
This adds a "Server Add-ons" menu entry under Admin -> Workstation
Administration in the staff client. Choosing this allows you to edit or set a
list of identifiers that correspond to JSAN-style modules found in
/server/addons/, and is meant mainly for activating 3rd party modules within the
staff client on a per-workstation basis. You need the
ADMIN_SERVER_ADDON_FOR_WORKSTATION permission to use it.
Configuration options for activated add-ons may also show up in this interface.
More technical details:
This Server Add-ons list is stored as a JSON array in the Mozilla preference
'oils.addon.autoload.list'.
We also add an addon.autoloader module that gets called in most XUL interfaces
via the util_overlay file. This autoloader will loop through the modules
specified in 'oils.addon.autoload.list' and instantiate each, storing a
reference to each of the newly created objects in a data structure in
window.oils_autoloaded.
So, as an example, let's say there is a module: /xul/server/addon/uber_scan.js
And we have the identifier 'uber_scan' in our Server Add-ons list. Then, on
every page load of a XUL interface using the stock util overlay, we will
effectively call:
new addon.uber_scan();
Causing the code in the module to execute. It is up to the module to determine
whether it needs to do anything within a given interface.
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Conflicts [permission numbering]:
Open-ILS/src/sql/Pg/950.data.seed-values.sql
Jason Etheridge [Thu, 20 Dec 2012 21:10:57 +0000 (16:10 -0500)]
internal: default_focus not called
Minor bug. Was being called in an else clause dependent on some help context
logic for new tabs, but should be called for every new tab. Shouldn't result
in any end-user visible change, but if interfaces wrapped in browser.js were
to have a default_focus function, then this could come into play.
Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Thu, 12 Sep 2013 17:13:23 +0000 (13:13 -0400)]
Optimize container filters in QueryParser
When a container filter is used at the top level of a QueryParser
query (that is, in a simple query with no OR-logic branches or explicit
nesting groups) we can use an INNER join instead of LEFT + IS NOT NULL.
On some production datasets this showed an increase in performance from
20+ seconds to 1ms for the core query.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Bill Erickson [Wed, 11 Sep 2013 17:49:07 +0000 (13:49 -0400)]
LP#1084758 store staff client tpac (etc) zoom pref
Staff client pages loaded via browser.xul which have a name (via
internal XUL URL param) now have the ability to store and load a per-
page zoom value preference. This includes (at minimum) the embedded
TPAC.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Currently tied to CTRL with +/-/0 like Firefox uses.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Thu, 20 Jun 2013 19:46:33 +0000 (15:46 -0400)]
LP1193095 lineitem batch actions sanity filters
Avoid applying the following actions to lineitems which are in a state
where each action makes no sense.
The following actions are affected. For each, the set of states for
which a lineitem must be in for the action to proceed is listed.
create PO
- new selector-ready order-ready approved
add to PO
- new selector-ready order-ready approved
create invoice
- !cancelled
add to invoice
- !cancelled
cancel lineitem
- !cancelled
mark selector ready
- new
mark order ready
- new selector-ready
mark received
- pending-order on-order
Depending on the interface, some top-level lineitem actions may be
globally disabled. The list of states listed above represent the bare
minimum requirements.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Etheridge [Thu, 8 Nov 2012 16:27:13 +0000 (11:27 -0500)]
reset title variable when looping with biblio A/T
Two templates that I'm concerned with, though there may be others that could use
this treatment: biblio.record_entry.email and biblio.record_entry.print
Basically, they can group events from the same user and consolidate bibs, but as
they loop through the bibs they're not clearing the temporary variable that
contains the bib title, so we get duplicated and run-on titles in the output.
Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/sql/Pg/002.schema.config.sql
Pasi Kallinen [Thu, 23 May 2013 20:24:04 +0000 (13:24 -0700)]
LP1183553 (continued) - Fix applied filters
The filter dialog kept the previous filter around and then joined the
new one with it. This repairs that issue and applies the new filter
options on subsequent loading.
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi> Signed-off-by: Ben Shum <bshum@biblio.org>
Steven Chan [Thu, 23 May 2013 20:24:04 +0000 (13:24 -0700)]
LP1183553 - Default filter option for configuration screens
In the staff client, the AutoGrid widget is used to render configuration
lists, and by default, the setting 'showLoadFilter' is turned off. It
seems more useful to turn it on by default so that any configuration
screen can use it unless its template sets it off.
Signed-off-by: Steven Chan <schan@sitka.bclibraries.ca> Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi> Signed-off-by: Ben Shum <bshum@biblio.org>
Chris Sharp [Mon, 19 Aug 2013 18:29:23 +0000 (14:29 -0400)]
The ILS User reports source branches to an All Hold Requests linked source
that was marked class="circ" instead of class="ahr". This corrects that problem.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Mike Rylander [Tue, 3 Sep 2013 15:45:25 +0000 (11:45 -0400)]
PgTAP tests for 0824
As promised at the August 2013 dev meeting, I'll be adding PgTAP tests
for any database work that I create, and where possible for any that
I commit for others.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Wed, 7 Aug 2013 16:05:30 +0000 (12:05 -0400)]
LP1209291 vandelay item import defaults
Via org settings, support auto-generation of call numbers and barcodes
for items imported via Vandelay's Item Import interface. Support
settings for applying a local prefix string to auto-generated call
numbers and barcodes. For both, the prefix defaults to "VAN".
Similarly, support default copy location and circ modifiers.
The alternate view in the Item Status screen shows a "Total Circs"
field that was under-counting circulations because UNION filtered
out duplicates. This commit replaces UNION with UNION ALL, which
allows duplicate rows.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Sun, 25 Aug 2013 04:41:37 +0000 (00:41 -0400)]
Schema.org authors: relate properties to the right context
While the approach of using the existing <a href> to launch a new search
based on the author name was workable, it may have been confusing for
schema.org processors such as Google Rich Snippets who expected that URI
to identify a resource for the author, not a set of search results.
Using @resource / @about attribute pairing, and wrapping the whole type
in an extra <span> element, enables us to avoid associating the
properties within the <a href> with the implicitly chained type.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Thu, 22 Aug 2013 22:30:34 +0000 (18:30 -0400)]
Schema.org: relate offers to record explicitly
Although schema.org defines the nested child elements as implicit
relationships that should be good enough for the Offer-to-Product
relationship, defining that relationship explicitly can't hurt.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Tue, 20 Aug 2013 16:45:44 +0000 (12:45 -0400)]
Map the bound-with relationship in schema.org
We don't know what type the target record is, so fall back to Product
and just point at it. At least this way schema.org processors will know
that the target bib is related to the current bib.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Sun, 25 Aug 2013 04:40:46 +0000 (00:40 -0400)]
Add structured data for holdings via http://schema.org/Offer
Map library name to Offer/seller, shelving location to
Offer/availableAtOrFrom, call number to Offer/sku, barcode to
Offer/serialNumber, copy status to Offer/availability, and ISBN-13 to
gtin13. Use the additionalType of Product to give these offers an
obvious relationship.
Surface copy counts as AggregateOffer instances.
Cut over to RDFa Lite instead of microdata for schema.org, as RDFa Lite
is more easily extensible with other vocabularies, and is as accepted as
microdata by schema.org processors.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Sun, 25 Aug 2013 04:39:46 +0000 (00:39 -0400)]
Schema.org: improve MusicGroup vs. Person parsing
Take a stricter approach to defining MusicGroups instead of Persons for
the main authors of MusicAlbums. Music groups are generally catalogued
as a 110 or 710 tag, and this avoids defining birthDates and deathDates
for groups (which, however valid that might be in the real world, is not
valid for schema.org).
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Tue, 6 Aug 2013 13:31:11 +0000 (09:31 -0400)]
LP1207396 TPAC org_selector supports org filter
When building and org unit selector via the build_org_selector MARCO,
the caller can now pass in a "valid_org_list" array which contains org
unit IDs. When such a list is provided, any org units in the selector
which are not in the list are marke as disabled.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Thu, 1 Aug 2013 20:52:18 +0000 (16:52 -0400)]
LP1207396 Patron self-registration web form
Web form for allowing patrons to submit thier own library registration
requests. The form collects various bits of user data and creates a
pending user account, which has no privileges. These pending accounts
must be approved and completed by staff from the staff client "Pending
Patrons" action in the Cirulation menu.
Control of whether to show a field, treat a field as required, show
example text, and validate the field format is managed with existing org
unit settings.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Tue, 6 Aug 2013 14:10:19 +0000 (10:10 -0400)]
LP1207396 user stage allows username selection
The caller may now pass a value for username. If unset, it still falls
back to using a uuid. If the username clashes with an existing staged
username, a USERNAME_EXISTS event is returned.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Thu, 1 Aug 2013 17:30:52 +0000 (13:30 -0400)]
LP1207396 DB / IDL for patron self-reg
Updating pending addr tables to track requesting user and address county.
Adding org settings:
* opac.allow_pending_user -- allow self-registration
* opac.pending_user_expire_interval - delete pending user interval
* ui.patron.edit.aua.county.require - indicate if county is required
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Tue, 21 May 2013 15:59:36 +0000 (11:59 -0400)]
LP1182519 Per-Hold Behind Desk Value
The true/false value for behind_desk is now stored directly on the hold
object for more accurate tracking of the location of captured holds.
If configured, patrons can now set their preferred value for behind the
desk holds.
* DB/IDL changes to support the new column
* API support for loading the setting from the patron for cases when no
value is provided by the caller.
* Staff client grid column definition for the Behind Desk field
* Hold counts in the staff client now show total, available, and
behind-desk (at the workstation).
* Printed hold receipt now uses the behind_desk value on the hold to
decide if a hold is behind the desk.
* Release notes
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts:
Mike Rylander [Wed, 14 Aug 2013 14:25:14 +0000 (10:25 -0400)]
Correctly mark nested INNER joins as such
We've been adopting containing the JOINs flavor, and then
attempting to use IS NOT NULL to restrict NULL-ness
in the WHERE clause. This is almost right, but not quite,
and was done in an attempt to match behavior with the
expectations of users that are not SQL experts. However,
right is better than "looks right most of the time", so
we use the proper join type now.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jason Boyer <jboyer1@library.in.gov> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Thu, 23 May 2013 17:30:43 +0000 (13:30 -0400)]
LP1183467 ACQ view funding source list permissions
Limit the set of funding sources visible in the funding source list
interface by those the user has view permissions for, not just those the
user has edit permissions for.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Fri, 12 Jul 2013 18:43:57 +0000 (14:43 -0400)]
Repair remaining Authority Fixed Field editor entries
The "Item" fixed field is only valid for MFHD records, so we remove
that entirely from AUTH records. The "GeoSubd" fixed field is
spelled "GeoDiv" everywhere, so we align that naming so that it can
be saved.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Thu, 11 Jul 2013 17:04:53 +0000 (13:04 -0400)]
Remove JSPAC-oriented PasswordReset.pm interface
A native TPAC interface for resetting passwords arrived some time ago,
and the i18n for PasswordReset.pm predated the more standardized
approach taken by TPAC. So... kill the JSPAC interface and save
ourselves a little bit of Apache overhead in the process.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Acq: Honor new dist forumula fields in old method of applying formulae
The batch updater came with new fields on distribution formulae, but we
didn't teach the pre-existing code for applying formulae from the
lineitem copies interface to apply values from the new fields.
Reported by Jennifer Pringle in Launchpad bug report #1195521.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Wed, 21 Aug 2013 15:57:40 +0000 (11:57 -0400)]
Make C unit tests more robust
Adding -I@abs_top_srcdir@/Open-ILS/include will pull in the source tree
header files, so that the C unit tests can run before Evergreen has been
installed (and thus will be a valid test of the source header files
instead of relying on the installed versions that might be different).
Build c-apps before recursing into c-apps/tests:
This ensures that the required libraries are built before the C unit
tests are built, thus preventing "make check" on a just-configured
source tree from failing due to missing dependencies.
Also, link to the source tree directories first rather than last, to
ensure that we pull in the correct source (if possible). And remove the
cargo-cultish $(TMP) linking/including.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Acq general search: improve searching for negative comparisons
This aims to address Launchpad bug #1031535. I think the bug only
really shows up when searches involve invoices either as the core type
or with filter fields. If a search doesn't involve invoices, the
problematic joins aren't present.
Could use more testing though. Seems to make the problem go away, and
other basic searches seem to work, but I certainly haven't tested
everything.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Scott [Tue, 20 Aug 2013 17:02:23 +0000 (13:02 -0400)]
Fedora: remove source installs for packaged dependencies
The Perl MARC packages, Library::CallNumber::LC, and libdbi / libdbd
drivers have been available as packages on Fedora since Fedora 18 (which
is now the oldest supported Fedora version), so don't install these from
source.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
install soap-lite as a deb before CPAN runs.
Business::OnlinePayment::PayPal fails otherwise.
by default, use apt-get as the APT tool, since all debian distros have
this
move 'install_yaz' directly into Makefile.ubuntu-lucid, since that's
the only OS which uses it.
Squeeze also needs an updated yaz; Yaz-related repairs
give debians and lucid libbz2-dev; precise has it already
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Bill Erickson [Mon, 8 Jul 2013 19:43:57 +0000 (15:43 -0400)]
LP 1190279 Installer makefiles OS targets for PG server
Instead of requesting install_pgsql_server_debs_91,
install_pgsql_server_backport_debs_91, etc. when installing the
postgres server, simply give each OS type its own postgres install
target.
make -f Makefile.install postgres-server-debian-wheezy
make -f Makefile.install postgres-server-debian-squeeze
make -f Makefile.install postgres-server-ubuntu-lucid
make -f Makefile.install postgres-server-ubuntu-precise
make -f Makefile.install postgres-server-fedora
Let the OS module decide what and how to install the postgres server.
Changes are reflected in docs/installation/server_installation.txt
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Adding per-distro makefiles for Ubuntu 10.04 and 12.04.
Correcting minor typo
SimpleServer installation expects yaz to already be installed
Ubuntu 12.04 does not like libparent-perl
Removing librose-uri-perl from the debs list since it is not in the 12.04 repo
Adding libbz2-dev to the deb list
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Create per-distro installer Makefiles for easier maintenance and
per-distro tweaks.
Included in this commit are installer Makefiles for debian wheezy and
squeeze.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Jason Stephenson [Tue, 11 Jun 2013 17:22:33 +0000 (13:22 -0400)]
Fix Lp bug 965656 WRT back dated checkins with fines.
* Move _check_open_xact from OpenILS::Application::Circ::Money
to OpenILS::Application::AppUtils so it can be called from
wherever.
* Modify OpenILS::Application::Circ::Money to use check_open_xact
from OpenILS::Application::AppUtils.
* Modify finish_fines_and_voiding in OpenILS::Application::Circ::Circulate
to use check_open_xact instead of reopen_xact.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm
Dan Scott [Mon, 15 Jul 2013 18:36:30 +0000 (14:36 -0400)]
Improved copy table CSS/markup for conjoined bibs
Let the library name column wrap now that it may potentially contain
stupidly long title/author combos. Also, associate the table cells with
their corresponding headers for improved accessibility.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Mon, 15 Jul 2013 15:28:21 +0000 (11:28 -0400)]
Conjoined items / foreign items display in TPAC
Foreign items now appear at the top of the copy table, no matter what
copy page you are on. See "The two violin concertos" in the Concerto
data set for an example; the foreign bib is linked, with a label for the
designated peer type.
The parent bib record displays all of the child records in the copy table
underneath the pertinent copy; each title / author entry links to the
child bib display, naturally. See "Violin concerto no. 2 ; Six duos
(from 44 Duos)" in the Concerto data set for an example.
We escape all of the text retrieved from the database to avoid XSS
(thanks for the heads-up from Pasi Kallinen).
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Now with HTML escaping for safety
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Ott [Thu, 23 May 2013 00:11:07 +0000 (20:11 -0400)]
Expose conjoined bibs in TPAC
This initial work is based on the GRPL need to handle eReader bib/copy display.
The "joined" titles will display a copy record with a call_number link back to
the "master" bib, where the master will display a set of links to individual
titles from each "copy".
TODO: consider peer_type when determining whether or not to display
Signed-off-by: Bill Ott <bott@grpl.org> Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
There's a bit in the code where it tries to pad the first digit group,
if it's the only digit group, but it assumed the digit group was the
first token.
Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Chris Sharp [Mon, 5 Aug 2013 18:10:56 +0000 (14:10 -0400)]
LP1208572 - Fixes for reporter.classic_item_list
This view was created before the extend_reporter schema and the reporter.
materialized_simple_record existed. Rewriting the view definition to include
those.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Copy location filter selector for the TPAC advanced search interface.
The behavior is the same as the analogous JSPAC feature. The interface
components are hidden by default, so non-JS browsers will be none the
wiser.
A number of small tweaks to related code were needed and are included in
this commit:
1. Make copy locations field_safe in the IDL so they can be retrieved
and parsed without the IDL
2. Insert a (full) hash-based org unit tree as inline JS at the bottom
of js.tt2 so JS will have access to the whole tree without having to
load the IDL to understand it.
3. Fix a bug in openils.CGI : decodeURIComponent parameter names
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Galen Charlton [Fri, 22 Feb 2013 19:00:55 +0000 (14:00 -0500)]
LP#1131889: sort TPac copy list by normalized call number
... as opposed to the literal call number label. E.g., this
patch would make LC call number "AE5 .E363 1975 v.10" sort
after "AE5 .E363 1975 v.9" rather than after "AE5 .E363 1975 v.1"
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Tue, 11 Dec 2012 15:26:30 +0000 (10:26 -0500)]
Improve styling for 'delayed' lineitems in PO UI
When a lineitem is cancelled, but "keep_debits" is true, the lineitem is
in effect delayed instead of truly cancelled. Make it more obvious in
the UI the difference between delayed and truly cancelled lineitems by
applying a row styling for delayed items (similar to other status row
styling) and always show the cancel reason (label) in the lineitem
display in the PO, next to the non-title attributes.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Kyle Tomita [Fri, 31 May 2013 18:33:59 +0000 (11:33 -0700)]
LP1185524 - Duplicate patron checking in the user editor is limited to workstation OU
Added a new library setting opac.duplicate_patron_check_use_consortium.
When true, the duplicate check will use the consortium (1) as the OU.
When false or not set, the duplicate check will use the workstation OU.
The setting is checked in subroutine that creates the search request and
sets the OU accordingly.
[LFW: Signing off but following with material changes next commit.]
Steven Chan [Mon, 5 Aug 2013 16:13:54 +0000 (12:13 -0400)]
Fix LP985075, cannot save Patron Acquisition Request form
The form is shown using a dojo EditPane attached to an EditDialog,
however, attaching the pane was done manually, resulting in the dialog
acting improperly and the pane positioned improperly.
Instead, we use dojo's attr method to define the content attribute of
the dialog to be the pane.
Signed-off-by: Steven Chan <schan@sitka.bclibraries.ca> Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Ben Shum <bshum@biblio.org>
Chris Sharp [Wed, 31 Jul 2013 15:03:25 +0000 (11:03 -0400)]
Fixing LP 1072892 - repeated rows in reporter.classic_item_list view
The view joined the actor.card table in such a way that all library
cards (active or not) were being returned. This commit changes that
behavior so that only the current card (from actor.usr.card) is returned.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Middle-layer support for the org unit setting "Leave transaction
open when long overdue balance equals zero". It behaves the same
as "Leave transaction open when lost balance equals zero", but for
long-overdue circs.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
projects / working / Evergreen.git / log