webstaff: improve performance of open-ils.search.authority.simple_heading.from_xml
Searching authority.record_entry by comparing are.simple_heading
with the results of authority.simple_normalize_heading() can result
in bad query plans; if we calculate the results of that function
first, we have a much better chance of hitting the index on
simple_heading.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Mon, 31 Aug 2015 22:09:01 +0000 (22:09 +0000)]
webstaff: start work on authority linker modal
When a bib record is opened in the MARC editor, fields that
can be put under authority control now have a link button at
the end of the subfield list. When clicked, this opens
a dialog box that, for now, allows:
* creating a new authority record based on the bib heading
* creating a new authority record and launching a secondary
MARC editor.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Fri, 28 Aug 2015 21:18:04 +0000 (21:18 +0000)]
LP#1489955: enable filtering authority search/browse by thesaurus
This patch adds support for restricting the scope of an
authority headings browse or authority record search by
thesaurus. For example, in SuperCat, the URL pattern
Galen Charlton [Fri, 28 Aug 2015 00:45:23 +0000 (00:45 +0000)]
webstaff: add support for editing authority records
This adds basic support for invoking the MARC editor on
authority records, and fixes a couple bugs discovered
along the way. The route currently supported is
/cat/catalog/authority/:authority_id/marc_edit
In the future, some sort of summary view of an authority
record might be added, in which case the route
"/cat/catalog/authority/:authority_id" is available.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Thu, 27 Aug 2015 22:23:23 +0000 (22:23 +0000)]
webstaff: add routine for Dojo JS to detect if running in iframe
Sometimes legacy Dojo interfaces may need to adjust their
behavior if they're embedded in the web staff client. This patch
adds a new utility function, openils.Util.inIFrame(), to detect
if such code is running in an iframe. If so, the presumption
is that iframe belongs to the web staff client.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
This commit removes the references in the docs to the now removed JSPAC,
and replaces all known remaining JSPAC screenshots, and when required
updates the descriptions to match TPAC features. It also fixes AsciiDoc
ordered list syntax in a few cases, which interfered with testing.
Michael Peters [Thu, 4 Dec 2014 20:56:53 +0000 (15:56 -0500)]
LP#1361266 Patron self-registration form accepts date of birth in wrong format
This patch applys some basic javascript to validate that a date entered is
at least in ISO 8601 format. This prevents someone from entering "cupcake"
or 55/66/6666 as a valid date of birth by validating the stgu.dob input
at the time of submission.
Signed-off-by: Michael Peters <mpeters@emeralddata.net> Signed-off-by: Josh Stompro <stomproj@larl.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
If no search parameters or invalid search parameters are sent to the
patron search API, the API call exits early with zero results. This
avoids cases where empty searches can lead to heavy DB calls, querying
and sorting he entire patron data set.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
The fix for LP 1484281 broke the 0847.auth_overlay_generator.pg live
test. Since e was removed from the controlled subfield list for the
100 authority tag, it needs to be removed from the expected live test
results.
This commit does that.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Yamil Suarez [Mon, 17 Aug 2015 20:47:34 +0000 (16:47 -0400)]
LP# 1484281 auth control config update to prevent propagated data deletion
Remove subfield 'e' from authority.control_set_authority_field seed values
Removed from the auth tag 100 and 110, which should apply to bib tags
100,110,600,610,700,710
Added upgrade script, and pgTAP test.
How to test this patch
----------------------
[1] To test this bug you need 1 authority record and at least 1 bib record.
The auth record needs to have an auth 100 or 110 tag that has a subfield $e,
for example 100 $aDavis, Miles $ecomposer. (for the record, it is not good
cataloging practice to have $e in the auth record, but it can happen by mistake.)
The bib record needs to be have a matching bib 100 or 700 tag with the same
subfield $a and $e. In addition the matching bib tag has to be linked to the
authority record, i.e. the bib tag has to have a bib subfield $0 with the DB
id of the authority record.
[2] If you open up the authority record, in the authority MARC editor, and remove
the subfield $e; the subfield $e found in the bib record tag will be removed.
This is a mistake because normally bib record tags 100/110/700/710 do use subfield
$e, though the subfield $e should not be used in the auth record 100/110 tags.
[3] When this patch is applied, if a cataloger removes a subfield $e from an auth
100/110 tag, the deletion will not cascade to its linked bibs.
Signed-off-by: Yamil Suarez <yamil@yamil.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Thu, 20 Aug 2015 17:32:28 +0000 (17:32 +0000)]
LP#1487143: remove legacy_script_support from example SIP config
This patch removes the legacy_script_support option (and the
related references to the scripts themselves) from the example
SIPServer config, as they now have no effect.
Existing Evergreen sites can choose to remove those configuraiton
options or leave them in.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Wells [Fri, 14 Aug 2015 19:11:16 +0000 (15:11 -0400)]
LP#1484989 Don't close xacts with checkin-generated fines
If a transaction has checkin-generated fines, and previously had a
balance of zero, the rearranged billing code was prematurely closing
the transaction. This commit separates the closing step to run after
any possible fine generation.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Ben Shum [Wed, 19 Aug 2015 22:11:18 +0000 (18:11 -0400)]
LP#1484650: Missing webstaff2pot make target for newpot
Seems that something went awry with the commit I submitted for pullrequest
and we missed the actual change to make the webstaff client file for
translation.
Dan Pearl [Wed, 14 Nov 2012 17:14:11 +0000 (12:14 -0500)]
LP# 1086934 - TPAC: Complete column sorting in some screens
(specifically holds, circs, and circs_history)
An earlier LP issue #1010277 concerned the halfway implementation of
the column sort facility, and was addressed at the time by ripping out any hint of
column sort capability, among other cleanup issues.
The sorting capability has now been implemented with the following functionality:
* Clicking on the appropriate column heads now sorts the contents from
"ascending" to "descending" to "no sort". (The "no sort" will restore the
original list as presented to the patron.)
* The sort indicator (an up or down arrow) is placed to the right
of the column head, as appropriate.
* The combined "Title/Author" column in the circ screens is now separated into two
independently sortable columns (Title and Author).
* Title sorting is done with the 'filing' characters (leading "the", "a",
"an", and other langugage equivalents) removed. To clarify the
behavior for the patron, the leading articles are rendered in
a smaller font, so as to keep the main entry prominent. In
addition to the filing characters removed for the sort, leading
non-alphanumeric characters are ignored in the sort.
This commit only affects those screens and columns that suggested column sorting
capability.
Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/templates/opac/parts/topnav.tt2
projects / working / Evergreen.git / log