working/Evergreen.git
11 years agoprevent negative paging display offset. added paginator to event def grids
erickson [Wed, 9 Sep 2009 13:16:52 +0000 (13:16 +0000)]
prevent negative paging display offset.  added paginator to event def grids

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13985 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoturn off array expansion in DBD::Pg (new feature)
miker [Tue, 8 Sep 2009 15:14:45 +0000 (15:14 +0000)]
turn off array expansion in DBD::Pg (new feature)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13983 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agothe Perl UUID module is not easily installed nor does it appear to be maintained...
erickson [Fri, 4 Sep 2009 21:21:40 +0000 (21:21 +0000)]
the Perl UUID module is not easily installed nor does it appear to be maintained.  use UUID::Tiny instead

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13982 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agothere's no valid reason to call ingest from within the bib create/overlay code before...
erickson [Fri, 4 Sep 2009 20:50:14 +0000 (20:50 +0000)]
there's no valid reason to call ingest from within the bib create/overlay code before the changes have been committed.  removed embedded ingest logic and the no-ingest flags passed by everyone that uses them

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13980 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agocapture override as a var because using =~ in an arg list is non-good
erickson [Fri, 4 Sep 2009 20:42:18 +0000 (20:42 +0000)]
capture override as a var because using =~ in an arg list is non-good

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13974 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoon marc record import, call ingest after the create xact has been committed
erickson [Fri, 4 Sep 2009 20:17:14 +0000 (20:17 +0000)]
on marc record import, call ingest after the create xact has been committed

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13968 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoplug baseWidgetValue setting for readOnly widgets back in with try/catch and comment...
erickson [Fri, 4 Sep 2009 19:58:21 +0000 (19:58 +0000)]
plug baseWidgetValue setting for readOnly widgets back in with try/catch and comment.  typo: state -> state()

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13966 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agotighter control over displaying mark-recived and update-barcodes links in lineitem...
erickson [Fri, 4 Sep 2009 19:26:08 +0000 (19:26 +0000)]
tighter control over displaying mark-recived and update-barcodes links in lineitem table.  showing lineitem and PO state in the UI.  Added PO activate routine which effectively marks a PO as 'ready to send to vendor'

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13964 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoLoosened constraint on group penalty thresholds. You can now define threholds for...
erickson [Fri, 4 Sep 2009 17:25:10 +0000 (17:25 +0000)]
Loosened constraint on group penalty thresholds.  You can now define threholds for the same group as long as they have a different context org unit

To Update:

ALTER TABLE permission.grp_penalty_threshold DROP CONSTRAINT penalty_grp_once;
ALTER TABLE permission.grp_penalty_threshold ADD CONSTRAINT penalty_grp_once UNIQUE (grp,penalty,org_unit);

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13961 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoexpose PO ID and PO name. plugged in option to change the PO name
erickson [Fri, 4 Sep 2009 15:23:54 +0000 (15:23 +0000)]
expose PO ID and PO name.  plugged in option to change the PO name

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13959 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoassume 'yes' to fetching dependencies; reduce the verbosity of package downloads
erickson [Fri, 4 Sep 2009 13:22:42 +0000 (13:22 +0000)]
assume 'yes' to fetching dependencies; reduce the verbosity of package downloads

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13958 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agodon't allow cut from or paste into readonly textboxes
phasefx [Thu, 3 Sep 2009 08:50:22 +0000 (08:50 +0000)]
don't allow cut from or paste into readonly textboxes

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13957 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoremote xul textboxes need context="clipboard" for proper cut/paste context menus
phasefx [Thu, 3 Sep 2009 08:39:45 +0000 (08:39 +0000)]
remote xul textboxes need context="clipboard" for proper cut/paste context menus

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13956 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoallow us to switch to the alt item status view even with no items selected or scanned...
phasefx [Thu, 3 Sep 2009 08:31:47 +0000 (08:31 +0000)]
allow us to switch to the alt item status view even with no items selected or scanned.  Put focus in scanbox after toggle.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13955 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAlternate Item Status View
phasefx [Thu, 3 Sep 2009 08:24:36 +0000 (08:24 +0000)]
Alternate Item Status View

This is a work in process and I expect a lot of churn; I promise to I18N-ize it before it leaves trunk.  Some stuff like Rolling Counter is more mock-up than anything; I have no idea what a Rolling Counter is.  :D

The main notion here is that we want a quick toggle in Item Status for a denser view of information for a single item.  Something less like the current Actions -> Show Item Details and more like the MARC View button in the Z39.50
interface.  Note, you can scan in new barcodes while remaining in this view.   In general, I want to move away from pop-up dialogs and interfaces in any case, and this sort of deck swapping is probably the future.

Feedback welcome.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13954 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoReplacing persist mechanism with oils_persist.
phasefx [Thu, 3 Sep 2009 04:14:48 +0000 (04:14 +0000)]
Replacing persist mechanism with oils_persist.

This changeset isn't as scary as it looks, I promise. :-)

In XUL you can say,   <element attribute1="foo" attribute2="bar" persist="attribute1 attribute2" />
and whenever those specified attributes change, the new values will be remembered the next time that element is loaded.

Problems with persist:
  * No longer works with remote XUL in Xulrunner 1.9 series, only chrome.  Mozilla did this for security reasons.
  * Persist was tied to the window.location of each interface, so:
    1) Settings would be lost on any "upgrade" that effectively changed the URL.  For example, /xul/rel_1_2/server/ versus /xul/rel_1_4/server/
    2) Some interfaces still make use of URL params, which effectively breaks persistance (because the URL changes constantly), and allows localstore.rdf to grow without limit (thanks to Jeff for noticing that last bit)

The solution:
  * We renamed all occurances of @persist to @oils_persist, in case Mozilla changes the behavior again.
  * We created a persist_helper() function and call it alongside font_helper() in the @onload for most windows (all that currently have elements using @oils_persist, at least)

persist_helper grabs all elements that have an @oils_persist, and constructs look-up keys based on the location.hostname, location.path, and element.id, and uses the Mozilla preference system to look for preferences with those
keys.  These keys don't include URL parameters.  For <checkbox> elements, an event listener is added that will set the preference whenever the element fires a command event (is checked or unchecked).

TODO:
  * Tweak the keys further so that they're BUILD_ID (version) agnostic
  * Add more event listeners to accomodate @oils_persist on other elements like window, splitter, and grippy.
  * Possibly remove persist_helper (and font_helper) from the inline @onload, and load it through a window.addEventListener('load',function(){ persist_helper(); },false); in the global util overlay instead.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13953 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agojust another test.. want to see if multiple commits with git-svn come across as multi...
phasefx [Thu, 3 Sep 2009 03:00:39 +0000 (03:00 +0000)]
just another test.. want to see if multiple commits with git-svn come across as multiple changesets when going back to svn later

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13952 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agojust a test
phasefx [Thu, 3 Sep 2009 03:00:37 +0000 (03:00 +0000)]
just a test

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13951 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoleave the accesskey blank for this. R gets grabbed by the top-level search menu...
phasefx [Wed, 2 Sep 2009 14:08:03 +0000 (14:08 +0000)]
leave the accesskey blank for this.  R gets grabbed by the top-level search menu, so no need to advertise an accesskey that doesn't work

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13950 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoSimple in-client "activity log" interface (Admin -> Local Administration -> Work...
phasefx [Wed, 2 Sep 2009 13:39:27 +0000 (13:39 +0000)]
Simple in-client "activity log" interface (Admin -> Local Administration -> Work Log), and an example of such logging in the Checkout interface.

The log function itself is part of util/error.js.  Example:

JSAN.use('util.error'); var logger = new util.error();

logger.work_log(

"Staff member Foo circulated item Bar to patron Baz",  // The log message

// Additional Row data to pass to a util.list construct in the work log interface, which can be used in rendering columns, and accessed by actions acting on the list
{
au_id : 1,  // Id for patron Baz; needed if you want the Retrieve Patron action to work with this log entry
acp_barcode : 'Bar', // Barcode of the item; needed if you want the Retrieve Item action to work with this log entry
}
);

TODO:

  * Add logging statements to the Check In interface (complication there is that we don't have patron data, which would be useful) and Patron Registration
  * Possibly add explicit columns for the type of action, the item involved, the patron involved, and the staff involved (to compliment Operator Change), rather than just Message and When.
  * Add filtering support for action types

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13949 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agobypass hold fulfillment attempt when checking out pre/non cat items
erickson [Wed, 2 Sep 2009 12:53:56 +0000 (12:53 +0000)]
bypass hold fulfillment attempt when checking out pre/non cat items

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13948 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agocapture the session handle before calling wait_complete
erickson [Wed, 2 Sep 2009 12:41:21 +0000 (12:41 +0000)]
capture the session handle before calling wait_complete

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13947 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agouse a separate pcrud instance for each object deletion so that a single instances...
erickson [Tue, 1 Sep 2009 20:54:29 +0000 (20:54 +0000)]
use a separate pcrud instance for each object deletion so that a single instances isn't trying to create transactions while it's already in the middle of transactions, pending async responses.  added some docs

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13945 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoreturn the status of xact_commit from the commit wrapper
erickson [Tue, 1 Sep 2009 20:34:20 +0000 (20:34 +0000)]
return the status of xact_commit from the commit wrapper

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13944 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadded ability to clone event_def environment when an event_def is cloned
erickson [Tue, 1 Sep 2009 18:40:37 +0000 (18:40 +0000)]
added ability to clone event_def environment when an event_def is cloned

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13941 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agopass the clone object to the postsubmit handler. allow caller to specificy post...
erickson [Tue, 1 Sep 2009 18:39:42 +0000 (18:39 +0000)]
pass the clone object to the postsubmit handler.  allow caller to specificy post-clone handler. added some docs

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13940 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agocalling widget.attr on readonly objects occaisonally results in errors from (as yet...
erickson [Tue, 1 Sep 2009 14:18:52 +0000 (14:18 +0000)]
calling widget.attr on readonly objects occaisonally results in errors from (as yet unexplained) dojo race condition.  however, basewidgetvalue is not needed for readOnly widgets, since displaystring is used, so bypasss for now;  use dojo.create

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13938 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agobury the old Local Admin interface, but don't remove it altogether yet
phasefx [Tue, 1 Sep 2009 05:13:24 +0000 (05:13 +0000)]
bury the old Local Admin interface, but don't remove it altogether yet

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13937 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agopass the ID not the bib object to the reporter.simple_rec_update stored proc
erickson [Fri, 28 Aug 2009 22:01:42 +0000 (22:01 +0000)]
pass the ID not the bib object to the reporter.simple_rec_update stored proc

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13934 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadd the tsearch2 config tables for pg 8.1 and 8.2
miker [Fri, 28 Aug 2009 15:51:52 +0000 (15:51 +0000)]
add the tsearch2 config tables for pg 8.1 and 8.2

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13933 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoCreate tables acq.fiscal_calendar and acq.fiscal_year.
scottmk [Thu, 27 Aug 2009 12:51:09 +0000 (12:51 +0000)]
Create tables acq.fiscal_calendar and acq.fiscal_year.

Create function acq.find_bad_fy to perform sanity checks
on acq.fiscal_year.

To add to an existing database:

CREATE TABLE acq.fiscal_calendar (
id              SERIAL         PRIMARY KEY,
name            TEXT           NOT NULL
);

CREATE TABLE acq.fiscal_year (
id              SERIAL         PRIMARY KEY,
calendar        INT            NOT NULL
                               REFERENCES acq.fiscal_calendar
                               ON DELETE CASCADE
                               DEFERRABLE INITIALLY DEFERRED,
year            INT            NOT NULL,
year_begin      TIMESTAMPTZ    NOT NULL,
year_end        TIMESTAMPTZ    NOT NULL,
CONSTRAINT acq_fy_logical_key  UNIQUE ( calendar, year ),
    CONSTRAINT acq_fy_physical_key UNIQUE ( calendar, year_begin )
);

CREATE OR REPLACE FUNCTION acq.find_bad_fy()
/*
Examine the acq.fiscal_year table, comparing successive years.
Report any inconsistencies, i.e. years that overlap or have
gaps between them.
*/
RETURNS SETOF RECORD AS $$
DECLARE
first_row  BOOLEAN;
curr_year  RECORD;
prev_year  RECORD;
return_rec RECORD;
BEGIN
first_row := true;
FOR curr_year in
SELECT
id,
calendar,
year,
year_begin,
year_end
FROM
acq.fiscal_year
ORDER BY
calendar,
year_begin
LOOP
--
IF first_row THEN
first_row := FALSE;
ELSIF curr_year.calendar    = prev_year.calendar THEN
IF curr_year.year_begin > prev_year.year_end THEN
-- This ugly kludge works around the fact that older
-- versions of PostgreSQL don't support RETURN QUERY SELECT
FOR return_rec IN SELECT
prev_year.id,
prev_year.year,
'Gap between fiscal years'::TEXT
LOOP
RETURN NEXT return_rec;
END LOOP;
ELSIF curr_year.year_begin < prev_year.year_end THEN
FOR return_rec IN SELECT
prev_year.id,
prev_year.year,
'Overlapping fiscal years'::TEXT
LOOP
RETURN NEXT return_rec;
END LOOP;
ELSIF curr_year.year < prev_year.year THEN
FOR return_rec IN SELECT
prev_year.id,
prev_year.year,
'Fiscal years out of order'::TEXT
LOOP
RETURN NEXT return_rec;
END LOOP;
END IF;
END IF;
--
prev_year := curr_year;
END LOOP;
--
RETURN;
END;
$$ LANGUAGE plpgsql;

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13931 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agomisnamed dojo tab
erickson [Mon, 24 Aug 2009 21:52:06 +0000 (21:52 +0000)]
misnamed dojo tab

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13928 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoChange constraint on acq.provider. Instead of making code unique
scottmk [Mon, 24 Aug 2009 17:49:26 +0000 (17:49 +0000)]
Change constraint on acq.provider.  Instead of making code unique
by itself, make code + owner unique.

To change an existing table:

ALTER TABLE acq.provider
DROP CONSTRAINT provider_code_key;

ALTER TABLE acq.provider
ALTER COLUMN code SET NOT NULL;

ALTER TABLE acq.provider
ADD CONSTRAINT code_once_per_owner
UNIQUE (code, owner);

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13926 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAdd columns to acq.purchase_order: order_date and name.
scottmk [Mon, 24 Aug 2009 16:14:36 +0000 (16:14 +0000)]
Add columns to acq.purchase_order: order_date and name.

Name defaults to the id, as text.

Name should be unique for a given ordering_agency and order
date (truncated to midnight), but only where order_date
is not null.

To change an existing table, run the following
through psql:

-- Add new columns; populate name

ALTER TABLE acq.purchase_order
ADD COLUMN order_date TIMESTAMP WITH TIME ZONE;

ALTER TABLE acq.purchase_order
ADD COLUMN name TEXT;

UPDATE acq.purchase_order
SET name = id::TEXT;

ALTER TABLE acq.purchase_order
ALTER COLUMN name SET NOT NULL;

-- Name should default to the id.  We can't do that with a DEFAULT
-- clause but we can do it with a trigger.

CREATE OR REPLACE FUNCTION acq.purchase_order_name_default () RETURNS TRIGGER
AS $$
BEGIN
IF NEW.name IS NULL THEN
NEW.name := NEW.id::TEXT;
END IF;

RETURN NEW;
END;
$$ LANGUAGE PLPGSQL;

CREATE TRIGGER po_name_default_trg
  BEFORE INSERT OR UPDATE ON acq.purchase_order
  FOR EACH ROW EXECUTE PROCEDURE acq.purchase_order_name_default ();

-- Name should be unique for a given ordering_agency and day, where
-- order_date is not null.  We can't do that with a check constraint
-- because it would require a subquery, so we use a trigger.

CREATE INDEX acq_po_org_name_order_date_idx
ON acq.purchase_order( ordering_agency, name, order_date );

CREATE OR REPLACE FUNCTION acq.po_org_name_date_unique () RETURNS TRIGGER
AS $$
DECLARE
collision INT;
BEGIN
--
-- If order_date is not null, then make sure we don't have a collision
-- on order_date (truncated to day), org, and name
--
IF NEW.order_date IS NULL THEN
RETURN NEW;
END IF;
--
-- In the WHERE clause, we compare the order_dates without regard to time of day.
-- We use a pair of inequalities instead of comparing truncated dates so that the
-- query can do an indexed range scan.
--
SELECT 1 INTO collision
FROM acq.purchase_order
WHERE
ordering_agency = NEW.ordering_agency
AND name = NEW.name
AND order_date >= date_trunc( 'day', NEW.order_date )
AND order_date <  date_trunc( 'day', NEW.order_date ) + '1 day'::INTERVAL
AND id <> NEW.id;
--
IF collision IS NULL THEN
-- okay, no collision
RETURN NEW;
ELSE
-- collision; nip it in the bud
RAISE EXCEPTION 'Colliding purchase orders: ordering_agency %, date %, name ''%''',
NEW.ordering_agency, NEW.order_date, NEW.name;
END IF;
END;
$$ LANGUAGE PLPGSQL;

CREATE TRIGGER po_org_name_date_unique_trg
  BEFORE INSERT OR UPDATE ON acq.purchase_order
  FOR EACH ROW EXECUTE PROCEDURE acq.po_org_name_date_unique ();

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13924 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agofire the fine generator at checkin time to assess required fines without a "missing...
miker [Mon, 24 Aug 2009 15:23:49 +0000 (15:23 +0000)]
fire the fine generator at checkin time to assess required fines without a "missing fine" window

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13923 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadjusting indentation for readability
miker [Mon, 24 Aug 2009 14:38:46 +0000 (14:38 +0000)]
adjusting indentation for readability

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13921 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoin checkin interface, keep a running tally of fines/bills encountered
phasefx [Mon, 24 Aug 2009 03:04:23 +0000 (03:04 +0000)]
in checkin interface, keep a running tally of fines/bills encountered

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13920 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agotypo, reporter.reporter.
erickson [Fri, 21 Aug 2009 18:33:36 +0000 (18:33 +0000)]
typo,  reporter.reporter.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13915 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agomore work on pcrud filter dialog. added filter option to autogrid. repaired faulty...
erickson [Fri, 21 Aug 2009 15:33:02 +0000 (15:33 +0000)]
more work on pcrud filter dialog.  added filter option to autogrid.  repaired faulty linked object caching in autogrid.  with caching repaired, made linked grid cell data fetching synchronous to prevent excessive network requests (1st instance of an object is cached)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13913 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoChange uniqueness constraint on acq.fund.code so as to
scottmk [Fri, 21 Aug 2009 12:38:47 +0000 (12:38 +0000)]
Change uniqueness constraint on acq.fund.code so as to
include org and year

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13912 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agobeginnings of database replication helper scripts
miker [Fri, 21 Aug 2009 05:14:25 +0000 (05:14 +0000)]
beginnings of database replication helper scripts

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13911 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoset hold.shelf_time when item hits the shelf. updated hold notify event def to use...
erickson [Thu, 20 Aug 2009 20:49:11 +0000 (20:49 +0000)]
set hold.shelf_time when item hits the shelf.  updated hold notify event def to use shelf_time as the delay field

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13907 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAnother typo [sigh...]
scottmk [Thu, 20 Aug 2009 20:13:12 +0000 (20:13 +0000)]
Another typo [sigh...]

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13906 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoCorrecting a typo...
scottmk [Thu, 20 Aug 2009 19:08:19 +0000 (19:08 +0000)]
Correcting a typo...

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13905 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoNew column: action.hold_request.shelf_time
scottmk [Thu, 20 Aug 2009 19:04:18 +0000 (19:04 +0000)]
New column: action.hold_request.shelf_time

For altering an existing table:

ALTER TABLE action.hold_request
ADD COLUMN shelf_time TIMESTAMP WITH TIME ZONE;

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13904 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agobeginning of a filter dialog for pcrud requests. users select columns and values...
erickson [Thu, 20 Aug 2009 16:04:35 +0000 (16:04 +0000)]
beginning of a filter dialog for pcrud requests.  users select columns and values from autofieldwidgets.  the eventual goal is to provide filter options for autogrid

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13903 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agothinko in recent ingest fix
miker [Thu, 20 Aug 2009 15:34:25 +0000 (15:34 +0000)]
thinko in recent ingest fix

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13897 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agomoving the simple-rec synchronization out of the DB for insert/update, and as a new...
miker [Thu, 20 Aug 2009 15:00:46 +0000 (15:00 +0000)]
moving the simple-rec synchronization out of the DB for insert/update, and as a new trigger for "delete".  This should finally address the ingest issues seen at some sites through the 1.4 series

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13894 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoFix a horrible regression when renewing multiple items at once in Items Out.
phasefx [Thu, 20 Aug 2009 08:01:42 +0000 (08:01 +0000)]
Fix a horrible regression when renewing multiple items at once in Items Out.

Referencing loop variables in Javascript with closures is dangerous, so one strategy is to do something like this:

funcs = [];
for (var i = 0; i < my_array.length; i++ ) {

/* Bad */
// funcs.push( function(){ do_something( my_array[i] ); } );
/* Better */
funcs.push( function(safe_value){ return function(){ do_something( safe_value ); } }( my_array[i] ) );
}

In our case, our generated function accidentally referenced a value dependent on the loop variable instead of the corresponding argument of the function generator.

So we had multiple async renewal calls that depending on the timing, could try to renew the same item.  To further add insult to injury, this could potentially put the database in an inconsistent
state wtih duplicate circulations.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13889 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoif the requested hook does not exist, gracefully back out
erickson [Wed, 19 Aug 2009 15:58:51 +0000 (15:58 +0000)]
if the requested hook does not exist, gracefully back out

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13883 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadd lib shortname to overdue script xml output
erickson [Wed, 19 Aug 2009 14:10:52 +0000 (14:10 +0000)]
add lib shortname to overdue script xml output

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13879 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agouse the appropriate label for show hold details in the context menu for the patron...
phasefx [Wed, 19 Aug 2009 03:09:17 +0000 (03:09 +0000)]
use the appropriate label for show hold details in the context menu for the patron holds interface

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13874 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoHave the Place Hold function in the Patron Holds interface update said interface...
phasefx [Wed, 19 Aug 2009 03:07:41 +0000 (03:07 +0000)]
Have the Place Hold function in the Patron Holds interface update said interface upon successful hold placement.
Also, rework how the Patron Holds interface encourages the summary sidebar (and the label under the Holds button) to refresh itself with regard to holds.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13873 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agofield_type may be null, check it
erickson [Tue, 18 Aug 2009 18:57:12 +0000 (18:57 +0000)]
field_type may be null, check it

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13872 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoupdated hold queue position code to consider all hold types that share a common poten...
erickson [Tue, 18 Aug 2009 17:45:49 +0000 (17:45 +0000)]
updated hold queue position code to consider all hold types that share a common potential copy

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13871 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agodon't call ->content if there is no response
erickson [Tue, 18 Aug 2009 17:44:22 +0000 (17:44 +0000)]
don't call ->content if there is no response

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13868 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agomiscommunication on logic. if user != requestor, it's a staff hold
erickson [Tue, 18 Aug 2009 15:48:39 +0000 (15:48 +0000)]
miscommunication on logic.  if user != requestor, it's a staff hold

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13867 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAdded strings for staff hold column
lmcfarland [Tue, 18 Aug 2009 15:32:17 +0000 (15:32 +0000)]
Added strings for staff hold column

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13866 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAdded staff hold column to holds table
lmcfarland [Tue, 18 Aug 2009 14:41:05 +0000 (14:41 +0000)]
Added staff hold column to holds table

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13865 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoalternate (and functional) clipboard context menus for fixed fields
phasefx [Tue, 18 Aug 2009 06:08:27 +0000 (06:08 +0000)]
alternate (and functional) clipboard context menus for fixed fields

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13862 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agofixed regression with default search field not being refocused after using the Clear...
phasefx [Tue, 18 Aug 2009 05:32:37 +0000 (05:32 +0000)]
fixed regression with default search field not being refocused after using the Clear Form button.  Also have the default field come into focus when the whole tab leaves focus and is later revisited.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13857 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoturned on paging for po list. set up the state filter differently so that the browse...
erickson [Mon, 17 Aug 2009 20:09:47 +0000 (20:09 +0000)]
turned on paging for po list.  set up the state filter differently so that the browser won't choose a default value.  no longer showing and fleshing the owner column since it was causing the render flickering... will reassess later.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13854 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoset page title
erickson [Mon, 17 Aug 2009 20:08:27 +0000 (20:08 +0000)]
set page title

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13853 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoremoved dupe debs (wrt osrf Makefile.install)
sboyette [Mon, 17 Aug 2009 18:32:58 +0000 (18:32 +0000)]
removed dupe debs (wrt osrf Makefile.install)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13852 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agochanged menu label from Hold Notice to Hold Details--Hold Notices functionality is...
lmcfarland [Mon, 17 Aug 2009 17:14:01 +0000 (17:14 +0000)]
changed menu label from Hold Notice to Hold Details--Hold Notices functionality is now in the Hold Details UI

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13851 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadded hold_details to the URLS, removed hold_notices
lmcfarland [Mon, 17 Aug 2009 17:03:32 +0000 (17:03 +0000)]
added hold_details to the URLS, removed hold_notices

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13850 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agousing new fund year list to populate year selector
erickson [Mon, 17 Aug 2009 16:14:51 +0000 (16:14 +0000)]
using new fund year list to populate year selector

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13848 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadded optional list of fields whose linked display value should not be fetched
erickson [Mon, 17 Aug 2009 16:12:49 +0000 (16:12 +0000)]
added optional list of fields whose linked display value should not be fetched

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13847 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadded companion api call to fund list retrieval which returns unique set of fund...
erickson [Mon, 17 Aug 2009 16:12:06 +0000 (16:12 +0000)]
added companion api call to fund list retrieval which returns unique set of fund years based on the provided query

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13846 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadd "distinct" support to fielder
miker [Mon, 17 Aug 2009 14:30:01 +0000 (14:30 +0000)]
add "distinct" support to fielder

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13845 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadded support to autogrid for loading paged data via callback for UIs that load their...
erickson [Sun, 16 Aug 2009 15:49:12 +0000 (15:49 +0000)]
added support to autogrid for loading paged data via callback for UIs that load their own data.  added paging to fund list page.  added paging options to fund by org fetcher

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13843 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadding proper attributes to uncontrolled subfield value textboxes to allow the defaul...
miker [Fri, 14 Aug 2009 15:39:05 +0000 (15:39 +0000)]
adding proper attributes to uncontrolled subfield value textboxes to allow the default-ish context menus to work properly

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13842 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agocode clean up--removed some leftover testing strings
lmcfarland [Fri, 14 Aug 2009 15:12:44 +0000 (15:12 +0000)]
code clean up--removed some leftover testing strings

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13841 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoshow hold notices menu is now a hold details interface, soon to encompass all hold...
lmcfarland [Fri, 14 Aug 2009 15:06:26 +0000 (15:06 +0000)]
show hold notices menu is now a hold details interface, soon to encompass all hold actions and details--added hold note functionality to this new/refactored UI

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13840 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoswapped commandset from holds.xul to holds_overlay.xul and the commandset call from...
lmcfarland [Fri, 14 Aug 2009 14:49:24 +0000 (14:49 +0000)]
swapped commandset from holds.xul to holds_overlay.xul and the commandset call from holds_overlay.xul to holds.xul

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13839 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agocreated new column in Holds interface for number of hold notes per hold
lmcfarland [Fri, 14 Aug 2009 14:16:30 +0000 (14:16 +0000)]
created new column in Holds interface for number of hold notes per hold

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13838 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoaccess circulation tables directly instead of through the all_circulation view to...
miker [Fri, 14 Aug 2009 03:11:51 +0000 (03:11 +0000)]
access circulation tables directly instead of through the all_circulation view to avoid pathological query plans

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13837 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agofixed some bugs in creating new picklists by name
erickson [Thu, 13 Aug 2009 21:09:25 +0000 (21:09 +0000)]
fixed some bugs in creating new picklists by name

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13834 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoturn on pagination in the provider list page
erickson [Thu, 13 Aug 2009 21:08:55 +0000 (21:08 +0000)]
turn on pagination in the provider list page

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13833 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoinitial pagination support. when enabled, back/prev links appear in a small nav...
erickson [Thu, 13 Aug 2009 21:08:22 +0000 (21:08 +0000)]
initial pagination support.  when enabled, back/prev links appear in a small nav pane just above the grid

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13832 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadded support for limit/offset to pcrud search and retrieveall calls
erickson [Thu, 13 Aug 2009 21:07:02 +0000 (21:07 +0000)]
added support for limit/offset to pcrud search and retrieveall calls

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13831 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoremoving old provider list code
erickson [Thu, 13 Aug 2009 21:06:33 +0000 (21:06 +0000)]
removing old provider list code

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13830 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoaaaaand the osrf perl preqs
sboyette [Thu, 13 Aug 2009 18:30:59 +0000 (18:30 +0000)]
aaaaand the osrf perl preqs

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13829 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agono apxs; no memcache, ncurses, or readline headers either
sboyette [Thu, 13 Aug 2009 18:09:54 +0000 (18:09 +0000)]
no apxs; no memcache, ncurses, or readline headers either

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13828 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoalso won't find apache2.2-common or liblog-log4perl-perl in a base install of debian
sboyette [Thu, 13 Aug 2009 17:39:16 +0000 (17:39 +0000)]
also won't find apache2.2-common or liblog-log4perl-perl in a base install of debian

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13827 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadding XML::Simple and XML::LibXML to debs list
sboyette [Thu, 13 Aug 2009 17:39:16 +0000 (17:39 +0000)]
adding XML::Simple and XML::LibXML to debs list

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13826 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agonevermind that last change
sboyette [Thu, 13 Aug 2009 17:39:15 +0000 (17:39 +0000)]
nevermind that last change

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13825 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadd Module::Install to the Debian/Ubuntu, Centos, and Gentoo installs
sboyette [Thu, 13 Aug 2009 17:39:14 +0000 (17:39 +0000)]
add Module::Install to the Debian/Ubuntu, Centos, and Gentoo installs

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13824 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agowhen a new hold is placed, tell the containing staff client about it
erickson [Thu, 13 Aug 2009 16:42:06 +0000 (16:42 +0000)]
when a new hold is placed, tell the containing staff client about it

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13823 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agocreate-hold call now only accepts a single hold arg. that's how it was being used...
erickson [Thu, 13 Aug 2009 16:37:45 +0000 (16:37 +0000)]
create-hold call now only accepts a single hold arg.  that's how it was being used and it makes the most since considering the return events are not hold-specific.  now, return the new hold ID on successful creation.  also tweaked potential copies count to use json_query count transform

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13822 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAdd support for UNION, INTERSECT, and EXCEPT.
scottmk [Thu, 13 Aug 2009 13:02:54 +0000 (13:02 +0000)]
Add support for UNION, INTERSECT, and EXCEPT.
(ORDER BY is accepted syntactically but not otherwise
supported yet.)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13821 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadded ability to auto-override configured checkout/renewal events at selfcheck. ...
erickson [Wed, 12 Aug 2009 17:18:50 +0000 (17:18 +0000)]
added ability to auto-override configured checkout/renewal events at selfcheck.  also, pull in JS files directly so we're not unnecessarily running opac-only code

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13817 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadded org setting type for setting overridable selfcheck events
erickson [Wed, 12 Aug 2009 17:14:23 +0000 (17:14 +0000)]
added org setting type for setting overridable selfcheck events

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13816 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoFor create and update methods: accept boolean column values
scottmk [Wed, 12 Aug 2009 15:19:49 +0000 (15:19 +0000)]
For create and update methods: accept boolean column values
as JSON_BOOLs instead of requiring them to be encoded as
"t" or "f" strings.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13815 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoUndo previous change. NULL can be a legitimate value for value.
scottmk [Tue, 11 Aug 2009 21:01:41 +0000 (21:01 +0000)]
Undo previous change.  NULL can be a legitimate value for value.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13814 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoIn doCreate(): check for a NULL pointer as a field value, and
scottmk [Tue, 11 Aug 2009 18:49:43 +0000 (18:49 +0000)]
In doCreate(): check for a NULL pointer as a field value, and
report it by class and field name.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13813 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoselected columns in a json_query need to be in an array
erickson [Tue, 11 Aug 2009 16:38:44 +0000 (16:38 +0000)]
selected columns in a json_query need to be in an array

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13812 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoUpdate code to check for all three caption & holdings fields, add
djfiander [Tue, 11 Aug 2009 16:20:38 +0000 (16:20 +0000)]
Update code to check for all three caption & holdings fields, add
basic test for supplementary material and indexes.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13809 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoDeal with a publication that only has a single level of
djfiander [Tue, 11 Aug 2009 16:10:14 +0000 (16:10 +0000)]
Deal with a publication that only has a single level of
enumeration (ie, only volume numbers).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13808 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoSegfaulting for json_queries selecting from functions, due to a
scottmk [Tue, 11 Aug 2009 13:47:32 +0000 (13:47 +0000)]
Segfaulting for json_queries selecting from functions, due to a
failure to handle the SELECT list properly.  Fixed.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13807 dcc99617-32d9-48b4-a31d-7c20da2025e4