working/Evergreen.git
5 years agoLP#1415898 Fix Potential Cstore Starvation in KPAC
Jason Stephenson [Thu, 29 Jan 2015 12:59:07 +0000 (07:59 -0500)]
LP#1415898 Fix Potential Cstore Starvation in KPAC

The getit_results function in EGKPacLoader.pm does xact_begin, which
opens a connected session to a cstore drone.  It later does xact_rollback,
which does not disconnect the session.  This leaves a drone hanging for
several seconds unable to responde to new requests.  This commit switches
to a rollback call that does disconnect the session.

Signed-off-by: Jason Stephenson <jason@sigio.com>
5 years agoLP#1412893: Only apply lost and paid status with the proper transactions
Ben Shum [Wed, 21 Jan 2015 21:30:53 +0000 (16:30 -0500)]
LP#1412893: Only apply lost and paid status with the proper transactions

As discovered while testing the lost and paid feature, when closing earlier transactions where
the item is currently lost, it could change the item status to lost and paid prematurely.

Change the logic so that it only does this if the current transaction being closed either has
a status of lost or longoverdue.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1409844: Towards more meaningful catalogue <title> elements
Dan Scott [Mon, 12 Jan 2015 18:13:03 +0000 (13:13 -0500)]
LP#1409844: Towards more meaningful catalogue <title> elements

Currently the catalogue <title> elements are formed by concatenating the page
title to "Catalog - ". This means that on browsers with more than a few tabs
open, users will only see "Catalog -", which doesn't help them navigate their
tabs. Also, in search results in general search engines, "Catalog - " is
expected to be a significant word as it appears first in the title of the page.

Instead, let's remove the "Catalog - " prefix entirely and add "- <library
name>" as a suffix to the page title. That way, a user will see the page title
in bookmarks, search results, and other contexts with the most important
information up front (whether that's the title of the work in record details,
or the fact that it's a search for some string), followed by the name of the
library to give it a specific context.

In addition, use the name of the library in the OpenSearch definition to be
more meaningful than the current hardcoded "Evergreen OpenSearch" (many users
will not even know what Evergreen is, if they stumble across the little "Add
search engine" widget at all).

And finally, use the HTML and URI filters appropriately to avoid any possible
damage :)

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1396161: Improve public docs and change osrf-config default from script help
Remington Steed [Wed, 26 Nov 2014 14:21:52 +0000 (09:21 -0500)]
LP#1396161: Improve public docs and change osrf-config default from script help

The public docs have an "Action Triggers" chapter, so this commit
applies the same improvements there to match the help docs in the
script. Also in the public docs, in two places a filename was split
across lines, causing a gap to appear in the HTML version of the docs.
That is corrected here.  This commit also removes the 'osrf-config'
option from the examples in the script help docs, since they are using
the default value.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1396161: action_trigger_runner.pl documentation update
Josh Stompro [Tue, 25 Nov 2014 21:56:50 +0000 (15:56 -0600)]
LP#1396161: action_trigger_runner.pl documentation update

 - Removed --granularity-only help docs.  Ever since the script was changed to
   support parallel execution of different granularity levels the granularity-only
   setting has always been set when using --granularity.

 - Added --verbose help docs.  This option wasn't included in the help docs.

 - Clarification - added some clarification to a few of the help descriptions.

 - Added an additional example for processing hooks and running pending events
   with a granularity set.

 - Removed two references to the --granularity-only flag in the Telephony docs.

I believe this change is valid for 2.7, 2.6 and 2.5 since the change to the script
 was made in 2010.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1413490 Fix <table><table> markup
Dan Scott [Thu, 22 Jan 2015 06:48:19 +0000 (01:48 -0500)]
LP#1413490 Fix <table><table> markup

Doesn't really have an effect on the display, as XULRunner automatically
repairs it dynamically, but might as well be correct.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1373594: Also ignore subfield 7 in get_graphics_880s
Ben Shum [Tue, 16 Dec 2014 19:34:12 +0000 (14:34 -0500)]
LP#1373594: Also ignore subfield 7 in get_graphics_880s

In the Czech Republic the subfield 7 of MARC fields 1XX and 7XX are used for
the National authority control number.

The problem is, that in current Evergreen versions, the subfield 7 is displayed
as a part of the link to author seach in search result or record details, but
when using the linkt to search rcords of the same author, no results are
returned, no matter whether the records exist or not.

That is why we nedd to add the subfield 7 into get_graphic_880s.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1407171 Avoid DEFLATEing fm_IDL.xml
Bill Erickson [Fri, 2 Jan 2015 22:50:26 +0000 (17:50 -0500)]
LP#1407171 Avoid DEFLATEing fm_IDL.xml

Prevent fm_IDL.xml from going through the Apache DEFLATE filter before
it's passed off to IDLCHUNK, which is unable to process deflated files.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1398926: Allow symbol popup to trigger on new marc fields
Thomas Berezansky [Wed, 3 Dec 2014 18:18:27 +0000 (13:18 -0500)]
LP#1398926: Allow symbol popup to trigger on new marc fields

Or rather, new MARC text entry boxes in general.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agoLP 1372197: Fixed another link to evergreen-ils.org that changed.
Josh Stompro [Wed, 24 Sep 2014 20:39:30 +0000 (15:39 -0500)]
LP 1372197: Fixed another link to evergreen-ils.org that changed.

Server upgrade section had a link to http://evergreen-ils.org/downloads.php that is now
http://evergreen-ils.org/egdownloads/

Signed-off-by: Josh Stompro <github@stompro.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP 1373197: fixed default "Get Help With Evergreen" link.
Josh Stompro [Wed, 24 Sep 2014 19:48:16 +0000 (14:48 -0500)]
LP 1373197: fixed default "Get Help With Evergreen" link.

The "Get Help" link was pointing to a 404 page, fixed it so it points at the correct page.

Signed-off-by: Josh Stompro <github@stompro.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1310619: Changing relationship between rcil and legacy stat cats to "might_have".
Chris Sharp [Tue, 6 May 2014 17:20:20 +0000 (13:20 -0400)]
LP#1310619: Changing relationship between rcil and legacy stat cats to "might_have".

After discussion with Mike Rylander, I've changed "has_a" to "might_have"
to make left joining rcil and legacy stat cat sources the default behavior.

For reference, see: http://irc.evergreen-ils.org/evergreen/2014-05-06#i_95055

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1310619: Add links in reporter.classic_item_list to legacy_cat1 and legacy_cat2...
Chris Sharp [Mon, 21 Apr 2014 13:10:28 +0000 (09:10 -0400)]
LP#1310619: Add links in reporter.classic_item_list to legacy_cat1 and legacy_cat2 views.

Currently, the reporter.classic_item_list view has the Legacy Cat 1 and 2
fields defined as "text", not "link", so all it will report out is the ID
number of the stat cat.  We want nullability control over stat cat entries,
so these need to be "link".

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1408803 Add 'persist' login type to auth_proxy sample config
Dan Wells [Thu, 8 Jan 2015 21:30:59 +0000 (16:30 -0500)]
LP#1408803 Add 'persist' login type to auth_proxy sample config

A recent version of EG added the option to "stay logged in", and this
was implemented as a new login type. Since basically everyone will use
this option via the OPAC, it makes sense that this should be part of the
sample config for auth_proxy.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoLP#980296: Stamping upgrade script for void lost on claims returned, etc.
Ben Shum [Tue, 13 Jan 2015 22:00:16 +0000 (17:00 -0500)]
LP#980296: Stamping upgrade script for void lost on claims returned, etc.

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#980296: Release notes entry for voiding lost on Claims Return
Kathy Lussier [Mon, 10 Feb 2014 06:03:12 +0000 (01:03 -0500)]
LP#980296: Release notes entry for voiding lost on Claims Return

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#980296: pgtap tests for the void on claims returned org settings.
Jason Stephenson [Sun, 7 Dec 2014 18:55:53 +0000 (13:55 -0500)]
LP#980296: pgtap tests for the void on claims returned org settings.

A single pgtap file to check if the 4 new settings exist in the database.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#980296: Update void on claims returned for longoverdue status.
Jason Stephenson [Sun, 7 Dec 2014 18:41:42 +0000 (13:41 -0500)]
LP#980296: Update void on claims returned for longoverdue status.

We add settings for voiding longoverdue fees on claims returned.

We modify code in Circ.pm to check those settings and void those
bills when a circulation is claims returned.

We also make some logical repairs to the new void_lost function
in CircCommon.pm and to event handling where that function is
called in set_circ_claims_returned in Circ.pm.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#980296: Add void of lost processing fee on claims returned.
Jason Stephenson [Mon, 1 Oct 2012 21:10:25 +0000 (17:10 -0400)]
LP#980296: Add void of lost processing fee on claims returned.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#980296: Void Lost Fines if copy claims returned.
Jason Stephenson [Mon, 1 Oct 2012 18:30:44 +0000 (14:30 -0400)]
LP#980296: Void Lost Fines if copy claims returned.

Add an ou setting (circ.void_lost_on_claimsreturned) to control whether or
not lost fines are voided when a lost circulation is claims returned.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1392759 Add 'bzr' to 'packager' targets
Bill Erickson [Fri, 9 Jan 2015 15:42:40 +0000 (10:42 -0500)]
LP#1392759 Add 'bzr' to 'packager' targets

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1392759 dev/pack makefile.install repairs
Bill Erickson [Thu, 8 Jan 2015 15:09:08 +0000 (10:09 -0500)]
LP#1392759 dev/pack makefile.install repairs

* remove 'make', since you can't execute a Makefile without it.
* remove duplicate installation of auto* packages for debian-wheezy

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1392759 dev/packager Makefile.install additions
Bill Erickson [Wed, 7 Jan 2015 16:55:47 +0000 (11:55 -0500)]
LP#1392759 dev/packager Makefile.install additions

Add additional packages to the "packager" target to help support
building Evergreen packages on machines where Evergreen and its prereqs
are not installed.

The "packager" target now depends internally on the "developer" target,
since packagers have to build the browser client dependencies.

Since older OSes have to build the nodejs dependencies, the autoconf,
etc. targets have been moved into the developer target, again to support
"headless" packaging.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1392759 developer/packager Makefile.install targets
Bill Erickson [Fri, 14 Nov 2014 15:45:07 +0000 (10:45 -0500)]
LP#1392759 developer/packager Makefile.install targets

* Adds <osname>-developer target for installing packages only needed by
  developers installing from source.  Currently, this is limited to
  packages needed for managing browser client dependencies, but others
  could be added later.

* Adds <osname>-packager target for installing packages needed to build
  Evergreen release bundles.

* Updates README install docs to reference these new targets.

* Updates README install docs to remove requirements for installing
  libtool/automake/autoconf, since those packages will have been
  installed during the OpenSRF install (which is required).

* NOTE: this does not include new Makefile.install targets for fedora

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1407507: Update relator codes
Dan Scott [Sun, 4 Jan 2015 21:26:04 +0000 (16:26 -0500)]
LP#1407507: Update relator codes

Per bug # 1046149, we added a script that will generate the contents of the
opac/parts/relators.tt2 file to provide more granular credits for added entries
that have relator codes. However, we haven't run that script since 2013, and
as there are a number of new relator codes, along with some revisions to the
existing relator terms, we should update relators.tt2 accordingly.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1074096: Remove Bib Call Number Search
Kathy Lussier [Thu, 11 Dec 2014 17:12:51 +0000 (12:12 -0500)]
LP#1074096: Remove Bib Call Number Search

Removes the Bib Call Number search as a default numeric search in the
catalog. Release notes include instructions for restoring it for those
sites that wish to restore it.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1386347 stamping upgrade for hold clear copy maps
Bill Erickson [Mon, 12 Jan 2015 16:58:40 +0000 (11:58 -0500)]
LP#1386347 stamping upgrade for hold clear copy maps

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoLP#1386347 clear maps at fulfillment time
Bill Erickson [Thu, 11 Dec 2014 19:36:11 +0000 (14:36 -0500)]
LP#1386347 clear maps at fulfillment time

For backwards compatibility with queue stats info on captured holds,
clear hold copy maps at fulfillment time instead of capture time, as
before.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1386347 Remove more unneeded map deleters
Bill Erickson [Wed, 29 Oct 2014 17:08:10 +0000 (13:08 -0400)]
LP#1386347 Remove more unneeded map deleters

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1386347: Clear hold-copy-map efficiently
Mike Rylander [Wed, 29 Oct 2014 14:37:29 +0000 (10:37 -0400)]
LP#1386347: Clear hold-copy-map efficiently

When capturing or canceling a hold, we can clear the hold-copy-map
with a trigger, saving the time of the user, and making the business
logic simpler.

LP#1386347 copy map trigger wants a RETURN

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoLP#1395456: (Fixing) Add back missing 0901 upgrade script
Ben Shum [Mon, 12 Jan 2015 16:52:22 +0000 (11:52 -0500)]
LP#1395456: (Fixing) Add back missing 0901 upgrade script

I apparently fumbled the upgrade script and it was lost in the action.
LP#1395456 is now closed with adding back this script to the repositories.

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1396359: Add entries for 345 and 346 tags to en-US/marcedit-tooltips.xml.
Jason Stephenson [Thu, 4 Dec 2014 21:28:32 +0000 (16:28 -0500)]
LP#1396359: Add entries for 345 and 346 tags to en-US/marcedit-tooltips.xml.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1396359: Add tooltips for 264, 344, & 347 tags to en-US/marcedit-tooltips.xml.
Jason Stephenson [Tue, 25 Nov 2014 21:29:26 +0000 (16:29 -0500)]
LP#1396359: Add tooltips for 264, 344, & 347 tags to en-US/marcedit-tooltips.xml.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoChanges to smooth out make_release
Dan Wells [Thu, 16 Jan 2014 20:07:40 +0000 (15:07 -0500)]
Changes to smooth out make_release

1) Make the fake 'HeadURL' into a URL which works with our web repo.
Note that this has 'tags/' hardcoded in, so it only works with true
release branches (e.g. rel_x_y_z) not "working" branches
(e.g. rel_x_y).

2) Change range selector when building log to better exclude commits
from previous releases.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoForward-port 2.6.4 upgrade script
Dan Wells [Tue, 6 Jan 2015 21:59:01 +0000 (16:59 -0500)]
Forward-port 2.6.4 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1406367 Fine generator skips no-fines transactions (parallel)
Bill Erickson [Mon, 29 Dec 2014 22:05:39 +0000 (17:05 -0500)]
LP#1406367 Fine generator skips no-fines transactions (parallel)

Avoid inspecting no-fines transactions when running the fine generator
in parallel mode.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agoLP#1406367 Fine generator skips no-fines transactions
Bill Erickson [Mon, 29 Dec 2014 19:04:45 +0000 (14:04 -0500)]
LP#1406367 Fine generator skips no-fines transactions

Filter out any circs or booking reservations which will never be billed
in the initial overdue transactions query used by the fine generator.
This allows us to avoid loading rows into memory that the fine generator
will ignore anyway.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agoLP#1406367 Reduce Fine gen. API memory use
Bill Erickson [Fri, 19 Dec 2014 17:14:10 +0000 (12:14 -0500)]
LP#1406367 Reduce Fine gen. API memory use

Avoid loading the full set of billable transaction objects into
memory when generating fines to reduce the memory footprint of the
open-ils.storage fine generater API.  Instead, load transaction IDs
on startup, then fetch individual transactions as needed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agoMake Vandelay merge profile names translatable.
Pasi Kallinen [Thu, 4 Jul 2013 09:00:48 +0000 (12:00 +0300)]
Make Vandelay merge profile names translatable.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoLP#1319964 "Summaries & More" displays improperly in TPAC
Michael Peters [Mon, 8 Dec 2014 17:08:21 +0000 (12:08 -0500)]
LP#1319964 "Summaries & More" displays improperly in TPAC

Commit 14eb3d30 added HTML-escaping of OPAC extras display
labels, meaning that if an ampersand in such a label is
desired, it should be entered in the template just as an ampersand.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
[Amended original commit to tweak message and remove unecessary changes
 to .po files, which are rebuilt when a release is rolled.]

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoForward-port 2.7.1-2.7.2 upgrade script
Ben Shum [Wed, 17 Dec 2014 21:04:33 +0000 (16:04 -0500)]
Forward-port 2.7.1-2.7.2 upgrade script

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoForward port 2.7.0-2.7.1 upgrade script
Ben Shum [Wed, 5 Nov 2014 20:55:09 +0000 (15:55 -0500)]
Forward port 2.7.0-2.7.1 upgrade script

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1402905 Use stricter matching for UPC values
Dan Scott [Tue, 16 Dec 2014 04:23:49 +0000 (23:23 -0500)]
LP#1402905 Use stricter matching for UPC values

Per http://www.loc.gov/marc/bibliographic/bd024.html we
should be checking to see if either the ind1 is "1" or
if there's a subfield 2 with a value of "upc" before
assuming that any "Other standard identifier" 024 field
is a UPC value.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#921142: Bring back automatic padding of short fixed fields in the GUI MARC editor
Mike Rylander [Fri, 18 May 2012 12:30:08 +0000 (08:30 -0400)]
LP#921142: Bring back automatic padding of short fixed fields in the GUI MARC editor

Bring back automatic padding of short fixed fields in the GUI MARC
editor. Also, use onblur instead of oninput, so that we've already lost
focus and don't care if that happens again.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1394356: Stamping upgrade script for patron purge post code fix
Ben Shum [Tue, 16 Dec 2014 20:15:57 +0000 (15:15 -0500)]
LP#1394356: Stamping upgrade script for patron purge post code fix

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1394356 Patron purge circs retain post code
Bill Erickson [Fri, 28 Nov 2014 21:29:57 +0000 (16:29 -0500)]
LP#1394356 Patron purge circs retain post code

When purging a patron, clear the address data after circulation
anonymization to ensure the usr_post_code is retained.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1400376: Stamping upgrade script for fix to metabib.record_attr
Ben Shum [Tue, 16 Dec 2014 20:01:53 +0000 (15:01 -0500)]
LP#1400376: Stamping upgrade script for fix to metabib.record_attr

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1400376: Don't allow NULL attrs to polute an HSTORE as a key
Mike Rylander [Tue, 16 Dec 2014 01:32:51 +0000 (20:32 -0500)]
LP#1400376: Don't allow NULL attrs to polute an HSTORE as a key

That causes the HSTORE to blow up, which is bad for circs that
want to succeed.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1389403: Stamping upgrade script for normalizer detection to call number browse
Ben Shum [Tue, 16 Dec 2014 19:54:28 +0000 (14:54 -0500)]
LP#1389403: Stamping upgrade script for normalizer detection to call number browse

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1389403 Normalizer detection compatibility with LP#1373693
Dan Wells [Wed, 19 Nov 2014 17:16:03 +0000 (12:16 -0500)]
LP#1389403 Normalizer detection compatibility with LP#1373693

In LP#1373693, $ou_ids become an optional argument when at the top of
the tree.  We need to account for that.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1389403 Add normalizer detection to call number browse
Dan Wells [Fri, 4 Oct 2013 14:02:39 +0000 (10:02 -0400)]
LP#1389403 Add normalizer detection to call number browse

When finding the pivot for call number browse, we currently rely on
simple label matching (rather than normalized label matching), since
we do not know at the time of the search which normalizer we should
use.

Rather than blindly using the label, let's select the pivot in two
phases.  First, we will do what we do know, getting as close as
possible by label alone.  If we find an exact match, we are done (same
as the current code).  If we don't find an exact match, we take the
normalizer setting from the closest label match, normalize our input,
then search again.

This method *greatly* improves the overall accuracy of call number
searching whenever the call number being browsed for does not exist,
while causing no harm to accuracy when it does exist (since it will
either match the label or normalize to the same call number anyway).

Eventually, we may want to add interface elements for selecting the
call number type, probably defaulting to the default call number type
for the org unit being searched, but even with that in place, this
"auto-detection" logic should still be valuable.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1401286: Cleaner display of URIs in search results
Dan Scott [Wed, 10 Dec 2014 22:05:38 +0000 (17:05 -0500)]
LP#1401286: Cleaner display of URIs in search results

Right now a record with an 856 like:

856 40 $zAvailable online $uhttp://publications.gc.ca $9LUSYS

shows up in search results with an HTML display like:

<a href="http://publications.gc.ca">http://publications.gc.ca</a> - Available online

rather than the much cleaner:

<a href="http://publications.gc.ca">Available online</a>

My simplistic approach is to check to see if the link text == the href,
and if so, and we have a note to display, to use the note as the text of
the link instead.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1400082 - avoid uninitialized var warning at TPAC login
Dan Scott [Sun, 7 Dec 2014 13:51:33 +0000 (08:51 -0500)]
LP#1400082 - avoid uninitialized var warning at TPAC login

Give username a default value of '', which makes the regex happy (avoiding an
uninit warning in Apache logs if no value was entered) and still counts as de
nada for the purposes of the actual login dance.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1401271: Add missing dependency for Date::Manip perl module
Jason Stephenson [Sat, 29 Nov 2014 15:34:53 +0000 (10:34 -0500)]
LP#1401271: Add missing dependency for Date::Manip perl module

This commit adds lines to distro-specific Makefiles to install
Perl Date::Manip packages so that Date::Manip::Date is
avaliable for marc_export. Somehow, this got missed or removed.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1400100 - Avoid extra </div> when OpenURL is enabled
Dan Scott [Sun, 7 Dec 2014 15:17:42 +0000 (10:17 -0500)]
LP#1400100 - Avoid extra </div> when OpenURL is enabled

When the OpenURL resolver is enabled, the record summary.tt2 page always
inserts a </div>, whether or not there actually are any OpenURL results to
point at (which is the condition that triggers the opening <div>).

This has the effect of resulting in the generated RDFa not including anything
below the OpenURL section, effectvely preventing the schema.org/Offer types
from being associated with the record. Which is not good for the semantic web
of library data.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoUpdate 2.6-2.7.0-upgrade-db.sql to reflect that it actually starts from 2.6.3 and up.
Ben Shum [Fri, 5 Dec 2014 21:02:04 +0000 (16:02 -0500)]
Update 2.6-2.7.0-upgrade-db.sql to reflect that it actually starts from 2.6.3 and up.

So, actually, the 2.7 upgrade path needs to include everything up to 2.6.3 to get all
the fixes.

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoRe-order parts of 0887 upgrade script
Ben Shum [Fri, 5 Dec 2014 20:59:40 +0000 (15:59 -0500)]
Re-order parts of 0887 upgrade script

Based on feedback from dbs, in PostgreSQL 9.1, the order to which we
fix up these functions matters.  So drop if exists first, then create
new.

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoDocs: Circulation - Patron Record web client updated content
Yamil Suarez [Fri, 12 Dec 2014 22:33:20 +0000 (17:33 -0500)]
Docs: Circulation - Patron Record web client updated content

There are still some sections missing, like 'Staff-Generated
Penalties/Messages' and 'merging patrons'.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
5 years agoLP#1401177: Stamping upgrade script of unique_mr_attrs.sql.
Jason Stephenson [Wed, 10 Dec 2014 21:03:11 +0000 (16:03 -0500)]
LP#1401177: Stamping upgrade script of unique_mr_attrs.sql.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agoLP#1401177: uniquify attrs across a metarecord
Mike Rylander [Wed, 10 Dec 2014 18:51:51 +0000 (13:51 -0500)]
LP#1401177: uniquify attrs across a metarecord

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agoDOCS: Tab documentation for web client
Kathy Lussier [Fri, 5 Dec 2014 19:28:02 +0000 (14:28 -0500)]
DOCS: Tab documentation for web client

Replacing the XUL-based tab docs with general tips for using web browser
controls, shortcuts, add-ons to support navigation in the web client.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoDOCS: Logging into the web client
Kathy Lussier [Fri, 5 Dec 2014 17:24:45 +0000 (12:24 -0500)]
DOCS: Logging into the web client

Adding a login section to the web client docs.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoDocs: Web Client preview intro
Remington Steed [Fri, 5 Dec 2014 15:29:48 +0000 (10:29 -0500)]
Docs: Web Client preview intro

This commit adds an introduction for the Web Client preview. It explains
what to expect as development continues, and where to give feedback. It
also includes the rationale from the 2.7 release notes.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 years agoMinor fix to web client section headers in root.txt
Kathy Lussier [Fri, 5 Dec 2014 14:03:20 +0000 (09:03 -0500)]
Minor fix to web client section headers in root.txt

I accidentally added the circulation header twice when adding the new
sections for web client docs. This commit removes one of the headers.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoWeb client section headings
Kathy Lussier [Thu, 4 Dec 2014 21:36:08 +0000 (16:36 -0500)]
Web client section headings

Adding section headings for web client documentation, which will be coming
shortly.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoDocs: Update to template receipt docs
Lynn Floyd [Mon, 10 Nov 2014 18:29:31 +0000 (13:29 -0500)]
Docs: Update to template receipt docs

Thanks to Lynn Floyd. When adding the new content I ended up splitting new and old content into three files.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
5 years agoRevert "LP#1198465 Allow fine generator to respect a stop_fines filter"
Dan Wells [Wed, 19 Nov 2014 23:08:31 +0000 (18:08 -0500)]
Revert "LP#1198465 Allow fine generator to respect a stop_fines filter"

This reverts commit e1fdcd3a6885baac3f86402e330aef3d8b36c681.

The code failed in the case of restoring voided lost overdues together
with generating new lost overdues on checkin.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoRevert "LP#1198465 lost overdues generated in main xact"
Dan Wells [Wed, 19 Nov 2014 23:06:18 +0000 (18:06 -0500)]
Revert "LP#1198465 lost overdues generated in main xact"

This reverts commit d2a521c0ff32e9921bfc93cb86b2c917e5eda92e.

The code failed in the case of restoring voided lost overdues together
with generating new lost overdues on checkin.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1207529: Add /openils assumption note
alzr [Mon, 5 Aug 2013 21:50:09 +0000 (16:50 -0500)]
LP#1207529: Add /openils assumption note

Signed-off-by: alzr <aleksey.lazar@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1207529: Make sure $PATH includes /openils/bin when configuring
alzr [Mon, 5 Aug 2013 19:33:07 +0000 (14:33 -0500)]
LP#1207529: Make sure $PATH includes /openils/bin when configuring

https://bugs.launchpad.net/evergreen/+bug/1207529

Signed-off-by: alzr <aleksey.lazar@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Conflicts:
docs/installation/server_upgrade.txt

5 years agoLP#1384932: document the zips.txt ZIP code database feature
Josh Stompro [Wed, 29 Oct 2014 21:12:08 +0000 (16:12 -0500)]
LP#1384932: document the zips.txt ZIP code database feature

Patron Address City/State/County Pre-Populate by ZIP Code.

Documented the zips.txt feature that auto fills patron address
(City, State, County) information.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1246371: Allow BibCommon::title_is_empty to accept a bre id or bre object.
Jason Stephenson [Wed, 30 Oct 2013 15:05:45 +0000 (11:05 -0400)]
LP#1246371: Allow BibCommon::title_is_empty to accept a bre id or bre object.

I was trying to delete copies with the record fleshed in the call number
object and got the following error:

Can't use an undefined value as an ARRAY reference at
/usr/local/share/perl/5.14.2/OpenILS/Application/Cat/BibCommon.pm line 399

Having title_is_empty check for a bre object and use its id solved this
problem for me.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1083639: use "cp -r" instead of "cp -R"
Galen Charlton [Thu, 13 Nov 2014 18:45:14 +0000 (10:45 -0800)]
LP#1083639: use "cp -r" instead of "cp -R"

This change is purely for the sake of consistency; there's
no functional difference.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1083639 - Added command to copy fonts into the KPAC2 / Alternate monster skin dir
Josh Stompro [Thu, 23 Oct 2014 19:30:05 +0000 (14:30 -0500)]
LP#1083639 - Added command to copy fonts into the KPAC2 / Alternate monster skin dir

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1116387 - adding kpac setup notes.
Josh Stompro [Thu, 23 Oct 2014 18:21:16 +0000 (13:21 -0500)]
LP#1116387 - adding kpac setup notes.

Revised instructions based on my testing.  Swapped around the Monster
and Default skin discriptions since the listed Alternate Skin is the default skin.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoAdd KPAC configuration info to the community docs
Kathy Lussier [Tue, 5 Feb 2013 15:24:17 +0000 (10:24 -0500)]
Add KPAC configuration info to the community docs

Adds the KPAC TechRef docs to root.txt so that this information can be
available via the community docs. Also adds a section to the docs on
configuring the alternate skin and removes a reference to configuration
from the end-user KPAC docs.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1246839: marc_stream_importer.pl no longer crashes with vs 0.23 of File::Temp
Fredric T Parks [Wed, 6 Nov 2013 23:36:32 +0000 (15:36 -0800)]
LP#1246839: marc_stream_importer.pl no longer crashes with vs 0.23 of File::Temp

updated marc_stream_importer.pl to use the 0.23 API

Signed-off-by: Fredric T Parks <fparks@catalystitservices.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoLP#1198465 lost overdues generated in main xact
Bill Erickson [Thu, 25 Sep 2014 16:49:17 +0000 (12:49 -0400)]
LP#1198465 lost overdues generated in main xact

Generate overdue fines for lost checkins (if configured) within the main
body of the checkin transaction to avoid complications with negative
balance reconciliation.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1198465 Allow fine generator to respect a stop_fines filter
Mike Rylander [Thu, 25 Sep 2014 16:58:45 +0000 (12:58 -0400)]
LP#1198465 Allow fine generator to respect a stop_fines filter

In order to support situations where billings should be generated on
specific circs, even when stop_fines is set, we allow a filter to
be passed.  The default of not passing a filter is the same as requiring
that stop_fines be NULL, which is the pre-commit behavior.

We also remove a never-used parameter.

Signed-off-by: Mike Rylander <miker@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1133158 - Fix typos in action_trigger_runner.pl
Josh Stompro [Mon, 10 Nov 2014 15:29:38 +0000 (09:29 -0600)]
LP#1133158 - Fix typos in action_trigger_runner.pl

Added equals sign to --hooks and added --process-hooks to command so
--hooks=x is actually used.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1386260: DST bugs in perl live tests (04-overdue_with_closed_dates.t)
Jason Etheridge [Fri, 7 Nov 2014 18:38:39 +0000 (13:38 -0500)]
LP#1386260: DST bugs in perl live tests (04-overdue_with_closed_dates.t)

more fixes

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1386260: DST bugs in perl live tests (03-overdue_circ.t)
Jason Etheridge [Fri, 7 Nov 2014 18:00:10 +0000 (13:00 -0500)]
LP#1386260: DST bugs in perl live tests (03-overdue_circ.t)

Use safer date math to handle bug with DST

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1391290: Stamping upgrade script for authority reingest setting
Ben Shum [Tue, 11 Nov 2014 02:00:42 +0000 (21:00 -0500)]
LP#1391290: Stamping upgrade script for authority reingest setting

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1391290: Respect setting to disable authority propagation on reingest
Chris Sharp [Mon, 10 Nov 2014 19:43:22 +0000 (14:43 -0500)]
LP#1391290: Respect setting to disable authority propagation on reingest

In commit a1612cfd6 we lost the ability to disable authority propagation on
record update.  Here, we put it back.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1012308: Teach the staff client to use titlesort
Thomas Berezansky [Tue, 12 Jun 2012 18:08:04 +0000 (14:08 -0400)]
LP#1012308: Teach the staff client to use titlesort

At least in some places.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP1282277_LP1282286_Unitialized_Vars_FIx
Liam Whalen [Sun, 13 Jul 2014 17:49:07 +0000 (10:49 -0700)]
LP1282277_LP1282286_Unitialized_Vars_FIx

The commit to prompt users if they are going to lose data in MARC edit
added some new variables (tabs, and tab) in various files.  If the MARC
edit window does not appear in a tab, then these variables remain
unitialzed and cause problems for MARC edits that appear in their own
window.  By checking for the existence of the variables before MARC
edito loads in its own windown, the problems are resolved.

Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop>
Signed-off-by: Jennifer Pringle <jpringle@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP1282277 & LP1282286 Double call to MARC edit save fixed
Liam Whalen [Mon, 7 Jul 2014 20:55:05 +0000 (13:55 -0700)]
LP1282277 & LP1282286 Double call to MARC edit save fixed

The code currently calls the MARC edit save feature twice due to a copy
and paste error.  This commit removes the duplicate call to save.

Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop>
Signed-off-by: Jennifer Pringle <jpringle@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP1282277 & LP1282286 Fixed error with Copy Editor
Liam Whalen [Sat, 28 Jun 2014 20:52:45 +0000 (13:52 -0700)]
LP1282277 & LP1282286 Fixed error with Copy Editor

With the previous fix applied, it is impossible to edit values within the copy
editor. A javascript error occurs.  This commit fixes that problem.

Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop>
Signed-off-by: Jennifer Pringle <jpringle@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP1282277 & LP1282286 MARC edit save warning & TCN search warning
Liam Whalen [Mon, 16 Sep 2013 02:26:16 +0000 (19:26 -0700)]
LP1282277 & LP1282286 MARC edit save warning & TCN search warning

LP1282286 TCN search shortcut incorrectly prompts for lost data

When cataloguing in the Marc Edit view, users can hit Shift-F3 to bring
up the TCN search dialog box.  After entering a TCN and confirming their
entry, they will be taken to the record specified by the TCN entered.

However, if the user has edited some data on the current marc record,
then another dialog box should appear before the TCN search box that
gives them a warning that they will lose data if they go to a new
record.

Currently, whenver a user presses the Shift-F3 shortcut, they are given
a warning about losing data regardless of the current state of the marc
record being edited.

When a record is edited, a key press event is captured and the function
oils_lock_page is called to record the page as edited.  In the case of
this bug, the Shift key is not being ignored.  So, when the user
presses Shift-F3, the marc record is locked as if it were edited, then
the TCN search function is called.  After the user enters a TCN and
presses OK, the warning about lost data is displayed because the
pressing of Shift marked the record as edited.

This fix adds a check for the ev.shiftKey event in the
set_lock_on_keypress function call in marcedit.js.

Currently, if the user has edited a marc record and
pressed Shift-F3 to retrieve another record via TCN, then the prompt for
the TCN appears and after the user ok's that prompt they are prompted to
make sure they are ok with losing data.

This modification causes the prompt for lost data to appear before the
prompt for the TCN value.  It requires modifying
chrome/content/main/menu.js, which will require a staff client update.
This fix also ensures that if users confirm that it is ok to lose
data but then cancel their TCN searches that they will be prompted that
they might lose data again if they do more TCN retrieving.

LP1282277 Prompt for lost data in  Marc Edit

When using the MARC editor, if you modify a record and then use another
UI element to leave the MARC editor, you will be prompted that you might
lose data if you leave the MARC editor.  Currently, this prompt does not
happen if the user uses an Action for This Record drop down menu item.
As well, if the user then returns to the MARC editor, the changes are
still present, but leaving the MARC editor no longer prompts with  a
lost data warning.

This fix, adds checks to the Actions for This Record menu items, and it
adds some tab variables to keep track of the state of the MARC editor.
That way, if the user leaves then comes back and changes are still
present, the user will still get a lose data warning if they try to
leave again.

As well, when ever a key is pressed in MARC Edit that would result in
modifying a record, a counter is increased on a semamphor stored on
the XUL tab containing the Marc Edit UI.  Currently, when the record is
saved, this counter is decremented by 1.  However, the code checks to
see that the counter is 0 in order to determine if the tab is still
locked and data might be lost.

So, to fix this, we check in the unlock_tab code to see if we are in the
MARC Editor, and if we are, then we set the counter to 0.  The
unlock_tab code is used when saving via the Marc Editor.  It may be
used elsewhere in other parts of the Staff Client, so I have left the
original decrement by 1 logic in for all cases other than being in the
Marc Editor.

Conflicts:

Open-ILS/xul/staff_client/chrome/content/cat/opac.js
Open-ILS/xul/staff_client/server/cat/marcedit.js
Open-ILS/xul/staff_client/server/cat/marcedit.xul

The fix was modified, because the previous fix was storing the flags that
indicated a change to a MARC record at the window level.
This new fix stores them at the tab level.  I am keeping this commit
message to indicate that there were more Conflicts when mergin Sitka's
code into the community code.  In case, I missed something and a record
of what was done needs to be consulted.

Conflicts:

Open-ILS/xul/staff_client/chrome/content/OpenILS/global_util.js
Open-ILS/xul/staff_client/chrome/content/cat/opac.js
Open-ILS/xul/staff_client/chrome/content/main/menu.js
Open-ILS/xul/staff_client/server/cat/marcedit.js

LP1282277 & LP1282286 MARC edit TCN search lose data prompts

This commit modifies my previous commits.  The code now uses the
previous versions code to mark a tab as locked and to record that data
is saved or not saved.  However, when a user returns to the MARC edit
screen, if there are changes still present, then the code now locks the
tab again and records that there is unsaved data.  This should allow all
previous functionality to remain while providing the proper warnings
when within the MARC editor.

LP1282277 & LP1282286 MARC Edit and TCN lose data prompt

This commit sets the tab.marc_edit_changed value to false when the tab
is set.  This means if an MARC record is edited in a tab then the tab is
set to another view, if the user then goes back to MARC edit, the tab
will not be locked because the flag will now be set to false.  This
results in no warning being shown when a user tries to leave a MARC edit
page when they have not edited the MARC.

Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop>
Signed-off-by: Kyle Tomita <tomitakyle@gmail.com>
Signed-off-by: Jennifer Pringle <jpringle@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1203734 copy circ counts include anon. circs
Bill Erickson [Mon, 3 Nov 2014 22:55:00 +0000 (17:55 -0500)]
LP#1203734 copy circ counts include anon. circs

Circ counts displayed on "Show Last Few Circulations" (XUL) includes
active, anonymized, and legacy circulations (via cstore)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP#1095290: Wrap record navigation template next and previous arrows with spans.
Pasi Kallinen [Wed, 2 Jan 2013 13:18:56 +0000 (15:18 +0200)]
LP#1095290: Wrap record navigation template next and previous arrows with spans.

Also affects one translatable string, by moving the arrow outside it;
there's no sense having it in the string.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#778989: Stamping upgrade script for copy location trigger
Ben Shum [Tue, 11 Nov 2014 01:27:11 +0000 (20:27 -0500)]
LP#778989: Stamping upgrade script for copy location trigger

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#778989: Adding DROP TRIGGER IF EXISTS to allow for smooth upgrades.
Chris Sharp [Tue, 26 Aug 2014 19:39:00 +0000 (15:39 -0400)]
LP#778989: Adding DROP TRIGGER IF EXISTS to allow for smooth upgrades.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#778989: Add circ lib to location fixer
Thomas Berezansky [Tue, 26 Aug 2014 16:14:11 +0000 (12:14 -0400)]
LP#778989: Add circ lib to location fixer

Because the circ lib is valid for picking locations.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#778989: Attempt to find "Correct" copy location
Thomas Berezansky [Wed, 1 Feb 2012 21:07:05 +0000 (16:07 -0500)]
LP#778989: Attempt to find "Correct" copy location

This adds a trigger to asset.copy that on insert or change of the location
and/or call number tries to find an identically named copy location that
is scoped to the owning library of the copy.

If it does not find one it uses the location provided.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoDocs: remove extra '\r' in cataloging/MARC_batch_edit.txt
Yamil Suarez [Mon, 10 Nov 2014 21:20:58 +0000 (16:20 -0500)]
Docs: remove extra '\r' in cataloging/MARC_batch_edit.txt

Signed-off-by: Yamil Suarez <yamil@yamil.com>
5 years agoDocs: Documentation for MARC Batch Edit
Timothy Spindler [Mon, 10 Nov 2014 21:00:15 +0000 (16:00 -0500)]
Docs: Documentation for MARC Batch Edit

Signed-off-by: Yamil Suarez <yamil@yamil.com>
5 years agoUse xact_start for due date calc instead of now
Thomas Berezansky [Mon, 9 Sep 2013 19:49:47 +0000 (15:49 -0400)]
Use xact_start for due date calc instead of now

If you don't supply a due date when creating a circulation with the
open-ils.circ.checkout family of calls, the due date is currently
calculated from now().  This code modification changes that so that
if a checkout_date is supplied that is used to calculate the due date
instead of now().

This enables some interesting uses of the open-ils.circ module for
batch circulation in the cases of offline use from a spreadsheet and
not the offline client or in the case of migrating circulations from
another ILS into Evergreen.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoDocumentation: LP#1386854 - Locally Hosted Added Content.
Yamil Suarez [Mon, 10 Nov 2014 18:47:52 +0000 (13:47 -0500)]
Documentation: LP#1386854 - Locally Hosted Added Content.

Adds documentation that describes how to use the local content bypass
feature of the AddedContent modules.  This allows for local added content like
cover art, reviews, TOC, exerpts or annotations to be shown in bib records.

I also changed the headers in the External Added Content section to use title case.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
5 years agoLP#1390225: Fail to care about errors from auth.session.delete
Mike Rylander [Thu, 6 Nov 2014 21:03:36 +0000 (16:03 -0500)]
LP#1390225: Fail to care about errors from auth.session.delete

We're just tossing this call over the wall and moving on.  We don't
care if the session wasn't there to delete or even if we didn't pass
a session to the server.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>