Replace almost all remaining reference to the MODULENAME macro
with references to a corresponding variable name.
This change is part of a project to split up the oils_cstore module
into an interface module (consisting mostly of osrfAppChildInit(),
osrfAppInitialize(), and osrfAppChildExit()) and an implementation
module (consisting of pretty much everything else). The implementation
module will then be available for reuse in other contexts.
Reduce dispatchCRUDMethod() to little more than a case structure,
which delegates all work to other functions (instead of doing some
of the work itself). Besides making the code arguably tidier, this
change will make it easier to isolate much of the logic to a separate
module.
Flesh and show cancel_reason in the user request rejected template. I'm just correcting the existing upgrade script and seed data rather than roll a new one.
added wrapper to new XUL get_new_session call. when embedded ui's lose their session, launch the staff client's login dialog instead of the local web-only dialog
Adds a xulG.get_new_session() convenience function that can be called by embedded dojo interfaces, etc.
Side effect: Sets a session cookie and updates the global OpenILS.data store with the newly acquired authtoken.
Return Value: True if a new authtoken was acquired, otherwise False.
Optional Param: Object with optional keys 'callback' and 'operator_change'.
If 'operator_change' is passed in with a value of true, then the dialog will resemble the Admin->Operator Change dialog, but it is not yet completely implemented (doesn't preserve the existing authtoken). Otherwise, we get the normal Session Expired dialog.
Callback may be a function that resembles this:
function( success, authtoken, authtime ) {
return success; // whatever gets returned here will also be returned by xulG.get_new_session()
}
Use the AssetCommon version of update_fleshed_copies so we can stay within the same transaction. However, no more magic hold retargeting. The CRON job can take care of any holds that do not get cancelled
For the first, @xact was never used.
The 3 part conditional only had two different outcomes.
There is still a problem with user_transactions reproducing a lot
of the functionality of user_transaction_history, which it already
calls to do the real query. But it doesn't reproduce all of it.
Recommend relying on user_transaction_history as much as possible,
but that kind of work is out of scope for this review.
For the other, remove unused var and unnecessary array.
You don't need to build an array when all you do at the end is count its elements.
Signed-off-by: Joe Atzberger <atz@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16092 dcc99617-32d9-48b4-a31d-7c20da2025e4
added claim sub-module. Added API call to retrieve claim-ready items. Added API call to initiate a claim for a given lineitem_detail or add a claim event to an existing claim
Cancel holds targeting the bib associated with a lineitem if it has become deleted. Note concerns about rolling back transactions and using open-ils.cat
don't make the call to open-ils.cat if there are no real copies to delete. I'm assuming we want to be able to call this method against lineitems that might not even be associated with a purchase order, much less have copies, etc. Need to think about that permission check at the beginning which is using purchase order -> ordering agency as a context org
param tweak to get copies to flesh on lineitem details, and yes, open-ils.cat will handle volume and bib deletion, as well as hold retargeting. But we still need to cancel holds in the case where the bib gets deleted. If the bib isn't deleted (because other copies were added outside of acq), holds that came from acq may or may not target those non-acq copies. If they don't and any holds become unfulfillable (say due to hold permit policies), we'll just let them lay for now rather than try to figure that out.
Har, I looked in Lineitem.pm for an existing lineitem cancel method before I started, but not Order.pm. Remove the one from Lineitem.pm and tweak the one in Order.pm. Still need smoketest, etc.
Rough cut of 'open-ils.acq.lineitem.cancel', which "Cancels a lineitem, any of its detail entries and corresponding copies and call numbers, and potentially related holds (if the bib becomes empty)." Need to smoke test it, add hold deletion if the bib becomes empty (and add an org unit setting for optionally deleting the bib as well), and check to see if volume deletion is being handled automatically by open-ils.cat.asset.copy.fleshed.batch.update
erickson [Wed, 31 Mar 2010 19:44:19 +0000 (19:44 +0000)]
Seed data for org settings and override permissions for managing the
behavior when the systems finds a copy that could be used to fulfill a
hold at the requesting branch before the hold is placed.
erickson [Tue, 30 Mar 2010 15:50:41 +0000 (15:50 +0000)]
moved to auto-grid for allocations and debits for paging support, etc. hiding percent-based allocation option for now since they are not supported by the back-end
miker [Tue, 30 Mar 2010 14:34:53 +0000 (14:34 +0000)]
Patch from Lee Dickens and Galen Charlton to correct a thinko in the recent change to pg_loader -- ignore auto-pkey tables, as those have had their sequences adjusted, um, automatically
erickson [Tue, 30 Mar 2010 02:00:26 +0000 (02:00 +0000)]
consolidated the bib and authority record import logic to get the new functionality into the authority import process. 1match is possible if all matches point to the same record, not just if there is only 1 match.
erickson [Mon, 29 Mar 2010 20:45:57 +0000 (20:45 +0000)]
added support for using alternate context-specific spell-check dictionaries w/ sample config. now de-duping suggestions that only differ by case. added a new boolean value to the response object to indicate if the original word was found in the dictionary, but still return alternate suggestions
scottmk [Mon, 29 Mar 2010 19:22:38 +0000 (19:22 +0000)]
In query.stored query: make from_clause nullable, so that we can
represent UNION, INTERSECT, and EXCEPT queries.
M Open-ILS/src/sql/Pg/002.schema.config.sql
M Open-ILS/src/sql/Pg/008.schema.query.sql
A Open-ILS/src/sql/Pg/upgrade/0220.schema.query.nullable-from.sql
erickson [Mon, 29 Mar 2010 15:38:43 +0000 (15:38 +0000)]
plugged in paging for viewing fund propagation results. added context org and org child selector to rollver actions. moved some css to external acq css file
scottmk [Mon, 29 Mar 2010 14:36:08 +0000 (14:36 +0000)]
When propagating funds: propagate the balance_warning_percent
and balance_stop_percent columns.
M Open-ILS/src/sql/Pg/200.schema.acq.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0219.schema.acq.propagate-fund-bal-pct.sql
miker [Sat, 27 Mar 2010 17:30:40 +0000 (17:30 +0000)]
Patch from Dan Wells which allows restriction of renewal when the item in question is needed to fulfill a hold.
There was concern initially about whether a patrons own holds should be ignored, but that is not the case in scripted circ rules, so the behavior, as implemented by Dan, is correct.
erickson [Fri, 26 Mar 2010 21:09:09 +0000 (21:09 +0000)]
show fiscal rollover summary; insert newly created funds into the fund grid for display; TODO: plug in grid paging handlers for paging through dry-run propagate results; finish up css and move to css file
senator [Fri, 26 Mar 2010 20:30:56 +0000 (20:30 +0000)]
Acq: Resurrect an old "view fund" interface, add some tag mapping managment
From the "list funds" interface, you can click on the name of a fund and get
to the "view funds" interface for that fund. That interface now how a "tags"
tab where you can attach and detach tags to/from the fund you're viewing.