working/Evergreen.git
4 years agoLP#1568046: Stamping upgrade script for eliminating connectby from functions
Ben Shum [Tue, 5 Jul 2016 05:14:38 +0000 (01:14 -0400)]
LP#1568046: Stamping upgrade script for eliminating connectby from functions

Signed-off-by: Ben Shum <ben@evergreener.net>
4 years agoLP#1568046: Replace last two uses of connectby with other function calls.
Jason Stephenson [Fri, 1 Jul 2016 17:13:16 +0000 (13:13 -0400)]
LP#1568046: Replace last two uses of connectby with other function calls.

Modify permission functions permission.usr_has_perm_at_nd and
permission.usr_has_perm_at_all_nd to no longer require the connectby
function from the tablefunc extension.  The connectby functionality is
replaced by existing database functions to retrieve org. unit
descendants.

This change removes the need to load the tablefunc extension, so it is
dropped from the create scripts.  The upgrade script does not remove
the extension as sites may be using connectby or other functions from
the extension.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
4 years agoDocs: Add tip for using "temp" as a login_types when using "Change Operator: New"
Yamil Suarez [Sun, 26 Jun 2016 16:52:43 +0000 (12:52 -0400)]
Docs: Add tip for using "temp" as a login_types when using "Change Operator: New"

Signed-off-by: Yamil Suarez <yamil@yamil.com>
4 years ago2.10.4-2.10.5 schema upgrade script
Galen Charlton [Thu, 16 Jun 2016 00:32:10 +0000 (20:32 -0400)]
2.10.4-2.10.5 schema upgrade script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoDocs: Adding 2.10 Release Notes
Kathy Lussier [Wed, 15 Jun 2016 16:45:31 +0000 (12:45 -0400)]
Docs: Adding 2.10 Release Notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1592891: Fix SIP2 standing penalty failures
Jeff Godin [Wed, 15 Jun 2016 16:25:24 +0000 (12:25 -0400)]
LP#1592891: Fix SIP2 standing penalty failures

Update too_many_overdue and excessive_fines in OpenILS::SIP::Patron
to account for the fact that the user object in this context no
longer contains an array of ausp objects, but just an array of ausp
IDs.

This fixes SIP2 failures with patron information messages when a
patron has one or more blocking penalties that are not otherwise
ignored.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1592891: tweak tests
Galen Charlton [Thu, 16 Jun 2016 00:16:52 +0000 (20:16 -0400)]
LP#1592891: tweak tests

This patch wraps the standing penalty checks in evals so that if they
crash, the test script can carry on -- and make it to the point where
it cleans up the standing penalties it adds.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1592891: Tests - SIP2 standing penalty failures
Jeff Godin [Wed, 15 Jun 2016 17:46:09 +0000 (13:46 -0400)]
LP#1592891: Tests - SIP2 standing penalty failures

Tests for SIP2 standing penalty failures in LP#1592891

Much of the code in these tests was copied or adapted from Jason
Stephenson's tests in 14-lp1499123_csp_ignore_proximity.t

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoForward port 2.9.5 to 2.9.6 upgrade script.
Jason Stephenson [Wed, 15 Jun 2016 19:08:53 +0000 (15:08 -0400)]
Forward port 2.9.5 to 2.9.6 upgrade script.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
4 years agoLP#1592565 Log successful authtoken and workstation
Bill Erickson [Tue, 14 Jun 2016 20:16:08 +0000 (16:16 -0400)]
LP#1592565 Log successful authtoken and workstation

Recover a previously existing activity log entry that logged the
username, authtoken, and workstation (when available) for successful
logins.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jeff Godin <jgodin@tadl.org>
4 years agoLP#1554714: Set angular 1.5.5 as minimum, not exact version
Ben Shum [Wed, 8 Jun 2016 11:41:30 +0000 (07:41 -0400)]
LP#1554714: Set angular 1.5.5 as minimum, not exact version

By adding the ~ in front of the angular version specified, we say
make this the minimum version to look for.  This bypasses the issue
for when new releases of the 1.5.x angular series is released, such
as 1.5.6, which is the current new version as of this patch.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1526858: Stamping upgrade script for faster alhr query
Kathy Lussier [Fri, 10 Jun 2016 15:51:41 +0000 (11:51 -0400)]
LP#1526858: Stamping upgrade script for faster alhr query

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1526858: speed up queries for shelf-expired holds during checkin
Galen Charlton [Wed, 16 Dec 2015 16:03:42 +0000 (11:03 -0500)]
LP#1526858: speed up queries for shelf-expired holds during checkin

This patch adds indexes on action.hold_request and tweaks
the definition of the alhr IDL view to more efficiently
identify holds that can be canceled if the "Clear Holds Shelf"
checkin modifier is in use.  This can prevent a problem
where such checkins can time out in very large databases.

The tweaks were created by Jason Etheridge and have been in
production at a large consortium for some time.

To test
-------
[1] With a suitably large database, set up an item that
    is on the holds shelf but has passed its shelf-expiration
    time, then check it in using the "Clear Holds Shelf" modifier.
[2] The checkin may fail with a "network failure" message due
    the query on the alhr timing out.
[3] Apply the patch and repeat step 1. This time, the checkin
    should succeed.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoAdds two missing link fields (patron profile and patron home library) to
Codey Kolasinski [Mon, 16 May 2016 13:28:09 +0000 (09:28 -0400)]
Adds two missing link fields (patron profile and patron home library) to
the fm_idl.xml for the Combined Active and Aged Circulations (combcirc)
reporter source. The fix was originally posted in a comment to the
Launchpad bug by Codey Kolasinski.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1566016: remove SSN as a stock ident type
Galen Charlton [Mon, 4 Apr 2016 21:31:58 +0000 (17:31 -0400)]
LP#1566016: remove SSN as a stock ident type

This patch removes the SSN (Social Security Number) as a stock
patron identification type, as it is no longer recommended
practice for libraries to store SSNs.

To test:

[1] Verify that in a fresh installation of Evergreen that
    has this patch in place, that SSN is no longer listed
    as a patron identification type.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1373578: fix translatability of hold placement errors
Galen Charlton [Mon, 23 May 2016 16:29:04 +0000 (12:29 -0400)]
LP#1373578: fix translatability of hold placement errors

This patch fixes a circumstance where ->maketext() could be
passed an empty string, causing it to emit the PO file header text
rather than a desired string.

To test
-------
[1] Configure Evergreen to use a TPAC localization (e.g.,
    the Czech translation).
[2] Enable the "Has Local Copy Alert" library setting.
[3] In the OPAC, change locale and attempt to place a
    hold that would trigger the alert saying that there's
    already a local copy available.
[4] Note that the alert reads as "Project-Id-Version: evergreen
    Report-Msgid-Bugs-To: ..."
[5] Apply the patch.
[6] Try step 3; this time the alert will be translated correctly,
    e.g., "Ve vaší domovské knihovně je již dostupný exemplář."

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
4 years agoLP 1548993: Remember the Show More/Fewer Details button selection.
Jason Stephenson [Thu, 26 May 2016 19:23:03 +0000 (15:23 -0400)]
LP 1548993: Remember the Show More/Fewer Details button selection.

The state of the Show More/Fewer Details button selection was
previously not remembered across searches or across changes to
advanced search.  This commit attempts to remedy that.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP 1548993: Restore Show More/Show Fewer Details button functionality.
Jason Stephenson [Thu, 19 May 2016 19:53:48 +0000 (15:53 -0400)]
LP 1548993: Restore Show More/Show Fewer Details button functionality.

When using a show_more_details.default setting of true in config.tt2,
the Show More/Show Fewer Details button functionality is broken.  The
detail record view is always shown, regardless of the button's state.
This patch attempts to repair the behavior so that the user can toggle
the detail record view even though the default is set to true.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years ago2.10.3-2.10.4 schema upgrade script
Galen Charlton [Wed, 25 May 2016 21:07:52 +0000 (17:07 -0400)]
2.10.3-2.10.4 schema upgrade script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agofix typos in 2.10.4 release notes
Galen Charlton [Wed, 25 May 2016 21:01:41 +0000 (17:01 -0400)]
fix typos in 2.10.4 release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoDocs: Adding 2.10.4 Point Release Notes
Kathy Lussier [Wed, 25 May 2016 15:29:22 +0000 (11:29 -0400)]
Docs: Adding 2.10.4 Point Release Notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1584801: fix tagging of previous circs in metarecord search results
Galen Charlton [Mon, 23 May 2016 14:29:09 +0000 (10:29 -0400)]
LP#1584801: fix tagging of previous circs in metarecord search results

This patch fixes a bug where previously-checked-out items were not
indicated as such in search results when doing a metarecord search.

To test:

[1] Ensure that the opac.search.tag_circulated_items library setting
    is enabled and that you are testing with a user that has opted-in
    to retaining circ history.
[2] Make a couple loans to that user.
[3] Log into the public catalog using that user.
[4] Perform a catalog search, choosing search terms such that
    the previously-loaned items appear in results.
[5] Verify that "I have checked this item out before" is displayed
    on the relevant hits.
[6] Click the "Group Formats and Editions" checkbox; note that
    after the page refreshes, previously-borrowed hits are /not/
    tagged.
[7] Apply the patch and restart the open-ils.search service.
[8] Repeat step 6; verify that this time previously-borrowed hits
    are tagged.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP1567514 - Don't Output Null Byte for Spool Files
Jason Boyer [Thu, 7 Apr 2016 16:08:09 +0000 (12:08 -0400)]
LP1567514 - Don't Output Null Byte for Spool Files

If a spool file is defined on the marc_stream_importer.pl
command line, no null byte is output after the record(s)
are processed.

To test:

[1] Use marc_stream_importer.pl to import a record from
    a file; verify that the output messages do not include
    a null character.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1517556 - Exclude inactive event defs from find_event_def_by_hook.
Josh Stompro [Wed, 30 Mar 2016 13:47:57 +0000 (08:47 -0500)]
LP#1517556 - Exclude inactive event defs from find_event_def_by_hook.

Currently when find_event_def_by_hook is called to find an appropriate
event_def based on the hook, it doesn't exclude inactive event defs.  So
strange behavior can happen if inactive event defs are present.

I ran into this issue when I was trying out different versions of the self
check receipt event def.  I had one ative and one inactive while I was
troubleshooting, and when the system would grab the inactive event def by
chance, the self check UI would freeze.  I think it is a resonable expectation
that an event def marked inactive doesn't get used by the system.

To test this out, clone one of the self check event defs, such as
"Self-Checkout Items Out Receipt" and mark the copy as inactive.  Now
go and trigger this event in the self check interface by attempting to
print from the Items Out screen.  It should now fail 50% of the time, since
both the active and inactive defs are returned.

After the fix the inactive event def will always be excluded, so the action
should no longer fail.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1580676: fix error message
Galen Charlton [Tue, 24 May 2016 17:27:05 +0000 (13:27 -0400)]
LP#1580676: fix error message

This patch fixes a typo in the error message presented
if the queued record could not be cleaned up for some
reason; it also reports the correct type of the record.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1580676 MARC stream authority cleanup repair
Bill Erickson [Wed, 11 May 2016 16:19:12 +0000 (12:19 -0400)]
LP#1580676 MARC stream authority cleanup repair

Delete the successfully imported authority record from the vandelay
authority queue instead of the bib record that happens to have the same
ID as the imported authority record.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1447746: Fix lp957466_update_date_and_source regression test
Kathy Lussier [Mon, 23 May 2016 23:17:36 +0000 (19:17 -0400)]
LP#1447746: Fix lp957466_update_date_and_source regression test

The new code introduced through LP1447746 adding an update_bib_source flag to
Vandelay merge profiles broke a test that was verifying the bib source and
edit fields were updated in Vandelay uploads.

This patch fixes the test and also adds a new test to ensure the flag works as
expected when set to both true and false. It also renames the test since the
it's now testing the newer code rather than the previous expected behavior.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
4 years agoLP#1554714 Add explicit phantomjs-prebuilt dependency
Bill Erickson [Thu, 19 May 2016 18:28:11 +0000 (14:28 -0400)]
LP#1554714 Add explicit phantomjs-prebuilt dependency

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
4 years agoLP#1554714 Ang. 2.5 hotkeys plugin update
Bill Erickson [Thu, 19 May 2016 20:25:12 +0000 (16:25 -0400)]
LP#1554714 Ang. 2.5 hotkeys plugin update

As with other dependencies, the hotkeys package name changed since the
last update.  It's now cfp-angular-hotkeys

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
4 years agoLP 1499123: 0951.schema.config.standing_penalty.ignore_proximity.sql.
Jason Stephenson [Thu, 19 May 2016 14:33:18 +0000 (10:33 -0400)]
LP 1499123: 0951.schema.config.standing_penalty.ignore_proximity.sql.

The script was not inserting the version into config.upgrade_log when
run standalone because the line to do so was still commented out.
This commit removes the comment characters.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoForward port 2.9.4 to 2.9.5 db upgrade script.
Jason Stephenson [Wed, 18 May 2016 18:36:15 +0000 (14:36 -0400)]
Forward port 2.9.4 to 2.9.5 db upgrade script.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
4 years agoDocs: Adding 2.9.5 Release Notes
Kathy Lussier [Wed, 18 May 2016 13:55:55 +0000 (09:55 -0400)]
Docs: Adding 2.9.5 Release Notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP1497374 fm_IDL.xml metabib::record_attr_flat contains an incorrect link
blake [Fri, 18 Sep 2015 17:24:28 +0000 (12:24 -0500)]
LP1497374 fm_IDL.xml metabib::record_attr_flat contains an incorrect link

Corrected the link in fm_IDL.xml. Also added a link to metabib::record_attr_flat
in biblio::record_entry

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1447746 Stamping upgrade script for update-bib-source flag in Vandelay
Kathy Lussier [Thu, 12 May 2016 20:49:11 +0000 (16:49 -0400)]
LP#1447746 Stamping upgrade script for update-bib-source flag in Vandelay

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1447746: Do not update bib source on match-only merge
Dan Pearl [Thu, 4 Feb 2016 17:46:46 +0000 (12:46 -0500)]
LP#1447746: Do not update bib source on match-only merge

This adds a flag to control the updating of the bib source on a vandelay operation.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1578716 Fix Responsive Items Out
Dan Wells [Thu, 5 May 2016 15:58:52 +0000 (11:58 -0400)]
LP#1578716 Fix Responsive Items Out

With "Title" and "Author" as separate columns, here is a quick fix
to get the responsive labels to line up again.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <ben@evergreener.net>
4 years agorelease notes for 2.10.3
Galen Charlton [Mon, 9 May 2016 21:03:20 +0000 (17:03 -0400)]
release notes for 2.10.3

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years ago2.10.2 to 2.10.3 schema upgrade script
Galen Charlton [Mon, 9 May 2016 21:08:40 +0000 (17:08 -0400)]
2.10.2 to 2.10.3 schema upgrade script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1579225: fix handling of passwords in patron registration
Galen Charlton [Sat, 7 May 2016 01:40:12 +0000 (21:40 -0400)]
LP#1579225: fix handling of passwords in patron registration

This patch improves how the new password hashing is invoked
by open-ils.actor.patron.update; in particular, it fixes
a problem whereby newly registered patrons could not
log in.  It also fixes other issues:

- actor.usr.passwd would be set to an MD5 of the password
  for new users, vitiating the strong hashes in actor.passwd
- certain types of updates via patron registration, such as
  adding or deleting addresses, could result in the patron's
  password getting doubly-hashed, thereby locking them out
  of their account.

To test
-------
[1] Register a new patron; verify that they can log in.
[2] Edit an existing patron and change their password; verify
    that they can log in.
[3] Edit an existing patron but do NOT change their password;
    verify that they can still log in.
[4] Inspect the actor.usr rows for these patrons and verify
    that actor.usr.passwd is set to the value MD5(''), not
    the MD5 of their password.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1579225: add live_t regression test
Galen Charlton [Mon, 9 May 2016 20:40:52 +0000 (16:40 -0400)]
LP#1579225: add live_t regression test

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1551084: Add 16.04 version notes in server_upgrade doc
Ben Shum [Wed, 4 May 2016 17:22:28 +0000 (13:22 -0400)]
LP#1551084: Add 16.04 version notes in server_upgrade doc

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 years agoLP#1551084: Fixup typo for ubuntu-xenial-developer
Ben Shum [Tue, 19 Apr 2016 14:36:39 +0000 (10:36 -0400)]
LP#1551084: Fixup typo for ubuntu-xenial-developer

Jason spotted a typo. Can probably squash this in later.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 years agoLP#1551084: Update README to include references for 'ubuntu-xenial'
Ben Shum [Mon, 29 Feb 2016 06:30:29 +0000 (01:30 -0500)]
LP#1551084: Update README to include references for 'ubuntu-xenial'

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 years agoLP#1551084: Start new Makefile target for 'ubuntu-xenial'
Ben Shum [Mon, 29 Feb 2016 06:20:34 +0000 (01:20 -0500)]
LP#1551084: Start new Makefile target for 'ubuntu-xenial'

For Ubuntu 16.04, let's start a new Makefile target for 'ubuntu-xenial'

For major changes, the packaged version of PostgreSQL that ships with
Ubuntu 16.04 is PostgreSQL 9.5.

Also, during the configure step, the build process looks for libpcre3-dev,
so we add that as an additional prerequisite now.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 years agoLP#1551084: Symlink for 000.english.pg95.fts-config.sql
Ben Shum [Mon, 29 Feb 2016 06:14:38 +0000 (01:14 -0500)]
LP#1551084: Symlink for 000.english.pg95.fts-config.sql

We need this so that the eg_db_config script can make the Evergreen
database with PostgreSQL 9.5 systems.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 years agoLP#1568046: Stamping upgrade script for changes to permission.grp_ancestors
Ben Shum [Wed, 4 May 2016 16:59:01 +0000 (12:59 -0400)]
LP#1568046: Stamping upgrade script for changes to permission.grp_ancestors

Signed-off-by: Ben Shum <ben@evergreener.net>
4 years agoLP#1568046: Fix some mistakes in previous commit.
Jason Stephenson [Fri, 8 Apr 2016 19:30:32 +0000 (15:30 -0400)]
LP#1568046: Fix some mistakes in previous commit.

Looks like a few thinkos crept in from it being dashed off in a hurry.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
4 years agoLP#1568046: Use CTE instead of connectby for group tree queries
Mike Rylander [Fri, 8 Apr 2016 18:49:10 +0000 (14:49 -0400)]
LP#1568046: Use CTE instead of connectby for group tree queries

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
4 years agoLP#1031335 No-op the escape_email_header helper
Dan Scott [Wed, 7 Jan 2015 23:22:22 +0000 (18:22 -0500)]
LP#1031335 No-op the escape_email_header helper

As suggested by Mike Rylander, keep the escape_email_header helper
around to avoid breaking templates that already adopted it, but make it
a no-op as the SendEmail reactor now encodes the email headers of
interest by default.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agoFix LP#1031335 by escaping some email headers automatically
Pasi Kallinen [Wed, 24 Jul 2013 06:28:13 +0000 (09:28 +0300)]
Fix LP#1031335 by escaping some email headers automatically

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agoAdd entries to .mailmap.
Jason Stephenson [Fri, 29 Apr 2016 11:48:44 +0000 (07:48 -0400)]
Add entries to .mailmap.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
4 years agoForward port 2.9.3 to 2.9.4 db upgrade script.
Jason Stephenson [Thu, 28 Apr 2016 23:32:47 +0000 (19:32 -0400)]
Forward port 2.9.3 to 2.9.4 db upgrade script.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
4 years agoAdding 2.8.7 -> 2.8.8 DB upgrade script
Bill Erickson [Thu, 28 Apr 2016 19:51:47 +0000 (15:51 -0400)]
Adding 2.8.7 -> 2.8.8 DB upgrade script

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years ago2.10.1 to 2.10.2 schema upgrade script
Galen Charlton [Thu, 28 Apr 2016 17:15:42 +0000 (13:15 -0400)]
2.10.1 to 2.10.2 schema upgrade script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoupdates to the 2.10.2 release notes
Galen Charlton [Thu, 28 Apr 2016 16:26:19 +0000 (12:26 -0400)]
updates to the 2.10.2 release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoAdding 2.10.2 point release notes
Kathy Lussier [Thu, 28 Apr 2016 13:27:16 +0000 (09:27 -0400)]
Adding 2.10.2 point release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoupdate release notes for 2.9.4
Galen Charlton [Thu, 28 Apr 2016 16:21:50 +0000 (12:21 -0400)]
update release notes for 2.9.4

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoAdding 2.9.4 release notes
Kathy Lussier [Thu, 28 Apr 2016 12:47:05 +0000 (08:47 -0400)]
Adding 2.9.4 release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoupdates to 2.8.8 release notes
Galen Charlton [Thu, 28 Apr 2016 16:20:45 +0000 (12:20 -0400)]
updates to 2.8.8 release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoPoint release notes for the 2.8.8 release
Kathy Lussier [Thu, 28 Apr 2016 12:35:43 +0000 (08:35 -0400)]
Point release notes for the 2.8.8 release

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1562153: fix case where changing sort order to relevance can fail
Galen Charlton [Fri, 25 Mar 2016 20:46:24 +0000 (16:46 -0400)]
LP#1562153: fix case where changing sort order to relevance can fail

This patch fixes a cause where sending a 'sort' CGI parameter
with the empty string as value (which specifies relevance sorting)
fails to override a previously-set sort order.

To test:

[1] Do a public catalog search starting from the advanced search form,
    e.g., keyword = "cats"
[2] Change the sort order to (say) Title A-Z from the results page.
[3] Note that the query string changes to "sort(titlesort) cats" and
    that the results are re-sorted
[4] Attempt to change the sort order to relevance.
[5] This time, the sort order does not change ... and it should have.
[6] Apply the patch and repeat steps 1-5. This time, the sort order
    should be successfully changed.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#1562153: add regression test
Galen Charlton [Fri, 25 Mar 2016 20:44:15 +0000 (16:44 -0400)]
LP#1562153: add regression test

This patch adds a regression test for successfully
overrding the sort order in a query from a 'sort' CGI
parameter.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#1563531: add libpcre3/libpcre3-dev deps for Jessie
Galen Charlton [Wed, 30 Mar 2016 17:29:10 +0000 (13:29 -0400)]
LP#1563531: add libpcre3/libpcre3-dev deps for Jessie

This patch adds libpcre3 and libpcre3-dev to the list
of packages installed when installing Evergreen on Debian
Jessie. Evergreen's direct dependency on libpcre3 is new in 2.10
(see bug 1468422); it happens that libpcre3 and libpcre3-dev
are installed on Wheezy by virtue of a different dependency
chain.

To test
-------
[1] On a fresh Debian Jessie netinstall, follow the OpenSRF
    and Evergreen installation instructions. Verify that with
    this patch in place, Evergreen's "configure" step succeeds.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#1568195: Stamping upgrade script
Mike Rylander [Thu, 28 Apr 2016 15:54:28 +0000 (11:54 -0400)]
LP#1568195: Stamping upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#1568195: fix retrieving big OUS batches
Galen Charlton [Sat, 9 Apr 2016 01:46:35 +0000 (21:46 -0400)]
LP#1568195: fix retrieving big OUS batches

This patch fixes a regression introduced in LP#1501471
where the Library Settings Editor could fail to retrieve
the values of org unit settings if more than 99 were
requested at a time.

To test
-------
[1] Open the XUL library settings editor and ensure that
    no search filters are in effect. Note that values
    are not displayed for any of the OU settings, and that
    the Pg log contains error messages like this:

    "ERROR: cannot pass more than 100 arguments to a function"

[2] Apply the patch.
[3] Repeat step one, and verify that values are now retrieved
    for all of the OU settings that have values set.
[4] Verify that the pgTAP tests in live_t/aous_batch.pg pass.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#1569884: stamp schema update
Galen Charlton [Thu, 28 Apr 2016 15:31:20 +0000 (11:31 -0400)]
LP#1569884: stamp schema update

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1569884: fix schema update script
Galen Charlton [Thu, 28 Apr 2016 15:27:11 +0000 (11:27 -0400)]
LP#1569884: fix schema update script

CREATE INDEX cannot run concurrently in a transaction
block period, at least as of 9.4.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1569884 Fix two problems in previous commit.
Jason Stephenson [Wed, 27 Apr 2016 19:43:31 +0000 (15:43 -0400)]
LP#1569884 Fix two problems in previous commit.

The CREATE TABLE biblio.monograph_part statement in
010.schema.biblio.sql ended up with a trailing comma.

The CREATE UNIQUE INDEX on biblio.monograph_part cannot be done
CONCURRENTLY at DB creation time, apparently.  At least not on
PostgreSQL 9.3.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1569884 Updated base schema with monograph parts index.
Steven Callender [Wed, 27 Apr 2016 16:05:48 +0000 (12:05 -0400)]
LP#1569884 Updated base schema with monograph parts index.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1569884 Allow deleted monograph parts to be recreated.
Steven Callender [Wed, 13 Apr 2016 15:15:27 +0000 (11:15 -0400)]
LP#1569884 Allow deleted monograph parts to be recreated.

Changed the constraint on the biblio.monograph_part table to allow for a
monograph part to be created if a duplicate deleted version is found.

To test:

[1] Add a monograph part to a bib.
[2] Delete that monograph part.
[3] Attempt to add a monograph part to the same bib using
    the same part label. Without the patches installed, this
    will fail; upon applying the database update, this operation
    should succeed.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1569884: add regression test
Galen Charlton [Thu, 28 Apr 2016 15:20:29 +0000 (11:20 -0400)]
LP#1569884: add regression test

This pgTAP test verifies that if you logically delete a monograph part,
you can subsequently add a new one with the same label as that of the
deleted one.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1564079 Stamping upgrade script
Kathy Lussier [Wed, 27 Apr 2016 14:35:49 +0000 (10:35 -0400)]
LP#1564079 Stamping upgrade script

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1564079 Checkout history skips nonexistent items
Bill Erickson [Wed, 30 Mar 2016 21:57:59 +0000 (17:57 -0400)]
LP#1564079 Checkout history skips nonexistent items

Modify the user checkout history migration process
(2.9.3-2.10.0-upgrade-db.sql and 0960.schema.decouple_co_history.sql) to
avoid inserting history rows for circulations whose copies do not
exist in the database.

For reference, this is a rare condition that cannot be recreated in a
modern EG system short of modifying constraints.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agoLP#1564079 Checkout history handles serials
Bill Erickson [Wed, 30 Mar 2016 21:49:26 +0000 (17:49 -0400)]
LP#1564079 Checkout history handles serials

Remove the target_copy foreign key constraint on action.usr_circ_history
so that it does not prevent creation of rows from circulation's that
link to serial.unit objects.  Similar to action.circulation, the foreign
key constraint is enforced via a evergreen.fake_fkey_tgr trigger
instead.

This modifies the 2.9.3-2.10.0-upgrade-db.sql and 0960 upgrade scripts,
since without this change, the scripts may fail.

A separate upgrade script is added to drop the constraint for those who
have already successfully run the the 2.9.3-2.10.0-upgrade-db.sql script
(i.e. those who don't use serials).  For simplicity, the
evergreen.fake_fkey_tgr trigger is only applied in this separate upgrade
script (in addition to the base schema, of course).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
4 years agofixing missing newline user/sandbergja/cataloging_docs
Jane Sandberg [Tue, 26 Apr 2016 17:23:14 +0000 (10:23 -0700)]
fixing missing newline

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 years agoLP954213 adding MARC Editor documentation somewhat based on 2.1
Jane Sandberg [Wed, 16 Mar 2016 04:44:57 +0000 (21:44 -0700)]
LP954213 adding MARC Editor documentation somewhat based on 2.1

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 years agoLP1494346: Docs syntax error
Jane Sandberg [Tue, 15 Mar 2016 18:59:44 +0000 (11:59 -0700)]
LP1494346: Docs syntax error

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 years agoresolving merge conflict
Jane Sandberg [Tue, 15 Mar 2016 18:50:30 +0000 (11:50 -0700)]
resolving merge conflict

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 years agoAdding more information about authorities+Vandelay
Jane Sandberg [Tue, 15 Mar 2016 18:36:01 +0000 (11:36 -0700)]
Adding more information about authorities+Vandelay

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 years agoLP#1559121: remove Debian Squeeze support
Galen Charlton [Fri, 18 Mar 2016 14:34:40 +0000 (10:34 -0400)]
LP#1559121: remove Debian Squeeze support

Now that Debian Squeeze's LTS (long-term support) period
has ended, Evergreen no longer offers community support
for that distribution. This patch removes references
to Squeeze from the installation scripts and documentation.

To test:

[1] Verify that Debian Squeeze is no longer referenced in
    the installation documentation.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
Conflicts:
docs/installation/server_upgrade.txt

4 years agoDocs: clean up formatting & typos in using_the_public_access_catalog.txt
Yamil Suarez [Fri, 22 Apr 2016 20:51:20 +0000 (16:51 -0400)]
Docs: clean up formatting & typos in using_the_public_access_catalog.txt

Thanks to Anna Goben for these fixes.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
4 years agoLP#1554714: update to latest Collapse attribute
Galen Charlton [Wed, 20 Apr 2016 15:20:36 +0000 (11:20 -0400)]
LP#1554714: update to latest Collapse attribute

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1554714: final $modal => $uibModal
Galen Charlton [Wed, 20 Apr 2016 15:11:47 +0000 (11:11 -0400)]
LP#1554714: final $modal => $uibModal

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1554714: more drop-down fixes
Galen Charlton [Wed, 20 Apr 2016 15:07:43 +0000 (11:07 -0400)]
LP#1554714: more drop-down fixes

Should be the last of them.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1554714: specify resolution to make angular-animate happy
Galen Charlton [Wed, 20 Apr 2016 15:03:06 +0000 (11:03 -0400)]
LP#1554714: specify resolution to make angular-animate happy

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1554714: fix up more drop-down menus
Galen Charlton [Wed, 20 Apr 2016 14:50:27 +0000 (10:50 -0400)]
LP#1554714: fix up more drop-down menus

This patch intentionally doesn't change templates
under cat/; that will come later.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1554714: (indirectly) bump up PhantomJS version
Galen Charlton [Wed, 20 Apr 2016 14:19:40 +0000 (10:19 -0400)]
LP#1554714: (indirectly) bump up PhantomJS version

It turns out that PhantomJS 2 or later is required for
angular-mocks to succesfully inject dependencies; this patch
updates karma-phantomjs-launcher to a version that will
bring in a recent-enough version of PhantomJS.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1554714 Ang 1.5 org unit dropdown repair
Bill Erickson [Thu, 14 Apr 2016 14:36:13 +0000 (10:36 -0400)]
LP#1554714 Ang 1.5 org unit dropdown repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1554714 ng-date-input -> eg-date-input typo
Bill Erickson [Thu, 14 Apr 2016 14:19:24 +0000 (10:19 -0400)]
LP#1554714 ng-date-input -> eg-date-input typo

We're using eg-date-input, not ng-date-input.

Thanks to Mike Rylander for pointing this out.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1554714 Ang. 1.5 navbar menu repairs
Bill Erickson [Thu, 17 Mar 2016 14:26:42 +0000 (10:26 -0400)]
LP#1554714 Ang. 1.5 navbar menu repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1554714 Ang 1.5 requires service to return an object
Bill Erickson [Wed, 16 Mar 2016 22:10:12 +0000 (18:10 -0400)]
LP#1554714 Ang 1.5 requires service to return an object

Return a {} from the dummy patronSvc service used by the standalone
patron editor.  Ang 1.5 requires services to return non-null.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1554714 eg-date-input relays ng-blur
Bill Erickson [Wed, 16 Mar 2016 22:09:51 +0000 (18:09 -0400)]
LP#1554714 eg-date-input relays ng-blur

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1554714 Migrate eg-date-input to ui-datepicker-popup
Bill Erickson [Thu, 10 Mar 2016 18:08:00 +0000 (13:08 -0500)]
LP#1554714 Migrate eg-date-input to ui-datepicker-popup

Also add support for uib-timepicker as an option secondary component of
the input.

Refactor existing use of eg-date-input to use <eg-date-input/>-style
declaration to better differentiate between a normal <input> and the
more complete/stylized date input div.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1554714 Patron reg DoB via datepicker
Bill Erickson [Wed, 9 Mar 2016 19:00:27 +0000 (14:00 -0500)]
LP#1554714 Patron reg DoB via datepicker

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1554714 Patron reg DoB parse month bug repair
Bill Erickson [Wed, 9 Mar 2016 19:01:31 +0000 (14:01 -0500)]
LP#1554714 Patron reg DoB parse month bug repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1554714 Patron reg 1.5 controller consolidation
Bill Erickson [Wed, 9 Mar 2016 13:38:41 +0000 (08:38 -0500)]
LP#1554714 Patron reg 1.5 controller consolidation

Angular 1.4+ requires that each controller be instantiated via the
module.controller() function.  No more global functions.  The patron
reg. controller, shared by 2 different modules, was defined as a global
function.  Resolve this by hanging it off the core module (when loaded).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1554714 angular-bootstrap 1.4 uibModal migration
Bill Erickson [Tue, 8 Mar 2016 21:12:48 +0000 (16:12 -0500)]
LP#1554714 angular-bootstrap 1.4 uibModal migration

angular-bootstrap's $modal module is now known as $uibModal.  Ditto
$uibModalInstance.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1554714 Browser client dependency updates note
Bill Erickson [Tue, 8 Mar 2016 21:01:15 +0000 (16:01 -0500)]
LP#1554714 Browser client dependency updates note

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1554714 Angular 1.5 + deps bower.json updates
Bill Erickson [Tue, 8 Mar 2016 20:58:33 +0000 (15:58 -0500)]
LP#1554714 Angular 1.5 + deps bower.json updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoDocs: Screenshots and step by step instructions added to Self Check section
Jennifer Pringle [Fri, 22 Apr 2016 03:02:21 +0000 (20:02 -0700)]
Docs: Screenshots and step by step instructions added to Self Check section

Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>