scottmk [Wed, 10 Mar 2010 19:41:50 +0000 (19:41 +0000)]
1. Eliminate somed source_definitions from the IDL where there is already
an equivalent view. In the presence of a tablename attribute, the
source_definitions were being ignored anyway. This step applies to classes
aufhl, aufhml, and aufhil.
2. For class aufhmxl: the IDL had both a tablename and a source_definition,
but there was no table or view corresponding to the tablename.
I eliminated the source_definition and created the corresponding view
action.unfulfilled_hold_max_loop.
3. For class aufhol: the IDL had both a tablename and a source_definition,
but neither was valid. The tablename didn't exist in the database, and the
source_definition referenced the action.unfulfilled_hold_max_loop view, which
didn't exist. I removed the tablename attribute and left the source_definition
in place, which is now valid because in step 2 I created the missing view.
4. Unrelated: added 201.acq.audit-functions.sql to the list of installation
scripts to run in build-db.sh.
M Open-ILS/src/sql/Pg/090.schema.action.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0185.schema.acq.aufhmxl-view.sql
M Open-ILS/src/sql/Pg/build-db.sh
M Open-ILS/examples/fm_IDL.xml
miker [Wed, 10 Mar 2010 19:20:30 +0000 (19:20 +0000)]
Reworking of a patch from Ben Ostrowsky: add an OILSProxyLoginOU Directory config option for apache to supply a pinned workstation OU for permission checking
erickson [Tue, 9 Mar 2010 20:24:14 +0000 (20:24 +0000)]
* Using lineitem estimated_unit_price to store the price instead of the lineitem attrs
* If necessary, perform the currency conversion exactly once, when the order is activated. Otherewise, assume the price is in the currency of the vendor.
* Create fund debits during PO activation instead of PO creation time.
* Cleared out a pile of deprecated code
* TODO: update JEDI template to pull price from the estimated_price_field
miker [Tue, 9 Mar 2010 18:55:13 +0000 (18:55 +0000)]
teach vandelay.strip_field() how to handle lists of complex field specs (ie: 100d,245c,650); add vandelay.add_field() which will transfer fields from an incoming record to an incumbent record; add vandelay.replace_field() and vandelay.preserve_field(), which are wrappers that use strip and add
scottmk [Tue, 9 Mar 2010 17:22:52 +0000 (17:22 +0000)]
1. Add estimated_unit_price column to acq.lineitem.
2. Bring acq.acq_lineitem_history and acq.acq_purchase_order_history
into sync with their respective source tables.
M Open-ILS/src/sql/Pg/200.schema.acq.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0183.schema.acq-cancel-reason-history.sql
M Open-ILS/examples/fm_IDL.xml
phasefx [Tue, 9 Mar 2010 17:05:16 +0000 (17:05 +0000)]
Ability to auto-generate barcodes in the Volume/Copy dialog. Takes the first barcode entered and generates subsequent barcodes using the typical library/codabar checkdigit algorithm if the barcodes are 13-14 digits, otherwise, just incrementing them without checkdigits.
erickson [Mon, 8 Mar 2010 21:29:50 +0000 (21:29 +0000)]
added auto_merge_vols option to open-ils.cat.asset.volume.fleshed.batch.update. when changing the label (or owner or bib) for a volume creates a collision against an existing volume, auto-merge (or override) will merge the contents of the edited volume into the existing volume
erickson [Mon, 8 Mar 2010 19:43:33 +0000 (19:43 +0000)]
added org util method to find the full path for an org unit, where the full path is all ancestors, the context org, and all children, as an ordered list of nodes or IDs.
dbs [Mon, 8 Mar 2010 19:25:53 +0000 (19:25 +0000)]
Make permissions for administering triggers more usable out of the box:
* Add CREATE/DELETE/UPDATE/VIEW variants to the generic ADMIN
* Add ADMIN/CREATE/DELETE/UPDATE trigger permissions to Local System Administrator group at System depth
* Add VIEW trigger permissions to Local System Administrator at Consortial depth to enable cloning
scottmk [Mon, 8 Mar 2010 15:53:07 +0000 (15:53 +0000)]
Add a cancel_reason column to acq.user_request, pointing to acq.cancel_reason.
Also: corrected the IDL entries for similar columns elsewhere. The <link>
should have a reltype of "might_have", not "has_a", since the column is nullable.
M Open-ILS/src/sql/Pg/200.schema.acq.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0181.schema.acq-user-request-cancel-cause.sql
M Open-ILS/examples/fm_IDL.xml
phasefx [Mon, 8 Mar 2010 15:31:03 +0000 (15:31 +0000)]
Batch barcode editing and copy (item attribute) editor tweaks. A few things here, and I apologize for not cherry-picking into separate commits:
* Modified the volume/copy creator to serve double-duty as an existing copy rebarcoder UI. This also gets us closer to being able to shove in existing pre-cats as an alternative cataloging workflow to transfering pre-cats to
targeted volumes.
* Tested this out as a Replace Barcode replacement in Holdings Maintenance, but the real motivator was for the Update Barcodes link for lineitems in acquisitions.
* The volume/copy interface now has two options, the new one bypasses the item attribute editor and creates or modifies the items instantly.
* Button labeling tweaks in the item attribute editor.
* Allow folks to change the item status for new copies. I can't recall the rationale for disallowing this in the first place, but I've heard enough arguments asking for us to allow this. If need be, we can wrap it in a perm if
folks do want to lock it down . We may also want to implement an org setting at some point for configuring the default status.
TODO: Replace "Replace Barcode" with this in Item Status UI
TODO: Allow batch call number editing. There's an existing UI for this, but we need something in the context of acquisitions for taking care of those autogenerated call numbers and barcodes in one shot.
erickson [Mon, 8 Mar 2010 13:59:56 +0000 (13:59 +0000)]
plugged in fund search format. it's like label format, except the search format gives us the type-ahead searching and it defines the format of the data in the value field of the select widget
scottmk [Sun, 7 Mar 2010 19:33:15 +0000 (19:33 +0000)]
Added comments; tinkered with white space here and there.
Rearranged the code a bit for clarity, without changing functionality.
In doFieldMapperSearch():
- Renamed meta to class_meta, in order to distiguish it from method metadata.
- Rename obj to row_obj, which is more descriptive, and moved its declaration
closer to its first use.
- Moved the declaration of dedup and links closer to their first uses.
In oilsMakeFieldmapperFromResult():
- Moved the declarations of several variables closer to their first uses.
- Eliminated a couple of unnecessary calls to memset().
scottmk [Fri, 5 Mar 2010 19:15:26 +0000 (19:15 +0000)]
Add a new permission, ADMIN_ACQ_CANCEL_CAUSE
Add two rows of seed data for acq.cancel_reason
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0180.data.acq.cancel-reasons.sql
M Open-ILS/src/sql/Pg/950.data.seed-values.sql
M Open-ILS/examples/fm_IDL.xml
erickson [Fri, 5 Mar 2010 16:47:53 +0000 (16:47 +0000)]
added support for overriding the searchAttr in addition the labelAttr. This is necessary when using HTML labelAttrs, which do not work in type-ahead or in display fields
scottmk [Thu, 4 Mar 2010 22:11:29 +0000 (22:11 +0000)]
Add a cancel_reason column to acq.lineitem_detail, pointing to
acq.cancel_reason. See KCLS ticket #3015.
M Open-ILS/src/sql/Pg/200.schema.acq.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0178.schema.acq.lid-cancel-reason.sql
M Open-ILS/examples/fm_IDL.xml
scottmk [Thu, 4 Mar 2010 21:31:55 +0000 (21:31 +0000)]
Create new table acq.cancel_reason.
Create new columns pointing to it in acq.purchase_order and
acq.lineitem.
See KCLS ticket #3015.
M Open-ILS/src/sql/Pg/200.schema.acq.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0177.schema.cancel_reason.sql
M Open-ILS/examples/fm_IDL.xml
M Open-ILS/src/sql/Pg/200.schema.acq.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0176.schema.acq.claim_interval.sql
M Open-ILS/examples/fm_IDL.xml
phasefx [Thu, 4 Mar 2010 15:27:56 +0000 (15:27 +0000)]
When the patron search interface is spawned from the patron registration interface for listing potential duplicate patrons, correctly handle the horizontal patron summary setting.
scottmk [Thu, 4 Mar 2010 05:04:58 +0000 (05:04 +0000)]
Slightly rearranged the treatment of transaction ids so as to avoid
repeated calls to getXactId(). Also: when committing or rolling back,
return the transaction id from getXactId() instead of referencing the
session_id of the application session.
In dispatchCRUDMethod: Added comments. Renamed meta to method_meta
to distinguish it from class metadata. Avoid unnecessary lookups of
the class metadata. Rearrange things a bit for clarity.
scottmk [Tue, 2 Mar 2010 00:49:43 +0000 (00:49 +0000)]
1. Renamed getSourceDefinition() to getRelation(), since "SourceDefinition"
could be taken to refer to a subquery defined in the IDL.
2. In getRelation(): when returning a source_definition instead of a table name
or view name, build it in a single allocated buffer instead of a growing_buffer,
in order to save a malloc() and free().
3. In osrfAppChildInit(): Use and reuse a single growing_buffer to build the
SELECT statements, instead of allocating and freeing one repeatedly.
4. In osrfAppChildInit(): if getRelation() returns NULL, skip the class and go
on to the next one, since any attempt to SELECT from it is doomed anyway.
5. In osrfAppChildInit(): eliminate several unnecessary casts.
phasefx [Mon, 1 Mar 2010 22:18:16 +0000 (22:18 +0000)]
In PO Events UI, change Target ID column into a Purchase Order column linking to the PO View. Change deprecated dojo .getValue and .setValue to .attr in places
scottmk [Mon, 1 Mar 2010 16:21:08 +0000 (16:21 +0000)]
1. Fixed a bug in osrfAppInitialize(). After loading the method name into the
method metadata, we were deleting it. Any subsequent access of it invoked
undefined behavior. It was just our dumb luck that cstore didn't crash and
burn long ago.
2. Tidied up some of the white space.
3. Added doxygen-style comments to three of the functions.
These views are similar to the correspondingly named views without the
"all_" prefix (i.e. acq.fund_allocation_total, etc) except that the
return a row for every fund in acq.fund, even if the fund is not
represented in acq.fund_debit or acq.fund_allocation.
M Open-ILS/src/sql/Pg/200.schema.acq.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0173.schema.acq.all-fund-views.sql
M Open-ILS/examples/fm_IDL.xml
scottmk [Wed, 24 Feb 2010 21:23:37 +0000 (21:23 +0000)]
Created a new table acq.provider_note, similar to acq.po_note, but tied
to acq.provider instead of to acq.purchase_order.
Also: modified actor.usr_purge_data() to touch the foreign keys to
actor.usr when a user is purged.
M Open-ILS/src/sql/Pg/999.functions.global.sql
M Open-ILS/src/sql/Pg/200.schema.acq.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0172.schema.acq.provider-notes.sql
M Open-ILS/examples/fm_IDL.xml
senator [Wed, 24 Feb 2010 19:36:17 +0000 (19:36 +0000)]
Acq: separate LI note creation from LI alert creation; improve notes iface
Since adding LI notes or alerts takes place immediately, so does deleting
them now, so there's no more need for a Save Changes button on that interface.
erickson [Wed, 24 Feb 2010 19:30:44 +0000 (19:30 +0000)]
fetch user groups non-async to prevent clobbering expire date when group dijit updates with async data. set required var before it's used. don't require values in the password field for existing users
scottmk [Wed, 24 Feb 2010 14:34:32 +0000 (14:34 +0000)]
Add fax number, phone, url, email to certain provider-related tables.
M Open-ILS/src/sql/Pg/200.schema.acq.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0171.schema.acq.provider-phone-email.sql
M Open-ILS/examples/fm_IDL.xml
projects / working / Evergreen.git / log