Bill Erickson [Thu, 10 Jan 2019 17:11:41 +0000 (12:11 -0500)]
LP1806087 Org setting to enable experimental staff catalog
Adds a new org unit setting "GUI: Enable Experimental Angular Staff
Catalog" (ui.staff.angular_catalog.enabled). When set to true, a new
navbar menu item will appear in both the Angular and AngJS client menus
for "Staff Catalog (Experimental)". This action directs the user to the
Angular staff catalog.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Wed, 7 Nov 2018 15:18:31 +0000 (10:18 -0500)]
LP1806087 Angular staff catalog phase II.
* Record detail tabs redirect to AngJS catalog where needed.
* Initial holds placement UI.
* Record baskets, actions, and UI.
* Ported MonographParts tab to Angular
* Set default catalog tab
* Browse
* MARC search
* Identifier search
* pub date filter
* Record detail 'View in Catalog' button
* Group formats and editions
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Tue, 29 Jan 2019 16:15:38 +0000 (11:15 -0500)]
LP1813647 Angular page title component & sandbox example
Adds a new component <eg-title /> which may be used to pass strings to
the native Angular Title service.
Each title may have a prefix and/or a suffix. If both are defined, they
are separated by a "-" (by default / en-US) and the prefix is tructed to
12 characters, consistent with AngularJS strings.setPageTitle()
function.
Bill Erickson [Mon, 7 Jan 2019 21:35:15 +0000 (16:35 -0500)]
LP1779158 Always clear import selection
Clear the import selection (e.g. Queue => Import All Items) from the
import UI when the user navigates away, regardless of whether the import
succeeded. Otherwise, the import UI gets stuck in selection mode
requiring the user to manually clear it.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
* Fix some workstation setting names that were missing the 'eg.grid.*'
prefix
* Add workstation setting types for merge profile and attr definition
admin pages.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Fri, 4 Jan 2019 16:07:31 +0000 (11:07 -0500)]
LP1779158 Cache new queues / display active queues
* Only list active (non-complete) queues in the Vandelay queue selector
combobox.
* Display an alert message when the user attempts to create a queue
whose name collides with an existing queue for the user.
* Be sure newly created queues are added to the local cache of queues in
the Vandelay service.
* Remove unused activeQueue list from vandelay.service to avoid having
to maintain 2 separate queue caches.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Fri, 4 Jan 2019 16:05:17 +0000 (11:05 -0500)]
LP1779158 Angular alert dialog component
Similar to the PromptDialogComponent except it displays a simple message
(formatted as 'danger') and the only option available to the user is to
close the dialog.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Kyle Huckins [Tue, 18 Dec 2018 22:57:21 +0000 (22:57 +0000)]
lp1779158 Inspect Queue Improvements
- Add "Delete selected" option to Authority Queues
- Change Queuetype to 'authority' from 'auth' when selecting single record to view
in auth record queue.
- Ensure "Imported As" link correctly navigates to Auth record view for Auth Queues
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue-list.component.html
modified: Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue.component.html
modified: Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue.component.ts
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Kyle Huckins [Tue, 27 Nov 2018 21:07:35 +0000 (21:07 +0000)]
lp1779158 Vandelay Authority Import Tweaks
- Check for "Auth" string
- Dummy rec.import_items when record is not bib
- Teach resolveQueue() to assume startQueueId unless a queue is selected already
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/cat/vandelay/import.component.ts
modified: Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue.component.ts
modified: Open-ILS/src/eg2/src/app/staff/cat/vandelay/vandelay.service.ts
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
* Associate <input>'s with their labels in the import and export forms
* Hide the MARC removal groups selector when record type is authority.
* Disable ACQ copy overlay option when record type is authority.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Support saving MARC Import form values as named templates. Values are
stored as (by defualt) workstation settings. A template may be selected
as the default and templates may be deleted.
Includes release notes update angular vandelay.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Port of the MARC Import/Export UI from a Dojo-driven interface to a
Angular(6) interface.
Includes an additional UI called "Recent Imports" which displays
Vandelay session tracker information for both active sessions and those
within the selected time frame. Active sessions are updated regularly
to display progress to the user.
Includes grid persist key workstation settings.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Sam Link [Wed, 12 Dec 2018 16:35:20 +0000 (11:35 -0500)]
LP1802594 - Splash Page Image Alt Text
Added alt="evergreen" to the logo image on the splash page, and alt=""
role="presentation" to the icon images. This was done for both the AngJS
and Ang7 clients.
Signed-off-by: Sam Link <slink@LIBPC002> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Sat, 6 Oct 2018 12:52:09 +0000 (05:52 -0700)]
LP1796225: Only auto-focus search on the home page
For a11y and usability, it's better to autofocus form fields
only when they are the main purpose of a page.
To test:
1) In the public catalog, visit the search results, record view,
library details, basket, and password reset pages. Notice that
the cursor leaps to the search bar in each of these pages.
2) Apply this commit.
3) Re-visit all those pages. Notice that the cursor no longer
leaps to the search bar.
4) Visit the home page of the public catalog. Notice that the
cursor still leaps to the search bar on this page only.
Jason Boyer [Mon, 3 Dec 2018 18:23:39 +0000 (13:23 -0500)]
LP1799963: Adjust fix to Staff Default Adv Search
By moving the only assignment to $scope.catalog_url inside
an if(<url is advanced search>) then only the advanced search
page can load in the opac. By adding a second assignment
inside an else block all opac pages can load again.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Thu, 15 Nov 2018 14:59:44 +0000 (09:59 -0500)]
LP#1726568: expose circ lib and owning lib fields to spine/pocket labels
This patch fleshes the item circulation library and owning library
fields so that spine/pocket labels can include the short name or
full name of the OU rather than just the ID. As a consequence, the
following fields are now available for label templates:
If, for some reason, existing label templates intentionally use
copy['call_number.owning_lib'] or copy['circ_lib'] to include the numeric
ID of the OU on the label, they will need to be replaced with
copy['call_number.owning_lib.id'] or copy['circ_lib.id'] respectively.
To test
-------
[1] Apply the patch.
[2] Open the print labels window for an item and try including one
or more of the new fields listed above; verify that the current
value is displayed on the label preview.
Jeff Davis [Tue, 21 Aug 2018 20:01:06 +0000 (13:01 -0700)]
LP#1752665: suppress located URIs in holdings view
To test:
[1] Locate or create a bibliographic record that has at least
one located URI (e.g., an 856 with a $9 containing an org
unit code)
[2] View the record in the Holdings View in the web staff interface,
with the 'Show empty call numbers' (or volumes) option
selected.
[3] Note that rows are displayed with a call number label of '##URI##';
these are for the located URIs and should not be visible here.
[4] Apply the patch and repeat step 2. This time the '##URI##' entries
should not display.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
The Parent/Guardian feature altered the actor.usr_delete
function, but accidentally tries to update the "guardian"
field twice. This fixes that problem.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jeff Davis [Wed, 7 Feb 2018 23:11:18 +0000 (15:11 -0800)]
LP#1715767: Allow others to use my account (privacy waiver)
Use case: Jane Doe has a hold ready for pickup but is unable to come
into the library. Her husband John Doe goes to the library to pick up
the hold on her behalf. His name is listed on Jane's account, so
library staff know it's okay to check out the book on Jane's account and
give it to John.
This commit adds a new table which lists the names of people who are
allowed to place holds, pick up holds, check out items, or view
borrowing history for a user account. Staff can add, edit, or remove
entries via the patron editor in the web client; patrons can do so in My
Account. The entries are not linked to other user accounts and they do
not add any extra functionality. They are essentially special patron
notes for circulation staff.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
James Fournie [Thu, 17 Jan 2019 21:23:12 +0000 (13:23 -0800)]
LP1783421 - Make Copy Alerts permission not global
For some reason copy alerts require global permissions. Instead
update the IDL for asset.active_copy_alert and asset.copy_alert to
require {CREATE,VIEW,UPDATE,DELETE}_COPY_ALERT perms only as far as
they are scoped for the circ lib of the copy.
Signed-off-by: James Fournie <jfournie@vcc.ca> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Bill Erickson [Thu, 3 Jan 2019 15:17:42 +0000 (10:17 -0500)]
LP1809288 Angular fm-editor read-only additions
* Add read-only view to org-select
* FM editor displays read-only values as plain text
* Mark readOnly checkboxes "disabled"
* Link fields only fetch linked data when an IDL selector exists
* Minor code/style changes
** Define all class vars before class methods (ng-lint)
** Replace some tabs with spaces (ng-lint)
** Avoid unnecessary type defs with default values (ng-lint)
** More const goodness (ng-lint)
** camelCase some vars for consistentcy
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
The === null test for determining if a disableOnRows handler was set was
not broad enough to capture undefined values. This commit changes it to
a more generic if() test to cover null/undefined. Also, instead of
creating a dummy function in the action, the testing code checks for the
presence of the function at run time.
Apply a fix to an ng-lint warning introduced by this series of commits in
the sandbox code.
Rename the "disabled" attribute on toolbar-action to "disabeOnRows" to
better clarify the expected input value: function returning bool instead
of bool variable.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Fri, 14 Dec 2018 04:50:15 +0000 (20:50 -0800)]
LP1808268: Add [disable] option to <eg-grid-toolbar-action> in eg2
To test:
1) Apply this commit and recompile eg2.
2) Open the eg2 sandbox (https://yourdomain/eg2/staff/sandbox)
3) Ensure that the action called "Action that needs a single row"
is only enabled when one row of the grid is selected.
4) Create more <eg-grid-toolbar-actions> on grids in eg2. Make sure
that they all enable/disable those actions per the output of the
functions you reference in the [disabled] attribute.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Cesar Velez [Fri, 21 Sep 2018 15:46:59 +0000 (11:46 -0400)]
LP#1727345 - fix bibsource when importing or overlaying
This addresses several issues that were causing the
bib source to either not display correctly on the record page
or not save correctly when editing z3950 imports/overlays
Refactors passing around of bib source into eg-marc-edit and it's
child directive egMarcEditBibsource.
Two paths to test:
Path A)
1. Import a new bib record from z3950, but via "Edit then Import"
2. Bring up marc editor and choose save w/ bib source.
3. Verify chosen bib source saved correctly on record page.
Path B)
1. Mark a record as target for Overlay, go to z3950 import.
2. Make a search, select item for Overlay.
3. Choose Edit z3950 record to bring up marceditor, save with a bib source.
4. Verify chosen bib source saved correctly on record page.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Bill Erickson [Tue, 18 Dec 2018 15:50:26 +0000 (10:50 -0500)]
LP1807764 Angular grid gets datePlusTime option
Adds a new boolean datePlusTime option to the Angular grid column
configuration, informing the grid to display both date and time in the
cell for a datetype=timestamp column.
Includes sandbox example.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Fri, 7 Dec 2018 00:42:49 +0000 (16:42 -0800)]
LP1805856: Open records in new tabs
Catalogers have given the feedback that it's very helpful to have
certain records open in a new tab after they perform certain tasks.
This commit opens the relevant records in a new tab in the following
circumstances:
1) Cataloging > Z39.50 > Import > Go to record (previously opened in the
existing tab)
2) Cataloging > Z39.50 > Overlay > Overlay (previously did not open the
overlaid record at all)
3) Cataloging > Record Buckets > Merge (previously opened the lead
record in the existing tab)
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Jason Boyer <JBoyer@library.in.gov> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jason Boyer [Wed, 16 Jan 2019 13:36:40 +0000 (08:36 -0500)]
LP1742521: Receipt Count Repair
The div wrapping the receipt printing controls was
shown or hidden using an ng-if declaration which
created a new $scope as explained in bug 1696238,
which caused the controller to not notice that the
value was changed. Changing that to an ng-show
allows the updated value to get where it needs to
be.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Add a deprecation warning to the Hatch configuration page notifying
users that Hatch for storage is deprecated. Includes suggestions on how
to migrate away from Hatch for storage.
Remove the unusued "Use Hatch for Offline Files" option.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Cesar Velez [Fri, 7 Dec 2018 23:50:43 +0000 (18:50 -0500)]
LP1765179 - fix issue with pending/staged user reg
After completing a staged user registration, the controller
in regctl.js was refreshing to the same route, and
trying to fetch the same staged user, but never finding it
as it was no longer staged/pending. This addresses that bug
and adds a bChannel refresh to the pending grid, so once
the user is registered in the child tab, it closes the tab and
the pending user grid is updated.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
abneiman [Wed, 12 Dec 2018 19:48:35 +0000 (14:48 -0500)]
docs: LP1258628: screenshots & updates to actiontriggers.adoc
Added a handful of screenshots; added language for Message Center definitions, and pulled in language about testing action triggers from this document: http://docs.evergreen-ils.org/dev/_creating_action_triggers.html
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Thu, 27 Sep 2018 14:53:35 +0000 (07:53 -0700)]
LP1782652: Make template dropdown larger in Volume/Copy Editor
To test:
1) Open an item in the volume/copy editor.
2) Go to the Copy Templates tab. Note the spacing of the template bar.
3) Create a few templates. Give them names of 30 characters or more.
4) Go back to the Edit tab and select one of your new templates. Note
that after you have selected it, the name of your template does not fit
in the dropdown box, and is cut off at the end.
5) Apply this commit.
6) Go to the Copy Templates tab again. Note that the spacing of the
template bar has not changed.
7) Go to the Edit tab. Note that the template dropdown has changed
to be much larger.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Janet Schrader <jschrader@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
- Change record_type to TEXT rather than an enum, constrained
with the option of "authority" or "bib"
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/sql/Pg/012.schema.vandelay.sql
new file: Open-ILS/src/sql/Pg/upgrade/XXXX.schema.vandelay-record-type-fix.sql
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Jason Stephenson [Wed, 12 Dec 2018 18:24:01 +0000 (13:24 -0500)]
Lp 1730726: Fix lp1501781-unaccent_and_squash.pg for PostgreSQL 9.6
PostgreSQL 9.6 apparently exhibits the same behavior as Postgresql 10
when it comes the OE ligature in the unaccent function. We modify the
test case to take that into account.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Ben Shum <ben@evergreener.net>
Lp 1730726: Fix lp1501781-unaccent_and_squash.pg for PostgreSQL 10
PostgreSQL 10 has improvements in the unaccent function used by the
evergreen.unaccent_and_squash function. The test needs a small
modification to take this into account. Actual code change from Mike
Rylander with a little typo fix.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Ben Shum <ben@evergreener.net>
Lp 1730726: Fix a number of PgTap tests for PostgreSQL 10.
A number of tests disabled output via "\set ECHO". In PostgreSQL 10,
the lack of a value in \set is an error. We change these lines to
"\set ECHO none".
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Ben Shum <ben@evergreener.net>
Lp 1730726: Basic Patch to build the database with PostgreSQL 10.
* Modify the evergreen.org_top() function, with code from Galen
Charlton, to be non-set returning.
* Modify Open-ILS/src/support-scripts/eg_db_config.in to not strip the
period from PostgreSQL version numbers and to use the first two
components when checking for supported PostgreSQL versions.
* Add link from Open-ILS/src/sql/Pg/000.english.pg94.fts-config.sql
to Open-ILS/src/sql/Pg/000.english.pg10.fts-config.sql.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Ben Shum <ben@evergreener.net>
For standalone DB server install, ensure that we are applying the proper
PostgreSQL community apt repo for packages.
DO NOT backport this branch. There are presently known issues with
Ubuntu 18.04 and email generation from action/trigger and other
interfaces. We plan to address these before the 3.3 release, but do
not necessarily expect to backport those fixes.
Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Jason Stephenson <jason@sigio.com>
Jason Stephenson [Tue, 25 Sep 2018 15:47:05 +0000 (11:47 -0400)]
LP#1793585: Fix Unescaped left brace in regex Perl error.
Running make check results in the following error on Perl 5.26:
Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/\${ <-- HERE EMAIL_SENDER}/ at Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/HoldNotify.pm line 358.
Prior to Ubuntu 18.04 and Perl 5.26, this was a deprecation warning.
This commit fixes the regular expressions in HoldNotify.pm to escape
the left braces to make this error/warning go away.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Ben Shum <ben@evergreener.net>
Changes to Makefile.install to support this version of Ubuntu.
Note: We are using PG9.6 from the PostgreSQL apt source instead of the
standard PG10 version that ships with Ubuntu 18.04. Further testing required
before we switch PG versions so relying on a known working version for now.
Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Jason Stephenson <jason@sigio.com>
Terran McCanna [Wed, 12 Dec 2018 22:57:19 +0000 (17:57 -0500)]
LP#1743783 Web Client Bill Full Detail Display Issues
Fleshes out retrieved data to be able to display the billing
location for both circulation and grocery bills on the full
details page as well as the owning library for circulation bills.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
projects / working / Evergreen.git / log