Acq: two tweaks to UI improvements in previous commit
Suggested by Bill Erickson:
* Prevent interface locking up with the Mark Received/Unreceived
actions when nothing is selected
* Make new lineitem batch receive/rollback API methods actually stream
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Several usability improvements throughout Acq, including:
* A logical re-ordering of the main "actions" dropdown in several Acq
interfaces (selection lists, purchase orders, acq search results, MARC
federated search interface, etc).
* "Actions" dropdown also has its options enabled/disabled depending what
interface you're seeing it through, and redundant entries are
removed from the per-lineitem secondary dropdown.
* Add to Purchase Order dialog added to "actions" dropdown
* Middle layer support for adding many line items to a PO at once
* Create/add to Purchase Order operations can no longer steal line
items from current POs
* Create invoice from / link to invoice now work in new tab
* Receive/unreceive now by selected lineitem instead of whole PO
* Claim policy application works more simply now
* Invoices interface auto-populates "# Invoiced" column with number of
invoicable copies, and copies the "billed cost" column to the
"amount paid" column if the latter doesn't have anything in it yet.
* You can now only cancel specific lineitems when they're actually on
a PO and have the state of 'on-order'.
* Avoid double-activation of POs at UI level
* Disable invoice and cancel options for whole pending POs
* Disable zero-copy checkbox for activated POs
* Disable new misc charges (acq.invoice_item) for activated POs
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Jason Etheridge [Mon, 11 Mar 2013 19:27:30 +0000 (15:27 -0400)]
skip xulG.get_barcode if no barcode completion
For Check In and Check Out interfaces, skip the xulG.get_barcode call if there
are no active Barcode Completion entries (under Admin->Local Administration->
Barcode Completion) at the time of the staff client login sequence.
However, for Check Out, an exception is made if the "Load patron from Checkout"
library setting is in effect, since that functionality depends on
xulG.get_barcode.
Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Bill Erickson [Wed, 16 Jan 2013 22:13:50 +0000 (17:13 -0500)]
ACQ PO inline details view
Adds a new 'expand' lineitem option which produces a table inline below
the lineitem title, author, etc. containing copy information. Each copy
linked to the lineitem is represented as a row in the table with owning
lib, copy location, fund, barcode, callnumber, and notes. An option to
expand/collapse all is also present.
Release notes included.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Fri, 18 Jan 2013 17:27:28 +0000 (12:27 -0500)]
ACQ order identifier UI
In the lineitem table show the set of possible order identifier types
and values. The user may enter new values when necessary. When changes
are applied, the selected order identifier is applied to each lineitem.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Mon, 21 Jan 2013 19:51:48 +0000 (14:51 -0500)]
ACQ API for setting the lineitem order identifier
API: open-ils.acq.lineitem.order_identifier.set
Given an existing lineitem_attr (typically a marc_attr), this will
create a matching local_attr to store the name and value and mark
the attr as the order_ident. Any existing local_attr marked as
order_ident is removed. When necessary, the value (isbn, issn, upc) is
added to the record first to create the marc attribute. If the lineitem
is linked to a bib record and the user has the correct permissions, any
new data will also be applied to the bib record.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Tue, 22 Jan 2013 19:35:22 +0000 (14:35 -0500)]
Extract multiple like values from lineitem
Make it possible to extract multiple values with the same MARC tag
during acquisitions lineitem ingest. Prior to this, only one (e.g.)
ISBN for each record would be extracted as a lineitem attribute.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Wed, 27 Feb 2013 18:08:07 +0000 (13:08 -0500)]
Z39.50 stored credentials
* New non-IDL-accessible DB table for storing credentials
* API for applying credentials
* Additions to the Z39.50 configuration UI for applying and clearing
credentials.
* At Z39.50 search time, if no creds are provided by the caller, but
creds are configured in the database, creds from the DB are used to
make the Z39 search call.
* Release notes included
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Wed, 26 Dec 2012 15:29:30 +0000 (10:29 -0500)]
Return calculated value for SIP recall_ok test
Determine the value for the "recall OK" testing for patron information
requests the same we we determine the value for ciruclations and holds.
Previously, the recall-OK test always returned false, presumably since
recalls are not currently supported in Evergreen SIP.
Note that like holds and circs, we determine whether a user has good
standing based on the users penalties and whether the user is active /
non-barred. Though we could in some cases, we are not checking whether
the user has the required permission to perform specific tasks.
This feature is enabled via a new oils_sip.xml configuration option:
Mike Rylander [Fri, 8 Mar 2013 19:26:17 +0000 (14:26 -0500)]
QP search modifier '#deleted'
These tweaks involve an internal flag that's off by default. If you
want '#deleted', you'll have to turn it on explicitly at your site (and
reingest existing records) to get the functionality. If you don't need
'#deleted', you may prefer to leave the setting off so that your system
will be purged (as before) of useless (to you) metarecord mappings
taking up room in the database for deleted bibs.
Bill Erickson [Tue, 11 Dec 2012 17:07:37 +0000 (12:07 -0500)]
Script to collect CSV notification status responses
For 3rd-party services which provide batch notifications status updates
via CSV file. The script assumes the action/trigger event definition ID
is included in the response and, from there, applyes the "status" value
to the async_output of the event definition in question.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Tue, 11 Dec 2012 17:03:27 +0000 (12:03 -0500)]
Action/Trigger template output aggregator
Script to collect template output data from action-trigger events,
potentially spanning multiple event definitions, and stitching the
output together into a single file / output. The file may then be
delivered to a 3rd party via sFTP/SCP using config.remote_account.
The primary use case of the script is for aggregating CSV, XML, etc.
output to deliver to a 3rd party for notification purposes (e.g. phone,
print notices). This is useful because a) no one event definition can
cover all notification types and b) template output files can become too
large to practically store in the DB and deliver to/from opensrf
services.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Tue, 11 Dec 2012 16:59:50 +0000 (11:59 -0500)]
Seed data for CSV notification export
Full set of seed data for CSV action/trigger notification batch exports.
The seed data is added to its own file and not automatically loaded into
new installs (or via upgrade script) since it adds a significant number
of new event definitions, probably more than most installs need by
default.
Review the event defs. and their parameters prior to loading this seed
data, as it only represents one possible set of CSV notification
options. For example, it assumes one type of "notify media" for all
created notices. It may necessary to add additional event defs to cover
additional media, etc.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Wells [Fri, 14 Dec 2012 19:22:20 +0000 (14:22 -0500)]
Serials special status support for Items tab
The Serial Control interface prevents direct editing of item status, as
some status changes require additional updates and/or can create data
conflicts.
In the current state, though, we have no way to set three important
statuses: claimed, not held, and not published. At some point, claims in
particular should be more than a simple status, but in the meantime, the
ability to set these should not be overlooked.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Mike Rylander [Fri, 8 Mar 2013 20:13:11 +0000 (15:13 -0500)]
Two new QP filters: create_date and edit_date
These filter on the fields of the same name in biblio.record_entry.
e.g.
create_date(,2013-02-01) => records created before 2013-02-01
create_date(2013-02-01) => records created since 2013-02-01
create_date(2013-02-01,2013-02-28) => records created in Feb 2013
create_date(yesterday) => records since created yesterday
[LFW] Reviewed and added a single missing 'use' line; rewrote commit
message; release note.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Wells [Thu, 28 Feb 2013 20:32:07 +0000 (15:32 -0500)]
Fix holding lib for certain distribution svrs
On a serial virtual record (svr), the holding lib is expected to be
just an ID. In one logic branch, Search/Serial.pm was attaching the
entire aou object, and we should instead attach just the ID of this
object.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Michael Peters [Tue, 12 Mar 2013 20:14:23 +0000 (16:14 -0400)]
LP#1154235 Allow inactive patron barcode to be loaded
This addresses LP#1154235 by modifying the evergreen.get_barcodes
function to allow users to retrieve patrons in barcode retrieve
who have inactive barcodes.
This returns to functionality in versions prior to around 2.2.x
series.
End result is staff receiving an alert that the patron was
accessed with an invalid barcode.
Signed-off-by: Michael Peters <mpeters@emeralddata.net> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Sat, 9 Mar 2013 03:41:08 +0000 (22:41 -0500)]
Show OPAC-invisible copies in TPAC in staff context
We were not calling the staff variation of the copy count method; thus,
the record details template was skipping the copy table in the event
that all copies for a given record were marked as OPAC-invisible via
either copy visibility or shelving location visibility.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Wells [Thu, 28 Feb 2013 19:49:16 +0000 (14:49 -0500)]
Don't populate the MFHD menu with distributions
If a distribution has no legacy record, it shouldn't get a menu
entry in the MFHD menus. A magic id of '-1' is used to indicate
this case, so we need to check for that when populating
mfhdDetails via the TPAC.
Also, entryNum must be an int, not a string, because it is
incremented prior to display. Removing the quotes solves this
display issue.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Wells [Wed, 27 Feb 2013 14:34:58 +0000 (09:34 -0500)]
Tweak Google Book Preview Display, Take 2
After some additional feedback, this commit makes three changes
to the Google Book preview link:
1) As a solution offered by Dan Scott, rather than move the
button, we simply scroll to the preview when the button is clicked.
This effectively makes it impossible to miss. (In the current
code it sometimes loads off the screen.)
2) Make the viewer display in the same style as other added
content.
3) Allow the added content header to function as an additional
toggle to turn the viewer on and off.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Wells [Wed, 27 Feb 2013 14:24:33 +0000 (09:24 -0500)]
Make Google Books Preview Honor Setting
The new Google Book Preview was loading even if the setting was
off, provided some other 'want_dojo' feature was loaded. This
change will honor the setting regardless.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Wed, 6 Mar 2013 21:02:37 +0000 (16:02 -0500)]
TPAC my-list call number includes child orgs
For my-list call number display, if the most relevant call number is a
child of any of the context org units (physical/pref/search), it is
considered relevant for purposes of call number display.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Tue, 12 Feb 2013 17:19:58 +0000 (12:19 -0500)]
tpac avoid more org_unit template var leaks
Avoid using the variable name 'org_unit' in misc_utils (when compiling
copy visibility info) since the value can leak into the org_selector
template, disrupting the rendering of the org selector.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Mon, 28 Jan 2013 18:40:12 +0000 (13:40 -0500)]
Consistent response type from TPAC pref lib lookup
In some contexts, the $user->home_ou field is fleshed with a real org
unit object. Ensure that the response value from _get_pref_lib in the
TPAC takes this into consideration when finding the ID of the user's
home org unit.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Thu, 13 Dec 2012 16:34:50 +0000 (11:34 -0500)]
Show local call number in TPAC My Lists display
If an opac-visible call number exists that is owned by an org unit
relevant to the patron, show the (most relevant) call number label in
the My Lists display for each record in the list. Call number is
displayed in both saved and temporary lists.
A call number is considered relevant if its owner is one of:
This code leverages the new "exclude_invisible_acn" unapi filter to
ensure that we are only required to retrieve 1 call number in the unapi
output instead of an arbitrarily large set of call numbers, against
which we may have to filter non-visible call numbers.
This commit also addresses and outstanding TODO item in the tpac Perl:
Replace the last use of fetch_marc_xml_by_id with get_records_and_facets
and remove fetch_marc_xml_by_id
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Thu, 7 Feb 2013 18:43:19 +0000 (13:43 -0500)]
rank_ou() honors pref-lib in non-global context
When determining how to sort an org unit (e.g. sorting copies by circ
lib for display in the catalog), allow the pref-lib to affect the sort
order in global and non-global searches.
Org units are now sorted with the following criteria in the following
order. For example, assume we are sorting a copy circ_lib:
1. circ_lib matches the search_lib
2. circ_lib matches pref_lib
3. distance of circ_lib from pref_lib when pref_lib is a child of
search_lib, if circ_lib is a child of pref_lib.
(For example, searching CONS with pref_lib SYS1, items at BR1 will
sort ahead of items at BR3, since BR1 is a child of the pref_lib).
4. proximity of circ_lib to search_lib, when circ_lib is a child of
search_lib.
5. In all other cases, circ_lib is sorted to the bottom with the rest of
the riffraff.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Wed, 21 Nov 2012 15:12:39 +0000 (10:12 -0500)]
extract PO name from picklist upload
If a PO name is encoded in a lineitem (via provider attribute
definition), extract that PO name when creating a new purchase order
from lineitems that were previously only linked to a selection list.
This allows staff to create selection lists first, then orders second,
while retaining the encoded purchase order name.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Fix divergence of stock serials schema and upgraded schema
And additionally make a function used in a constraint on
serial.issuance.holding_code a little bit smarter.
These issues were reported to me by Galen Charlton.
The upgrade script included here will set serial.issuance.holding_code
to NULL in cases where the value doesn't validate, but in those cases
there is no part of Evergreen that could have made use of the data
anyway, and the data is just plain bad.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Exclude copies that have been deleted from showing up on the browse holds shelf list.
If an item had been deleted while it had a status of On Holds Shelf, it would permanently show up on
the browse holds list. This will exclude deleted copies from the results.
Signed-off-by: Steven Callender <stevecallender@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Tue, 11 Dec 2012 20:50:56 +0000 (15:50 -0500)]
Remote Account Conify UI
Admin interface for config.remote_account. To date, remote accounts
have been managed solely as EDI accounts, which have their own
interface. If one wishes to add/manage non-EDI remote accounts, then
this new UI is needed.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/xul/staff_client/chrome/content/main/menu_frame_menus.xul
Galen Charlton [Tue, 5 Feb 2013 18:12:02 +0000 (13:12 -0500)]
LP#1116509: prevent null SVF attribute value from breaking record import
Fix problem where a record could fail to be staged for import
with the following error:
ERROR: query string argument of EXECUTE is null
CONTEXT: PL/pgSQL function "extract_rec_attrs" line 72 at EXECUTE statement
SQL function "extract_rec_attrs" statement 1
This error would be triggered if at least one SVF attribute has a normalization
function defined that is applied to a null value during record import.
Patch is based on a suggestion by Bob Wicksall.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Mon, 11 Mar 2013 17:40:46 +0000 (13:40 -0400)]
Reify required authority fixed field names
Adam (and Art, by way of Adam's patch) added a goodly pile of fixed
field definitions that were lacking previously. The change in this
commit simply changes the label of two (008/11 and 008/15) to those
in use by other parts of the code. In particular, internally, we call
the field holding a thesaurus code value "Subj" and use that name during
ingest of authority records. Therefore, that should not change. This
required a subsequent change to the label of another, to SubjUse.
I've included a duplication in the backend-only (probably deprecated)
version of this mapping to allow the front-end labels to work.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
This is consistent with commit's e675b854 change to the
OCLC labels, and also fixes a problem where changing the
008/11 and 008/15 was not reflected in the fixed field boxes.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Adam Bowling [Fri, 26 Oct 2012 14:59:54 +0000 (10:59 -0400)]
Add fixed fields missing from previous configuration, namely for MAP and SER record types. Incoporate previous changes for AUT record types from 1040381.
Signed-off-by: Adam Bowling <adbowling@library.in.gov> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Mon, 4 Feb 2013 20:46:20 +0000 (15:46 -0500)]
Default ACQ copies use workstation org as owning lib
When creating default copies for new lineitems or lineitems added to
POs, use the workstation org unit as the owning lib for each copy. With
this, it's possible to order items for "here" without having to edit any
single copies. This also resolves a confusing issue where opening the
copies in the copies grid made it appear that each copy had an
owning_lib applied (via the autofieldwidget) when none was yet set.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Bill Erickson [Wed, 30 Jan 2013 14:36:17 +0000 (09:36 -0500)]
Default number of ACQ copies per provider
Acquisitions providers have a new "Default # Copies" field. When the value
is set, this number of copies will be automatically added to each lineitem
added to a purchase order for the provider. This takes place during PO
creation from a selection list or existing bib record and when a lineitem is
added to an existing purchase order. If a lineitem already has copies
attached, no default copies are added.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
This patch updates the seed data from the target list at
http://www.loc.gov/z3950/lcserver.html#addr. It also changes the
structure attribute for the 'lccn' search attribute to wordlist,
which means that LCCNs can be searched without having to enter
the leading spaces.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
When the max fine amount is not a multiple of the recurring fine amount,
fines will actually max out at an amount greater than the max fine
value. This commit adds YAOUS and some simple functionality to
optionally truncate the final amount billed to the max fine amount.
For example, if max fine is $5.00 and recurring fine is $0.30, the 17th
billing will bring the total amount billed to $5.10 (17 x $0.30),
thereby exceeding the max fine amount. With this commit, if
circ.fines.truncate_to_max_fine is true, the final billing amount will
be reduced and the total amount billed will be $5.00.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Thu, 28 Feb 2013 17:39:40 +0000 (12:39 -0500)]
LP#1136084: drop silent dependency on 'bsdmainutils' Debian/Ubuntu package
colrm is a perfectly good command, but isn't guaranteed to be
present on a minimal Ubuntu system. This patch replaces ti with
with cut, which is more likely to be present (including on *BSD
servers).
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Sat, 19 Jan 2013 05:46:32 +0000 (00:46 -0500)]
LP#1086458: clean up after event listeners in circ/patron interface
Upon window unload, now removes event listeners, both ones explicitly
created by the page JavsScript as well as ones created by
util.list, util.controller, and persist_helper().
The same approach of defining cleanup fnctions used by unload
events can be applied to the rest of the staff client, but
this patch focuses on circulation first.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
EventListenerList allows one to maintain a list
of event listeners, then remove them all when it's
time to clean up a window.
Usage is:
var list = new EventListenerList();
// attach an event listener
list.add(node, 'command', function(ev) { alert('BOO!'); }, false);
...
// get rid of them
list.removeAll();
Based on an idea by Jason Etheridge.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
projects / working / Evergreen.git / log