Kathy Lussier [Wed, 17 Feb 2016 13:01:54 +0000 (08:01 -0500)]
LP#1067823 Add genre facet by default and remove tag 659 from definition
Since genre will work well as a facet, add it to the facets in config.tt2 so
that it displays by default. Also removes the 659 MARC field from the genre
definition since it is currently an unassigned tag.
Release notes have been updated to reflect these changes.
[1] Adjust facet XPath to work for more Pg versions.
[2] Ensure that upgrade script adds stock search
normalizers.
[3] Make update script provide instructions for
running a partial reingest.
And genres are not subjects. So now we will index genres in the identifier
class and teach the tpac to build links appropriately. Genre is herein
defined as data in tags 655 or 659 (as the tpac currently thinks), restricted
to subfields [abvxyz], per LoC documentation.
To test:
[1] Apply the update and run the partial reingest as suggested
by the upgrade script.
[2] In the public catalog, navigate to a record that has one
or more 655 fields. Click on one of the genre links and
verify that it retrieves records sharing that genre heading.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Andrea Neiman <aneiman@kent.lib.md.us> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Jason Stephenson [Sat, 26 Sep 2015 15:42:35 +0000 (11:42 -0400)]
LP 1499123: Modify Perl code for csp.ignore_proximity field.
* Add get_org_unit_proximity function to AppUtils.
First, we add a helper function to OpenILS::Application::AppUtils that
returns the proximity value between a "from" org_unit and a "to"
org_unit. It takes a CStoreEditor and the ids of the two org_units as
arguments.
* Use csp.ignore_proximity in O::A::Circ::Circulate::Circulator.
Modify the check_hold_fulfill_blocks method of the Circulator object
to take the csp.ignore_proximity into account.
The new code first calculates the proximity of the circ_lib and the
copy's circ_lib with the patron's home_ou. It then modifies the main
query in the function to check if the csp object's ignore_proximity
is null or greater than either of the two calculated proximity values.
* Teach SIP::Patron about csp.ignore_proximity.
We modify SIP::Patron::flesh_user_penalties to not report penalties
within csp.ignore_proximity of the user's home_ou.
In order to have a notion of "here" for the proximity check, we modify
SIP::Patron->new to assign its authtoken argument, if any, to the
CStoreEditor. We then use this authtoken to retrieve the authsession
user so that we may use the authsession user's ws_ou or home_ou as a
context ou for penalty lookup and filtering based on the
csp.ignore_proximity in flesh_user_penalties. If we're not given the
authtoken, we fall back to using the patron's home_ou and the
penalty's context ou for the proximity lookup.
This assumes, of course, that the authsession user's ws_ou or home_ou
have a logical relationship with the desired transaction ou. For most
self-checks this will likely be true. For other uses of the SIP
protocol, this is less likely to be true.
* Add Perl live tests.
Add tests for basic checkout and hold functionality as well as for
the OpenILS::SIP::Patron->flesh_user_penalties() changes.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Jason Stephenson [Fri, 25 Sep 2015 00:35:50 +0000 (20:35 -0400)]
LP 1499123: Add ignore_proximity to config.standing_penalty.
This commit adds the integer column ignore_proximity to the
config.standing_penalty table. It also adds the column to the
csp class entry in the IDL.
It also modifies the action.hold_permit_test() function from
110.hold_matrix.sql to use the ignore_proximity field from
config.standing_penalty when checking the user's penalties to see if
they block the hold.
We also modify the action.item_user_circ_test() function from
100.circ_matrix.sql to use the ignore_proximity field from the
config.standing_penalty table when checking to see if the user's
penalties block the circulation.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
When a patron has no mailing address linked, attempt to read address
data from the patron's billing address. Similarly, if all address
fields are properly set by the API caller, except the country, and the
patron has no addresses, attempt to determine the country from org unit
settings.
If insufficient address data is provided or divined, return an invalid
params Event (similar to other CC failures).
To test:
[1] Create a patron record that has no mailing address but does
have a billing address. Perform or simulate a credit card
payment; it shoudl fail with an internal error.
[2] Apply the patch and repeat step 1; this time, the payment
attempt should succeed and use the billing address.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Kathy Lussier [Tue, 15 Dec 2015 13:39:27 +0000 (08:39 -0500)]
LP#1522604: Remove red alert style for non-cataloged checkouts
The non-cataloged checkouts in the patron summary had a red alert style
applied when there was a lost item count on the patron record. This branch
removes any alert styling since we don't need to highlight non-cataloged
checkouts.
Test plan:
Pre-patch, retrieve a patron record with lost transactions in the web client.
The non-cataloged count in the patron summary will be red. Apply the patch.
The count will no longer be red.
Josh Stompro [Mon, 9 Nov 2015 02:51:04 +0000 (20:51 -0600)]
LP#1240657 - Creating and Deleting Closed Dates permissions wrong.
The code referenced two permissions that didn't exist
CREATE_CLOSEING and DELETE_CLOSEING. Should be CREATE_ORG_UNIT_CLOSING,
and DELETE_ORG_UNIT_CLOSING.
[RM note: the affected methods don't appear to be in use, however]
Kathy Lussier [Sat, 14 Feb 2015 19:10:54 +0000 (14:10 -0500)]
lp1422802: Improve visibility of parts on Place Holds screen
Users often miss the list of parts on the Place Holds screen, leading to
many title-level holds on records where only one or two libraries have
'unparted' copies. This branch adds some styling to add padding around the
parts selector and to bold the Select a Part text. Many thanks to Christine
Morgan whose custom work at NOBLE served as an inspiration for this styling.
The branch also adds a new config.tt2 option to display parts with
radio buttons instead of a select menu so that all of the parts will display on
the screen. With this option, no parts are pre-selected, forcing the users to
actively choose a part.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Ben Shum <ben@evergreener.net>
Dan Wells [Fri, 14 Dec 2012 18:39:21 +0000 (13:39 -0500)]
LP#1526547 Prevent bogus notes when adjusting lost/lod overdues
If you void/adjust an overdue, but don't supply a reason, the code
automatically adds "VOIDED FOR BACKDATE" to the billing note. This is
obviously wrong for overdues adjusted or voided due to lost (or long
overdue) processing.
This commit simply adds a more appropriate note.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Galen Charlton [Fri, 20 Nov 2015 21:26:05 +0000 (21:26 +0000)]
LP#1516867: set limit on when HTML report output sorting
To avoid taking an excessive amount of time to render an
HTML report or sort its values, dynamic sorting is enabled
only when there are at most 10,000 rows of output.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ben Shum <ben@evergreener.net>
Using the sortable JavaScript library from https://github.com/hubspot/sortable
(MIT license), we can make HTML reports much more usable by making them
sortable by clicking on the column headers. This should save some downloading
of CSV or Excel versions of the reports.
To test:
[1] Create or use a report template and generate an HTML report; ensure
that the report has at most 10,000 rows of output.
[2] View the report output and click on one of the column headings;
verify that the table sorts itself by that column's values.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ben Shum <ben@evergreener.net>
Galen Charlton [Tue, 26 Jan 2016 22:34:03 +0000 (17:34 -0500)]
webstaff: tweak setting default classification scheme in volcopy editor
With this patch, the volume/copy editor creation default for
classification scheme now can have a value of "Use Library Setting".
If this is in effect, the default classification scheme for new
volumes is taken from the library setting.
Galen Charlton [Tue, 26 Jan 2016 18:06:14 +0000 (13:06 -0500)]
webstaff: save copy templates now unconditional
The save copy templates button in the volume/copy editor
no longer requires that a working template be active; this
way, users can save the set of templates after an import
without having to select one of them first.
specifies a button that, when click, allows the user to save
the contents of the scope variable foo. The dialog that
appears will use "example.json" as the default filename.
This also adds a new dependency, the MIT-licensed
angular-file-saver service written by Philipp Alferov:
Galen Charlton [Thu, 29 Oct 2015 23:24:35 +0000 (23:24 +0000)]
webstaff: tweak how element IDs in MARC editor are generated
For new records (or records that for whatever reason lack
a 901 field), use '0' as a dummy value for the record
ID when constructing element IDs (e.g., r0f5, r0f10sf0value,
etc.). This fixes a problem where setCaret() couldn't
successfully change focus after adding a field or subfield
to a new record.
Galen Charlton [Wed, 21 Oct 2015 17:39:08 +0000 (17:39 +0000)]
LP#1508477: bump up minimum version of angular-hotkeys
Version 1.3.0 of angular-hotkeys is now required, as this
is the version that introduces the ability the specify
that hotkeys can be used even when inputs, selects,
and textareas have focus.
After applying the patch (and doing a bower update,
grunt uglify, and install), one can test hotkeys in
the web staff client by (for example):
- starting from the home page and hitting F1 to
get to patron search by barcode
- hitting F5 to get the item status page
Note that if the page embeds the OPAC or a Dojo
interface using an egEmbedFrame, if any element
of the iframe's content has focus, the hotkeys won't
work -- that will be the subject of another patch.
Galen Charlton [Fri, 16 Oct 2015 22:21:14 +0000 (22:21 +0000)]
webstaff: teach egOrgSelector how to be sticky
In order to make the org unit selector in the holdings view
to be "sticky", the egOrgSelector directive now accepts an
optional stickySetting attribute specifying the name of a
preference key for storing the last selected org unit.
projects / working / Evergreen.git / log