working/Evergreen.git
2 years agowebstaff: warning sound for Event Override dialog
Jason Etheridge [Mon, 27 Mar 2017 19:31:34 +0000 (15:31 -0400)]
webstaff: warning sound for Event Override dialog

Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agowebstaff: warning sound for Bad Barcode dialog
Jason Etheridge [Mon, 27 Mar 2017 19:10:45 +0000 (15:10 -0400)]
webstaff: warning sound for Bad Barcode dialog

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agowebstaff: warning sound for Item Not Found in Item Status
Jason Etheridge [Mon, 27 Mar 2017 19:01:48 +0000 (15:01 -0400)]
webstaff: warning sound for Item Not Found in Item Status

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agowebstaff: tweak successful renewal sound
Jason Etheridge [Thu, 23 Mar 2017 19:08:17 +0000 (15:08 -0400)]
webstaff: tweak successful renewal sound

aesthetic: default to info.wav instead of success.wav

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoLP#1683388: Docs: README change for nodejs installation
Ben Shum [Fri, 14 Apr 2017 22:51:01 +0000 (18:51 -0400)]
LP#1683388: Docs: README change for nodejs installation

Now that we have Makefile developer support for Wheezy too, we can
skip the extra steps if we use the developer make target for any
supported distribution.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1683388:Install newer NodeJS binary for Ubuntu Trusty and Debian Wheezy
Ben Shum [Fri, 14 Apr 2017 22:33:31 +0000 (18:33 -0400)]
LP#1683388:Install newer NodeJS binary for Ubuntu Trusty and Debian Wheezy

We need newer stuff!

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1675899 Targeter --retarget-interval override fix
Bill Erickson [Fri, 24 Mar 2017 19:05:46 +0000 (15:05 -0400)]
LP#1675899 Targeter --retarget-interval override fix

Treat the hold targeter --retarget-interval command line option as an
option containing a string value (the interval) instead of a boolean.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1667115 - Silence config.hard_due_date warning
Josh Stompro [Thu, 23 Feb 2017 19:38:12 +0000 (13:38 -0600)]
LP#1667115 - Silence config.hard_due_date warning

For every checkout where a hard due date isn't used there is a log
warning of "retrieve config.hard_due_date called with no ID...".

This fix silences that warning.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
2 years agoLP#1670425: RTL improvements to new advanced search limiter block
Kathy Lussier [Wed, 12 Apr 2017 02:37:20 +0000 (22:37 -0400)]
LP#1670425: RTL improvements to new advanced search limiter block

Add some extra divs to the block with associated styling so that the advanced
search limiter block displays correctly for right-to-left languages. Also, add
some CSS to the rtl stylesheet so that padding and margins are added to the
correct side of blocks.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
2 years agoLP#1670425: Adjust the release notes entry to reflect changes
Kathy Lussier [Fri, 10 Mar 2017 17:50:20 +0000 (12:50 -0500)]
LP#1670425: Adjust the release notes entry to reflect changes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
2 years agoLP#1670425: New responsive design for advanced search limiters block
Kathy Lussier [Fri, 10 Mar 2017 13:57:26 +0000 (08:57 -0500)]
LP#1670425: New responsive design for advanced search limiters block

When the screen is 600px or smaller, we continue to only display the 'x filters
applied' link as we did with the sidebar display because displaying limiters
pushes the results too far down the screen. Clicking the link toggles the
display of the limiters.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
2 years agoLP#1670425: Moving display of advanced search limiters on search results page
Kathy Lussier [Thu, 2 Mar 2017 04:06:49 +0000 (23:06 -0500)]
LP#1670425: Moving display of advanced search limiters on search results page

Moves the new 2.12 advanced search filters block out of the sidebar and
along the top of the screen so that the user can see limiters along with their
other search terms.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
2 years agoLP#1665933: describe the new -x option when running -h
Galen Charlton [Wed, 12 Apr 2017 20:06:09 +0000 (16:06 -0400)]
LP#1665933: describe the new -x option when running -h

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
2 years agoLP 1665933: Skip XUL staff client build in make_release.
Jason Stephenson [Tue, 11 Apr 2017 14:52:09 +0000 (10:52 -0400)]
LP 1665933: Skip XUL staff client build in make_release.

Add a -x option to skip building the XulRunner staff clients.  This is
useful for making custom tarballs for local installation where you
will build the staff client on the server.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
2 years agoLP#1680624 Remove bower packaging bits
Dan Scott [Wed, 12 Apr 2017 00:21:56 +0000 (20:21 -0400)]
LP#1680624 Remove bower packaging bits

We no longer need to install bower as part of the Makefile.install
targets or worry about the bower_components cache directory when
generating a release. Rip out those references.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <ben@evergreener.net>
2 years agoLP#1680624 angular-ui-bootstrap stopped shipping minified files
Dan Scott [Thu, 6 Apr 2017 20:28:31 +0000 (16:28 -0400)]
LP#1680624 angular-ui-bootstrap stopped shipping minified files

Per https://github.com/angular-ui/bootstrap/issues/5522 upstream
feels users should minimize the files themselves.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
2 years agoLP#1680624 Consolidate package dependencies into package.json
Dan Scott [Thu, 6 Apr 2017 04:26:50 +0000 (00:26 -0400)]
LP#1680624 Consolidate package dependencies into package.json

npm already enables us to designate dependencies in package.json,
and projects have increasingly consolidated what bower used to be
used for in package.json. We can do this with an npm-compatible version of
angular-order-object-by from github.

There are a few other tweaks to npm vs bower file locations, such as
ng-toast instead of ngtoast for ngToast.

Pin to AngularJS 1.5.x for now

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
2 years agoLP#1680312: Fix IDs for 950.data.seed-values.sql for i18n
Ben Shum [Thu, 6 Apr 2017 04:25:15 +0000 (00:25 -0400)]
LP#1680312: Fix IDs for 950.data.seed-values.sql for i18n

For oils_i18n_gettext purposes, fix the IDs being fed so that we do not
get duplicates when generating the translation files for 950.data.seed-values

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
2 years agoLP#1680312 Ensure oils_i18n_gettext keys are unique
Dan Scott [Fri, 7 Apr 2017 18:19:22 +0000 (14:19 -0400)]
LP#1680312 Ensure oils_i18n_gettext keys are unique

To avoid inadvertent introduction of duplicate oils_18n_gettext() keys
in the data seed SQL, which will then prevent translated strings from
being able to be loaded, add a regression test.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Ben Shum <ben@evergreener.net>
2 years agoLP#1677416: unbreak use of egOrgSelector by egEditFmRecord
Galen Charlton [Thu, 30 Mar 2017 21:03:07 +0000 (17:03 -0400)]
LP#1677416: unbreak use of egOrgSelector by egEditFmRecord

This patch fixes a regression where attempting to change
the value of an egOrgSelector embedded in an egEditFmRecord
would result in errors like this:

Error: [$compile:nonassign] http://errors.angularjs.org/1.5.11/$compile/nonassign?p0=rec_orgs%5Bfield.name%5D()&p1=selected&p2=egOrgSelector

To test
-------
[1] Open the MARC Tag Tables admin interface in the web
    staff client and edit an existing entry. Note that
    changing the selected OU will result in there being
    no change and error messages appearing in the browser
    JavaScript console.
[2] Apply the patch and repeat step 1.
[3] Verify that no errors are logged.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
2 years agoLP#1167541: Use Patron home org for pickup lib instead of staff's
Mike Rylander [Thu, 9 Mar 2017 20:26:44 +0000 (15:26 -0500)]
LP#1167541: Use Patron home org for pickup lib instead of staff's

When staff are placing a hold for a patron, we should use the patron's
preferred pickup location, and failing that, their home library rather
than the staff's home library.

To test
-------
[1] In the web staff client, search for a title to place
    a hold request on, using a patron record
    whose home library is different from the home library of
    the staff member you are logged in as.
[2] Note that the pickup location defaults to the staff
    account's home library.
[3] Apply the patch and repeat step #1. This time, the default
    pickup library should be the home library of the patron.
[4] Set a preferred pickup location for the patron, then
    repeat step #1. This time, the default pickup library
    should be the preferred pickup location just set.
[5] Repeat steps #1-#4 using the XUL staff client; note that
    for step #3, it will be necessary to rebuild the client.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: Adding more information about closed dates editor
Jane Sandberg [Thu, 6 Apr 2017 04:15:45 +0000 (21:15 -0700)]
Docs: Adding more information about closed dates editor

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoInstall a modern Node.js
Dan Scott [Wed, 5 Apr 2017 21:25:10 +0000 (17:25 -0400)]
Install a modern Node.js

Rather than directing people to use an ancient version of Node.js from source,
point at the LTS version of the downloadable package (if necessary).

Signed-off-by: Dan Scott <dan@coffeecode.net>
2 years agoLP#1599634: stamp schema update
Galen Charlton [Tue, 4 Apr 2017 14:32:58 +0000 (10:32 -0400)]
LP#1599634: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP1599634: follow-ups
blake [Thu, 10 Nov 2016 23:06:39 +0000 (17:06 -0600)]
LP1599634: follow-ups

Squashed patch containing follows-ups written by Chris Sharp
and Galen Charlton:

*  When running the upgrade script, the DROP VIEW statement resulted in an
error since the view did not already exist.  You could add IF EXISTS, but
CREATE OR REPLACE VIEW is sufficient.

* Changes the ID column to just pass through
the ID from the source tables, promoted to BIGINT in
some cases.  This has the effect of:

- removing a redundancy, as circ_type already specifies the source table
- making it easier to join this view against the circulation tables when
  writing SQL queries

* Renames the schema upgrade script to better
match conventions.

* Move release notes entry so that it will get picked up

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP1599634 Circulation report source to include in-house(non cat), and non cat circ
blake [Thu, 7 Jul 2016 20:01:36 +0000 (15:01 -0500)]
LP1599634 Circulation report source to include in-house(non cat), and non cat circ

Added a simple view and supporting IDL. This will allow all the circulation
data to output in the same report.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: blake <blake@mobiusconsortium.org>
Conflicts:
Open-ILS/examples/fm_IDL.xml

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1643998: update list of supported languages
Galen Charlton [Tue, 4 Apr 2017 14:12:42 +0000 (10:12 -0400)]
LP#1643998: update list of supported languages

Per translations coordinator Eva Cerniňáková, add ar-JO
and remove fi-FI.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1643998 Docs: Updates needed to languages
Jeanette Lundgren [Fri, 20 Jan 2017 19:34:59 +0000 (14:34 -0500)]
LP#1643998 Docs: Updates needed to languages

Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: replacing XUL client docs with Browser client docs
Jane Sandberg [Sun, 2 Apr 2017 17:38:01 +0000 (10:38 -0700)]
Docs: replacing XUL client docs with Browser client docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: Information for system administrators about translations
Eva Cerniňáková [Sun, 2 Apr 2017 16:03:53 +0000 (09:03 -0700)]
Docs: Information for system administrators about translations

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: Web client no longer has borders around patron name
Jane Sandberg [Tue, 28 Mar 2017 19:41:16 +0000 (15:41 -0400)]
Docs: Web client no longer has borders around patron name

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen
Jane Sandberg [Tue, 28 Mar 2017 13:45:48 +0000 (09:45 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen

2 years agoDocs: Updating column picker docs for Web client
Jane Sandberg [Tue, 28 Mar 2017 13:44:23 +0000 (09:44 -0400)]
Docs: Updating column picker docs for Web client

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agolp1453205 replaced Target_Pickup_Lib1.jpg
Jeanette Lundgren [Wed, 18 Jan 2017 18:51:38 +0000 (13:51 -0500)]
lp1453205 replaced Target_Pickup_Lib1.jpg

Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: adding more to the config.tt2 variable list
Jane Sandberg [Tue, 28 Mar 2017 11:23:46 +0000 (07:23 -0400)]
Docs: adding more to the config.tt2 variable list

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoDocs: adding to the list of config.tt2 variables
Jane Sandberg [Tue, 28 Mar 2017 03:14:36 +0000 (23:14 -0400)]
Docs: adding to the list of config.tt2 variables

2 years agoDocs: Publish the 2.12 release notes
Dan Scott [Mon, 27 Mar 2017 02:40:24 +0000 (22:40 -0400)]
Docs: Publish the 2.12 release notes

We've released 2.12, let's integrate the corresponding release
notes into the doc build.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
2 years agoDocs: Use the 2.11 release notes
Robert Soulliere [Wed, 28 Sep 2016 14:35:53 +0000 (10:35 -0400)]
Docs: Use the 2.11 release notes

Update root.txt to point to the 2.11 release notes.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
2 years agoResolve a few doc build errors with images
Dan Scott [Mon, 27 Mar 2017 02:24:57 +0000 (22:24 -0400)]
Resolve a few doc build errors with images

* We need to match the case of images exactly on case-sensitive file systems
* Two dots in a file name confuses the simple-minded PDF build
* Comment out images that we don't actually have yet

Signed-off-by: Dan Scott <dscott@laurentian.ca>
2 years agoLP#1669868: fix regression that broke building staff client
Galen Charlton [Wed, 22 Mar 2017 21:24:02 +0000 (17:24 -0400)]
LP#1669868: fix regression that broke building staff client

Looks like AM_CONDITIONAL should not be in if blocks per
https://www.gnu.org/software/automake/manual/html_node/Usage-of-Conditionals.html

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agofix typo that broken generation of es-ES lang.dtd
Galen Charlton [Wed, 22 Mar 2017 19:57:48 +0000 (15:57 -0400)]
fix typo that broken generation of es-ES lang.dtd

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoTranslation updates - po files
Galen Charlton [Wed, 22 Mar 2017 19:26:05 +0000 (15:26 -0400)]
Translation updates - po files

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoTranslation updates - newpot
Galen Charlton [Wed, 22 Mar 2017 19:21:56 +0000 (15:21 -0400)]
Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoupdate server upgrade instructions for 2.12.0
Galen Charlton [Wed, 22 Mar 2017 18:05:14 +0000 (14:05 -0400)]
update server upgrade instructions for 2.12.0

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoupdate release notes for 2.12.0
Galen Charlton [Wed, 22 Mar 2017 18:03:21 +0000 (14:03 -0400)]
update release notes for 2.12.0

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years ago2.11.3-2.12.0 schema update script
Galen Charlton [Wed, 22 Mar 2017 18:00:25 +0000 (14:00 -0400)]
2.11.3-2.12.0 schema update script

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1668720: remove browser console noise for OPAC
Galen Charlton [Wed, 22 Mar 2017 16:25:41 +0000 (12:25 -0400)]
LP#1668720: remove browser console noise for OPAC

This patch fixes a case where JavaScript used in the OPAC
attempts to set the value of a #client_tz_id input on all
pages, even though only the login page has such an input.

To test:

[1] Load the OPAC homepage and open the JavaScript console/developer tools.
    Note that there's a "Cannot set property 'value' of null"
    error.
[2] Apply the patch and try again; this time there shouldn't
    be such an error.
[3] Open the login page, and verify, using developer tools,
    that the hidden client_tz_id input does have its value
    set to the client timezone.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP 1669868: Fix make check for all distros.
Jason Stephenson [Tue, 21 Mar 2017 19:34:21 +0000 (15:34 -0400)]
LP 1669868: Fix make check for all distros.

Chris Sharp found that make check was failing on Ubuntu 14.04 and 16.04.

I borrowed a few lines from the OpenSRF configure.ac and modified the
Open-ILS/src/c-apps/tests/Makefile.am to use a more autoconf-oriented
approach that won't lead to unnecessary checks in the install scripts.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1675025: Docs: mention that Vandelay can load MARCXML
Galen Charlton [Wed, 22 Mar 2017 13:58:39 +0000 (09:58 -0400)]
LP#1675025: Docs: mention that Vandelay can load MARCXML

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 years agoDocs: README to include Debian for changing ownership of /var/lock/apache2
Ben Shum [Tue, 21 Mar 2017 13:37:48 +0000 (09:37 -0400)]
Docs: README to include Debian for changing ownership of /var/lock/apache2

Minor tweak to also include Debian among distributions where it might
be necessary to change ownership of /var/lock/apache2 to opensrf user.
Previously this had been Ubuntu only issue, but has since been encountered
during new Debian installations.

Signed-off-by: Ben Shum <ben@evergreener.net>
2 years agoDocs: replacing XUL booking module screenshots with browser client ones
Jillianne Presley [Tue, 21 Mar 2017 18:22:51 +0000 (11:22 -0700)]
Docs: replacing XUL booking module screenshots with browser client ones

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 years agoLP#1673891: Fix untranslatable strings in metarecord sibling links
Kathy Lussier [Tue, 21 Mar 2017 01:25:25 +0000 (21:25 -0400)]
LP#1673891: Fix untranslatable strings in metarecord sibling links

We had a couple of untrasnlatable strings in the new sibling link section
of the record summary page. This commit makes the strings translatable and
also rewords one of the strings, as recommended by Eva Cerninakova, to make
it easier to translate in other languages.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1670512 Apply focus/select model udpates via timeout
Bill Erickson [Tue, 7 Mar 2017 17:25:32 +0000 (12:25 -0500)]
LP#1670512 Apply focus/select model udpates via timeout

Avoid manually invoking scope.$apply() in the midst of an angular
$digest loop, since this is forbidden by angular.  Wrap the apply()'s in
a $timeout, so they occur after the currently running digest.

Fixes the focusMe, blurMe, and selectMe directives.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1638377: update release notes to mention --with-perlbase
Galen Charlton [Wed, 15 Mar 2017 20:51:22 +0000 (16:51 -0400)]
LP#1638377: update release notes to mention --with-perlbase

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1638377: Allow perl to be installed in non-standard locations
Mike Rylander [Wed, 17 Aug 2016 17:25:35 +0000 (13:25 -0400)]
LP#1638377: Allow perl to be installed in non-standard locations

Add --with-perlbase configure option to specify
an alternative location for installing the Perl modules. This
can be useful for setups that want to run the Perl modules
from a shared filesystem or environments that need to run
multiple versions of OpenSRF simultaneously.

Users of --with-perlbase are responsible for ensuring that
PERL5LIB is set appropriately.

To test
-------
[1] Use --with-perlbase during the configure step, e.g.,

    ./configure --with-perlbase /tmp/perl

[2] Run make; make check; sudo make install
[3] Verify that the Perl modules are installed under
    /tmp/perl.
[4] Make a change to a Perl source file, then
    go to src/perlmods, then run sudo ./Build install. Verify
    that it remembers the --with-perlbase directory
    and installs the updated module there.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoupdate a couple references of 2.12-beta to 2.12-rc
Galen Charlton [Wed, 15 Mar 2017 20:35:45 +0000 (16:35 -0400)]
update a couple references of 2.12-beta to 2.12-rc

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoTranslation updates - po files
Galen Charlton [Wed, 15 Mar 2017 20:31:38 +0000 (16:31 -0400)]
Translation updates - po files

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoTranslation updates - newpot
Galen Charlton [Wed, 15 Mar 2017 20:26:21 +0000 (16:26 -0400)]
Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoupdate monolithic schema upgrade script for 2.12-rc
Galen Charlton [Wed, 15 Mar 2017 20:18:50 +0000 (16:18 -0400)]
update monolithic schema upgrade script for 2.12-rc

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1671936: add facet reingest to version-upgrade from 2.11.3
Galen Charlton [Wed, 15 Mar 2017 20:16:54 +0000 (16:16 -0400)]
LP#1671936: add facet reingest to version-upgrade from 2.11.3

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1671936: Tweak to release notes entry on reingest
Kathy Lussier [Tue, 14 Mar 2017 18:12:45 +0000 (14:12 -0400)]
LP#1671936: Tweak to release notes entry on reingest

Changes the Upgrade Notes in the release notes that a reingest of both browse
and facet indexes is required.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
docs/RELEASE_NOTES_2_12.adoc

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1671936: Provide reingest for 1006 upgrade script
Kathy Lussier [Fri, 10 Mar 2017 23:17:41 +0000 (18:17 -0500)]
LP#1671936: Provide reingest for 1006 upgrade script

We missed the reingest for upgrade script 1006. Adding it here.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: Fix typo, add missing contributing organization
Remington Steed [Wed, 15 Mar 2017 15:41:35 +0000 (11:41 -0400)]
Docs: Fix typo, add missing contributing organization

This commit fixes a small grammar mistake and adds a missing
organization to the Acknowledgements section.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: Slight rewording of release notes
Remington Steed [Wed, 15 Mar 2017 15:18:49 +0000 (11:18 -0400)]
Docs: Slight rewording of release notes

This commit slightly rewords the release notes entry about the new
translator make target.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: Grammar tweaks to the 2.12 release notes
Kathy Lussier [Wed, 15 Mar 2017 14:55:04 +0000 (10:55 -0400)]
Docs: Grammar tweaks to the 2.12 release notes

Many thanks to Andrea Neiman for catching these!

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: Updates to Czech organizations
Kathy Lussier [Wed, 15 Mar 2017 14:18:33 +0000 (10:18 -0400)]
Docs: Updates to Czech organizations

Making updates to Czech organizations listed in acknowledgements as recommended
by Eva Cerninakova.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: more 2.12 release notes updates
Galen Charlton [Tue, 14 Mar 2017 18:24:59 +0000 (14:24 -0400)]
Docs: more 2.12 release notes updates

* additional formatting
* mention the two new services in the top-level upgrade
  section.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: more typo and formatting improvements for 2.12 release notes
Galen Charlton [Tue, 14 Mar 2017 18:23:21 +0000 (14:23 -0400)]
Docs: more typo and formatting improvements for 2.12 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: mark subfield labels in 2.12 release notes
Galen Charlton [Tue, 14 Mar 2017 18:03:49 +0000 (14:03 -0400)]
Docs: mark subfield labels in 2.12 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: replace "OPAC" jargon in release notes
Galen Charlton [Tue, 14 Mar 2017 17:52:15 +0000 (13:52 -0400)]
Docs: replace "OPAC" jargon in release notes

... in favor of "public catalog". Please note that
I don't feel strongly about this change, and won't mind
if it gets reverted. I do feel more strongly about the
word "OPAC" slipping into patron-targeted documentation.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: typo fix for 2.12 release notes
Galen Charlton [Tue, 14 Mar 2017 17:51:14 +0000 (13:51 -0400)]
Docs: typo fix for 2.12 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: Translator acknowledgements and PostgreSQL support
Kathy Lussier [Tue, 14 Mar 2017 17:52:33 +0000 (13:52 -0400)]
Docs: Translator acknowledgements and PostgreSQL support

Updates the release notes with acknowledgements for translators that changed
trasnlations strings for offically-supported languages since the last release.
Also adds PostgreSQL as a recommendation as per discussion at March 2017 dev
meeting and follow-up e-mail to the dev list.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoDocs: Additions to 2.12 release notes
Kathy Lussier [Fri, 10 Mar 2017 20:38:10 +0000 (15:38 -0500)]
Docs: Additions to 2.12 release notes

Adds organizations that commissioned development, contributors who have
contributed since the beta release, new notes for ebook integration, and
some some missed features.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1673059: Update passwd storage test
Kathy Lussier [Wed, 15 Mar 2017 12:37:25 +0000 (08:37 -0400)]
LP#1673059: Update passwd storage test

The passwd storage PgTAP test is failing because the user ids shifted when new
sample records were added to the actor.usr table in the Concerto dataset. This
branch changes the id in the test to point to the correct user.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
2 years agoLP#1671112 Sample users and addresses with Unicode characters
Dan Scott [Wed, 8 Mar 2017 14:13:43 +0000 (09:13 -0500)]
LP#1671112 Sample users and addresses with Unicode characters

Introducing to the line up of sample users, José Antonio Bautista
and Munenori Kawasaki (川﨑 宗則), hailing from 800 René-Lévesque Blvd W in
Montréal.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <ben@evergreener.net>
2 years agowebstaff: Make Items Bookable and Book Item Now for Holdings View
Jason Etheridge [Fri, 10 Mar 2017 18:05:50 +0000 (13:05 -0500)]
webstaff: Make Items Bookable and Book Item Now for Holdings View

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoLP#1586567 Always return Fund Years sorted descending
Remington Steed [Thu, 29 Sep 2016 18:55:41 +0000 (14:55 -0400)]
LP#1586567 Always return Fund Years sorted descending

Currently, fund year selectors in Acq interfaces (at least Acq Admin ->
Funds, and Acq -> Load MARC Order Records) show the fund years in
database order. This commit adds a descending sort to the perl function
that retrieves fund years for those interfaces. It also removes the
unsuccessful attempt at sorting that was present in the dojo code.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP# 1668414: Stamping upgrade script for oneclickdigital base URI
Kathy Lussier [Tue, 14 Mar 2017 19:53:20 +0000 (15:53 -0400)]
LP# 1668414: Stamping upgrade script for oneclickdigital base URI

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1541559: org setting for OneClickdigital API base URI
Jeff Davis [Mon, 27 Feb 2017 21:40:55 +0000 (13:40 -0800)]
LP#1541559: org setting for OneClickdigital API base URI

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agolp1629016: Hide List Option In Staff Client
Christine Morgan [Wed, 1 Mar 2017 16:12:02 +0000 (11:12 -0500)]
lp1629016: Hide List Option In Staff Client

This will hide the option to add to Lists when in the staff client.

Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agolp1261835 stop colliding bill UI refreshes
Jason Etheridge [Wed, 2 Nov 2016 18:28:08 +0000 (14:28 -0400)]
lp1261835 stop colliding bill UI refreshes

for want of promises in Angular :)

population of the bill list in this implementation is asynchronous, but the rest
of the refresh action is not, and it's sadly being invoked multiple times. There
are different ways to fix this, but using a semaphore seems to work.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1175293 Use filtered fund dropdown in funding source interface
Dan Wells [Wed, 2 Nov 2016 18:35:16 +0000 (14:35 -0400)]
LP#1175293 Use filtered fund dropdown in funding source interface

The exising interface for allocating to funds from a funding source
view lists all funds by code only.  Since many (most?) orgs reuse
fund codes year to year, you eventually end up with a bunch of
dupes you cannot tell apart.

Let's "borrow" an AutoFieldWidget to do the heavy lifting of creating
a filtered list of active funds, and include the year for further
user validation.

This is inspired by a few other fund dropdowns, but may not be the
best overall solution.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1668682 Checkout holds fullfill ignores expire time
Bill Erickson [Tue, 28 Feb 2017 16:33:25 +0000 (11:33 -0500)]
LP#1668682 Checkout holds fullfill ignores expire time

Checking out a hold-captured item for a hold whose expire time is in the
past, but has not yet been canceled by the hold targeter, now marks the
hold as fulfilled.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1522644: Make Mark for Hold Transfer option consistent with other options
Kathy Lussier [Fri, 3 Mar 2017 04:52:30 +0000 (23:52 -0500)]
LP#1522644: Make Mark for Hold Transfer option consistent with other options

Makes the following changes to the Mark for Holds Transfer Destination option:

1) Changes the label from "Mark As Title Hold Transfer Destination" to "Title
Hold Transfer." The 'Mark" piece is already implied in the "Mark For" button
label, and the long text was pushing the menu off the screen for some displays.

2) Makes the option behave as other Mark options. If a record is already marked,
it displays the marked Record ID in the menu. The mark is also removed when the
"Reset Record Marks" option is clicked.

3) Pushes the reset option down to the bottom of the menu and alphabetizes the
other Mark options above it.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
2 years agoLP#1522644: webclient: Transfer title holds issues
Victoria Lewis [Fri, 13 Jan 2017 19:42:37 +0000 (11:42 -0800)]
LP#1522644: webclient: Transfer title holds issues

    Hid "Transfer All Titles" button from the View Holds tab of the bib record

    Moved the "Mark as Title Hold Transfer Destination" button to the
    "Mark For:" dropdown to make it more consistent with other "mark" actions.

    To test
    -------
    [1] Place a hold on a title.

    [2] Choose another title. Under "Mark For" click
        "Mark as Title Hold Transfer Destination"

    [3] Return to original title on hold. Under "Actions"
        click "Transfer To Marked Title"

    [4] Confirm that hold is transfered.

Signed-off-by: Victoria Lewis <vlewis@catalystdevworks.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
2 years agoLP#1442276: Stamp schema upgrade for corrupted XSL output
Dan Scott [Sun, 12 Mar 2017 04:05:15 +0000 (23:05 -0500)]
LP#1442276: Stamp schema upgrade for corrupted XSL output

Signed-off-by: Dan Scott <dscott@laurentian.ca>
2 years agoLP#1442276: Upgrade script for Encoding UTF8 output
Kathy Lussier [Sat, 11 Mar 2017 03:53:18 +0000 (22:53 -0500)]
LP#1442276: Upgrade script for Encoding UTF8 output

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
2 years agoLP#1442276 output_as_chars() instead of toString
Dan Scott [Sun, 5 Mar 2017 16:45:12 +0000 (11:45 -0500)]
LP#1442276 output_as_chars() instead of toString

The SuperCat transform methods for records retrieved by record ID or ISBN call
toString on the XSLT output object, which results in a byte string and thus
corrupted output. Instead, call output_as_chars() on the stylesheet object to
generate a character string and avoid corruption.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1442276 pgTAP test for oils_xslt_process
Dan Scott [Fri, 3 Mar 2017 21:03:30 +0000 (16:03 -0500)]
LP#1442276 pgTAP test for oils_xslt_process

In moving from the deprecated XML::LibXSLT::output_string() to output_as_chars(),
add a regression test to ensure that we do not suffer from corrputed encoding
output in the future.

We test both the case where an output encoding has been explicitly declared,
as well as the case where an output encoding has not been explicitly declared.
It was this subtle difference that was causing the problem with output_string().

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1442276 Prevent corrupted Unicode chars in MARCTXT and RIS
Dan Scott [Fri, 3 Mar 2017 06:40:19 +0000 (01:40 -0500)]
LP#1442276 Prevent corrupted Unicode chars in MARCTXT and RIS

The MARCTXT and RIS feeds use the deprecated XML::LibXSLT::output_string()
method which, depending on the stylesheet, generated either a byte string
or characters. Using output_as_bytes() ensures it is always a byte string
and avoids the resulting MARCTXT and RIS output from corrupting Unicode
characters.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1442276 Encode UTF8 output of XSLT transforms
Dan Scott [Fri, 3 Mar 2017 06:26:53 +0000 (01:26 -0500)]
LP#1442276 Encode UTF8 output of XSLT transforms

The XML::LibXSLT::output_string() method was deprecated in favour of
output_as_bytes() and output_as_chars(). The latter always generates
UTF8 output as characters, which is what we need, while output_string()
behaviour depended on the stylesheet.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1671904 egDate unit test handles time change
Bill Erickson [Fri, 10 Mar 2017 18:55:09 +0000 (13:55 -0500)]
LP#1671904 egDate unit test handles time change

Teach the egDate unit test requesting '2 days' worth of seconds to allow
values for 47, 48, or 49 hours.  47 and 49 happen when crossing time
change boundaries.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1671165: Fix web client build error
Kathy Lussier [Wed, 8 Mar 2017 16:51:35 +0000 (11:51 -0500)]
LP#1671165: Fix web client build error

Bower install was grabbing a later version of angular-cookies than we wanted,
resulting in errors when attempting to build the web client. Changing a
caret to a tilde in the bower.json files keeps us to a 1.5.x version of
angular-cookies, making web client builds happy.

Many thanks to Ben Shum for finding the solution to this problem!

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
2 years agoLP#1642378 Webstaff negative balance UI progress dialog
Bill Erickson [Fri, 3 Mar 2017 16:42:44 +0000 (11:42 -0500)]
LP#1642378 Webstaff negative balance UI progress dialog

Display a progress dialog while loading the Patrons With Negative
Balances UI.  Dialog starts indeterminate, morphing into
semi-determinate as patron data streams in.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1642378 Webstaff Negative Balance org select repairs
Bill Erickson [Mon, 27 Feb 2017 21:53:52 +0000 (16:53 -0500)]
LP#1642378 Webstaff Negative Balance org select repairs

1. Disable org units in the org unit selector that cannot have users.

Additional code cleanup:

2. The org selector calls egStartup internally, so if the page
controller has no need to wait on the startup to complete, then it does
not need to manually invoke the startup.

3. No longer necessary to manually track the selected org unit from the
org selector directive.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1642378 Webstaff org selector misc. repairs
Bill Erickson [Mon, 27 Feb 2017 21:43:09 +0000 (16:43 -0500)]
LP#1642378 Webstaff org selector misc. repairs

1. Always apply default values after egStartup.go() has completed.
   Among other things, this prevents the occaisonal "cannot call ws_ou()
   on an undefined value" errors bubbling up from the org selector
   when an attempt to set default values occured before egAuth had
   retrieved the user (which occurs during startup).

2. For consistency, always run the $scope.onchange handler on initial
   page load when a selected value and change handler are defined.
   Similar to #1 above, the initial onchange always fires after
   egStartup has completed.

3. Run the change handler in a $timeout so that the $scope.selected
   value has a chance to propagate to the calling controller's $scope.
   Otherwise, the the calling controller has to manually track the
   selected value (which partially defeats the purpose of having this
   directive in the first place).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1653001 Hold pull list progress dialog
Bill Erickson [Thu, 2 Mar 2017 23:05:05 +0000 (18:05 -0500)]
LP#1653001 Hold pull list progress dialog

Display a progress dialog while loading the holds pull list grid and the
when collecting data for printing the holds pull list.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1653001 webstaff: Holds pull list sortable columns
Bill Erickson [Wed, 20 Aug 2014 20:45:47 +0000 (16:45 -0400)]
LP#1653001 webstaff: Holds pull list sortable columns

Retrieve holds for the pull list via the canned "ahopl" pull list IDL
class.  This lets the grid fetch the data via canned flattener query,
supporting server-side sort/limit/offset options.

To retain all previous UI behavior, primarily editing hold attributes
(e.g. notification prefs), hold details for each hold have to be fetched
(and cached) in addition to the main grid data.  The grid renders and
sorts the flattener data, then grid actions act upon the fleshed hold
details data.

Commit also includes:

1. Added some missing IDL links for the "ahopl" class.
2. Micro-optimization to egGrid to exit early when an invalid IDL path
   is provided.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1653001 Hold details authoritative API cstore maintenance
Bill Erickson [Fri, 30 Dec 2016 16:54:08 +0000 (11:54 -0500)]
LP#1653001 Hold details authoritative API cstore maintenance

Avoid cstore exhaustion during .authorative API calls that run
Holds:retrieve_hold_queue_status_impl() by using the in-transaction
editor for YAOUS lookups instead of allowing the lookups to create their
own cstore connections, each spawning a new transaction, since
CStoreEditor is in authoritative mode.

Since CStoreEditor authoritative handling leaves each cstore transaction
open until the API call completes, and in this case, each hold in the batch
lookup resulted in 2 additional open cstore connections per hold, a batch
lookup of (say) 15 holds, meant 31 cstore connections were opened in one API
call.

Telling the YAOUS lookup to use the existing editor means the same call
completes with 1 cstore connection.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1522638 Patron search uses progress modal
Bill Erickson [Fri, 24 Feb 2017 17:12:21 +0000 (12:12 -0500)]
LP#1522638 Patron search uses progress modal

Use the progress modal dialog in the web staff patron search UI for
consistency / code re-use.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>