Dan Scott [Thu, 1 Oct 2015 20:13:45 +0000 (16:13 -0400)]
Doc build: update the implicit ID for release notes
The implicit ID for a given heading changes each release as we update
the release notes, so bump 2.8 to 2.9 so that the reference to the ID
can be resolved.
Dan Scott [Thu, 1 Oct 2015 20:15:12 +0000 (16:15 -0400)]
Doc build: link to the right media file
The screenshot for the list of call numbers is a PNG image, not a JPEG
image, so referring to it with the appropriate extension will make it
show up in the docs and enable the epub and PDF builds to successfully
complete.
Dan Scott [Thu, 1 Oct 2015 20:11:57 +0000 (16:11 -0400)]
Doc build: use XML-compliant IDs
Doc builds that depend on an intermediate XML transform (epub, PDF) also
need to use IDs that comply to the XML standard. In this case, numbers
are not valid NameStartChars:
http://www.w3.org/TR/REC-xml/#NT-NameStartChar
Dan Scott [Thu, 1 Oct 2015 20:10:41 +0000 (16:10 -0400)]
Avoid duplicate IDs in doc build
Defining the same ID twice in the same document results in broken builds
that depend on an intermediate XML transform (epub, PDF), so redefine
the second ID in this document.
Bill Erickson [Tue, 29 Sep 2015 16:10:53 +0000 (12:10 -0400)]
LP#838525 libdbi DATE types translated via gmtime
libdbi assumes a date (w/ no time or timezone) is GMT. Parse the date
via gmtime() instead of localtime() to ensure the date returned to the
caller matches the date in the DB.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Tue, 29 Sep 2015 16:10:31 +0000 (12:10 -0400)]
LP#838525 Store date of birth as SQL DATE type
Upgrade script translates DoB ahead 3 hours before translating to DATE
(from TIMESTAMPTZ) to ensure dates stored in alternate daylight savings
TZ (e.g. -05 vs. -04) are translated to the proper date.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Documentation for negative balance settings in 2.9. The updates in this branch
include:
* Updates of the circulation, patron record, and library settings sections
to reflect the new features contained in the negative balance work.
* General updates, consolidation, and re-organization of some components
of the billing section.
A new understanding and confiuring billing section is still to come, but this
branch brings existing documentaiton up to date.
Chris Sharp noticed another ERROR: cannot ALTER TABLE
"record_attr_definition" because it has pending trigger events
with the 2.8.4 to 2.9.0 upgrade script. I have rearranged the
transactions so that there are now 3.
1. One for the initial inserts and other changes up to 0937.
2. One for the two alter table statements in 0937.
3. One for 0938 to the end (0944).
This resolves the issue and works for me on an upgrade from a
clean 2.8.4 installation.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Stephenson [Thu, 17 Sep 2015 19:12:40 +0000 (15:12 -0400)]
LP 1496977: Duplicate Code in OpenILS::Application::Cat::AssetCommon
It looks like two lines of code got duplicated in commit e2f6cca0 in
AssetCommon. This duplication can lead to data loss for the function
update_fleshed_copies. It also lead to the following warning when
you use OpenILS::Application::Cat::AssetCommon in a script:
"my" variable $sc_entries masks earlier declaration in same scope at
/usr/local/share/perl/5.18.2/OpenILS/Application/Cat/AssetCommon.pm
line 371.
After this patch, the warning disappears.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Docs: Apache config includes examples for "no image"
This commit adds a note about the new commented config blocks in the
example Apache vhost file for providing a custom image for items with no
image. This commit also moves a related section into the "External
Content" section, so all external content info is together.
Docs 2.9: Update and add detail for Holdings Import profile
In order to add details about the new ability to import Stat Cat data
for a copy, this commit adds a table of all the import fields available
in the Holdings Import Profile. It also duplicates some content from
another section about batch importing, and updates the screenshot and
some wording in the original section.
We missed acknowledgements for a few code contributors during the 2.8.3
point release. Adding them here as well as a fix to get the header to display
properly for the 2.8.4 release notes.
Adjusting the release notes entry for conditional negative balances to reflect
recent changes in the code and adding ackwnowledgements. Also, cleaning up some
grammar and removing entries that already made it into point release notes as
bug fixes.
Dan Wells [Tue, 15 Sep 2015 19:28:44 +0000 (15:28 -0400)]
LP#1494544 Complete XUL UI for adjustment vs. void options
This commit does several things to complete the adjustment UI changes.
1) Adds "Adjust to Zero" to the "Actions" menu. It was previously only
on the right-click popup.
2) Shows or hides the void/adjustment controls based on permissions.
3) Generates a new force-verified warning if you attempt to void, but
there is also some chance that doing so would be contrary to your
negative balance policy settings.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Dan Wells [Mon, 14 Sep 2015 15:12:38 +0000 (11:12 -0400)]
LP#1494544 Add ADJUST_BILLS permission to seed data
This commit adds the new ADJUST_BILLS permission to the seed data.
Note that the upgrade script only adds the perm and avoids adding it
to any groups, as that should only be done with local discretion.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Fixes an error that occurs when attempting to refund a negative balance from
the patron's bill record. We removed the staff.patron.bills.handle_refund.
confirm_message string, which caused the error when the handle_refund function
tried to retrieve the string. It turns out the string never displayed in the
client. Therefore, in this branch, we stop the handle_refund function from
trying to retrieve the string. I did the confirmation message for the
adjust_to_zero function since the same issue was occurring there.
Test case: Find a negative balance transaction and, from the patron's bills
record, select the transaction and select the option to Refund. Pre-patch, this
action will generate an error message. Post-patch, this action should generate
a prompt asking the user to confirm the action.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Bill Erickson [Thu, 10 Sep 2015 00:52:14 +0000 (20:52 -0400)]
webstaff: Phys Char Wiz various additions and repairs
* Show <unset> as selector value when no value is selected
* Properly handle gaps (undefined slots) in 007 field value
* Return to origin value when dialog Cancel is chosen
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
webstaff: flat MARC editor now updates model on blur, not change
This fixes a problem where attempting to type in the flat
MARC editor would result in a fromBreaker()/toBreaker() cycle
being run with each keystroke, which (among other things) made
the user have to fight for control of the insertion cursor.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
webstaff: improve performance of open-ils.search.authority.simple_heading.from_xml
Searching authority.record_entry by comparing are.simple_heading
with the results of authority.simple_normalize_heading() can result
in bad query plans; if we calculate the results of that function
first, we have a much better chance of hitting the index on
simple_heading.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>