working/Evergreen.git
2 years agoLP#1689608: Minor fixes
Kathy Lussier [Fri, 21 Jul 2017 16:33:03 +0000 (12:33 -0400)]
LP#1689608: Minor fixes

Fixe a typo in the seed data:
TEXT not NEXT

Also, add the user bucket service to karma test so that our tests are happy.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1689608: Batch user editing
Mike Rylander [Thu, 2 Feb 2017 20:29:46 +0000 (15:29 -0500)]
LP#1689608: Batch user editing

Summary
-------

Currently, editing and deleting of users must be performed on a user-by-user
basis. There are workflows that would benefit from the ability to act on a
set of users, where the changes to all users in the set are the same.

This commit provides a new interface analogous to the Copy Bucket interface
to record the selection and grouping of a set of users into a User Bucket.
The addition of users to a User Bucket is possible from the Patron Search
interface by the use of a new grid Action, and directly on the User Bucket
interface by user barcode. It is also possible to add users by uploading
a text file that contains a list of user barcodes.

From this interface it is possible to perform a set of specific batch update
operations against users generally.

Editing users
-------------

In order to facilitate the update of user data fields, specifically:

 * Active flag
 * Primary Permission Group (group application permissions consulted)
 * Juvenile flag
 * Home Library (UPDATE_USER checked against both old and new value)
 * Privilege Expiration Date
 * Barred flag (BAR_PATRON permission consulted)
 * Internet Access Level

This commit contains a new set of business logic allowing staff to supply new
values for these fields. Creation and immediate processing of a change set
will be made available through a grid Menu item. If the staff user does not
have the UPDATE_USER permission, this option will be disabled.

Each change set requires a name. Buckets may have multiple change sets. All
users in the Bucket at the time of processing will be updated when the change
set is processed, and change sets are processed immediately upon successful
creation. The interface will deliver progress information regarding the
processing stage and percent of completion.

While processing the users, the original value for each field edited will be
recorded for potential future rollback. Users can examine the success and
failure of applied change sets.

The user will be able to rollback the entire change set, but not parts thereof.
The rollback will affect only those users that were successfully updated by the
original change set and may be different from the current set of users in the
Bucket. Users can manually discard change sets, removing them from the
interface but preventing future rollback.

As a batch process, rather than a direct edit, this mechanism explicitly skips
processing of Action/Trigger event definitions for user update.

Deleting users
--------------

In order to facilitate the batch deletion of users, this commit creates a new
set of business logic allowing staff to set the Deleted flag on users.
Creation and immediate processing of a batch delete is made available through
a grid Menu item. If the staff user does not have both the UPDATE_USER and
DELETE_USER permission, this option is disabled. Because of the potential for
damage and the additional required permission, this field change is
specifically segregated from the general Editing functionally described above.

Each delete set requires a name. Buckets may have multiple delete sets. All
users in the Bucket at the time of processing will be marked as deleted when
the delete set is processed. The interface will deliver progress information
regarding the processing stage and percent of completion.

While processing the users, the original value for the "deleted" field will be
recorded for potential future rollback. Users will be able to examine the
success and failure of applied delete sets in the same interface used for the
above described change sets.

As a batch process, rather than a direct edit, this mechanism explicitly skips
processing of Action/Trigger event definitions for user deletion.

This mechanism does not use the Purge User functionality, but instead simply
marks the users as deleted. Future enhancement could add such functionality.

Editing Statistical Category Entries
------------------------------------

In order to facilitate the batch editing, addition, and removal of
Statistical Category Entries for users, this commit creates a new set of
business logic allowing staff to either remove or add & update Entries for
Statistical Categories to which the staff member has access. Processing of
Statistical Category Entry modifications will are available through a grid
Menu item.

All users in the bucket will have their Statistical Category Entries
modified. Unlike user data field updates, modification of Statistical
Category Entries is permanent and cannot be rolled back. No named change
sets are required. The interface will deliver progress information regarding
the processing stage and percent of completion.

As a batch process, rather than a direct edit, this mechanism explicitly skips
processing of Action/Trigger event definitions for user update.

New service requirement
-----------------------

This new functionality makes use of the QStore service, which was previously
unused in production.  If this service has been removed from the configuration
of a live Evergreen instances, it will need to be added back in order for
batch user editing to succeed.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Scott Thomas <scott.thomas@sparkpa.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Conflicts:
Open-ILS/src/templates/staff/circ/patron/index.tt2
Open-ILS/web/js/ui/default/staff/circ/patron/app.js

2 years agoLP#1712840: extend fix to circ and holds history tabs
Galen Charlton [Fri, 25 Aug 2017 14:29:43 +0000 (10:29 -0400)]
LP#1712840: extend fix to circ and holds history tabs

This patch fixes the remaining two instances of a
bare 'IF ebook_api.enabled' test.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
2 years agoLP#1712840 Ebook tabs always visible in My Account
McCanna [Fri, 25 Aug 2017 13:53:14 +0000 (09:53 -0400)]
LP#1712840 Ebook tabs always visible in My Account

Corrects a problem in My Account where the ebook tabs
on the checkouts and holds pages were always visible
regardless of whether the ebook_api.enabled value was
set to true or false.

Signed-off-by: McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
2 years agoLP#1712657: stamping schema update (fixup)
Ben Shum [Sat, 26 Aug 2017 22:39:03 +0000 (18:39 -0400)]
LP#1712657: stamping schema update (fixup)

Originally committed with the wrong upgrade stamp number. Move that file,
and also update the baseline schema upgrade version.

Signed-off-by: Ben Shum <ben@evergreener.net>
2 years agoLP#1712657: stamping schema update
Jason Etheridge [Fri, 25 Aug 2017 21:40:44 +0000 (17:40 -0400)]
LP#1712657: stamping schema update

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
2 years agoLP#1712657 Merge patron checkout history
Bill Erickson [Wed, 23 Aug 2017 19:39:16 +0000 (15:39 -0400)]
LP#1712657 Merge patron checkout history

Transfer checkout history rows to the destination user during patron
merge.

To Test:

1. Enable circ history tracking for 2 users, ideally 2 with same
   last name for easy searching.
2. Check out items to both patrons.
3. Load the 2 patrons in the patron search UI and merge one into the other.
4. action.usr_circ_history rows previously linked to the deleted patron
   will now be linked to the active/lead patron.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
2 years agoLP1713064: String / Float Value ACP Editor Fix
Jason Boyer [Fri, 25 Aug 2017 15:13:22 +0000 (11:13 -0400)]
LP1713064: String / Float Value ACP Editor Fix

Add an Angular directive to the vol/copy editor
to convert and format numbers stored as strings
in acp objects.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1685929: (follow-up) fix passing copy when opening volume/copy editor
Galen Charlton [Fri, 25 Aug 2017 19:51:44 +0000 (15:51 -0400)]
LP#1685929: (follow-up) fix passing copy when opening volume/copy editor

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1685929: adjust egItem.print_spine_labels()
Galen Charlton [Fri, 25 Aug 2017 19:17:25 +0000 (15:17 -0400)]
LP#1685929: adjust egItem.print_spine_labels()

Make egItem.print_spine_labels() accept a list of copy
IDs and make the caller responsible for putting that list together.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1685929: (follow-up) fix rebase error
Galen Charlton [Fri, 25 Aug 2017 15:49:31 +0000 (11:49 -0400)]
LP#1685929: (follow-up) fix rebase error

Intentionally not putting two actions in the Show group.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1685929: add implementation print spine labels to checkin grid
Cesar Velez [Tue, 1 Aug 2017 21:42:00 +0000 (22:42 +0100)]
LP#1685929: add implementation print spine labels to checkin grid

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1685929 - Extract itemSvc from item module to core
Cesar Velez [Fri, 11 Aug 2017 15:11:45 +0000 (16:11 +0100)]
LP#1685929 - Extract itemSvc from item module to core

Refactored Missing Pieces module and CheckIn to use
shared functionally of itemSvc, which is now it's own
separate file.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Conflicts:
Open-ILS/web/js/ui/default/staff/cat/item/app.js

2 years agoLP#1685929-Adds more XUL parity to Webstaff checkIn
Cesar Velez [Fri, 11 Aug 2017 15:00:29 +0000 (16:00 +0100)]
LP#1685929-Adds more XUL parity to Webstaff checkIn

Checkin Grid context actions like Add Items to Bucket, Show Holds on Bib, Show
Last Few Circulations, Edit Item Attributes, Mark Item Missing Pieces,
Print Spine Label, were missing from CheckIn in webstaff.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Conflicts:
Open-ILS/web/js/ui/default/staff/cat/item/app.js

2 years agoLP#1684988: add opt-in check to patron service
Jeff Davis [Mon, 21 Aug 2017 23:12:46 +0000 (16:12 -0700)]
LP#1684988: add opt-in check to patron service

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
2 years agoLP1712922: Exclude Deleted ACPL in Vol/Copy Editor
Jason Boyer [Thu, 24 Aug 2017 21:34:02 +0000 (17:34 -0400)]
LP1712922: Exclude Deleted ACPL in Vol/Copy Editor

Just what it says on the tin. When loading the list of ACPL
in the editor only retrieve the non-deleted locations.

Tester's note: there's no database contraint that strictly
prevents a copy from linking to a deleted location, so for
items like that, the copy location selector will be blank. This
is an uncommon situation, but Evergreen admins can identify
such items by running the following query:

select acp.id, acp.barcode, acpl.name
from asset.copy acp
join asset.copy_location acpl on (acpl.id = acp.location)
where not acp.deleted
and acpl.deleted
order by acp.id;

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoforward-port 2.12.4-2.12.5 DB update
Galen Charlton [Thu, 24 Aug 2017 22:29:13 +0000 (18:29 -0400)]
forward-port 2.12.4-2.12.5 DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoForward-port 2.11.8 upgrade script
Dan Wells [Thu, 24 Aug 2017 21:54:38 +0000 (17:54 -0400)]
Forward-port 2.11.8 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 years agoDocs: Release notes for 2.12.5 maintenance release
Kathy Lussier [Wed, 23 Aug 2017 21:02:28 +0000 (17:02 -0400)]
Docs: Release notes for 2.12.5 maintenance release

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoDocs: Release notes for the 2.11.8 point release
Kathy Lussier [Wed, 23 Aug 2017 20:22:45 +0000 (16:22 -0400)]
Docs: Release notes for the 2.11.8 point release

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP 1708728 - Fix Stripe penny errors introduced by perl int() function
Michele Morgan [Wed, 9 Aug 2017 15:36:20 +0000 (11:36 -0400)]
LP 1708728 - Fix Stripe penny errors introduced by perl int() function

Fixes the issue where payment amounts sent to Stripe can be one cent less
than the actual Evergreen payment due to use of the perl int() function.

To test
-------
A Stripe account is required to view transactions on the Stripe side.
To enable test payments, Stripe testing API keys need to be entered
in the Evergreen ou settings:

credit.processor.stripe.pubkey
credit.processor.stripe.secretkey

- Add a bill to a patron record with the following amounts: $8.20
- Login to the opac as the patron and pay the bill.
- View the transaction on the Stripe side and see that it is one cent
  less than the paid bill in Evergreen.
- Apply the patch.
- Repeat the steps above.

- On the Stripe side, see that the Stripe amount and Evergreen amount
  now match.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoLP#1708485: (follow-up) improve dest_courier_code support
Galen Charlton [Wed, 23 Aug 2017 19:22:28 +0000 (15:22 -0400)]
LP#1708485: (follow-up) improve dest_courier_code support

This patch ensures that dest_courier_code is added to
the printer context; it also displays the courier code (if set)
on the transit modal and mentions dest_courier_code in the
inline documentation for transit and hold slips.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1708485 - Add courier code variable to transit slips.
Chris Sharp [Wed, 9 Aug 2017 18:30:43 +0000 (14:30 -0400)]
LP#1708485 - Add courier code variable to transit slips.

This code, developed by Bill Erickson, creates a variable/macro
for {{dest_courier_code}} for receipt templates in the web client.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1699566: item barcode completion in web client
Jeff Davis [Wed, 12 Jul 2017 20:38:13 +0000 (13:38 -0700)]
LP#1699566: item barcode completion in web client

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agolp1709966 webstaff: Hold Verify prompt
Jason Etheridge [Wed, 16 Aug 2017 13:05:25 +0000 (09:05 -0400)]
lp1709966 webstaff: Hold Verify prompt

This implements the prompt and call logic for the Hold Verify feature for copy
locations.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1710747: Absolute URL for media_prefix in templates
Dan Scott [Tue, 15 Aug 2017 14:19:22 +0000 (10:19 -0400)]
LP#1710747: Absolute URL for media_prefix in templates

If OILSWebMediaPrefix is set in the Apache configuration, then
the ctx.media_prefix TT2 template variable uses that value as the
hostname; otherwise it is null, resulting in many relative URLs for
images, CSS, and JavaScript files.

Normally this is not a problem, but the Open Graph image property
requires a full absolute URL rather than the relative URL that would
previously result on the record summary page in the absence of the
OILSWebMediaPrefix variable having been set in the Apache config.

This patch tweaks the EGWeb handler to fall back to the base hostname in
the absence of the OILSWebMediaPrefix variable, thus ensuring that all
uses of ctx.media_prefix result in an absolute URL.

Test Plan:
Pre-patch - Visit a record summary page in the catalog. View the source of the
page. In the head section, find the og:image meta property. The content will
display a relative URL to the record's book jacket cover image.

Post-patch - When viewing the source of the page, og:image will display the
full URL.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
2 years agoLP#1694577: exclude empheral search results folder from selector
Galen Charlton [Wed, 23 Aug 2017 16:08:12 +0000 (12:08 -0400)]
LP#1694577: exclude empheral search results folder from selector

Otherwise, the folder selector for the move or clone template
actions includes a blank entry.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
2 years agoLP#1694577: tweak searching for words in report templates
Galen Charlton [Wed, 23 Aug 2017 15:54:32 +0000 (11:54 -0400)]
LP#1694577: tweak searching for words in report templates

Use \m to recognize beginning-of-word boundaries; this fixes
an issue where you couldn't use "clone" to retrieve templates
whose name was of the form "foo (clone)".

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
2 years agoLP#1694577 Release notes for report template search
Bill Erickson [Sat, 12 Aug 2017 15:25:16 +0000 (11:25 -0400)]
LP#1694577 Release notes for report template search

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
2 years agoLP#1694577 Reports template searching and paging
Bill Erickson [Sat, 12 Aug 2017 15:12:17 +0000 (11:12 -0400)]
LP#1694577 Reports template searching and paging

Adds a new template search from along the top of the reports interface.
Templates may be searched name and/or description.

Adds paging support to the template, reports, and output interfaces.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
2 years agoLP#1694577 Report templates search API & paging
Bill Erickson [Sat, 12 Aug 2017 15:08:30 +0000 (11:08 -0400)]
LP#1694577 Report templates search API & paging

Adds new API call open-ils.reporter.search.templates allowing search of
reporter template names and/or descriptions.  Searching is
case-insensitive, any order, with left-anchored words.  Searching can be
for specific folders or all folders visible to the calling user.

Adds paging support (limit / offset) for retriving templates, reports,
and outputs.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
2 years agoLP#1712362 Display single conjoined items
Dan Scott [Tue, 22 Aug 2017 14:08:22 +0000 (10:08 -0400)]
LP#1712362 Display single conjoined items

An off-by-one error resulted in single conjoined items not being linked
from their peer bib record.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoLP#1703678 Display foreign item location and status
Dan Scott [Wed, 12 Jul 2017 14:07:23 +0000 (10:07 -0400)]
LP#1703678 Display foreign item location and status

We were using copy_info instead of the foreign item's data to try to display
location and status of foreign items. As copy_info had not been initialized,
it displayed nothing. Use the foreign item data instead for location and
status.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoLP#1703678 Show foreign copies even if only one
Dan Wells [Tue, 31 May 2016 19:51:47 +0000 (15:51 -0400)]
LP#1703678 Show foreign copies even if only one

If a record has no copies of its own, but it does have a foreign copy
on a peer bib, show that copy info (and the link to the other record).

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoLP#1624443 - TPAC 500 error after adding duplicate title to Temp List
Cesar Velez [Tue, 8 Aug 2017 20:13:15 +0000 (16:13 -0400)]
LP#1624443 - TPAC 500 error after adding duplicate title to Temp List

Credit to gmcharlt, prevents the my list (temporary list) page from
crashing when a user has added a title to the list more than once.
This can happen if they add a title then login, then redo search and
add same title. Per Galen, it looks like an issue with
OpenSRF::MultiSession parallel record retrieval causing some kind of
race condition when there are duplicate entries in the list.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 years agoTranslation updates - newpot
Ben Shum [Tue, 15 Aug 2017 20:45:58 +0000 (16:45 -0400)]
Translation updates - newpot

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoDocs: Asciidoc fix
Angela Kilsdonk [Mon, 14 Aug 2017 23:21:34 +0000 (16:21 -0700)]
Docs: Asciidoc fix
Asciidoc fix for report data type icons.

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
3 years agoLP#1701001: add release notes
Galen Charlton [Mon, 31 Jul 2017 20:57:06 +0000 (16:57 -0400)]
LP#1701001: add release notes

Here is the test plan for the feature:

[1] In the web staff client, perform a catalog search. From search
    results, choose Place Hold.
[2] In the form that displays, click the 'Patron Search' button.
[3] Verify that a modal with a patron search form is displayed.
[4] Search for a patron, then select one and click the 'Select'
    button.
[5] Verify that the patron's barcode is inserted into the patron
    barcode input.
[6] Verify that submitting the form successfully places the hold.
[7] Verify that the feature works from a bib record details page.
[8] Verify that the Patron Search button does not show up when
    using the place hold form in the public catalog.
[9] Verify that normal patron search, retrieval, and registration
    functionality continues to work, as this patch series does some
    refactoring to create a reusable Angular patron search service
    and templates.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
3 years agoLP#1701001: add "patron search" button to OPAC place hold form
Galen Charlton [Fri, 28 Jul 2017 20:54:55 +0000 (16:54 -0400)]
LP#1701001: add "patron search" button to OPAC place hold form

This button is displayed only when the public catalog is embedded
in the web staff client and the iframe's controller explicitly
unhides the button.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
3 years agoLP#1701001: add search-to-hold to catalog app
Galen Charlton [Fri, 28 Jul 2017 20:55:22 +0000 (16:55 -0400)]
LP#1701001: add search-to-hold to catalog app

This patch teaches the web staff client's catalog app how
to activate the patron search button in the embedded catalog's
place hold form. It also adds a handler for the button action
to display a modal to allow the staff member to search
for and select a patron, then injects the patron's barcode
into the form.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
3 years agoLP#1701001: split patron search form into separate templates
Galen Charlton [Fri, 28 Jul 2017 20:55:37 +0000 (16:55 -0400)]
LP#1701001: split patron search form into separate templates

This patch breaks up the patron search form and results into
separate templates and adds a template for a patron selector
modal.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
3 years agoLP#1701001: carve out a reusable patron search service
Galen Charlton [Fri, 26 May 2017 20:41:38 +0000 (20:41 +0000)]
LP#1701001: carve out a reusable patron search service

This patch moves the patron search service and the base
patron search controller into a separate, reusable
file.  The core patron search service is available for
injection as patronSvc from the new egPatronSearchMod, while
BasePatronSearchCtrl now exists as a base controller for the
patron search form that can be extended as needed by doing
something like this:

module.controller('DerivedPatronSearchCtrl', [
             '$scope', '$controller',
    function ($scope, $controller) {
    // Initialize the super class and extend it.
    angular.extend(this, $controller('BasePatronSearchCtrl', {$scope: $scope}));
...

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
3 years agoLP#1710010: Fix item status file upload
Mike Rylander [Thu, 10 Aug 2017 20:41:03 +0000 (16:41 -0400)]
LP#1710010: Fix item status file upload

The item service currently living inside the item status app does not know how
to fetch multiple barcodes at once.  So, we'll loop over them and refresh the
grid when they're all retrieved.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1702968 - Add missing error string - mark item damaged.
Chris Sharp [Fri, 7 Jul 2017 17:04:35 +0000 (13:04 -0400)]
LP#1702968 - Add missing error string - mark item damaged.

When marking an item damaged for a circulation that has been
archived/aged, the patron receives an error that the string
associated with staff.cat.util.mark_item_damaged.item_no_linked_patron
is not there.  This branch adds it.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1705524: fix a quoting issue in the DB update scripts
Galen Charlton [Fri, 11 Aug 2017 19:35:38 +0000 (15:35 -0400)]
LP#1705524: fix a quoting issue in the DB update scripts

... toss enough quotes at the problem, and eventually one
will make it to the end.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1705524 Stamping org timezones SQL
Bill Erickson [Fri, 11 Aug 2017 18:25:24 +0000 (14:25 -0400)]
LP#1705524 Stamping org timezones SQL

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP#1705524: Minor cleanup in prep for committing
Mike Rylander [Thu, 3 Aug 2017 18:18:30 +0000 (14:18 -0400)]
LP#1705524: Minor cleanup in prep for committing

1. Provide an admin-friendly summary of changes at the top of the release notes.
2. Change quoting of optional post-upgrade SQL echoing in the upgrade script.
3. Fix preexisting issue with variable interpolation inside an alert modal.
4. Protect against null or empty date fields when formatting.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
5. Added if (date == 'now') check.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP#1705524 Grid value filter defaults to null
Bill Erickson [Thu, 3 Aug 2017 15:43:56 +0000 (11:43 -0400)]
LP#1705524 Grid value filter defaults to null

Avoid use of Perl undef in JS.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
3 years agoLP#1705524 Closed dates editor handles no timezones
Bill Erickson [Thu, 3 Aug 2017 15:35:31 +0000 (11:35 -0400)]
LP#1705524 Closed dates editor handles no timezones

Fix issue in closed dates editor where it failed creating new closed
dates when an org unit had no value applied for the lib.timezone org
unit setting.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
3 years agoLP#1705524 Load workstation org timezone in startup
Bill Erickson [Thu, 3 Aug 2017 15:25:56 +0000 (11:25 -0400)]
LP#1705524 Load workstation org timezone in startup

Piggy-back on the batch org setting call made during page startup to
load / pre-cache the timezone setting for the workstation org unit.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
3 years agoLP#1705524: Override angular date filter
Mike Rylander [Wed, 2 Aug 2017 20:56:20 +0000 (16:56 -0400)]
LP#1705524: Override angular date filter

Here we'll use moment.js to format all dates that want to use the angular date
filter, for consistency and standards compliance.  The primary benefit is the
ability to use a proper timezone (region) rather than just a simple GMT offset.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP#1705524 Adding timezone release note
Mike Rylander [Mon, 24 Jul 2017 14:27:09 +0000 (10:27 -0400)]
LP#1705524 Adding timezone release note

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Tina Ji <tji@sitka.bclibraries.ca>
3 years agoLP#1705524: Adjust day-granular due date pushing
Mike Rylander [Mon, 24 Jul 2017 14:13:31 +0000 (10:13 -0400)]
LP#1705524: Adjust day-granular due date pushing

Now that due dates are globally stored in the configured timezone of the
circulating library, the automatic adjustment to day-granular due dates needs
to take those timezones into account.

An optional SQL command is provided by the upgrade script to retroactively
adjust existing due dates after library configuration is complete.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Tina Ji <tji@sitka.bclibraries.ca>
3 years agoLP#1705524: Use the new grid configuration for date format in the bills list
Mike Rylander [Thu, 20 Jul 2017 21:52:38 +0000 (17:52 -0400)]
LP#1705524: Use the new grid configuration for date format in the bills list

The bills list in the patron interface predated any grid date formatting, so
we bring it into the modern world.

This also enhances the grid autoformatting for dates to support both flattened
and dot-pathed item layout.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Tina Ji <tji@sitka.bclibraries.ca>
3 years agoLP#1705524: Honor timezone of the acting library where appropriate
Mike Rylander [Wed, 21 Jun 2017 18:03:29 +0000 (14:03 -0400)]
LP#1705524: Honor timezone of the acting library where appropriate

This is a followup to the work done in bug 1485374, where we added the ability
for the client to specify a timezone in which timestamps should be interpreted
in business logic and the database.

Most specifically, this work focuses on circulation due dates and the closed
date editor. Due dates, where displayed using stock templates (including
receipt templates) and used for fine calculation, are now manipulated in the
library's configured timezone. This is controlled by the new 'lib.timezone'
YAOUS, loaded from the server when required. Additionally, closings are
recorded in the library's timezone so that so that due date calculation is more
accurate. The closed date editor is also taught how to display closings in the
closed library's timezone. Closed date entries also explicitly record if they
are a full day closing, or a multi-day closing. This significantly simplifies
the editor, and may be useful in other contexts.

To accomplish this, we use the moment.js library and the moment-timezone addon.
This is necessary because the stock AngularJS date filter does not understand
locale-aware timezone values, which are required to support DST. A simple
mapper translates the differences in format values from AngularJS date to
moment.js.

Of special note are a set of new filters used for formatting timestamps under
certain circumstances. The new egOrgDateInContext, egOrgDate, and egDueDate
filters provide the functionality, and autogrid is enhanced to make use of
these where applicable. egGrid and egGridField are also taught to accept
default and field-specific options for applying date filters. These filters may
be useful in other or related contexts.

The egDueDate filter, used for all existing displays of due date via Angular
code, intentionally interprets timestamps in two different ways WRT timezone,
based on the circulation duration. If the duration is day-granular (that is,
the number of seconds in the duration is divisible by 86,400, or 24 hours worth
of seconds) then the date is interpreted as being in the circulation library's
timezone. If it is an hourly loan (any duration that does not meet the
day-granular criterium) then it is instead displayed in the client's timezone,
just as all other timestamps currently are, because of the work in 1485374.

The OPAC is adjusted to always display the due date in the circulating
library's timezone. Because the OPAC displays only the date portion of the due
date field, this difference is currently considered acceptable. If this proves
to be a problem in the future, a minor adjustment can be made to match the
egDueDate filter logic.

This work, as with 1485374 was funded by SITKA, and we thank them for their
partnership in making this happen!

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Tina Ji <tji@sitka.bclibraries.ca>
3 years agoLP#1659928: fix regression introduce by previous patches
Galen Charlton [Fri, 11 Aug 2017 16:23:01 +0000 (12:23 -0400)]
LP#1659928: fix regression introduce by previous patches

A couple other places that use the standing_penalty list needed to
be adjusted to account for the non-de-fleshing.

Kudos to Jason Etheridge for noting the live_t test failure. Also,
unit tests FTW.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP 1542495: Release Notes and Sample Config Change.
Jason Stephenson [Sun, 8 Jan 2017 00:49:12 +0000 (19:49 -0500)]
LP 1542495: Release Notes and Sample Config Change.

In addition to adding the release note file, we alter the location of
the encoding element in oils_sip.xml.example to the new, recommended
location.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Martha Driscoll <driscoll@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP 1542495: Remove OpenILS::SIP::clean_text.
Jason Stephenson [Mon, 2 Jan 2017 15:51:48 +0000 (10:51 -0500)]
LP 1542495: Remove OpenILS::SIP::clean_text.

This commit removes the OpenILS::SIP::clean_text utility function and
all references to it in the OpenILS::SIP modules.  Its job is now done
in SIPServer's write_msg routine.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Martha Driscoll <driscoll@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1681864: Add pocommentclean for db.seed cleanup prior to updatepo
Ben Shum [Mon, 17 Apr 2017 21:20:25 +0000 (17:20 -0400)]
LP#1681864: Add pocommentclean for db.seed cleanup prior to updatepo

By adding a segment to run pocommentclean against the db.seed locale file
prior to doing updatepo against the file from the PO template, we clear
any unwanted old and outdated comment IDs prior to applying clean newly
synchronized comment IDs from the PO template.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1160347: (follow-up) fix a couple field class entries
Galen Charlton [Thu, 10 Aug 2017 21:26:24 +0000 (17:26 -0400)]
LP#1160347: (follow-up) fix a couple field class entries

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1160347 - Fixing missing closing parens in INSERT statement
Chris Sharp [Wed, 9 Aug 2017 12:42:29 +0000 (08:42 -0400)]
LP#1160347 - Fixing missing closing parens in INSERT statement

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1160347: i18n fixes for db.seed
Ben Shum [Wed, 19 Apr 2017 13:10:33 +0000 (09:10 -0400)]
LP#1160347: i18n fixes for db.seed

Some strings were not marked for translation. Also, there were strings
with incorrect IDs, or mismatched entries.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1709932: recognize more strings from oils_i18n_gettext()
Galen Charlton [Thu, 10 Aug 2017 16:45:58 +0000 (12:45 -0400)]
LP#1709932: recognize more strings from oils_i18n_gettext()

This patch makes db-seed-i18n.py more flexible about
where commas between strings in invocations of oils_i18n_gettext()
can appear, reduces the chances that strings fail to be grabbed
for translation. It also improves the error message shown
when parsing errors occur.

To test
-------
[1] Apply patch and run

    cd build/i18n && make sql2pot

[2] Verify that no error messages are produced during
    this step.
[3] Inspect the changes to po/db.seed/db.seed.pot and
    verify that additional strings are added, including
    "Item Print Label Font Family".
[4] (optional) Deliberately remove a comma from an
    oils_i18n_gettext invocation in 950.data.seed-values.sql
    and run make sql2pot again. The error message shoudl
    now include the failing chunk of text.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agoLP#1659928: (follow-up) the flesh stays on...
Galen Charlton [Thu, 10 Aug 2017 20:43:36 +0000 (16:43 -0400)]
LP#1659928: (follow-up) the flesh stays on...

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP1659928 SIP is not respecting standing penalties for charge ok and hold ok
blake [Thu, 15 Jun 2017 18:39:08 +0000 (13:39 -0500)]
LP1659928 SIP is not respecting standing penalties for charge ok and hold ok

This will include the block_list data in the blessed user object. This allows
charge_ok, renew_ok and hold_ok to determine if any of the respective blocks are
present in any of the applied penalties.

To test
-------
[1] Using a SIP emulator, issue a 63 message to fetch information
    about a patron that has nothing preventing it from doing loans,
    renewals, or hold requests, e.g.,

    6300020060329    201700Y         AOevergreen|AA99999384262||

[2] Verify that the first six positions of the response are
    '64  Y '
[3] Apply a standing penalty that blocks circulation and repeat
    step 1. This time, the response should start with '64Y Y '
[4] Apply other standing penalties that block holds or renewals
    and repeate step 1, verifying that the various privileges
    denied positions in the 64 response have expected values.
[5] Archive all of the penalties used during testing, then
    verify that the response returns to '64  Y ...'

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoDocs: Web Client Data Types
Angela Kilsdonk [Thu, 10 Aug 2017 19:08:34 +0000 (12:08 -0700)]
Docs: Web Client Data Types

Updated chart of data type icons in web client.

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
3 years agosyntax: end-quote for stored procedure
Jason Etheridge [Thu, 10 Aug 2017 18:06:08 +0000 (14:06 -0400)]
syntax: end-quote for stored procedure

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
3 years agosyntax error in schema script
Jason Etheridge [Thu, 10 Aug 2017 18:01:52 +0000 (14:01 -0400)]
syntax error in schema script

incidentally, I'm a huge fan of comma-first style, I18N-breakage aside :)

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
3 years agoStamping populariy parameter upgrade scripts
Mike Rylander [Thu, 10 Aug 2017 15:16:13 +0000 (11:16 -0400)]
Stamping populariy parameter upgrade scripts

Also, the org-count parameter function is adjusted to consistently find
and count copies by circ lib.  Because this parameter is about counting
copies on the shelves of libraries, this makes more sense than owing
library.  Changed in consultation with Kathy Lussier.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
3 years agoLP#1688099: Popularity parameter for the number of OUs that own a title
Kathy Lussier [Mon, 31 Jul 2017 17:43:38 +0000 (13:43 -0400)]
LP#1688099: Popularity parameter for the number of OUs that own a title

Creates a new badge that calculates a score based on a count of libraries
that own a copy of a title. The badge is based on libraries that are the copy's
circulation library. The intent of the badge is to measure the breadth of
ownership within a particular consortium with the hope that it doesn't
generate as many 'false hits' that are seen with the similar Total Copy Counts
badge.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
3 years agoLP#1688096: Popularity parameter for in-house use
Kathy Lussier [Mon, 31 Jul 2017 20:36:50 +0000 (16:36 -0400)]
LP#1688096: Popularity parameter for in-house use

Adds a new popularity parameter based on in-house use over time. The parameter
can be used for creating a statistically-generated popularity badge for titles.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
3 years agoLP#1709476 Copy summary aged circ display repair
Bill Erickson [Wed, 9 Aug 2017 20:41:53 +0000 (16:41 -0400)]
LP#1709476 Copy summary aged circ display repair

Always check active and aged circs (via "aacs" class) for circs to
display for a given copy in the item status Quick Summary and Recent
Circ History tabs.  When a aged circ is encountered, display the '<Aged
Circulation>' tag in lieu of the patron's name.

To test:
[1] Checkout and checkin a copy.
[2] Checkout and checkin the same copy to a different patron
[3] Manually delete the 2nd circulation in the database.
[4] Load the Item Status interface for the copy.
[5] Confirm chekout time, etc. for the 2nd show in the Quick Summary
    circulation data.
[6] Confirm the patron displayed under the 'Recent Circ History' tab
    shows '<Aged Circulation>'

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1691563: Prevent "Use of freed value in iteration" error during adjust to zero
Jeff Davis [Wed, 17 May 2017 21:16:26 +0000 (14:16 -0700)]
LP#1691563: Prevent "Use of freed value in iteration" error during adjust to zero

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
3 years agoStamping upgrade script for slim all-circs view
Mike Rylander [Wed, 9 Aug 2017 19:37:05 +0000 (15:37 -0400)]
Stamping upgrade script for slim all-circs view

Signed-off-by: Mike Rylander <mrylander@gmail.com>
3 years agoLP#1695007 Webstafff circ group summary display fix
Bill Erickson [Thu, 1 Jun 2017 20:11:11 +0000 (16:11 -0400)]
LP#1695007 Webstafff circ group summary display fix

Repair display of the Total Circs, Last Renewed On, and Renewal
Workstation fields in the web staff item summary Recent Circ History tab
Most Recent Circ Group Display.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
3 years agoLP#1695007 All-circulations slim DB VIEW
Bill Erickson [Thu, 1 Jun 2017 14:56:11 +0000 (10:56 -0400)]
LP#1695007 All-circulations slim DB VIEW

Adds a new view action.all_circulation_slim which collects all
action.circulation and action.aged_circulation rows into a single set,
without the added joins for copy and patron data imposed by the existing
action.aged_circulation view.

The new leaner view is now used by various other views and APIs in place
of the all_circulation view:

DB:  action.all_circ_chain()
DB:  action.summarize_all_circ_chain()
DB:  rating.percent_time_circulating()
API: open-ils.circ.retrieve
API: open-ils.circ.copy_checkout_history.retrieve
API: open-ils.circ.copy_details.retrieve
API: open-ils.circ.renewal_chain.retrieve_by_circ[.summary]
API: open-ils.circ.prev_renewal_chain.retrieve_by_circ[.summary]

To Test (webstaff style):

[1] Open a copy in the web staff Item Status / Detail View interface
    that has live and aged circulations.
[2] Open the Recent Circ History tab
[3] Confirm relevent fields for both types of circs display as expected
    and that the Patron field for the aged circulation shows a value of
    <Aged Circulation>

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
3 years agoLP#1098685: Require OPAC patron holds w/ phone/SMS notification to enter that info
Cesar Velez [Tue, 23 May 2017 20:36:44 +0000 (16:36 -0400)]
LP#1098685: Require OPAC patron holds w/ phone/SMS notification to enter that info

This provides some plain vanilla JS form validation, and error feedback
using a yellow background color on the culprit input field.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1480432: stamp DB update
Galen Charlton [Tue, 8 Aug 2017 21:28:43 +0000 (17:28 -0400)]
LP#1480432: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1480432: choose broadest depth if staff has same perm multiple times
Michele Morgan [Thu, 29 Sep 2016 20:35:20 +0000 (16:35 -0400)]
LP#1480432: choose broadest depth if staff has same perm multiple times

Fixes a staff user permission depth issue that can exist when multiple
permission groups are assigned. In particular, this patch clarifies
that if a given permission is assigned to a staff member multiple times,
e.g., via mutiple profiles or by individual permission mapping, whatever
permission depth is the broadest will apply.

To test
-------
[1] Run the t/lp1480432_test_func.permissions.usr_perms_depth_sort.pg
    pgTAP test.
[2] Set up a staff user that has the same permission at multiple
    depths, and verify that its scope of applicability applies
    at the broadest depth. For example, if you give SET_CIRC_CLAIMS_RETURNED
    at system and consortial depth, verify that the staff user can
    mark any loan as claims returned regardless of system.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1480432 - Added tests for permission.usr_perms() change
Cesar Velez [Fri, 2 Jun 2017 14:36:30 +0000 (10:36 -0400)]
LP#1480432 - Added tests for permission.usr_perms() change

Making sure that returned permissions are depth sorted ascending.
Tests and verifies mmorgan's patch for said lp bug.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1463166 Apply funds from view/place orders and search
Bill Erickson [Fri, 4 Aug 2017 15:54:15 +0000 (11:54 -0400)]
LP#1463166 Apply funds from view/place orders and search

Activate the copy-specific fund selectors for lineitems accessed from
the View/Place orders and MARC Federated Search interfaces.  Prior to
this, fund selectors existed, but could not accept values until after a
PO was created for a given lineitem.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1463166 Fix Batch update of Funds in Selection Lists
Liam Whalen [Sat, 19 Sep 2015 03:24:14 +0000 (20:24 -0700)]
LP#1463166 Fix Batch update of Funds in Selection Lists

Selection lists are currently unable to batch update funds.  The problem
stems from the fact that the Fund selection list is not populated in the
copy rows.  New code used to limit the number of funds, in the dropdown
list, to those funds available to the user was added for purchase
orders.  However, these changes were not added to Selection Lists.  This
code adds the new call to initBatchUpdater to the selection list code.

Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1669534 - OPAC hold request should not default to first SMS carrier
Cesar Velez [Tue, 23 May 2017 13:58:39 +0000 (09:58 -0400)]
LP#1669534 - OPAC hold request should not default to first SMS carrier

Added empty <option> tag to address this and related form validation issues.

To test
-------
[0] Ensure that SMS messaging is enabled.
[1] Apply the patch and go to the place hold form in the public
    catalog. Verify that no mobile carrier is selected.
[2] Set the default SMS carrier and number for the user account
    and go back to the place hold form. Verify that the user's
    default carrier and number appear in the form.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1681095: (follow-up) fix a template syntax error
Galen Charlton [Mon, 7 Aug 2017 20:52:04 +0000 (16:52 -0400)]
LP#1681095: (follow-up) fix a template syntax error

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1075401: add release notes entry
Galen Charlton [Mon, 7 Aug 2017 20:49:17 +0000 (16:49 -0400)]
LP#1075401: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1075401: stamp DB update
Galen Charlton [Mon, 7 Aug 2017 20:44:32 +0000 (16:44 -0400)]
LP#1075401: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP 1075401 - Upgrade script to nullify existing bad data
Michele Morgan [Mon, 3 Jul 2017 18:49:42 +0000 (14:49 -0400)]
LP 1075401 - Upgrade script to nullify existing bad data

Sets to NULL any entries in asset.copy_template.age_protect and
asset.copy_template.circ_as_type that are not valid values.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1075401: adjust two fields in the legacy Serials Copy Template editor
Michele Morgan [Tue, 18 Apr 2017 16:11:01 +0000 (12:11 -0400)]
LP#1075401: adjust two fields in the legacy Serials Copy Template editor

This commit changes the Age Protection and Circ as Type fields to links in
the fm_IDL.xml to allow the template to read the data in the fields. It also
changes the owning_lib reporter type to org_unit so the org unit shortname
is displayed in the grid view, along with fixing the config.floating_group cfg
FM settings so that the name is displayed instead of the ID.

[Note from Galen: the forthcoming web staff serials module's serial
 copy template editor already provided drop-downs for those two fields,
 but the IDL changes remain beneficial.]

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1693851: Fix hardcoded paths in srfsh support scripts
Jeff Davis [Fri, 26 May 2017 17:05:02 +0000 (10:05 -0700)]
LP#1693851: Fix hardcoded paths in srfsh support scripts

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1704873 Stamping SQL upgrade for print labels
Bill Erickson [Mon, 7 Aug 2017 18:39:14 +0000 (14:39 -0400)]
LP#1704873 Stamping SQL upgrade for print labels

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP#1704873 webstaff: item label setting stickiness
Jason Etheridge [Fri, 4 Aug 2017 21:47:12 +0000 (17:47 -0400)]
LP#1704873 webstaff: item label setting stickiness

Save last template applied as default.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP#1704873 webstaff: label printing
Jason Etheridge [Sun, 5 Mar 2017 21:07:17 +0000 (16:07 -0500)]
LP#1704873 webstaff: label printing

...initial hook
...better stock template for labels, and a | wrap filter
...pull in some Library Settings for Print Labels
...Reset to Default button for templates for both receipt and item print labels
...toward tabs for Print Label interface
...template management for print labels
...bundle the Call Number Template in with saved templates
...manual editing of cn's for print labels
...And affixes in the stock CN template.
...Settings tab for print labels
...add Print Labels action to Copy Buckets
...and some other cosmetic tweaks to the Actions menu
...add Print Labels to Holdings View
...provide MVR's for use with Print Labels
...better than super simple record, but Display Fields will be better yet later on
...new org unit settings for print labels
...and fix to stock call number template for affixes
...and cn_wrap filter for call numbers
...handle null location affixes
...implement Print Item Labels on Save & Exit in vol/copy editor

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP#1681095: add release notes
Galen Charlton [Mon, 7 Aug 2017 18:43:55 +0000 (14:43 -0400)]
LP#1681095: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1681095: fix TT syntax error
Galen Charlton [Mon, 7 Aug 2017 18:35:38 +0000 (14:35 -0400)]
LP#1681095: fix TT syntax error

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1681095: add cache-busting to a couple more links
Galen Charlton [Mon, 7 Aug 2017 18:22:02 +0000 (14:22 -0400)]
LP#1681095: add cache-busting to a couple more links

This covers a couple more resources added since the last
time that the branch for this bug was rebased.

The following command can help find other places where the
cache-busting key should be added:

  git grep -P '\.(gif|png|jpg|js|css)' Open-ILS/src/templates/{opac,kpac}|grep -v cache_key|grep -v eg_cache_hash

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1681095 Browser cache-busting key for longer expires
Dan Scott [Sat, 8 Apr 2017 13:26:42 +0000 (09:26 -0400)]
LP#1681095 Browser cache-busting key for longer expires

Extend the support for cache-busting that we added with autogen's generation of
ctx.eg_cache_hash for core JavaScript assets to other assets such as images,
stylesheets, and additional JavaScript. This will enable us to set very long
cache times for our assets, which can then be controlled explicitly by setting
eg.cache_key in config.tt2, or by default any time you run autogen.

Addresses TPAC and KPAC

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1681095 Set aggressive default cache expires timelines
Dan Scott [Sat, 8 Apr 2017 15:02:02 +0000 (11:02 -0400)]
LP#1681095 Set aggressive default cache expires timelines

Now that we have a broad cache-busting mechanism, set the default cache expires
timelines for non-HTML types far in the future.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1706365: cursor for record menu items should be a pointer
Kathy Lussier [Tue, 25 Jul 2017 14:23:20 +0000 (10:23 -0400)]
LP#1706365: cursor for record menu items should be a pointer

When using the Mark For or Other Actions menus on the bib record page, the
cursor becomes an i-beam while hovering over the menu items instead of the
expected pointer. This commit adds an empty href attribute to the a tag for menu
items so that a pointer displays instead.

Test plan:
Log into the web client and retrieve a record. Click the 'Mark For' menu on the
record page. Pre-patch, as you scroll through the menu items, the cursor will
turn into an i-beam, indicating that text can be selected. Post-patch, the
cursor will be the expected pointer that typically displays for links.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1694529: tweak wording of collision alert message
Galen Charlton [Mon, 7 Aug 2017 15:15:57 +0000 (11:15 -0400)]
LP#1694529: tweak wording of collision alert message

And here's a test plan for the patch series as a whole:

[1] In the web staff client, retrieve a patron that has some
    loans. In a separate window, open the patron editor
    for that same patron.
[2] In the first window, mark one of the patron's loans
    as either claims returned or claims never checked out.
[3] In the second window, make a change and attempt to save
    the record. You should see a alert dialog saying that
    the record could not be saved.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1694529 Patron editor friendly xact ID collision alert
Bill Erickson [Thu, 29 Jun 2017 21:53:56 +0000 (17:53 -0400)]
LP#1694529 Patron editor friendly xact ID collision alert

Display a friendly alert dialog message to staff when attempting to save
a patron record that has been externally modified during editing.  This
is an improvement over the existing debug alert with JSON data.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>