Bill Erickson [Fri, 10 Aug 2012 18:06:36 +0000 (14:06 -0400)]
Fiscal year selector in ACQ order record upload
* Support a 'fiscal_year' parameter to ACQ order record upload API.
* Adds a new "Fiscal Year" selector to the upload form to facilitate
uploading orders to different fiscal years.
This partially resolves LP 1031927 by allowing manual selection of the
correct fiscal year.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Ben Shum [Mon, 13 Aug 2012 22:08:53 +0000 (18:08 -0400)]
Change "Reset form" to "Clear Form"
As suggested by Thomas Berezansky in the comments on LP 994058, change
the button from "Reset form" to "Clear form" to be absolutely clear
that the button now removes all previous search variables.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Wed, 8 Aug 2012 19:08:24 +0000 (15:08 -0400)]
TPAC: Reset Form and New Search should clear queries
Currently, clicking "Another Search" in the search results page, or
"Reset Form" on the advanced search page, keeps the same query terms and
type around. Clear these parameters as expected; essentially, we keep
only the search location (loc or locg) in scope.
Note that we explicitly keep parameters around when someone is going
from a basic search to an advanced search, because the assumption is
that they want to refine their search further.
Also affected are the org_selector, because we want to pull the logic
for loc or locg out into a common area (the get_library block in
misc_util.tt2), and the style (input.opac-button elements now get styled
the same as a.opac-button elements, which makes it easier to intermingle
them on the same form).
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Ben Shum [Sun, 12 Aug 2012 07:25:49 +0000 (03:25 -0400)]
TPAC - add library scoping to shelf browser
The shelf browser currently uses the 'loc' variable to define scoping and
limit browsing to specific org units. However, since much of the scoping
actually uses 'locg', the scoping was broken for the shelf browser.
Additionally, under Advanced Search's Numeric Search, the option for
'Call Number (Shelf Browse)' only applies the 'cn' variable to searches
and never adds the search scope, despite the search library now being
an available filter choice.
Based on suggestion by Dan Scott in IRC, this patch uses the function for
_get_search_lib() to retrieve the search library and add it to both parts
of the shelf browser.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Jason Stephenson [Wed, 25 Jul 2012 17:43:38 +0000 (13:43 -0400)]
Make opac/results.tt2 remember facet when sorting, etc.
Add a hidden field in the search form and set its value to the value
of the CGI 'facet' param if the facet parameter is set. This appears
to work for multiple facets. Clearing a facet is as simple as clicking
on the gray-backgounded facet name.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Ben Shum [Thu, 9 Aug 2012 16:27:57 +0000 (12:27 -0400)]
TPAC - fix alignment of "You are now browsing..." in shelf browser
The "You are now browsing..." message does not align to the center of the
page. Changing the <div> to a <p> seems to properly align the text.
Along the way, we should remove the extra <span> and <strong> (the strong
is redundant with the css being inherited by color_4 class) and make the
new single line message more i18n-friendly for future translations.
Credit to Michael Peters for noticing the problem and thanks to Dan Scott,
Lebbeous Fogle-Weekley, and Thomas Berezansky for help via IRC for the
i18n-bits.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Michael Peters <mrpeters@library.in.gov> Signed-off-by: Dan Scott <dscott@laurentian.ca>
The cnoffset was strictly checking for values that start with a digit.
But negative numbers start with a "-" instead. Once this check was
changed, the previous link will continue to move further into negative
offsets.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Thu, 9 Aug 2012 22:25:00 +0000 (18:25 -0400)]
Authorities: Fix broken UI due to new XUL/Dojo/regressions
New versions of XUL, since Firefox 10, hate dojo.query("foo bar"), so we
have to refactor it to use dojo.query("foo").query("bar") instead. At
least until we upgrade to a new version of Dojo.
In addition, 522d8d82 introduced a regression meaning that the text of
the authorities was no longer wrapped in a SPAN element with a class of
"text". That in turn meant that the Dojo queries weren't picking up the
labels for the merge box, leaving no visual indication to the user as to
what authorities exactly were being merged. So, repair that.
Also, similar to a fix for the MFHD editor, set the initial height of
the spawned MARC Editor for an authority record to something reasonable.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Thu, 9 Aug 2012 20:31:44 +0000 (16:31 -0400)]
Set a sane initial MFHD Editor size
For most MFHD records, the size of the MARC Editor window when spawned
fits into the confines of a normal desktop. However, for MFHD records
with dozens or more rows, the window chrome can be inaccessible because
it is bumped off the top of the Windows desktop. This makes it
impossible for users to close the window without a workaround like
hitting ALT+F4
This branch sets the window to an initial height of 40 pixels less than
the height of the entire staff client window. This should be enough to
enable the chrome on top to be visible. In addition, we have to set the
width to something reasonable because XUL seems to otherwise set the
window to be extremely skinny once an explicit height is set, so we set
that to be half the width of the staff client window.
Finally, we allow the new window to be resizable according to the user's
preference.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Simplified Hold Pull List: Fix several sorting bugs
First of all, sorting on most columns was broken due to a bug in the way
that the flattener methods of the open-ils.fielder service were
constructing their SQL JOINs. We were coming up with way too many
joins, and then losing track of which JOIN's alias to refer to when
building the ORDER BY clause later. This is fixed.
Secondly, the shelving location column now sorts automatically by the
shelving location *ordering* values, when avaiable. These are the
values that you set up in the drag-and-drop staff client interface
titled "Copy Location Order." When these values are not set for the org
unit whose pull list you're viewing, the sorting will fall back to
alphabetical.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Sat, 4 Aug 2012 15:24:15 +0000 (11:24 -0400)]
TPAC: Remove explicit width on "View my list" button
.cached_list_div, which defines the style for the "View my list" button
on the TPAC button bar once an item has been added to a temporary list,
is given an explicit width of 111px, which is problematic for a number
of reasons:
1. If the font-size of the base style is increased, then the text will
likely wrap.
2. Translations tend to be longer than English, and indeed in fr-CA
"Afficher ma liste" ends up wrapping onto a second line, which makes
the button bar look weird.
Accordingly, remove the explicit "width:111px" from the style definition
for .cached_list_div.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Fri, 3 Aug 2012 14:59:33 +0000 (10:59 -0400)]
Add dependencies for Fedora
Noted by Net Wolf on the mailing list, some core dependencies were
missing from the Fedora Makefile.install installer. As some of them have
recently been packaged for Fedora 17, add them to the package
collection; others are still unpackaged, so leave them there.
Note: the packages are not available on Fedora 16, but that has a
limited remaining shelf life anyway, so consider this a shift to
supporting only the latest stable version of Fedora.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Thu, 2 Aug 2012 16:09:42 +0000 (12:09 -0400)]
Add simple README to RELEASE_NOTE_NEXT
Without something in the directory, it will dissappear each time we
create release notes from the contents and delete them, since Git
removes empty directories. That would likely just lead to confusion.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jeff Godin [Tue, 19 Jun 2012 19:10:07 +0000 (15:10 -0400)]
Pass authtoken to OpenILS::SIP::Patron objects
To support retrieval of billing details, OpenILS::SIP::Patron
objects need an auth token.
Teach OpenILS::SIP->find_patron to pass patron objects an auth
token, and also move existing "find patron by what key: barcode or
database id?" logic into find_patron (and out of
OpenILS::SIP::Patron->new).
Signed-off-by: Jeff Godin <jgodin@tadl.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Bill Erickson [Thu, 31 May 2012 13:27:40 +0000 (09:27 -0400)]
Search filter groups release notes
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Bill Erickson [Thu, 31 May 2012 13:37:58 +0000 (09:37 -0400)]
Search filter groups admin UI staff menu entry
Admin -> Local Administration -> Search Filter Groups
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Bill Erickson [Fri, 25 May 2012 13:22:36 +0000 (09:22 -0400)]
Search filter groups admin UI / API
UI for managing search filter groups and group entries.
This inclues a new API call for performing CRUD actions on filter
group entries:
open-ils.actor.filter_group_entry.crud
This new API call was necessary because entries link to
actor.search_query's, whose write access cannot be controled by pcrud.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Art Rhyno [Fri, 27 Jul 2012 15:39:14 +0000 (11:39 -0400)]
Block "Place Hold" link in TPAC if item is available
Suppress the display of the "Place Hold" link based on whether an item
is available. This is set as a preference in config.tt2. Some sites
may want the ability to place holds regardless of availability.
Signed-off-by: Art Rhyno <art632000@yahoo.ca> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Conflicts:
Open-ILS/src/templates/opac/parts/record/summary.tt2
Open-ILS/src/templates/opac/parts/result/table.tt2
Allow for temporary, staff, and permanent operator changes.
Temporary uses a temp authtoken for a few minute timeout.
Staff uses a normal staff login authtoken for a multi-hour timeout.
Permanent is a staff change that disregards the previous login instead of
allowing it to be recovered by using the menu item again.
I also fixed things up so later timeouts can re-use the previous duration
and fixed up some title bar issues:
1 - Login screen shows version again (needed a document in the title set)
2 - Menu windows don't forget the server name
3 - Menu windows keep the same number for their lifetime
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Bill Erickson <berick@esilibrary.com>
This converts the util/window.js open function to a wrapper around the
openDialog function and passes xulG in that way, as well as teaches
global_util.js to look for it having been passed in via the arguments
parameter on window.
The non-modal "push it into place" is still done as well, in case some
window isn't using global_util.js and needs xulG.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Bill Erickson [Fri, 27 Jul 2012 16:11:23 +0000 (12:11 -0400)]
EDI ORDER template, now with copies
Adds a new "copies" structure to the stock JEDI ORDER template. Copies
are ultimately mapped into one or more GIR segments in the outbound EDI.
This commit only adds the change to the stock template (seed data). It
also adds entries to the environment for the stock template and existing
template 23 via upgrade script (to expedite local template editing).
With the current template, GIR segments look like so:
Bill Erickson [Thu, 12 Apr 2012 15:44:44 +0000 (11:44 -0400)]
Collections user balance API / batch file output
New API open-ils.collections.user_balance_summary.generate,
which generates summary information on patron balance owed for all open
transactions that occurred at the requested location. Optional flag
supports including per-xact summary information as well. The summary
information is written to an XML file and placed in a protected, shared
web directory for download after the file has been generated.
During creation, the output file will have a .tmp suffix, allowing
clients to poll for file completion.
Includes a new opensrf.xml app_setting for open-ils.collections to
specifiy the batch file directory as well as a sample Apache config in
eg_vhost.conf
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Thu, 12 Apr 2012 15:07:10 +0000 (11:07 -0400)]
Fieldmapper toXML repairs and additions
1. Be sure the append the current element to the document in progress
2. Use the class hint instead of the fully qualified class_name (e.g.
Fielmapper::actor::user) to avoid XML errors:
namespace error : Failed to parse QName 'Fieldmapper:'
3. Added support for additional options including "no_virt" which tells
the routine to skip all virtual fields and "skip_fields" to support
leaving specific fields out of the output. The main use case for skip
fields is au => ['passwd'], but other examples might include large
fields like bre => ['marc'].
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Wed, 1 Aug 2012 17:54:00 +0000 (13:54 -0400)]
ACQ unified search submit on enter (for real)
This replaces the old-style submit on enter handler which was based
attaching key handlers to the dijit domNode, which does not work for
filtering selects (i.e. more complicated dijits) w/ the dijit-sanctioned
dojo.connect(..., 'onkeyup', ...), which works regardless. This also
covers more form input elements which were overlooked with the original
submit-on-enter code.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Thu, 12 Jul 2012 19:26:50 +0000 (15:26 -0400)]
ACQ invoice formatting improvements
Prevent # invoiced and # paid inputs from wrapping. Also, make the text
boxes a little smaller to reduce horizontal space requirements. It's
still possible to enter any value, but only the 4 least significant
digits are visible. Since it's not common to invoice 10k+ copies of the
same item, this seems like a fair trade off.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Tue, 10 Jul 2012 15:07:53 +0000 (11:07 -0400)]
ACQ invoice inline lineitem search and add
The Invoice UI is how composed of two tabs, the main invoice tab and a new
Search tab. The search tab consists of a subset of the Acquisitions unified
search interface. The goal is to allow users to search for lineitems to
invoice. Search results may be added directly to the growing invoice. A
number of small usability features are included.
Features
~~~~~~~~
* Option (default) to limit searches to invoiceable items.
** These are lineitems that are not cancelled, have at least one
invoiceable copy, linked to a PO whose provider matches that of the
current invoice, and are not already linked to the current invoice.
* Search defaults to last-run search (on workstation).
* New Lineitem Detail filter options
* Sort searches by lineitem number (default) and title.
* There is a new Expected Cost field which includes both the total invoiced
cost plus the anticipated cost of lineitems as they are added.
* New Price per Copy field
* Lineitem count field
* Show / Hide Invoice details button. Details are displayed by default, but
hidden when the user enters the search tab. From there it remains hidden
until manually shown (or a new invoice is opened).
* A new "Save & Clear" button which saves the current invoice then clears
the invoice display to create a new invoice.
* Provider, shipper, and receiver fields are auto-populated from the
first-added invoice data (when not already set).
* Totals are now read-only, since they are derived from existing data (and
are informational only).
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Fri, 20 Jul 2012 15:15:25 +0000 (11:15 -0400)]
EditPane.js API repairs
By default, don't throw an exception from EditPane.getFieldValue when a
field is required and the value is null. Otherwise, external code is
unable to use this method for inspecting the pane. Make checkRequired
an additional method flag.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Includes patch for edi4r to make invoice parsing possible.
Also adds OpenILS::Utils::LooseEDI module. This doesn't try to do the
validation and other helpful things that Business::EDI aims to do, but it
does let us get up and running relatively quickly at getting data from EDI
invoices if we know what we're looking for.
[Amended to add bits about tax, plus release note blurb.]
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Bill Erickson [Fri, 27 Jul 2012 20:11:54 +0000 (16:11 -0400)]
Vandelay Copy Overlay support
Vandelay Item Attributes (Cataloging -> MARC Import /
Export -> Import Item Attribute Definitions) contains
a new field called "Overlay Match ID". The presence of data
in this field extracted from an import-item copy indicates
to the Vandelay import process that a copy overlay is requested
instead of new copy creation. The value for the field is the
copy id for bib record queues and the ACQ lineitem_detail ID for
Acquisitions Queues. For either type of queue, however, overlay
occurs against a real copy (asset.copy). In the ACQ queue case,
we use the lineitem_detail ID because this is the data ACQ
providers and sub-systems will have access to.
When a match point ID value is a set and a matching copy is found,
the values extracted from the inbound copy data are used to replace
values on the existing found copy, including the call-number label.
Any fields on the inbound copy that are empty are ignored.
One use case for this feature are shelf-ready items produced by a
3rd-party (e.g. ACQ provider) and delivered to the library via MARC
file for upload. The file might contain improved MARC bibliographic
data as well as real barcodes (i.e. not temporary ACQ generated
barcodes) for the copies already purchased through the vendor.
Permission
~~~~~~~~~
This adds a new permission called IMPORT_OVERLAY_COPY which is
required to perform the copy overlay step.
Regardless of permission, it is not possible to overlay values on
a copy unless the imported bib record links (creates/overlays/merges)
to/with the owning bib record for the copy to be overlaid. This is
both for security and removal of a potent foot-gun.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
- Minor correction to make stock schema match upgrade script match.
- OU setting determining whether to offer rollover-without-money in UI
and allow it in DB.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Mike Rylander [Thu, 26 Jul 2012 13:35:01 +0000 (09:35 -0400)]
Allow propagation of encumbrances without funds
Some libraries must return all unspent money to some funding agencies at the
end of the year. To support this, we give the year-end close-out operation
the ability to dump the money from rollover-enabled funds into the void. Funds
are still created for the next year, and encumbrances are moved to theses
analogous funds.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Mon, 30 Jul 2012 03:19:21 +0000 (23:19 -0400)]
TPAC: Address remaining colors and background URL image
Thanks to Thomas Berezansky for finding these remaining hard-coded CSS
colors, and raising a question about one of the background images that
turns out to not currently being in use.
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Dan Scott [Sun, 29 Jul 2012 04:15:07 +0000 (00:15 -0400)]
TPAC CSS: Remove unused classes and associated images
Combing through the remaining url() usages in the TPAC CSS, it seems
that most of the usages are unreferenced in the actual TPAC. Therefore,
delete the cruft.
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Dan Scott [Thu, 26 Jul 2012 21:39:06 +0000 (17:39 -0400)]
Templatize TPAC styles
Begin by gathering the colors together in one consistent file, such that
skinning for the purposes of color only needs to touch one small file.
Also, it should make things easier for designers to reduce drastically
the number of colors that are actually used in the design.
Also, enable TT to handle the CSS files in Apache configuration.
Also, convert the login background image into a simple gradient.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Bill Erickson [Tue, 26 Jun 2012 19:36:50 +0000 (15:36 -0400)]
kpac : repair Top link
Template Toolkit string.replace() does an inline replacement instead of
returning a value. Use .replace() correctly when building the Top URL,
or the result will be an empty href, which direct to "here" in
Firefox/Chrome, but directs to "here, minus the page name in the URL"
(e.g. http://domain/eg/kpac/) in IE, which ultimately directs the user
to /eg/opac/login (since it doesn't match any configured paths).
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Thu, 21 Jun 2012 13:07:18 +0000 (09:07 -0400)]
kpac : better wording for the Save It dialog
This removes any mention of selecting a location, which is not needed
for saving items to lists. It also adds some language about saving
items to existing lists.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Tue, 29 May 2012 14:01:25 +0000 (10:01 -0400)]
kpac : hide font-size image/link pending design
Will need to get some input on how this action should behave. My
personal pref. is to use the browser's page zoom behavior, since it's
the only way to truly resize everything in the page.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Tue, 29 May 2012 13:48:45 +0000 (09:48 -0400)]
kpac : hide font-size image/link pending design
Will need to get some input on how this action should behave. My
personal pref. is to use the browser's page zoom behavior, since it's
the only way to truly resize everything in the page.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Wed, 23 May 2012 15:44:28 +0000 (11:44 -0400)]
kpac : global filter config option
Allows for configuration of an always-on global search filter. All
searches, regardless of origin, in the kpac will be appended by this
filter when configured.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
projects / working / Evergreen.git / log