working/Evergreen.git
5 years agoLP#1281750 Ignore deleted users in usrgroup info APIs
Bill Erickson [Tue, 18 Feb 2014 19:38:07 +0000 (14:38 -0500)]
LP#1281750 Ignore deleted users in usrgroup info APIs

Ignore deleted users in these API calls:

open-ils.actor.usergroup.members.balance_owed
open-ils.actor.usergroup.members.retrieve
open-ils.actor.usergroup.leaders.retrieve
open-ils.actor.address.members

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1277731: pgTAP for action.hold_request_permit_test()
Dan Wells [Tue, 11 Mar 2014 19:04:39 +0000 (15:04 -0400)]
LP#1277731: pgTAP for action.hold_request_permit_test()

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 years agoLP#1277731: Stamping upgrade for hold_test_params
Dan Wells [Tue, 11 Mar 2014 18:33:58 +0000 (14:33 -0400)]
LP#1277731: Stamping upgrade for hold_test_params

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1277731: Disambiguate parameter/column names
Mike Rylander [Tue, 4 Mar 2014 20:47:12 +0000 (15:47 -0500)]
LP#1277731: Disambiguate parameter/column names

Due to slightly different and more strict disabiguation rules
for parameters and column names in PLPGSQL in modern versions
of Postgres, our hold matrix functions were failing in 9.3.

This commit attempts to address that by declaring and using
aliases for parameters that share names with columns used in
in-line SQL.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1289450: OpenSRF 2.3.0 is the minimum required version
Galen Charlton [Fri, 7 Mar 2014 16:11:59 +0000 (08:11 -0800)]
LP#1289450: OpenSRF 2.3.0 is the minimum required version

This patch updates the installation and upgrade documentation
to reflect the decision to make OpenSRF 2.3.0 be the minimum
required version.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 years agoLP1284864 - stamping upgrade for deleted metarecord function fixing
Ben Shum [Mon, 10 Mar 2014 16:55:04 +0000 (12:55 -0400)]
LP1284864 - stamping upgrade for deleted metarecord function fixing

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1284864: Forcibly update deleted MR masters
Mike Rylander [Mon, 10 Mar 2014 16:43:24 +0000 (12:43 -0400)]
LP#1284864: Forcibly update deleted MR masters

Query derived from one by Ben Shum, altered to take deleted-record retention
configuration into account.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1284864: Don't leak deleted constituent records
Mike Rylander [Fri, 7 Mar 2014 20:48:35 +0000 (15:48 -0500)]
LP#1284864: Don't leak deleted constituent records

There were times when deleted constituent records were leaking into
the display of metarecord results.  In particular, when a metarecord's
lead record was deleted, the lead was not recalculated.  We address
this situation directly now in the remapper.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoStamping upgrade script for TPAC metarecord / formats repairs and usability additions
Mike Rylander [Mon, 10 Mar 2014 16:31:51 +0000 (12:31 -0400)]
Stamping upgrade script for TPAC metarecord / formats repairs and usability additions

Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1284864 correct TPAC metarecord list pagination
Bill Erickson [Thu, 6 Mar 2014 21:40:31 +0000 (16:40 -0500)]
LP#1284864 correct TPAC metarecord list pagination

Set the template hit_count value for metarecord constituent records page
to show the correct counts and pagination.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1284864 repair MR hold possibilty depth calculation
Bill Erickson [Tue, 4 Mar 2014 15:42:22 +0000 (10:42 -0500)]
LP#1284864 repair MR hold possibilty depth calculation

Fixes a bug where the hold possibility checks for metarecords used the
depth of the selection OU instead of depth 0 when no depth was defined.
This prevented holds from being placed in some instances, particularly
when no hold boundaries were defined (or equaled zero).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1284864 MR opac-visible constituent records
Bill Erickson [Mon, 3 Mar 2014 16:52:57 +0000 (11:52 -0500)]
LP#1284864 MR opac-visible constituent records

The number of constituent records for a metarecord during searching is
now consitently based on the presence of an opac visible copy and not a
holdable copy.  This affects the constituent record counts in MR results
lists and the records displayed in the constituent records list.  (Icons
were already checking visibility instead of holdability).

Holdable formats are still derived from records with holdable copies.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1284864 MR display avoid fetching master
Bill Erickson [Mon, 3 Mar 2014 16:08:54 +0000 (11:08 -0500)]
LP#1284864 MR display avoid fetching master

Remove unnecessary code to fetch the MR master when compiling MR
constituent records lists, since the master record was slipping into the
results set, where it should not have been.  This code is unneeded and
is a holdover from an earlier experiment.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1284864 MR holds w/o formats disallowed
Bill Erickson [Fri, 28 Feb 2014 15:07:11 +0000 (10:07 -0500)]
LP#1284864 MR holds w/o formats disallowed

During MR hold placement, if the MR has zero holdable formats, disallow
the hold.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1284864 MR holds display and edit repairs
Bill Erickson [Thu, 27 Feb 2014 22:22:52 +0000 (17:22 -0500)]
LP#1284864 MR holds display and edit repairs

* Repair format icons for MR and non-MR holds
* Allow all filters to be cleared from a MR hold (w/o resulting in a
  server error).
* during editing, if a hold has a selection_depth, use that to further
  limit the available formats and languages in the edit selectors.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1284864 metarecord holds wording repairs
Bill Erickson [Thu, 27 Feb 2014 21:37:25 +0000 (16:37 -0500)]
LP#1284864 metarecord holds wording repairs

Indicate to the patron that selecting no format means that any available
format may be used to fill the hold.  Ditto language.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1284864 metarecord filtered constituent record counts
Bill Erickson [Thu, 27 Feb 2014 21:27:55 +0000 (16:27 -0500)]
LP#1284864 metarecord filtered constituent record counts

Ensure the count of constiuent records in the MR results lists is
derived from the filtered record set (search org, depth, holdable, etc.)
and not all records.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1284864 TPAC scoped constituent MR records list
Bill Erickson [Thu, 27 Feb 2014 21:15:06 +0000 (16:15 -0500)]
LP#1284864 TPAC scoped constituent MR records list

Limit bib records to those within the search scope in the MR constituent
records list page.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1284864 TPAC format selector attribute / values
Bill Erickson [Wed, 26 Feb 2014 15:35:25 +0000 (10:35 -0500)]
LP#1284864 TPAC format selector attribute / values

Creates a new search_format record attribute, which is responsible for
driving the catalog search format selector.  The values are derived from
the icon_format attriute, with a few notable changes (for starters).

1. The 'book' search_format contains large print and has the label "All
Books".

2. The 'music' search_format contains all music, regardless of sound
record format (or other attributes) and has the label "All Music"

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1284864 TPAC metarecord display record count in results
Bill Erickson [Tue, 25 Feb 2014 21:47:03 +0000 (16:47 -0500)]
LP#1284864 TPAC metarecord display record count in results

Next to each metarecord containing more than one record, display the
count of constituent records next to the record title in parentheses.
This allows the user to see at a glance if a record is really grouped or
simply a single-record "group".

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1284864 display code value code in composite def builder
Bill Erickson [Tue, 25 Feb 2014 20:33:32 +0000 (15:33 -0500)]
LP#1284864 display code value code in composite def builder

When selected code values to add to a composite definition in the coded
value map composite def. editor, display both the label and the code, as
many people or more familiar w/ the codes than the labels.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1284864 coded value map cloning
Bill Erickson [Tue, 25 Feb 2014 20:27:58 +0000 (15:27 -0500)]
LP#1284864 coded value map cloning

Added a "clone selected" option to the coded value map grid.  For CCVMs
which have composite definitions, clone the composite definition as
well.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1284864 propagate patron barcode to advanced hold options
Bill Erickson [Tue, 25 Feb 2014 19:58:06 +0000 (14:58 -0500)]
LP#1284864 propagate patron barcode to advanced hold options

1. Staff searches the catalog within the staff client, not focused on a
patron.

2. Staff types a barcode into the patron barcode input

3. Staff clicks "Advanced Holds Options" and the typed barcode now
propagates to the metarecord hold page.

--

Minor HTML cleanup to avoid 350+-wide character columns.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1284864 show all formats in record details page
Bill Erickson [Tue, 25 Feb 2014 18:59:34 +0000 (13:59 -0500)]
LP#1284864 show all formats in record details page

For records which have multiple formats (e.g. DVD and BLU-RAY), show all
formats in the details page, similar to the search results pages.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1284864 added missing stock blu-ray icon
Bill Erickson [Tue, 25 Feb 2014 18:59:00 +0000 (13:59 -0500)]
LP#1284864 added missing stock blu-ray icon

For now, it matches the DVD icon.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1077811 Inconsistent INSTALL Instructions
Elliot V [Fri, 7 Mar 2014 05:43:00 +0000 (23:43 -0600)]
LP#1077811 Inconsistent INSTALL Instructions

The preamble to the installation instructions, intended for
developers, is a bit unclear. The instructions describe actions
that should take place at two different points in the installation.

This commit moves the instructions to download and install the Dojo
Toolkit until after the opensrf Linux user already owns the
/openils directory. It also adds the appropriate note for non-devs
to skip this section.

Signed-off-by: Elliot V <evoris@slcconline.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 years agoLP1288938 - final adjustments for 0870 upgrade script
Ben Shum [Fri, 7 Mar 2014 13:49:16 +0000 (08:49 -0500)]
LP1288938 - final adjustments for 0870 upgrade script

These were missed from the original and resulted in the fix not being complete.

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoForward-port 2.5.2-2.5.3 upgrade script
Dan Wells [Thu, 6 Mar 2014 23:17:56 +0000 (18:17 -0500)]
Forward-port 2.5.2-2.5.3 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1287510 Add missing column to upgrade script
Dan Wells [Wed, 5 Mar 2014 17:24:19 +0000 (12:24 -0500)]
LP#1287510 Add missing column to upgrade script

If you come via upgrade and not a fresh 2.5 DB, you are probably
missing the action.aged_hold_request.behind_desk column.  Add it in a
harmless way.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP1288938 - stamping upgrade script
Ben Shum [Thu, 6 Mar 2014 20:16:45 +0000 (15:16 -0500)]
LP1288938 - stamping upgrade script

With minor fixing to remove the unneeded bits of the upgrade scripts.

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1288938: Leaking URIs ... don't do that
Mike Rylander [Thu, 6 Mar 2014 16:28:46 +0000 (11:28 -0500)]
LP#1288938: Leaking URIs ... don't do that

Ben Shum spotted an issue where the old behavior
could leak hidden URIs.  Being more explicit in the
WHERE clause addresses this.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1287973 recover row breaks in TPAC advanced search
Bill Erickson [Thu, 6 Mar 2014 18:10:19 +0000 (13:10 -0500)]
LP#1287973 recover row breaks in TPAC advanced search

Avoid long horizontal filter rows in the advanced search page by
recovering the original clear/both on each row of filters to force a new
line.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1279420 Add Test::Output prerequisite
Jason Etheridge [Wed, 12 Feb 2014 16:49:37 +0000 (11:49 -0500)]
LP#1279420 Add Test::Output prerequisite

Build tests require Test::Output. Add packages for Test::Output to
the prerequite installer Makefiles.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Jeff Godin <jgodin@tadl.org>
5 years agoLP1272316 - Stamping upgrade script for pre-calculate-prox-adjustment
Ben Shum [Fri, 28 Feb 2014 17:38:36 +0000 (12:38 -0500)]
LP1272316 - Stamping upgrade script for pre-calculate-prox-adjustment

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP1272316 - Calculate proximity in the DB for speed
Mike Rylander [Fri, 14 Feb 2014 17:01:37 +0000 (12:01 -0500)]
LP1272316 - Calculate proximity in the DB for speed

We need to calculate and store a (potenially adjusted) proxmity for
each hold and copy for use in targetting and optimization of op
capture.  Before this commit, we do that within the hold target
code itself.  Now we'll do it when the hold-copy map is inserted,
because we have the same information available at that time as we
have in the targeter.  This will both speed up the apparent cost of
the calculation, because it avoids the cost of a network round-trip,
and the total number of SELECTs we must issue, because the proximity
value will now be cached for use by the proximity map function.

Backward compatability is retained for the create_prox_map() function
in case any other code is depending on that.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP1272316 - Followup to make ou_ancestor_setting() even faster
Lebbeous Fogle-Weekley [Fri, 24 Jan 2014 17:33:13 +0000 (12:33 -0500)]
LP1272316 - Followup to make ou_ancestor_setting() even faster

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP1272316 - Speed up these settings lookups in the hold targeter that get repeated...
Lebbeous Fogle-Weekley [Fri, 24 Jan 2014 17:24:06 +0000 (12:24 -0500)]
LP1272316 - Speed up these settings lookups in the hold targeter that get repeated a ...

... lot when there are lots of copies for a hold.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1179660: remove call to undefined initialize func
Bill Erickson [Thu, 6 Jun 2013 15:13:35 +0000 (11:13 -0400)]
LP#1179660: remove call to undefined initialize func

Remove call to nonexistant function Search::Z3950->initialize.  Prior to
now, this would have quietly failed, but with AUTOLOAD to be removed
from OpenSRF, it would fail with full shock and awe.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Search.pm

5 years agoTranslation updates - newpot
Dan Wells [Mon, 24 Feb 2014 21:31:16 +0000 (16:31 -0500)]
Translation updates - newpot

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoTranslation updates - po files
Dan Wells [Mon, 24 Feb 2014 21:21:32 +0000 (16:21 -0500)]
Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoStamping 0868 - 'behind_desk' fixes
Dan Wells [Fri, 21 Feb 2014 21:34:58 +0000 (16:34 -0500)]
Stamping 0868 - 'behind_desk' fixes

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1281744 Aged hold purging column repair
Bill Erickson [Tue, 18 Feb 2014 19:16:40 +0000 (14:16 -0500)]
LP#1281744 Aged hold purging column repair

Add missing non-NULLable "behind_desk" column to
action.all_hold_request, which is used during holds deletion and
archiving.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoStamping 0864-0867 for MVF, CRA, and TPAC MRs
Dan Wells [Fri, 21 Feb 2014 20:58:50 +0000 (15:58 -0500)]
Stamping 0864-0867 for MVF, CRA, and TPAC MRs

That is, Multi-valued Fields, Composite Record Attibutes, and TPAC
Metarecord support.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1053397 Prevent display non-opac-visible icons / hold formats
Bill Erickson [Fri, 21 Feb 2014 18:48:07 +0000 (13:48 -0500)]
LP#1053397 Prevent display non-opac-visible icons / hold formats

Avoid showing coded value maps for icons, hold formats, and hold
languages where the coded value's opac_visible value is FALSE.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1053397 icon / metarcord format additions
Bill Erickson [Fri, 21 Feb 2014 17:19:14 +0000 (12:19 -0500)]
LP#1053397 icon / metarcord format additions

 * Adds a new blu-ray format for icon and metarecord holds

 * Remove large-print items from the generic "book" attribute for icons
   and holds.

   For icons, this means we will no longer see two icons displayed for a
   single large-print book.

   For holds, this means that to receive a large-print book, one has to
   select the large-print book format.  "book" alone will not result in
   a large-print item being targted.

   Note that when building a data set for the format selector drop-down,
   it might make sense to keep large-print items in the generic "book"
   format.  That'll come later.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1053397 MR list return to grouped results
Bill Erickson [Fri, 21 Feb 2014 15:19:00 +0000 (10:19 -0500)]
LP#1053397 MR list return to grouped results

Show a "Return to Grouped Search Results" link from the metarecord
constituent records page.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1053397 staff client MR results paging repair
Bill Erickson [Thu, 20 Feb 2014 20:05:11 +0000 (15:05 -0500)]
LP#1053397 staff client MR results paging repair

When selecting a record from the list of metarecord constituents, the
paging controls (start/previous/next/end) within the staff client should
page through the constiuents, not the original search.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1053397 MR holds displays selected formats
Bill Erickson [Thu, 20 Feb 2014 19:48:53 +0000 (14:48 -0500)]
LP#1053397 MR holds displays selected formats

In a patron's holds list, only show formats in the format column
matching the patron's selected hold formats.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1053397: Use the new data structures for looking up language indexing configuration
Mike Rylander [Wed, 19 Feb 2014 22:11:29 +0000 (17:11 -0500)]
LP#1053397: Use the new data structures for looking up language indexing configuration

Also, from Dan Wells:

First, we don't want to fully exclude records which don't have a
metabib.record_attr_vector_list entry, so we do a LEFT JOIN instead
for that table.  Otherwise, some records error out when ingesting
(see placeholder record -1 in the stock data set).

Second, let's add a check for 'active' which appears to have been
always missing.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1053397: Correct operator thinko on CRA sorters
Mike Rylander [Wed, 19 Feb 2014 18:06:32 +0000 (13:06 -0500)]
LP#1053397: Correct operator thinko on CRA sorters

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP1053397: Don't leak memory; Cache compiled ccraed values
Mike Rylander [Tue, 18 Feb 2014 21:53:53 +0000 (16:53 -0500)]
LP1053397: Don't leak memory; Cache compiled ccraed values

We were leaking memory in a PLPGSQL function that compiles the
query_int from a ccraed value.  Stop doing that!

Also, implement a self-invalidating (upon table update) cache
for compiled composite attr defs.  This brings concerto reingest
down from 50+ seconds to under 10.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1053397 catch-all 'music' icon_format attribute value
Bill Erickson [Mon, 17 Feb 2014 20:08:11 +0000 (15:08 -0500)]
LP#1053397 catch-all 'music' icon_format attribute value

Many records in the Evergreen sample data have item_type=j and no sound
recording format.  This seems likely to happen in the wild, as well.
The new coded value captures everying with item_type=j and no sr_format.

Also included is a "music.png" icon, which looks like a pair of happy
eigth notes.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1269911: Cast bigint to int
Mike Rylander [Mon, 17 Feb 2014 19:03:02 +0000 (14:03 -0500)]
LP#1269911: Cast bigint to int

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1053397 filter MR icons/formats repair
Bill Erickson [Mon, 17 Feb 2014 14:24:40 +0000 (09:24 -0500)]
LP#1053397 filter MR icons/formats repair

Only limit the scope of the MR attributes in the presence of a hard hold
boundary when searching for which attributes to display in the hold
placement form.

In other words, don't limit the attributes based on search parameters,
since searching at Branch 1 does not necesssarily meany you only want to
place holds on formats available at branch 1.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1053397 filter MR icons/formats by org scope
Bill Erickson [Fri, 14 Feb 2014 22:25:44 +0000 (17:25 -0500)]
LP#1053397 filter MR icons/formats by org scope

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1053397: Add optional org filter to "has holdable copies", and use that in open...
Mike Rylander [Fri, 14 Feb 2014 21:06:59 +0000 (16:06 -0500)]
LP#1053397: Add optional org filter to "has holdable copies", and use that in open-ils.circ.holds.metarecord.filterd_records

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1053397 apply org scope to metarecord attributes
Bill Erickson [Fri, 14 Feb 2014 19:34:02 +0000 (14:34 -0500)]
LP#1053397 apply org scope to metarecord attributes

When loading record attributes (cra, ccvm, etc.) for constituent
records, limit the attributes to those contained by records which have
holdings within the provided (search) scope.

With this, for example, a search at Branch 1 for metarecords will only
show format icons for constituent records that have holdings at BR1.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1053397 repair one-hit redirect logic for metarecords
Bill Erickson [Fri, 14 Feb 2014 17:23:02 +0000 (12:23 -0500)]
LP#1053397 repair one-hit redirect logic for metarecords

* Only perform the single-hit redirect if there is only one metarecord
  search result and the MR only has a single constituent record.

* Repair the record id logic so the redirect jumps to the correct
  record.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1269911 global flag for opac format selector attribute
Bill Erickson [Thu, 13 Feb 2014 21:28:01 +0000 (16:28 -0500)]
LP#1269911 global flag for opac format selector attribute

Adds a new config.global_flag for defining which record attribute the
OPAC will use to find formats for the format selector.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1269911 seed data SQL repairs
Bill Erickson [Thu, 13 Feb 2014 20:28:39 +0000 (15:28 -0500)]
LP#1269911 seed data SQL repairs

Products of merge conflict resolution with the mvf-cra branch.

* repaired syntax error
* removed some duplicate global flag entries

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1269911 'large print book' is also a 'book'
Bill Erickson [Tue, 11 Feb 2014 15:33:01 +0000 (10:33 -0500)]
LP#1269911 'large print book' is also a 'book'

Remove the item_form != d component of the "book" composite definition.
I think this more closely matches how humans would interpret it.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/src/sql/Pg/950.data.seed-values.sql

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1053397 TPAC Metarecords release notes
Bill Erickson [Mon, 10 Feb 2014 19:01:05 +0000 (14:01 -0500)]
LP#1053397 TPAC Metarecords release notes

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1053397 TPAC metarecord search and holds UI
Bill Erickson [Mon, 10 Feb 2014 19:01:47 +0000 (14:01 -0500)]
LP#1053397 TPAC metarecord search and holds UI

API, TPAC backend, and UI bits for TPAC metarecord searching and holds.

* Group Formats and Editions options in advanced search / searchbar
* MR holds placement form, allowing selected formats and languages
* MR holds targeting updated to work w/ new holdable formats composite
  definitions

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1053397 DB metarecord seed data
Bill Erickson [Mon, 10 Feb 2014 19:00:21 +0000 (14:00 -0500)]
LP#1053397 DB metarecord seed data

Seed data for representing the holdable formats for metarecords.  This
is a subset of the "icon_format" collection, excluding the electronic
resources.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1053397 DB for metarecords unapi and holds
Mike Rylander [Mon, 10 Feb 2014 18:59:23 +0000 (13:59 -0500)]
LP#1053397 DB for metarecords unapi and holds

Schema for unapi metarecord access (unap.mmr()) and associated
components.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1053397 IDL class mraf for metabib::record_attr_flat
Bill Erickson [Mon, 10 Feb 2014 18:54:43 +0000 (13:54 -0500)]
LP#1053397 IDL class mraf for metabib::record_attr_flat

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1269911: Release notes for Composite Record Attributes
Mike Rylander [Mon, 10 Feb 2014 19:10:38 +0000 (14:10 -0500)]
LP#1269911: Release notes for Composite Record Attributes

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1269911: Release notes for Multi-valued Fields and Controlled Attributes
Mike Rylander [Mon, 10 Feb 2014 19:02:22 +0000 (14:02 -0500)]
LP#1269911: Release notes for Multi-valued Fields and Controlled Attributes

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1053397: removed extraneous MR formats global flag
Bill Erickson [Mon, 10 Feb 2014 19:12:15 +0000 (14:12 -0500)]
LP#1053397: removed extraneous MR formats global flag

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1269911: TPAC generates format selector from icon_format attr
Bill Erickson [Thu, 6 Feb 2014 18:31:18 +0000 (13:31 -0500)]
LP#1269911: TPAC generates format selector from icon_format attr

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1269911: composite attributes: configurable "icons" attribute
Bill Erickson [Wed, 5 Feb 2014 21:18:38 +0000 (16:18 -0500)]
LP#1269911: composite attributes: configurable "icons" attribute

Honor the configurable icon attribute within the TPAC.

Create a default set of icons, by copying from the existing icons,
which roughly map to the new "icon_format" record attribute
definition mappings.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1269911 composite attributes admin UI
Bill Erickson [Tue, 21 Jan 2014 22:47:41 +0000 (17:47 -0500)]
LP#1269911 composite attributes admin UI

New interface for managing composite record attribute definitions:

/eg/conify/global/config/composite_attr_entry_definition/<id>

The UI for a coded value map is accessed from an existing coded value
via a new "Manage" link column in the CCVM table.  The UI allows staff
to build tree-shaped boolean composite definitions for CCVMs in terms
of existing CCVMs.

Additionally, the record attribute definition UI now has a link from
each definition to the coded value map page for the attribute.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1269911: Upgrade script for MVF and CRA
Mike Rylander [Wed, 15 Jan 2014 21:48:13 +0000 (16:48 -0500)]
LP#1269911: Upgrade script for MVF and CRA

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1269911: Teach QueryParser new tricks
Mike Rylander [Wed, 15 Jan 2014 21:00:52 +0000 (16:00 -0500)]
LP#1269911: Teach QueryParser new tricks

QP Needs to be made aware of several new structures in the database.

First, we have added a new sort-supporting table called metabib.record_sorter
which holds values extracted by crad.sorter=true attrs.  This is used instead
of the mrd.attrs->"something" hstore composite.

Next, we teach QP how to convert from a list of user-supplied values across
many dynamic filters (based on crad) into an intarray query of ids extracted
from config.coded_value_map (in the case of controlled attributes) or
metabib.uncontrolled_record_attr_value (in the case of, you guessed it,
uncontrolled attributes).  This query is applied against the vlist column
of metabib.record_attr_vector_list, which is GIN indexed for speed.

Finally, metabib.record_attr is now a view over metabib.record_attr_vector_list
and is consequently going to be slow for general use.  We restrict
its inclusion in the core query to only the case of a during() filter
which requires access to the value of a bib's Date2 field.  For the
other common case, requiring access to the Date1 field, we instead
use the pubdate sort value now stored in metabib.record_sorter.  We
might consider making the specific sorter attribute used configurable
so that we can change the definition of pubdate down the road, but it
starts out (and generally stays) defined as equivalent to Date1.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1269911: Teach the IDL about MVF- and CRA-related structures
Mike Rylander [Wed, 15 Jan 2014 18:17:39 +0000 (13:17 -0500)]
LP#1269911: Teach the IDL about MVF- and CRA-related structures

IDL link from ccvm => ccraed via composite_def field

IDL selector attribute for ccvm class

ccraed gets CUD actions

In conify/global/config/coded_value_map, if the selected attr type is
composite=true, show a link from each coded value to manage the
composite definition.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1269911: Database elements of MVF and CRA
Mike Rylander [Tue, 14 Jan 2014 21:28:04 +0000 (16:28 -0500)]
LP#1269911: Database elements of MVF and CRA

* Teach vandelay.marc21_physical_characteristics() to see all 007's

We use vandelay.marc21_physical_characteristics() to extract fixed
field data that lives in the 007.  Before this change, it would
only look at the first 007 in the record.  Now it will look at
all of them in turn, supporting configurations such as DVD+BluRay.

* Add intarray extension

We need intarray for GIN index support of integer arrays, which is
how we'll be storing the in-use record attribute value identifiers.

* Hidy hole in which to stick "uncontrolled" values

In order to make use of the massive speed increases provided by
intarray indexing, we need to use (you guessed it) integers.  But
uncontrolled record attributes are not necessarily (or even very
often) numbers.  We will store them in a table of unique (per
attribute) values, and use the id from that table in our intarray
indexing.  That id comes from a DECREMENTING serial that starts
at -1 and counts downward.  This avoids collision with the other
set of integers (the id from config.coded_value_map) that we will
use for controlled record attribute values.

* Add a multi flag for record attrs

We pre-coordinate which record attrs are allowed to be multi-valued
with this new bool.  Most can be, we set the default to true and
adjust the seed data for those that should be false (sorters and
fields in the leader).

* New intarray-focused attribute extraction

We rewrite the record attribute extraction to capture all the
record-supplied values for each attribute (where multi is true)
and store that list in the new (fkey-corrected) metabib.record_attr_vector_list
table.  Only filters make it into this table.

We also insert a parameter after the record id to accept a list of
record attributes we want to rewrite. This defaults to NULL to rewrite
all of them.

Sorters are stored in a new, separate table built specifically for them.

metabib.record_attr becomes a vew atop metabib.record_attr_vector_list
which expands the intarray stored therein into an hstore. For
multi=true attributes, only one will be returned through this view,
as is HSTORE's way, and which will be returned is undefined.  However
this view is only provided for the purpose of backward compat with
reports or other locally defined logic.

And, finally, baseline seed data

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoFix syntax error in seed data
Remington Steed [Fri, 21 Feb 2014 14:54:47 +0000 (09:54 -0500)]
Fix syntax error in seed data

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoStamping 0863 - Stripe credit card payment options
Dan Wells [Thu, 20 Feb 2014 21:35:21 +0000 (16:35 -0500)]
Stamping 0863 - Stripe credit card payment options

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoRelease note for Stripe payment support
Lebbeous Fogle-Weekley [Fri, 11 Oct 2013 05:13:44 +0000 (01:13 -0400)]
Release note for Stripe payment support

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoSupport Stripe payments with some new code and some rearranged code ...
Lebbeous Fogle-Weekley [Thu, 19 Sep 2013 15:00:00 +0000 (11:00 -0400)]
Support Stripe payments with some new code and some rearranged code ...

... behind the open-ils.circ.money.payment method.

- Also add Business::Stripe as a CPAN module to the pre-reqs installers.
- If payment processor is Stripe, only show form if Javascript enabled.

Our implementation of payments via Stripe doesn't work without Javascript.
That's part of the point. Using Stripe really limits a site's worries
about PCI compliance because users' credit card number and security
codes are never transmitted to the [Evergreen] server at all.  That data
goes to Stripe instead (using Javascript) and from that we get back a
one-time token from Stripe to give to our server instead.

Thanks to Jason Boyer at the Indiana State Library for recognizing the
value of supporting approaches like that in Evergreen and for starting
the work.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Conflicts:
Open-ILS/src/templates/opac/myopac/main_payment_form.tt2

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoDB upgrade script for Stripe payments; seed data; minor template fixes
Lebbeous Fogle-Weekley [Thu, 19 Sep 2013 13:51:47 +0000 (09:51 -0400)]
DB upgrade script for Stripe payments; seed data; minor template fixes

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Conflicts:
Open-ILS/src/templates/opac/myopac/main_payment_form.tt2

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoSeparate stripe js into stripe.tt2, add seed data for ou settings
Jason Boyer [Thu, 19 Sep 2013 13:45:25 +0000 (09:45 -0400)]
Separate stripe js into stripe.tt2, add seed data for ou settings

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoRough draft of integrating Stripe support into the opac payment page.
Jason Boyer [Thu, 19 Sep 2013 13:16:30 +0000 (09:16 -0400)]
Rough draft of integrating Stripe support into the opac payment page.

Conflicts:
Open-ILS/src/templates/opac/myopac/main_payment_form.tt2
Open-ILS/src/templates/opac/parts/base.tt2

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoDuplicate 0851 as 0862 for backport clarity
Dan Wells [Thu, 20 Feb 2014 15:01:46 +0000 (10:01 -0500)]
Duplicate 0851 as 0862 for backport clarity

Rather than backport 0851 after 0852 has already been backported,
let's give 0851 a second number.  It probably wouldn't have bitten
anyone, but there's no harm in running this upgrade again, and I
don't think it hurts to be extra clear.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP1223903 - Also bump the schema config
Ben Shum [Wed, 19 Feb 2014 19:39:06 +0000 (14:39 -0500)]
LP1223903 - Also bump the schema config

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP1223903 - Stamping upgrade script for new authority_record_entry indexes
Ben Shum [Wed, 19 Feb 2014 19:22:37 +0000 (14:22 -0500)]
LP1223903 - Stamping upgrade script for new authority_record_entry indexes

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP1223903 - Add release notes for rewrite of marc_export.
Jason Stephenson [Thu, 6 Feb 2014 16:18:49 +0000 (11:18 -0500)]
LP1223903 - Add release notes for rewrite of marc_export.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP1223903 - Rewrite marc_export.in in support-scripts.
Jason Stephenson [Wed, 5 Feb 2014 16:24:05 +0000 (11:24 -0500)]
LP1223903 - Rewrite marc_export.in in support-scripts.

This commit rewrites marc_export.in in the support-scripts  src directory.
It will still be transformed into marc_export at build time.  This change
replaces the current marc_export scipt with a faster, DBI based alternative.

The replacement support nearly all of the features of the original, except
for the progress output.  Much of this information is harder to gather
with the new design.

This is a squashed, rebased commit of previous work.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP1223903 - Add indexes to authority.record_entry.
Jason Stephenson [Tue, 10 Dec 2013 20:16:21 +0000 (15:16 -0500)]
LP1223903 - Add indexes to authority.record_entry.

We want indexes on edit_date and create_date for authority.record_entry
so that date-based searching is faster for authority record export.  It
likely will prove useful for other features.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP1223903 - Add from_bare_hash to Fieldmapper.pm.
Jason Stephenson [Thu, 26 Sep 2013 05:53:35 +0000 (01:53 -0400)]
LP1223903 - Add from_bare_hash to Fieldmapper.pm.

Teach the Perl Fieldmapper.pm to build objects from a hashref in a
similar manner to how the JS Fieldmapper already can.  You might use
it if you retrieved a database row as a hashref, like so:

my $hashref = {};
my $class = Fieldmapper::class_for_hint('bre');
my $bre = $class->from_bare_hash($hashref);

We also modify the Fieldmapper's properties method to sort the array of
field names it returns by position.  This makes the return value a lot
more useful for on the fly object construction and other fancy tricks.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoLP#1262722 Fix DB supersedes/deprecates pgtap test
Bill Erickson [Wed, 19 Feb 2014 15:22:37 +0000 (10:22 -0500)]
LP#1262722 Fix DB supersedes/deprecates pgtap test

Sort multi-value arrays before passing them off to pgtap for test
comparison. Otherwise, pgtap tests may fail with:

Failed test 5
        have: {AAAC,AAAB}
        want: {AAAB,AAAC}

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jeff Godin <jgodin@tadl.org>
5 years agoStamping upgrade script for supsersede/deprecate logic fixes
Mike Rylander [Tue, 18 Feb 2014 18:01:08 +0000 (13:01 -0500)]
Stamping upgrade script for supsersede/deprecate logic fixes

Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoDB patch supersede/deprecate logic repairs; unit tests
Bill Erickson [Thu, 19 Dec 2013 15:27:26 +0000 (10:27 -0500)]
DB patch supersede/deprecate logic repairs; unit tests

* Fix some thinkos in the various DB functions for calculating
  supersedes/deprecation logic.

* Added a pgtap test

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoStamping upgrade for Granular Staff Initials settings
Mike Rylander [Tue, 18 Feb 2014 17:47:42 +0000 (12:47 -0500)]
Stamping upgrade for Granular Staff Initials settings

Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoAdd granular settings for requiring staff initials for notes
Ben Shum [Tue, 28 May 2013 18:54:27 +0000 (14:54 -0400)]
Add granular settings for requiring staff initials for notes

Up till now, there has only been one setting for making staff initials required
for all of the various note fields. Instead, let's break this up into separate
org unit settings for each type of note field, giving us more flexiblity in
making use of the append staff initials feature.

These three types of notes will now have settings to add initials for each:

- patron penalties/messages
- patron information notes
- copy (item) notes

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1272074 Physical Characteristics Wizard for the MARC Editor (Part II)
Lebbeous Fogle-Weekley [Tue, 18 Feb 2014 17:15:18 +0000 (12:15 -0500)]
LP#1272074 Physical Characteristics Wizard for the MARC Editor (Part II)

These files should have been in the other commit with the above title,
but I lost them in a rebase effort.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoStamping 0858: Fixed field enhancements
Dan Wells [Tue, 18 Feb 2014 17:01:29 +0000 (12:01 -0500)]
Stamping 0858: Fixed field enhancements

Also, move test file to a possibly better location.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1272074 Release notes (with pictures!) of fixed fields MARC editor enhancements
Lebbeous Fogle-Weekley [Thu, 23 Jan 2014 21:02:02 +0000 (16:02 -0500)]
LP#1272074 Release notes (with pictures!) of fixed fields MARC editor enhancements

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1272074 Fix faulty physical characteristics seed data
Lebbeous Fogle-Weekley [Mon, 18 Nov 2013 17:31:47 +0000 (12:31 -0500)]
LP#1272074 Fix faulty physical characteristics seed data

For 007 (00/a=f), "subfield" e (Level of contraction) starts at position
5, not 4.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1272074 Physical Characteristics Wizard for the MARC Editor
Lebbeous Fogle-Weekley [Tue, 12 Nov 2013 22:51:57 +0000 (17:51 -0500)]
LP#1272074 Physical Characteristics Wizard for the MARC Editor

Right-click in an 007 field to find a new entry in the context menu that
launches this wizard.  The prompts and suggested values come from data
already found in the database.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>