scottmk [Thu, 27 May 2010 16:10:50 +0000 (16:10 +0000)]
Add new expression type 'xser' to represent series expressions,
i.e. a series of expressions separated by operators, such as a
chain of ANDed conditions.
M Open-ILS/src/sql/Pg/002.schema.config.sql
M Open-ILS/src/sql/Pg/008.schema.query.sql
A Open-ILS/src/sql/Pg/upgrade/0280.schema.query-xser.sql
M Open-ILS/examples/fm_IDL.xml
erickson [Thu, 27 May 2010 13:18:45 +0000 (13:18 +0000)]
added Replace Barcode option into new patron reg. interface. Also added a basic See All operation that shows all attached barcodes for a user, provides no editing capabilities
scottmk [Thu, 27 May 2010 12:38:48 +0000 (12:38 +0000)]
Bug fix in verifyObjectPCRUD().
When traversing a chain of rows according to the "jump" attribute:
if you encounter a null foreign key, just stop looking, without
issuing an exception.
scottmk [Wed, 26 May 2010 19:03:25 +0000 (19:03 +0000)]
Correcting some diverging drift in the usr_merge function
M Open-ILS/src/sql/Pg/999.functions.global.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0278.function.usr-merge-drift.sql
scottmk [Wed, 26 May 2010 13:27:29 +0000 (13:27 +0000)]
Bug fixes in verifyObjectPCRUD():
1. Don't throw an exception just because a foreign key is null.
2. When looking for local or foreign contexts, always do a lookup of
the current row, even if you already have an image of that row in
hand. The image you have may not include the foreign key(s) you need.
The latter fix is simple but inefficient. It should be possible to
avoid the extra lookup most of the time, and maybe all of the time,
for the search, retrieve, and id_list methods. However that will
involve additional complications, not yet implemented. Let's make
it correct first, and worry about efficiency later.
scottmk [Tue, 25 May 2010 17:53:43 +0000 (17:53 +0000)]
Correcting an upgrade script.
The value column in actor.org_unit_setting should be valid JSON. In this
revised version the new value is jiggered to make it a string instead of a
number. This conversion is a bit simplistic and can be defeated by various
kinds of improbable input.
M Open-ILS/src/sql/Pg/upgrade/0274.data.org-setting-type-est-wait.sql
scottmk [Tue, 25 May 2010 16:21:56 +0000 (16:21 +0000)]
Plug some memory leaks, and eliminate some unnecessary
memory allocations.
In oils_utils.[ch]:
-- Create a new function, oilsFMGetStringConst(), similar to
oilsFMGetString() except that it doesn't allocate memory; it returns
a const pointer to a string internal to the specified object.
-- Add some comments, tidy up white space.
In oils_sql.c:
-- Replace oilsFMGetString() with oilsFMGetStringConst in a number
of places; partly to reduce memory churn, and partly to plug some
memory leaks where the function call was nested within a
parameter list.
-- Change org_tree_root() so as to return a const pointer to a
static buffer (which was already in use as a cache) instead of
allocating a copy of the string. This change reduces memory
churn. In addition the allocated string was leaking anyway, and
now that leak is plugged.
M Open-ILS/include/openils/oils_utils.h
M Open-ILS/src/c-apps/oils_sql.c
M Open-ILS/src/c-apps/oils_utils.c
scottmk [Tue, 25 May 2010 03:24:07 +0000 (03:24 +0000)]
Various changes to verifyObjectPCRUD():
1. Add numerous comments.
2. Check for nullity of local_context before dereferencing it.
3. If the lookup of a foreign row results in an empty result set, set
_param to NULL instead of pointing it to a JSON_NULL. (Existing code
seems to assume such a policy. This assumption was false, because
jsonObjectClone() never returns NULL.)
4. Instead of using jsonObjectClone() and then immediately destroying
the original, use jsonObjectExtractIndex() to pull an existing subobject
out of its surroundings.
5. In the loop implementing the "jump" attribute: plug a memory leak by
freeing _fparam before assigning it a new value.
6. In the loop that adds org unit contexts from a foreign row: take the
call to osrfHashGet() out of the loop condition, since its return value
is a loop invariant.
-----------
NOTE: This patch does *not* fix a known bug whereby we try to trace
foreign keys that are not present in the available row image. The result
of the bug is that all id_list calls deny access in pcrud. The same bug
can affect retrieve and search calls, if the call specifies a SELECT list
that doesn't include all the necessary foreign keys.
A fix for this bug will come later; fixing it now would make it harder to
test the current changes.
...with corresponding tweaks to label and description.
Also: change datatype from 'integer' to 'interval'.
For any existing rows in actor.org_unit_setting, pointing to the old
setting type: update them to point to circ.holds.default_estimated_wait_interval.
(Due to a foreign key constraint, the latter update has to happen in the same
transaction as the rename of the old row.)
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0274.data.org-setting-type-est-wait.sql
M Open-ILS/src/sql/Pg/950.data.seed-values.sql
miker [Fri, 21 May 2010 17:01:32 +0000 (17:01 +0000)]
Patch from Jason Stephenson which adds "IF EXISTS" to all DROP SCHEMA statements where it is currently missing in the scripts in Open-ILS/src/sql/Pg directory.
scottmk [Fri, 21 May 2010 16:32:00 +0000 (16:32 +0000)]
Add column avg_wait_time to config.circ_modifier.
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0273.schema.config-circ-mod-avg-wait.sql
M Open-ILS/src/sql/Pg/100.circ_matrix.sql
M Open-ILS/examples/fm_IDL.xml
erickson [Fri, 21 May 2010 15:09:13 +0000 (15:09 +0000)]
hide the out-of-sync, non-xul dojo menu in the html pages. we don't want it showing up in the self-check UI or any oter public UIs built from templates
scottmk [Fri, 21 May 2010 13:04:16 +0000 (13:04 +0000)]
Fixing a typo in the previous changeset (a missing comma that led to
nonsense instead of an obvious error).
M Open-ILS/src/sql/Pg/002.schema.config.sql
M Open-ILS/src/sql/Pg/008.schema.query.sql
A Open-ILS/src/sql/Pg/upgrade/0270.schema.query-xisnull-correction.sql
scottmk [Thu, 20 May 2010 20:35:12 +0000 (20:35 +0000)]
Create database support for IS [NOT] NULL expressions
in stored queries.
M Open-ILS/src/sql/Pg/002.schema.config.sql
M Open-ILS/src/sql/Pg/008.schema.query.sql
A Open-ILS/src/sql/Pg/upgrade/0269.schema.query-xisnull.sql
M Open-ILS/examples/fm_IDL.xml
erickson [Thu, 20 May 2010 14:10:47 +0000 (14:10 +0000)]
loosen the restrictions on exporting holdings / price data from uploaded records. It's no longer necessary to set every field in the holdings data just to import. if no quantity is defined, go ahead and pull the estimed price data (when present) to link it with the lineitem
phasefx [Thu, 20 May 2010 04:55:40 +0000 (04:55 +0000)]
* I18N for print admin interface
* custom/external print strategy (where you dictate an external command and feed it %receipt.txt% and/or %receipt.html%)
* DOS LPT1 Print strategy preserved as a legacy option, but without serving double-duty with the external linux commands
* label printing now honors plain text print strategies, but we're still stuck with system defaults for print dialogs
* @hex attribute for generating control characters when using HTML in templates being rendered with plain text print strategies
For example, <p hex="0C">Hello World</p> will transform into form feed + Hello World if used with DOS LPT1 Print or with the
%receipt.txt% macro for the Custom/External Print strategy. <p>Hello World</p hex="0C"> will yield Hello World + form feed.
miker [Wed, 19 May 2010 18:54:25 +0000 (18:54 +0000)]
add ISBN 10/13 index normalizer (requires ISN postgres contrib module); adjust index definition xpath so it actually works; generalize indexing trigger function so it does not have to know about search classes before hand
scottmk [Wed, 19 May 2010 12:46:18 +0000 (12:46 +0000)]
Add partial support for bind variables: load them from the
database, and use default values if available. There is no
mechanism yet to override the defaults.
scottmk [Tue, 18 May 2010 20:12:38 +0000 (20:12 +0000)]
Fix a typo in a previous commit to the acq schema. The upgrade script was
correct, but this upgrade script will fix a database table that was built
from the installation script, which was wrong.
M Open-ILS/src/sql/Pg/200.schema.acq.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0266.schema.acq-fix-edi-message-check.sql
scottmk [Mon, 17 May 2010 16:47:32 +0000 (16:47 +0000)]
Two changes to acq.edi_message:
1. New "message_type" column.
2. New valid value for status column: 'retry'.
-- WARNING: because the new column is NOT NULL, this upgrade script must
-- initialize it with something if the table is not empty. The initial
-- value, 'ORDERS', may not always be appropriate. Massage as needed.
M Open-ILS/src/sql/Pg/200.schema.acq.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0264.schema.acq-edi-message-type.sql
M Open-ILS/examples/fm_IDL.xml
miker [Sun, 16 May 2010 20:19:09 +0000 (20:19 +0000)]
Optional pgmemcache-based caching of permission checks. Significantly speeds permission testing for common checks against heavy-use users, such as circulation-related permissions.
senator [Thu, 13 May 2010 21:07:16 +0000 (21:07 +0000)]
Acq: the XULTermLoader dijit now returns the first columns of CSV rows
Could be improved later to allow more control over what data you get back,
but it works fine for the current uses (reading a file of one-term-per-line
for unified search and reading a CSV file where the first column is of
interest in the Bib record->lineitem interface).
Also added a little support to the LI table/pager for remember what lineitems
are selected even after you move on to the next page. Nothing really takes
full advantage of this yet, though.
erickson [Thu, 13 May 2010 19:05:09 +0000 (19:05 +0000)]
use estimed_unit_price directly on the lineitem in JEDI creation. strip protocol/port info from the edi account host before attempting remote delivery. more strict check of successfull login for RemoteAccount
miker [Thu, 13 May 2010 16:44:14 +0000 (16:44 +0000)]
teach the overlay functions about data matching REs; add a template-based merge instead of requiring a vandelay record, and use that for bib merging; minor logic collapsing
senator [Thu, 13 May 2010 15:02:58 +0000 (15:02 +0000)]
Acq: two bug fixes
1) a bug recently introduced in unified search would try to build the catalog
search query more often than needed (and fail at it)
2) there was a colliding accesskey in staff client acquisitions menu
erickson [Thu, 13 May 2010 14:23:14 +0000 (14:23 +0000)]
moved to generic acqpo.activate hook instead of the format.po.jedi hook
added validator to determine of a PO should create JEDI
added JEDI creation reactor. it behaves like ProcessTemplate, but gives
us something more specific to filter acqpo.activate events on
update PO JEDI reactor to use new hook and reactor
update the edi_pusher to filter out events for PO's that have already
been processed
senator [Wed, 12 May 2010 22:14:49 +0000 (22:14 +0000)]
Acq: import file of bib IDs, get paginated LI table from which make new orders
This is most of the way to being usable, but isn't all there,
as it probably still needs:
1) trivial parsing of the input file so that we can look for a
specific column in a CSV file to treat as a bib ID instead of a whole line,
2) a way to select and act on lineitems not currently displayed on the page
scottmk [Wed, 12 May 2010 20:44:40 +0000 (20:44 +0000)]
Add purchase_order column to acq.edi_message.
Also: add the CREATE TABLE command for acq.edi_message (including
the new column) to 200.schema.acq.sql, where it was omitted due
to an oversight.
M Open-ILS/src/sql/Pg/200.schema.acq.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0259.schema.acq-edi-msg-po.sql
M Open-ILS/examples/fm_IDL.xml
scottmk [Tue, 11 May 2010 19:53:25 +0000 (19:53 +0000)]
Add "label" column to query.bind_variable
M Open-ILS/src/sql/Pg/002.schema.config.sql
M Open-ILS/src/sql/Pg/008.schema.query.sql
A Open-ILS/src/sql/Pg/upgrade/0257.schema.query-bind-var-label.sql
M Open-ILS/examples/fm_IDL.xml
scottmk [Mon, 10 May 2010 19:48:15 +0000 (19:48 +0000)]
Define an updatable view query.expr_xbind as those rows in
query.expression where type = 'xbind'.
M Open-ILS/src/sql/Pg/002.schema.config.sql
M Open-ILS/src/sql/Pg/008.schema.query.sql
A Open-ILS/src/sql/Pg/upgrade/0256.schema.query-bind-expr-view.sql
M Open-ILS/examples/fm_IDL.xml
scottmk [Mon, 10 May 2010 18:42:52 +0000 (18:42 +0000)]
Add to query.expression: foreign key bind_variable pointing
to query.bind_variable. Also: allow the expression type 'xbind'.
M Open-ILS/src/sql/Pg/002.schema.config.sql
M Open-ILS/src/sql/Pg/008.schema.query.sql
A Open-ILS/src/sql/Pg/upgrade/0255.query-expr-bind.sql
M Open-ILS/examples/fm_IDL.xml
scottmk [Mon, 10 May 2010 14:52:05 +0000 (14:52 +0000)]
Add table query.bind_variable.
M Open-ILS/src/sql/Pg/002.schema.config.sql
M Open-ILS/src/sql/Pg/008.schema.query.sql
A Open-ILS/src/sql/Pg/upgrade/0254.schema.query-bind-variable.sql
M Open-ILS/examples/fm_IDL.xml
scottmk [Sat, 8 May 2010 20:17:42 +0000 (20:17 +0000)]
Revise the updatable views for the various types of query.expression:
1. Rename query.expr_string to query.expr_xstr, for consistency.
2. Add a "negate" column to each view, except for query.expr_xnum
and query.expr_xstr.
3. Add a "left_operand" column to query.expr_xin, correcting an
earlier oversignt.
M Open-ILS/src/sql/Pg/002.schema.config.sql
M Open-ILS/src/sql/Pg/008.schema.query.sql
A Open-ILS/src/sql/Pg/upgrade/0253.schema.query_expr_view.sql
M Open-ILS/examples/fm_IDL.xml
projects / working / Evergreen.git / log