Bill Erickson [Tue, 22 May 2012 20:22:14 +0000 (16:22 -0400)]
TPAC: recover the ability to override hold placement failures
There is a certain class of hold failure events (e.g. HOLD_EXISTS,
HOLD_ITEM_CHECKED_OUT) that can be overridden by patrons when they have
the correct override permission. This change recovers that ability,
which was recently removed with 99e8fc893a.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
The set of filter groups available to the TPAC are those defined at the
search org unit and its ancestors. If multiple filters have the same
code name, the filter owned closest to the context org unit is used.
This allows for global filters with local overrides.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Wed, 18 Apr 2012 20:15:46 +0000 (16:15 -0400)]
tpac : search_HINT cache fixes
When searching for multiple values like a list of IDs, generate the
cache key from the sorted JSON form of the search value instead of the
bare ARRAY ref.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Wed, 18 Apr 2012 17:24:24 +0000 (13:24 -0400)]
Teach QueryParser about search filter callbacks, and if a callback returns a value, parse it at the current recursion level
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Thu, 23 Feb 2012 19:28:50 +0000 (14:28 -0500)]
Search Filter Groups and Generic Queries : DB / IDL
Adds 3 new tables. The first is a general purpose container for
query-parser queries. These can be used by other entities for storing
saved searches, saved search filters, etc. Each contains a query string
and a label.
The two other tables are for creating org unit saved search filter
groups. A filter group is a named set of search queries, treated as
filters, collected to create a high-level search filter. Filter group
entries use search_query's under the covers, so the content of the
filter can be any valid query string, including other filters or even
other filter groups.
For example, you could create an "Audience" filter group with entries
like, "Children" => "audience(a, b) locations(3,4,5)" to filter on copy
location in addition to the MARC audience data.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Mon, 21 May 2012 14:32:56 +0000 (10:32 -0400)]
Query Parser merged copy / non-dynamic filters
When more than one copy-level filter (e.g. locations()) is used in a
query-parser query, all but the first are ignored. The goal of this
work is to compress multiple copy-level filters into a single filter
that represents the full collection. Wherever possible, boolean
structures will be honored, to the extent possible for post-search
copy-level filters.
( concerto locations(3,4,5) ) && ( piano locations(3,5,7) )
==> concerto piano locations(3,5)
Note, in the last 2 examples, the final query does not exactly match the
original. This is because copy-level filters are applied after the
initial search and cannot be executed as part of the nested query. The
best we can do is create a representation of the final copy-level
filter, based on the nesting, and apply it to the final result of the
nested search.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Tue, 15 May 2012 22:00:30 +0000 (18:00 -0400)]
Query Parser nested dynamic filters
Dynamic filters (from metabib.record_attr) are now parsed along with
search strings and facets as Query Parser descends the parse tree. The
WHERE clause for the query as a whole is now a combination of the main
WHERE and the ON clause for JOINing to metabib.record_attr. This gives
us the ability to create complex boolean nested queries using
SVF/record_attr filters, unlike before where nested filters were either
ignored or always treated as global filters.
Dan Scott [Mon, 21 May 2012 19:09:59 +0000 (15:09 -0400)]
Use spaces instead of tabs in QueryParser.pm
Copying swathes of SQL from logs into psql would often trigger the
autocompletion that psql offers, garbling a query awfully. Define the
local $spc var as two spaces and use that instead, leaving open the
option for reverting to tabs or anything else people prefer.
Also remove trailing whitespace, as this whole thing is about space.
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Mike Rylander [Thu, 29 Dec 2011 16:36:20 +0000 (11:36 -0500)]
abstract query representations from QueryParser
When you perform a search, you now also get back an abstract
representation of your search query. fts-replacement.pl is a test
script that shows you things that QueryParser does, including the new
abstract query feature, and it also reconstitutes a string from the
abstract query to demonstrate the correctness of that query.
[Also]
Make last-wins true for facets, filters and modifiers -- arg!; Parameterized values win in the staged-search QP wrapper
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Scott <dan@coffeecode.net>
Dan Scott [Mon, 21 May 2012 18:46:53 +0000 (14:46 -0400)]
QueryParser: comma-delimit multiple WITH clauses
Bill Erickson's fix for my breakage of QueryParser.pm for the speedup
via the WITH common table expression usage inadvertently left out
the commas required to delimit multiple WITH clauses, resulting in SQL
query errors.
This fixes that oversight. Note that the fts-replacement.pl script came
in quite handy for testing this; recommended.
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Jason Stephenson [Sat, 19 May 2012 02:51:14 +0000 (22:51 -0400)]
Add libnet-https-any-perl as precise deb requirement in Makefile.install.
Business::OnlinePayment::PayPal requires it, and it does not always want
to install from CPAN. It says it require either Net-SSLeay or
Crypt-SSLeay but the CPAN package never wants to install unless they
both are installed. The deb package for Ubuntu seems to do the right
thing.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Fri, 18 May 2012 20:42:19 +0000 (16:42 -0400)]
QP support for nested WITH construction
Nested query plans build their own tsquery chunks which have to be
individually JOINed to the final query. To do this, each tsquery SELECT
gets its own entry in the top-level WITH, complete with alias for
joining.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Mon, 21 May 2012 03:02:09 +0000 (23:02 -0400)]
Further integration: link README to server install docs
We will now have the INSTALL file linking to the README file which in
turn leads to the docs/installation/server_installation.text file. But
it all works!
Dan Scott [Mon, 21 May 2012 02:51:52 +0000 (22:51 -0400)]
Merge the Evergreen docs into the code repository
Rather than maintaining two separate repositories, with dual maintenance
of what are essentially single-sourced files in the release notes and
the install instructions, make better use of the docs/ subfolder of the
Evergreen repository. If this crazy scheme works, DIG can commit to the
docs/ subfolder, and devs can commit there too.
Dan Scott [Wed, 16 May 2012 04:29:11 +0000 (00:29 -0400)]
Optimize full text search with a CTE
The tsquery used directly in a JOIN was resulting in bad
plan with lots of nested loops and operations. Using a CTE
to define the query improves the plan.
Also, instead of ARRAY_AGG(DISTINCT foo), just return the
whole thing in an array. Not great for dupes, but we can
handle those inside search.query_parser_fts if we really
need to.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Wed, 16 May 2012 19:55:23 +0000 (15:55 -0400)]
Vandelay authority existing queue search repair
When searching for an existing authority queue, search for an authority
queue, not a bib queue. Apart from simply not working, the query will
fail with an "invalid input value for enum vandelay.bib_queue_queue_type"
and result in a client-side error.
https://bugs.launchpad.net/evergreen/+bug/989391
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Scott [Thu, 17 May 2012 03:40:52 +0000 (23:40 -0400)]
Document hold-driven recalls
Mostly reformatting the original commit message from c403d6bb54 as
documentation. Includes index entries. Tested with current master,
supported since 2.1.0.
Dan Scott [Fri, 11 May 2012 14:45:39 +0000 (10:45 -0400)]
Move PLPERL dropping outside of 2.1-2.2 upgrade transaction
Sites might have added custom PLPERL database functions for migrations,
data clean up, etc, so don't make the success of the 2.1-2.2 upgrade
hinge on a database schema that exactly matches vanilla Evergreen;
just move it outside of the upgrade transaction and output a reassuring
note.
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Fri, 4 May 2012 13:18:10 +0000 (09:18 -0400)]
Check if transaction needs closing after adding billings
This addresses the issue where issuing refunds results in a negative
ballance and it is then impossible to close the transaction by creating
new billings.
https://bugs.launchpad.net/evergreen/+bug/758982
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
TPAC: Keep site() and depth() out of basic search box when widgets suffice
This is a short term but working solution to the problem described here:
https://bugs.launchpad.net/evergreen/+bug/986196
Now when you have a selection for site on the advanced search page, it
doesn't lead to redundant site() and depth() terms in your basic search
query box.
Item type selections and search class selections (keyword/author/etc)
can still lead to ugliness in the advanced search box, but that's
because in the advanced search page you get a multi-select widget for
item type and in a basic search page you only get a single-select
dropdown, so there's not a clean way to map your advanced page
selections to basic page selections. Search classes are kind of the
same issue, since you have three dropdowns on the advanced search page
and one on the basic.
So the "bigger" problem is one that we will have to solve later, but for
the common case at least we don't get the extra site() and depth() for
now.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Fri, 4 May 2012 16:07:35 +0000 (12:07 -0400)]
TPAC: repair staff client End link for showing last record
In the embedded TPAC, when staff clicks the End link in the record
detail page to jump to the last record in the search results, it now
makes an intermediate jump through search code, which locates the last
record in the set (via CGI param find_last) then redirects to the record
detail page for the last record. With this approach, we don't have to
pre-fetch the entire set of record IDs just to render the paging links.
Tip o' the hat to Mike R. for the design suggestion.
https://bugs.launchpad.net/evergreen/+bug/984070
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Consensus was reached to remove editor-specific globs from .gitignore.
In a highly overengineered discussion out of scope with the actual breadth
of this very minor issue, everyone has come to the conclusion that
editor-specific globs don't really belong in the project's .gitignore,
given that git permits a global-level ignore file for users.
Instead, a HACKING file is herein added, with its first entry to explain
how developers can set the own global gitignore.
Signed-off-by: Bradley M. Kuhn <bkuhn@ebb.org> Signed-off-by: Dan Scott <dan@coffeecode.net>
If you had relatively technical users composing searches with
QueryParser syntax, or if they were just typing ampersands for any
other reason, AutoSuggest would behave as if the ampersand marked the end
of user input.
This is fixed by applying the correct URI-encoding function for the
situation.
To be clear, QueryParser syntax does not actually affect suggestions;
such syntax is ignored. AutoSuggest is not search.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Scott <dan@coffeecode.net>
lp996776: Patch to fix the response if no configured status is detected.
SIP response messages that use circulation_status where defaulting to just 1
rather than 01 if the status was not detected. Since SIP needs a 2 character
response, this was causing issues in some 3rd party devices. Added quoting
around the 01 to force the 2 characters.
Signed-off-by: Steven Callender <stevecallender@esilibrary.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
This causes bad interactions between patron windows and normal catalog
windows. Examples:
Load a patron, load place hold catalog in patron window. Future loads of
non-patron catalogs will default to this patron.
Load Patron A from written note, and open Place Hold catalog. Start
searching for the item Patron A wants.
Get interupted by Patron B calling. Load Patron B, and open Place Hold
catalog. Search, place a hold for Patron B.
Return to Patron A, find item, go to place hold. Find Patron B's barcode
populated.
Instead, teach the staff javascript, that already knows how to load hold
preferences, how to grab the barcode from xulG. This barcode should be
specific to the patron window the catalog is embedded in, and won't 'leak'
to other catalog interfaces.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Scott [Tue, 8 May 2012 16:52:02 +0000 (12:52 -0400)]
Roll back libjs version to 1.7.0
The install version of libjs (Spidermonkey) had been bumped to the
latest, 1.8.5, but it turned out that the tests for that had probably
been run on a system that had an old version of libjs source and/or
installed headers/libraries in place, as building libjs 1.8.5 is a
different beast entirely (different directory structure, etc).
In addition, there are several bugs along the lines of
https://rt.cpan.org/Public/Bug/Display.html?id=75058 that strongly
suggest that libjs-1.8.5 is not compatible with the
JavaScript::SpiderMonkey 0.21 Perl module.
Therefore, roll back to the tried-and-true libjs 1.7.0.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
James Fournie [Mon, 7 May 2012 17:57:30 +0000 (10:57 -0700)]
Upgrade 0704 was missing from the 2.1-2.2 upgrade script.
That upgrade added a parameter to search.query_parser_fts, without it,
Evergreen passes 11 parameters to the database but the searches fail because
there's only a 10 parameter function in the database.
Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Scott [Fri, 4 May 2012 17:55:55 +0000 (13:55 -0400)]
Fix typo in TPAC noticed by Warren Layton
Expiration needs to be spelled correctly; Warren Layton pointed out the
typo while working on a translation of the derived tpac.pot file. Many
thanks, Warren!
Dan Scott [Mon, 9 Apr 2012 20:23:08 +0000 (16:23 -0400)]
Prereqs: Remove references to CentOS / RHEL
The prereqs were focused on the 5.x series for CentOS and RHEL, which is
hella-out-of-date and never really worked anyway. Get rid of the noise
to focus on the signal.
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Wells [Wed, 25 Apr 2012 19:56:20 +0000 (15:56 -0400)]
Allow subscriptions at org units without volumes
Subscriptions are sometimes owned at the consortium or system
level, so forcing can_have_vols() to be true was incorrect.
This commit removes those checks. In addition, we also remove
some dead code and make the subscription org unit selector
consistent with the distribution org unit selector.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Jason Etheridge [Wed, 2 May 2012 19:23:06 +0000 (15:23 -0400)]
Address date sorting in Item Status and Copy Buckets interfaces, too
> The sort_value function for the date columns being used in those
> interfaces had no error protection, and were returning empty strings
> upon failure.
Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Scott [Tue, 1 May 2012 06:36:11 +0000 (02:36 -0400)]
dblatex hates files with multiple periods
Running the PDF transform was generating errors from dblatex complaining
about unknown file extensions like ".50_Import1.jpg"; this was because
there were two periods in the file name. Easily fixed by renaming the
files, and I removed the useless ALT text from the image attributes in
the same pass.
Dan Scott [Tue, 1 May 2012 06:29:28 +0000 (02:29 -0400)]
Update Release Notes and Installation documents to match code
We need to keep the release notes and installation instructions in sync
with the code versions.
To make our lives easier, use the "leveloffset" AsciiDoc macro so that
we don't have to push all of the heading indicators in the
single-sourced documents down one level manually.
Dan Scott [Tue, 1 May 2012 05:52:56 +0000 (01:52 -0400)]
Release notes: clean up and introduce TPAC
General clean-up of the release notes for consistency and to support
PDF output:
* Reformat line-widths to 80 characters or less
* Mark interface window and element names as bold
* Fix up some formatting glitches and headers
* Make the "Documentation is available..." note standard & separated
by one line; I suspect we will want to modify this globally, so it
will be easier if it is consistent.
Also, give a brief introduction to the TPAC and mention the forthcoming
JSPAC deprecation in the next feature release.
Dan Scott [Mon, 30 Apr 2012 20:02:21 +0000 (16:02 -0400)]
Replace the questionable PDF icon with a CC-BY-SA icon
The Adobe PDF icon policy at http://www.adobe.com/misc/linking.html
states that the icon may only be used with PDF documents created by an
Adobe Acrobat product. The DIG PDF files are not produced in this
manner.
Therefore, replace the current icon with a GIF derived from the CC BY-SA
Dropline Etiquette GNOME icons by Silvestre Herrerra
<silvestre.herrera@gmail.com>. Downloaded from
http://art.gnome.org/download/themes/icon/1049/ICON-DroplineEtiquette.tar.bz2
To comply with the "BY" part of BY-SA, the new GIF includes a comment
that clearly states the provenance of the icon.
Bill Erickson [Wed, 21 Mar 2012 20:33:39 +0000 (16:33 -0400)]
Vandelay match set permission additions
Allow retrieve access for match points with the VIEW_IMPORT_MATCH_SET
permission (in addition to ADMIN_IMPORT_MATCH_SET).
Adds 2 new permissions to the database:
ADMIN_IMPORT_MATCH_SET
VIEW_IMPORT_MATCH_SET
From Jason Stephenson resolving conflicts:
> Conflicts:
>
> Open-ILS/src/sql/Pg/950.data.seed-values.sql
>
> I had to change the ids of the new permissions because another branch
> had used one of the ids since this branch was last rebased. I also edited
> the ids in the upgrade script to match what is in 950.data.seed-values.sql.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
projects / working / Evergreen.git / log