The new string "Are you sure you want to cancel the hold(s)?"
has been added as the following variable,
staff.hold_list.cancel_hold_dialog.confirmation.
The string also needs to be translated to all supported languages.
Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Steven Callender [Fri, 15 Jun 2012 17:27:33 +0000 (13:27 -0400)]
Avoid problems when auth recs are missing the 901c
Fixed the authority.normalize_heading function to better handle
INT's when there is no 901 present. Now we look for the best-fit
control set instead of throwing a db-level error.
Signed-off-by: Steven Callender <stevecallender@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Best hold selection: fix a checkin-busting bug affecting Holds-go-home
Several subselects within SQL auxiliary queries can possibly return
multiple rows in situations where outer code requires that they return
only one or zero rows.
When you're using a best-hold order that includes htime or shtime, (such
as those with Holds-go-home) and if there are mutiple circs or transits
related to the copy in hand with certain characteristics, you can
trigger this bug. The end user at the staff client gets one of those
nasty "Network error" dialogs, and the error in the SQL logs is:
> ERROR: more than one row returned by a subquery used as an expression
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Fix bug in hold targeter introduced with Calculated Proximity Adjustments
The Calculated Proximity Adjustments feature introduced a bug in the
hold targeter where holds would not discount those copies from the
potentials list that aren't in either the Available or Reshelving
status.
This commit should restore the earlier, correct behavior.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Fri, 29 Mar 2013 17:36:17 +0000 (13:36 -0400)]
LP 1126545 repair staff 'return to results' tpac link
Strip the extra "/" from the URL created by the "return to results"
button in the staff client TPAC view. Havin the extra "/" in place
prevents the next/previous links from functioning.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Dan Wells [Fri, 15 Mar 2013 18:47:53 +0000 (14:47 -0400)]
Allow access to public hold notes via hold "blob"
If a hold note is marked as "public", it seems reasonable that it
should be visible to anyone who can see that hold, regardless of
who created the note.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>
Dan Wells [Fri, 15 Mar 2013 18:42:24 +0000 (14:42 -0400)]
Fix reversed logic for hold "blob" notes
Hold notes (at least at the data level) allow for both staff and
"private" notes to be attached. This code intended to show "private"
notes to the hold owner and staff notes to staff, but had the logic
reversed.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>
Bill Erickson [Mon, 25 Mar 2013 19:19:14 +0000 (15:19 -0400)]
tpac : honor page locale in record detail copy grid
The query used to load the record detail copy grid now uses the same
locale value set as the default for all cstore-editor calls. This
solves the issue where copy location names, statuses, etc. are not
properly translated.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi> Signed-off-by: Mike Rylander <mrylander@gmail.com>
1) UI change - pre-select highest OU where user can edit
There's a dropdown in the org unit proximity adjustment interface that
affects the scope of what you can see in the table below. Before, that
dropdown would be set to the user's home UO (say, BR1 in the example org
tree). But you might have the permission to make changes everywhere, so
you add a proximity adjustment that affects BR3 in some way. As soon as
you'd refresh the interface, your new proximity adjustment would not be
visible, because your scope selector would default to BR1.
So now the dropdown defaults to the first context where you have the
permission, which in all but eccentric setups should be the highest OU
(and therefore broadest scope) where you have the permission.
This could also improve other interfaces in the future. Anything that
invokes openils.User.buildPermOrgSelector() can pass -1 as the third
parameter to get the new behavior.
2) Change UNIQUE index at DB layer.
This prevents the creation of rows that would give the hold targeter
conflicting directives.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Fri, 22 Mar 2013 14:40:59 +0000 (10:40 -0400)]
More authority fixed-field cleanup
Even with the efforts by many to add and harmonize the authority fixed-field
setup, and maintain functionality, there were some missing bits. This commit
should take care of those by realigning the remaining field names and allwowing
those fields to be saved properly.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
The circ_modifier and billing_types lists in the
open-ils.circ section of opensrf.xml are no longer
used. This commit removes them from the opensrf.xml
example config. It also removes the method
open-ils.circ.billing_type.retrieve.all, which has
not be used by any other code once in-DB billing types
were introduced.
Any external clients that used the method that was
removed should instead use
open-ils.circ.billing_type.ranged.retrieve.all.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Changed the way authority tags were being pulled to specifically use an aggregate array.
There appears to have been a change in postgres at some point between 9.0 and 9.1
to the aggregate method. Because of this, postgres was not returning the proper
results when pulling tags for authorities. This change will force postgres to do
a proper aggregate array call and return the correct results.
Signed-off-by: Steven Callender <stevecallender@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Bill Erickson [Fri, 3 Aug 2012 19:08:51 +0000 (15:08 -0400)]
SIP re-login fetches correct auth session
After a login session expires and the SIP server logs in again to
acquire a new authtoken, be sure to use the new authtoken when fetching
the new session object. Otherwise, the login_session is left undef and
you may see errors like this when checking in items:
Can't call method "ws_ou" on an undefined value at
/usr/local/share/perl/5.10.1/OpenILS/SIP/Transaction/Checkin.pm line 77.
Incidentally, the checkin code is the only code that references
$sip_handler->{login_session}. And the problem listed above only occurs
when the login session expires just prior to a checkin call. In any
other scenario, the login_session would ultimately get repaired.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Melissa Lefebvre [Mon, 25 Feb 2013 15:42:15 +0000 (10:42 -0500)]
TPAC - Account preferences headings
Currently, all tabs in My Account show a heading once clicked(Items Checked
Out shows "Current Items Checked Out" heading when clicked); however,
under the Account Preferences for a change of username, password, and
email address no headings appear.
Div classes were added to update_password.tt2, update_username.tt2, and
update_email.tt2 for consistancy in the My Account area.
Jeff Godin [Thu, 14 Mar 2013 18:15:28 +0000 (14:15 -0400)]
Fix detection of empty Syndetics AC data elements
Due to a change in how the vendor responds to requests for data
elements which are not present for a requested title, we need to
change how we detect "empty" data elements in the "data_exists"
function.
First, we check for the new "No Data Available" title element, then
we check for the previously-used value of "error".
This change resolves the symptom where the catalog would display
tabs for "Author Notes", "Excerpt", "Table of Contents", on every
record in the catalog, even when clicking each tab would show that
the content was not present / available.
Signed-off-by: Jeff Godin <jgodin@tadl.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Ben Shum [Fri, 22 Feb 2013 05:46:17 +0000 (00:46 -0500)]
LP1054322 - libparent-perl not needed for Ubuntu Precise
The newer version of Perl 5.14 which comes with Ubuntu Precise already
contains the contents of libparent-perl, which is now an obsolete package.
Remove this dependency from the extra debs installed for Debian and Ubuntu
but then add to the extras for Debian Squeeze and create a new extras just
for Ubuntu Lucid so that it continues to be installed on those systems and
not on Ubuntu Precise.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Ben Shum [Thu, 14 Mar 2013 21:40:04 +0000 (17:40 -0400)]
LP1103068 - Show titles and authors for pre-cat items
As noted in LP1103068, TPAC does not currently show anything when viewing a
pre-cataloged item in the my account summary of items checked out.
If the call number is -1 (pre-cat), then show the dummy title and dummy author
values, which fields are hopefully relevant as long as staff were good to put
something meaningful in those during creation of the pre-cat.
Also, wrap the title in a check for attrs.title.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Dan Scott [Thu, 14 Mar 2013 21:52:09 +0000 (17:52 -0400)]
TPAC: Address severe accessibility issues
Using the Chrome Accessibility Dev Tools extension to run accessibility
audits against the TPAC turned up some "severe" issues, such as input
widgets lacking labels. In most cases the text for the labels was
present, but it needed to be associated with a <label> element. In some
other cases, it was easier to use the aria-label attribute to give the
widget an accessible label. Finally, we can use the placeholder
attribute where warranted as an accessible label.
These changes address the first set of accessibility issues I came
across via the audits and could address quickly.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Ben Shum [Fri, 22 Feb 2013 05:03:58 +0000 (00:03 -0500)]
Enable dojo in TPAC if using newer Novelist API
Enable dojo if the apache variable for Novelist URL is set. This avoids
issues such as needing to have dojo enabled via either AutoSuggest or
Google Books preview, which may not be enabled by every TPAC.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Restore previous behavior to the maintain_901() trigger
function so that bib records that are loaded without
explicitly setting the TCN have it set to the bib ID
when the cat.bib.use_id_for_tcn global flag is set, rather
than 'AUTOGENERATED-xxx'.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Add a "Show holds on bibs" option from item checkin, item status, and patron
hold interfaces. This makes it quicker to flip to viewing who else has holds
on an item instead of having to click an option to see the bib, then clicking
in the menus for view holds. One less click.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Serials: printing routing slips fails with Javascript error
The symptom (an error in the Javascript console about dijit.form.Button
and an empty page for routing slips that you try to print at batch
recieve) may or may not be affected by whether you're in a production
environment with the pre-built dojo 1.3.3 package installed or a
development environment without it.
This simple fix makes the problem go away in any case.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Mike Rylander [Thu, 28 Feb 2013 18:28:20 +0000 (13:28 -0500)]
Observed speed increases through judicious indexing
These indexes drove high-cost queries down into the noise
at several sites. They are more applicable for larger
installations, where "larger" can be defined as either "lots
of data in the db" or "has used Evergreen for a long time".
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Wed, 1 Aug 2012 15:12:36 +0000 (11:12 -0400)]
TPAC: Add config options to hide phone / user prefs
Libraries using centralized authentication (such as LDAP via
open-ils.auth_proxy) will not want to allow users to change their
passwords or email addresses.
In addition, many libraries do not want to deal with phone
notifications.
This commit adds preferences to config.tt2 that hide these options from
the user.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Wells [Fri, 8 Mar 2013 22:55:52 +0000 (17:55 -0500)]
Move serials interfaces closer together
Back in (I believe) 2.2, we brought the dijit issuance editor into the
serial control interface with two goals: having less code in more places,
and easing the transition to an eventual unified interface which would
likely be more widget-based.
That experiment was well received, so this commit takes things a large
step further in that direction. Basically, we are embedding the
alternate subscription editing interface into the serial control
scaffolding, which ultimately amounts to giving you some of the
benefits of both. You get the more modern and maintainable code from
the alternate interfaces, but keep the context-awareness and familiar
navigation of the non-alternate serial control.
That said, this change is not meant to be the last word in serials,
but rather a way to at least come closer together while we still
continue to learn what structures provide the best experience.
Finally, some feature additions were necessary to the alternate serials
code in order to make this change as seamless as possible. In some
cases, the new feature only works in the embedded version, but a new
'context' variable makes that simple to adjust as we move forward.
Changes include:
- note editors on subscriptions and distributions
- labeled dropdown for distribution summary options
- and legacy record entry linkages
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Fri, 8 Mar 2013 18:23:06 +0000 (13:23 -0500)]
Distribution formula fund rollover setting
Adds an org unit setting (acq.fund.rollover_distrib_forms) which
controls whether the fund value on distribution formulae is updated to
use the newly created fund during fiscal year rollover.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
This UI enhancement uses the API method in the previous commit to allow
users to apply changes to the copies on a selected set of line items.
When successful, the updater just reloads the whole page, but it can be
made smarter later, i.e. by refreshing only the affected line items rows
in the display.
The UI only appears on POs for now, and is partly disabled if the PO has
already been activated. It could appear elsewhere if it seems sensible
to put it elsewhere.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
This new method gives you a server-side way to make batch updates to
all the copies of a target set of lineitems. Permissions are checked
for each target object. The method returns OpenILS::Event instances
for all kinds of permission problems and other errors. IDs of lineitems
affected are streamed back to the client in the successful case.
This also expands distribution formulae to contain more (optional)
fields so that they can be used to make updates to copies on all the
same fields that you can just specify individually. IDL and interface
changes to support the new fields are included.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Bill Erickson [Mon, 4 Mar 2013 15:48:12 +0000 (10:48 -0500)]
Import bib trash fields : XUL Z39.50 UI
In the Z39.50 staff search interface, staff may now select from optional
MARC trash field groups (within the org unit range) to be applied to
incoming Z39.50 records.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Fri, 1 Mar 2013 19:55:15 +0000 (14:55 -0500)]
Import bib trash field Vandelay UI
During bib record import, if any optional MARC trash field groups exist
(in the org unit range), a new multi-select option is displayed allowing
the user to specify which trash field groups should be applied to the
current record import/merge/overlay.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Mon, 18 Feb 2013 16:33:59 +0000 (11:33 -0500)]
Strip configured fields during import/overlay
Records coming in from the staff client may contain junk tags, and
we have a mechanism (not yet exposed) for defining such junk tags
in an inheritable way. This applies said junk-tag removal based on
said configuration. The configuration interface is yet to come.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Wed, 27 Feb 2013 20:32:56 +0000 (15:32 -0500)]
MARC import tag stripping : SQL / IDL
* Adds a new table vandelay.import_bib_trash_group for grouping "trash"
fields. Groups may be optional or "always_apply". Always-apply groups
contain MARC fields which are to be unconditionally removed during
import.
* Updates vandelay.import_bib_trash_fields for putting them into groups.
* IDL changes to accommodate the above
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Acq: two tweaks to UI improvements in previous commit
Suggested by Bill Erickson:
* Prevent interface locking up with the Mark Received/Unreceived
actions when nothing is selected
* Make new lineitem batch receive/rollback API methods actually stream
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Several usability improvements throughout Acq, including:
* A logical re-ordering of the main "actions" dropdown in several Acq
interfaces (selection lists, purchase orders, acq search results, MARC
federated search interface, etc).
* "Actions" dropdown also has its options enabled/disabled depending what
interface you're seeing it through, and redundant entries are
removed from the per-lineitem secondary dropdown.
* Add to Purchase Order dialog added to "actions" dropdown
* Middle layer support for adding many line items to a PO at once
* Create/add to Purchase Order operations can no longer steal line
items from current POs
* Create invoice from / link to invoice now work in new tab
* Receive/unreceive now by selected lineitem instead of whole PO
* Claim policy application works more simply now
* Invoices interface auto-populates "# Invoiced" column with number of
invoicable copies, and copies the "billed cost" column to the
"amount paid" column if the latter doesn't have anything in it yet.
* You can now only cancel specific lineitems when they're actually on
a PO and have the state of 'on-order'.
* Avoid double-activation of POs at UI level
* Disable invoice and cancel options for whole pending POs
* Disable zero-copy checkbox for activated POs
* Disable new misc charges (acq.invoice_item) for activated POs
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Jason Etheridge [Mon, 11 Mar 2013 19:27:30 +0000 (15:27 -0400)]
skip xulG.get_barcode if no barcode completion
For Check In and Check Out interfaces, skip the xulG.get_barcode call if there
are no active Barcode Completion entries (under Admin->Local Administration->
Barcode Completion) at the time of the staff client login sequence.
However, for Check Out, an exception is made if the "Load patron from Checkout"
library setting is in effect, since that functionality depends on
xulG.get_barcode.
Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Bill Erickson [Wed, 16 Jan 2013 22:13:50 +0000 (17:13 -0500)]
ACQ PO inline details view
Adds a new 'expand' lineitem option which produces a table inline below
the lineitem title, author, etc. containing copy information. Each copy
linked to the lineitem is represented as a row in the table with owning
lib, copy location, fund, barcode, callnumber, and notes. An option to
expand/collapse all is also present.
Release notes included.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Fri, 18 Jan 2013 17:27:28 +0000 (12:27 -0500)]
ACQ order identifier UI
In the lineitem table show the set of possible order identifier types
and values. The user may enter new values when necessary. When changes
are applied, the selected order identifier is applied to each lineitem.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Mon, 21 Jan 2013 19:51:48 +0000 (14:51 -0500)]
ACQ API for setting the lineitem order identifier
API: open-ils.acq.lineitem.order_identifier.set
Given an existing lineitem_attr (typically a marc_attr), this will
create a matching local_attr to store the name and value and mark
the attr as the order_ident. Any existing local_attr marked as
order_ident is removed. When necessary, the value (isbn, issn, upc) is
added to the record first to create the marc attribute. If the lineitem
is linked to a bib record and the user has the correct permissions, any
new data will also be applied to the bib record.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Tue, 22 Jan 2013 19:35:22 +0000 (14:35 -0500)]
Extract multiple like values from lineitem
Make it possible to extract multiple values with the same MARC tag
during acquisitions lineitem ingest. Prior to this, only one (e.g.)
ISBN for each record would be extracted as a lineitem attribute.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Wed, 27 Feb 2013 18:08:07 +0000 (13:08 -0500)]
Z39.50 stored credentials
* New non-IDL-accessible DB table for storing credentials
* API for applying credentials
* Additions to the Z39.50 configuration UI for applying and clearing
credentials.
* At Z39.50 search time, if no creds are provided by the caller, but
creds are configured in the database, creds from the DB are used to
make the Z39 search call.
* Release notes included
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
projects / working / Evergreen.git / log