scottmk [Thu, 25 Mar 2010 16:03:48 +0000 (16:03 +0000)]
Replace acq.lineitem.claim_interval and acq.provider.default_claim_interval
with foreign keys pointing to the new acq.claim_policy table.
M Open-ILS/src/sql/Pg/200.schema.acq.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0211.schema.acq.replace-claim-interval.sql
M Open-ILS/examples/fm_IDL.xml
scottmk [Thu, 25 Mar 2010 13:31:06 +0000 (13:31 +0000)]
Create two tables in acq schema: claim_policy and claim_policy_action.
M Open-ILS/src/sql/Pg/200.schema.acq.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0210.schema.acq.claim-policy.sql
M Open-ILS/examples/fm_IDL.xml
erickson [Thu, 25 Mar 2010 13:19:57 +0000 (13:19 +0000)]
Minor refactors for clarity:
~ avoid name confusion between $holds and $holds[0] (@holds)
~ more consistent style (return X if X)
~ factor out common case from all conditional blocks
scottmk [Thu, 25 Mar 2010 05:43:48 +0000 (05:43 +0000)]
1. In order to avoid repeated calls to the authentication server, cache
the login information locally, as part of the userData stored by the
applicaton session. This caching speeds up some queries by about 20%.
Actual results will of course vary according to circumstance.
2. Don't include the database password in log messages.
3. Tinkered a bit with white space and comments here and there.
senator [Wed, 24 Mar 2010 21:17:58 +0000 (21:17 +0000)]
Acq: limit "Fund" dropdowns in LID table to active funds
A dropdown will still include one inactive fund if the dropdown belongs to a
copy row whose fund has become inactive (but presumably wasn't originally
inactive).
scottmk [Wed, 24 Mar 2010 15:41:40 +0000 (15:41 +0000)]
Clear up some muddlement in the design of query.from_relation.
The table_alias column should be nullable, but it shouldn't be required
to be null for a core table.
M Open-ILS/src/sql/Pg/002.schema.config.sql
M Open-ILS/src/sql/Pg/008.schema.query.sql
A Open-ILS/src/sql/Pg/upgrade/0207.schema.query.nullable-table-alias.sql
senator [Tue, 23 Mar 2010 16:00:26 +0000 (16:00 +0000)]
Acq: optionally mark POs as prepayment_required; show/confirm it where needed
The PO creation dialog box now has a checkbox for "prepayment required." This
will be checked or unchecked automatically when choosing a vendor from the
above dropdown based on whether that vendor's "prepayment required" value is
true. The user can override the default value for a vendor, but will face a
confirmation dialog about it.
The PO viewing interface shows whether or not a PO is marked "prepayment
required," and if it is, when the user wishes to activate the PO, there will
be another confirmation dialog reminding the user to deal with payment.
scottmk [Tue, 23 Mar 2010 13:47:06 +0000 (13:47 +0000)]
Tweak to reflect a better understanding of oilsUtilsQuickReq().
If the latter calls a method that returns no result, it returns
a JSON_NULL, not a NULL.
(The previous version worked correctly, but kinda sorta by accident.)
dbs [Mon, 22 Mar 2010 22:25:41 +0000 (22:25 +0000)]
Forward-port r15933 from rel_1_6_0: Default to "true" for email notification of holds in example configuration file
Fix minor typos in HoldNotify.pm log messages
miker [Mon, 22 Mar 2010 03:48:51 +0000 (03:48 +0000)]
provide valid xml for the magical -1 precat record, so that we avoid xml errors; add a force-reingest flag to allow reingest when the MARC has not changed
scottmk [Thu, 18 Mar 2010 20:12:40 +0000 (20:12 +0000)]
Performance tweak to oilsAuthComplete().
Formerly, if authenticating a barcode rather tnan a user name, we would
look up the same barcode twice in actor.card: first to get the user id
for a lookup in actor.usr, and again to determine whether the card was
active. Now we use a single lookup for both purposes. In other respects
the validation logic is unchanged.
The oilsAuthCheckCard() function, which performed the second lookup, has
been eliminated.
The oilsUtilsFetchUserByBarcode() function, in oils_utils.c, is no
longer called from anywhere and may be eliminated.
Also added a doxygen-style comment block to document oilsUtilsFetchUserByBarcode(),
and tweaked few comments in the body of the function.
erickson [Thu, 18 Mar 2010 00:04:07 +0000 (00:04 +0000)]
added option to import records by record list in addition to queue-level imports; eval doesn't like being exited via 'last', rearranged sysread loop to accommodate; changed merge param to merge-profile
erickson [Thu, 18 Mar 2010 00:04:02 +0000 (00:04 +0000)]
Make GetOpts::Long and Cronscript get along
So the old Cronscript approach was to have variables declared with
the default values assigned and pass a hash of keys => var_ref, where
the var_ref's pointed to the variables. This didn't work because of
Cronscript trying to build the clean hashes and incorporate structure
into the object.
So instead now we rely on the MyGetOptions return
value (hashref or hash), essentially the opts_clean hash. And we
populate the local variables afterwards. The default values are passed
in the hash now. This works.
scottmk [Wed, 17 Mar 2010 20:42:33 +0000 (20:42 +0000)]
Tweaked oilsAuthVerifyPassword(), mostly for clarity:
1. Addad a doxygen-style comment block to document it, plus several comments
in the body of the function.
2. A slight rearrangement: get the password from the user object after getting
the seed from memcache, instead of before. That way if the memcache call
fails we don't need to free the copy of the user object's password.
3. Moved the declaration of ret (the return code) closer to its first use.
4. Plugged a potential (albeit improbable) memory leak in the case of an
early exit.
Also: several minor tweaks to white space and comments elsewhere.
scottmk [Wed, 17 Mar 2010 13:29:31 +0000 (13:29 +0000)]
Add four tables in acq schema: claim, claim_type, claim_event, claim_event_type.
M Open-ILS/src/sql/Pg/999.functions.global.sql
M Open-ILS/src/sql/Pg/200.schema.acq.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0198.schema.acq.claim.sql
M Open-ILS/examples/fm_IDL.xml
phasefx [Tue, 16 Mar 2010 20:03:51 +0000 (20:03 +0000)]
make batch renewal use synchronous calls again to better handle exceptions. The original push for synchronous calls here was for performance, so we may need to revisit
scottmk [Tue, 16 Mar 2010 15:54:43 +0000 (15:54 +0000)]
Added doxygen-style comments to several functions.
Also, in oilsAuthInit():
1. Moved the declarations of several variables closer to their first uses.
2. Instead of using va_list_to_string() to build a seed, exploit the fact that
md5sum() builds its input using printf-style formatting. This change eliminates
a malloc(), a free(), and two calls to vsprintf().
miker [Tue, 16 Mar 2010 14:16:52 +0000 (14:16 +0000)]
Patch from Galen Charlton: removes empty controlfield elements, which can be produced in a couple different ways during the ingest of slightly invalid MARC records
scottmk [Tue, 16 Mar 2010 01:14:16 +0000 (01:14 +0000)]
Support multiple languages in the lookup for event descriptions.
Capture the current locale, which reflects the message most
recently received, and confine the lookup to messages in that
language. If you don't find a description, and the language is
different from the default language (hard-coded as "en-US"),
try again with the default language.
senator [Mon, 15 Mar 2010 15:45:02 +0000 (15:45 +0000)]
Acq: for showing related lineitems, do the right thing w/ null bib rec
Also, flesh_cancel_reason employed in more of the cases where we're retrieving
lineitems to build an li_table, and li_table doesn't fail so hard when it
doesn't have a fleshed cancel_reason.
scottmk [Mon, 15 Mar 2010 01:54:50 +0000 (01:54 +0000)]
Tidied up whitespace; added comments; removed comments from the header
so that they won't override the new doxygen-style comments in the
implementation file.
M Open-ILS/include/openils/oils_event.h
M Open-ILS/src/c-apps/oils_event.c
projects / working / Evergreen.git / log