]> git.evergreen-ils.org Git - working/Evergreen.git/log
working/Evergreen.git
13 years agoApache2::Const::DECLINED leads to ugly error dialogues. I'm OK, you're OK.
dbs [Thu, 3 Jun 2010 04:05:39 +0000 (04:05 +0000)]
Apache2::Const::DECLINED leads to ugly error dialogues. I'm OK, you're OK.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16571 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years ago< is not >; get our time-to-live threshold comparison correct
dbs [Thu, 3 Jun 2010 03:39:16 +0000 (03:39 +0000)]
< is not >; get our time-to-live threshold comparison correct

Also add a useful log entry to differentiate this not-active-request reason from the others

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16570 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoSetting apache->status() caused 500 server errors for password reset requests
dbs [Thu, 3 Jun 2010 03:15:38 +0000 (03:15 +0000)]
Setting apache->status() caused 500 server errors for password reset requests

Don't do that.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16569 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agopassword reset URI needs a trailing slash, and this enables the aupr entry to be...
dbs [Thu, 3 Jun 2010 02:52:10 +0000 (02:52 +0000)]
password reset URI needs a trailing slash, and this enables the aupr entry to be created, but:

  * Server is now returning a 500 instead of 200, which causes an error dialogue
    to be displayed instead of "success!" and JavaScript errors to cascade
  * We don't want to hard-code the en-US locale; need to pull that from current locale

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16568 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agos/perl/javascript/
phasefx [Wed, 2 Jun 2010 22:46:02 +0000 (22:46 +0000)]
s/perl/javascript/

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16567 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agofix logic error that could result in partial list of available libs for workstation...
phasefx [Wed, 2 Jun 2010 22:39:16 +0000 (22:39 +0000)]
fix logic error that could result in partial list of available libs for workstation registration

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16566 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoUndouble these elements of password-reset that somehow doubled up during the forward...
dbs [Wed, 2 Jun 2010 21:36:34 +0000 (21:36 +0000)]
Undouble these elements of password-reset that somehow doubled up during the forward-porting from rel_1_6

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16565 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agosome defensive programming
phasefx [Wed, 2 Jun 2010 21:34:55 +0000 (21:34 +0000)]
some defensive programming

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16564 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoReplace most of the serial schema with a different set of tables. Only
scottmk [Wed, 2 Jun 2010 19:24:14 +0000 (19:24 +0000)]
Replace most of the serial schema with a different set of tables.  Only
the serial.record_entry table remains unscathed.

In addition: a new table asset.copy_template.

M    Open-ILS/src/sql/Pg/002.schema.config.sql
M    Open-ILS/src/sql/Pg/040.schema.asset.sql
A    Open-ILS/src/sql/Pg/upgrade/0288.schema.serial-overhaul.sql
M    Open-ILS/src/sql/Pg/210.schema.serials.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16563 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agosome more API documentation for these password reset request methods
phasefx [Wed, 2 Jun 2010 18:46:24 +0000 (18:46 +0000)]
some more API documentation for these password reset request methods

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16562 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadding more non-auto Identifier specifiers
miker [Wed, 2 Jun 2010 18:02:06 +0000 (18:02 +0000)]
adding more non-auto Identifier specifiers

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16560 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agouse dojo.query instead of getElementsByTagName ... IE--
miker [Wed, 2 Jun 2010 17:42:40 +0000 (17:42 +0000)]
use dojo.query instead of getElementsByTagName ... IE--

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16559 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadd class/instance methods for checking required-ness and validity of an object field...
miker [Wed, 2 Jun 2010 15:11:52 +0000 (15:11 +0000)]
add class/instance methods for checking required-ness and validity of an object field in JS FM implementation

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16557 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadd class/instance methods for checking required-ness and validity of an object field...
miker [Wed, 2 Jun 2010 14:55:23 +0000 (14:55 +0000)]
add class/instance methods for checking required-ness and validity of an object field in perl FM implementation; also fixing typo

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16556 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoget rid of search.staged_fts() and supporting functions -- entirely replaced by searc...
miker [Wed, 2 Jun 2010 14:38:58 +0000 (14:38 +0000)]
get rid of search.staged_fts() and supporting functions -- entirely replaced by search.query_parser_fts(); deprecating only, no upgrade script required

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16555 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agomade overly restrictive example validation regexp more generic -- just require at...
miker [Wed, 2 Jun 2010 12:48:40 +0000 (12:48 +0000)]
made overly restrictive example validation regexp more generic -- just require at least one character, instead of all upper-case ASCII

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16554 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadd required IDL flag and validation regexp support
miker [Wed, 2 Jun 2010 02:43:32 +0000 (02:43 +0000)]
add required IDL flag and validation regexp support

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16553 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoMake in-db hold checking consistent with circulation when it comes to
senator [Tue, 1 Jun 2010 21:04:39 +0000 (21:04 +0000)]
Make in-db hold checking consistent with circulation when it comes to
returning events with fail_part set.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16552 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoMove credit card processing ML code into the circ module, removing API method
senator [Tue, 1 Jun 2010 20:35:21 +0000 (20:35 +0000)]
Move credit card processing ML code into the circ module, removing API method
for direct payment processing.  (Using open-ils.circ.money.payment with auth
can invoke CC processing).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16550 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoForward port r16547 from rel_1_6_0: fix regression in date formatting for non-due...
dbs [Tue, 1 Jun 2010 19:19:08 +0000 (19:19 +0000)]
Forward port r16547 from rel_1_6_0: fix regression in date formatting for non-due dates

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16549 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agorid ourself of some namespace prefixes because IE is too braindead to understand...
miker [Tue, 1 Jun 2010 19:02:19 +0000 (19:02 +0000)]
rid ourself of some namespace prefixes because IE is too braindead to understand them

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16546 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoRemove accidentally committed OPAC CC payment test code.
senator [Tue, 1 Jun 2010 17:38:21 +0000 (17:38 +0000)]
Remove accidentally committed OPAC CC payment test code.

Only the changes in payment.js and selfcheck.js were supposed to be commited
in 16542.  The opac changes themselves were only a rough test and aren't
seaworthy.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16545 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoin the SIP server plugin, don't connect and start a transaction by default with every...
erickson [Tue, 1 Jun 2010 17:21:31 +0000 (17:21 +0000)]
in the SIP server plugin, don't connect and start a transaction by default with every cstore handle.  only connect/begin when necessary.  also, making use of new CStoreEditor::init() call for setting up the editor environment when initial load was done before the IDL was available.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16544 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoIn OPAC CC payment, fall back on alert()ing events if onPaymentSubmit undef
senator [Tue, 1 Jun 2010 16:10:36 +0000 (16:10 +0000)]
In OPAC CC payment, fall back on alert()ing events if onPaymentSubmit undef

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16543 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoIncorporate CC payment interface into OPAC fines page (rough)
senator [Tue, 1 Jun 2010 15:59:25 +0000 (15:59 +0000)]
Incorporate CC payment interface into OPAC fines page (rough)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16542 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAdd support for GROUP BY.
scottmk [Tue, 1 Jun 2010 15:06:20 +0000 (15:06 +0000)]
Add support for GROUP BY.

M    Open-ILS/include/openils/oils_buildq.h
M    Open-ILS/src/c-apps/oils_storedq.c
M    Open-ILS/src/c-apps/buildSQL.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16541 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadd usr_setting_type of history.hold.retention_start for setting "opt-in" date of...
miker [Tue, 1 Jun 2010 14:48:11 +0000 (14:48 +0000)]
add usr_setting_type of history.hold.retention_start for setting "opt-in" date of holds retention

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16540 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agosubstream for better performance with large datasets
phasefx [Tue, 1 Jun 2010 06:14:27 +0000 (06:14 +0000)]
substream for better performance with large datasets

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16539 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAdd support for BETWEEN conditions.
scottmk [Mon, 31 May 2010 19:45:26 +0000 (19:45 +0000)]
Add support for BETWEEN conditions.

M    Open-ILS/src/c-apps/oils_storedq.c
M    Open-ILS/src/c-apps/buildSQL.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16538 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years ago1. Add support for function calls. Note that certain functions have
scottmk [Mon, 31 May 2010 03:03:03 +0000 (03:03 +0000)]
1. Add support for function calls.  Note that certain functions have
peculiar calling syntax.  They will require special handling as exceptions,
and are not yet supported.

2. Add a bit of sanity checking for numeric and string literal expressions.

3. Eliminate the function_id member of Expression.

M    Open-ILS/include/openils/oils_buildq.h
M    Open-ILS/src/c-apps/oils_storedq.c
M    Open-ILS/src/c-apps/buildSQL.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16537 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoFor various updatable views based on query.expression:
scottmk [Sun, 30 May 2010 03:50:47 +0000 (03:50 +0000)]
For various updatable views based on query.expression:
add COALESCE to the insert rule so that we don't always
have to specify a value for the "negate" column.

Also: eliminate a harmless but annoying duplication of
the create statements for the query.expr_xbind view.

M    Open-ILS/src/sql/Pg/002.schema.config.sql
M    Open-ILS/src/sql/Pg/008.schema.query.sql
A    Open-ILS/src/sql/Pg/upgrade/0286.schema.query-coalesce-negate.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16536 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoutilities for testing circ and ahr events
phasefx [Fri, 28 May 2010 21:35:04 +0000 (21:35 +0000)]
utilities for testing circ and ahr events

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16535 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years ago.print and .email event-firing variants of open-ils.actor.history.hold.visible and...
phasefx [Fri, 28 May 2010 21:35:04 +0000 (21:35 +0000)]
.print and .email event-firing variants of open-ils.actor.history.hold.visible and open-ils.actor.history.circ.visible

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16534 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agotemplates and methods for print/email of historical hold/circ lists
phasefx [Fri, 28 May 2010 21:35:03 +0000 (21:35 +0000)]
templates and methods for print/email of historical hold/circ lists

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16533 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadded a wait flag to create_events_for_hook() to allow for processing large sets...
erickson [Fri, 28 May 2010 19:37:32 +0000 (19:37 +0000)]
added a wait flag to create_events_for_hook() to allow for processing large sets of objects without dropping all the calls on the network at once

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16532 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAdded org_unit_setting_type auth.persistent_login_interval
scottmk [Fri, 28 May 2010 16:40:39 +0000 (16:40 +0000)]
Added org_unit_setting_type auth.persistent_login_interval

M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0284.data.persistent-login-interval.sql
M    Open-ILS/src/sql/Pg/950.data.seed-values.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16531 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadded duplicate username checking/warning
erickson [Fri, 28 May 2010 15:50:23 +0000 (15:50 +0000)]
added duplicate username checking/warning

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16530 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAPI calls to expose the circ/hold history stored procedures
erickson [Fri, 28 May 2010 14:19:21 +0000 (14:19 +0000)]
API calls to expose the circ/hold history stored procedures
moved circ chain summary creator code to apputils for sharing

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16529 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agorepaired misnamed function oils_json_to_string -> oils_json_to_text; updated funcs...
erickson [Fri, 28 May 2010 13:25:47 +0000 (13:25 +0000)]
repaired misnamed function oils_json_to_string -> oils_json_to_text; updated funcs to use the setting name provided by the seed data retention_start_date -> retention_start

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16528 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoSupport IN lists.
scottmk [Fri, 28 May 2010 03:35:32 +0000 (03:35 +0000)]
Support IN lists.

M    Open-ILS/src/c-apps/oils_storedq.c
M    Open-ILS/src/c-apps/buildSQL.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16527 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoSupport series expressions, i.e. a series of expressions
scottmk [Fri, 28 May 2010 01:46:29 +0000 (01:46 +0000)]
Support series expressions, i.e. a series of expressions
separated by operators or commas.  This construct will
be especially useful for chains of ANDs or ORs.

M    Open-ILS/include/openils/oils_buildq.h
M    Open-ILS/src/c-apps/oils_storedq.c
M    Open-ILS/src/c-apps/buildSQL.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16526 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadding function to return holds visible to the user, based on their horizon settings...
miker [Thu, 27 May 2010 20:16:33 +0000 (20:16 +0000)]
adding function to return holds visible to the user, based on their horizon settings; fixing logic reversal in circ version of same

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16525 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoedi_message fetching for POs is just for counting, use id_list instead of full object...
erickson [Thu, 27 May 2010 18:47:48 +0000 (18:47 +0000)]
edi_message fetching for POs is just for counting, use id_list instead of full object fetching

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16524 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agofunctions and settings for purging circs and user-settable circ memory horizon
miker [Thu, 27 May 2010 18:44:22 +0000 (18:44 +0000)]
functions and settings for purging circs and user-settable circ memory horizon

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16523 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agofor some added privacy, display the user's username instead of their real name in...
erickson [Thu, 27 May 2010 18:42:08 +0000 (18:42 +0000)]
for some added privacy, display the user's username instead of their real name in the self-check welcome banner.  i18n-ified

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16522 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAdd new expression type 'xser' to represent series expressions,
scottmk [Thu, 27 May 2010 16:10:50 +0000 (16:10 +0000)]
Add new expression type 'xser' to represent series expressions,
i.e. a series of expressions separated by operators, such as a
chain of ANDed conditions.

M    Open-ILS/src/sql/Pg/002.schema.config.sql
M    Open-ILS/src/sql/Pg/008.schema.query.sql
A    Open-ILS/src/sql/Pg/upgrade/0280.schema.query-xser.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16521 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadded global_flag editing UI and staff client menu entry
erickson [Thu, 27 May 2010 16:04:46 +0000 (16:04 +0000)]
added global_flag editing UI and staff client menu entry

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16519 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agorepaired bug in dojo.mixin usage for applying overrides. support for stying fields...
erickson [Thu, 27 May 2010 16:04:44 +0000 (16:04 +0000)]
repaired bug in dojo.mixin usage for applying overrides.  support for stying fields marked readOnly via override

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16518 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadded note about new direction of opt-in circ history maintenance; minor cleanup
erickson [Thu, 27 May 2010 13:18:46 +0000 (13:18 +0000)]
added note about new direction of opt-in circ history maintenance; minor cleanup

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16517 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadded Replace Barcode option into new patron reg. interface. Also added a basic...
erickson [Thu, 27 May 2010 13:18:45 +0000 (13:18 +0000)]
added Replace Barcode option into new patron reg. interface.  Also added a basic See All operation that shows all attached barcodes for a user, provides no editing capabilities

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16516 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoBug fix in verifyObjectPCRUD().
scottmk [Thu, 27 May 2010 12:38:48 +0000 (12:38 +0000)]
Bug fix in verifyObjectPCRUD().

When traversing a chain of rows according to the "jump" attribute:
if you encounter a null foreign key, just stop looking, without
issuing an exception.

M    Open-ILS/src/c-apps/oils_sql.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16515 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoMinor whitespace/syntax changes, sifted out of the previous telephony commit.
senator [Wed, 26 May 2010 21:29:54 +0000 (21:29 +0000)]
Minor whitespace/syntax changes, sifted out of the previous telephony commit.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16514 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoFoundations of Action/Triger-based telephony,
senator [Wed, 26 May 2010 21:26:55 +0000 (21:26 +0000)]
Foundations of Action/Triger-based telephony,
by Joe Atzberger and Lebbeous Fogle-Weekley

Just as described to the open-ils-dev mailing list on May 21, 2010, with a
whitespace/non-semantic-changes patch to follow.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16513 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agohave new patron editor honor global.password_regex
phasefx [Wed, 26 May 2010 20:32:51 +0000 (20:32 +0000)]
have new patron editor honor global.password_regex

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16512 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agothese entities are no longer used
phasefx [Wed, 26 May 2010 20:32:50 +0000 (20:32 +0000)]
these entities are no longer used

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16511 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoCorrecting some diverging drift in the usr_merge function
scottmk [Wed, 26 May 2010 19:03:25 +0000 (19:03 +0000)]
Correcting some diverging drift in the usr_merge function

M    Open-ILS/src/sql/Pg/999.functions.global.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0278.function.usr-merge-drift.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16510 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAdding a qualifying schema name to keep PG happy
scottmk [Wed, 26 May 2010 18:57:06 +0000 (18:57 +0000)]
Adding a qualifying schema name to keep PG happy

M    upgrade/0277.schema.address_schema_drift.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16509 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoand, of course, the same typo /in/ the file. fixed
miker [Wed, 26 May 2010 18:07:46 +0000 (18:07 +0000)]
and, of course, the same typo /in/ the file. fixed

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16507 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoarg ... typo in filename. moved
miker [Wed, 26 May 2010 18:07:04 +0000 (18:07 +0000)]
arg ... typo in filename. moved

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16506 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoafter nearly 280 schema updates, we had a little drift. this addresses upgrade vs...
miker [Wed, 26 May 2010 15:08:33 +0000 (15:08 +0000)]
after nearly 280 schema updates, we had a little drift. this addresses upgrade vs stock substantive differences

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16505 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoBug fixes in verifyObjectPCRUD():
scottmk [Wed, 26 May 2010 13:27:29 +0000 (13:27 +0000)]
Bug fixes in verifyObjectPCRUD():

1. Don't throw an exception just because a foreign key is null.

2. When looking for local or foreign contexts, always do a lookup of
the current row, even if you already have an image of that row in
hand.  The image you have may not include the foreign key(s) you need.

The latter fix is simple but inefficient.  It should be possible to
avoid the extra lookup most of the time, and maybe all of the time,
for the search, retrieve, and id_list methods.  However that will
involve additional complications, not yet implemented.  Let's make
it correct first, and worry about efficiency later.

M    Open-ILS/src/c-apps/oils_sql.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16504 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAdd actor.usr_password_reset table required for password reset functionality - missed...
dbs [Wed, 26 May 2010 01:35:37 +0000 (01:35 +0000)]
Add actor.usr_password_reset table required for password reset functionality - missed it in 0237.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16503 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agothis doesn't work. I think my environment wasn't pristine when I pushed it
phasefx [Tue, 25 May 2010 21:27:52 +0000 (21:27 +0000)]
this doesn't work.  I think my environment wasn't pristine when I pushed it

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16501 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoremove duplicate line
phasefx [Tue, 25 May 2010 21:21:35 +0000 (21:21 +0000)]
remove duplicate line

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16500 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoPatch from Bill Ott to add missing apostrophe in rdetail.js
erickson [Tue, 25 May 2010 20:51:47 +0000 (20:51 +0000)]
Patch from Bill Ott to add missing apostrophe in rdetail.js

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16497 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoCorrecting an upgrade script.
scottmk [Tue, 25 May 2010 17:53:43 +0000 (17:53 +0000)]
Correcting an upgrade script.

The value column in actor.org_unit_setting should be valid JSON.  In this
revised version the new value is jiggered to make it a string instead of a
number.  This conversion is a bit simplistic and can be defeated by various
kinds of improbable input.

M    Open-ILS/src/sql/Pg/upgrade/0274.data.org-setting-type-est-wait.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16496 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoThe Great For-In Refactoring of ought-nine broke dojo trees built from opensrf object...
miker [Tue, 25 May 2010 16:51:16 +0000 (16:51 +0000)]
The Great For-In Refactoring of ought-nine broke dojo trees built from opensrf objects. this un-refactors that

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16495 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoPlug some memory leaks, and eliminate some unnecessary
scottmk [Tue, 25 May 2010 16:21:56 +0000 (16:21 +0000)]
Plug some memory leaks, and eliminate some unnecessary
memory allocations.

In oils_utils.[ch]:

-- Create a new function, oilsFMGetStringConst(), similar to
oilsFMGetString() except that it doesn't allocate memory; it returns
a const pointer to a string internal to the specified object.

-- Add some comments, tidy up white space.

In oils_sql.c:

-- Replace oilsFMGetString() with oilsFMGetStringConst in a number
of places; partly to reduce memory churn, and partly to plug some
memory leaks where the function call was nested within a
parameter list.

-- Change org_tree_root() so as to return a const pointer to a
static buffer (which was already in use as a cache) instead of
allocating a copy of the string.  This change reduces memory
churn.  In addition the allocated string was leaking anyway, and
now that leak is plugged.

M    Open-ILS/include/openils/oils_utils.h
M    Open-ILS/src/c-apps/oils_sql.c
M    Open-ILS/src/c-apps/oils_utils.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16494 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agosupport for calculating estimated hold wait time based on new circ estimated wait...
erickson [Tue, 25 May 2010 13:51:26 +0000 (13:51 +0000)]
support for calculating estimated hold wait time based on new circ estimated wait field

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16493 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadded support for propagating searchOrg, searchSort, searchSortDir, searchLang, start...
erickson [Tue, 25 May 2010 13:51:25 +0000 (13:51 +0000)]
added support for propagating searchOrg, searchSort, searchSortDir, searchLang, startIndex, and count in openurl mapper

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16492 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoVarious changes to verifyObjectPCRUD():
scottmk [Tue, 25 May 2010 03:24:07 +0000 (03:24 +0000)]
Various changes to verifyObjectPCRUD():

1. Add numerous comments.

2. Check for nullity of local_context before dereferencing it.

3. If the lookup of a foreign row results in an empty result set, set
_param to NULL instead of pointing it to a JSON_NULL.  (Existing code
seems to assume such a policy.  This assumption was false, because
jsonObjectClone() never returns NULL.)

4. Instead of using jsonObjectClone() and then immediately destroying
the original, use jsonObjectExtractIndex() to pull an existing subobject
out of its surroundings.

5. In the loop implementing the "jump" attribute: plug a memory leak by
freeing _fparam before assigning it a new value.

6. In the loop that adds org unit contexts from a foreign row: take the
call to osrfHashGet() out of the loop condition, since its return value
is a loop invariant.

-----------

NOTE: This patch does *not* fix a known bug whereby we try to trace
foreign keys that are not present in the available row image.  The result
of the bug is that all id_list calls deny access in pcrud.  The same bug
can affect retrieve and search calls, if the call specifies a SELECT list
that doesn't include all the necessary foreign keys.

A fix for this bug will come later; fixing it now would make it harder to
test the current changes.

M    Open-ILS/src/c-apps/oils_sql.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16491 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadd settings group table, shared between org and usr settings, for labeling groups...
miker [Mon, 24 May 2010 20:08:20 +0000 (20:08 +0000)]
add settings group table, shared between org and usr settings, for labeling groups of settings

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16490 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoSplit old org unit setting type circ.hold_estimate_wait_interval into two:
scottmk [Mon, 24 May 2010 18:52:02 +0000 (18:52 +0000)]
Split old org unit setting type circ.hold_estimate_wait_interval into two:

circ.holds.default_estimated_wait_interval
circ.holds.min_estimated_wait_interval

...with corresponding tweaks to label and description.

Also: change datatype from 'integer' to 'interval'.

For any existing rows in actor.org_unit_setting, pointing to the old
setting type: update them to point to circ.holds.default_estimated_wait_interval.

(Due to a foreign key constraint, the latter update has to happen in the same
transaction as the rename of the old row.)

M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0274.data.org-setting-type-est-wait.sql
M    Open-ILS/src/sql/Pg/950.data.seed-values.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16489 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAdd CVV field to selfcheck credit card payment interface
senator [Mon, 24 May 2010 18:31:41 +0000 (18:31 +0000)]
Add CVV field to selfcheck credit card payment interface

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16488 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoConsistently return fail_part to the client from in-db circ/hold failures
senator [Mon, 24 May 2010 18:25:07 +0000 (18:25 +0000)]
Consistently return fail_part to the client from in-db circ/hold failures

This will allow more specificity in messages explaining circ/hold failures
to the user.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16487 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoSeparate payment form code from the rest of the self check interface
senator [Mon, 24 May 2010 16:04:42 +0000 (16:04 +0000)]
Separate payment form code from the rest of the self check interface

This will facilitate the borrowing of the same code for re-use in the OPAC,
and potentially elsewhere.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16486 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadd View/Place Orders to opac wrapper in staff client
phasefx [Mon, 24 May 2010 15:52:01 +0000 (15:52 +0000)]
add View/Place Orders to opac wrapper in staff client
remove Show/Create Orders action from OPAC

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16485 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoenable grid paging by default. replaced showPaginator with hidePaginator option
erickson [Fri, 21 May 2010 20:28:34 +0000 (20:28 +0000)]
enable grid paging by default.  replaced showPaginator with hidePaginator option

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16483 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agountil support for added circ mod groups on new matchpoints is finished, exit the...
erickson [Fri, 21 May 2010 19:31:22 +0000 (19:31 +0000)]
until support for added circ mod groups on new matchpoints is finished, exit the func early to prevent JS errors

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16481 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agorepaired inadvertent api drift caused by move from storage to cstore call in user...
erickson [Fri, 21 May 2010 18:23:23 +0000 (18:23 +0000)]
repaired inadvertent api drift caused by move from storage to cstore call in user fines summary.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16480 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoPatch from Jason Stephenson which adds "IF EXISTS" to all DROP SCHEMA statements...
miker [Fri, 21 May 2010 17:01:32 +0000 (17:01 +0000)]
Patch from Jason Stephenson which adds "IF EXISTS" to all DROP SCHEMA statements where it is currently missing in the scripts in Open-ILS/src/sql/Pg directory.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16479 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoForward port of a patch from Dan Wells to fix the bookbag menu not showing up in...
miker [Fri, 21 May 2010 16:53:39 +0000 (16:53 +0000)]
Forward port of a patch from Dan Wells to fix the bookbag menu not showing up in Craftsman.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16478 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAdd column avg_wait_time to config.circ_modifier.
scottmk [Fri, 21 May 2010 16:32:00 +0000 (16:32 +0000)]
Add column avg_wait_time to config.circ_modifier.

M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0273.schema.config-circ-mod-avg-wait.sql
M    Open-ILS/src/sql/Pg/100.circ_matrix.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16475 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoremove errant tsearch joiners if the normalizers are messy and leave leading/trailing...
miker [Fri, 21 May 2010 15:52:42 +0000 (15:52 +0000)]
remove errant tsearch joiners if the normalizers are messy and leave leading/trailing spaces

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16474 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadd identifier FTS config (assumed to exist in some places)
miker [Fri, 21 May 2010 15:46:30 +0000 (15:46 +0000)]
add identifier FTS config (assumed to exist in some places)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16473 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agouse proper JSON, re &apos; vs &quot;
miker [Fri, 21 May 2010 15:24:39 +0000 (15:24 +0000)]
use proper JSON, re &apos; vs &quot;

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16472 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agohide the out-of-sync, non-xul dojo menu in the html pages. we don't want it showing...
erickson [Fri, 21 May 2010 15:09:13 +0000 (15:09 +0000)]
hide the out-of-sync, non-xul dojo menu in the html pages.  we don't want it showing up in the self-check UI or any oter public UIs built from templates

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16471 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoSupport IS NULL and IS NOT NULL expressions.
scottmk [Fri, 21 May 2010 14:00:03 +0000 (14:00 +0000)]
Support IS NULL and IS NOT NULL expressions.

M    Open-ILS/include/openils/oils_buildq.h
M    Open-ILS/src/c-apps/oils_storedq.c
M    Open-ILS/src/c-apps/buildSQL.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16470 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoFixing a typo in the previous changeset (a missing comma that led to
scottmk [Fri, 21 May 2010 13:04:16 +0000 (13:04 +0000)]
Fixing a typo in the previous changeset (a missing comma that led to
nonsense instead of an obvious error).

M    Open-ILS/src/sql/Pg/002.schema.config.sql
M    Open-ILS/src/sql/Pg/008.schema.query.sql
A    Open-ILS/src/sql/Pg/upgrade/0270.schema.query-xisnull-correction.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16469 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoallow caller to define the sort field/direction in PL retrieval call. by default...
erickson [Fri, 21 May 2010 13:02:19 +0000 (13:02 +0000)]
allow caller to define the sort field/direction in PL retrieval call.  by default, sort most recently edited PLs to the front

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16468 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoPO virtual lineitem_count field is an int, not a link
erickson [Fri, 21 May 2010 13:02:18 +0000 (13:02 +0000)]
PO virtual lineitem_count field is an int, not a link

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16467 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoCreate database support for IS [NOT] NULL expressions
scottmk [Thu, 20 May 2010 20:35:12 +0000 (20:35 +0000)]
Create database support for IS [NOT] NULL expressions
in stored queries.

M    Open-ILS/src/sql/Pg/002.schema.config.sql
M    Open-ILS/src/sql/Pg/008.schema.query.sql
A    Open-ILS/src/sql/Pg/upgrade/0269.schema.query-xisnull.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16466 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAcq: correct a mistake in r16464
senator [Thu, 20 May 2010 16:01:51 +0000 (16:01 +0000)]
Acq: correct a mistake in r16464

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16465 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAcq: fix unified search for not-null boolean fields
senator [Thu, 20 May 2010 15:47:55 +0000 (15:47 +0000)]
Acq: fix unified search for not-null boolean fields

The unified search UI produces a checkbox for these fields, but it did not
build a search query from checkboxes correctly.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16464 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoloosen the restrictions on exporting holdings / price data from uploaded records...
erickson [Thu, 20 May 2010 14:10:47 +0000 (14:10 +0000)]
loosen the restrictions on exporting holdings / price data from uploaded records.  It's no longer necessary to set every field in the holdings data just to import.  if no quantity is defined, go ahead and pull the estimed price data (when present) to link it with the lineitem

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16463 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoDon't assume an explicit print strategy has been set here
phasefx [Thu, 20 May 2010 05:21:39 +0000 (05:21 +0000)]
Don't assume an explicit print strategy has been set here

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16462 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years ago* I18N for print admin interface
phasefx [Thu, 20 May 2010 04:55:40 +0000 (04:55 +0000)]
* I18N for print admin interface
* custom/external print strategy (where you dictate an external command and feed it %receipt.txt% and/or %receipt.html%)
* DOS LPT1 Print strategy preserved as a legacy option, but without serving double-duty with the external linux commands
* label printing now honors plain text print strategies, but we're still stuck with system defaults for print dialogs
* @hex attribute for generating control characters when using HTML in templates being rendered with plain text print strategies

  For example, <p hex="0C">Hello World</p> will transform into form feed + Hello World if used with DOS LPT1 Print or with the
  %receipt.txt% macro for the Custom/External Print strategy.  <p>Hello World</p hex="0C"> will yield Hello World + form feed.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16461 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoset persisted settings before generating labels on page load
phasefx [Thu, 20 May 2010 04:54:15 +0000 (04:54 +0000)]
set persisted settings before generating labels on page load

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16460 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agorework these column definitions for pre-cats, since all rows in the list are getting...
phasefx [Thu, 20 May 2010 04:54:11 +0000 (04:54 +0000)]
rework these column definitions for pre-cats, since all rows in the list are getting mvr objects now

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16459 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agochange this id to avoid a collision when patron and circ columns are combined in...
phasefx [Thu, 20 May 2010 04:54:03 +0000 (04:54 +0000)]
change this id to avoid a collision when patron and circ columns are combined in one list (such as with the Check-In interface)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16458 dcc99617-32d9-48b4-a31d-7c20da2025e4