working/Evergreen.git
7 years agoSchema.org: relate offers to record explicitly
Dan Scott [Thu, 22 Aug 2013 22:30:34 +0000 (18:30 -0400)]
Schema.org: relate offers to record explicitly

Although schema.org defines the nested child elements as implicit
relationships that should be good enough for the Offer-to-Product
relationship, defining that relationship explicitly can't hurt.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoMap the bound-with relationship in schema.org
Dan Scott [Tue, 20 Aug 2013 16:45:44 +0000 (12:45 -0400)]
Map the bound-with relationship in schema.org

We don't know what type the target record is, so fall back to Product
and just point at it. At least this way schema.org processors will know
that the target bib is related to the current bib.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoAdd structured data for holdings via http://schema.org/Offer
Dan Scott [Sun, 25 Aug 2013 04:40:46 +0000 (00:40 -0400)]
Add structured data for holdings via schema.org/Offer

Map library name to Offer/seller, shelving location to
Offer/availableAtOrFrom, call number to Offer/sku, barcode to
Offer/serialNumber, copy status to Offer/availability, and ISBN-13 to
gtin13. Use the additionalType of Product to give these offers an
obvious relationship.

Surface copy counts as AggregateOffer instances.

Cut over to RDFa Lite instead of microdata for schema.org, as RDFa Lite
is more easily extensible with other vocabularies, and is as accepted as
microdata by schema.org processors.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoSchema.org: improve MusicGroup vs. Person parsing
Dan Scott [Sun, 25 Aug 2013 04:39:46 +0000 (00:39 -0400)]
Schema.org: improve MusicGroup vs. Person parsing

Take a stricter approach to defining MusicGroups instead of Persons for
the main authors of MusicAlbums. Music groups are generally catalogued
as a 110 or 710 tag, and this avoids defining birthDates and deathDates
for groups (which, however valid that might be in the real world, is not
valid for schema.org).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoStamping upgrade for patron self-reg
Dan Wells [Fri, 23 Aug 2013 23:33:58 +0000 (19:33 -0400)]
Stamping upgrade for patron self-reg

Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoTrivial changes
Dan Wells [Fri, 23 Aug 2013 23:25:06 +0000 (19:25 -0400)]
Trivial changes

-Fix (conform) whitespace in IDL
-Fix "county" typo in settings label
-Restore mysteriously absent "Bottom Link 2" :)

Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP1207396 Patron Self-Register Release Notes
Bill Erickson [Tue, 6 Aug 2013 16:08:00 +0000 (12:08 -0400)]
LP1207396 Patron Self-Register Release Notes

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP1207396 pending patron reg show requestor
Bill Erickson [Tue, 6 Aug 2013 17:52:24 +0000 (13:52 -0400)]
LP1207396 pending patron reg show requestor

Show a link to the requesting user, when present, for pending patrons in
the staff client patron registration form.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP1207396 TPAC org_selector supports org filter
Bill Erickson [Tue, 6 Aug 2013 13:31:11 +0000 (09:31 -0400)]
LP1207396 TPAC org_selector supports org filter

When building and org unit selector via the build_org_selector MARCO,
the caller can now pass in a "valid_org_list" array which contains org
unit IDs.  When such a list is provided, any org units in the selector
which are not in the list are marke as disabled.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP1207396 Patron self-registration web form
Bill Erickson [Thu, 1 Aug 2013 20:52:18 +0000 (16:52 -0400)]
LP1207396 Patron self-registration web form

Web form for allowing patrons to submit thier own library registration
requests.  The form collects various bits of user data and creates a
pending user account, which has no privileges.  These pending accounts
must be approved and completed by staff from the staff client "Pending
Patrons" action in the Cirulation menu.

Control of whether to show a field, treat a field as required, show
example text, and validate the field format is managed with existing org
unit settings.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP1207396 user stage allows username selection
Bill Erickson [Tue, 6 Aug 2013 14:10:19 +0000 (10:10 -0400)]
LP1207396 user stage allows username selection

The caller may now pass a value for username.  If unset, it still falls
back to using a uuid.  If the username clashes with an existing staged
username, a USERNAME_EXISTS event is returned.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP1207396 purge old pending users
Bill Erickson [Tue, 6 Aug 2013 15:09:45 +0000 (11:09 -0400)]
LP1207396 purge old pending users

Script to delete pending user accounts based on the interval defined in
the opac.pending_user_expire_interval org unit setting.

Add /openils/bin/purge_pending_users.srfsh to opensrf's CRON.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP1207396 DB / IDL for patron self-reg
Bill Erickson [Thu, 1 Aug 2013 17:30:52 +0000 (13:30 -0400)]
LP1207396 DB / IDL for patron self-reg

Updating pending addr tables to track requesting user and address county.

Adding org settings:

* opac.allow_pending_user -- allow self-registration
* opac.pending_user_expire_interval - delete pending user interval
* ui.patron.edit.aua.county.require - indicate if county is required

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP#1182519 Stamping DB upgrade 0822 user/berick/lp1182519-hold-behind-desk-staging
Bill Erickson [Fri, 23 Aug 2013 14:35:12 +0000 (10:35 -0400)]
LP#1182519 Stamping DB upgrade 0822

Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoLP1182519 Per-Hold Behind Desk Value
Bill Erickson [Tue, 21 May 2013 15:59:36 +0000 (11:59 -0400)]
LP1182519 Per-Hold Behind Desk Value

The true/false value for behind_desk is now stored directly on the hold
object for more accurate tracking of the location of captured holds.
If configured, patrons can now set their preferred value for behind the
desk holds.

 * DB/IDL changes to support the new column
 * API support for loading the setting from the patron for cases when no
   value is provided by the caller.
 * Staff client grid column definition for the Behind Desk field
 * Hold counts in the staff client now show total, available, and
   behind-desk (at the workstation).
 * Printed hold receipt now uses the behind_desk value on the hold to
   decide if a hold is behind the desk.
 * Release notes

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts:

Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm

Resolved 2 conflicts in Actor.pm sub hold_request_count
Retained the parameters as:
  my( $self, $client, $authtoken, $user_id, $ctx_org) = @;

And retained:

my @ready = grep { .... } @$holds code.

Signed-off-by: Garry Collum <gcollum@gmail.com>
7 years agoAdd placeholder file for 0821 upgrade script
Ben Shum [Thu, 22 Aug 2013 16:16:39 +0000 (12:16 -0400)]
Add placeholder file for 0821 upgrade script

0821 was added as a backport fix for 2.3 and 2.4, but not master.

Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoCorrectly mark nested INNER joins as such
Mike Rylander [Wed, 14 Aug 2013 14:25:14 +0000 (10:25 -0400)]
Correctly mark nested INNER joins as such

We've been adopting containing the JOINs flavor, and then
attempting to use IS NOT NULL to restrict NULL-ness
in the WHERE clause.  This is almost right, but not quite,
and was done in an attempt to match behavior with the
expectations of users that are not SQL experts.  However,
right is better than "looks right most of the time", so
we use the proper join type now.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Boyer <jboyer1@library.in.gov>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoFix A/T object cache
Thomas Berezansky [Thu, 1 Nov 2012 13:08:38 +0000 (09:08 -0400)]
Fix A/T object cache

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP1183467 ACQ view funding source list permissions
Bill Erickson [Thu, 23 May 2013 17:30:43 +0000 (13:30 -0400)]
LP1183467 ACQ view funding source list permissions

Limit the set of funding sources visible in the funding source list
interface by those the user has view permissions for, not just those the
user has edit permissions for.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoStamping upgrade script for series title normalizer improvement
Mike Rylander [Thu, 22 Aug 2013 15:26:20 +0000 (11:26 -0400)]
Stamping upgrade script for series title normalizer improvement

Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoRemove [ and ] characters from seriestitle index LP#1187521
Steven Callender [Tue, 4 Jun 2013 18:11:50 +0000 (14:11 -0400)]
Remove [ and ] characters from seriestitle index LP#1187521

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoRepair remaining Authority Fixed Field editor entries
Mike Rylander [Fri, 12 Jul 2013 18:43:57 +0000 (14:43 -0400)]
Repair remaining Authority Fixed Field editor entries

The "Item" fixed field is only valid for MFHD records, so we remove
that entirely from AUTH records.  The "GeoSubd" fixed field is
spelled "GeoDiv" everywhere, so we align that naming so that it can
be saved.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoPropagating 2.3.10 DB upgrade script
Bill Erickson [Thu, 22 Aug 2013 14:24:57 +0000 (10:24 -0400)]
Propagating 2.3.10 DB upgrade script

Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoRemove JSPAC-oriented PasswordReset.pm interface
Dan Scott [Thu, 11 Jul 2013 17:04:53 +0000 (13:04 -0400)]
Remove JSPAC-oriented PasswordReset.pm interface

A native TPAC interface for resetting passwords arrived some time ago,
and the i18n for PasswordReset.pm predated the more standardized
approach taken by TPAC. So... kill the JSPAC interface and save
ourselves a little bit of Apache overhead in the process.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoAcq: Honor new dist forumula fields in old method of applying formulae
Lebbeous Fogle-Weekley [Tue, 2 Jul 2013 19:27:39 +0000 (15:27 -0400)]
Acq: Honor new dist forumula fields in old method of applying formulae

The batch updater came with new fields on distribution formulae, but we
didn't teach the pre-existing code for applying formulae from the
lineitem copies interface to apply values from the new fields.

Reported by Jennifer Pringle in Launchpad bug report #1195521.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agosilence some unitialized warnings
Jason Etheridge [Thu, 1 Aug 2013 16:34:21 +0000 (12:34 -0400)]
silence some unitialized warnings

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoInvoke skull-and-crossbones popup in batch receive for server-side errors
Lebbeous Fogle-Weekley [Mon, 23 Jan 2012 23:44:00 +0000 (18:44 -0500)]
Invoke skull-and-crossbones popup in batch receive for server-side errors

And introduce a minor bumper rail to guide serials users who might try
to hand-edit a holding code.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Conflicts:
    Open-ILS/xul/staff_client/server/serial/batch_receive.js

Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoMake C unit tests more robust
Dan Scott [Wed, 21 Aug 2013 15:57:40 +0000 (11:57 -0400)]
Make C unit tests more robust

Adding -I@abs_top_srcdir@/Open-ILS/include will pull in the source tree
header files, so that the C unit tests can run before Evergreen has been
installed (and thus will be a valid test of the source header files
instead of relying on the installed versions that might be different).

Build c-apps before recursing into c-apps/tests:
This ensures that the required libraries are built before the C unit
tests are built, thus preventing "make check" on a just-configured
source tree from failing due to missing dependencies.

Also, link to the source tree directories first rather than last, to
ensure that we pull in the correct source (if possible). And remove the
cargo-cultish $(TMP) linking/including.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
7 years agoMove HTML tags out of translatable strings in toolkit templates.
Pasi Kallinen [Mon, 10 Jun 2013 05:42:18 +0000 (08:42 +0300)]
Move HTML tags out of translatable strings in toolkit templates.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoCopying 2.3.8-2.3.9 SQL upgrade script
Bill Erickson [Wed, 21 Aug 2013 13:51:10 +0000 (09:51 -0400)]
Copying 2.3.8-2.3.9 SQL upgrade script

Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoAcq general search: improve searching for negative comparisons
Lebbeous Fogle-Weekley [Wed, 19 Sep 2012 19:27:03 +0000 (15:27 -0400)]
Acq general search: improve searching for negative comparisons

This aims to address Launchpad bug #1031535.  I think the bug only
really shows up when searches involve invoices either as the core type
or with filter fields.  If a search doesn't involve invoices, the
problematic joins aren't present.

Could use more testing though.  Seems to make the problem go away, and
other basic searches seem to work, but I certainly haven't tested
everything.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoMove exchange_rate seed data to 950 file
Dan Wells [Fri, 12 Jul 2013 21:20:07 +0000 (17:20 -0400)]
Move exchange_rate seed data to 950 file

Since currency_type is a foreign key of acq.exchange_rate, if we move
currency_type to the seed data file, exchange rate must follow.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoMove acq.currency_code entries and wrap for i18n
Pasi Kallinen [Tue, 11 Jun 2013 08:53:42 +0000 (11:53 +0300)]
Move acq.currency_code entries and wrap for i18n

Fix LP#1107834 by moving the acq.currency_code entries into
950.data.seed-values.sql and wrapping the texts with oils_i18n_gettext.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoFedora: remove source installs for packaged dependencies
Dan Scott [Tue, 20 Aug 2013 17:02:23 +0000 (13:02 -0400)]
Fedora: remove source installs for packaged dependencies

The Perl MARC packages, Library::CallNumber::LC, and libdbi / libdbd
drivers have been available as packages on Fedora since Fedora 18 (which
is now the oldest supported Fedora version), so don't install these from
source.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoLP 1190279 Modularize Makefile.install fedora target
Bill Erickson [Mon, 19 Aug 2013 15:23:14 +0000 (11:23 -0400)]
LP 1190279 Modularize Makefile.install fedora target

make -f Makefile.install fedora

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoLP 1190279 libtest-warn-perl for ubuntu targets
Bill Erickson [Mon, 19 Aug 2013 16:16:43 +0000 (12:16 -0400)]
LP 1190279 libtest-warn-perl for ubuntu targets

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoLP 1190279 Modularize Makefile.install misc. repairs
Bill Erickson [Tue, 9 Jul 2013 15:43:47 +0000 (11:43 -0400)]
LP 1190279 Modularize Makefile.install misc. repairs

apply missing install_libdbi for wheezy/squeeze

Added libtest-warn-perl prereq for wheezy/squeeze

per-distro makefile improvments

install soap-lite as a deb before CPAN runs.
   Business::OnlinePayment::PayPal fails otherwise.

by default, use apt-get as the APT tool, since all debian distros have
   this

move 'install_yaz' directly into Makefile.ubuntu-lucid, since that's
  the only OS which uses it.

Squeeze also needs an updated yaz; Yaz-related repairs

give debians and lucid libbz2-dev; precise has it already

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoLP 1190279 Installer makefiles OS targets for PG server
Bill Erickson [Mon, 8 Jul 2013 19:43:57 +0000 (15:43 -0400)]
LP 1190279 Installer makefiles OS targets for PG server

Instead of requesting install_pgsql_server_debs_91,
install_pgsql_server_backport_debs_91, etc. when installing the
postgres server, simply give each OS type its own postgres install
target.

make -f Makefile.install postgres-server-debian-wheezy
make -f Makefile.install postgres-server-debian-squeeze
make -f Makefile.install postgres-server-ubuntu-lucid
make -f Makefile.install postgres-server-ubuntu-precise
make -f Makefile.install postgres-server-fedora

Let the OS module decide what and how to install the postgres server.

Changes are reflected in docs/installation/server_installation.txt

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoLP 1190279 Ubuntu install targets
Chris Sharp [Thu, 13 Jun 2013 11:56:45 +0000 (07:56 -0400)]
LP 1190279 Ubuntu install targets

Ubuntu 10.04 comes with Yaz 3.0.52.

This installs version 4.2.32 from source.

Adding per-distro makefiles for Ubuntu 10.04 and 12.04.

Correcting minor typo

SimpleServer installation expects yaz to already be installed

Ubuntu 12.04 does not like libparent-perl

Removing librose-uri-perl from the debs list since it is not in the 12.04 repo

Adding libbz2-dev to the deb list

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoLP 1190279 Modularize Makefile.install
Bill Erickson [Wed, 12 Jun 2013 15:18:46 +0000 (11:18 -0400)]
LP 1190279 Modularize Makefile.install

Create per-distro installer Makefiles for easier maintenance and
per-distro tweaks.

Included in this commit are installer Makefiles for debian wheezy and
squeeze.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoUpdate docs for Fedora install
Dan Scott [Tue, 20 Aug 2013 18:29:59 +0000 (14:29 -0400)]
Update docs for Fedora install

Fedora 17 is no longer a supported distro; long live Fedora 18/19 and
beyond (and their beautiful packages that let us avoid many source
installs).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoRead the zip code lookup file in UTF8 mode.
Pasi Kallinen [Mon, 1 Jul 2013 05:36:48 +0000 (08:36 +0300)]
Read the zip code lookup file in UTF8 mode.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoFix Lp bug 965656 WRT back dated checkins with fines.
Jason Stephenson [Tue, 11 Jun 2013 17:22:33 +0000 (13:22 -0400)]
Fix Lp bug 965656 WRT back dated checkins with fines.

* Move _check_open_xact from OpenILS::Application::Circ::Money
  to OpenILS::Application::AppUtils so it can be called from
  wherever.

* Modify OpenILS::Application::Circ::Money to use check_open_xact
  from OpenILS::Application::AppUtils.

* Modify finish_fines_and_voiding in OpenILS::Application::Circ::Circulate
  to use check_open_xact instead of reopen_xact.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm

7 years agoImproved copy table CSS/markup for conjoined bibs
Dan Scott [Mon, 15 Jul 2013 18:36:30 +0000 (14:36 -0400)]
Improved copy table CSS/markup for conjoined bibs

Let the library name column wrap now that it may potentially contain
stupidly long title/author combos. Also, associate the table cells with
their corresponding headers for improved accessibility.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoConjoined items / foreign items display in TPAC
Dan Scott [Mon, 15 Jul 2013 15:28:21 +0000 (11:28 -0400)]
Conjoined items / foreign items display in TPAC

Foreign items now appear at the top of the copy table, no matter what
copy page you are on. See "The two violin concertos" in the Concerto
data set for an example; the foreign bib is linked, with a label for the
designated peer type.

The parent bib record displays all of the child records in the copy table
underneath the pertinent copy; each title / author entry links to the
child bib display, naturally. See "Violin concerto no. 2 ; Six duos
(from 44 Duos)" in the Concerto data set for an example.

We escape all of the text retrieved from the database to avoid XSS
(thanks for the heads-up from Pasi Kallinen).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Now with HTML escaping for safety

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoWhitespace and timelog entries
Dan Scott [Mon, 15 Jul 2013 13:11:53 +0000 (09:11 -0400)]
Whitespace and timelog entries

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoExpose conjoined bibs in TPAC
Bill Ott [Thu, 23 May 2013 00:11:07 +0000 (20:11 -0400)]
Expose conjoined bibs in TPAC

This initial work is based on the GRPL need to handle eReader bib/copy display.
The "joined" titles will display a copy record with a call_number link back to
the "master" bib, where the master will display a set of links to individual
titles from each "copy".

TODO: consider peer_type when determining whether or not to display

Signed-off-by: Bill Ott <bott@grpl.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoStamping upgrade script for dewey sort fix
Ben Shum [Tue, 20 Aug 2013 14:50:43 +0000 (10:50 -0400)]
Stamping upgrade script for dewey sort fix

Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP#1150939 fix dewey sort
Jason Etheridge [Thu, 7 Mar 2013 16:59:09 +0000 (11:59 -0500)]
LP#1150939 fix dewey sort

There's a bit in the code where it tries to pad the first digit group,
if it's the only digit group, but it assumed the digit group was the
first token.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP1208572 - Fixes for reporter.classic_item_list
Chris Sharp [Mon, 5 Aug 2013 18:10:56 +0000 (14:10 -0400)]
LP1208572 - Fixes for reporter.classic_item_list

This view was created before the extend_reporter schema and the reporter.
materialized_simple_record existed.  Rewriting the view definition to include
those.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoFix LP#1160770 by marking default toolbar names as translatable.
Pasi Kallinen [Mon, 15 Jul 2013 08:22:57 +0000 (11:22 +0300)]
Fix LP#1160770 by marking default toolbar names as translatable.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP 1084732 TPAC copy location selector
Bill Erickson [Tue, 13 Aug 2013 18:39:00 +0000 (14:39 -0400)]
LP 1084732 TPAC copy location selector

Copy location filter selector for the TPAC advanced search interface.
The behavior is the same as the analogous JSPAC feature.  The interface
components are hidden by default, so non-JS browsers will be none the
wiser.

A number of small tweaks to related code were needed and are included in
this commit:

1. Make copy locations field_safe in the IDL so they can be retrieved
   and parsed without the IDL
2. Insert a (full) hash-based org unit tree as inline JS at the bottom
   of js.tt2 so JS will have access to the whole tree without having to
   load the IDL to understand it.
3. Fix a bug in openils.CGI : decodeURIComponent parameter names

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP#1131889: sort TPac copy list by normalized call number
Galen Charlton [Fri, 22 Feb 2013 19:00:55 +0000 (14:00 -0500)]
LP#1131889: sort TPac copy list by normalized call number

... as opposed to the literal call number label.  E.g., this
patch would make LC call number "AE5 .E363 1975 v.10" sort
after "AE5 .E363 1975 v.9" rather than after "AE5 .E363 1975 v.1"

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoFix typo in release notes file name for acq-style-cancelled-delayed.
Jason Stephenson [Tue, 20 Aug 2013 14:03:34 +0000 (10:03 -0400)]
Fix typo in release notes file name for acq-style-cancelled-delayed.

Rename acq-style-cancelled-delayted.txt to acq-style-cancelled-dealyed.txt.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoACQ delayed lineitems style release notes
Bill Erickson [Wed, 26 Dec 2012 21:43:20 +0000 (16:43 -0500)]
ACQ delayed lineitems style release notes

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoImprove styling for 'delayed' lineitems in PO UI
Bill Erickson [Tue, 11 Dec 2012 15:26:30 +0000 (10:26 -0500)]
Improve styling for 'delayed' lineitems in PO UI

When a lineitem is cancelled, but "keep_debits" is true, the lineitem is
in effect delayed instead of truly cancelled.  Make it more obvious in
the UI the difference between delayed and truly cancelled lineitems by
applying a row styling for delayed items (similar to other status row
styling) and always show the cancel reason (label) in the lineitem
display in the PO, next to the non-title attributes.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoDB numbering for patron duplication check depth setting
Lebbeous Fogle-Weekley [Fri, 16 Aug 2013 14:32:42 +0000 (10:32 -0400)]
DB numbering for patron duplication check depth setting

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoAdjust Kyle Tomita's patron dupe check fix to use the depth concept
Lebbeous Fogle-Weekley [Fri, 16 Aug 2013 13:31:16 +0000 (09:31 -0400)]
Adjust Kyle Tomita's patron dupe check fix to use the depth concept

Addressing these comments:
https://bugs.launchpad.net/evergreen/+bug/1185524/comments/3

And also renaming the OU setting to better peer with similar settings
affecting staff client (not OPAC) patron registration.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
7 years agoLP1185524 - Duplicate patron checking in the user editor is limited to workstation OU
Kyle Tomita [Fri, 31 May 2013 18:33:59 +0000 (11:33 -0700)]
LP1185524 - Duplicate patron checking in the user editor is limited to workstation OU

Added a new library setting opac.duplicate_patron_check_use_consortium.
When true, the duplicate check will use the consortium (1) as the OU.
When false or not set, the duplicate check will use the workstation OU.

The setting is checked in subroutine that creates the search request and
sets the OU accordingly.

[LFW: Signing off but following with material changes next commit.]

Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
7 years agoUse uri_escape_utf8 instead of uri_escape
Pasi Kallinen [Fri, 28 Jun 2013 06:44:44 +0000 (09:44 +0300)]
Use uri_escape_utf8 instead of uri_escape

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoFix LP985075, cannot save Patron Acquisition Request form
Steven Chan [Mon, 5 Aug 2013 16:13:54 +0000 (12:13 -0400)]
Fix LP985075, cannot save Patron Acquisition Request form

The form is shown using a dojo EditPane attached to an EditDialog,
however, attaching the pane was done manually, resulting in the dialog
acting improperly and the pane positioned improperly.

Instead, we use dojo's attr method to define the content attribute of
the dialog to be the pane.

Signed-off-by: Steven Chan <schan@sitka.bclibraries.ca>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoFixing LP 1072892 - repeated rows in reporter.classic_item_list view
Chris Sharp [Wed, 31 Jul 2013 15:03:25 +0000 (11:03 -0400)]
Fixing LP 1072892 - repeated rows in reporter.classic_item_list view

The view joined the actor.card table in such a way that all library
cards (active or not) were being returned.  This commit changes that
behavior so that only the current card (from actor.usr.card) is returned.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoFinish i18n support for config.usr_setting_type
Pasi Kallinen [Fri, 7 Jun 2013 16:33:46 +0000 (19:33 +0300)]
Finish i18n support for config.usr_setting_type

Add the missing oils_i18n_gettext markers to config.usr_setting_type
inserts.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoFlag cust & oust name/description fields as translatable
Dan Scott [Wed, 20 Feb 2013 02:06:05 +0000 (21:06 -0500)]
Flag cust & oust name/description fields as translatable

Setting type names and descriptions should be translatable, a simple
oils_persist:i18n attribute will do the trick.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP1211506 fix numeric sorting in staff client grids
Bill Erickson [Tue, 13 Aug 2013 14:03:10 +0000 (10:03 -0400)]
LP1211506 fix numeric sorting in staff client grids

To recover numeric (vs. ascii-betical) sorting of number and money
values in grids, cast the cached sort values back into numbers.

This was tested in the billing interface, but should repair numeric
sorting for most grids.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoAlways show grid buttons on My Selection List
Pasi Kallinen [Mon, 22 Jul 2013 07:16:36 +0000 (10:16 +0300)]
Always show grid buttons on My Selection List

Fix LP#1028601 by showing the selection list creation buttons in the acq
search UI even when there are no search results.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoZ39.50 documentation asciidoc fix and moved Z39.50 Servers to the appropriate locatio...
Angela Kilsdonk [Mon, 12 Aug 2013 13:26:21 +0000 (09:26 -0400)]
Z39.50 documentation asciidoc fix and moved Z39.50 Servers to the appropriate location in root.txt.

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
7 years agoStamping upgrade script for long overdue status -- LP 1169193.
Jason Stephenson [Fri, 9 Aug 2013 20:03:47 +0000 (16:03 -0400)]
Stamping upgrade script for long overdue status -- LP 1169193.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoLP 1169193 Support L/O xact close on paid
Bill Erickson [Mon, 6 May 2013 15:01:52 +0000 (11:01 -0400)]
LP 1169193 Support L/O xact close on paid

Middle-layer support for the org unit setting "Leave transaction
open when long overdue balance equals zero".  It behaves the same
as "Leave transaction open when lost balance equals zero", but for
long-overdue circs.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoLP 1169193 Bypass longoverdue w/ default A/T runner
Bill Erickson [Fri, 26 Apr 2013 16:59:33 +0000 (12:59 -0400)]
LP 1169193 Bypass longoverdue w/ default A/T runner

Avoid processing LONGOVERDUE circulations in the default
action_trigger_runner.pl filter.

When no custom filters are used, the script will provide it's own
default filter for circulation-based hooks.  This change ensure that
when the default filter is in use, the script will not attempt to
process longoverdue circulations, since they have already been processed
(which is how they became longoverdue in the first place).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoLP 1169193 long-overdue release notes
Bill Erickson [Wed, 24 Apr 2013 18:09:12 +0000 (14:09 -0400)]
LP 1169193 long-overdue release notes

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoLP 1169193 transit_slip macro for copy status
Bill Erickson [Wed, 24 Apr 2013 15:05:02 +0000 (11:05 -0400)]
LP 1169193 transit_slip macro for copy status

Adds support for a new 'transit_slip' receipt template macro called
"transit_copy_status", which displays the stored status of the
in-transit copy (i.e. the status the copy will be placed in once it
arrives at the transit destination).  This is useful, in particular, for
lost or long-overdue items which are not "immediately available" upon
checkin.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoLP 1169193 long-overdue item checkin
Bill Erickson [Mon, 22 Apr 2013 17:05:14 +0000 (13:05 -0400)]
LP 1169193 long-overdue item checkin

Checkin of long-overdue items now goes through a very simimlar process
as check-in of Lost items.  Staff can control how long after the due
date (and potentially other date-related fields) the item may be
returned for a configurable set of refunds and/or reinstatement of
overdue fines.  All settings are controlled by a series of new org unit
settings specifically related to long-overdue processing.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoLP 1169193 long-overdue automated processing
Bill Erickson [Wed, 17 Apr 2013 14:31:04 +0000 (10:31 -0400)]
LP 1169193 long-overdue automated processing

Middle layer components for marking circulations long overdue.  The
automation is controlled with an Action/Trigger event definition
(sample included in seed data), which uses a new MarkItemLongOverdue
reactor.  The reactor makes use of a new util function (AssetCommon.pm)
for doing the actual work and looking up the relevant org unit settings.

Inluded is a new PatronNotInCollections Validator, which can be used to
avoid marking circulations long overdue for patrons that are in
collections processing.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoLP 1169193 long-overdue SQL seed data
Bill Erickson [Mon, 15 Apr 2013 15:44:26 +0000 (11:44 -0400)]
LP 1169193 long-overdue SQL seed data

Seed data for managing long-overdue circulations.

* new copy status
* new billing types
* new org settings
* new permissions
* sample action/trigger event definitions

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoFinish stamping for bib record browser
Dan Wells [Fri, 9 Aug 2013 19:16:09 +0000 (15:16 -0400)]
Finish stamping for bib record browser

Sorry for the noise...

Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoStamping upgrade scripts for bib record browser
Dan Wells [Fri, 9 Aug 2013 19:12:58 +0000 (15:12 -0400)]
Stamping upgrade scripts for bib record browser

LP #1177810

Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoFix problem where basic search bar was flush with left edge of page
Lebbeous Fogle-Weekley [Thu, 8 Aug 2013 14:27:10 +0000 (10:27 -0400)]
Fix problem where basic search bar was flush with left edge of page

Reported by Ben Shum.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoFix issues with multiple divs having the search-wrapper id.
Jason Stephenson [Fri, 26 Jul 2013 13:48:59 +0000 (09:48 -0400)]
Fix issues with multiple divs having the search-wrapper id.

Basically, remove the extra <div> from all the files that INCLUDE
searchbar.tt2, and leave the <div> that searchar.tt2 uses alone.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoOPAC Browse: bugfixes squashed together from LP #1177810
Lebbeous Fogle-Weekley [Mon, 22 Jul 2013 14:14:51 +0000 (10:14 -0400)]
OPAC Browse: bugfixes squashed together from LP #1177810

In specific:
    OPAC Browse: go back from numbered to bulleted results
    OPAC Browse: Avoid showing tracing if linked authorities have no bibs
    OPAC Browse: Replace English pager with customizable pager
    OPAC Browse: Extra small bit of documentation about author headings

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoBreak up expensive queries, match index to quals
Mike Rylander [Fri, 19 Jul 2013 16:35:31 +0000 (12:35 -0400)]
Break up expensive queries, match index to quals

First, we order browse queries over MBE by (sort_value, value) so we
want to match the unique index to that.

We're only going to use the first few rows of the cursors we build from
the back/forward MBE paging queries, and the embedded GROUP BY defeats
the planners desire to use an index for ordering the rows. So, instead,
we use a simpler core query and gather aggregate data as a secondary,
index-capable query for each MBE row.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoOPAC Browse: some squashed commits from LP #1177810
Lebbeous Fogle-Weekley [Thu, 13 Jun 2013 20:22:13 +0000 (16:22 -0400)]
OPAC Browse: some squashed commits from LP #1177810

Namely:
    OPAC Browse: Various interface improvements
    OPAC Browse: Put best-matched browse entry in middle of result set
    OPAC Browse: Don't try to build hyperlinks from 680 ‡a
    OPAC Browse: add a CSS class to the best-matching result when not paging
    Remove unwanted space before question makr in "Did you mean" message
    OPAC Browse: Fix browse interface's use of hits-per-page user setting

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoFix problem with YYYY.schema.bib-auth-browse.sql.
Jason Stephenson [Fri, 7 Jun 2013 14:31:30 +0000 (10:31 -0400)]
Fix problem with YYYY.schema.bib-auth-browse.sql.

Disable ALL triggers on authority.control_set_authority_field before
altering and updating the table to avoid an error related to altering
a table with pending trigger events.

The triggers are enabled again after the updates and alters are done.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoBib record browser with 'see also', etc from linked authority headings
Lebbeous Fogle-Weekley [Wed, 24 Apr 2013 14:46:27 +0000 (10:46 -0400)]
Bib record browser with 'see also', etc from linked authority headings

This feature provides a patron-oriented OPAC interface for browsing
bibliographic records.

Users choose to browse by Author, Title, Subject, or Series. They then
enter a browse term, and the nearest match from a left-anchored search
on the headings extracted for browse purposes will be displayed in a
typical backwards/forwards paging display. Headings link to search
results pages showing the related records. If the browse heading is
linked to any authority records, and if any *other* authority records
point to those with "See also" or other non-main entry headings, those
alternative headings are displayed a linked to a search results page
showing related bib records related to the alternate heading.

The counts of holdings displayed next to headings from bibliographic
records are subject to the same visiibility tests as search. This means
that the org unit (and copy location group) dropdown on the browse
interface affects counds, and it further means that whether or not
you're looking at the browse interface through the staff client makes a
difference.

This builds on the two previous commits that provide inter-authority
linking and the linking of metabib.browse_entry rows to authority
records.

This also contains, in squashed form, these commits that resulted from
collaboration on LP #1177810:

    Two bugfixes to OPAC Browse: non-filing indicators, leading-article warning
    Fix paste-o encountered in Bib browse upgrade script
    OPAC Browse: fix 0-9 link in paging shortcuts; padding issues
    OPAC Browse: Improve authority code to show more headings
    OPAC Browse: Fix authority counting
    Extensions to our MODS32 stylesheet to capture all possible NFI in fields
    OPAC Browse: i18n improvement for short terms
    OPAC Browser: Display Public General Notes from authorities when possible
    OPAC Browse: Build browse entry sort_value column separately from value
    OPAC Browse: We don't want role/relator info in browse headings
    OPAC Browse: Better display of tracings from authorities
    OPAC Browse: Pick up authority links from 650 fields
    OPAC Browse: Show authority tracings only when inter-authority links exist
    OPAC Browse: use  superpage concept for performance; fix other counting bug
    OPAC Browse: Fix broken authority reference link

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoLink browse entries to authority record when possible
Lebbeous Fogle-Weekley [Thu, 28 Mar 2013 22:02:32 +0000 (18:02 -0400)]
Link browse entries to authority record when possible

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoInter-authority linking
Lebbeous Fogle-Weekley [Fri, 22 Mar 2013 21:11:50 +0000 (17:11 -0400)]
Inter-authority linking

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoSolidify caption/holding relationship, improve MFHD::Holding comparisons
Dan Wells [Tue, 2 Jul 2013 15:55:21 +0000 (11:55 -0400)]
Solidify caption/holding relationship, improve MFHD::Holding comparisons

[This commit has been squashed for merging. LFW]

  * This commit:
    - Makes sure that holding data is valid for the given caption
      for new holding objects
    - Teaches field_values() to fall back to '*' (unknown marker)
      when a holding is missing data
    - Allows the caption() method to be a setter

  * This commit:
    - Makes the comparison operator consider chron data, not just
      enumeration data
    - Teaches the comparison operator a way to handle 'unsure' data
      (that is, data presented in brackets [])

  * The code was assuming the $end_holding param would be uncompressed,
    but this was not stated anywhere, nor enforced.  Let's allow the
    method to take both compressed and uncompressed holdings as the "end"
    (and handle it appropriately).

  * Add some holdings with missing and unsure data to test the new
    comparison operators handling of such data.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoFix logic in get_compressed_holdings()
Dan Wells [Wed, 8 May 2013 19:09:41 +0000 (15:09 -0400)]
Fix logic in get_compressed_holdings()

[This commit has been squashed for merging. LFW]

  * This commit rearranges some of the logic branches to protect
    against an unusual case of having two holding statements with
    the same start value, but one being open-ended and one not.

  * The logic in get_combined_holdings() was a little sloppy and
    repeated some steps unnecessarily.  This cleans things up.

    See the test case in the previous commit for more clarity.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoTie in new MFHD method to serials module/MFHD tests for compressing, combining
Dan Wells [Tue, 7 May 2013 22:23:27 +0000 (18:23 -0400)]
Tie in new MFHD method to serials module/MFHD tests for compressing, combining

[This commit has been squashed for merging. LFW]

 *  Now that we have a potentially better alternative, let's call
    get_combined_holdings() in place of get_compressed_holdings() in
    Serial.pm.

 *  First, add a test for the new get_combined_holdings() method.

    Second, add a known problem case for get_compressed_holdings().
    The fix will come in a subsequent commit.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoAdd new get_combined_holdings() method to MFHD.pm
Dan Wells [Tue, 7 May 2013 22:19:34 +0000 (18:19 -0400)]
Add new get_combined_holdings() method to MFHD.pm

This commit adds a new method to the MFHD module which creates an
array of compressed holdings from all holdings for a given caption,
combining as needed.

NOTE: This method is similar to, but much less aggressive/strict than
get_compressed_holdings(). Ultimately, get_compressed_holdings()
might be deprecated in favor of this.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoDocumentation for storing Z39.50 credentials. Added to existing file on Z39.50 permi...
Angela Kilsdonk [Fri, 9 Aug 2013 14:31:34 +0000 (10:31 -0400)]
Documentation for storing Z39.50 credentials.  Added to existing file on Z39.50 permissions.

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
7 years agoAcq: When processing EDI invoices, skip unknown line item references
Lebbeous Fogle-Weekley [Mon, 24 Jun 2013 15:47:40 +0000 (11:47 -0400)]
Acq: When processing EDI invoices, skip unknown line item references

See LP #1172373.

In their electronic invoices, vendors sometimes include a mix of line
items that your ILS knows about, because you ordered them through it,
and line items of which your ILS knows nothing. We should not fail
altogether at processing invoices, but instead process what line items
we can.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoAcq: When building invoices from EDI messages, avoid bad data
Lebbeous Fogle-Weekley [Tue, 16 Apr 2013 19:18:17 +0000 (15:18 -0400)]
Acq: When building invoices from EDI messages, avoid bad data

From some vendors, these EDI messages contain strings (useless ones,
like just the name of the vendor) where we had been expecting numeric
identifiers.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoValidate date ranges in Close Dates editor
Pasi Kallinen [Wed, 17 Jul 2013 17:24:26 +0000 (20:24 +0300)]
Validate date ranges in Close Dates editor

Complain in Closed Dates Editor when ending date is earlier than starting date.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoFix org unit setting names for this example test
Jason Etheridge [Mon, 5 Aug 2013 20:40:02 +0000 (16:40 -0400)]
Fix org unit setting names for this example test

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoPrevent paste from empty clipboard throwing an error
Pasi Kallinen [Tue, 23 Jul 2013 07:49:47 +0000 (10:49 +0300)]
Prevent paste from empty clipboard throwing an error

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoAdd release note for checkout trimming whitespaces from beginning and end of barcodes
Ben Shum [Tue, 6 Aug 2013 16:20:33 +0000 (12:20 -0400)]
Add release note for checkout trimming whitespaces from beginning and end of barcodes

Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoTrim whitespace from beginning and end of the barcode in checkout.
Pasi Kallinen [Tue, 2 Jul 2013 16:36:53 +0000 (19:36 +0300)]
Trim whitespace from beginning and end of the barcode in checkout.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoStamping upgrade script for "delate" typo
Ben Shum [Tue, 6 Aug 2013 16:13:15 +0000 (12:13 -0400)]
Stamping upgrade script for "delate" typo

Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoFix typo "delate" in permission descriptions.
Pasi Kallinen [Mon, 15 Jul 2013 07:01:57 +0000 (10:01 +0300)]
Fix typo "delate" in permission descriptions.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>