working/Evergreen.git
7 years agoAdd fi-FI to update_pofiles script
Pasi Kallinen [Tue, 18 Dec 2012 08:42:59 +0000 (10:42 +0200)]
Add fi-FI to update_pofiles script

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agopo-files for Finnish translation
Pasi Kallinen [Tue, 18 Dec 2012 08:41:28 +0000 (10:41 +0200)]
po-files for Finnish translation

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoMake config.update_coded_value_map() consistent
Dan Wells [Tue, 18 Dec 2012 20:51:12 +0000 (15:51 -0500)]
Make config.update_coded_value_map() consistent

The version of this function in the upgrade file is different than
the one in the 002.schema.config.sql file. This commit fixes the
broken logic in the 002 file and makes it match the logic in the
old upgrade file.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoCheck for a selection_depth returned from title_hold.is_possible.
James Fournie [Tue, 18 Dec 2012 20:45:51 +0000 (12:45 -0800)]
Check for a selection_depth returned from title_hold.is_possible.
See Launchpad 1064651 for details.  This is a quick fix which solves a
fairly serious issue whereby copies outside of a hard boundary could fill
holds when they are placed within the TPAC in the staff client.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoDojo IDL: Set the "Accept-Language" header
Dan Scott [Tue, 18 Dec 2012 13:52:55 +0000 (08:52 -0500)]
Dojo IDL: Set the "Accept-Language" header

The internationalization support for /reports/fm_IDL.xml keys off of the
Accept-Language header - which, if not set to ^[a-z]{2}-[A-Z]{2}$, falls
back to en-US. Setting the header in the dojo.xhrGet() request makes
Apache able to serve up the right flavour of /reports/fm_IDL.xml

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
7 years agoSet locale properly in Apache configuration
Dan Scott [Tue, 18 Dec 2012 12:39:18 +0000 (07:39 -0500)]
Set locale properly in Apache configuration

A RewriteCond only applies to the next RewriteRule, while our config was
attempting to apply multiple rules for a single condition. Fix that up
by using skip (S) rules to apply blocks of rules for the condition in
question.

Also, use the HTTP:Accept-Language value directly, rather than relying
on a backreference (which did not seem to be working as desired).

These fixes enable screens like the Register Patron interface to present
field labels from the IDL in the correct locale, whereas previously they
would always default to en-US.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
7 years agoLP#1078596: Cannot translate strings handled by fieldmapper
Pasi Kallinen [Sun, 2 Dec 2012 20:49:42 +0000 (22:49 +0200)]
LP#1078596: Cannot translate strings handled by fieldmapper

Strings that should be translatable only show up in English,
for example in the Patron Registration screen.

There's a bug in the fieldmapper where it sets a variable to
an empty array, but later in the code only checks whether that
particular variable exists, not if it's an empty array.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoSyndetics - retrieve summary as part of added content
Ben Shum [Wed, 28 Nov 2012 21:05:53 +0000 (16:05 -0500)]
Syndetics - retrieve summary as part of added content

As noted by Steve Callender in LP1027131, Syndetics added content is not
retrieving summary.html to be displayed in the catalog.

This change adds a function similar to toc/anotes to bring in summary data.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
7 years agoACQ: repair lineitem cancel-reason fleshing
Bill Erickson [Tue, 4 Dec 2012 16:04:08 +0000 (11:04 -0500)]
ACQ: repair lineitem cancel-reason fleshing

When fetching lineitems for display in the general lineitem list page,
if the lineitem is cancelled, be sure we correctly retrieve the
cancel-reason object.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoStamping upgrade script for frozen holds clear expire time
Ben Shum [Tue, 18 Dec 2012 06:00:07 +0000 (01:00 -0500)]
Stamping upgrade script for frozen holds clear expire time

Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP1076399: Prevent reactivated holds from expiring immediately.
Jason Stephenson [Wed, 14 Nov 2012 18:41:37 +0000 (13:41 -0500)]
LP1076399: Prevent reactivated holds from expiring immediately.

Clear the expire_time on deactivated holds.

Recalculate the expire_time when a hold is reactivated.

Upgrade script to set expire_time to NULL on frozen action.hold_requests.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoResolve LP893448: Prevent hold expiration in past.
Jason Stephenson [Wed, 14 Nov 2012 16:49:49 +0000 (11:49 -0500)]
Resolve LP893448: Prevent hold expiration in past.

If a hold is placed with an expiration date in the past, the
expire_time of the hold will be reset using the hold expiration
interval settings.

Likewise, if a hold is changed to have an expiration date in the
past, the hold expiration date will be recalculated using the
hold expiration interval settings.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoAdd calculate_expire_time helper function to Holds.pm.
Jason Stephenson [Wed, 14 Nov 2012 16:27:53 +0000 (11:27 -0500)]
Add calculate_expire_time helper function to Holds.pm.

This new function calculates an expire_time for a hold based on the hold
expiration interval setting for a passed in org_unit. If the setting is found
the interval is added to "now" and returned as an ISO8601 string. undef is
returned if the setting is not found for the org_unit or its ancestors.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoAdd datecmp to OpenILS::Application::AppUtils.
Jason Stephenson [Wed, 14 Nov 2012 15:40:35 +0000 (10:40 -0500)]
Add datecmp to OpenILS::Application::AppUtils.

datecmp is a handy subroutine for comparing two DateTime objects or string
represenations. It returns -1, 0, and 1, much like the perl cmp operator.

If only 1 date is specified, then it will be compared to DateTime->now.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoFix foreign character display in receipts
Dan Wells [Tue, 6 Nov 2012 21:32:23 +0000 (16:32 -0500)]
Fix foreign character display in receipts

This commit makes two changes to the staff client print code to
help with the proper display of foreign characters:

1) Specify the utf-8 charset in the receipt Data URIs.
2) Properly encode the entire data string using encodeURIComponent
rather than encode().  Failing to do so was causing XULRunner to
be "creative" with the interpretation of the data.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoStamping upgrade script for hold request email notify default false
Ben Shum [Tue, 18 Dec 2012 05:12:38 +0000 (00:12 -0500)]
Stamping upgrade script for hold request email notify default false

Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP#1047475 Set action.hold_request.email_notify to default to false
Michael Peters [Thu, 13 Sep 2012 20:28:04 +0000 (16:28 -0400)]
LP#1047475 Set action.hold_request.email_notify to default to false

LP#1047475 points out that email notify prefs are ignored in TPAC.
Even if a patron deselects email notify during hold request time, it
will always be set to true due to the column default.

This change defaults the column in the database to false (like most
other similar columns are) and resolves the bug.

Credit to Steve Callender for the idea.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP: #1086064 Ignore spaces in opac username/barcode entry field
Dan Pearl [Tue, 11 Dec 2012 15:13:41 +0000 (10:13 -0500)]
LP: #1086064  Ignore spaces in opac username/barcode entry field

Too often, patrons copy the spacing on the barcode on their keytag,
or enter a spurious space before entering their name/barcode. This
change will remove spaces in their name/barcode.

(For now, keep the login screen's directions to omit spaces when
entering the username/barcode.)

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoHighlight selected facets over multiple lines
Dan Scott [Tue, 4 Dec 2012 15:08:36 +0000 (10:08 -0500)]
Highlight selected facets over multiple lines

As reported by Dan Pearl in LP# 1086150, selected facets that wrap over
multiple lines only have the first line highlighted. Which is odd, and
easily fixed with a small tweak to the CSS.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoUse uri_escape_utf8 in EGCatLoader/Record.pm.
Jason Stephenson [Tue, 30 Oct 2012 17:07:21 +0000 (13:07 -0400)]
Use uri_escape_utf8 in EGCatLoader/Record.pm.

To avoid this:

[Tue Oct 30 12:34:36 2012] [error] [client 134.241.121.11] egweb: Context
Loader error: Can't escape \\x{02B9}, try uri_escape_utf8() instead at
/usr/local/share/perl/5.14.2/OpenILS/WWW/EGCatLoader/Record.pm line 472 \n,
referer: http://catalog.mvlc.org/eg/opa c/results?fi%3Aitem_type=&query=
zhenshchiny&qtype=keyword&locg=1

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP#1088868: Column sort popup menu has no background style
Pasi Kallinen [Thu, 13 Dec 2012 08:00:43 +0000 (10:00 +0200)]
LP#1088868: Column sort popup menu has no background style

Change the menu from "popup" element to "menupopup", as per tsbere's suggestion.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoSupport barcode autocompletion in copy buckets
Thomas Berezansky [Thu, 9 Feb 2012 21:37:48 +0000 (16:37 -0500)]
Support barcode autocompletion in copy buckets

By request of our staff, who are lazy.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP#1084161 KPAC: Added Content Tabs can be too wide
Michael Peters [Wed, 28 Nov 2012 17:45:02 +0000 (12:45 -0500)]
LP#1084161 KPAC: Added Content Tabs can be too wide

In cases where LOTS of added content might be available, the
record summary is not wide enough to fit all of the tabs.

This decreases their padding width to fit them comfortably.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoLP#1090385 Fix success message for copy template deletion
Michael Peters [Mon, 17 Dec 2012 14:10:19 +0000 (09:10 -0500)]
LP#1090385 Fix success message for copy template deletion

We were displaying the "confirm" message twice, instead of the
existing "success" message.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoI18N: Make everything in tt2 files translatable.
Dan Scott [Sun, 16 Dec 2012 08:20:49 +0000 (03:20 -0500)]
I18N: Make everything in tt2 files translatable.

Simply wrap everything that should be translatable inside l().
Also fixes bug #1088388

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Conflicts:
Open-ILS/src/templates/acq/common/li_table.tt2
Open-ILS/src/templates/acq/invoice/view.tt2
Open-ILS/src/templates/acq/search/unified.tt2
Open-ILS/src/templates/vandelay/inc/item_attrs.tt2

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoJava IDL parser supports isnew/ischanged/isdeleted
Bill Erickson [Thu, 5 Apr 2012 13:36:31 +0000 (09:36 -0400)]
Java IDL parser supports isnew/ischanged/isdeleted

Includes changes to TestIDL.java for verification.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoAdd Java *.class files to gitignore
Bill Erickson [Fri, 24 Feb 2012 21:37:07 +0000 (16:37 -0500)]
Add Java *.class files to gitignore

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoJava IDL parser updated to use derived field array index
Bill Erickson [Fri, 24 Feb 2012 21:33:58 +0000 (16:33 -0500)]
Java IDL parser updated to use derived field array index

The "array_position" IDL attribute is deprecated.  Determine the
index by field position within the XML.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoFix OSRF_HOME and EXT in Open-ILs/src/java/Makefil.am.
Jason Stephenson [Wed, 31 Oct 2012 17:25:04 +0000 (13:25 -0400)]
Fix OSRF_HOME and EXT in Open-ILs/src/java/Makefil.am.

Change the paths so that they work.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoUpdate Java dependencies.
Jason Stephenson [Tue, 30 Oct 2012 21:10:42 +0000 (17:10 -0400)]
Update Java dependencies.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoAcq: When invoice-building with embedded search, allow control of results list
Lebbeous Fogle-Weekley [Fri, 5 Oct 2012 22:42:11 +0000 (18:42 -0400)]
Acq: When invoice-building with embedded search, allow control of results list

Previously, a results list could accumulate under inconsistent
conditions.  You'd get an accumulating results list if you were pressing
enter after successful searches, but your results lists would clear if
you actually clicked the Search button.  Worse, searches yielding empty
result sets would *appear* to clear your result list, but subsequent
sucessful searches would restore what was there before.

This is the "missing commit" that makes the behavior consistent and
togglable.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoLP#1058321: Acq: Possible to receive a pending purchase order
Mark Cooper [Wed, 24 Oct 2012 05:02:38 +0000 (22:02 -0700)]
LP#1058321: Acq: Possible to receive a pending purchase order

Revised to allow a cancelled PO to be received, as this is needed under
certain conditions (note - bib/items are not restored in this case).
Added po_state variable to avoid repeated PO.state() function invocations.

Signed-off-by: Mark Cooper <markchristophercooper@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoLP#1058321: Possible to receive a pending purchase order
Mark Cooper [Tue, 16 Oct 2012 01:03:44 +0000 (18:03 -0700)]
LP#1058321: Possible to receive a pending purchase order

Restrict 'Mark purchase order as received' to on-order state
purchase orders, and 'Un-Receive Purchase Order' to 'received'
POs. Otherwise inconsistencies easily occur ...

Signed-off-by: Mark Cooper <markchristophercooper@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoAutoFieldWidget support external copy loc retrieval
Bill Erickson [Fri, 28 Sep 2012 19:48:22 +0000 (15:48 -0400)]
AutoFieldWidget support external copy loc retrieval

When rendering a collection of copy locations, AFW fetches locations
relevant to the context org unit.  While rendering an AFW for an
existing object, though, whose copy location is outside of that scope,
the code will now append the non-local copy location to the selector and
tag it with the owning lib (to avoid dupes).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoACQ order upload use copy location from owner
Bill Erickson [Fri, 28 Sep 2012 19:00:37 +0000 (15:00 -0400)]
ACQ order upload use copy location from owner

When uploading an ACQ MARC order record, attempt to match copy locations
to copies based on the copy owning location instead of the upload
context org unit.  This allows one branch to order copies for another
and have the copies use the copy location of the other (owning) branch
(when they exist) instead of the ordering branch (or parent org).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoUse consistent language for holdings/items profiles in Vandelay. Now
Mark Cooper [Wed, 5 Dec 2012 21:11:23 +0000 (13:11 -0800)]
Use consistent language for holdings/items profiles in Vandelay. Now
uses "Holdings Import Profiles" as standard.

Signed-off-by: Mark Cooper <markchristophercooper@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agolp1010187 eliminate redundant/unnecessary calls
Jason Etheridge [Wed, 20 Jun 2012 15:47:54 +0000 (11:47 -0400)]
lp1010187 eliminate redundant/unnecessary calls

Particularly invocations of open-ils.circ.stat_cat.asset.retrieve.all in the
Item Attribute Editor

To test:

    login with a BR1 workstation
    load a pristine (non-stat-cat-laden) BR1 item with the editor
    there should be no call to open-ils.circ.stat_cat.asset.retrieve.all
    change the Circ Lib on the item to BR4
    reload the item in the editor
    there should be a call to open-ils.circ.stat_cat.asset.retrieve.all
    reload the item in the editor
    there should be no call to open-ils.circ.stat_cat.asset.retrieve.all
    assign the item a stat cat entry owned by CONS
    reload the item in the editor
    there should be no call to open-ils.circ.stat_cat.asset.retrieve.all

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoPatch to improve the warning on double checkout attempt
edoceo [Wed, 25 Jul 2012 09:00:55 +0000 (02:00 -0700)]
Patch to improve the warning on double checkout attempt

Code modifications by David Busby of Edoceo for KCLS
Released without restriction to Evergreen community
Signed-off-by: edoceo <code@edoceo.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agomod_perl expects child_init return values
Thomas Berezansky [Wed, 11 Apr 2012 17:26:42 +0000 (13:26 -0400)]
mod_perl expects child_init return values

So add in Apache2::Const::OK returns on all of them.

[LFW: Added the same change to AutoSuggest.pm for consistency's sake.]

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoAllow 'Enter' key to run Verify Credentials user check
edoceo [Thu, 8 Nov 2012 04:08:27 +0000 (20:08 -0800)]
Allow 'Enter' key to run Verify Credentials user check

In both the "Verify Credentials" menu and "Test Password" patron account
option, this change checks for the keypress of "Enter" and then executes
the cmd_verify routine.

Additionally, the password field is blanked after each attempt.

Signed-off-by: edoceo <code@edoceo.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoAcq: Yet more efforts to sanitize data for the EDI translator
Lebbeous Fogle-Weekley [Fri, 23 Mar 2012 02:21:36 +0000 (22:21 -0400)]
Acq: Yet more efforts to sanitize data for the EDI translator

I specifically did this to address cases reported to me by Galen
Charlton in which get_li_attr_jedi() would return the string "nul", but
I hope this is a nail in the coffin for problems involving
JEDI-producing Action/Trigger templates feeding the EDI translator
strings that the latter doesn't like.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoMake the acquisitions setup show up in the manual
Dan Scott [Sun, 9 Dec 2012 05:36:08 +0000 (00:36 -0500)]
Make the acquisitions setup show up in the manual

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoAdd acquisitions setup chapter
Dan Scott [Sun, 9 Dec 2012 05:30:29 +0000 (00:30 -0500)]
Add acquisitions setup chapter

Another product of the Evergreen in Action documentation sprint!

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoAdd the "Importing via the staff client" chapter
Dan Scott [Sun, 9 Dec 2012 00:55:24 +0000 (19:55 -0500)]
Add the "Importing via the staff client" chapter

... from the Evergreen In Action doc sprint.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoRoll in some Evergreen in Action chapters
Dan Scott [Sat, 8 Dec 2012 23:36:12 +0000 (18:36 -0500)]
Roll in some Evergreen in Action chapters

For the initial import we're keeping the formatting and words identical,
so that we can manually sycnhronize changes as needed between the FLOSS
Manuals version of this documentation and the AsciiDoc version.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoAdd a target ID to fix the epub transform
Dan Scott [Sat, 8 Dec 2012 23:37:51 +0000 (18:37 -0500)]
Add a target ID to fix the epub transform

Commit a850606073 added a link pointing to this ID, but the target ID
did not exist, breaking the epub transform. Now it works again.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoDocumentation: Add sections to workstation admin chapter.
BC Libraries Cooperative [Fri, 30 Nov 2012 16:10:39 +0000 (11:10 -0500)]
Documentation: Add sections to workstation admin chapter.

Content from:
http://docs.sitka.bclibraries.ca/Sitka/current/html/intro_start_workstation_admi$

Receipt template editor sections moved to this chapter.
Converted to asciidoc by rsoulliere. Index terms added by rsoulliere
Some duplicate images were also removed from media directory.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoDocumentation: Add workstation administration chapter.
BC Libraries Cooperative [Thu, 29 Nov 2012 20:39:57 +0000 (15:39 -0500)]
Documentation: Add workstation administration chapter.

Content from: http://docs.sitka.bclibraries.ca/Sitka/current/html/intro_start_workstation_admin.html
Converted to asciidoc by rsoulliere.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoFix misspelling of "summary" in KPAC Added Content
Michael Peters [Wed, 28 Nov 2012 17:36:10 +0000 (12:36 -0500)]
Fix misspelling of "summary" in KPAC Added Content

Summary != Smmary

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoDocumentation: Add staff client login chapter.
Robert Soulliere [Thu, 29 Nov 2012 15:43:28 +0000 (10:43 -0500)]
Documentation: Add staff client login chapter.

Included standalone interface and loggin out information as well as
a few index terms.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoDocumentation: Add chapter on staff client installation.
Robert Soulliere [Wed, 28 Nov 2012 16:36:54 +0000 (11:36 -0500)]
Documentation: Add chapter on staff client installation.

Also included information on removing staff client preferences
(from EG wiki) and registering workstations.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoKPAC - add shelving location to copy table display
Melissa Lefebvre [Tue, 27 Nov 2012 18:35:42 +0000 (13:35 -0500)]
KPAC - add shelving location to copy table display

Addition of shelving location information to the display along with the
removal of broken "view library info" javascript link.

Signed-off-by: Melissa Lefebvre <mlefebvre@biblio.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoKPAC - fix getit_results with short titles
Ben Shum [Wed, 21 Nov 2012 19:17:59 +0000 (14:17 -0500)]
KPAC - fix getit_results with short titles

When using the "Get it" options to either add an item to a list or place an
item on hold, one would get an internal server error whenever attemping this
on a bib record with a short title.

Turns out that the substr function that shortens the length of long titles
breaks when the title is 18 characters or less.

Add an IF check around the substr function to avoid this error.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
8 years agoKPAC - fix Get It and pickup library selector
Ben Shum [Mon, 19 Nov 2012 22:34:33 +0000 (17:34 -0500)]
KPAC - fix Get It and pickup library selector

Change PROCESS to INCLUDE to prevent variable leaks from breaking
the pickup library selector's values.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
8 years agoLP#1082260: Update OPAC low search hits template for i18n
Pasi Kallinen [Tue, 27 Nov 2012 10:39:02 +0000 (12:39 +0200)]
LP#1082260: Update OPAC low search hits template for i18n

The OPAC lowhits.tt2 template is only partially translatable,
and the translatable part is impossible to make sound good
for languages with different word order than English.

This patch changes the already translatable part so there
are 4 different phrases to translate (instead of two phrase
fragments), and makes the search hints translatable.

For English language, the patch does not introduce any visible differences.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoFix typo in docs/opac/search_form.txt
Michael Peters [Tue, 27 Nov 2012 14:31:32 +0000 (09:31 -0500)]
Fix typo in docs/opac/search_form.txt

Creating a simple search for kpac should link to "kpac"
not "tpac" which won't exist.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
8 years agoFix lp1076379: Can't edit holds beyond first page.
Jason Stephenson [Thu, 8 Nov 2012 20:09:09 +0000 (15:09 -0500)]
Fix lp1076379: Can't edit holds beyond first page.

When a hold was being edited on page 2+ of a patron's list of holds, the
offset was > 0. Since the input hold_ids array ref has only 1 member, using
the offset as a starting point in searching began the search beyond the end
of the array and thus returned nothing.

The code in this commit moves the handling of the offset and limit to cases
where the input hold_ids is undefined, as this is, I think the intended
behavior. Typically when hold_ids is passed to the fetch_user_holds function
in EGCatLoader::Account, you want to retrieve those holds regardless of
the offset and limit values.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoRepair syntax on line 559 of Holds.pm
Jason Stephenson [Thu, 8 Nov 2012 16:32:06 +0000 (11:32 -0500)]
Repair syntax on line 559 of Holds.pm

A change was introduced when listing available holds that has incorrect JSON
syntax. This caused available holds not to be returned by the query.

Changing '+ahr' to '=' in the query resolves this.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoDocumentation: Fix some typos in upgrade instructions.
Robert Soulliere [Mon, 26 Nov 2012 15:17:53 +0000 (10:17 -0500)]
Documentation: Fix some typos in upgrade instructions.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoTest data: avoid crazy transactions for expired patrons
Dan Scott [Wed, 21 Nov 2012 16:37:06 +0000 (11:37 -0500)]
Test data: avoid crazy transactions for expired patrons

Rather than creating brand new circ transactions for patrons who expired
in 1999, make things a little more realistic by filtering out the
patrons to those whose account expired in the past month or later, and
creating xact_start / due_date values based on their account expiry
date if expired, or NOW() if still active.

Oh, and add some patrons who expired over the past month. :)

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoSample data: enable loading via eg_db_config.pl
Dan Scott [Sun, 11 Nov 2012 23:32:44 +0000 (18:32 -0500)]
Sample data: enable loading via eg_db_config.pl

Add "--load-concerto-sample" and "--load-all-sample" options to the
eg_db_config.pl script so that would-be testers can create the database
and load sample data on it in one easy step.

Add a release notes entry.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoConcerto test data: realistic call numbers
Dan Scott [Sun, 11 Nov 2012 15:48:55 +0000 (10:48 -0500)]
Concerto test data: realistic call numbers

Add a parameter to the populate call number function so that we can define the
call number class. As a result, create a new 3-parm version of the function
that simply calls the 4-parm version with a NULL value for the 3rd parm.

Use some realistic LC and Dewey call numbers for the "concerto" bibs so
that we can have more useful tests of the call number browse functionality.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoExpand and modularize concerto data set
Bill Erickson [Sat, 13 Oct 2012 16:28:29 +0000 (12:28 -0400)]
Expand and modularize concerto data set

* Break function creation and deletion out to their own files.
* Translates lul_fre_100 bibs into SQL
* adds a load_all.sql file for loading all test data
* moves all test data sql to its own dir
* creates a backward-compat concerto.sql loader
* ensure that most users are not already expired
* Adds a 'tag' column to marcxml_import, which populates last_xact_id on
  import.  This 'tag' is useful for differentiating which records to link
  callnumbers to.
* Adds an 'id' column to marcxml_import to ensure insert-order inserts
  into biblio.record_entry
* Adds a handful of copies for french records
* Adds supporting functions for creating circ/hold test data.
* creates a pile of sample circ and hold data
* Give most users NULL dobs and suffixes.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTweak wording of patron account expiry warning
Dan Scott [Wed, 21 Nov 2012 14:24:09 +0000 (09:24 -0500)]
Tweak wording of patron account expiry warning

A warning is something that comes in advance of an event, so a
pre-warning would be a warning about the warning, which is a bit weird.
Hopefully this language will be a little simpler and easier for users to
understand.

Also, fetch the value of the setting once and stuff it in a variable;
vars are cheap and things might be a little more legible.

Also, add a release note entry for the new feature.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoWrap upgrade script for patron expiry warning
Dan Scott [Wed, 21 Nov 2012 12:08:04 +0000 (07:08 -0500)]
Wrap upgrade script for patron expiry warning

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoAdd library setting to control pre-expire warning for patrons
Ben Shum [Wed, 14 Nov 2012 18:30:11 +0000 (13:30 -0500)]
Add library setting to control pre-expire warning for patrons

Thanks to some more inspiration by Thomas Berezansky, this change adds a
library setting to control when the pre-expire warning will be displayed.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoWarn on card expiring within 28 days
Michael Peters [Thu, 8 Nov 2012 19:14:42 +0000 (14:14 -0500)]
Warn on card expiring within 28 days

Thank you to Thomas Berzansky for pointing out a simple way of
accomplishing this, since we were already checking and alerting
if card was already expired.

This places an alert on the "stop sign" page if the card expires
within 28 days from the current date.

Interval can be configured by editing preexpire.setDate in display.js.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoDocs: Add offline circulation basics
Dan Scott [Mon, 19 Nov 2012 20:55:34 +0000 (15:55 -0500)]
Docs: Add offline circulation basics

Based heavily on the documentation from Evergreen 1.6, which was in turn
based heavily on the Sitka documentation for offline mode, add some
coverage of the offline processes for registering patrons, checking
items in and out, renewing items, and uploading & processing
transactions.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoMake the "user account expired" warning i18n-friendly
Dan Scott [Fri, 16 Nov 2012 21:01:10 +0000 (16:01 -0500)]
Make the "user account expired" warning i18n-friendly

The warning message is now capable of being translated, and we're
formatting of the date consistently with other uses throughout the TPAC.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoAdd card expired message to the myopac account summary
Justin Hopkins [Mon, 30 Jul 2012 22:25:20 +0000 (17:25 -0500)]
Add card expired message to the myopac account summary

The JSPAC included a message to users who had an expired card alerting them to this fact.
This message is useful and was not writted into the TPAC.

Signed-off-by: Justin Hopkins <hopkinsju@gmail.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoSet eg_version at start of 2.2 upgrade scripts
Dan Scott [Thu, 27 Sep 2012 03:47:26 +0000 (23:47 -0400)]
Set eg_version at start of 2.2 upgrade scripts

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoApply the 0715 update for acq settings_group
Dan Scott [Thu, 27 Sep 2012 03:25:53 +0000 (23:25 -0400)]
Apply the 0715 update for acq settings_group

We add the 'acq' config.settings_group in the seed data, and add the
other settings groups in the 2.1-2.2 upgrade script, but need to add the
acq settings_group to the 2.1-2.2 upgrade script.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoAfter upgrade, list records with missing or incorrect 901$c
Galen Charlton [Thu, 27 Sep 2012 03:34:32 +0000 (23:34 -0400)]
After upgrade, list records with missing or incorrect 901$c

This is a common cause of pain for upgrades. Let's try to identify the
problem early (even if it takes forever on a site with 3 million bibs)
and offer advice on correcting the problem if it is flagged.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agorel_2_1 does not have a config.upgrade_log.applied_to column
Dan Scott [Thu, 13 Sep 2012 16:47:32 +0000 (12:47 -0400)]
rel_2_1 does not have a config.upgrade_log.applied_to column

Thanks to Michael Peters for running into & reporting this problem when
attempting to upgrade from 2.1.2 to 2.1.3!

Fix the version upgrade script.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoDocumentation: Grammar fix on upgrade instructions.
Robert Soulliere [Wed, 14 Nov 2012 18:38:09 +0000 (13:38 -0500)]
Documentation: Grammar fix on upgrade instructions.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoDocumentation: Specify that Apache files should be updated as root.
Robert Soulliere [Wed, 14 Nov 2012 18:35:17 +0000 (13:35 -0500)]
Documentation: Specify that Apache files should be updated as root.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoDocumentation: Update upgrade instructions for 2.3.1
Robert Soulliere [Wed, 14 Nov 2012 18:18:01 +0000 (13:18 -0500)]
Documentation: Update upgrade instructions for 2.3.1

Fleshed out the Apache instructions with more precise cp commands.
I find this helpful since I like to copy and paste the commands.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoStamping upgrade script for lost xact_finish opt.
Dan Wells [Tue, 13 Nov 2012 20:45:07 +0000 (15:45 -0500)]
Stamping upgrade script for lost xact_finish opt.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
8 years agoAddress Launchpad Bug 793550.
Jason Stephenson [Sat, 3 Nov 2012 16:04:34 +0000 (12:04 -0400)]
Address Launchpad Bug 793550.

Check for stop fines reason of CHECKIN or RENEW before closing a circulation
transaction when the balance reaches zero.

Also, if the stop fines reason is LOST, then check a new ou setting,
circ.lost.xact_open_on_zero, to determine if the transaction is closed or
kept open.  The setting is checked for the circulation copy's circ_lib.

Add CircCommon->can_close_circ.

Following up on Dan Wells' comments on Launchpad Bug 793550, I have moved
the logic to check if the circ transaction can be closed to its own utility
function in OpenILS::Application::Circ::CircCommon.  This potentially
consolidates the logic in one place in case we need to use it elsewhere.

Instead of checking for stop fines reasons of CHECKIN and RENEW and
checking for checkin time on the circ, we just check for checkin time.
Both CHECKIN and RENEW should set the checkin time.

Also, use the constant for stop fines reason of LOST, rather than the
literal string "LOST".

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
8 years agoNo need for vanity info in OpenSRF article
Dan Scott [Mon, 12 Nov 2012 16:46:21 +0000 (11:46 -0500)]
No need for vanity info in OpenSRF article

We don't credit particular authors in the Evergreen docs, and we don't
want to dissuade contributors from improving & evolving any particular
section of the docs, so get rid of a hangover attribution from the
OpenSRF article.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoAdd "Intro to OpenSRF" to development section
Dan Scott [Mon, 12 Nov 2012 16:32:31 +0000 (11:32 -0500)]
Add "Intro to OpenSRF" to development section

We have the Asciidoc source, so let's drop it into place. Triggered by a
request for info on OpenSRF development on IRC that was answered with
"we don't really have much information on that" response. *Poof*, now
we have some.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoDocs: resolve transform errors and warnings
Dan Scott [Mon, 12 Nov 2012 16:28:58 +0000 (11:28 -0500)]
Docs: resolve transform errors and warnings

ePub really doesn't like absolute references to images - which is good,
it shouldn't. Also, single line NOTE blocks are much easier to deal with
using the prefix approach (and don't generate warnings during normal
HTML generation).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoDocumentation: Fix small typo in 2.3 release notes. s/how/now.
Remington Steed [Mon, 12 Nov 2012 16:10:31 +0000 (11:10 -0500)]
Documentation: Fix small typo in 2.3 release notes. s/how/now.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoDocumentation: Fix some broken links and adjust an image in the
Robert Soulliere [Mon, 12 Nov 2012 15:36:09 +0000 (10:36 -0500)]
Documentation: Fix some broken links and adjust an image in the
Acquistions Admin chapter as pointed out by Remington Steed.

Added anchors, pointed links to "Line Item Features" and changed
wording accordingly. I cropped image and use a red box for highlighting.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
8 years agoAdd translation update info back into official docs
Dan Scott [Mon, 12 Nov 2012 14:17:05 +0000 (09:17 -0500)]
Add translation update info back into official docs

This disappeared in the 2.3 release for some reason; let's get it back.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoDocumentation: Update upgrade instructions to 2.3.0.
Robert Soulliere [Wed, 3 Oct 2012 17:21:57 +0000 (13:21 -0400)]
Documentation: Update upgrade instructions to 2.3.0.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoDocumentation: update upgrade instructions to 2.3.beta2.
Robert Soulliere [Thu, 23 Aug 2012 17:07:24 +0000 (13:07 -0400)]
Documentation: update upgrade instructions to 2.3.beta2.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agomake_release: add the \set eg_version command to upgrade script
Dan Scott [Wed, 7 Nov 2012 17:55:49 +0000 (12:55 -0500)]
make_release: add the \set eg_version command to upgrade script

We were echoing the output to STDOUT instead of redirecting it to the
upgrade script that we were generating. Let's go the last mile and
actually get it into the upgrade script.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoMake it possible to suppress IDL fields
Mike Rylander [Wed, 10 Oct 2012 21:36:52 +0000 (17:36 -0400)]
Make it possible to suppress IDL fields

Some clients of external services, particularly pcrud and reporter-store,
need to be able to access tables that contain columns we'd rather restrict.
For instance, the passwd field on actor.usr.

To effect this feature we provide a blacklist attribute for fields, called
suppress_controller, which works in the same way as the class controller
attribute but names controllers not allowed to use the field.  When the field
is explicitly named in a query (fieldmapper select block or json_query) an
error is thrown, and suppressed fields are ingored in general fieldmapper
search/retreive requests.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoMove 'initial host' feature docs into 2.3 release notes
Bill Erickson [Tue, 6 Nov 2012 20:28:28 +0000 (15:28 -0500)]
Move 'initial host' feature docs into 2.3 release notes

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoCStoreEditor auto-activity log redaction
Bill Erickson [Fri, 2 Nov 2012 19:28:27 +0000 (15:28 -0400)]
CStoreEditor auto-activity log redaction

CStoreEditor logs all update calls to the activity log as key/value
pairs on the updated object.  Avoid loging key/value pairs for objects
when the API call being relayed by CStoreEditor is on the list of
log-protect API calls.  Instead, log "**DETAILS REDACTED**".

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoDocument log redaction XML chunk for opensrf_core.xml
Dan Scott [Tue, 6 Nov 2012 03:14:34 +0000 (22:14 -0500)]
Document log redaction XML chunk for opensrf_core.xml

Based on Bill Erickson's original version.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoAdd sample log redaction config to EG opensrf_core
Bill Erickson [Wed, 31 Oct 2012 13:00:19 +0000 (09:00 -0400)]
Add sample log redaction config to EG opensrf_core

Redact parameter logging for the following API calls:

Login:
open-ils.auth.authenticate.verify
open-ils.auth.authenticate.complete
open-ils.auth_proxy.login

User updates:
open-ils.actor.user.password
open-ils.actor.user.username
open-ils.actor.user.email
open-ils.actor.patron.update
open-ils.cstore.direct.actor.user.create
open-ils.cstore.direct.actor.user.update
open-ils.cstore.direct.actor.user.delete

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoStaff client initial hostname
Thomas Berezansky [Thu, 2 Aug 2012 17:28:44 +0000 (13:28 -0400)]
Staff client initial hostname

Add support for an initial staff client hostname.

It can be specified during building the staff client or via configure.

During making the staff client:

make INITIAL_HOST=hostname build

During configure:

./configure --with-initialhost=hostname

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoTPAC: Address some search syntax leaks in links
Dan Scott [Thu, 11 Oct 2012 04:56:40 +0000 (00:56 -0400)]
TPAC: Address some search syntax leaks in links

Expand the list of filtered characters to cover all of the special
characters documented for the Evergreen search grammar
(http://evergreen-ils.org/dokuwiki/doku.php?id=documentation:technical:search_grammar)
when generating links in the TPAC so as to avoid inadvertently launching
filtered searches when a user clicks on something that should just be a
display value.

For example, if a title includes "Presenting a subject: tips for
consultants", it should _not_ launch a search for "subject" containing
"tips for consultants".

This commit addresses most of the link problems in the record
display, as well as the author links in the search results table.

Still problematic are the facets (which seem to rely on exact matching,
such that filtering out the problematic characters is itself
problematic) and autocomplete (which requires modifying the Autocomplete
Dojo widget).

In addition, this commit makes the series code actually display, as it
was using a non-standard method to attempt to return the results from
the BLOCK (and failing). Also, it makes the links for authors in the
record details match the MODS32 definition for personal name parts and
only use the "acdq" subfields. This enables a click on the link to
actually return results; previously, in the case where the author field
included (for example) a subfield "g" value, that value would be
included in the generated link and would likely lead to 0 hits.

For authors, we substitute with a space rather than just eliding the
substituted value. Authors are particularly likely to have dates like
1899-1978; "1899 1978" matches, but "18991978" will not.

Perhaps we should take the same approach with the others, or break down
the search/replace logic a little further (for example, we could remove
the "-" only if it is preceded by a space or is at the start of the
string and is followed immediately by a character, and preserve it if it
is surrounded by digits). But this seems to take us pretty far down the
road of less negatively surprising results.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoTPAC: Add search torture tests to concerto record
Dan Scott [Thu, 11 Oct 2012 03:35:13 +0000 (23:35 -0400)]
TPAC: Add search torture tests to concerto record

In addition to # signs causing problems in facets, we found that search
syntax in general is surfaced directly in most links that are exposed to
users in the TPAC. This commit adds several examples to the record with
the title "Trombone concerto (1991)":

In the title, there is an embedded "subject:" search which will be
triggered by autocomplete.

In the author (100 field), there is an embedded "author:" search which
will be triggered from the record details page. This also includes
another usage of the # sign.

In the subject fields, there are:
  * an embedded "subject:" search which will be triggered from the
    facets, autocomplete, and record details page
  * an embedded negation operator which will be triggered from the
    facets, autocomplete, and record details page

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoMunge concerto to include # signs in series facets
Dan Scott [Wed, 10 Oct 2012 19:50:49 +0000 (15:50 -0400)]
Munge concerto to include # signs in series facets

Search for "Piano concerto in C major, op. 39" or "Beethoven: concertos
and overtures" and you'll get facets with # signs to assist with fixing
LP # 856811.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoAdd tsearch2 removal upgrade script
Thomas Berezansky [Thu, 25 Oct 2012 23:51:44 +0000 (19:51 -0400)]
Add tsearch2 removal upgrade script

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoAdd support for PostgreSQL 9.2, drop TSearch2 extension
Dan Scott [Sat, 22 Sep 2012 20:35:43 +0000 (16:35 -0400)]
Add support for PostgreSQL 9.2, drop TSearch2 extension

The TSearch2 extension hasn't been needed for a long time, and it causes
problems trying to use ts_rewrite(TSQUERY, TEXT) at least.

Add a full text search config script for PostgreSQL 9.2.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoAvoid specific version mention for database extensions
Dan Scott [Sun, 23 Sep 2012 01:51:59 +0000 (21:51 -0400)]
Avoid specific version mention for database extensions

As tsbere pointed out, the 9.1 database script will be used for every
version after 9.1... which makes it confusing to have a version number.
As the primary reason for the difference is the switch to extensions
instead of contrib modules, use a name that flags that difference.

Convert the 9.1 full-text search configuration into a symbolic link
instead of maintaining a separate copy of the file.

Given that the pre-9.1 database script was focused on the creation of
PostgreSQL contribs, call it that, rather than the (now confusingly)
generic "create_database.sql" that existed from a time when contribs
ruled the earth and extensions were mere fantasy.

Adjust eg_db_config.sql for these changes as well - including the
command line switches.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>