working/Evergreen.git
8 years agoAdd class_for_hint function to OpenILS::Utils::Fieldmapper.
Jason Stephenson [Sun, 11 Dec 2011 01:28:48 +0000 (20:28 -0500)]
Add class_for_hint function to OpenILS::Utils::Fieldmapper.

Use this function to find a Fieldmapper class from the JSON hint or
class id:

my $class = Fieldmapper::class_for_hint('au');
print("$class\n");

Will print:

Fieldmapper::actor::user

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoLP904915 Restore call number columns
Jason Etheridge [Thu, 15 Dec 2011 19:38:54 +0000 (14:38 -0500)]
LP904915 Restore call number columns

in Check In interface

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoturn objects (such as null) into empty strings
Jason Etheridge [Thu, 15 Dec 2011 15:28:33 +0000 (10:28 -0500)]
turn objects (such as null) into empty strings

when they're being treated as strings (with escape_html) during printing

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoLP# 902667 - Wrap upgrade script for Dewey sorting
Dan Scott [Fri, 16 Dec 2011 19:00:24 +0000 (14:00 -0500)]
LP# 902667 - Wrap upgrade script for Dewey sorting

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoFix Dewey call number sorting
James Fournie [Sun, 11 Dec 2011 00:49:01 +0000 (16:49 -0800)]
Fix Dewey call number sorting

Ported over Koha commit aef8358c - fix for Koha Bug 4265.
Further documented in Evergreen LP # 902667
Here's the description from the commit message by Magnus Enger:

C4::ClassSortRoutine::Dewey turns "306 Les" into "306_Les"
for items.cn_sort and MARC-field 952$6, which results in
"306.46 Les" being sorted before "306 Les" in the OPAC.
With this patch, "306 Les" is turned into "306_000000000000000_Les".

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoFix the POD in Cronscript.pm.in.
Jason Stephenson [Thu, 1 Dec 2011 20:05:12 +0000 (15:05 -0500)]
Fix the POD in Cronscript.pm.in.

I lied when I said it includes Data::Dumper, so you don't have to.
It does include Data::Dumper, but if you want to use Data::Dumper
in your script, you still have to use Data::Dumper.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoMake some improvements to Cronscript.pm.
Jason Stephenson [Thu, 1 Dec 2011 17:38:55 +0000 (12:38 -0500)]
Make some improvements to Cronscript.pm.

Allow the session method to function when called more than once with
different service names.

Add some useful new methods:

logout: Calls open-ils.auth.session.delete if we're logged in.

die_event: Causes a script to croak if the object passed in is an event,
or optionally a certain named event.

warn_event: Causes a script to output an error message if the object passed
in is an event, or optionally a certain named event.

Use OpenILS::Application::AppUtils.

Default to staff login in Cronscript->authenticate method.

Improve the Croncript.pm.in POD to include a better synopsis of its features.

Clean up some other sections of the POD, remove the TODO section, and add
some SEE ALSO entries.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoTPAC: Assume that templates are encoded in UTF-8
Dan Scott [Sat, 10 Dec 2011 15:43:47 +0000 (10:43 -0500)]
TPAC: Assume that templates are encoded in UTF-8

Per http://template-toolkit.org/docs/faq/index.html
under "Why do I get rubbish for my utf-8 templates?", Template::Toolkit
does not assume that templates are encoded in UTF-8, which runs counter
to current assumptions circa 2011.

Practically, this means that before this change any UTF8 characters
used for purposes such as Unicode art or otherwise would be garbled in
the generated Web page. This commit tells Template::Toolkit to assume
that the templates are UTF8 without forcing us to monkey with byte-order
markers.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoAllow for the page offset when listing the "Result x of y" values.
bott [Wed, 14 Dec 2011 17:31:30 +0000 (12:31 -0500)]
Allow for the page offset when listing the "Result x of y" values.

The record details page did not show the page offset correctly, so
result 13 would show up as "Result 3 of ###", and result 23 would also
show up as "Result 3 of ###".

Signed-off-by: bott <bott@grpl.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoFix can_have_copies checks
Thomas Berezansky [Wed, 14 Dec 2011 19:30:52 +0000 (14:30 -0500)]
Fix can_have_copies checks

Bibs aren't required to have sources. Thus, adjust all appropriate locations
to support a default state of "no source bibs can have copies", without
erroring out.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoProcess still-shelved, canceled holds in clear-shelf process
Bill Erickson [Wed, 14 Dec 2011 18:36:05 +0000 (13:36 -0500)]
Process still-shelved, canceled holds in clear-shelf process

Holds that are canceled but still physically on the hold shelf are
processed like other holds during the clear-shelf process.  They will be
grouped in the same manner and if a custom post-clear status is
configured, copies linked to already-canceled holds will get the custom
status.  The only difference is already-canceled holds will not be
re-canceled during the clear-shelf process.

This change has the added benefit of leveraging another API call to
retrieve the shelf-expired holds instead of using its own custom
json-query.

See https://bugs.launchpad.net/evergreen/+bug/904332

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoClear hold shelf/shelf_expire time for pickup lib change
Bill Erickson [Tue, 13 Dec 2011 19:32:45 +0000 (14:32 -0500)]
Clear hold shelf/shelf_expire time for pickup lib change

If a hold is on the holds shelf and the pickup library changes, clear
the shelf_time and shelf_expire_time, since the hold is now in transit.

This is particularly important for avoiding action_trigger events for
the "hold_request.shelf_expires_soon" hook for what is now an
in-transit item.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoTPAC: Add prefixes and suffixes to call number displays
Dan Scott [Tue, 6 Dec 2011 07:16:16 +0000 (02:16 -0500)]
TPAC: Add prefixes and suffixes to call number displays

Call numbers can be associated with prefixes and suffixes meant for
display purposes; display these with the call numbers in search results
and record details.

Thanks to Lebbeous and Bill for the assist in sorting out the remaining
portion of the hairy json_query for the record display.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoMake canceled but still on the shelf holds show up
Thomas Berezansky [Tue, 11 Oct 2011 20:42:03 +0000 (16:42 -0400)]
Make canceled but still on the shelf holds show up

Browse Hold Shelf otherwise can't see holds canceled after the item was
placed on the shelf.

This also causes the expired view to show canceled but still in on the
hold shelf status holds to show up.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoStamping upgrade for LP898248: Address Alert
Thomas Berezansky [Wed, 14 Dec 2011 15:34:19 +0000 (10:34 -0500)]
Stamping upgrade for LP898248: Address Alert

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoAlert addresses for patron registration : UI
Bill Erickson [Fri, 9 Dec 2011 20:52:32 +0000 (15:52 -0500)]
Alert addresses for patron registration : UI

Add support for comparing user addresses to alert addresses.  When an
address is found, the address in question is styled (the header row
turns red) and the configured alert message is shown along the
top-right, where other warnings appear.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoAlert addresses for patron registration : API
Bill Erickson [Fri, 9 Dec 2011 20:51:49 +0000 (15:51 -0500)]
Alert addresses for patron registration : API

Middle-layer API call for matching addresses to alert addresses

open-ils.actor.address_alert.test(auth, orgid, fields)

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoAlert addresses for patron registration : configuration UI
Bill Erickson [Fri, 9 Dec 2011 15:43:28 +0000 (10:43 -0500)]
Alert addresses for patron registration : configuration UI

Conify UI for managing Alert Addresses

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoAlert addresses for patron registration : DB/IDL
Bill Erickson [Tue, 6 Dec 2011 21:09:16 +0000 (16:09 -0500)]
Alert addresses for patron registration : DB/IDL

DB and IDL components to support configuration of alert addresses.  The
target use case for alert addresses is in the patron registration
interface.  When a patron's address matches an alert address, the staff
should be notified.

Alert address fields are treated as regular expressions.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agojson_query boolean function param support
Bill Erickson [Tue, 13 Dec 2011 16:03:23 +0000 (11:03 -0500)]
json_query boolean function param support

Solves the following problem when passing boolean parameter values to
json_query functions using the 'from' construct.

E.g.  {"from" : ["some_func_name", true]}

oils_sql.c:2568 open-ils.cstore: Error quoting key string [(null)]

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoMerge remote-tracking branch 'working/collab/dbs/tpac-non-fixed-width'
Thomas Berezansky [Mon, 12 Dec 2011 17:25:36 +0000 (12:25 -0500)]
Merge remote-tracking branch 'working/collab/dbs/tpac-non-fixed-width'

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoTPAC: Remove more inline styles from results table collab/dbs/tpac-non-fixed-width
Dan Scott [Mon, 12 Dec 2011 05:44:34 +0000 (00:44 -0500)]
TPAC: Remove more inline styles from results table

Most of the inline styles are gone from the results table.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoRPAC: Remove one formatting row from results
Dan Scott [Mon, 12 Dec 2011 05:29:47 +0000 (00:29 -0500)]
RPAC: Remove one formatting row from results

One of the table rows was being inserted into every result simply to
provide a border that is better handled via CSS on the existing useful
elements. Begone.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPAC: results use floated DIVs instead of table layout
Dan Scott [Mon, 12 Dec 2011 05:06:39 +0000 (00:06 -0500)]
TPAC: results use floated DIVs instead of table layout

Rather than a table containing a single row for the rather gross purpose
of placing the facet sidebar on the left, a little bit of a divider
between the facets and the results, and the results on the right, just
use a floated div and a relatively positioned div for the two pertinent
chunks of content. Bonus: one touch of CSS moves the facet sidebar to
the right instead of the left.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPAC: Record details - inline style to classes
Dan Scott [Mon, 12 Dec 2011 04:37:02 +0000 (23:37 -0500)]
TPAC: Record details - inline style to classes

Continue the march towards no inline styles in the record details page.
Includes a small tweak for electronic resource display so that the
unordered list gains a bit of space on the left-hand side from the image
location.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPAC: Include Chilifresh conditionally user/dbs/tpac-non-fixed-width
Dan Scott [Mon, 12 Dec 2011 00:51:10 +0000 (19:51 -0500)]
TPAC: Include Chilifresh conditionally

Rather than including Chilifresh JavaScript and table cells
unconditionally, only include the Chilifresh calls if an account has
been defined in the Apache environment.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPAC: Fix styling in advanced searchbar
Dan Scott [Sun, 11 Dec 2011 22:40:39 +0000 (17:40 -0500)]
TPAC: Fix styling in advanced searchbar

Per Peter Lux's comment, we needed to fix the styling in the advanced
search bar. Marking the DIV id with "search-box" makes it consistent
with the searchbar in other interfaces.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPAC: Fix whitespace in advanced.tt2
Dan Scott [Sun, 11 Dec 2011 22:39:43 +0000 (17:39 -0500)]
TPAC: Fix whitespace in advanced.tt2

Indentation was non-standard following plux's addition of the basic link
in the advanced search UI; fix that up.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPAC: Link to Basic Search from advanced page
Peter Lux [Fri, 9 Dec 2011 21:12:00 +0000 (16:12 -0500)]
TPAC: Link to Basic Search from advanced page

The searchbar in basic search, results, record details offers an option
to get to advanced search - but advanced search doesn't offer a way to
get directly back to a basic search. Now it does; however, some CSS is
required to make it look consistent.

Signed-off-by: Peter Lux <plux@upei.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoAdded CUFTS support in ResolverResolver
Art Rhyno [Fri, 9 Dec 2011 21:36:28 +0000 (16:36 -0500)]
Added CUFTS support in ResolverResolver

This is based on the CUFTS implementation for UPEI. This is
very closely modeled on the SFX implementation.

opensrf.xml.example has been modified to include a <resolver_type>
element for ResolverResolver; by default, SFX will be used and this
shouldn't break anything else. If you use CUFTS rather than SFX, you
can specify 'cufts'.

Signed-off-by: Art Rhyno <artrhyno@uwindsor.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPAC: Fix record summary e-resource and copy display
Dan Scott [Fri, 9 Dec 2011 20:12:53 +0000 (15:12 -0500)]
TPAC: Fix record summary e-resource and copy display

Electronic resources were wrapped with an ugly black line and no
differentiation from the outstanding text. Give them a light background
and remove the black line. Also, use an unordered list if we have more
than one URI to display.

Move the copy summary below the "Copies" heading that immediately
follows it for a more logical grouping of elements.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoFix typo in comment in Open-ILS/src/extras/Makefile.install. collab/dyrcona/precise_pangolin
Chris Sharp [Fri, 9 Dec 2011 19:02:31 +0000 (14:02 -0500)]
Fix typo in comment in Open-ILS/src/extras/Makefile.install.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
8 years agoUpdate the README for Ubuntu Precise Pangolin (12.04).
Jason Stephenson [Thu, 8 Dec 2011 20:53:16 +0000 (15:53 -0500)]
Update the README for Ubuntu Precise Pangolin (12.04).

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
8 years agoUpdate Open-ILS/src/extras/Makefile.install for Ubuntu 12.04.
Jason Stephenson [Thu, 8 Dec 2011 17:10:20 +0000 (12:10 -0500)]
Update Open-ILS/src/extras/Makefile.install for Ubuntu 12.04.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
8 years agoTPAC: Remove more explicit widths from results page
Dan Scott [Fri, 9 Dec 2011 17:05:14 +0000 (12:05 -0500)]
TPAC: Remove more explicit widths from results page

Refactor the facet sidebar such that headers consist of a floated span
and a div with no specific width; absent a specific width, the button
will float over top of text that might expand due to translation.

Also remove the explicit table cell width for the results counter column
and move some inline styles over to CSS. More to be done in results
table but we are on our way.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPAC: Use padding instead of explicit width for tabs
Dan Scott [Fri, 9 Dec 2011 16:09:24 +0000 (11:09 -0500)]
TPAC: Use padding instead of explicit width for tabs

Explicit widths work well for a combination of a specific font sizes and
a known string; however, in the context of translation, strings may get
longer than the explicit width allows. Using padding gives us more
flexibility to accommodate different font sizes and variable length
strings; the uniformity of the tab size will be sacrificed but perhaps
that is not such a bad thing.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into dbs/tpac-non-fixed...
Dan Scott [Thu, 8 Dec 2011 19:01:57 +0000 (14:01 -0500)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into dbs/tpac-non-fixed-width

Conflicts:
Open-ILS/web/css/skin/default/opac/style.css

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoSerials: be less eager to offer season dropdown in holding code mini-wizard
Lebbeous Fogle-Weekley [Wed, 16 Nov 2011 20:19:18 +0000 (15:19 -0500)]
Serials: be less eager to offer season dropdown in holding code mini-wizard

The recent commit (ebce79a288b in master) to make the holding code
mini-wizard offer a dropdown for season offers it too often, sometimes
in completely inappropriate cases.

This commit gets it right, and incidentally fixes two totally broken
links elsewhere in alternate serials control view interfaces.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
8 years agoPropagate search scope through advanced search interfaces
Dan Scott [Fri, 2 Dec 2011 04:01:24 +0000 (23:01 -0500)]
Propagate search scope through advanced search interfaces

If a user had a chosen search scope (via the CGI "loc" parameter), it
would be lost when switching to the advanced search interfaces. Now we
progagate the search scope through the advanced search interfaces.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoStamping upgrade for LP893315: filter_deleted_acns_from_unapi
Bill Erickson [Tue, 6 Dec 2011 14:56:55 +0000 (09:56 -0500)]
Stamping upgrade for LP893315: filter_deleted_acns_from_unapi

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoLP893315: Do not return delected call numbers in holdings_xml
Dan Scott [Fri, 25 Nov 2011 18:20:32 +0000 (13:20 -0500)]
LP893315: Do not return delected call numbers in holdings_xml

Per LP893315, deleted call numbers were obscuring the actual active URIs
associated with a given bib record in a given scope at the default limit
of 5 results per record in unapi.holdings_xml.

Filtering out the deleted call numbers from the results seems like a
good idea, as we're generally interested in only showing the active
results (at least as in-db unapi is currently used). This also addresses
the problem of not showing active URIs when there are active URIs to
display.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoCode comments and tweaks for lost processing
Dan Wells [Mon, 5 Dec 2011 16:44:41 +0000 (11:44 -0500)]
Code comments and tweaks for lost processing

This commit is intended to do the following:

* Fix case where MISSING status is not retained for items
  being sent 'home' (as it was in previous versions)
* Be more explicit about when we unset the LOST status and when
  we do not in checkin_handle_lost()
* Prevent update of the copy in checkin_handle_lost() unless we
  actually change the status
* Restore log messages for special handling of LOST/MISSING
  checkins away from 'home'
* Provide additional code comments to clarify intended behavior

Note: Given the current restructure, MISSING item behavior is no
longer affected by 'lost_immediately_available' setting.  That
seemed more bug than feature, and can be implemented later
(perhaps as a separate setting) if required.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
8 years agoCheck OILS_SETTING_LOST_IMMEDIATELY_AVAILABLE in checkin_handle_lost.
Jason Stephenson [Tue, 29 Nov 2011 14:22:29 +0000 (09:22 -0500)]
Check OILS_SETTING_LOST_IMMEDIATELY_AVAILABLE in checkin_handle_lost.

Check the value of OILS_SETTING_LOST_IMMEDIATELY_AVAILABLE before
changing the copy status in checkin_handle_lost. This makes the setting
actually do something.

Add a couple of blank lines to aid in readability.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
8 years agoFix LP851000.
Jason Stephenson [Thu, 17 Nov 2011 20:15:09 +0000 (15:15 -0500)]
Fix LP851000.

Remove about 14 lines from OpenILS/Application/Circ/Circulate.pm
in the checkin_handle_circ subroutine that check whether or not
the checkin happens at the copy's circ_lib and the value of the
circ.lost_immediately_available org unit setting.

This change causes the handle_lost subroutine to run regardless of
where the checkin takes place for a more consistent experience.

Whether or not billings are voided, overdues restored, etc. is still
determined by the copy's circ_lib.

Given how the hold targeter and transit code works, it does not appear
the the circ.lost_immediately_available setting could ever do what it
was intended to do. Given these changes to the code it is now unnecessary.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
8 years agoTPAC: Protect against missing 901c in legacy MARCXML
Dan Scott [Fri, 25 Nov 2011 17:30:24 +0000 (12:30 -0500)]
TPAC: Protect against missing 901c in legacy MARCXML

Bad MARCXML to which Evergreen has been unable to add a 901c happens -
particularly with legacy MARCXML. Currently, TPAC crashes hard with an
ugly error if a 901c is not found when attempting to display the record
in search results. In comparison, the JSPAC displays the record without
a problem.

This commit logs a warning and enables the TPAC to continue somewhat
gracefully (the problem record is simply skipped in the search results).
A more robust solution may be to teach unapi.bre to add the record ID to
the results and to have the TPAC pull from that, rather than relying on
the MARCXML itself to contain the record ID.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoAdd versioned upgrade script for "Bib source: can have copies"
Dan Scott [Mon, 5 Dec 2011 18:32:23 +0000 (13:32 -0500)]
Add versioned upgrade script for "Bib source: can have copies"

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoRefactor retrieval of cbs object into cat.util.get_cbs_for_bre_id().
Jason Stephenson [Wed, 16 Nov 2011 00:31:12 +0000 (19:31 -0500)]
Refactor retrieval of cbs object into cat.util.get_cbs_for_bre_id().

Avoid code duplication.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoAdd can have copies check to the Add MFHD Record link in rdetail.
Jason Stephenson [Tue, 4 Oct 2011 20:54:32 +0000 (16:54 -0400)]
Add can have copies check to the Add MFHD Record link in rdetail.

This prevents the button from the JSPAC from being able to add MFHD
records to the affected bib record.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoModify copy browser to check for bib_source.can_have_copies.
Jason Stephenson [Tue, 4 Oct 2011 14:29:23 +0000 (10:29 -0400)]
Modify copy browser to check for bib_source.can_have_copies.

Add code to server/cat/copy_browser.js.
Add error string to server/local/en-US/cat.properties.
Swap obj. for g. that was copied from opac.js.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoModify server/cat/bib_brief.js to check for source can have volumes.
Jason Stephenson [Tue, 4 Oct 2011 00:09:37 +0000 (20:09 -0400)]
Modify server/cat/bib_brief.js to check for source can have volumes.

Copy/paste code from chrome/content/cat/opac.js.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoCheck for bib_source.can_have_copies in cataloging.
Jason Stephenson [Sat, 1 Oct 2011 16:02:16 +0000 (12:02 -0400)]
Check for bib_source.can_have_copies in cataloging.

Retrieve the BRE and CBS object in the add_volumes method of
opac.js.

Check if the CBS can have copies, and if not, tell the user such
and return.

Also required adding an api entry in constants.js and a new message
in offline.properties.

This is the beginning of the client code changes. There are very
likely to be more.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoAdd can_have_copies field to config.bib_source.
Jason Stephenson [Fri, 30 Sep 2011 15:28:08 +0000 (11:28 -0400)]
Add can_have_copies field to config.bib_source.

Add the column definition to config.bib_source in
002.schema.config.sql.

Insert TRUE into the column for the default sources created in
950.data.seed-values.sql.

Add the field definition to class id cbs in fm_IDL.xml.

Teach OpenILS/Application/Storage/CDBI/config.pm about new field.

Add upgrade script for config.bib_source.can_have_copies.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agopin a version number for the patron card editor upgrade script
Jason Etheridge [Thu, 1 Dec 2011 21:02:29 +0000 (16:02 -0500)]
pin a version number for the patron card editor upgrade script

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoWhen editing cards, lock tab on apply changes
Thomas Berezansky [Tue, 1 Nov 2011 18:00:46 +0000 (14:00 -0400)]
When editing cards, lock tab on apply changes

Hopefully to prevent people from moving away before saving.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoSeed values/upgrade script for card edit perms
Thomas Berezansky [Tue, 1 Nov 2011 14:11:24 +0000 (10:11 -0400)]
Seed values/upgrade script for card edit perms

Not assigned to anyone by default.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoCheck Profile Editing Perms for Card Editor
Thomas Berezansky [Tue, 1 Nov 2011 14:01:43 +0000 (10:01 -0400)]
Check Profile Editing Perms for Card Editor

Don't allow Active/Primary card changes unless you have the ability to edit
the patron's primary profile group.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoActive/Primary Editing for Patron Cards
Thomas Berezansky [Tue, 1 Nov 2011 13:18:47 +0000 (09:18 -0400)]
Active/Primary Editing for Patron Cards

Changes "See All" into an editing interface, allowing for changing of the
active and primary state of each card.

Each requires a specific permission:

UPDATE_PATRON_ACTIVE_CARD
UPDATE_PATRON_PRIMARY_CARD

Without the appropriate permission the interface will show the green check
or red x instead of the editing elements. If you don't have either
permission then the Apply Changes button is hidden.

As the editing interface exists, also show the "See All" button when there
is only one card, but not when registering a new patron. This allows for
toggling the lone card's active flag, as well as replacing a card but
leaving the old one active.

To ensure that you can do the above, and to avoid some other errors, the
new card on a patron is saved to the editCard variable, rather than using
patron.card(). This both allows for "Replacing" a new non-primary card into
place as well as avoiding issues with editing the primary and active states
at the same time (the interface would try and update the new primary card
with the old primary card's barcode). Also, when checking for duplicate
barcodes, update the editCard with the barcode so the See All interface can
show the new card's barcode in the list properly.

Finally, included is localization for the All Cards interface headers and
buttons.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoTpac: ability to edit name, description of bookbags later
Lebbeous Fogle-Weekley [Wed, 16 Nov 2011 14:48:11 +0000 (09:48 -0500)]
Tpac: ability to edit name, description of bookbags later

You could already name and describe when creating them, and now you can
edit that later.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoFix for LP894125 - reshelving interval collab/dyrcona/lp_894125_fix_reshelving
Ben Shum [Wed, 23 Nov 2011 20:14:32 +0000 (15:14 -0500)]
Fix for LP894125 - reshelving interval

Update to reshelving code to utilize actor.org_unit_ancestor_setting function
and properly retrieve org settings for "circ.reshelving_complete.interval" for
org unit or ancestors.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
8 years agoEnable record summary to be scrollable at larger font sizes
Dan Scott [Tue, 22 Nov 2011 18:33:07 +0000 (13:33 -0500)]
Enable record summary to be scrollable at larger font sizes

The record summary at the top of the cataloguing interfaces appears to
determine its size based on the "normal" font size at load; then, when a
larger font size is applied to the page, the text gets hidden by the
fixed size of the groupbox.  Ideally the groupbox would adjust to
accomodate the larger font size, but after trying many different
approaches the best short-term approach seems to be to enable overflow
so that scrollbars can appear when necessary.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoLimit display to 856 with ind1 = 4 and ind2 = 0 or 1.
Jason Stephenson [Mon, 21 Nov 2011 18:47:30 +0000 (13:47 -0500)]
Limit display to 856 with ind1 = 4 and ind2 = 0 or 1.

Minor modification to Open-ILS/src/templates/opac/parts/
misc_util.tt2 that limits the display of 856 urls to that have
indicator 1 equal to 4 and indicator 2 equal to 0 or 1. These should
be those that point directly to the resource.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPac: show non-asset.uri 856 URLs on detail page
Bill Erickson [Mon, 3 Oct 2011 20:31:45 +0000 (16:31 -0400)]
TPac: show non-asset.uri 856 URLs on detail page

Display "global" 856 URLs in record detail page.  A "global" URL in this
case is one that has no ownership and has not been extracted out as an
asset.uri.  As of right now, this is any 856 that has no $9, $w, or $n
subfield data.

Links are displayed directly after asset.uri links using the same style.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoAvoid redundant install_cpan_force dependencies
Dan Scott [Mon, 21 Nov 2011 17:41:03 +0000 (12:41 -0500)]
Avoid redundant install_cpan_force dependencies

The "install" target and each of the generic distro targets in
Makefile.install included install_cpan_force; make the "install" target
more useful by factoring out the install_libdbi dependency so that
"install" is truly common again (and we only add the install_cpan_force
dependency once).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoAdd install_yaz dependency to debian and ubuntu Makefile.install
Dan Scott [Mon, 21 Nov 2011 17:38:56 +0000 (12:38 -0500)]
Add install_yaz dependency to debian and ubuntu Makefile.install

To build SimpleServer 1.15 we need a version of yaz 4.2+, so add
install_yaz as a dependency for debian and ubuntu. This should have been
added in LP 872284 but was overlooked due to local testing and didn't
get any further testing before being committed.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agobump xulrunner version
Jason Etheridge [Fri, 18 Nov 2011 16:15:04 +0000 (11:15 -0500)]
bump xulrunner version

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoSwitch to new Google Books API; make SSL friendly
Dan Wells [Thu, 17 Nov 2011 21:13:02 +0000 (16:13 -0500)]
Switch to new Google Books API; make SSL friendly

As implied in the title, this commit does two things.  First, it
switches to the new Google Books API (which is both imminent and
also necessary to make SSL calls work).  Though the information is
scant, from what I have read and experienced, we do not need an
API key to do searches and previews.  I have also not hit any kind
of unauthenticated limit in several days of heavy testing, so I
would figure we are safe (at this point) for normal end-user OPAC
browsing.

Second, all Google Book requests are now done over https.  This
eliminates the majority of mixed content warnings when browsing
securely, though you still get a warning when you actually do
preview a book.

In addition to possibly implementing protocol detection (rather
than doing https all the time as a "lowest" common denominator),
there are a few minor points where we might consider future changes.
Those points are commented within the code.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoStamp upgrade scripts for both unapi update and vandelay-to-bucket
Mike Rylander [Thu, 17 Nov 2011 19:46:41 +0000 (14:46 -0500)]
Stamp upgrade scripts for both unapi update and vandelay-to-bucket

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoDefault to org tree root for bre unapi funcs
Bill Erickson [Tue, 8 Nov 2011 20:13:53 +0000 (15:13 -0500)]
Default to org tree root for bre unapi funcs

If the org unit ("site") parameter to unapi.biblio_record_entry_feed()
or unapi.bre() is equal to "-" or NULL, default to the root of the org
unit tree.  In cases where the caller does not care to limit by site,
determing the shortname of the root org node is one less step the client
now has to take.

Original patch from Mike Rylander.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoVandelay; copy imported bib queue recs to bucket
Bill Erickson [Mon, 31 Oct 2011 21:33:23 +0000 (17:33 -0400)]
Vandelay; copy imported bib queue recs to bucket

Adds a "Copy to Bucket" option within the Vandelay queue interface.
User is given the option to name the bucket.  If the bucket already
exists, the records are added to the existing bucket.  Otherwise, a new
bucket is created and the records are added.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoVandelay; API for creating buckets from queues
Bill Erickson [Mon, 31 Oct 2011 18:56:48 +0000 (14:56 -0400)]
Vandelay; API for creating buckets from queues

* Adds a new biblio record entry bucket type of "vandelay_queue"
* Adds a new API call that allows callers to create new buckets (or add
to existing buckets), copying imported records from a vandelay queue
into the bucket.

open-ils.vandelay.bib_queue.to_bucket

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoRepair errant explode_array in upgrade script.
Bill Erickson [Wed, 16 Nov 2011 16:50:57 +0000 (11:50 -0500)]
Repair errant explode_array in upgrade script.

The upgrade script 0562.schema.copy_active_date.sql included 2 calls to
explode_array after explode_array had been removed from the baseline
schema.  This upgrade just copies the contents of the
action.hold_request_permit_test function from the baseline schema to
repair the function for anyone following the upgrade scripts.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoStamping upgrade script for copy visibility vs peer-bibs fix
Mike Rylander [Wed, 16 Nov 2011 17:00:48 +0000 (12:00 -0500)]
Stamping upgrade script for copy visibility vs peer-bibs fix

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoDistinct cache_copy_visibility copy/record
Thomas Berezansky [Mon, 24 Oct 2011 14:36:39 +0000 (10:36 -0400)]
Distinct cache_copy_visibility copy/record

Because if you peer bib a copy to the bib it is on things don't like you.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoObey renewal rules for SIP2 Checkout
Thomas Berezansky [Tue, 18 Oct 2011 19:10:07 +0000 (15:10 -0400)]
Obey renewal rules for SIP2 Checkout

If local policy OR the selfcheck are set to not do renewals than don't
attempt them.

Also, return whether a renewal was attempted (success or failure) so that
the self check on the other end has a better clue what went on.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoImprovement for telephony: just-in-time event revalidation
Lebbeous Fogle-Weekley [Mon, 26 Sep 2011 16:06:07 +0000 (12:06 -0400)]
Improvement for telephony: just-in-time event revalidation

One of the shortcomings with using the Action/Trigger based telephony in
Evergreen until now was that while you might have overdue notices
generated and sent to a system where Asterisk runs for later calling,
but if the notice was generated on a Saturday night, and you have Asterisk
set up not to place any calls again until Monday morning, Asterisk has
no way of revalidating that call at the last minute.  That is, the
system could not determine whether the items that were overdue on
Saturday night are still overdue on Monday morning, and whether the call
should still be made.

Now we have a workable solution to that.

The eg-pbx-allocator.pl script, which takes call files for Asterisk from
a "staging" directory and slowly drips them onto Asterisk's spool can
now consult an open-ils.justintime which in turn asks open-ils.trigger
whether given events, enumerated within the call files themselves, are
still valid.

open-ils.trigger is designed to run as a private service, so that's why
we need a public service that doesn't do anything too sensitive.

This open-ils.justintime service can potentially be extended to offer other
just-in-time information to the allocator right before a call goes onto
Asterisk's spool. For example, that might be a good time to check the time
of day and make a late decision on which phone number to use for a given
user (day_phone, evening_phone, other_phone).

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoStamped upgrade for full circ count view fix
Mike Rylander [Tue, 15 Nov 2011 21:22:08 +0000 (16:22 -0500)]
Stamped upgrade for full circ count view fix

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoUse DISTINCT in counts to avoid dupes
Thomas Berezansky [Thu, 29 Sep 2011 14:44:26 +0000 (10:44 -0400)]
Use DISTINCT in counts to avoid dupes

Otherwise you get:
Legacy count + 2(normal count)(aged count)

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoFull Circ Count View Amplifies Legacy Circs
Dan Wells [Thu, 29 Sep 2011 13:23:49 +0000 (09:23 -0400)]
Full Circ Count View Amplifies Legacy Circs

The current extend_reported.full_circ_count sums the legacy circ count
column, but this results in amplifying the count by the number of current
circs in the system.  This commit adds the legacy count to the GROUP BY
instead of summing it.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoSkip shelved holds at checkout auto-fill
Thomas Berezansky [Tue, 15 Nov 2011 16:08:00 +0000 (11:08 -0500)]
Skip shelved holds at checkout auto-fill

Already happened for volume/title hold, but target map checking wasn't
checking to see if the current copy was shelved.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoNet::Z3950::SimpleServer 1.15 should not require sedding
Dan Scott [Sun, 16 Oct 2011 19:48:38 +0000 (15:48 -0400)]
Net::Z3950::SimpleServer 1.15 should not require sedding

Checking both versions of the packages listed on ftp.indexdata.dk, the
hardcoded path to yaz-config does not exist in Makefile.PL - thus, we
should be able to drop the "sed" instruction for 1.15.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoInstall yaz-4.2 and Net::Z3950::Simpleserver 1.15
Dan Scott [Sun, 16 Oct 2011 15:40:59 +0000 (11:40 -0400)]
Install yaz-4.2 and Net::Z3950::Simpleserver 1.15

Net::Z3950::Simpleserver 1.14+ requires yaz 4.2.x, as well as currently
suffering from a Makefile.PL problem that involves a hard-coded path to
yaz-config (https://rt.cpan.org/Public/Bug/Display.html?id=70444).
Provide a sed command to resolve the latter problem and upgrade our
"current version of yaz" to yaz 4.2.x.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoFix a problem in the clear holds shelf list printer
Lebbeous Fogle-Weekley [Wed, 28 Sep 2011 20:50:03 +0000 (16:50 -0400)]
Fix a problem in the clear holds shelf list printer

This is a "special" interface that you get to via Admin -> For
Developers -> Local Administration in the staff client.

The addition features to one "side" of this hackish interface of label affix
and parts had caused breakage on the other "side."  This fixes that.

Also improve document printing, making it less likely the progress
dialog itself gets printed.

One day this will be replaced with something better.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoStamped upgrade for asset.merge_record_assets fix
Mike Rylander [Tue, 15 Nov 2011 20:45:02 +0000 (15:45 -0500)]
Stamped upgrade for asset.merge_record_assets fix

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoLP#849143 fix some gaps in bib record merging
Jason Etheridge [Tue, 13 Sep 2011 16:22:58 +0000 (12:22 -0400)]
LP#849143 fix some gaps in bib record merging

Tweaks asset.merge_record_assets such that it considers acquisition line items and user requests, serial subscriptions, booking resource types, biblio monograph parts, and biblio peer bib copy maps. I'm not handling vandelay.queued_record.imported_as or any other vandelay tables, but we may wish to do that too. We're also leaving acq.acq_lineitem_history alone.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoAligned the MARC editor subfields to 'start' fixes long subfield display
Liam Whalen [Tue, 1 Nov 2011 19:59:13 +0000 (15:59 -0400)]
Aligned the MARC editor subfields to 'start' fixes long subfield display

When viewing a record in the MARC editor that has extremely long
entries in a subfield, the output would align in the center of the
subfield making the output hard to read.  This patch adds an
align: 'start' option to both the subfield, and the subfield code
elements in the marcSubfield function to make the subfields align in a
 more readable manner.
Signed-off-by: Liam Whalen <lwhalen@evergreen-dev.catalogue.nrcan.gc.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoMerge remote-tracking branch 'eg-working/collab/phasefx/merged_bill_and_receipt_fixes'
Mike Rylander [Tue, 15 Nov 2011 20:36:26 +0000 (15:36 -0500)]
Merge remote-tracking branch 'eg-working/collab/phasefx/merged_bill_and_receipt_fixes'

8 years agoAcq: (un)receive w/o assets should not attempt a copy update
Bill Erickson [Fri, 23 Sep 2011 21:45:39 +0000 (17:45 -0400)]
Acq: (un)receive w/o assets should not attempt a copy update

When receiveing a lineitem for a PO that was activated without assets,
avoid any attempts to update said non-existent assets.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoLP#848945 - Hide Empty Libs checkbox
Jason Etheridge [Tue, 13 Sep 2011 12:48:52 +0000 (08:48 -0400)]
LP#848945 - Hide Empty Libs checkbox

The "Show Libraries With Items" button in Holdings Maintenance shows all the
libs with items regardless of the library/depth filters. One problem is that
when the list refreshes (whenever an item/volume is edited, deleted, or added),
staff using this feature have to re-press the button, which can take a while for
some bibs. This branch removes this button and replaces it with a "sticky"
checkbox labelled "Hide Empty Libs".

This allows you to do almost the same thing; you can set the context library to
Consortium and the depth filter to the lowest depth, which would normally show
all libs, but then use the checkbox to prune out the ones that have no children
and no volumes(*). One possible use case that we'd lose is the ability to show a
specific set of libs that don't already have volumes in addition to all the libs
that do.

* - Also, the test for whether to hide an org or not is very simplistic, but
easy to implement. A more aggressive test would hide a library and all its
descendants if none of the descendants have volumes.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoPatch from Jeff Davis (SITKA) fixing cardless patron updates
Mike Rylander [Tue, 15 Nov 2011 20:04:08 +0000 (15:04 -0500)]
Patch from Jeff Davis (SITKA) fixing cardless patron updates

Quoth the bug report (https://bugs.launchpad.net/evergreen/+bug/851110):

  On our Evergreen 2.0.8 system, it sometimes arises that a patron's card gets deleted. If it was the patron's only card, it becomes impossible to add a new card to the account via the staff client.

  How to reproduce:
  1. Retrieve a patron record for a patron who has no associated card.
  2. Click the Edit button.
  3. Click Replace Barcode and enter a new barcode.
  4. Click Save. This does not work - the process hangs, and if you hit Reload, you will find that your changes were not saved.

  I believe this happens because some code in register.js assumes the patron has at least one card. I have a potential fix that this comment box is too small to contain ... uh, that is to say, I will post it momentarily.

Which he did, and I applied.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoThrow out non-digit barcodes for strict check
Thomas Berezansky [Thu, 22 Sep 2011 13:24:56 +0000 (09:24 -0400)]
Throw out non-digit barcodes for strict check

Characters like "." are valid for numbers, but not the algorithm.

Thus, we need to throw out "16.00" despite the check for
"16.00" == Number("16.00")
returning true.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoDon't check barcode without strict enabled
Thomas Berezansky [Thu, 22 Sep 2011 13:16:31 +0000 (09:16 -0400)]
Don't check barcode without strict enabled

Item status was, unlike other interfaces, doing the strict check, THEN
looking at the checkbox and if it was checked return.

This caused issues when the barcode crashes out the strict checking.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoFix JSPac Hold Editor Org Selector
Thomas Berezansky [Fri, 7 Oct 2011 14:03:34 +0000 (10:03 -0400)]
Fix JSPac Hold Editor Org Selector

Don't wipe out all changes just because the OU was changed.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoStamped upgrade script for hold_notification update via A/T cleanup module
Mike Rylander [Tue, 15 Nov 2011 17:18:53 +0000 (12:18 -0500)]
Stamped upgrade script for hold_notification update via A/T cleanup module

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoHold notification creation A/T cleanup module
Bill Erickson [Thu, 9 Jun 2011 19:21:39 +0000 (15:21 -0400)]
Hold notification creation A/T cleanup module

New CreateHoldNotification Action/Trigger cleanup module that, when
linked to a hold-based event_definition, adds an entry into
action.hold_notification for each hold processed.  The main user-facing
change from this will be that the hold notification time / count in the
staff client will now take A/T notices into effect in addition to
manually created hold notifications.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoFurther support for "circ.collections.exempt" setting
Bill Erickson [Tue, 18 Oct 2011 20:22:25 +0000 (16:22 -0400)]
Further support for "circ.collections.exempt" setting

Added support for skipping users that have the
"circ.collections.exempt" setting in the API call:

open-ils.collections.users_of_interest.warning_penalty.retrieve

This call is an alternate entry point for finding users to consider
for collections processing

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoReshelving update.
Steven Callender [Wed, 19 Oct 2011 18:51:14 +0000 (18:51 +0000)]
Reshelving update.

Update to the reshelving code to make it faster and utilize the new status change time field on asset.copy.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoTPac: Fix glitch in displaying received holdings
Lebbeous Fogle-Weekley [Mon, 14 Nov 2011 18:18:30 +0000 (13:18 -0500)]
TPac: Fix glitch in displaying received holdings

Under "issues held" on the record detail page, holdings summaries for
received issues are nested in an additional layer of array as compared
to MFHD-based holdings, so compensate.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoClear shelf canceled holds notification fix
Bill Erickson [Mon, 24 Oct 2011 20:27:29 +0000 (16:27 -0400)]
Clear shelf canceled holds notification fix

After cancelling a batch of holds via the clear-shelf process, before we
send the holds off to action/trigger for potential notification
generation, re-fetch the holds from the DB to pick up the calculated
cancel_time value (i.e. get a real value for "now").  Otherwise, A/T may
die attempting to create a DateTime object by parsing "now".

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoTPac; hold success confirmation; redirect repairs
Bill Erickson [Wed, 2 Nov 2011 15:28:57 +0000 (11:28 -0400)]
TPac; hold success confirmation; redirect repairs

1. After a successful hold placement, provide feedback to the user that
the hold placement succeeded.  After placement, the user is taken to a
page (same page for failed holds) where the title(s) are listed along
with the success/failure information for each.

2. In some cases, the user may be redirected to the my account page
instead of the point of origin for holds placement.  This occurs
generally when the user is not already logged in and is asked to log in
prior to holds placement.

3. As a side effect, this change replaces one of the ornery
history.go(-1) actions with a true href/URL.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoTPac; reduce vertical space caused by chilifresh link
Bill Erickson [Thu, 3 Nov 2011 14:18:12 +0000 (10:18 -0400)]
TPac; reduce vertical space caused by chilifresh link

CSS loaded from chilifresh forces a fixed height on the
.chili_review class, which causes significant vertical space gobbling in
the results and details pages.  Solution is to change the chili_review
container from a <div> to a <span>, where the height has no effect.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>