Galen Charlton [Tue, 19 Aug 2014 20:19:20 +0000 (13:19 -0700)]
LP#1358916: refuse to retrieve over-large MARC records via Z39.50
At least one malformed record discovered in the wild can
cause open-ils.search backends to balloon to over 3G of memory
consumption. This patch works around that by refusing
to process any (MARC) Z39.50 results that are larger than the
MARC record maximum of 99,999 octets.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Documentation for Delayed vs Canceled Items, Report Editing, Report Hints, and Copy View/Edit Links. Documentation written by Erica Rohlfs, Equinox Software, and Sally Fortin, Athenaeum Educational Services.
Adding docs for lost and paid status. These changes also moves the copy
statuses documentation up from the old 1.6 docs with the addition of the
long overdue and lost and paid statuses and includes some fixes to the
bills documentation.
Docs: Fix filenames to match references in the docs - second time
This is just like the fix that Remington Steed sent in on Sept 4th.
These images were creating errors for me when I try to create
an epub version of the docs because they are all referenced as .jpg
but the filenames were .JPG.
Bill Erickson [Thu, 11 Sep 2014 17:56:32 +0000 (13:56 -0400)]
LP#1350042 browser unit tests use repo fm_IDL2js.xsl
Generate JS-friendly IDL2js for browser client unit tests from the .xsl
file within the repo instead of referencing the installed version, which
may not yet exist on the machine.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Exit processing and return an event if the barcode on a new serial.unit
collides with an existing serial.unit or asset.copy barcode in the
serial receive API.
In the UI, detect the dupe barcode event and provide an error message to
the user.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Jennifer Pringle <jpringle@sitka.bclibraries.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Kathy Lussier [Mon, 30 Jun 2014 18:57:29 +0000 (14:57 -0400)]
lp1335958 Remove parameters from current checkouts link
The limit and offset parameters can cause patrons to be stuck in a small
section of their current checkout lists. Let's remove those two parameters
when linking to that list from the patron dashboard.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Jim Keenan <jkeenan@cwmars.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Pearl [Tue, 26 Aug 2014 20:07:41 +0000 (16:07 -0400)]
LP#1190508: Rename certain image files to avoid Ad Block Plus's blacklist
Ad Block Plus was blocking images with /images/adv_ in their pathname. It is
presumed that "adv" was short for "advertisement". I have renamed the files
and the references to avoid the ABP blacklist.
Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Docs: Fix filenames to match references in the docs
These image files were not displaying in the docs because the filenames
and the references used different capitalization. Web URLs are
case-sensitive, so this commit changes the image filenames to be all
lowercase.
* Templates in Open-ILS/src/templates/staff/
* JS files in Open-ILS/web/js/ui/default/staff/
* Also includes a few TPAC modifications for embedded mode
* Resurrects the pre-XUL user permission editor
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Mon, 4 Aug 2014 18:03:07 +0000 (14:03 -0400)]
LP#1350042 make_release -c for building browser client
Adds support for fetching JS dependencies, minification, and
building of the experimental browser client via new -c option.
Browser client building is disabled by default.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
* Location configuratoin for /eg/staff templates
* Support for "stop-at-index" in EGWeb, so that navigating to "/eg/foo"
can result in /eg/index.tt2 getting served.
* Cache and compress additions for /js files.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Mon, 4 Aug 2014 17:16:02 +0000 (13:16 -0400)]
LP#1350042 detect is-staff mode for browser client
The browser client does not pass an OILS-Wrapper header to the embedded
catalog (etc.) so consider the presence of a workstation an indication
that the TPAC should operate in staff mode.
NOTE: this may require some additional thought, since this means all
TPACs within an authenticated browser will run in staff mode, which may
not be desired.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Adds an API name-based option to the standard holds pull list API to
respond with a stream of fleshed users, so the caller is not forced to
make additional fetch-by-ID calls to collect the holds data.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Adds an API name-based option to the standard patron search API to
respond with a stream of fleshed users, so the caller is not forced to
make additional fetch-by-ID calls to collect the user data.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Terran McCanna [Tue, 26 Aug 2014 21:58:52 +0000 (17:58 -0400)]
LP#1282783: Use patron hold notification defaults for KPAC
Since the KPAC interface doesn't display a patron's email/phone notification
preferences, we had initially assumed it was pulling in the patron's default
notification info, but we've found that it does not.
Emails are not sent to patrons who have their notification preferences set to
email, and hold slips print out without phone numbers or email addresses. This
causes extra work for Circ staff in processing incoming holds as they need to
look up each account number to get the patron's contact information.
This patch pulls in the patron's email & phone notification preferences and
related values in hidden fields and allows the patron to choose their pickup
library at time of hold placement (defaults to their preferred pickup location).
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Mon, 25 Aug 2014 18:16:35 +0000 (14:16 -0400)]
LP#1362210: Install PostgreSQL packages where we can
Rather than relying on purely manual installation, carve out a common
set of packages that are needed by both the Evergreen server and the
standalone PostgreSQL server and add them as dependencies to both
scenarios. In the worst case, the package manager will see a package
that it has already installed and skip it (if the database server is on
the same OS instance as the Evergreen server).
It sure beats upgrading your database server and wondering why things
like the addition of call numbers fails with database query errors when
it turns out that you're missing the Library::CallNumber::LC Perl module
:)
It also makes the README shorter and requires fewer steps for users to
follow to install successfully. Win win win?
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Fall back to an unitialized maketext handler, which defaults to the
template language, when OpenILS::WWW::EGWeb::I18N->get_handle fails to
return a response.
Note that why get_handle() returns undef is not yet known.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Jason Etheridge [Mon, 1 Oct 2012 20:49:04 +0000 (16:49 -0400)]
LP#1010027: tweak patron columns in patron search interface
specifically, remove the Mailing Address and Billing Address columns that come
off the actor table, since they are redundant with the Mailing Addr: Address ID
and Billing Addr: Address ID columns that come off the address table.
Also, alphabetize the columns coming directly off of the user table. The columns
coming off the library card and address tables remain unsorted; I believe their
order is as listed in the fm_IDL.xml file for their corresponding fieldmapper
definitions.
Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Jennifer Pringle <jpringle@sitka.bclibraries.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
specifically, give fm_columns a sort_headers flag for alphabetizing the columns
returned by label; and delete_me flag for omitting a column definition entirely
Not all xul lists are using fm_columns yet
Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Jennifer Pringle <jpringle@sitka.bclibraries.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Chris Sharp [Tue, 11 Jun 2013 14:09:20 +0000 (10:09 -0400)]
LP#1189556: Fix typo in URL_VERIFY permission description
The description for the URL_VERIFY permission contained a typo,
fixed here.
Added an upgrade sql to update the text.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi> Signed-off-by: Ben Shum <bshum@biblio.org>
Ben Shum [Wed, 30 Apr 2014 06:02:49 +0000 (02:02 -0400)]
LP#1314370: Enable dojo all the time in the catalog
Because we rely on the dojo framework for the shelving location filter in the
advanced search, we should choose to use dojo everywhere and not just when
autosuggest, google books, or novelist are enabled.
This is a quick change to toggle the flag for want_dojo to be set all the time.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop>
LP1277556 Fast Item Add no longer opens record after copy is created
Altered save_attempt to handle undefined and true cases for replace_on_complete
When fastItemAdd is not used, replace_on_complete is undefined
When it is used, and successful, replace_on_complete will be set to true
then we need it to execute result.on_complete()
Liam Whalen [Sat, 28 Jun 2014 22:37:28 +0000 (15:37 -0700)]
LP1084269, LP1050043 Expert Search Fixes
Sorting Expert Search corrected
LP1050043 was issued because attempting to sort the MARC expert search
results, in the staff client, caused the staff client to return to the
basic search page rather than sort the results.
To fix the sorting I had to modify two perl files.
metabib.pm had to be changed in a number of ways.
1. The way the sort works currently assumes the user is doing a full
text search. So, it passes in the values of titlesort and authorsort as
the sort variable in the URL. However, in the expert search, it is
looking for the values 'title' and 'author'. This resulted in the title
sort and author sort never being executed and returning the relevance
sort instead. I modified the search to use a regex instead of eq.
2. If a record has no value associated with it e.g. no 260 c for
pubdate, no 245 $a for title, no 1xx $a for author, then the SQL is
supposed to replace those values with either 'AAAA' or 'zzzz' depending
on the order of the sort. This should cause records without the
relevant sort values to be pushed to the bottom of the sort results.
But, the PgSQL function COALESCE, which is supposed to do the
replacing, does not do anything if no rows are returned for a record's
relevant value. To work around this, I surrounded the relevant values
with the MAX() function call, which returns NULL if no row is returned.
Because author sort works on any 1xx value, it sorts those values in
numerical order when there is more than one 1xx in a record. This
requires the use of an ORDER BY statement, which seems to nullify
the effect of MAX(). So, I had to move the MAX() into a second SELECT
statement in the case of author sort.
3. I added the variables number_default_sort and string_default_sort
to the metabib code because the current code hard codes values of
'9999' and 'zzzzzzzz' into the sort.
Search.pm had to be changed to pass the sort values from the TPAC
into the relevant sort subroutines. This was done with the addition of
an $arghash variable that checks the cgi parameters for the sort
variable.
As well, Expert search puts the tag and _special params in the
search form. This causes all other searches to perform Expert searches
afterwords. To fix this, Search.pm is modified to look for an empty
query value before it conducts an Expert search. If it is empty and
the Expert search variables are present, then the Expert search is
performed. Otherwise, a normal search is done.
Finally, to fix the problem reported by LP1050043, I had to modify
searchbar.tt2. Currently, searchbar.tt2 does not have the values from
the Expert search entered into the <form> where the sort functionality
is located. This means, when a sort option is chosen, the TPAC no
longer knows which values were used for the Expert search.
This is not obvious at first because after choosing to sort, the
user is returned to a page where the URL has the Expert search values
in it. This happens because the sort is submitting a form without a
query value, so the TPAC redirects the user to the referring page,
which is the initial Expert search.
To fix this, I added the Expert search values as hidden variables
into the <form> where the sort functionality is located. I also
removed the use of the "_adv" hidden variable from the <form> when
not in the advanced search.
[LP1094269] Retrive past 100 records in Expert Search
Currently, when paging through the results of the Expert search, the
system will not return more than 100 records. Going past page 10
causes a no results screen.
This is due to the offset and limit values not being passed into the
argument hash used to create the SQL for the search. Once the SQL
returns, it returns record ids within the range of the offset and
the limit. So, if the offset is 100 and the limit is 10, the record
ids for search results 100 to 109 are returned.
But, because offset and limit are not being passed into the arghash,
they default to 0 and 100 respectively. This means the first 100
records are always returned regardless of where in the search pages
you are viewing. These 100 results were then pruned to the relevant
10 results in Biblio.pm. However, if the offset starts beyond 100
then no results are returned because the results passed 100 are not
returned by metabib.pm.
This commit passes the offset and limit as arguments in the search
hash. It also removes offset and limit as parameters of the
search.biblio.marc call. Because offset and limit are needed in the
arghash to limit the number of records returned, it is better to
pass them only via the arghash to ensure that no more than the
necessary number of records are returned.
Offset and limit could be kept as parameters, but it would require
modifying metabib as well to look for those parameters, so I think
forcing the Expert search to pass them as argument parameters is the
better option.
As well, this commit removes the pruning in Biblio.pm that was based
on the offset and limit because that is handled in metabib.pm now
that offset and limit are being supplied in the argument hash.
I have checked the source code and the marc_search function in
Biblio.pm is only called via the Expert search in
WWW/EGCatLoader/Search.pm, so modifying Biblio.pm in this manner
will only affect the Expert search and nothing else.
Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop> Signed-off-by: Sarah Childs <sarahc@zionsvillelibrary.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Victoria Lewis [Wed, 30 Apr 2014 22:09:07 +0000 (15:09 -0700)]
lp1182605 Abstracting out common functionality from code that sorts call numbers by label_sortkey
Code had been added to insure that LC call numbers are sorting as they should by asset.call_number.label_sortkey.
Code was duplicated in the 'call_number column' in the 'columns' group and in the 'hold_columns'group.
I abstracted the logic out of 'sort_value' and 'render' in the 'call_number' column in the 'columns' group and from
'render' in the 'call_number' column in the 'hold_columns' group to a utility function called
'sort_call_numbers_by_label_sortkey'.
Signed-off-by: Victoria Lewis <vcamklewis@gmail.com>
modified: xul/staff_client/server/circ/util.js Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Kyle Tomita [Mon, 2 Dec 2013 23:50:17 +0000 (15:50 -0800)]
LP1182605 : LC call numbers sort improperly in tabular displays
The issue was that the column was sorting on the label (call number)
and not label_sortkey. An attribute 'sort_value' was added that used
label_sortkey.
Dan Wells [Mon, 7 Jul 2014 17:16:58 +0000 (13:16 -0400)]
Fix currently harmless but still confusing sigil error
get_org_descendants() returns an array ref, not a list, so it doesn't
make sense to assign it to an '@orgs' variable. Lucky for us, our
where-parser treats this single element list containing the ref in the
same manner as the proper ref itself, but at best, it is still very
confusing to see.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
If you have generated holdings, but are not using the "compressed"
display, your holdings show up regardless of scope. This change
limits the display to only sdists with a holding_lib in your current
search scope.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Bill Erickson [Tue, 25 Feb 2014 17:23:13 +0000 (12:23 -0500)]
LP#800478 repair logic error in acq fund transfer
The source data for the amount applied to each allocation and transfer
(in certain circumstances) was incorrect.
The transfer amount should not be the total amount allocated from the
source to the fund, but instead the amount of the funding source credit
in cases where we have to pull money from multiple funding source
credits.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Thu, 21 Aug 2014 19:33:53 +0000 (12:33 -0700)]
LP#1359934: prevent error opening patron search form
As a result of the patch for OpenSRF bug 1316245, JSON2js
in the OpenSRF library is now stricter -- in particular, passing
an undefined value to it results in an exception being thrown.
This patch runs with the increased strictness and fixes an
issue where the patron search form was passing an undefined value
to JSON2js.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Ben Shum [Thu, 14 Aug 2014 16:36:16 +0000 (12:36 -0400)]
Fixes for create_release_notes.sh
1) Teach it to ignore the sample RELEASE_NOTES_NEXT.txt file
2) Add a proper section for "New Features" heading, instead of
defaulting everything under the "Upgrade notes" heading.
Note: Will still require manually moving any upgrade notes to the
right place post-compile.
* Correctly propagate values for text widget "in list" values when editing
reports
* After entering a value for "in list" text widgets, clear the text
input so the user can enter subsequent values w/o manually clearing.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
* ensure default values for scheduling and recurrence are applied with each
edited report, including today's date in the scheduler.
* If the most recent report run run_time is in the past, deafult to "run
now"
* fix bug with propagating months recurrence
* If recurrence interval is in days and divisible by 7, present as weeks
* make date regexes easier on the eyes
* fix bug with rendering sets of org units
* fixed bug with modifying report to be "run now" from scheduled.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Kathy Lussier [Fri, 8 Aug 2014 21:16:39 +0000 (17:16 -0400)]
Release note repairs and additions
A handful of repairs and additions to the 2.7 release notes, including:
* moved copy_edit_links to cataloging
* making no-fixed-field-defaults-for-ingest an upgrade note
* adding release note entries for hold targeting of precats and improved
acq fund rendering.
James Fournie [Wed, 4 Jan 2012 19:55:19 +0000 (11:55 -0800)]
Add multiple permission groups editor to user registration form
This makes use of permission.usr_grp_perm_map which grants secondary
permission groups. It does not affect the 'profile' ie: circulation policy.
Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Fri, 8 Aug 2014 00:39:47 +0000 (20:39 -0400)]
LP#1329503 avoid run now + later combined schedule
When editing a report, ensure only one of "now" vs. "schedule for later"
options is selected by default. Similarly, if the schedule option is
activated by default, ensure the date fields are enabled.
If the run time of the most recent report is in the past, default to the
current date for the schedule instead of the no longer valid date.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
* correctly propagate values for the "between" widget
* propagate pivot data and label when present
* propagate report run time
* improvements to report email propagation
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Alongside each report in the Reports folder view there are two new
links, one for viewing (read-only) and one for editing. After changing
a report, the user has the option to save the modified report or create
a new report with the new values, in effect cloning the original report.
When saving a changed report, if a pending report run exists, the user
will be warned of this and asked if they would prefer to modify the
scheduled report or to instead save the changed values as a new report,
leaving the original report intact.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Ben Shum <bshum@biblio.org>
* Various sanity checks and misc. repairs
* Add missing strings
* oils_rpt_editor.xhtml XML repair; XMLENT is strict
* links to external resources open XUL tabs (to avoid HTTP dialogs)
* avoid displaying bare HTML in labels
* show hints for display fields
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Ben Shum <bshum@biblio.org>
* Report templates support a new External URL field, which may
contain a link to template-specific, local documentation.
** When set, a link to the external documentation will be
displayed in a new column in the template list and within
the report editor.
** URL's are set in the 'Documentation URL' entry.
* Template display fields and filters support a new Field Hint
value. When set, hints are displayed in the report editor.
** Values are set via the 'Change Field Hint' option along
the bottom of the template editor.
------ from commits ----
* Initial template-level support for inline template and field documentation
* Use external documenation url in clark output
* Show the docs link and strings in the report editor
* Set the href of a link, instead of the text content of a span
* Attempt to pop up a new window (may require more pushups in the XUL staff client)
* Add calculated column support, use it for external docs url
* Realign field names
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Adds "view" and "edit" links next to each copy in the TPAC copy grid
when in embedded mode. The "edit" link only appears when the user has
permission to edit the specified copy.
Via the XUL volume_item_creator, the ui.unified_volume_copy_editor org
unit setting is inspected to determine which UI to load. Also, the data
needed to load the subsequent UI is fetched within the
volume_item_creator, so the catalog doesn't have to.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Fri, 1 Aug 2014 04:46:45 +0000 (00:46 -0400)]
LP#1304462: Add schema.org copyrightYear, manufacturer for RDA 264 fields
It looks like the best we can do is to define a "manufacturer" property (and
corresponding Organization entity) when 264 ind2="3"; and we can provide a
copyrightYear when we have 264 ind2="4".
Even then, MARC / RDA cataloging practices end up giving us copyright notices
like '@2012' instead of actual dates, so we have to regex the year out of the
notice to satisfy the Integer range for copyrightYear. Theoretically we'll be
in trouble if the copyright notice includes some other 4-digit number (for
example, a multipart work catalogued in a single record that has a date range),
but what are you gonna do? It's MARC / RDA.
Same for manufacturer name, which seems likely (if the LoC examples that Yamil
provided are any guide) to include statements like "Manufactured by Foobar"
instead of cleanly structured data. The RDA fields were added to MARC21 in
2011, you would have thought that the benefits of providing clean data would
have been obvious by then. Grumble grumble grumble. Yes, this is meant to be
a transcription field, and theoretically one could use a 7xx to record the
publisher/distributor/manufacturer/producer in a more cleanly stated factual
way that would lend itself to actual linked data (hey, maybe even providing a
link to an external resource that could act as an identifier), but NOBODY DOES
THAT.
So we do the best we can and soldier on.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
projects / working / Evergreen.git / log