]> git.evergreen-ils.org Git - working/Evergreen.git/log
working/Evergreen.git
13 years agoSilence warning
atz [Thu, 30 Sep 2010 23:06:39 +0000 (23:06 +0000)]
Silence warning

Warnings was:
Use of uninitialized value in subroutine entry at /openils/lib/perl5/OpenILS/SIP/Patron.pm line 230.

Signed-off-by: Joe Atzberger <atz@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18111 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agofire the hold_request.cancel.staff when hold is cancelled by staff
erickson [Thu, 30 Sep 2010 20:49:14 +0000 (20:49 +0000)]
fire the hold_request.cancel.staff when hold is cancelled by staff

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18109 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoFix overzealous prompting for auth credentials, and some debug lines
phasefx [Wed, 29 Sep 2010 20:49:05 +0000 (20:49 +0000)]
Fix overzealous prompting for auth credentials, and some debug lines

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18106 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoGive BibTemplate the ability to inspect and optionally parse XML, instead of requirin...
miker [Wed, 29 Sep 2010 20:16:41 +0000 (20:16 +0000)]
Give BibTemplate the ability to inspect and optionally parse XML, instead of requiring a DOM node

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18105 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agofix FM type of reporter.report.data
gmc [Wed, 29 Sep 2010 18:07:43 +0000 (18:07 +0000)]
fix FM type of reporter.report.data

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18103 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoreporter: don't try to write Excel formulas
gmc [Wed, 29 Sep 2010 17:48:52 +0000 (17:48 +0000)]
reporter: don't try to write Excel formulas

Any cell value that starts with = is now always written
as a text cell in spreadsheet output.  Avoids a possible
exploit as well as errors like this:

Couldn't parse formula: = at /openils/bin/clark-kent.pl line 429

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18101 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agosupport per-grunlarity parallelizing via flag and lock file
miker [Wed, 29 Sep 2010 15:05:53 +0000 (15:05 +0000)]
support per-grunlarity parallelizing via flag and lock file

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18099 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoProcess item imports during record import, not as a secondary call (never should...
miker [Wed, 29 Sep 2010 14:45:50 +0000 (14:45 +0000)]
Process item imports during record import, not as a secondary call (never should have worked, but for transaction timing)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18097 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoUse transactions everywhere in Vandelay
miker [Tue, 28 Sep 2010 23:12:58 +0000 (23:12 +0000)]
Use transactions everywhere in Vandelay

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18095 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoDelete all cookies on logoff. There's dojo code that looks for stale session cookies...
phasefx [Tue, 28 Sep 2010 21:12:11 +0000 (21:12 +0000)]
Delete all cookies on logoff.  There's dojo code that looks for stale session cookies and has the xul client prompt for a new session.  When you logoff, the session is destroyed, but the stale cookies were being left behind (and not overwritten on login? I don't understand that part).  But this fixes it

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18093 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agomove the early-out response so we avoid breaking the caller
miker [Tue, 28 Sep 2010 20:45:17 +0000 (20:45 +0000)]
move the early-out response so we avoid breaking the caller

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18091 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoA/T: Send an early response back to the client when running all pending events
senator [Tue, 28 Sep 2010 20:26:09 +0000 (20:26 +0000)]
A/T: Send an early response back to the client when running all pending events
The client may wish to know when the relativelty fast process of creating the
events is over, and the relatively slow process of validating them and running
their reactors/cleanup/etc is about to begin.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18089 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agofor troubleshooting, log the size of the template output to be stored
erickson [Tue, 28 Sep 2010 18:12:14 +0000 (18:12 +0000)]
for troubleshooting, log the size of the template output to be stored

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18085 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoability to override checkin events. minor fixes.
erickson [Tue, 28 Sep 2010 18:12:13 +0000 (18:12 +0000)]
ability to override checkin events. minor fixes.

repaired bug that caused checkin to sometimes fail when a hold
was captured for a user that had at least 1 inactive card;
made checkin override events configurable; minor cleanup

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18084 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agorepaired logic bug in lineitem worksheet template
erickson [Tue, 28 Sep 2010 18:12:12 +0000 (18:12 +0000)]
repaired logic bug in lineitem worksheet template

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18083 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agothis breaks (hides) the buttonbar in windows. Sorry James, miker
phasefx [Tue, 28 Sep 2010 16:46:34 +0000 (16:46 +0000)]
this breaks (hides) the buttonbar in windows.  Sorry James, miker

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18081 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoChange memcached default location to 127.0.0.1 from localhost
dbs [Tue, 28 Sep 2010 16:40:02 +0000 (16:40 +0000)]
Change memcached default location to 127.0.0.1 from localhost

Debian Squeeze currently doesn't fare well with memcached servers pointing to
localhost and needs an explicit 127.0.0.1, whereas Ubuntu Lucid is happy with
either. Changing the default here means one less possible gotcha in the out
of the box install & configure experience for Debian Squeeze folk.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18079 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadd support for the null() xpath function, which works in pgxml (AKA xml2) but not...
miker [Tue, 28 Sep 2010 16:35:24 +0000 (16:35 +0000)]
add support for the null() xpath function, which works in pgxml (AKA xml2) but not in the builtin XPATH function for 8.3+

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18077 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoMake authority validation rules match authority ingest rules for better matches
dbs [Tue, 28 Sep 2010 06:43:41 +0000 (06:43 +0000)]
Make authority validation rules match authority ingest rules for better matches

This resolves a problem in O:A:Storage:Publisher:authority:validate_tag() where
the full NACO normalization rules that are applied to the subfields of the
authority records when they are ingested into authority.full_rec are not similarly
applied to the incoming subfields of the bib field that is being validated;
only diacritic characters in the bib field subfields were being normalized.

Now we apply naco_normalize() to the search terms so that they will match
the ingested form of the authority record.

Addresses https://bugs.launchpad.net/evergreen/+bug/649556

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18076 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoSilence SQL warnings from O:A:Storage:Publisher:metabib
dbs [Tue, 28 Sep 2010 06:18:07 +0000 (06:18 +0000)]
Silence SQL warnings from O:A:Storage:Publisher:metabib

PostgreSQL wants strings containing regular expressions to be prefixed
with E; this patch considerably reduces the noise in open-ils.storage_unix.log
by complying with PostgreSQL's wishes.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18075 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoIncorporate several recent upgrade scripts, through # 0422.
scottmk [Tue, 28 Sep 2010 05:17:03 +0000 (05:17 +0000)]
Incorporate several recent upgrade scripts, through # 0422.

M    Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18073 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoTurn an int into a bigint in acq.acq_lineitem_history, following up on
scottmk [Tue, 28 Sep 2010 05:13:32 +0000 (05:13 +0000)]
Turn an int into a bigint in acq.acq_lineitem_history, following up on
a similar change to acq.lineitem.

M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0422.schema.acq.lineitem-history-bigint.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18072 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAdd a placeholder server/skin/custom.js to prevent one error in JS console
dbs [Tue, 28 Sep 2010 03:32:28 +0000 (03:32 +0000)]
Add a placeholder server/skin/custom.js to prevent one error in JS console

custom.js enables you to override the settings in the stock constants.js
to skin the behaviour of your staff client at your installation, without
being subject to grief at upgrade time.

Not having a custom.js file at all was, however, causing errors to be generated
in the JS console as XULRunner tried hard to parse the 404 message as
JavaScript. I suppose one could have changed the 404 message to valid
JavaScript... naw, that would be evil.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18068 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoUse quoted attribute values to make Firefox / XULRunner happier about dojo queries
dbs [Tue, 28 Sep 2010 03:08:48 +0000 (03:08 +0000)]
Use quoted attribute values to make Firefox / XULRunner happier about dojo queries

The unquoted values in BibTemplate and the OPAC detail template were generating
mucho noise in the JavaScript console; this hushes it up nicely.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18062 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agotypo in POD
atz [Tue, 28 Sep 2010 01:26:07 +0000 (01:26 +0000)]
typo in POD

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18058 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoMinor cleanup
atz [Tue, 28 Sep 2010 01:24:20 +0000 (01:24 +0000)]
Minor cleanup

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18057 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoFix POD for RemoteAccount
atz [Tue, 28 Sep 2010 01:22:41 +0000 (01:22 +0000)]
Fix POD for RemoteAccount

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18056 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoFor edi_translator on RHEL
atz [Tue, 28 Sep 2010 01:22:40 +0000 (01:22 +0000)]
For edi_translator on RHEL

Note: RubyGems 1.3.4 is not available anymore

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18055 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years ago1. Turn some ints into bigints.
scottmk [Mon, 27 Sep 2010 21:31:17 +0000 (21:31 +0000)]
1. Turn some ints into bigints.

2. Rename the uniqueness constraint for booking.resource_type.

M    Open-ILS/src/sql/Pg/090.schema.action.sql
M    Open-ILS/src/sql/Pg/200.schema.acq.sql
M    Open-ILS/src/sql/Pg/012.schema.vandelay.sql
M    Open-ILS/src/sql/Pg/095.schema.booking.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
M    Open-ILS/src/sql/Pg/070.schema.container.sql
A    Open-ILS/src/sql/Pg/upgrade/0421.schema.embiggen-ints.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18054 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoSpecial overriden widgets need forcible population when used in edit dialogs
senator [Mon, 27 Sep 2010 20:54:56 +0000 (20:54 +0000)]
Special overriden widgets need forcible population when used in edit dialogs

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18051 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadjustments to pubdate sorting patch
gmc [Mon, 27 Sep 2010 20:14:49 +0000 (20:14 +0000)]
adjustments to pubdate sorting patch

* handle upgrade for date1/date2 containing the empty string
* syntax error fix

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18049 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agofix another hold targeting glitch
gmc [Mon, 27 Sep 2010 19:48:33 +0000 (19:48 +0000)]
fix another hold targeting glitch

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18047 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agofix glitch in hold target OU weighting
gmc [Mon, 27 Sep 2010 19:27:04 +0000 (19:27 +0000)]
fix glitch in hold target OU weighting

We want to weight by the copy's circulation library, not the
pickup library.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18045 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agomissed in the previous commit, sorry folks
miker [Mon, 27 Sep 2010 19:24:13 +0000 (19:24 +0000)]
missed in the previous commit, sorry folks

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18043 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoCorrect the subquery for A/T opt_in_setting
miker [Mon, 27 Sep 2010 19:16:57 +0000 (19:16 +0000)]
Correct the subquery for A/T opt_in_setting

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18041 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agomake pubdate sorting on search faster by pre-munging date1 and date2 into an acceptab...
miker [Mon, 27 Sep 2010 19:11:21 +0000 (19:11 +0000)]
make pubdate sorting on search faster by pre-munging date1 and date2 into an acceptable sortkey

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18039 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agofix default path to selfcheck sounds
gmc [Mon, 27 Sep 2010 18:50:56 +0000 (18:50 +0000)]
fix default path to selfcheck sounds

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18037 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agouse transaction when gathering records from a newly created queue; adjust rollback...
miker [Mon, 27 Sep 2010 18:26:29 +0000 (18:26 +0000)]
use transaction when gathering records from a newly created queue; adjust rollback usage in import loop

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18034 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agosince we're enforcing the requiredness of address type, let's give it a default value...
phasefx [Mon, 27 Sep 2010 16:29:19 +0000 (16:29 +0000)]
since we're enforcing the requiredness of address type, let's give it a default value (since empty strings don't work with these widgets)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18029 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAdjust hold-to-record view to cover I, F and R hold types
miker [Mon, 27 Sep 2010 16:15:14 +0000 (16:15 +0000)]
Adjust hold-to-record view to cover I, F and R hold types

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18027 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoProvide for limiting the number of classOrder elements to a specific number. Skips...
miker [Mon, 27 Sep 2010 15:23:10 +0000 (15:23 +0000)]
Provide for limiting the number of classOrder elements to a specific number. Skips those without facet values.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18025 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoResolve differences between stored procedures in a freshly installed
scottmk [Mon, 27 Sep 2010 12:45:57 +0000 (12:45 +0000)]
Resolve differences between stored procedures in a freshly installed
2.0 database and those in an upgraded one.

M    Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18023 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoavoid multiple clicks of selfcheck logout link
gmc [Mon, 27 Sep 2010 01:43:12 +0000 (01:43 +0000)]
avoid multiple clicks of selfcheck logout link

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18021 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agohonor SIP return date as the circ backdate
erickson [Sun, 26 Sep 2010 23:20:12 +0000 (23:20 +0000)]
honor SIP return date as the circ backdate

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18017 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agono need to warn when emails may just be disabled
erickson [Sun, 26 Sep 2010 23:20:11 +0000 (23:20 +0000)]
no need to warn when emails may just be disabled

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18016 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agopush copy location order update into ML method. return updated orders from method...
erickson [Sun, 26 Sep 2010 23:20:10 +0000 (23:20 +0000)]
push copy location order update into ML method.  return updated orders from method to prevent replication issues.  update UI JS to match

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18015 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoRemove a debugging statement that slipped in
dbs [Sun, 26 Sep 2010 18:34:47 +0000 (18:34 +0000)]
Remove a debugging statement that slipped in

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18013 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadded missing columns to CDBI table definitions
gmc [Sun, 26 Sep 2010 16:26:21 +0000 (16:26 +0000)]
added missing columns to CDBI table definitions

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18011 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoOnly show facetOrder limited facets that have values
miker [Sun, 26 Sep 2010 15:53:21 +0000 (15:53 +0000)]
Only show facetOrder limited facets that have values

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18009 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoallow more complex facet ordering
miker [Sun, 26 Sep 2010 15:31:41 +0000 (15:31 +0000)]
allow more complex facet ordering

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18007 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agounmark record for overlay after it is overlaid
phasefx [Sun, 26 Sep 2010 10:29:36 +0000 (10:29 +0000)]
unmark record for overlay after it is overlaid

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18006 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agomake the MARC editor optional with Z39.50
phasefx [Sun, 26 Sep 2010 10:02:38 +0000 (10:02 +0000)]
make the MARC editor optional with Z39.50

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18005 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoCall persist_helper() in most interfaces. Give it the ability to handle resizing...
phasefx [Sun, 26 Sep 2010 09:23:43 +0000 (09:23 +0000)]
Call persist_helper() in most interfaces.  Give it the ability to handle resizing windows and set some windows up so that their height, width, and maximized state persist

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18004 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agomake all the splitters sticky with oils_persist
phasefx [Sun, 26 Sep 2010 08:06:33 +0000 (08:06 +0000)]
make all the splitters sticky with oils_persist

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18003 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agomake the splitters in the z39.50 interface sticky
phasefx [Sun, 26 Sep 2010 07:05:58 +0000 (07:05 +0000)]
make the splitters in the z39.50 interface sticky

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18002 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoShow cover art in Z39.50 client. I'm slow, so it only hit me this year that we can...
phasefx [Sun, 26 Sep 2010 06:34:22 +0000 (06:34 +0000)]
Show cover art in Z39.50 client.  I'm slow, so it only hit me this year that we can show added content for material not actually in the catalog yet

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18001 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agomake address_type required in the patron editor, otherwise a blank value sends a...
phasefx [Sun, 26 Sep 2010 03:17:05 +0000 (03:17 +0000)]
make address_type required in the patron editor, otherwise a blank value sends a null to the db where it silently fails

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17999 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agomore selfcheck receipt transaction hackery
gmc [Sun, 26 Sep 2010 02:49:39 +0000 (02:49 +0000)]
more selfcheck receipt transaction hackery

Instead of having authoritative versions of
open-ils.circ.fire_*_trigger_events, wrap just the
target retrieval itself in a transaction.  Avoids as
yet unexplained rollback failure that occurs if
processing a selfcheck receipt with more than a few items on it.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17997 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agodon't leak cstores if CStoreEditor rollback fails
gmc [Sun, 26 Sep 2010 02:42:50 +0000 (02:42 +0000)]
don't leak cstores if CStoreEditor rollback fails

Patch by Mike Rylander.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17995 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoonly need to wrap event retrieve in xact for latest copy. otherwise, run the risk...
erickson [Sat, 25 Sep 2010 04:09:57 +0000 (04:09 +0000)]
only need to wrap event retrieve in xact for latest copy.  otherwise, run the risk of xact-ed cstore timing out

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17994 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agofix misplaced paranoia
senator [Sat, 25 Sep 2010 03:54:09 +0000 (03:54 +0000)]
fix misplaced paranoia

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17992 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agono need to start a xact in the holds pull list. really long lists can results in...
erickson [Sat, 25 Sep 2010 03:46:03 +0000 (03:46 +0000)]
no need to start a xact in the holds pull list.  really long lists can results in sending a rollback on a timed-out cstore handle, resulting in errors

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17991 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoHow did this get lost? PermaCrud authoritative might work now?
senator [Sat, 25 Sep 2010 03:45:21 +0000 (03:45 +0000)]
How did this get lost? PermaCrud authoritative might work now?

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17989 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoevents don't have granularity's. removing
erickson [Sat, 25 Sep 2010 03:27:20 +0000 (03:27 +0000)]
events don't have granularity's.  removing

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17987 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoparanoia
senator [Sat, 25 Sep 2010 01:13:31 +0000 (01:13 +0000)]
paranoia

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17985 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agopedantic protection of cstore backends -- always use die_event when in xact mode...
miker [Sat, 25 Sep 2010 00:58:35 +0000 (00:58 +0000)]
pedantic protection of cstore backends -- always use die_event when in xact mode, and rollback otherwise

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17984 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoMaybe not abandon poor little cstore so much.
senator [Sat, 25 Sep 2010 00:56:24 +0000 (00:56 +0000)]
Maybe not abandon poor little cstore so much.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17982 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agomore transaction cleanups
erickson [Fri, 24 Sep 2010 23:04:45 +0000 (23:04 +0000)]
more transaction cleanups

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17980 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoclean up the fire_object_events cstore xact
erickson [Fri, 24 Sep 2010 22:23:58 +0000 (22:23 +0000)]
clean up the fire_object_events cstore xact

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17978 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoRemove confusing older targeter version; move status trimming to earlier in the process
miker [Fri, 24 Sep 2010 20:29:43 +0000 (20:29 +0000)]
Remove confusing older targeter version; move status trimming to earlier in the process

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17976 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoFix an autogrid create dialog of the kind that gets big, unusable and jumpy
senator [Fri, 24 Sep 2010 20:11:12 +0000 (20:11 +0000)]
Fix an autogrid create dialog of the kind that gets big, unusable and jumpy

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17974 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoremoved extra {}'s from where clause
erickson [Fri, 24 Sep 2010 19:30:10 +0000 (19:30 +0000)]
removed extra {}'s from where clause

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17972 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agospawn item attribute editor instead of item notes UI during process missing pieces...
phasefx [Fri, 24 Sep 2010 18:23:10 +0000 (18:23 +0000)]
spawn item attribute editor instead of item notes UI during process missing pieces workflow

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17965 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agocut-n-paste-o ... removing bad "my"
miker [Fri, 24 Sep 2010 18:08:05 +0000 (18:08 +0000)]
cut-n-paste-o ... removing bad "my"

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17963 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agodon't styled the juvenile indicator in the patron display based on age calculations...
phasefx [Fri, 24 Sep 2010 18:04:59 +0000 (18:04 +0000)]
don't styled the juvenile indicator in the patron display based on age calculations by default, just go by the juvenile flag on the user.  local CSS can restore the behavior if desired

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17958 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoput the frozen (and also empty issuance or last-copy-removed) check back in as a...
miker [Fri, 24 Sep 2010 17:56:31 +0000 (17:56 +0000)]
put the frozen (and also empty issuance or last-copy-removed) check back in as a conditional select if we found nothing mapped

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17957 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoexcise the no-potentials check, should only effect frozen holds
miker [Fri, 24 Sep 2010 17:45:49 +0000 (17:45 +0000)]
excise the no-potentials check, should only effect frozen holds

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17956 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoimprove hold targetting
gmc [Fri, 24 Sep 2010 16:37:23 +0000 (16:37 +0000)]
improve hold targetting

* all potential capturable copies are now checked (up to the first
  one that is permitted for the request), instead of a small random
  subset of them
* don't do redundant permission checks

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17954 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agothis call returns an array; fixes surprise stat cats in patron display
phasefx [Fri, 24 Sep 2010 05:48:39 +0000 (05:48 +0000)]
this call returns an array; fixes surprise stat cats in patron display

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17952 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoBe more tolerant of long-running A/T event handling for holds pull list printing
senator [Fri, 24 Sep 2010 04:45:42 +0000 (04:45 +0000)]
Be more tolerant of long-running A/T event handling for holds pull list printing

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17950 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoWe're starting to get events where ilsevent == empty string now, not just null or...
phasefx [Fri, 24 Sep 2010 02:36:55 +0000 (02:36 +0000)]
We're starting to get events where ilsevent == empty string now, not just null or a number.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17948 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agouse _session_request in RO calls
miker [Fri, 24 Sep 2010 01:47:06 +0000 (01:47 +0000)]
use _session_request in RO calls

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17946 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agocorrect the comment
miker [Fri, 24 Sep 2010 01:46:41 +0000 (01:46 +0000)]
correct the comment

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17945 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoApply some fixes that were earlier applied to the base installation script
scottmk [Fri, 24 Sep 2010 00:56:21 +0000 (00:56 +0000)]
Apply some fixes that were earlier applied to the base installation script
090.schema.action.sql, but not in an upgrade script.

Also: correct a typo (INTEVAL -> INTERVAL).  Hence this upgrade needs to go
to v2.0 as well as to trunk.

M    Open-ILS/src/sql/Pg/090.schema.action.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0418.function.action.fix-purge-circ.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17944 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoRe-commit miker's PermaCrud changes, just a tad more nicer ;-)
senator [Fri, 24 Sep 2010 00:15:31 +0000 (00:15 +0000)]
Re-commit miker's PermaCrud changes, just a tad more nicer ;-)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17941 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoStopping the leak (let us try this again)
miker [Thu, 23 Sep 2010 23:49:26 +0000 (23:49 +0000)]
Stopping the leak (let us try this again)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17939 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoreverting previous. sorry, folks
miker [Thu, 23 Sep 2010 23:47:49 +0000 (23:47 +0000)]
reverting previous. sorry, folks

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17938 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoStopping the leak
miker [Thu, 23 Sep 2010 23:38:10 +0000 (23:38 +0000)]
Stopping the leak

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17937 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoI can has authoritative for selfcheck receipts
erickson [Thu, 23 Sep 2010 23:01:06 +0000 (23:01 +0000)]
I can has authoritative for selfcheck receipts

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17935 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoIE hates the dangling comma (sometimes).
senator [Thu, 23 Sep 2010 20:59:13 +0000 (20:59 +0000)]
IE hates the dangling comma (sometimes).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17933 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agorepaired search call for user_setting. cstoreeditor uses the fieldmapper name, sos...
erickson [Thu, 23 Sep 2010 20:47:47 +0000 (20:47 +0000)]
repaired search call for user_setting. cstoreeditor uses the fieldmapper name, sos/usr/user/

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17931 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoesolving various discrepancies between a freshly built 2.0
scottmk [Thu, 23 Sep 2010 18:58:36 +0000 (18:58 +0000)]
esolving various discrepancies between a freshly built 2.0
database and an upgraded one.

M    Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17929 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agodisable holds Detail View button until the asynchronously loading details UI is ready
phasefx [Thu, 23 Sep 2010 16:35:20 +0000 (16:35 +0000)]
disable holds Detail View button until the asynchronously loading details UI is ready

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17927 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoForward-port of a patch from Steve Callendar, via James Fournie, via launchpad:
miker [Thu, 23 Sep 2010 15:38:46 +0000 (15:38 +0000)]
Forward-port of a patch from Steve Callendar, via James Fournie, via launchpad:

When the patron.password.use_phone is set, new patrons are created with their password set to the last 4 digits of their phone number, HOWEVER, when a patron's password is reset, it does not work properly. Although the little underlined summary shows the proper 4 digits, the password box displays 9-ish digits, and is not the last 4 digits of the password.

The attached patch was created by Steve Callender and is confirmed working on 1.6.0

ORIGINAL CAVEAT: This patch will not work on 2.0 as that has a new user editor, but it would presumably be worthwhile to verify this functionality works in that editor as well.

ED NOTE: Because it is possible to use the old editor -- it still exists -- this patch should be applied.  It does what it advertises to do, which is fix the old editor to follow the "use phone number" OU setting.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17922 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoDrop the never-used column item_count from acq.lineitem.
scottmk [Thu, 23 Sep 2010 15:22:29 +0000 (15:22 +0000)]
Drop the never-used column item_count from acq.lineitem.
Drop it also from the associated history table, and rebuild
the function that maintains it.  Finally, rebuild the
associated lifecycle view.

Apply to trunk only; this column never existed in 2.0.
The column has already been removed from the base installation
script.

M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0417.schema.acq.drop-lineitem-item-count.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17918 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoRename a couple of indexes (recuring -> recurring)
scottmk [Thu, 23 Sep 2010 14:31:32 +0000 (14:31 +0000)]
Rename a couple of indexes (recuring -> recurring)

M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0416.schema.rename-recuring-idx.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17917 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoDropping and recreating a foreign key constraint for config.metabib_field,
scottmk [Thu, 23 Sep 2010 13:45:06 +0000 (13:45 +0000)]
Dropping and recreating a foreign key constraint for config.metabib_field,
in order to change its name.  WHen this foreign key was first introduced,
the upgrade script gave it one name and the base install script gave it
a different name.  Here we bring the names into sync.

M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0415.schema.rename-field-class-fkey.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17915 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agofetch last updated event before comitting to stay in the xact
erickson [Thu, 23 Sep 2010 07:17:00 +0000 (07:17 +0000)]
fetch last updated event before comitting to stay in the xact

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17914 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoevent firing util code needs to run in a xact
erickson [Thu, 23 Sep 2010 05:31:03 +0000 (05:31 +0000)]
event firing util code needs to run in a xact

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17913 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoHave the CStoreEditor grow a DESTROY
miker [Thu, 23 Sep 2010 04:33:39 +0000 (04:33 +0000)]
Have the CStoreEditor grow a DESTROY

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17912 dcc99617-32d9-48b4-a31d-7c20da2025e4