working/Evergreen.git
3 years agoLP#1468422 Add libpcre to build for open-ils.auth
Bill Erickson [Fri, 24 Jul 2015 15:20:06 +0000 (11:20 -0400)]
LP#1468422 Add libpcre to build for open-ils.auth

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
3 years agoLP#1468422 open-ils.auth API salted pw changes
Bill Erickson [Wed, 22 Jul 2015 22:02:19 +0000 (18:02 -0400)]
LP#1468422 open-ils.auth API salted pw changes

Added .init.barcode and .init.username methods.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
3 years agoLP#1468422 Password storage/migration SQL getting started
Bill Erickson [Fri, 17 Jul 2015 20:00:17 +0000 (16:00 -0400)]
LP#1468422 Password storage/migration SQL getting started

* Backwards compatible salted password storage using pgcrypt
* Adds actor.passwd and actor.passwd_type tables
* Includes pgtap tests
* Includes installation of pgcrypto

Current flow:

1. Application requests a salt to use as the CHAP-style seed
2. If new-style password exists, salt is returned.
3. Else, old password is migrated and the new salt is returned.
4. App finalizes login by checking verify_passwd.

== continued...

Store the iter_count and start using the crypt_algo column.

Make it possible to change the salt, and potentially strengthen
the salt, when changing passwords.

Make is possible to start salt-less passwords, for pw's that are managed
outside of the DB.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
3 years agoLP#1333254 Improve entry debit maintenance for inv. open/close.
Bill Erickson [Thu, 25 Feb 2016 18:33:20 +0000 (13:33 -0500)]
LP#1333254 Improve entry debit maintenance for inv. open/close.

Improve handling of debit->entry links for invoices that cross the
open/close boundary, modifying the number of items invoiced on an entry,
and rolling back invoice entry debits.

Prior to this, some debits would be unnecessarily linked to entries and
fail to clean up properly when rolled back.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1333254 Support closing new invoices
Bill Erickson [Wed, 24 Feb 2016 17:35:53 +0000 (12:35 -0500)]
LP#1333254 Support closing new invoices

Allow invoices to be closed at create time (as originally intended) by
fixing code thinko.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1333254 Release notes
Bill Erickson [Mon, 4 Jan 2016 19:38:28 +0000 (14:38 -0500)]
LP#1333254 Release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1333254 Perl live tests
Bill Erickson [Mon, 4 Jan 2016 20:24:18 +0000 (15:24 -0500)]
LP#1333254 Perl live tests

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1333254 Disencumber on invoice close
Bill Erickson [Thu, 31 Dec 2015 22:35:34 +0000 (17:35 -0500)]
LP#1333254 Disencumber on invoice close

Set encumbrance=false on invoiced fund debits when the invoice is closed
(complete=true) instead of when the invoice is created.

To test:

1. Activate a purchase order.
2. Create an invoice for the PO.
3. Confirm PO shows same amount encumbered as befor invoicing and $0
   paid.
4. Close the invoice.
5. Confirm amount encumbered on the PO is reduced by the amount invoiced
   and the amount paid on the PO is increased by the amount invoiced.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1527342 Stamping upgrade script decouple checkout history
Kathy Lussier [Fri, 26 Feb 2016 00:30:05 +0000 (19:30 -0500)]
LP#1527342 Stamping upgrade script decouple checkout history

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1527342 Improve display of C/O history delete warning
Bill Erickson [Thu, 25 Feb 2016 18:52:29 +0000 (13:52 -0500)]
LP#1527342 Improve display of C/O history delete warning

Move the history warning to the top of the form for visbility and avoid
displaying the success message when the warning is also displayed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1527342 Patron CO history CSV update core type
Bill Erickson [Wed, 24 Feb 2016 15:01:06 +0000 (10:01 -0500)]
LP#1527342 Patron CO history CSV update core type

Modify circ.format.history.csv to core type of 'auch' in seed data.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1527342 Patron checkout history CSV export repair
Bill Erickson [Tue, 23 Feb 2016 15:42:27 +0000 (10:42 -0500)]
LP#1527342 Patron checkout history CSV export repair

When exporting circ history as CSV, export history objects, not
(unrelated) circ objects.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1527342 Patron checkout history table release notes
Bill Erickson [Mon, 28 Dec 2015 17:22:57 +0000 (12:22 -0500)]
LP#1527342 Patron checkout history table release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1527342 Patron checkout history PGTAP tests
Bill Erickson [Mon, 28 Dec 2015 15:43:58 +0000 (10:43 -0500)]
LP#1527342 Patron checkout history PGTAP tests

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1527342 search result history tagging
Bill Erickson [Tue, 22 Dec 2015 20:14:12 +0000 (15:14 -0500)]
LP#1527342 search result history tagging

Use circ history data to indicate circulated items in search results.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1527342 Patron checkout history TPAC display
Bill Erickson [Mon, 21 Dec 2015 16:19:19 +0000 (11:19 -0500)]
LP#1527342 Patron checkout history TPAC display

Checkout history is now derived from the new action.usr_circ_history
table.  When a patron disables circ history, all history is deleted from
the new table.  Also, when disabling circ or holds history, the patron
is now warned if data will be deleted or, in the case of holds, become
inaccessible.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1527342 Patron co history remove on purge
Bill Erickson [Wed, 30 Dec 2015 16:53:52 +0000 (11:53 -0500)]
LP#1527342 Patron co history remove on purge

Delete checkout history rows when purging a user.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1527342 Patron checkout history SQL/IDL
Bill Erickson [Fri, 18 Dec 2015 23:09:16 +0000 (18:09 -0500)]
LP#1527342 Patron checkout history SQL/IDL

Adds a new table action.usr_circ_history for tracking opt-in checkout
history.  History is maintained via trigger on action.circulation.

Includes updates to html/email/csv checkout history templates to
gracefully handle NULL checkin_time values, since history starts as soon
as an item is checked out.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1452950: add release notes
Galen Charlton [Thu, 25 Feb 2016 22:48:54 +0000 (17:48 -0500)]
LP#1452950: add release notes

Currently treating this as a technology preview; this may
change before release of 2.10.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 Patron reg pending users
Bill Erickson [Sun, 21 Feb 2016 23:43:53 +0000 (18:43 -0500)]
LP#1452950 Patron reg pending users

Support loading pending users and removing pending users after save.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 Patron reg. clone user
Bill Erickson [Thu, 18 Feb 2016 14:59:09 +0000 (09:59 -0500)]
LP#1452950 Patron reg. clone user

Implemented Save & Clone.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 date input supports null dates
Bill Erickson [Wed, 17 Feb 2016 02:40:57 +0000 (21:40 -0500)]
LP#1452950 date input supports null dates

Leave a date unset when its value is null instead of defaulting to now.
Support unsetting a date when its value is cleared.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 re-attach unload warning after click-through
Bill Erickson [Wed, 17 Feb 2016 01:56:26 +0000 (20:56 -0500)]
LP#1452950 re-attach unload warning after click-through

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 Support free-text stat cats
Bill Erickson [Sat, 23 Jan 2016 20:19:00 +0000 (15:19 -0500)]
LP#1452950 Support free-text stat cats

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 Stat cat maps store values, not links
Bill Erickson [Fri, 22 Jan 2016 03:21:15 +0000 (22:21 -0500)]
LP#1452950 Stat cat maps store values, not links

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 Remove unsaved data warning after click-thru
Bill Erickson [Sat, 16 Jan 2016 20:15:01 +0000 (15:15 -0500)]
LP#1452950 Remove unsaved data warning after click-thru

Once the user clicks through the unsaved data warning, clear the warning
for future navigation.  If more fields are changed, the warning will be
reinstated.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 Unload prompts more handlers / dupe styling
Bill Erickson [Mon, 21 Dec 2015 00:51:01 +0000 (19:51 -0500)]
LP#1452950 Unload prompts more handlers / dupe styling

Link in remaining unload onchange handlers.  Use bootstrap alert styles
for dupe patron links.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 Secondary groups dialog scrollable groups list
Bill Erickson [Sat, 16 Jan 2016 16:42:59 +0000 (11:42 -0500)]
LP#1452950 Secondary groups dialog scrollable groups list

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 Patron reg pass=phone on new patrons only
Bill Erickson [Sat, 16 Jan 2016 16:39:08 +0000 (11:39 -0500)]
LP#1452950 Patron reg pass=phone on new patrons only

When changing a patron's phone number, only modify the password for new
patrons when the org setting patron.password.use_phone is enabled.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 Patron reg avoid data re-fetch
Bill Erickson [Sat, 16 Jan 2016 16:34:44 +0000 (11:34 -0500)]
LP#1452950 Patron reg avoid data re-fetch

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 Remove dupe/doc floating div dashed border
Bill Erickson [Sat, 16 Jan 2016 16:33:38 +0000 (11:33 -0500)]
LP#1452950 Remove dupe/doc floating div dashed border

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 patron reg. unload prompt stub
Bill Erickson [Thu, 17 Dec 2015 02:11:44 +0000 (21:11 -0500)]
LP#1452950 patron reg. unload prompt stub

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 page unload warning prompt service
Bill Erickson [Thu, 17 Dec 2015 02:10:43 +0000 (21:10 -0500)]
LP#1452950 page unload warning prompt service

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 patron reg dupe links wording consistency
Bill Erickson [Thu, 10 Dec 2015 15:09:50 +0000 (10:09 -0500)]
LP#1452950 patron reg dupe links wording consistency

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 patron reg refactor alert pane
Bill Erickson [Thu, 10 Dec 2015 15:06:45 +0000 (10:06 -0500)]
LP#1452950 patron reg refactor alert pane

Create a single top-right floating alert pane which contains both the
duplicate patron links and the field documentation.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 patron dupe search links
Bill Erickson [Wed, 9 Dec 2015 16:42:50 +0000 (11:42 -0500)]
LP#1452950 patron dupe search links

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 patron dupe search / plumbing
Bill Erickson [Tue, 8 Dec 2015 21:17:40 +0000 (16:17 -0500)]
LP#1452950 patron dupe search / plumbing

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 patron reg invalidate fields
Bill Erickson [Tue, 8 Dec 2015 14:39:43 +0000 (09:39 -0500)]
LP#1452950 patron reg invalidate fields

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 patron reg secondary groups done
Bill Erickson [Mon, 23 Nov 2015 01:34:28 +0000 (20:34 -0500)]
LP#1452950 patron reg secondary groups done

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 Patron reg secondary groups part 1
Bill Erickson [Thu, 19 Nov 2015 15:04:10 +0000 (10:04 -0500)]
LP#1452950 Patron reg secondary groups part 1

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 Patron reg loading dialog; more caching
Bill Erickson [Thu, 19 Nov 2015 13:47:09 +0000 (08:47 -0500)]
LP#1452950 Patron reg loading dialog; more caching

* Hide the patron edit form and show a loading dialog while data loads.
* Cache net access levels and ident types to speed up navigation between
  patron edit and other pages within the patron app.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 patron reg code cleanup
Bill Erickson [Sat, 31 Oct 2015 17:08:02 +0000 (13:08 -0400)]
LP#1452950 patron reg code cleanup

Break up one of the bigger chunks by moving new patron defaults to its
own function.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 Field doc display repair
Bill Erickson [Sat, 31 Oct 2015 17:03:31 +0000 (13:03 -0400)]
LP#1452950 Field doc display repair

Set the current field doc via function instead of directly within the
ng-click handler.  For unknown reasons, the direct approach was not
working with addresses.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 survey dates/sorting; stat cat sorting
Bill Erickson [Fri, 30 Oct 2015 01:41:34 +0000 (21:41 -0400)]
LP#1452950 survey dates/sorting; stat cat sorting

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 pat. reg surveys and stat cats
Bill Erickson [Mon, 26 Oct 2015 02:24:16 +0000 (22:24 -0400)]
LP#1452950 pat. reg surveys and stat cats

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 pat. reg surveys and opt-in settings
Bill Erickson [Sun, 25 Oct 2015 23:37:22 +0000 (19:37 -0400)]
LP#1452950 pat. reg surveys and opt-in settings

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 patron reg additions (phone pw, hiding stuff)
Bill Erickson [Sun, 25 Oct 2015 15:42:11 +0000 (11:42 -0400)]
LP#1452950 patron reg additions (phone pw, hiding stuff)

1. Generate password from last 4 digits of phone number if library
setting is present (patron.password.use_phone).

2. Only show "replace barcode" and invlidate buttons when editing an
existing patron.

3. Address no longer defaults to within_city_limits, consistent with
dojo version.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 focus barcode field
Bill Erickson [Mon, 5 Oct 2015 00:58:35 +0000 (20:58 -0400)]
LP#1452950 focus barcode field

For new patrons, focus the barcode field.  For existing patrons, disable
the barcode field (except when a new barcode is needed) and focus the
username field by default.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 username defaults to barcode
Bill Erickson [Sun, 20 Sep 2015 14:35:51 +0000 (10:35 -0400)]
LP#1452950 username defaults to barcode

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 save/delete/modify addresses
Bill Erickson [Sun, 20 Sep 2015 14:29:53 +0000 (10:29 -0400)]
LP#1452950 save/delete/modify addresses

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 extract and save patron settings
Bill Erickson [Sun, 20 Sep 2015 13:33:12 +0000 (09:33 -0400)]
LP#1452950 extract and save patron settings

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 patron reg i18n repair; more saving
Bill Erickson [Fri, 18 Sep 2015 01:51:54 +0000 (21:51 -0400)]
LP#1452950 patron reg i18n repair; more saving

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 patron reg saving new patrons repairs
Bill Erickson [Fri, 18 Sep 2015 01:33:11 +0000 (21:33 -0400)]
LP#1452950 patron reg saving new patrons repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 patron reg new patron defaults
Bill Erickson [Fri, 18 Sep 2015 00:50:07 +0000 (20:50 -0400)]
LP#1452950 patron reg new patron defaults

Additions and repairs for default user setting values, addr type,
password, net access level, ident type, state.

Also includes repairs for barcode replacements.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 patron reg replace barcode
Bill Erickson [Thu, 17 Sep 2015 01:42:16 +0000 (21:42 -0400)]
LP#1452950 patron reg replace barcode

Replace patron barcode.  Includes duplicate barcode detection, but no
styling/warning is produced when a dupe is found, since the structure
for handling invalid form fields in patron reg does not yet exist.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 patron reg initial save operation
Bill Erickson [Mon, 14 Sep 2015 02:03:47 +0000 (22:03 -0400)]
LP#1452950 patron reg initial save operation

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 patron reg barcodes dialog
Bill Erickson [Wed, 2 Sep 2015 01:02:56 +0000 (21:02 -0400)]
LP#1452950 patron reg barcodes dialog

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 patron reg post code lookup
Bill Erickson [Mon, 31 Aug 2015 01:34:52 +0000 (21:34 -0400)]
LP#1452950 patron reg post code lookup

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 add/delete patron address
Bill Erickson [Mon, 31 Aug 2015 01:10:23 +0000 (21:10 -0400)]
LP#1452950 add/delete patron address

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 browser client patron reg additions
Bill Erickson [Thu, 20 Aug 2015 03:16:46 +0000 (23:16 -0400)]
LP#1452950 browser client patron reg additions

* generate password
* update expire date
* phone / email invalide buttons (display only)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 quiet chatty grid field logging
Bill Erickson [Thu, 20 Aug 2015 02:21:29 +0000 (22:21 -0400)]
LP#1452950 quiet chatty grid field logging

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 patron summary show/hide repair
Bill Erickson [Tue, 18 Aug 2015 13:47:20 +0000 (09:47 -0400)]
LP#1452950 patron summary show/hide repair

Recover the patron summary show/hide link, which was lost in the
fixed-position elements shuffle.  This moves the patron's name back into
the fixed bar along the top so that it's always visible, as before.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 required/suggested/all fields selectors
Bill Erickson [Sat, 15 Aug 2015 19:41:59 +0000 (15:41 -0400)]
LP#1452950 required/suggested/all fields selectors

Wire up links for Required, suggested, and All fields links.

Also move the patron control bar out to its own template since it must
be loaded from 2 different places in the markup, one for edit and one
for register.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 patron reg fixed css repair
Bill Erickson [Sun, 9 Aug 2015 20:53:02 +0000 (16:53 -0400)]
LP#1452950 patron reg fixed css repair

Use CSS-style comments within <style> blocks, not HTML comments, lest
your CSS stops working.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 Patron reg fixed navigation
Bill Erickson [Fri, 31 Jul 2015 02:38:41 +0000 (22:38 -0400)]
LP#1452950 Patron reg fixed navigation

Make the patron navigation tabs fixed.  Adds a fixed patron
edit/registration action bar.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 Register v.s. Edit patron banners
Bill Erickson [Sun, 19 Jul 2015 14:58:57 +0000 (10:58 -0400)]
LP#1452950 Register v.s. Edit patron banners

Register patron now has a page-level banner consistent w/ other
full-page UI's.  Patron edit gets a smaller header since it's nestled
under the patron tabs.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 Patrong reg. style repairs
Bill Erickson [Tue, 14 Jul 2015 23:49:58 +0000 (19:49 -0400)]
LP#1452950 Patrong reg. style repairs

* Reduce vertical space by a few pixels
* Make field labels non-bold
* Make input fields bold
* Remove duplicate padding to avoid label misalignment.
* Use blue alert-info banner along the top of the screen.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1464767 Patron edit billing => physical
Bill Erickson [Wed, 17 Jun 2015 23:58:29 +0000 (19:58 -0400)]
LP#1464767 Patron edit billing => physical

Move toward use of "Physical" label over "Billing" in browser client
patron editor.

See also LP#1068646

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1464767 Sort browser client org selector
Bill Erickson [Tue, 16 Jun 2015 01:54:44 +0000 (21:54 -0400)]
LP#1464767 Sort browser client org selector

Sort each level of the shared org unit tree in the browser client by org
unit shortname.  This primarily affects org unit selectors / dropdowns
(unless otherwise sorted).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 patron reg. UI improvements / repairs
Bill Erickson [Thu, 4 Jun 2015 01:43:45 +0000 (21:43 -0400)]
LP#1452950 patron reg. UI improvements / repairs

 * floating save, clone, etc pane arranged vertically with less padding.
 * reduce vertical spacing between fields
 * alert_message field rendered as textarea
 * avoid showing 'Example:' label when no phone example exists.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1452950 angularize patron registration phase I
Bill Erickson [Mon, 4 May 2015 01:19:51 +0000 (21:19 -0400)]
LP#1452950 angularize patron registration phase I

Replace legacy Dojo patron registration / edit UI's in the browser
client with an initial cut of an Angular version.  For this commit, the
UI is basically a wireframe, but the selectors display values and
most fields display the correct values set on the patron.

No save or clone etc. operations or data validation are functional.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
3 years agoLP#1206936 Base SQL schema repair
Bill Erickson [Thu, 25 Feb 2016 20:47:20 +0000 (15:47 -0500)]
LP#1206936 Base SQL schema repair

Avoid referencing money.materialized_billable_xact_summary before it's
defined.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1501516 'paid' lineitem release notes
Bill Erickson [Mon, 12 Oct 2015 19:54:02 +0000 (15:54 -0400)]
LP#1501516 'paid' lineitem release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Christine Burns <christine.burns@bc.libraries.coop>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1501516 PO lineitem 'paid' indicator
Bill Erickson [Thu, 1 Oct 2015 15:51:43 +0000 (11:51 -0400)]
LP#1501516 PO lineitem 'paid' indicator

Display a new "paid" label for each lineitem within a purchase
order whose items have all been invoiced (or canceled).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Christine Burns <christine.burns@bc.libraries.coop>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP1402770: Do not show Holds Count by default in most item screens
Kathy Lussier [Thu, 25 Feb 2016 04:33:51 +0000 (23:33 -0500)]
LP1402770: Do not show Holds Count by default in most item screens

The Holds Count columns was displaying by default in many xul item interfaces
where this info may not be as useful for staff. Let's hide them by default
in most column pickers, and only display it by default in the patron's Items
Out tab.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
3 years agoLP1402770: Release notes entry for holds count column picker
Kathy Lussier [Thu, 25 Feb 2016 03:49:17 +0000 (22:49 -0500)]
LP1402770: Release notes entry for holds count column picker

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
3 years agoLP1402770_column_picker_option_for_number_of_holds
blake [Mon, 20 Jul 2015 15:11:22 +0000 (10:11 -0500)]
LP1402770_column_picker_option_for_number_of_holds

Added a virtual IDL defintion. Added a OpenSRF method to return
the number of holds that a copy is a member of action.hold_copy_map.
Added javascript column definition to surface this in the xul staff client.
Added the column in the web based staff client as well.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Andrea Neiman <aneiman@kent.lib.md.us>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
3 years agoLP#1206936 Stamping upgrade script; adding test
Dan Wells [Wed, 24 Feb 2016 19:27:15 +0000 (14:27 -0500)]
LP#1206936 Stamping upgrade script; adding test

Signed-off-by: Dan Wells <dbw2@calvin.edu>
3 years agoLP#1206936 - Fix wrong billing info in money.transaction_billing_summary
Chris Sharp [Mon, 30 Nov 2015 14:48:26 +0000 (09:48 -0500)]
LP#1206936 - Fix wrong billing info in money.transaction_billing_summary

The money.transaction_billing_summary view was showing the wrong
last billing type and last billing note for certain transactions.
This fix, from Dan Scott, in turn from Mike Rylander, recreates
that view so that it depends on the speedier and more accurate
money.materialized_billable_xact_summary view.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
3 years agoLP#1526546 Sort copies by part label in holdings maint.
Remington Steed [Wed, 16 Dec 2015 20:46:17 +0000 (15:46 -0500)]
LP#1526546 Sort copies by part label in holdings maint.

This commit improves the sorting of copies on the Holdings Maintenance
screen in the XUL-based staff client. The previous code sorted the
copies by their barcodes after retrieval. This commit moves the sorting
logic into the search call and adds logic to first sort by the part
label sort key.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
3 years agoLP#1505286: stamping upgrade script for limit facets retrieved
Ben Shum [Wed, 24 Feb 2016 04:50:11 +0000 (23:50 -0500)]
LP#1505286: stamping upgrade script for limit facets retrieved

Signed-off-by: Ben Shum <ben@evergreener.net>
3 years agoLP#1505286: add release notes
Galen Charlton [Fri, 23 Oct 2015 17:18:19 +0000 (17:18 +0000)]
LP#1505286: add release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
3 years agoLP#1505286: add pgTAP tests
Galen Charlton [Fri, 23 Oct 2015 17:04:17 +0000 (17:04 +0000)]
LP#1505286: add pgTAP tests

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
3 years agoLP#1505286: limit number of facets retrieved
Galen Charlton [Fri, 23 Oct 2015 16:29:38 +0000 (16:29 +0000)]
LP#1505286: limit number of facets retrieved

This patch teaches search how to limit the number of facets retrieved
per defined facet field. Setting a limit is useful so that
open-ils.cstore backends don't end up needlessly consuming
memory when fetching facets for a large result set; if a broad
search retrieves over 10,000 author facets (say), even the most
persistant user is not going to actually look at all of them. Fetching
fewer facets can also slightly speed up generation of search
results.

The limit is controlled by a new global flag, search.max_facets_per_field,
whose label is "Search: maximum number of facet values to retrieve for
each facet field".  The default limit value is 1,000, but lower values
(e.g., 100) are perhaps even better for most catalogs.

To test:

[1] Upon applying the patch, set the value of the
    search.max_facets_per_field global flag to a small
    value.
[2] Perform some searches and verify that the number
    of facets retrieved doesn't exceed the limit; note
    that the limit is per facet *field*, not overall
    or per field class.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
3 years agoLP#1545178: remove two unused methods
Galen Charlton [Fri, 12 Feb 2016 22:10:25 +0000 (17:10 -0500)]
LP#1545178: remove two unused methods

This patch removes two methods that were both broken
and not in use:

  * open-ils.actor.org_unit.closed_date.create
  * open-ils.actor.org_unit.closed_date.delete

To test:

[1] This patch has no user-visible impact whatsoever, but
    to check for regressions, verify the proper functioning
    of the closed dates editor.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
3 years agoLP#1466990: Detailed search results shows parts for items that dont have parts
blake [Wed, 23 Dec 2015 20:20:40 +0000 (14:20 -0600)]
LP#1466990: Detailed search results shows parts for items that dont have parts

The part_label variable needs to be reset between iterations. The variable was still set
and bled from copy to copy. Testing this will require a search with details turned on.
The search result set needs to include a bib that has copies with parts (with at least
one copy invisible) and another bib that has copies without parts.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
3 years agoLP#1474051 Stamping upgrade script for drop-cc-data
Kathy Lussier [Fri, 19 Feb 2016 17:41:43 +0000 (12:41 -0500)]
LP#1474051 Stamping upgrade script for drop-cc-data

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1474051 Release/Upgrade Notes on dropped CC fields
Bill Erickson [Mon, 13 Jul 2015 19:29:25 +0000 (15:29 -0400)]
LP#1474051 Release/Upgrade Notes on dropped CC fields

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1474051 CRON script for clearing CC numbers
Bill Erickson [Wed, 14 Oct 2015 15:59:32 +0000 (11:59 -0400)]
LP#1474051 CRON script for clearing CC numbers

Adds a new srfsh script which calls a new open-ils.storage API call
which sets the cc_number value to NULL on all credit card payments
older than the age specified in the srfsh script.

Adds example CRON entry.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1474051 PGTAP test checking dropped columns
Bill Erickson [Mon, 13 Jul 2015 19:19:35 +0000 (15:19 -0400)]
LP#1474051 PGTAP test checking dropped columns

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1474051 Drop unneeded CC payment fields
Bill Erickson [Mon, 13 Jul 2015 18:00:06 +0000 (14:00 -0400)]
LP#1474051 Drop unneeded CC payment fields

Avoid storing the following credit card fields:

expire month
expire year
first name
last name
credit card type

Print and email receipts for credit card data modified to avoid
referencing these fields.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoPorting 2.8.4-2.8.5 / 2.8.5-2.8.6 DB upgrade scripts
Bill Erickson [Fri, 19 Feb 2016 17:35:42 +0000 (12:35 -0500)]
Porting 2.8.4-2.8.5 / 2.8.5-2.8.6 DB upgrade scripts

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoForward port 2.9.1 to 2.9.2 upgrade script and server upgrade instructions.
Jason Stephenson [Fri, 19 Feb 2016 17:00:24 +0000 (12:00 -0500)]
Forward port 2.9.1 to 2.9.2 upgrade script and server upgrade instructions.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
3 years agoLP#1202742 non-active copy transit release notes
Bill Erickson [Mon, 4 Aug 2014 13:16:41 +0000 (09:16 -0400)]
LP#1202742 non-active copy transit release notes

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1202742 Non-active transit copy status messages
Bill Erickson [Thu, 18 Jul 2013 15:17:23 +0000 (11:17 -0400)]
LP#1202742 Non-active transit copy status messages

When an in-transit copy is checked into the staff client, display a special
message in the transit alert dialog and in the printed transit receipt
(optionally, via macro) if the copy is in (or, rather, will be once it
arrives at its destination) a non-active copy status.

See config.copy_status.copy_active.

For example, assuming the org unit setting 'circ.lost_immediately_available'
is unset, when a Lost copy is checked in that must transit home, the
following message will appear in the transit alert dialog:

This item is in status "Lost", additional staff action may be required.

Additionally, the value of the 'transit_copy_status_msg' macro, which
defaults to "", will be set to this message, so that the message may
appear in printed transit slips.

Note that the code will test for the presence of the
"staff.circ.utils.transit.copy_status_message" string property and fail
gracefully if it is unset.  Through this, admins can disable this
feature entirely.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1486151 Stamping upgrade script for password reset regex description
Kathy Lussier [Thu, 18 Feb 2016 23:51:33 +0000 (18:51 -0500)]
LP#1486151 Stamping upgrade script for password reset regex description

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1013786 TPAC add reminder to modify update_pasword_msg.tt2 to global.password_regex
Michael Peters [Tue, 18 Aug 2015 16:49:10 +0000 (12:49 -0400)]
LP#1013786 TPAC add reminder to modify update_pasword_msg.tt2 to global.password_regex

Currently, libraries can configure their own password strength regular expressions
via the Library Settings Editor.  This, however, did not provide a reminder
that the message shown to the patron when resetting their password needed to
meet those requirements.

This patch provides a hint in the description of the YAOUS global.password_regex
to remind that update_password_msg.tt2 should be updated with a user-friendly
text string explaining the password requirements if they are changed from the default.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off by: Christine Burns <christine.burns@bc.libraries.coop>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1380709 Stamping upgrade script for fund debit invoice links
Kathy Lussier [Thu, 18 Feb 2016 17:58:03 +0000 (12:58 -0500)]
LP#1380709 Stamping upgrade script for fund debit invoice links

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1367926 Stamping upgrade script for direct access to full unapi backend
Kathy Lussier [Thu, 18 Feb 2016 17:53:19 +0000 (12:53 -0500)]
LP#1367926 Stamping upgrade script for direct access to full unapi backend

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
3 years agoLP#1380709 Renaming live-t test to avoid duplicate numbers
Kathy Lussier [Thu, 18 Feb 2016 16:50:56 +0000 (11:50 -0500)]
LP#1380709 Renaming live-t test to avoid duplicate numbers

Signed-off-by: Kathy Lussier <klussier@masslnc.org>