]> git.evergreen-ils.org Git - working/Evergreen.git/commit
LP 115706: Avoid Internal Server Errors with Hold Count Retrieval user/cesardv/lp1155706_holdcount_avoid_server_error_500_rebase
authorJason Stephenson <jason@sigio.com>
Tue, 7 Aug 2018 14:02:10 +0000 (10:02 -0400)
committerCesar Velez <cesar.velez@equinoxinitiative.org>
Fri, 24 May 2019 21:23:23 +0000 (17:23 -0400)
commit3743dc2e267e10b5739afab476359f44f867ab62
tree755da78018faf95ea457198f0c1fa4b76813b0a5
parent1adb00509209c3ebd223701612b1f2692b17e3bc
LP 115706: Avoid Internal Server Errors with Hold Count Retrieval

It can happen that the query to get a record's hold count can run too
long and timeout or fail for some other reason.  When this happens,
the user sees an Internal Server Error.  The underlying cause is the
following Perl error:

Can't use an undefined value as an ARRAY reference at
/usr/local/share/perl/5.22.1/OpenILS/Application/Circ/Holds.pm line
4264.

This commit rearranges the code around that line to avoid this
particular undefined value reference error.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm