]> git.evergreen-ils.org Git - working/Evergreen.git/commit
Correctly mark nested INNER joins as such
authorMike Rylander <mrylander@gmail.com>
Wed, 14 Aug 2013 14:25:14 +0000 (10:25 -0400)
committerMike Rylander <mrylander@gmail.com>
Thu, 22 Aug 2013 15:38:05 +0000 (11:38 -0400)
commit80e3f6f63a6e8ce422e6b2e1f7c981a7c2e5ff49
tree6c2c84eb478594b447fe24dc6751aeccc88d3864
parentfb37e15ec7476be5a8c772595d613853e3e11019
Correctly mark nested INNER joins as such

We've been adopting containing the JOINs flavor, and then
attempting to use IS NOT NULL to restrict NULL-ness
in the WHERE clause.  This is almost right, but not quite,
and was done in an attempt to match behavior with the
expectations of users that are not SQL experts.  However,
right is better than "looks right most of the time", so
we use the proper join type now.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Boyer <jboyer1@library.in.gov>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Open-ILS/src/perlmods/lib/OpenILS/Reporter/SQLBuilder.pm