]> git.evergreen-ils.org Git - working/Evergreen.git/commit
Patch from Joe Atzberger: Cleanup subs in Actor
authorerickson <erickson@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Thu, 1 Apr 2010 19:09:33 +0000 (19:09 +0000)
committererickson <erickson@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Thu, 1 Apr 2010 19:09:33 +0000 (19:09 +0000)
commit75f644c50d6b13aa121a4a25543e76e27919e1fa
treec7d5918dd64f3ac5a9d2be04eacd75f424a48ca7
parenta5dd0b2497b0096929d32934e41c0da7e974250a
Patch from Joe Atzberger:  Cleanup subs in Actor

For the first, @xact was never used.
The 3 part conditional only had two different outcomes.
There is still a problem with user_transactions reproducing a lot
of the functionality of user_transaction_history, which it already
calls to do the real query.  But it doesn't reproduce all of it.
Recommend relying on user_transaction_history as much as possible,
but that kind of work is out of scope for this review.

For the other, remove unused var and unnecessary array.
You don't need to build an array when all you do at the end is count its elements.

Signed-off-by: Joe Atzberger <atz@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16092 dcc99617-32d9-48b4-a31d-7c20da2025e4
Open-ILS/src/perlmods/OpenILS/Application/Actor.pm